cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

redfish_command: Avoid power on/off commands if system already in target state (#56069)

Browse source 
* avoid power on/off commands if system already in target state

* add changelog fragment
This commit is contained in:
Bill Dodd 2019-06-10 02:50:04 -05:00 committed by René Moser
parent d86183f595
commit e5972ccbab
2 changed files with 11 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
changelogs/fragments/56069-make-redfish-power-commands-idempotent.yaml Normal file
View file

@ -0,0 +1,3 @@
---
bugfixes:
- redfish_command - make power commands idempotent (https://github.com/ansible/ansible/issues/55869)

12
lib/ansible/module_utils/redfish_utils.py
View file

@ -620,16 +620,21 @@ class RedfishUtils(object):
return result
def manage_system_power(self, command):
result = {}
key = "Actions"
# Search for 'key' entry and extract URI from it
response = self.get_request(self.root_uri + self.systems_uris[0])
if response['ret'] is False:
return response
result['ret'] = True
data = response['data']
power_state = data["PowerState"]
if power_state == "On" and command == 'PowerOn':
return {'ret': True, 'changed': False}
if power_state == "Off" and command in ['PowerGracefulShutdown', 'PowerForceOff']:
return {'ret': True, 'changed': False}
reset_action = data[key]["#ComputerSystem.Reset"]
action_uri = reset_action["target"]
allowable_vals = reset_action.get("ResetType@Redfish.AllowableValues", [])
@ -657,8 +662,7 @@ class RedfishUtils(object):
response = self.post_request(self.root_uri + action_uri, payload)
if response['ret'] is False:
return response
result['ret'] = True
return result
return {'ret': True, 'changed': True}
def list_users(self):
result = {}