Enos connection issue (#32895)

* Changes due to connection issues

* Adding changes pertaining to connection issue of Ansible

* Review comments of Kedar

* Adding EOL PyLint issue

* Fixing pep8  and yamlint issues

lib/ansible/module_utils/enos.py

@@ -35,6 +35,7 @@ from ansible.module_utils._text import to_text
 from ansible.module_utils.basic import env_fallback, return_values
 from ansible.module_utils.network_common import to_list, EntityCollection
 from ansible.module_utils.connection import Connection, exec_command
+from ansible.module_utils.connection import ConnectionError
 
 _DEVICE_CONFIGS = {}
 _CONNECTION = None
@@ -75,7 +76,7 @@ def get_connection(module):
     global _CONNECTION
     if _CONNECTION:
         return _CONNECTION
-    _CONNECTION = Connection(module)
+    _CONNECTION = Connection(module._socket_path)
 
     context = None
     try:
@@ -144,8 +145,11 @@ def run_commands(module, commands, check_rc=True):
 
 
 def load_config(module, config):
-    conn = get_connection(module)
+    try:
-    conn.edit_config(config)
+        conn = get_connection(module)
+        conn.edit_config(config)
+    except ConnectionError as exc:
+        module.fail_json(msg=to_text(exc))
 
 
 def get_defaults_flag(module):

lib/ansible/modules/network/enos/enos_facts.py

@@ -235,7 +235,9 @@ class Hardware(FactsBase):
 
     def populate(self):
         super(Hardware, self).populate()
-        data = self.responses[0]
+        data = self.run(['show system memory'])
+        data = to_text(data, errors='surrogate_or_strict').strip()
+        data = data.replace(r"\n", "\n")
         if data:
             self.facts['memtotal_mb'] = self.parse_memtotal(data)
             self.facts['memfree_mb'] = self.parse_memfree(data)

lib/ansible/plugins/action/enos.py

@@ -53,45 +53,31 @@ except ImportError:
 class ActionModule(_ActionModule):
 
     def run(self, tmp=None, task_vars=None):
+        if self._play_context.connection == 'local':
+            provider = load_provider(enos_provider_spec, self._task.args)
+            pc = copy.deepcopy(self._play_context)
+            pc.connection = 'network_cli'
+            pc.network_os = 'enos'
+            pc.remote_addr = provider['host'] or self._play_context.remote_addr
+            pc.port = provider['port'] or self._play_context.port or 22
+            pc.remote_user = provider['username'] or self._play_context.connection_user
+            pc.password = provider['password'] or self._play_context.password
+            pc.private_key_file = provider['ssh_keyfile'] or self._play_context.private_key_file
+            pc.timeout = int(provider['timeout'] or C.PERSISTENT_COMMAND_TIMEOUT)
+            pc.become = provider['authorize'] or True
+            pc.become_pass = provider['auth_pass']
+            pc.become_method = 'enable'
 
-        if self._play_context.connection != 'local':
+            display.vvv('using connection plugin %s' % pc.connection, pc.remote_addr)
-            return dict(
+            connection = self._shared_loader_obj.connection_loader.get('persistent', pc, sys.stdin)
-                failed=True,
+            socket_path = connection.run()
-                msg='invalid connection specified, expected connection=local, '
+            display.vvvv('socket_path: %s' % socket_path, pc.remote_addr)
-                    'got %s' % self._play_context.connection
+            if not socket_path:
-            )
+                return {'failed': True,
-        provider = load_provider(enos_provider_spec, self._task.args)
+                        'msg': 'unable to open shell. Please see: ' +
+                               'https://docs.ansible.com/ansible/network_debug_troubleshooting.html#unable-to-open-shell'}
 
-        pc = copy.deepcopy(self._play_context)
+            task_vars['ansible_socket'] = socket_path
-        pc.connection = 'network_cli'
-        pc.network_os = 'enos'
-        pc.remote_addr = provider['host'] or self._play_context.remote_addr
-        display.vvvv('remote_addr: %s' % pc.remote_addr)
-        pc.port = provider['port'] or self._play_context.port or 22
-        pc.remote_user = provider['username'] or self._play_context.connection_user
-        pc.password = provider['password'] or self._play_context.password
-        pc.private_key_file = provider['ssh_keyfile'] or self._play_context.private_key_file
-        pc.timeout = int(provider['timeout'] or C.PERSISTENT_COMMAND_TIMEOUT)
-
-        pc.become = provider['authorize'] or True
-        pc.become_pass = provider['auth_pass']
-
-        display.vvv('using connection plugin %s' % pc.connection, pc.remote_addr)
-        connection = self._shared_loader_obj.connection_loader.get('persistent', pc, sys.stdin)
-
-        socket_path = connection.run()
-
-        display.vvvv('socket_path: %s' % socket_path, pc.remote_addr)
-        if not socket_path:
-            return {'failed': True,
-                    'msg': 'unable to open shell. Please see: ' +
-                           'https://docs.ansible.com/ansible/network_debug_troubleshooting.html#unable-to-open-shell'}
-
-        task_vars['ansible_socket'] = socket_path
-
-        if self._play_context.become_method == 'enable':
-            self._play_context.become = False
-            self._play_context.become_method = None
 
         result = super(ActionModule, self).run(tmp, task_vars)
         return result