cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Revert "Merge branch 'slow_ssh' of git://github.com/lberruti/ansible into lberruti-slow_ssh"

Browse source 
This reverts commit fe091ec00d, reversing
changes made to aed2194b1d.
This commit is contained in:
James Tanner 2014-01-30 16:02:05 -05:00
parent 9574f89471
commit e6aeb191d5
2 changed files with 28 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
lib/ansible/runner/connection_plugins/ssh.py
View file

@ -272,7 +272,6 @@ class Connection(object):
raise errors.AnsibleError('SSH Error: data could not be sent to the remote host. Make sure this host can be reached over ssh')
while True:
rfd, wfd, efd = select.select(rpipes, [], rpipes, 1)
process_over = p.poll() is not None
# fail early if the sudo/su password is wrong
if self.runner.sudo and sudoable and self.runner.sudo_pass:
@ -288,11 +287,22 @@ class Connection(object):
raise errors.AnsibleError('Incorrect su password')
if p.stdout in rfd:
stdout += os.read(p.stdout.fileno(), 9000)
dat = os.read(p.stdout.fileno(), 9000)
stdout += dat
if dat == '':
rpipes.remove(p.stdout)
if p.stderr in rfd:
stderr += os.read(p.stderr.fileno(), 9000)
if process_over:
dat = os.read(p.stderr.fileno(), 9000)
stderr += dat
if dat == '':
rpipes.remove(p.stderr)
# only break out if we've emptied the pipes, or there is nothing to
# read from and the process has finished.
if (not rpipes or not rfd) and p.poll() is not None:
break
# Calling wait while there are still pipes to read can cause a lock
elif not rpipes and p.poll() == None:
p.wait()
stdin.close() # close stdin after we read from stdout (see also issue #848)
if C.HOST_KEY_CHECKING and not_in_host_file:

18
lib/ansible/runner/connection_plugins/ssh_old.py
View file

@ -230,7 +230,6 @@ class Connection(object):
rpipes = [p.stdout, p.stderr]
while True:
rfd, wfd, efd = select.select(rpipes, [], rpipes, 1)
process_over = p.poll() is not None
# fail early if the sudo/su password is wrong
if self.runner.sudo and sudoable and self.runner.sudo_pass:
@ -246,11 +245,22 @@ class Connection(object):
raise errors.AnsibleError('Incorrect su password')
if p.stdout in rfd:
stdout += os.read(p.stdout.fileno(), 9000)
dat = os.read(p.stdout.fileno(), 9000)
stdout += dat
if dat == '':
rpipes.remove(p.stdout)
if p.stderr in rfd:
stderr += os.read(p.stderr.fileno(), 9000)
if process_over:
dat = os.read(p.stderr.fileno(), 9000)
stderr += dat
if dat == '':
rpipes.remove(p.stderr)
# only break out if we've emptied the pipes, or there is nothing to
# read from and the process has finished.
if (not rpipes or not rfd) and p.poll() is not None:
break
# Calling wait while there are still pipes to read can cause a lock
elif not rpipes and p.poll() == None:
p.wait()
stdin.close() # close stdin after we read from stdout (see also issue #848)
if C.HOST_KEY_CHECKING and not_in_host_file: