Redo #50208 on a per-plugin basis

changelogs/fragments/50248-fix-coonfig-backup-glob.yaml

@@ -0,0 +1,4 @@
+bugfixes:
+- Change backup file globbing for network _config modules so backing up one host's config
+  will not delete the backed up config of any host whose hostname is a subset of the first
+  host's hostname (e.g., switch1 and switch11)

lib/ansible/plugins/action/aireos_config.py

@@ -71,7 +71,7 @@ class ActionModule(_ActionModule):
         backup_path = self._get_working_path() + '/backup'
         if not os.path.exists(backup_path):
             os.mkdir(backup_path)
-        for fn in glob.glob('%s/%s*' % (backup_path, host)):
+        for fn in glob.glob('%s/%s_config.*' % (backup_path, host)):
             os.remove(fn)
         tstamp = time.strftime("%Y-%m-%d@%H:%M:%S", time.localtime(time.time()))
         filename = '%s/%s_config.%s' % (backup_path, host, tstamp)

lib/ansible/plugins/action/aruba_config.py

@@ -71,7 +71,7 @@ class ActionModule(_ActionModule):
         backup_path = self._get_working_path() + '/backup'
         if not os.path.exists(backup_path):
             os.mkdir(backup_path)
-        for fn in glob.glob('%s/%s*' % (backup_path, host)):
+        for fn in glob.glob('%s/%s_config.*' % (backup_path, host)):
             os.remove(fn)
         tstamp = time.strftime("%Y-%m-%d@%H:%M:%S", time.localtime(time.time()))
         filename = '%s/%s_config.%s' % (backup_path, host, tstamp)

lib/ansible/plugins/action/asa_config.py

@@ -71,7 +71,7 @@ class ActionModule(_ActionModule):
         backup_path = self._get_working_path() + '/backup'
         if not os.path.exists(backup_path):
             os.mkdir(backup_path)
-        for fn in glob.glob('%s/%s*' % (backup_path, host)):
+        for fn in glob.glob('%s/%s_config.*' % (backup_path, host)):
             os.remove(fn)
         tstamp = time.strftime("%Y-%m-%d@%H:%M:%S", time.localtime(time.time()))
         filename = '%s/%s_config.%s' % (backup_path, host, tstamp)

lib/ansible/plugins/action/ce_config.py

@@ -71,7 +71,7 @@ class ActionModule(_ActionModule):
         backup_path = self._get_working_path() + '/backup'
         if not os.path.exists(backup_path):
             os.mkdir(backup_path)
-        for fn in glob.glob('%s/%s*' % (backup_path, host)):
+        for fn in glob.glob('%s/%s_config.*' % (backup_path, host)):
             os.remove(fn)
         tstamp = time.strftime("%Y-%m-%d@%H:%M:%S", time.localtime(time.time()))
         filename = '%s/%s_config.%s' % (backup_path, host, tstamp)

lib/ansible/plugins/action/cnos_config.py

@@ -67,7 +67,7 @@ class ActionModule(_ActionModule):
         backup_path = self._get_working_path() + '/backup'
         if not os.path.exists(backup_path):
             os.mkdir(backup_path)
-        for fn in glob.glob('%s/%s*' % (backup_path, host)):
+        for fn in glob.glob('%s/%s_config.*' % (backup_path, host)):
             os.remove(fn)
         tstamp = time.strftime("%Y-%m-%d@%H:%M:%S", time.localtime(time.time()))
         filename = '%s/%s_config.%s' % (backup_path, host, tstamp)

lib/ansible/plugins/action/dellos10_config.py

@@ -73,7 +73,7 @@ class ActionModule(_ActionModule):
         backup_path = self._get_working_path() + '/backup'
         if not os.path.exists(backup_path):
             os.mkdir(backup_path)
-        for fn in glob.glob('%s/%s*' % (backup_path, host)):
+        for fn in glob.glob('%s/%s_config.*' % (backup_path, host)):
             os.remove(fn)
         tstamp = time.strftime("%Y-%m-%d@%H:%M:%S", time.localtime(time.time()))
         filename = '%s/%s_config.%s' % (backup_path, host, tstamp)

lib/ansible/plugins/action/dellos6_config.py

@@ -70,7 +70,7 @@ class ActionModule(_ActionModule):
         backup_path = self._get_working_path() + '/backup'
         if not os.path.exists(backup_path):
             os.mkdir(backup_path)
-        for fn in glob.glob('%s/%s*' % (backup_path, host)):
+        for fn in glob.glob('%s/%s_config.*' % (backup_path, host)):
             os.remove(fn)
         tstamp = time.strftime("%Y-%m-%d@%H:%M:%S", time.localtime(time.time()))
         filename = '%s/%s_config.%s' % (backup_path, host, tstamp)

lib/ansible/plugins/action/dellos9_config.py

@@ -73,7 +73,7 @@ class ActionModule(_ActionModule):
         backup_path = self._get_working_path() + '/backup'
         if not os.path.exists(backup_path):
             os.mkdir(backup_path)
-        for fn in glob.glob('%s/%s*' % (backup_path, host)):
+        for fn in glob.glob('%s/%s_config.*' % (backup_path, host)):
             os.remove(fn)
         tstamp = time.strftime("%Y-%m-%d@%H:%M:%S", time.localtime(time.time()))
         filename = '%s/%s_config.%s' % (backup_path, host, tstamp)

lib/ansible/plugins/action/edgeos_config.py

@@ -73,7 +73,7 @@ class ActionModule(_ActionModule):
         backup_path = self._get_working_path() + '/backup'
         if not os.path.exists(backup_path):
             os.mkdir(backup_path)
-        for fn in glob.glob('%s/%s*' % (backup_path, host)):
+        for fn in glob.glob('%s/%s_config.*' % (backup_path, host)):
             os.remove(fn)
         tstamp = time.strftime("%Y-%m-%d@%H:%M:%S", time.localtime(time.time()))
         filename = '%s/%s_config.%s' % (backup_path, host, tstamp)

lib/ansible/plugins/action/enos_config.py

@@ -68,7 +68,7 @@ class ActionModule(_ActionModule):
         backup_path = self._get_working_path() + '/backup'
         if not os.path.exists(backup_path):
             os.mkdir(backup_path)
-        for fn in glob.glob('%s/%s*' % (backup_path, host)):
+        for fn in glob.glob('%s/%s_config.*' % (backup_path, host)):
             os.remove(fn)
         tstamp = time.strftime("%Y-%m-%d@%H:%M:%S", time.localtime(time.time()))
         filename = '%s/%s_config.%s' % (backup_path, host, tstamp)

lib/ansible/plugins/action/eos_config.py

@@ -72,7 +72,7 @@ class ActionModule(_ActionModule):
         backup_path = self._get_working_path() + '/backup'
         if not os.path.exists(backup_path):
             os.mkdir(backup_path)
-        for fn in glob.glob('%s/%s*' % (backup_path, host)):
+        for fn in glob.glob('%s/%s_config.*' % (backup_path, host)):
             os.remove(fn)
         tstamp = time.strftime("%Y-%m-%d@%H:%M:%S", time.localtime(time.time()))
         filename = '%s/%s_config.%s' % (backup_path, host, tstamp)

lib/ansible/plugins/action/exos_config.py

@@ -72,7 +72,7 @@ class ActionModule(_ActionModule):
         backup_path = self._get_working_path() + '/backup'
         if not os.path.exists(backup_path):
             os.mkdir(backup_path)
-        for fn in glob.glob('%s/%s*' % (backup_path, host)):
+        for fn in glob.glob('%s/%s_config.*' % (backup_path, host)):
             os.remove(fn)
         tstamp = time.strftime("%Y-%m-%d@%H:%M:%S", time.localtime(time.time()))
         filename = '%s/%s_config.%s' % (backup_path, host, tstamp)

lib/ansible/plugins/action/ios_config.py

@@ -71,7 +71,7 @@ class ActionModule(_ActionModule):
         backup_path = self._get_working_path() + '/backup'
         if not os.path.exists(backup_path):
             os.mkdir(backup_path)
-        for fn in glob.glob('%s/%s*' % (backup_path, host)):
+        for fn in glob.glob('%s/%s_config.*' % (backup_path, host)):
             os.remove(fn)
         tstamp = time.strftime("%Y-%m-%d@%H:%M:%S", time.localtime(time.time()))
         filename = '%s/%s_config.%s' % (backup_path, host, tstamp)

lib/ansible/plugins/action/iosxr_config.py

@@ -71,7 +71,7 @@ class ActionModule(_ActionModule):
         backup_path = self._get_working_path() + '/backup'
         if not os.path.exists(backup_path):
             os.mkdir(backup_path)
-        for fn in glob.glob('%s/%s*' % (backup_path, host)):
+        for fn in glob.glob('%s/%s_config.*' % (backup_path, host)):
             os.remove(fn)
         tstamp = time.strftime("%Y-%m-%d@%H:%M:%S", time.localtime(time.time()))
         filename = '%s/%s_config.%s' % (backup_path, host, tstamp)

lib/ansible/plugins/action/ironware_config.py

@@ -71,7 +71,7 @@ class ActionModule(_ActionModule):
         backup_path = self._get_working_path() + '/backup'
         if not os.path.exists(backup_path):
             os.mkdir(backup_path)
-        for fn in glob.glob('%s/%s*' % (backup_path, host)):
+        for fn in glob.glob('%s/%s_config.*' % (backup_path, host)):
             os.remove(fn)
         tstamp = time.strftime("%Y-%m-%d@%H:%M:%S", time.localtime(time.time()))
         filename = '%s/%s_config.%s' % (backup_path, host, tstamp)

lib/ansible/plugins/action/junos_config.py

@@ -71,7 +71,7 @@ class ActionModule(_ActionModule):
         backup_path = self._get_working_path() + '/backup'
         if not os.path.exists(backup_path):
             os.mkdir(backup_path)
-        for fn in glob.glob('%s/%s*' % (backup_path, host)):
+        for fn in glob.glob('%s/%s_config.*' % (backup_path, host)):
             os.remove(fn)
         tstamp = time.strftime("%Y-%m-%d@%H:%M:%S", time.localtime(time.time()))
         filename = '%s/%s_config.%s' % (backup_path, host, tstamp)

lib/ansible/plugins/action/net_config.py

@@ -71,7 +71,7 @@ class ActionModule(_ActionModule):
         backup_path = self._get_working_path() + '/backup'
         if not os.path.exists(backup_path):
             os.mkdir(backup_path)
-        for fn in glob.glob('%s/%s*' % (backup_path, host)):
+        for fn in glob.glob('%s/%s_config.*' % (backup_path, host)):
             os.remove(fn)
         tstamp = time.strftime("%Y-%m-%d@%H:%M:%S", time.localtime(time.time()))
         filename = '%s/%s_config.%s' % (backup_path, host, tstamp)

lib/ansible/plugins/action/netconf_config.py

@@ -69,7 +69,7 @@ class ActionModule(_ActionModule):
         backup_path = self._get_working_path() + '/backup'
         if not os.path.exists(backup_path):
             os.mkdir(backup_path)
-        for fn in glob.glob('%s/%s*' % (backup_path, host)):
+        for fn in glob.glob('%s/%s_config.*' % (backup_path, host)):
             os.remove(fn)
         tstamp = time.strftime("%Y-%m-%d@%H:%M:%S", time.localtime(time.time()))
         filename = '%s/%s_config.%s' % (backup_path, host, tstamp)

lib/ansible/plugins/action/nos_config.py

@@ -71,7 +71,7 @@ class ActionModule(_ActionModule):
         backup_path = self._get_working_path() + '/backup'
         if not os.path.exists(backup_path):
             os.mkdir(backup_path)
-        for fn in glob.glob('%s/%s*' % (backup_path, host)):
+        for fn in glob.glob('%s/%s_config.*' % (backup_path, host)):
             os.remove(fn)
         tstamp = time.strftime("%Y-%m-%d@%H:%M:%S", time.localtime(time.time()))
         filename = '%s/%s_config.%s' % (backup_path, host, tstamp)

lib/ansible/plugins/action/nxos_config.py

@@ -71,7 +71,7 @@ class ActionModule(_ActionModule):
         backup_path = self._get_working_path() + '/backup'
         if not os.path.exists(backup_path):
             os.mkdir(backup_path)
-        for fn in glob.glob('%s/%s*' % (backup_path, host)):
+        for fn in glob.glob('%s/%s_config.*' % (backup_path, host)):
             os.remove(fn)
         tstamp = time.strftime("%Y-%m-%d@%H:%M:%S", time.localtime(time.time()))
         filename = '%s/%s_config.%s' % (backup_path, host, tstamp)

lib/ansible/plugins/action/onyx_config.py

@@ -70,7 +70,7 @@ class ActionModule(_ActionModule):
         backup_path = self._get_working_path() + '/backup'
         if not os.path.exists(backup_path):
             os.mkdir(backup_path)
-        for fn in glob.glob('%s/%s*' % (backup_path, host)):
+        for fn in glob.glob('%s/%s_config.*' % (backup_path, host)):
             os.remove(fn)
         tstamp = time.strftime("%Y-%m-%d@%H:%M:%S", time.localtime(time.time()))
         filename = '%s/%s_config.%s' % (backup_path, host, tstamp)

lib/ansible/plugins/action/slxos_config.py

@@ -71,7 +71,7 @@ class ActionModule(_ActionModule):
         backup_path = self._get_working_path() + '/backup'
         if not os.path.exists(backup_path):
             os.mkdir(backup_path)
-        for fn in glob.glob('%s/%s*' % (backup_path, host)):
+        for fn in glob.glob('%s/%s_config.*' % (backup_path, host)):
             os.remove(fn)
         tstamp = time.strftime("%Y-%m-%d@%H:%M:%S", time.localtime(time.time()))
         filename = '%s/%s_config.%s' % (backup_path, host, tstamp)

lib/ansible/plugins/action/sros_config.py

@@ -71,7 +71,7 @@ class ActionModule(_ActionModule):
         backup_path = self._get_working_path() + '/backup'
         if not os.path.exists(backup_path):
             os.mkdir(backup_path)
-        for fn in glob.glob('%s/%s*' % (backup_path, host)):
+        for fn in glob.glob('%s/%s_config.*' % (backup_path, host)):
             os.remove(fn)
         tstamp = time.strftime("%Y-%m-%d@%H:%M:%S", time.localtime(time.time()))
         filename = '%s/%s_config.%s' % (backup_path, host, tstamp)

lib/ansible/plugins/action/vyos_config.py

@@ -72,7 +72,7 @@ class ActionModule(_ActionModule):
         backup_path = self._get_working_path() + '/backup'
         if not os.path.exists(backup_path):
             os.mkdir(backup_path)
-        for fn in glob.glob('%s/%s*' % (backup_path, host)):
+        for fn in glob.glob('%s/%s_config.*' % (backup_path, host)):
             os.remove(fn)
         tstamp = time.strftime("%Y-%m-%d@%H:%M:%S", time.localtime(time.time()))
         filename = '%s/%s_config.%s' % (backup_path, host, tstamp)