cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Fix AIX networks facts when nestat is either missing or has incorrect permissions (#72516)

Browse source 
* Added check for none on netstat_path variable

* Added changelog
This commit is contained in:
Egor Margineanu 2020-11-10 16:07:28 +01:00 committed by GitHub
parent d451433e5d
commit e879f12fb9
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 17 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
changelogs/fragments/72516-fix-aix-network-facts.yml Normal file
View file

@ -0,0 +1,2 @@
bugfixes:
- Fixed issue when `netstat` is either missing or doesn't have execution permissions leading to incorrect command being executed.

29
lib/ansible/module_utils/facts/network/aix.py
View file

@ -30,22 +30,23 @@ class AIXNetwork(GenericBsdIfconfigNetwork):
platform = 'AIX'
def get_default_interfaces(self, route_path):
netstat_path = self.module.get_bin_path('netstat')
rc, out, err = self.module.run_command([netstat_path, '-nr'])
interface = dict(v4={}, v6={})
lines = out.splitlines()
for line in lines:
words = line.split()
if len(words) > 1 and words[0] == 'default':
if '.' in words[1]:
interface['v4']['gateway'] = words[1]
interface['v4']['interface'] = words[5]
elif ':' in words[1]:
interface['v6']['gateway'] = words[1]
interface['v6']['interface'] = words[5]
netstat_path = self.module.get_bin_path('netstat')
if netstat_path:
rc, out, err = self.module.run_command([netstat_path, '-nr'])
lines = out.splitlines()
for line in lines:
words = line.split()
if len(words) > 1 and words[0] == 'default':
if '.' in words[1]:
interface['v4']['gateway'] = words[1]
interface['v4']['interface'] = words[5]
elif ':' in words[1]:
interface['v6']['gateway'] = words[1]
interface['v6']['interface'] = words[5]
return interface['v4'], interface['v6']