From eac7d2a958f41f3919a52896b6e0cf390d19134a Mon Sep 17 00:00:00 2001 From: Mark Chappell Date: Mon, 9 Dec 2019 10:05:36 +0100 Subject: [PATCH] ec2_placement_group: Make name 'required' to match the documentation (#65555) Previously you'd get one of the following behaviours: - A boto3 error - Nothing would change - An error that you're not allowed to change the strategy So of the bahaviour would depend on the random order that AWS returns the list of all Placement Groups --- changelogs/fragments/65555-amazon-sanity-required.yml | 2 ++ lib/ansible/modules/cloud/amazon/ec2_placement_group.py | 2 +- test/sanity/ignore.txt | 1 - 3 files changed, 3 insertions(+), 2 deletions(-) create mode 100644 changelogs/fragments/65555-amazon-sanity-required.yml diff --git a/changelogs/fragments/65555-amazon-sanity-required.yml b/changelogs/fragments/65555-amazon-sanity-required.yml new file mode 100644 index 00000000000..ef385be3e48 --- /dev/null +++ b/changelogs/fragments/65555-amazon-sanity-required.yml @@ -0,0 +1,2 @@ +minor_changes: +- ec2_placement_group - make `name` a required field. diff --git a/lib/ansible/modules/cloud/amazon/ec2_placement_group.py b/lib/ansible/modules/cloud/amazon/ec2_placement_group.py index 31e62280600..1fb04e47a6f 100644 --- a/lib/ansible/modules/cloud/amazon/ec2_placement_group.py +++ b/lib/ansible/modules/cloud/amazon/ec2_placement_group.py @@ -170,7 +170,7 @@ def main(): argument_spec = ec2_argument_spec() argument_spec.update( dict( - name=dict(type='str'), + name=dict(required=True, type='str'), state=dict(default='present', choices=['present', 'absent']), strategy=dict(default='cluster', choices=['cluster', 'spread']) ) diff --git a/test/sanity/ignore.txt b/test/sanity/ignore.txt index 79f8be20ddc..a6f811f71b5 100644 --- a/test/sanity/ignore.txt +++ b/test/sanity/ignore.txt @@ -492,7 +492,6 @@ lib/ansible/modules/cloud/alicloud/ali_instance.py validate-modules:parameter-ty lib/ansible/modules/cloud/alicloud/ali_instance_info.py validate-modules:doc-missing-type lib/ansible/modules/cloud/alicloud/ali_instance_info.py validate-modules:doc-required-mismatch lib/ansible/modules/cloud/alicloud/ali_instance_info.py validate-modules:parameter-type-not-in-doc -lib/ansible/modules/cloud/amazon/ec2_placement_group.py validate-modules:doc-required-mismatch lib/ansible/modules/cloud/amazon/iam.py validate-modules:doc-required-mismatch lib/ansible/modules/cloud/amazon/iam_cert.py validate-modules:doc-required-mismatch lib/ansible/modules/cloud/amazon/iam_policy.py validate-modules:doc-required-mismatch