cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Add check_mode support to HipChat module

Browse source 
The HipChat module declares to support check_mode,
but the message is sent in any case.

With this, if executed in check mode, the module will exit
before actually sending the message to HipChat.

It will return changed=False, as per the convention
for notifications modules.
This commit is contained in:
Jean-Fred Berthelot 2015-04-25 12:56:35 +01:00 committed by Jean-Fred
parent 19b345932a
commit f0508fa30e
1 changed files with 7 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
notification/hipchat.py
View file

@ -96,6 +96,11 @@ def send_msg(module, token, room, msg_from, msg, msg_format='text',
url = api + "?auth_token=%s" % (token)
data = urllib.urlencode(params)
if module.check_mode:
# In check mode, exit before actually sending the message
module.exit_json(changed=False)
response, info = fetch_url(module, url, data=data)
if info['status'] == 200:
return response.read()
@ -119,8 +124,8 @@ def main():
"purple", "gray", "random"]),
msg_format=dict(default="text", choices=["text", "html"]),
notify=dict(default=True, type='bool'),
validate_certs = dict(default='yes', type='bool'),
api = dict(default=MSG_URI),
validate_certs=dict(default='yes', type='bool'),
api=dict(default=MSG_URI),
),
supports_check_mode=True
)