cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

postgresql_db: add note to doc about pg_dump Backport/2.8/57297 (#57308)

Browse source 
* postgresql_db: add note to doc about pg_dump (backport of #57297)
* Update lib/ansible/modules/database/postgresql/postgresql_db.py
This commit is contained in:
Andrey Klychkov 2019-06-03 18:23:41 +03:00 committed by Alicia Cozine
parent 9184255340
commit f0664476b7
2 changed files with 6 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
changelogs/fragments/57297-postgresql_db_add_note_dump.yml Normal file
View file

@ -0,0 +1,2 @@
bugfixes:
- postgresql_db - add note to the documentation about state dump and the incorrect rc (https://github.com/ansible/ansible/pull/57297)

4
lib/ansible/modules/database/postgresql/postgresql_db.py
View file

@ -65,6 +65,10 @@ options:
- C(present) implies that the database should be created if necessary.
- C(absent) implies that the database should be removed if present.
- C(dump) requires a target definition to which the database will be backed up. (Added in Ansible 2.4)
Note that in some PostgreSQL versions of pg_dump, which is an embedded PostgreSQL utility and is used by the module,
returns rc 0 even when errors occurred (e.g. the connection is forbidden by pg_hba.conf, etc.),
so the module returns changed=True but the dump has not actually been done. Please, be sure that your version of
pg_dump returns rc 1 in this case.
- C(restore) also requires a target definition from which the database will be restored. (Added in Ansible 2.4)
- The format of the backup will be detected based on the target name.
- Supported compression formats for dump and restore include C(.bz2), C(.gz) and C(.xz)