Fix for routers without external interfaces

This commit is contained in:
David Shrewsbury 2015-10-22 11:52:28 -04:00 committed by Matt Clay
parent c2b695390b
commit f086279a23

View file

@ -164,10 +164,13 @@ def _needs_update(cloud, module, router, network, internal_subnet_ids):
"""
if router['admin_state_up'] != module.params['admin_state_up']:
return True
if router['external_gateway_info'].get('enable_snat', True) != module.params['enable_snat']:
return True
if router['external_gateway_info']:
if router['external_gateway_info'].get('enable_snat', True) != module.params['enable_snat']:
return True
if network:
if router['external_gateway_info']['network_id'] != network['id']:
if not router['external_gateway_info']:
return True
elif router['external_gateway_info']['network_id'] != network['id']:
return True
# check external interfaces