Further cleanup to add another rc check and remove a now redundent one.

This commit is contained in:
Ashley Penney 2012-10-12 18:26:40 +00:00
parent 6042419624
commit f4484f800b

View file

@ -156,6 +156,8 @@ def pull(module, repo, dest, version):
cur_branch = b
if is_local_branch(module, dest, version) and not is_current_branch(module, dest, version):
(rc, out, err) = switch_version(module, dest, remote, version)
if rc != 0:
module.fail_json(msg=err)
cmd = "git pull -u origin"
cmd = subprocess.Popen(cmd, shell=True, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
@ -222,10 +224,6 @@ def main():
if rc != 0:
module.fail_json(msg=err)
# handle errors from clone or pull
if rc != 0:
module.fail_json(msg=err)
# switch to version specified regardless of whether
# we cloned or pulled
(rc, out, err) = switch_version(module, dest, remote, version)