From f63ad7894efd960e06c11349c61de4f2000bd3d9 Mon Sep 17 00:00:00 2001 From: Jon Hadfield Date: Fri, 3 Oct 2014 13:00:11 +0100 Subject: [PATCH] Remove redundant check for creates argument. --- lib/ansible/modules/files/unarchive.py | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/lib/ansible/modules/files/unarchive.py b/lib/ansible/modules/files/unarchive.py index b632aff3f04..f46e52e02a3 100644 --- a/lib/ansible/modules/files/unarchive.py +++ b/lib/ansible/modules/files/unarchive.py @@ -193,7 +193,6 @@ def main(): src = os.path.expanduser(module.params['src']) dest = os.path.expanduser(module.params['dest']) copy = module.params['copy'] - creates = module.params['creates'] # did tar file arrive? if not os.path.exists(src): @@ -204,20 +203,6 @@ def main(): if not os.access(src, os.R_OK): module.fail_json(msg="Source '%s' not readable" % src) - if creates: - # do not run the command if the line contains creates=filename - # and the filename already exists. This allows idempotence - # of command executions. - v = os.path.expanduser(creates) - if os.path.exists(v): - module.exit_json( - stdout="skipped, since %s exists" % v, - skipped=True, - changed=False, - stderr=False, - rc=0 - ) - # is dest OK to receive tar file? if not os.path.isdir(dest): module.fail_json(msg="Destination '%s' is not a directory" % dest)