From f88412b7cdb93b59735cdfce57a41977389c0d56 Mon Sep 17 00:00:00 2001 From: Nathaniel Case Date: Wed, 23 May 2018 18:33:36 -0400 Subject: [PATCH] Fix ios test pt. 2 (#40628) * Add missing idempotence assert * Remove dhcp with other addresses on ipv6 --- lib/ansible/modules/network/ios/ios_l3_interface.py | 5 +++-- .../targets/ios_l3_interface/tests/cli/basic.yaml | 2 ++ 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/lib/ansible/modules/network/ios/ios_l3_interface.py b/lib/ansible/modules/network/ios/ios_l3_interface.py index 25f9312f8c3..651be3c6d1d 100644 --- a/lib/ansible/modules/network/ios/ios_l3_interface.py +++ b/lib/ansible/modules/network/ios/ios_l3_interface.py @@ -107,11 +107,10 @@ from copy import deepcopy from ansible.module_utils._text import to_text from ansible.module_utils.basic import AnsibleModule -from ansible.module_utils.six import iteritems from ansible.module_utils.network.ios.ios import get_config, load_config from ansible.module_utils.network.ios.ios import ios_argument_spec from ansible.module_utils.network.common.config import NetworkConfig -from ansible.module_utils.network.common.utils import conditional, remove_default_spec +from ansible.module_utils.network.common.utils import remove_default_spec from ansible.module_utils.network.common.utils import is_netmask, is_masklen, to_netmask, to_masklen @@ -197,6 +196,8 @@ def map_obj_to_commands(updates, module): commands.append('no ipv6 address {}'.format(ipv6)) else: commands.append('no ipv6 address') + if 'dhcp' in obj_in_have['ipv6']: + commands.append('no ipv6 address dhcp') elif state == 'present': if ipv4: diff --git a/test/integration/targets/ios_l3_interface/tests/cli/basic.yaml b/test/integration/targets/ios_l3_interface/tests/cli/basic.yaml index 4a199e3ffd9..cb0de03f74e 100644 --- a/test/integration/targets/ios_l3_interface/tests/cli/basic.yaml +++ b/test/integration/targets/ios_l3_interface/tests/cli/basic.yaml @@ -168,6 +168,8 @@ provider: "{{ cli }}" register: result +- assert: *unchanged + - name: Delete second interface ipv4 and ipv6 address (setup) ios_l3_interface: name: "{{ test_interface2 }}"