cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Make subversion module work on python 3

Browse source 
In python 3, filter return a iterator and so result in this traceback:

    Traceback (most recent call last):
      File \"/tmp/ansible_kzu72kz5/ansible_module_subversion.py\", line 264, in <module>
        main()
      File \"/tmp/ansible_kzu72kz5/ansible_module_subversion.py\", line 243, in main
        local_mods = svn.has_local_mods()
      File \"/tmp/ansible_kzu72kz5/ansible_module_subversion.py\", line 178, in has_local_mods
        return len(filter(regex.match, lines)) > 0
    TypeError: object of type 'filter' has no len()
This commit is contained in:
Michael Scherer 2016-10-16 23:39:36 +02:00 committed by Matt Clay
parent c9da5e98a9
commit f9478c7618
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
lib/ansible/modules/source_control/subversion.py
View file

@ -175,7 +175,7 @@ class Subversion(object):
# Match only revisioned files, i.e. ignore status '?'.
regex = re.compile(r'^[^?X]')
# Has local mods if more than 0 modified revisioned files.
return len(filter(regex.match, lines)) > 0
return len(list(filter(regex.match, lines))) > 0
def needs_update(self):
curr, url = self.get_revision()