cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Distribution: Add support for Linux Mint 18.3 (#52224)

Browse source 
* Distribution: Add support for Linux Mint 18.3
* Review comments

Fixes: #52210

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
This commit is contained in:
Abhijeet Kasurde 2019-02-18 08:28:04 +05:30 committed by GitHub
parent b7482e6a6d
commit fad6443e58
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 27 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
changelogs/fragments/distribution_support.yaml Normal file
View file

@ -0,0 +1,3 @@
minor_changes:
- Support for Linux Mint 18.3 added in setup facts (https://github.com/ansible/ansible/pull/52224).
- Support for Cumulus Linux 2.5.4 and 3.7.3 added in setup facts (https://github.com/ansible/ansible/pull/52309).

6
lib/ansible/module_utils/facts/system/distribution.py
View file

@ -345,6 +345,12 @@ class DistributionFiles:
release = re.search(r'VERSION="(.*)"', data)
if release:
debian_facts['distribution_release'] = release.groups()[0]
elif "Mint" in data:
debian_facts['distribution'] = 'Linux Mint'
version = re.search(r"VERSION_ID=\"(.*)\"", data)
if version:
debian_facts['distribution_version'] = version.group(1)
debian_facts['distribution_major_version'] = version.group(1).split('.')[0]
else:
return False, debian_facts

18
test/units/module_utils/test_distribution_version.py
View file

@ -1157,6 +1157,24 @@ SUPPORT_URL="http://support.cumulusnetworks.com/"
'distribution_version': '2.5.4',
}
},
{
"platform.dist": [
"LinuxMint",
"18.3",
"sylvia",
],
"input": {
"/etc/os-release": "NAME=\"Linux Mint\"\nVERSION=\"18.3 (Sylvia)\"\nID=linuxmint\nID_LIKE=ubuntu\nPRETTY_NAME=\"Linux Mint 18.3\"\nVERSION_ID=\"18.3\"\nHOME_URL=\"http://www.linuxmint.com/\"\nSUPPORT_URL=\"http://forums.linuxmint.com/\"\nBUG_REPORT_URL=\"http://bugs.launchpad.net/linuxmint/\"\nVERSION_CODENAME=sylvia\nUBUNTU_CODENAME=xenial", # noqa
},
"name": "Linux Mint 18.3",
"result": {
"distribution_release": "sylvia",
"distribution": "Linux Mint",
"distribution_major_version": "18",
"os_family": "Debian",
"distribution_version": "18.3"
}
}
]