From fd50dda268a7e3c8bd9ad6514c7896853eb1687e Mon Sep 17 00:00:00 2001 From: James Cammarata Date: Thu, 8 May 2014 15:08:43 -0500 Subject: [PATCH] Some cleanup for the rds/vpc_security_groups fix --- cloud/rds | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/cloud/rds b/cloud/rds index 055ad176099..faef8480bbc 100644 --- a/cloud/rds +++ b/cloud/rds @@ -300,7 +300,7 @@ def main(): multi_zone = dict(type='bool', default=False), iops = dict(required=False), security_groups = dict(required=False), - vpc_security_groups = dict(required=False), + vpc_security_groups = dict(type='list', required=False), port = dict(required=False), upgrade = dict(type='bool', default=False), option_group = dict(required=False), @@ -465,9 +465,10 @@ def main(): params["security_groups"] = security_groups.split(',') if vpc_security_groups: - params["vpc_security_groups"] = [ - boto.rds.VPCSecurityGroupMembership(vpc_group=x) if x else None - for x in vpc_security_groups.split(',')] + groups_list = [] + for x in vpc_security_groups: + groups_list.append(boto.rds.VPCSecurityGroupMembership(vpc_group=x)) + params["vpc_security_groups"] = groups_list if new_instance_name: params["new_instance_id"] = new_instance_name