Commit graph

130 commits

Author SHA1 Message Date
Monty Taylor
007efe438d Merge pull request #1690 from emonty/typo-fix
Fix a small typo in parameter processing
2015-07-09 09:36:00 -04:00
Monty Taylor
fbb6277a37 Fix a small typo in parameter processing 2015-07-09 09:33:10 -04:00
Brian Coca
e3c774be6f Merge pull request #1632 from emonty/feature/os_floating_ip
Add OpenStack Floating IP module
2015-07-07 19:42:42 -04:00
Jesse Keating
76398781ba Fix up docs 2015-07-07 15:29:47 -07:00
Monty Taylor
dd9c292861 Update docstring to show port ranges as optional 2015-07-06 18:53:31 -04:00
David Shrewsbury
6933407cd4 Correct port matching logic
Port matching logic did not take into account recent shade change
to equate (None, None) to (1, 65535) when Nova is the backend.

Also, this encapsulates the port matching logic into a single function
and heavily documents the logic.
2015-07-06 18:50:03 -04:00
David Shrewsbury
8664c88417 Change required parameters for rules module
The ports and protocol are no longer required (and now depends on
a new version of shade).
2015-07-06 18:50:03 -04:00
Monty Taylor
9f03302b68 Use int in the parameter list instead of casting 2015-07-06 18:50:03 -04:00
dagnello
2e8daa2330 Resolving issues in rule comparison algorithm
Port range min/max values are at times represented as string and
compared to int equivalents.  This fix explicitly ensures all
port range values are ints for proper comparisons.
2015-07-06 18:50:03 -04:00
David Shrewsbury
f027e75976 Compare ports as strings
Ports as returned from shade are ints. They are strings as they come
in to the module.
2015-07-06 18:50:03 -04:00
David Shrewsbury
9d0c8b0507 Fix syntax error 2015-07-06 18:50:03 -04:00
Monty Taylor
0e5942d7e7 Return rule object 2015-07-06 18:50:03 -04:00
David Shrewsbury
16b3b72294 Update secgroup rules module for latest shade
This allows the rules module to work against either nova or neutron
for handling security groups. New parameters for 'direction' and
'ethertype' are added.

Check mode is supported with this version.
2015-07-06 18:50:03 -04:00
David Shrewsbury
5b6c6cac20 Recongnize None and -1 port equivalency
shade 0.7.0 represents disabled min/max ports as None (in the
neutron style) rather than -1. Recognize this as the same as -1.
2015-07-06 18:50:03 -04:00
David Shrewsbury
5758b4ebdc Fix id value reference 2015-07-06 18:50:03 -04:00
David Shrewsbury
8f2e70a1c1 Update rules mode for latest shade
Shade 0.7.0 normalized the security group data that is returned,
when using nova, to look more like neutron security group data.
This adjusts for that change.
2015-07-06 18:50:03 -04:00
dagnello
b98e6663e8 Minor fixes for os_security_group_rule module
Was not able to use this module as it was.  The changes submitted
resolved the issues I ran into in order to get it working.
2015-07-06 18:50:03 -04:00
dagnello
d35df1f217 Minor fixes for os_security_group_rule module
Was not able to use this module as it was.  The changes submitted
resolved the issues I ran into in order to get it working.
2015-07-06 18:50:02 -04:00
Davide Guerri
a9301ba918 Fix invalid syntax in openstack_module_kwargs call 2015-07-06 18:50:02 -04:00
Monty Taylor
08b4bb42c4 Fix example code syntax 2015-07-06 18:50:02 -04:00
Monty Taylor
08b2f31915 Add OpenStack Security Group Rule module 2015-07-06 18:50:02 -04:00
Toshio Kuratomi
ff69ce7912 Merge pull request #1638 from j2sol/bugfix/os_server_afip_doc
Document auto_floating_ip argument
2015-07-01 08:15:53 -07:00
Toshio Kuratomi
968386cba3 Merge pull request #1631 from emonty/features/single-cloud-details
Add filter ability to OpenStack os-client-config module
2015-07-01 08:07:37 -07:00
Toshio Kuratomi
02b6df3160 Fix indentation levels in os_keypair 2015-07-01 05:00:39 -07:00
Toshio Kuratomi
edad5c80ff Few minor things from review of the pull request 2015-06-30 13:18:56 -07:00
Toshio Kuratomi
8703fb3c76 Merge pull request #1045 from emonty/feature/os_keypair
Add OpenStack Keypair module
2015-06-30 13:17:27 -07:00
Jesse Keating
ddc78c82a4 Document auto_floating_ip argument 2015-06-29 14:06:50 -07:00
David Shrewsbury
7970924bd5 Use newest documentation style for return value. 2015-06-29 15:55:15 -04:00
David Shrewsbury
e6fc129013 Add a note about the return value. 2015-06-29 14:49:13 -04:00
Monty Taylor
7b0b75ceed Fix dict syntax typo 2015-06-29 10:34:24 -04:00
Davide Guerri
304e187a52 Fix reuse argument documentation 2015-06-26 14:53:48 +01:00
Davide Guerri
e3d9b51cbb Update os_floating_ip with new shade methods 2015-06-26 12:53:20 +01:00
David Shrewsbury
bed420cd53 Update os_keypair for latest shade
Uses the latest version of shade for cleaner code. Also, always
return the key dict whether we create the key, or it already exists.
The example using public_key_file is corrected to use a full path
since ~ is not converted for us.
2015-06-25 12:19:20 -04:00
Monty Taylor
850ed126e2 Remove duplicate shade requirement 2015-06-19 17:39:57 -04:00
Monty Taylor
94a8b6dccc Make sure we're always returning objects too 2015-06-19 17:08:36 -04:00
dagnello
d7f65af6d9 Resolving secgroup.id issue in this module
secgroup['id'] was not being returned in all cases where the
specified security group exists.
2015-06-19 17:07:20 -04:00
Brian Coca
6449a01311 Merge pull request #1536 from emonty/feature/os_security_group
Return OpenStack secgroup, not just id
2015-06-19 01:52:43 -04:00
Monty Taylor
02d0a73906 Move the order of argument processing 2015-06-18 08:01:27 -04:00
Davide Guerri
82dc5c4394 Avoind using lookup() in documentation
lookup() is currently broken (current Ansible devel branch), so better to avoid
it in our examples.
2015-06-18 08:01:27 -04:00
Monty Taylor
a226701efe Add OpenStack Keypair module
Also deprecate old nova_keypair module.
2015-06-18 08:01:24 -04:00
Monty Taylor
759c2de7f9 Add filter ability 2015-06-18 07:56:50 -04:00
Monty Taylor
d8c51a67f3 Actually use changed variable 2015-06-17 08:47:14 -04:00
Monty Taylor
1a11f07d29 Return the secgroup for all present states 2015-06-17 08:02:34 -04:00
Monty Taylor
5609d1dc5a Return resource objects from OpenStack modules
It's not uncommon for people to want to do additional things after
creating a module. Also, add a note about it to the dev notes.
2015-06-17 05:24:08 -04:00
Monty Taylor
ef22008cac Return secgroup, not just id 2015-06-17 04:25:55 -04:00
Brian Coca
898e338318 minor doc fixes 2015-06-16 18:56:24 -04:00
Monty Taylor
ff0fc73d64 Add OpenStack Floating IP Module
Also deprecate the two old quantum floating ip modules.
2015-06-16 15:50:31 -07:00
Brian Coca
d393df4bce Merge pull request #1053 from emonty/feature/os_security_group
Add OpenStack Security Group module
2015-06-16 18:19:53 -04:00
Brian Coca
7adc911372 Merge pull request #1047 from emonty/feature/os_object
Add OpenStack Object module
2015-06-16 18:18:14 -04:00
Brian Coca
0367a923c7 Merge pull request #1044 from emonty/feature/os_ironic_node
Add Ironic Node module
2015-06-16 18:17:12 -04:00