Commit graph

7954 commits

Author SHA1 Message Date
Andrew Smith
eed32ea70c dest_contents isn’t always defined, so don’t pass it around
I think this is also a bit of a hack since it should probably be set
before being used, I’m just not sure what it should be set to.
2013-11-28 10:59:51 +10:00
Andrew Smith
e2d03173d2 The file module doesn’t have it’s module_args reset
I believe that this should be reset in the same way that the copy module
does
2013-11-28 10:58:14 +10:00
Andrew Smith
7b01c83159 Passing in complex_args throws ‘unsupported parameter for module’ errors
When using assemble only params (e.g. remote_src) the copy (and I’m
guessing file) modules throw an error that the param isn’t supported.
Simply removing the complex_args param fixes it for me, but I’m not sure
that’s the correct thing to do
2013-11-28 10:55:35 +10:00
Andrew Smith
da44a7f0cb I think that resultant is meant to be the contents of the combined file
It is used for the transfer and as a diff param but isn’t actually
defined anywhere before it’s used. This seemed like the least bad place
to set it.
2013-11-28 10:53:00 +10:00
Andrew Smith
4503413baa ReturnData is used throughout but not actually imported 2013-11-28 10:51:04 +10:00
dragon3
d39e6fda92 hostname module: add support for Amazon Linux 2013-11-28 09:31:25 +09:00
Andrew Smith
7d007cac16 Correct the invocation of ‘_assemble_from_fragments’ 2013-11-28 09:44:14 +10:00
Michael DeHaan
52b2cfedfc Add release history for 1.4.1 into 1.5 branch. 2013-11-27 18:41:07 -05:00
jctanner
920bc6e75b Merge pull request #5086 from j2sol/fix-accelerate_inventory
Avoid a traceback when using accelerate
2013-11-27 14:46:12 -08:00
Michael DeHaan
55cc5f25c5 Merge pull request #5085 from tgerla/awsfixes
fix heading name syntax in AWS guide
2013-11-27 14:35:49 -08:00
James Tanner
b6879ca2bd Fixes #5030 compare connection user and sudo user and disable sudo if identical 2013-11-27 17:01:53 -05:00
Jesse Keating
5522d489e3 Avoid a traceback when using accelerate
This bit of code is attempting to access accelerate_inventory_host,
which may not have been set/created. This will cause a traceback.
Instead use getattr with a fallback to False.
2013-11-27 13:58:11 -08:00
Tim Gerla
af42f0b771 fix heading name syntax in AWS guide 2013-11-27 12:36:49 -08:00
James Tanner
12ed39ef7b Fixes #5056 Append new hosts to the groups cache 2013-11-27 13:04:31 -05:00
James Cammarata
1f80aa768a Fix bug in error detection code, where a zero-length string was causing a traceback
Fixes #5064
2013-11-27 11:57:15 -06:00
Brandon Hilkert
33afaebb95 Fix checking for existence of EC2 tags 2013-11-27 11:01:42 -05:00
James Cammarata
30948ae0dc Fix accelerate module parameter for IPv6 activation 2013-11-27 09:32:07 -06:00
jctanner
696ce0effe Merge pull request #5067 from justinludwig/fix-aws-credential-params
Fix AWS credential params for ec2_ami, ec2_elb, ec2_tag, ec2_vpc, route53, and s3 modules
2013-11-27 07:14:19 -08:00
Patrick Craston
8de0b88c1c Updated Fix for documentation playbook loops
if key is used with lookup parameter needs quotes as
otherwise it will load "ssh-rsa" "<the key>" "<the comment>" as separate
values and fail with "this module requires key=value arguments"
2013-11-27 13:12:50 +00:00
Michael DeHaan
4deac3c3f4 Merge pull request #5068 from jimrybarski/devel
fixed documentation typo about region purpose
2013-11-27 04:50:05 -08:00
gservat
13da2c3ac9 Added support for parsing in the SLES patch level correctly
On SLES, the setup module was returning the architecture as the distribution version (i.e. platform.dist() didn't quite return the right thing). This change checks for /etc/SuSE-release and grabs the second column in the third line as distribution_version.
2013-11-27 23:44:34 +11:00
Patrick Craston
20c5b7f800 Fix for documentation playbook loops
if key is used with lookup parameter that needs to be in quotes as
otherwise it will load "ssh-rsa" "<the key>" "<the comment>" as separate
values and fail with "this module requires key=value arguments"
2013-11-27 11:59:11 +00:00
Jim Rybarski
483bb58f2d fixed documentation typo about region purpose 2013-11-27 00:35:33 -06:00
Justin Ludwig
26374d89a0 Fix AWS credential params for s3 and other modules
The `ec2_ami`, `ec2_elb`, `ec2_tag`, `ec2_vpc`, `route53`, and `s3` modules
all canonicalize the AWS access and secret key params as
`aws_access_key` and `aws_secret_key`. However, following the fixes for #4540,
those modules now use `get_ec2_creds` from `lib/ansible/module_utils/ec2.py`,
which requires access/secret key params to be canonicalized as
`ec2_access_key` and `ec2_secret_key`. As a result, AWS credentials passed
to those six modules as parameters are ignored (they instead always use
the AWS credentials specified via environment variables, or nothing).

So this change fixes those six modules to canonicalize the
AWS access and secret key params as `ec2_access_key` and `ec2_secret_key`,
allowing them to again accept AWS credentials passed via module params.
2013-11-26 19:29:06 -08:00
Sam Hartsfield
ae7735b45d Fixed hostname module for RHEL6 Workstation 2013-11-26 11:36:10 -05:00
James Tanner
7be13faae8 Fix comment yaml escaping in authorized_key module 2013-11-26 08:54:19 -05:00
Michael DeHaan
82c9f5bfe4 Merge pull request #5060 from bcoca/assemble_fix
fixed typo for assemble function
2013-11-26 05:30:22 -08:00
Brian Coca
65885feeeb fixed typo for assemble function 2013-11-26 08:30:28 -05:00
James Tanner
4ba51eef6f Save comment hashes in sshkeys 2013-11-25 23:46:48 -05:00
James Tanner
16b22d0d64 Cleanup debug statements 2013-11-25 22:16:04 -05:00
James Tanner
b938554311 Fixes #5032 escape and safely split key options in authorized_keys module 2013-11-25 22:13:42 -05:00
James Tanner
d187066339 Fixes #5010 Add user to all defined supplementary groups 2013-11-25 14:56:46 -05:00
Michael DeHaan
d308aa584a Merge pull request #5050 from greenbrian/devel
Update unarchive
2013-11-25 10:39:52 -08:00
greenbrian
d80eb4a7fd Update unarchive
Modified argument order provided to unzip command as the -o was being interpreted as a file.
2013-11-25 10:44:39 -06:00
Michael DeHaan
41e83d9df1 Merge pull request #5045 from junegunn/wait_for-python2.4
Remove Python 2.4-incompatible 'with' statement
2013-11-25 08:28:14 -08:00
James Tanner
b8146e3bc7 Fixes #4979 Check for the correct context when inside the inventory_hostnames plugin 2013-11-25 10:57:10 -05:00
James Tanner
903c4cae7b Fixes #5031 Template the delay value and cast to float for loops 2013-11-25 10:13:55 -05:00
James Tanner
5c1fbcc9d2 Addresses #5036 fix typo in git module 2013-11-25 09:55:05 -05:00
James Tanner
d950a3d1b5 Fixes 5036 add missing parameter to git module function call 2013-11-25 09:51:07 -05:00
Jens Rantil
883f37e404 Improved documentation of mount module
Mentioning the fact that mount point directories are created and
removed.
2013-11-25 13:58:00 +01:00
Junegunn Choi
9c798b119c Remove Python 2.4-incompatible 'with' statement 2013-11-25 17:01:24 +09:00
Michael DeHaan
828b9f872f Merge pull request #5033 from tgerla/vagrantguide
Add a basic guide describing Vagrant and Ansible
2013-11-24 08:15:58 -08:00
Tim Gerla
fb3d5d6589 elaborate on a couple of sections 2013-11-23 14:59:35 -08:00
Michael DeHaan
0d4c690111 Merge pull request #5034 from zanardo/fix-typo
fix typo in deprecation warning
2013-11-23 13:24:45 -08:00
Antonio Zanardo
8dbd91b5ad fix typo in deprecation warning 2013-11-23 19:15:51 -02:00
Tim Gerla
461afa2b25 remove Vagrant from the list of pending topics 2013-11-23 11:13:56 -08:00
Tim Gerla
1cd71b7899 fix up word wrapping 2013-11-23 11:10:43 -08:00
Tim Gerla
7adf33ed41 add a topical guide for Vagrant integration 2013-11-23 11:07:51 -08:00
James Tanner
32986c4d64 Fixes #5021 safely split hostkeys with quotes 2013-11-22 16:36:31 -05:00
Michael DeHaan
e54a574bb2 Merge pull request #5020 from damycra/django_manage_migrate_changed_filter
Reports changed status from django_manage migrate
2013-11-22 13:22:07 -08:00