Doug Luce
030fbaef64
Use os module for checking absolute/joining paths
2016-12-08 11:33:55 -05:00
Doug Luce
d4275e576e
cronvar.py: support absolute destinations
...
Mainly so /etc/crontab can be written to.
2016-12-08 11:33:55 -05:00
Rene Moser
c00688a118
iptables: add defaults to docs
2016-12-08 11:33:55 -05:00
David Hocky
4abd217aa5
add version added to new params
2016-12-08 11:33:55 -05:00
David Hocky
a3b7dbe1df
fix doc issue
2016-12-08 11:33:55 -05:00
David Hocky
994edea253
add support for setting dscp marks with iptables module
2016-12-08 11:33:55 -05:00
liquidat
7abe6b0e8c
correct win_firewall state parameter
...
- original parameter comment was probably copy&paste error
- new comment highlights that firewall rules can be
added or removed altering this parameter
2016-12-08 11:33:55 -05:00
Toshio Kuratomi
32ff89b30e
Fix module docs
2016-12-08 11:33:55 -05:00
Rene Moser
fd68e66827
cloudstack: new module cs_zone_facts
2016-12-08 11:33:55 -05:00
Michael Scherer
4589b67a44
Remove unused variables
...
Session_id is unused in update_session, changed is always specifically
set in all exit_json call, and consul_client.session.destroy return True
or False, and is unused later (nor checked)
2016-12-08 11:33:55 -05:00
Michael Scherer
fabd619070
Rename consul variable to consul_client
...
Since the module is also named consul, pyflakes emit a warning
about it since the variable shadow the module.
2016-12-08 11:33:55 -05:00
Michael Scherer
78571c053b
Pyflakes complain about unused import, so remove it
2016-12-08 11:33:55 -05:00
Michael Scherer
334bfbd465
Add a datacenter parameter, fix #1693
2016-12-08 11:33:55 -05:00
Eike Frost
b8b2613c35
Replace deprecated exists API for Zabbix 3.0 compatibility
2016-12-08 11:33:55 -05:00
Calvin Walton
f623057e0e
zabbix_maintenance: Stop using api removed in zabbix 3.0
2016-12-08 11:33:55 -05:00
Ricky Cook
4a9daf6bae
New json_fail syntax for dnsimple module
2016-12-08 11:33:55 -05:00
yta
0446231380
osx_defaults: Do not make any changes in check mode
2016-12-08 11:33:55 -05:00
Ritesh Khadgaray
06d2682b08
Fix test failure for lxc_container
...
TRACE:
while parsing a block mapping
in "<string>", line 33, column 13:
description: resulting state of ...
^
expected <block end>, but found ','
in "lxc_container.RETURN", line 419, column 53:
... "/tmp/test-container-config.tar",
ERROR: RETURN is not valid YAML. Line 419 column 53
2016-12-08 11:33:54 -05:00
Brian Coca
bb355e6ccd
add container name to return and document return
...
fixes #1848
2016-12-08 11:33:54 -05:00
mxpt user
0798bfe2dc
Fixing typo in bigip_monitors Correcting set_template_int_property to set_template_integer_property
2016-12-08 11:33:54 -05:00
nitzmahone
2afecc7198
fix version_added issues in win_iis_website
2016-12-08 11:33:54 -05:00
nitzmahone
2e4cb9c651
added doc note to win_iis_website site_id arg
2016-12-08 11:33:54 -05:00
Corwin Brown
659c1078ba
Updated Documentation to include site_id param
2016-12-08 11:33:54 -05:00
Corwin Brown
2c9512aece
Adding Site_ID param
2016-12-08 11:33:54 -05:00
Brian Coca
864bf4e19e
added new puppet path to bin search
...
fixes #1835
2016-12-08 11:33:54 -05:00
Brian Coca
b1281319c1
updated to match core module forms
2016-12-08 11:33:54 -05:00
Hans-Joachim Kliemeck
bb27e38578
corrected replacement of last backslash
2016-12-08 11:33:54 -05:00
Hans-Joachim Kliemeck
cd0e97dc77
corrected requirements
2016-12-08 11:33:54 -05:00
Hans-Joachim Kliemeck
5f9eaf193e
fixxed problems related to path input
2016-12-08 11:33:54 -05:00
Hans-Joachim Kliemeck
0d01a36dd9
first implementation of win_share module
2016-12-08 11:33:54 -05:00
Marcin Dobosz
6f68db5c1a
Fix win_iis_webapppool module to not null ref when removing an apppool using PS4
2016-12-08 11:33:54 -05:00
nitzmahone
092c3ccbde
fix default arg handling and error messages in win_file_version
2016-12-08 11:33:54 -05:00
nitzmahone
db58300aa7
fix missing bracket in win_file_version
2016-12-08 11:33:54 -05:00
Sam Liu
a077c4bc9d
fix some error for passing CI build.
2016-12-08 11:33:53 -05:00
Sam Liu
b174416895
Fixed: exception swallowing
2016-12-08 11:33:53 -05:00
Sam Liu
d5fe7633e2
new module win_file_version
2016-12-08 11:33:53 -05:00
liquidat
87bc5fcb24
remove legacy action style from examples
...
- "action" style invoking is a legacy way to call modules
- the examples were updated to the typical style of calling complex
modules:
ovirt:
parameter1: value1
parameter2: value2
...
2016-12-08 11:33:53 -05:00
Matt Martz
019a944fb3
Catch errors related to insufficient (old) versions of pexpect. Fixes #13660
2016-12-08 11:33:53 -05:00
Will Keeling
876fe06290
Better handling of package groups in pacman module
2016-12-08 11:33:53 -05:00
Jonathan Mainguy
ac8b171da4
fixes bug where puppet fails if logdest is not specified
2016-12-08 11:33:53 -05:00
Toshio Kuratomi
c602d49d42
Fail due to no dnf module installed earlier as we use a dnf utility function to determine if we have permission to install packages.
2016-12-08 11:33:53 -05:00
Jiri Tyr
bb194b03bc
Removing parameter from yum_repository module
2016-12-08 11:33:53 -05:00
Jiri Tyr
709ae10207
Adding more options to the yum_repository module
2016-12-08 11:33:53 -05:00
Eike Frost
85f6bb4d8e
Check whether interface-list exits before querying its length
2016-12-08 11:33:53 -05:00
Ricardo Carrillo Cruz
9fea94b5bf
Fix instantiation of openstack_cloud object in os_project
...
The os_project module instantiates the openstack cloud object
by passing the module params kwargs.
As the params contain a key named 'domain_id', this is used
for domain in the OpenStack connection, instead of the domain value
the user specifies on the OSCC clouds.yaml or OpenStack envvars.
This fix corrects this by popping the 'domain_id' key, so it we
keep the value but it's not passed later on module.params.
2016-12-08 11:33:53 -05:00
Darek Kaczyński
17a6cea512
ecs_task module documentation fixes
2016-12-08 11:33:53 -05:00
Joseph Callen
773db55233
Resolves issue with vmware_migrate_vmk module for v2.0
...
When this module was written back in May 2015 we were using 1.9.x. Being lazy I added to param the objects that the other functions would need. What I have noticed is in 2.0 exit_json is trying to jsonify those complex objects and failing. This PR resolves that issue with the vmware_migrate_vmk module.
@kamsz reported this issue in https://github.com/ansible/ansible-modules-extras/pull/1568
Playbook
```
- name: Migrate Management vmk
local_action:
module: vmware_migrate_vmk
hostname: "{{ mgmt_ip_address }}"
username: "{{ vcsa_user }}"
password: "{{ vcsa_pass }}"
esxi_hostname: "{{ hostvars[item].hostname }}"
device: vmk1
current_switch_name: temp_vswitch
current_portgroup_name: esx-mgmt
migrate_switch_name: dvSwitch
migrate_portgroup_name: Management
with_items: groups['foundation_esxi']
```
Module Testing
```
TASK [Migrate Management vmk] **************************************************
task path: /opt/autodeploy/projects/emmet/tasks/deploy/migrate_vmk.yml:3
ESTABLISH LOCAL CONNECTION FOR USER: root
localhost EXEC ( umask 22 && mkdir -p "$( echo $HOME/.ansible/tmp/ansible-tmp-1454695485.85-245405603184252 )" && echo "$( echo $HOME/.ansible/tmp/ansible-tmp-1454695485.85-245405603184252 )" )
localhost PUT /tmp/tmpdlhr6t TO /root/.ansible/tmp/ansible-tmp-1454695485.85-245405603184252/vmware_migrate_vmk
localhost EXEC LANG=en_US.UTF-8 LC_ALL=en_US.UTF-8 LC_MESSAGES=en_US.UTF-8 /usr/bin/python /root/.ansible/tmp/ansible-tmp-1454695485.85-245405603184252/vmware_migrate_vmk; rm -rf "/root/.ansible/tmp/ansible-tmp-1454695485.85-245405603184252/" > /dev/null 2>&1
localhost EXEC ( umask 22 && mkdir -p "$( echo $HOME/.ansible/tmp/ansible-tmp-1454695490.35-143738865490168 )" && echo "$( echo $HOME/.ansible/tmp/ansible-tmp-1454695490.35-143738865490168 )" )
localhost PUT /tmp/tmpqfZqh1 TO /root/.ansible/tmp/ansible-tmp-1454695490.35-143738865490168/vmware_migrate_vmk
localhost EXEC LANG=en_US.UTF-8 LC_ALL=en_US.UTF-8 LC_MESSAGES=en_US.UTF-8 /usr/bin/python /root/.ansible/tmp/ansible-tmp-1454695490.35-143738865490168/vmware_migrate_vmk; rm -rf "/root/.ansible/tmp/ansible-tmp-1454695490.35-143738865490168/" > /dev/null 2>&1
localhost EXEC ( umask 22 && mkdir -p "$( echo $HOME/.ansible/tmp/ansible-tmp-1454695491.96-124154332968882 )" && echo "$( echo $HOME/.ansible/tmp/ansible-tmp-1454695491.96-124154332968882 )" )
localhost PUT /tmp/tmpf3rKZq TO /root/.ansible/tmp/ansible-tmp-1454695491.96-124154332968882/vmware_migrate_vmk
localhost EXEC LANG=en_US.UTF-8 LC_ALL=en_US.UTF-8 LC_MESSAGES=en_US.UTF-8 /usr/bin/python /root/.ansible/tmp/ansible-tmp-1454695491.96-124154332968882/vmware_migrate_vmk; rm -rf "/root/.ansible/tmp/ansible-tmp-1454695491.96-124154332968882/" > /dev/null 2>&1
ok: [foundation-vcsa -> localhost] => (item=foundation-esxi-01) => {"changed": false, "invocation": {"module_args": {"current_portgroup_name": "esx-mgmt", "current_switch_name": "temp_vswitch", "device": "vmk1", "esxi_hostname": "cscesxtmp001", "hostname": "172.27.0.100", "migrate_portgroup_name": "Management", "migrate_switch_name": "dvSwitch", "password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER", "username": "root"}, "module_name": "vmware_migrate_vmk"}, "item": "foundation-esxi-01"}
ok: [foundation-vcsa -> localhost] => (item=foundation-esxi-02) => {"changed": false, "invocation": {"module_args": {"current_portgroup_name": "esx-mgmt", "current_switch_name": "temp_vswitch", "device": "vmk1", "esxi_hostname": "cscesxtmp002", "hostname": "172.27.0.100", "migrate_portgroup_name": "Management", "migrate_switch_name": "dvSwitch", "password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER", "username": "root"}, "module_name": "vmware_migrate_vmk"}, "item": "foundation-esxi-02"}
ok: [foundation-vcsa -> localhost] => (item=foundation-esxi-03) => {"changed": false, "invocation": {"module_args": {"current_portgroup_name": "esx-mgmt", "current_switch_name": "temp_vswitch", "device": "vmk1", "esxi_hostname": "cscesxtmp003", "hostname": "172.27.0.100", "migrate_portgroup_name": "Management", "migrate_switch_name": "dvSwitch", "password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER", "username": "root"}, "module_name": "vmware_migrate_vmk"}, "item": "foundation-esxi-03"}
```
2016-12-08 11:33:53 -05:00
Joseph Callen
eece1346ab
missing doc fragment
2016-12-08 11:33:53 -05:00
Joseph Callen
3721a4647c
Resolves issue with vmware_vm_vss_dvs_migrate module for v2.0
...
When this module was written back in May 2015 we were using 1.9.x. Being lazy I added to param the objects that the other functions would need. What I have noticed is in 2.0 exit_json is trying to jsonify those complex objects and failing. This PR resolves that issue with the vmware_vm_vss_dvs_migrate module.
@kamsz reported this issue in https://github.com/ansible/ansible-modules-extras/pull/1568
Playbook
```
- name: Migrate VCSA to vDS
local_action:
module: vmware_vm_vss_dvs_migrate
hostname: "{{ mgmt_ip_address }}"
username: "{{ vcsa_user }}"
password: "{{ vcsa_pass }}"
vm_name: "{{ hostname }}"
dvportgroup_name: Management
```
Module Testing
```
ASK [Migrate VCSA to vDS] *****************************************************
task path: /opt/autodeploy/projects/emmet/site_deploy.yml:260
ESTABLISH LOCAL CONNECTION FOR USER: root
localhost EXEC ( umask 22 && mkdir -p "$( echo $HOME/.ansible/tmp/ansible-tmp-1454695546.3-207189190861859 )" && echo "$( echo $HOME/.ansible/tmp/ansible-tmp-1454695546.3-207189190861859 )" )
localhost PUT /tmp/tmpkzD4pF TO /root/.ansible/tmp/ansible-tmp-1454695546.3-207189190861859/vmware_vm_vss_dvs_migrate
localhost EXEC LANG=en_US.UTF-8 LC_ALL=en_US.UTF-8 LC_MESSAGES=en_US.UTF-8 /usr/bin/python /root/.ansible/tmp/ansible-tmp-1454695546.3-207189190861859/vmware_vm_vss_dvs_migrate; rm -rf "/root/.ansible/tmp/ansible-tmp-1454695546.3-207189190861859/" > /dev/null 2>&1
changed: [foundation-vcsa -> localhost] => {"changed": true, "invocation": {"module_args": {"dvportgroup_name": "Management", "hostname": "172.27.0.100", "password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER", "username": "root", "vm_name": "cscvcatmp001"}, "module_name": "vmware_vm_vss_dvs_migrate"}, "result": null}
```
2016-12-08 11:33:53 -05:00
Joseph Callen
cef9e42896
Resolves issue with vmware_host module for v2.0
...
When this module was written back in May 2015 we were using 1.9.x. Being lazy I added to param the objects that the other functions would need. What I have noticed is in 2.0 exit_json is trying to jsonify those complex objects and failing. This PR resolves that issue with the vmware_host module.
@kamsz reported this issue in https://github.com/ansible/ansible-modules-extras/pull/1568
Playbook
```
- name: Add Host
local_action:
module: vmware_host
hostname: "{{ mgmt_ip_address }}"
username: "{{ vcsa_user }}"
password: "{{ vcsa_pass }}"
datacenter_name: "{{ mgmt_vdc }}"
cluster_name: "{{ mgmt_cluster }}"
esxi_hostname: "{{ hostvars[item].hostname }}"
esxi_username: "{{ esxi_username }}"
esxi_password: "{{ site_passwd }}"
state: present
with_items: groups['foundation_esxi']
```
Module Testing
```
TASK [Add Host] ****************************************************************
task path: /opt/autodeploy/projects/emmet/site_deploy.yml:214
ESTABLISH LOCAL CONNECTION FOR USER: root
localhost EXEC ( umask 22 && mkdir -p "$( echo $HOME/.ansible/tmp/ansible-tmp-1454693866.1-87710459703937 )" && echo "$( echo $HOME/.ansible/tmp/ansible-tmp-1454693866.1-87710459703937 )" )
localhost PUT /tmp/tmppmr9i9 TO /root/.ansible/tmp/ansible-tmp-1454693866.1-87710459703937/vmware_host
localhost EXEC LANG=en_US.UTF-8 LC_ALL=en_US.UTF-8 LC_MESSAGES=en_US.UTF-8 /usr/bin/python /root/.ansible/tmp/ansible-tmp-1454693866.1-87710459703937/vmware_host; rm -rf "/root/.ansible/tmp/ansible-tmp-1454693866.1-87710459703937/" > /dev/null 2>&1
localhost EXEC ( umask 22 && mkdir -p "$( echo $HOME/.ansible/tmp/ansible-tmp-1454693943.8-75870536677834 )" && echo "$( echo $HOME/.ansible/tmp/ansible-tmp-1454693943.8-75870536677834 )" )
localhost PUT /tmp/tmpVB81f2 TO /root/.ansible/tmp/ansible-tmp-1454693943.8-75870536677834/vmware_host
localhost EXEC LANG=en_US.UTF-8 LC_ALL=en_US.UTF-8 LC_MESSAGES=en_US.UTF-8 /usr/bin/python /root/.ansible/tmp/ansible-tmp-1454693943.8-75870536677834/vmware_host; rm -rf "/root/.ansible/tmp/ansible-tmp-1454693943.8-75870536677834/" > /dev/null 2>&1
localhost EXEC ( umask 22 && mkdir -p "$( echo $HOME/.ansible/tmp/ansible-tmp-1454693991.56-163414752982563 )" && echo "$( echo $HOME/.ansible/tmp/ansible-tmp-1454693991.56-163414752982563 )" )
localhost PUT /tmp/tmpFB7VQB TO /root/.ansible/tmp/ansible-tmp-1454693991.56-163414752982563/vmware_host
localhost EXEC LANG=en_US.UTF-8 LC_ALL=en_US.UTF-8 LC_MESSAGES=en_US.UTF-8 /usr/bin/python /root/.ansible/tmp/ansible-tmp-1454693991.56-163414752982563/vmware_host; rm -rf "/root/.ansible/tmp/ansible-tmp-1454693991.56-163414752982563/" > /dev/null 2>&1
changed: [foundation-vcsa -> localhost] => (item=foundation-esxi-01) => {"changed": true, "invocation": {"module_args": {"cluster_name": "Foundation", "datacenter_name": "Test-Lab", "esxi_hostname": "cscesxtmp001", "esxi_password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER", "esxi_username": "root", "hostname": "172.27.0.100", "password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER", "state": "present", "username": "root"}, "module_name": "vmware_host"}, "item": "foundation-esxi-01", "result": "'vim.HostSystem:host-15'"}
changed: [foundation-vcsa -> localhost] => (item=foundation-esxi-02) => {"changed": true, "invocation": {"module_args": {"cluster_name": "Foundation", "datacenter_name": "Test-Lab", "esxi_hostname": "cscesxtmp002", "esxi_password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER", "esxi_username": "root", "hostname": "172.27.0.100", "password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER", "state": "present", "username": "root"}, "module_name": "vmware_host"}, "item": "foundation-esxi-02", "result": "'vim.HostSystem:host-20'"}
changed: [foundation-vcsa -> localhost] => (item=foundation-esxi-03) => {"changed": true, "invocation": {"module_args": {"cluster_name": "Foundation", "datacenter_name": "Test-Lab", "esxi_hostname": "cscesxtmp003", "esxi_password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER", "esxi_username": "root", "hostname": "172.27.0.100", "password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER", "state": "present", "username": "root"}, "module_name": "vmware_host"}, "item": "foundation-esxi-03", "result": "'vim.HostSystem:host-21'"}
```
2016-12-08 11:33:53 -05:00