Commit graph

15 commits

Author SHA1 Message Date
Brian Coca
767ec29640 Merge pull request #1260 from xavpaice/devel
Added stdout and stderr to puppet output for rc=2
2015-11-24 12:51:14 -08:00
Brian Coca
367b88a2ab removed json import 2015-11-21 16:07:12 -08:00
Xav Paice
c1cf8e671a Added stdout and stderr to puppet output for rc=2 2015-11-18 14:34:46 +13:00
Monty Taylor
ea5af4c27a Revert "Change show_diff to default to yes"
This was originally to match what puppet agent --test is, since the
rest of the options defaulted to on are grabbed from --test. However,
some security concerns have since been raised - namely that since this
is not the same invocation as --test but instead a remote orchestration
of puppet, the fact that passwords leak into the diff is a dangerous
default.

This reverts commit b86762c180.
2015-11-01 10:50:58 +09:00
Jonathan Mainguy
b86762c180 Change show_diff to default to yes, to match what puppet agent --test is, since the rest of the options defaulted to on are grabbed from --test 2015-10-23 13:24:39 -04:00
Brian Coca
1382576100 fixed a few typos
fixes #821
2015-08-10 13:25:13 -04:00
Rene Moser
f33bbe6e49 puppet: update author to new format 2015-06-16 11:33:16 -04:00
Rene Moser
e633d9946f puppet: make arg puppetmaster optional
puppetmaster was used to determine if `agent` or `apply` should be used. But puppetmaster is not required by puppet per default. Puppet may have a config or could find out by itself (...) where the puppet master is.

It changed the code so we only use `apply` if a manifest was passed, otherwise we use `agent`.

This also fixes the example, which did not work the way without this change.

~~~
# Run puppet agent and fail if anything goes wrong
- puppet
~~~
2015-06-16 11:33:15 -04:00
Rene Moser
c277946fb3 puppet: fix missing space between command and arg
Fixes:
~~~
{
    "cmd": "/usr/bin/puppetconfig print agent_disabled_lockfile",
    "failed": true,
    "msg": "[Errno 2] No such file or directory",
    "rc": 2
}
~~~
2015-06-16 11:33:15 -04:00
Rene Moser
616a56f871 puppet: add --environment support 2015-06-16 11:33:15 -04:00
Rene Moser
9d4046f44b puppet: ensure puppet is in live mode per default
puppet may be configured to operate in `--noop` mode per default.

That is why we must pass a `--no-noop` to make sure, changes are going to be applied.
2015-06-16 11:33:15 -04:00
Monty Taylor
ce93a91a59 Fix octal values for python 2.4 2015-06-16 11:33:12 -04:00
Monty Taylor
e7ed08f762 Add support for check mode 2015-06-16 11:33:12 -04:00
Monty Taylor
a1ecd60285 Fix some errors pointed out by travis 2015-06-16 11:33:11 -04:00
Monty Taylor
9d2d3f0299 Add module to run puppet
There is a growing pattern for using ansible to orchestrate runs of
existing puppet code. For instance, the OpenStack Infrastructure team
started using ansible for this very reason. It also turns out that
successfully running puppet and interpreting success or failure is
harder than you'd expect, thus warranting a module and not just a shell
command.

This is ported in from
http://git.openstack.org/cgit/openstack-infra/ansible-puppet
2015-06-16 11:33:11 -04:00