cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity
9270 commits 47 branches 390 tags 440 MiB
Commit graph

866 commits

Author SHA1 Message Date
James Tanner
9be870bb2a Revert "remove checking of stderr for insserv (#1846)" 
This reverts commit 2ee6e4cf66.
 2016-05-05 10:41:06 -04:00
TheSameCH
2ee6e4cf66 remove checking of stderr for insserv (#1846) 
stderr of insserv can also contain warnings which can be ignored. checking rc only is more accurate.
fixes #1502
 2016-05-04 22:09:55 -04:00
Brian Coca
4549ea5e85 removed incorrect defaults from docs 2016-04-25 14:43:05 -04:00
Konstantin Gribov
ab53adad4b Escape spaces, backslashes when create new entry in fstab (#3193) 
Supplement to PR #1454 and issue #530.

Fixes #3192.
Fixes #1861 (introduced by PR #1454).

Signed-off-by: Konstantin Gribov <grossws@gmail.com>
 2016-04-25 10:09:19 -04:00
Toshio Kuratomi
1d25c41844 Merge pull request #3525 from madpilot78/freebsd-service-sleep 
Make FreeBSD subclass respect the sleep option.
 2016-04-23 08:22:21 -07:00
Guido Falsi
8aac5ae7ba Make FreeBSD subclass respect the sleep option. 2016-04-23 14:10:11 +02:00
Michael Scherer
e3cb90bc2f Change home and ssh_key_file to 'path' in user module 2016-04-23 10:49:55 +02:00
Joshua Kugler
05109d16ec Fix mount's handling of passno 2016-04-12 16:42:55 -08:00
Robin Roth
d3fa192968 use custom ismount function in mount module (#2737) 
* based on cpython os.path.ismount
* includes patch from http://bugs.python.org/issue2466
* fixes #2186
* when the upstream bug is fixed this should be removed/rewritten
* use ismount from module_utils
 2016-04-12 08:48:42 -07:00
René Moser
6a7dac5bdc Merge pull request #3168 from jdicarreira/hostname_sles10_11 
Change hostname SLES 10 & 11
 2016-03-23 11:23:48 +01:00
René Moser
f30f4674e4 Merge pull request #3239 from towolf/add_diff_and_check_mode_to_cron 
Add diff and check mode to cron module
 2016-03-20 17:49:21 +01:00
Toshio Kuratomi
345d9cbca8 Fix documentation. 2016-03-16 10:50:31 -07:00
Toshio Kuratomi
7f6810d6bf Remove the ignore_ohai and ignore_facter parameters as the functionality was merged into gather_subset 2016-03-14 15:05:20 -07:00
Yannig Perré
4c14108b7e Use list type in order to convert directly gather_subset option into list. 2016-03-14 09:31:18 -07:00
Yannig Perré
baf8109dcc Add a way to restrict gathered facts in Ansible: 
- Using gather_subset options
- By ignoring ohai/chef or facter/puppet facts
 2016-03-14 09:31:18 -07:00
Tobias Wolf
0edf689688 Add diff and check mode to cron module 
supports not writing backup file in check mode and new environment
vars.

![example screenshot](http://i.imgur.com/mkAThq8.png)
 2016-03-14 15:42:32 +01:00
Brian Coca
84501dbe13 docs updates and fixes 
fixes http://github.com/ansible/ansible/issues/14876
 2016-03-09 10:06:44 -05:00
Matt Davis
ad2b9b342d Merge pull request #1876 from davidobrien1985/devel 
Custom Windows Facts
 2016-03-04 17:31:24 +00:00
Joao Carreira
a7c3c82162 added support for sles 10 & 11 2016-03-02 12:33:15 +00:00
Brian Coca
8baecece22 corrected version added 2016-02-29 23:47:37 -05:00
Brian Coca
f0f8d27bff Merge pull request #2010 from lberruti/global_user_crontab_env_variables_rebase 
cron module: add enviroment variables management
 2016-02-29 23:39:55 -05:00
Toshio Kuratomi
91ac443e8f Set one parameter to be type path 2016-02-29 00:08:26 -08:00
davidobrien1
b33320d3f1 Restore filter on Windows and version reference for Windows facts. 2016-02-26 22:40:43 +11:00
David O'Brien
e4c2cb96ea Add documentation to setup.py and remove use of $params.fact_path in setup.ps1 2016-02-26 16:34:10 +11:00
Ton Kersten
d43d2bc219 Fix facter path 
In Puppet 4 and in the PE edition, the Puppet tree is installed in
`/opt/puppetlabs/...` and all commands can be reached from
`/opt/puppetlabs/bin`.
 2016-02-19 10:38:23 +01:00
Matt Martz
c7845456a6 Various simple linting type cleanups on modules 2016-02-16 15:58:44 -06:00
jjshoe
c18afbc1ab List which version it was added 
fixes https://github.com/ansible/ansible-modules-core/issues/2605
 2016-02-12 13:09:24 -06:00
Brian Coca
3d4b5d165c avoid chmod in check mode 2016-02-09 21:49:07 -05:00
Brian Coca
4e49df7b88 revamped checkmode support in user module 
- defaulted to commands not executing in checkmode
- added force run for info gathering (for setting changed)
- added debug for what would have been run in check mode
- added check mode for spots that made changes using system calls instead of command
- removed now redundant checkmode checks

better failure now, if i missed anything, it will misreport changed value
instead of old default of actually making the change in checkmode
 2016-02-09 10:45:42 -05:00
James Cammarata
b175b11a63 Merge pull request #2954 from mattclay/user-check-mode-aix 
Make modify_user_usermod honor check mode on AIX.
 2016-02-09 08:04:55 -05:00
Matt Clay
151f981ce5 Make modify_user honor check mode on OS X. 2016-02-04 01:29:56 -08:00
Matt Clay
2645113eda Make modify_user_usermod honor check mode on AIX. 2016-02-03 23:19:17 -08:00
Luca Berruti
d820be81e5 Typo. 2016-02-03 16:57:06 +01:00
Matt Clay
8bb538aeb1 Make modify_user honor check mode on FreeBSD. 2016-02-03 02:24:12 -08:00
Toshio Kuratomi
93d02189f6 Remove duplicate documentation fields 2016-01-28 09:24:20 -08:00
Toshio Kuratomi
09e2457eb0 Fix documentation build in hostname 2016-01-21 08:37:56 -08:00
Brian Coca
1ab46f1e79 Merge pull request #2795 from hnakamur/add_warning_to_hostname_doc 
Doc: Add NOTE about hostname modules does not modify /etc/hosts
 2016-01-18 20:45:20 -05:00
Brian Coca
493f06435c Merge pull request #2768 from quinot/topic/abs_cron_file 
Allow cron_file to be an absolute path
 2016-01-18 20:35:12 -05:00
Luca Berruti
933a44ba78 cron module: add enviroment variables management 2016-01-18 22:35:12 +01:00
Brian Coca
7a0b488244 reverse order of cron commands 
does not affect linux but fixes issue with busybox caring about order
fixes #2807
 2016-01-15 15:01:36 -05:00
Jeroen Seegers
1a362cdff0 Update cron.py 
Minor update to documentation for the cron module to reflect the required "name" parameter when the value of "state" is "absent".
 2016-01-15 17:05:34 +01:00
Hiroaki Nakamura
9f2bd22a3d Doc: Add NOTE about hostname modules does not modify /etc/hosts 2016-01-12 20:29:22 +09:00
Thomas Quinot
0b38e4b407 Allow cron_file to be an absolute path 
Support specifying an absolute path (typically /etc/crontab) rather than
a path relative to /etc/cron.d, to allow modifying the main system crontab.
Particularly useful for target systems that have /etc/crontab but no
/etc/cron.d.
 2016-01-06 15:18:15 +01:00
Brian Coca
827b9596da service goes back to failing when absent 
if no tools and no init script, this should always fail
 2015-12-17 12:55:43 -05:00
Brian Coca
f3ed819241 added missing version_added 2015-12-12 17:29:27 -05:00
Brian Coca
76b926a9e8 Merge pull request #1941 from badpass/devel 
Add support for selinux user when adding a new user
 2015-12-12 17:25:15 -05:00
Michael Scherer
8ccfdb874e Remove a unneeded use of use_unsafe_shell 
Since use_unsafe_shell is suspicious from a security point
of view (or it wouldn't be unsafe), the less we have, the less
code we have to toroughly inspect for a security audit.
 2015-12-10 00:00:19 +01:00
nitzmahone
f2b72e62c0 fixed disappearing groups on OSX user module 
Ensure that we don't try to modify the groups collection if groups are not specified
 2015-12-08 16:17:21 -05:00
Dominique Barton
6128845b69 bugfix for issue #2537 2015-12-08 16:17:21 -05:00
Sina Sadeghi
ae582adce6 Update hostname.py 
Added support for FreeBSD. (http://www.freebsd.org)
 2015-11-29 18:00:44 +11:00
Brian Coca
660b47f62d minor doc fixes and reformating 
updated validate_certs feature to be 2.1
 2015-11-27 09:28:50 -08:00
Brian Coca
aad6e044e6 Merge pull request #2519 from vmindru/validate_key_auth_module 
add  validate_certs  option #2518
 2015-11-27 09:22:31 -08:00
Veaceslav (Slava) Mindru
19abe233fe Squashed commit of the following: 
commit 406214fad214359fcf13fe8c7cd3f8f8faac5386
commit 85d1c9b0a41dd075eb2683b1a7de595ca3119614
commit 4aa5049b5ae25dee71a248238201611a466a13c4
commit 65a96974c80aea1fef88d78e218ecb665d8113e1
commit 22ea5863d1dfd628735b46cc7de51c0fd33251de

Refactoring
 2015-11-26 08:48:42 -05:00
Martin André
129bac3649 Fix typo in ping module short description 2015-11-25 16:54:11 +09:00
Jordi De Groof
6584b59d91 Update facts when hostname is changed 
ansible_hostname contains the unqualified hostname
 2015-11-11 20:23:24 +01:00
Greg DeKoenigsberg
a76184ad1f @bradobro stepping down as maintainer 2015-10-28 14:39:20 -04:00
Brian Coca
4072bc1da0 rearranged systemd check, removed redundant systemctl check 
fixed unused cmd and state var assignements
 2015-10-23 18:59:05 -04:00
Brian Coca
dae3718e79 Merge pull request #2341 from reactormonk/devel 
simpler way to check if systemd is the init system
 2015-10-23 18:44:01 -04:00
Simon Hafner
6233e72001 added earlier paths to systemd 
2b583ce657
b925e72633
 2015-10-24 00:20:59 +02:00
chriskarel
32a21a9b61 Update hostname.py 
Added support for Oracle Linux.  (http://www.oracle.com/linux)
 2015-10-22 16:49:34 -05:00
Simon Hafner
e65c0f896a simpler way to check if systemd is the init system 
According to
http://www.freedesktop.org/software/systemd/man/sd_booted.html
check if the directory /run/systemd/system/ exists.
 2015-10-22 22:26:51 +02:00
Brian Coca
83b5220068 clarified ping module purpose 2015-10-21 13:58:05 -04:00
Toshio Kuratomi
dc51e1ae41 Mark a few parameters as no_log 2015-10-20 15:35:17 -07:00
Brian Coca
ccbcff8c8e better handling of checkmode for solaris 
fixes #2296
 2015-10-19 20:09:21 -04:00
Brian Coca
0307e3e649 Merge pull request #2209 from gekmihesg/devel 
Support sysctl on OpenBSD
 2015-10-09 13:26:24 -04:00
Achilleas Pipinellis
1499288c64 Add missing documentation: cron_file requires user to be set 2015-10-08 19:20:08 +03:00
gekmihesg
cdf0c8a560 Support sysctl on OpenBSD 
Fixes #1233
 2015-10-06 17:38:47 +02:00
Simon Li
d616fd12da Fix incorrect variable in group.py: user -> group 2015-10-03 01:09:03 +01:00
Brian Coca
a15aa09251 removed typo 2015-10-01 10:16:34 -04:00
Brian Coca
f6bbd2ac5b removed syslog in favor of common module logging functions 2015-10-01 00:13:58 -04:00
Brian Coca
3e42527fde revert must_exist 2015-10-01 00:13:58 -04:00
Mike Boone
539c996ede Updated link to the FAQ. 2015-09-20 22:45:51 -04:00
Brian Coca
81a7243bbb changed chmod to 2.4 compat 2015-09-14 09:54:38 -04:00
Brian Coca
813053c51c Merge pull request #986 from ssssam/cron-permissions-fix 
Fix permissions issue with 'cron' module
 2015-09-11 16:37:16 -04:00
tobbe
75fed6e6d8 Merge remote-tracking branch 'upstream/devel' into devel 2015-09-05 22:50:55 +02:00
tobbe
30576ad0c7 add text to the description, more user friendly 2015-09-05 14:39:52 +02:00
Brian Coca
e278f285aa partially reverted previous change to deal with systemctl show status not returning errors on missing service 
Now it looks for not-found key instead of running status which does return error codes when service is present but in diff states.
fixes #12216
 2015-09-02 17:11:30 -04:00
Brian Coca
bbcfb1092a check systemctl status before show as show will not return antyhing other than rc=0 even when it fails. 2015-09-01 10:58:15 -04:00
Marius Gedminas
5595a9f81d authorized_key: fix example in documentation 
'key=' cannot be pointing to a file name; it needs to be the key itself as a string (or a URL).
 2015-08-31 09:08:35 +03:00
Tim Rupp
48f522455d Add hostname support for Kali linux 2.0 
This patch allows the hostname module to detect and set the hostname for a
Kali Linux 2.0 installation. Without this patch, the hostname module raises
the following error

   hostname module cannot be used on platform Linux (Kali)

Kali is based off of Debian.
 2015-08-28 20:35:24 -07:00
Benno Joy
8bf800d5c5 Merge pull request #1973 from mgedmin/user-no-ssh-keygen-in-check-mode 
user: don't generate SSH keys in check mode
 2015-08-27 12:13:06 +05:30
Marius Gedminas
4ae4331a6b user: don't generate SSH keys in check mode 
Fixes https://github.com/ansible/ansible/issues/11768

Test plan:

- (in a Vagrant VM) created a user 'bob' with no ssh key
- ran the following playbook in check mode:

    ---
    - hosts: trusty
      tasks:
        - user: name=bob state=present generate_ssh_key=yes

- saw that ansible-playbook reported "changes=1"
- saw that /home/bob/.ssh was still absent
- ran the playbook for real
- saw that /home/bob/.ssh was created
- ran the playbook in check mode again
- saw that ansible-playbook reported no changes
- tried a variation with a different username for a user that didn't
  exist: ansible-playbook --check worked correctly (no errors, reported
  "changed")
 2015-08-26 08:51:52 +03:00
Simon Li
428550e179 Don't fail in check_mode if user exists 
PR #1651 fixed issue #1515 but the requirement for path to be defined is unecessarily strict. If the user has previously been created a path isn't necessary.
 2015-08-21 17:55:28 +01:00
tobbe
8fa1e9515b Add suport for selinux user when adding a new user on selinux enabled 
systems
 2015-08-20 22:34:32 +02:00
Александр Костырев
31ec203583 Fix documentation of authorized_key.py 
man for sshd http://www.openbsd.org/cgi-bin/man.cgi/OpenBSD-current/man8/sshd.8?query=sshd
says there's no "host" option but "from".
 2015-08-17 18:00:04 +03:00
Brian Coca
5d7cb981d3 made continue into a pass (there was no loop) 2015-08-13 10:05:30 -04:00
Brian Coca
6d7428527d minor doc fixes 2015-08-12 23:55:01 -04:00
Brian Coca
2fd171a5e1 Merge pull request #878 from EvanK/system-cron--disabled 
cron module: Add disabled option for commented jobs
 2015-08-12 23:50:47 -04:00
Brian Coca
cd0a1947c2 Merge pull request #1899 from austinhyde/fix-service-rcconf-newlines 
Service module incorrectly handles lines not ending in a newline
 2015-08-12 19:34:34 -04:00
Brian Coca
7a2687178e avoid shlex exceptions in rc parsing (happens with multiline entries) 
fixes #1898
 2015-08-12 18:10:24 -04:00
Brian Coca
0c403781a7 Merge pull request #1905 from evverx/fix-legacy-services-enabled 
Fix service.enabled on: Debian 8, Ubuntu 15.04
 2015-08-12 10:18:50 -04:00
Evgeny Vereshchagin
55e8863cb4 Fix service.enable on: Debian 8, Ubuntu 15.04 
Workaround for https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=751638
See https://github.com/systemd/systemd/issues/937
 2015-08-12 14:13:19 +00:00
Brian Coca
072c4f38ea Merge pull request #62 from 0x46616c6b/user-add-skeleton-support 
Add support for skeleton directory (useradd -k) in user module
 2015-08-12 09:17:35 -04:00
Austin Hyde
5c25057868 Always end rc.conf entries with a new line 2015-08-10 17:42:26 -04:00
Brian Coca
0e9fccd098 changed verbose override variable 2015-07-29 14:54:19 -04:00
James Cammarata
bc60c893f5 Prefer non-zero rc's over text analyis in service status checks 
Fixes ansible/ansible#10441
 2015-07-27 12:51:30 -04:00
saito-hideki
e91ad2ab6c Add Solaris support in hostname module 
feature_pull_request: #1804
 2015-07-25 23:32:55 +09:00
saito-hideki
b991a2708b Add Solaris support in hostname module 2015-07-25 21:48:13 +09:00
Brian Coca
a2b713edad Merge pull request #1790 from renard/allow-star-password-on-openbsd-2015-07-24 
[user] Allow '*' as empty password.
 2015-07-24 18:55:13 -04:00
KIKUCHI Koichiro
a3b9fb58bf Fix service enabled check failure on FreeBSD 2015-07-24 21:05:16 +09:00