Matt Clay
775539a8b8
Fix api_profile choices in Azure docs fragment.
2018-03-20 11:07:34 -07:00
Dag Wieers
51662acc6c
Clean up Grafana docs a bit ( #37516 )
...
* Clean up Grafana docs a bit
But more is needed, default values, missing choices, proper
descriptions, actual sentences :-)
* Remove validate-modules entries
2018-03-17 02:53:26 +01:00
Dag Wieers
cdd21e2170
Clean up module documentation ( #36909 )
...
* Clean up module documentation
This PR includes:
- Removal of `default: None` (and variations)
- Removal of `required: false`
- Fixing booleans and `type: bool` where required
* Fix remaining (new) validation issues
2018-03-15 22:15:24 +01:00
Matt Martz
8980d275a0
Support recursive suboptions schema ( #37206 )
...
* Support recursive suboptions schema
* Remove todo line, add voluptuous version constraint
2018-03-09 17:09:58 -06:00
Pilou
bc6b96d42e
webfaction modules: fix broken import ( #35024 )
...
* webfaction_app: fix broken import
* doc: use formatting functions
* webaction_db: fix broken import
* webfaction_domain: fix broken import
* webfaction_mailbox: fix broken import
* webaction_site: fix broken import
* webfaction modules: fix doc
2018-03-07 06:22:06 -08:00
René Moser
e1297af18a
cs_router: fix missing doc ( #37107 )
...
* cs_router: fix missing doc
* update ignore.txt
2018-03-07 13:34:39 +00:00
René Moser
67d8c8f5c6
cs_ip_address.py: fix missing doc ( #37109 )
...
* cs_ip_address.py: fix missing doc
* update ignore.txt
2018-03-07 13:15:39 +00:00
René Moser
2559e832df
cloudstack: fix common E324 in docs ( #37082 )
...
Notes about precedence of common args.
Partly fixes E324.
2018-03-07 11:09:08 +01:00
René Moser
4705edd1a7
letsencrypt: add new param force ( #37077 )
...
* letsencrypt: add new param force to ignore remaining days
* letsencrypt: fix E325
2018-03-06 20:51:24 +01:00
Mikhail Naletov
7d0e1f92f4
[terraform] Support initializing modules and providers at runtime ( #36996 )
...
* Fixes #36994
Added function for force initializing modules and providers
Added type for force_init parameter
2018-03-05 11:01:53 -05:00
Matt Martz
ca092b5c26
Skip top level args that are the same as args in provider in doc<->arg_spec comparisons ( #36911 )
2018-03-01 10:47:20 -06:00
Gaurav Rastogi
60e39b9718
Updated the documentation of modules to match argspec including the type setting for bool parameters ( #36821 )
2018-02-28 14:38:03 +00:00
Matt Clay
dc71c2197f
More code-smell sanity test updates. ( #36830 )
...
* Add test for missing Azure requirements.
* Improve readability.
* Enhance no-unicode-literals code-smell test.
2018-02-28 00:50:00 -08:00
Matt Clay
ac1698099d
Overhaul additional sanity tests. ( #36803 )
...
* Remove unnecessary sys.exit calls.
* Add files filtering for code-smell tests.
* Enhance test-constraints code-smell test.
* Simplify compile sanity test.
* Pass paths to importer on stdin.
* Pass paths to yamllinter on stdin.
* Add work-around for unicode path filtering.
* Enhance configure-remoting-ps1 code-smell test.
* Enhance integration-aliases code-smell test.
* Enhance azure-requirements code-smell test.
* Enhance no-illegal-filenames code-smell test.
2018-02-27 15:05:39 -08:00
Matt Clay
60a24bbdaa
Pass code-smell paths on stdin.
2018-02-27 00:36:16 -08:00
Mário Santos
8b52006d5c
Fix sanity checks in OpenStack docs fragment ( #36722 )
...
* Fix sanity checks in OpenStack docs fragment
Signed-off-by: Mário Santos <mario.rf.santos@gmail.com>
2018-02-26 13:05:53 +00:00
Ed Costello
2a0c7c4331
Fix documentation of validate_certificates option in aws doc_fragment.
...
Unignore sanity test failures for AWS modules caused by this common
fragment.
2018-02-23 13:21:44 -08:00
Pilou
07927f52ae
filesystem: fix documentation ( #36556 )
2018-02-23 10:59:38 +00:00
Matt Clay
5b5cba5e50
Update more code-smell tests. ( #36570 )
...
* Enhance use-compat-six code-smell test.
* Enhance use-argspec-type-path code-smell test.
* Enhance replace-urlopen code-smell test.
* Enhance boilerplate code-smell test.
* Enhance no-underscore-variable code-smell test.
2018-02-22 08:08:29 -08:00
Matt Clay
891f4f3b2d
Upgrade more code-smell tests. ( #36560 )
...
* Enhance no-dict-* code-smell tests.
* Enhance no-basestring code-smell test.
* Enhance no-get-exception code-smell test.
* Enhance empty-init code-smell test.
* Enhance required-and-default-attribute test.
* Remove unused code-smell test.
2018-02-21 20:09:13 -08:00
Jordan Borean
ef4f8851dc
win_feature: better error handling to make it easier to debug issues ( #36491 )
...
* win_feature: better error handling to make it easier to debug issues
* removed ignroed pslint rules that are no longer needed
2018-02-22 11:33:48 +10:00
John R Barker
5d0ed38e3a
Fixup VMware module docs issues ( #36409 )
...
Fix various argspec vs documentation issue
2018-02-21 15:20:42 +00:00
Matt Clay
2b6ac4561b
Add support for enhanced code-smell tests. ( #36332 )
...
* Add support for enhanced code-smell tests:
- Path selection handled by ansible-test.
- Optional path filtering based on extension.
- Optional path filtering based on prefixes.
- Optional lint friendly output.
* Enhance no-assert code-smell test.
* Enhance no-tests-as-filters code-smell test.
2018-02-20 13:37:23 -08:00
Matt Clay
a9b58b84d8
Fix path handling in validate-modules sanity test.
2018-02-20 11:02:42 -08:00
ABond
591695932e
Fix bug in DigitalOcean module_util ( #36352 )
2018-02-18 07:47:26 +05:30
Abhijeet Kasurde
5242914ae5
Fix digital ocean issues ( #36347 )
...
Remove module from ignore lists and some documentation fix in
digital_ocean_block_storage and digital_ocean module.
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-02-17 22:48:52 +05:30
Matt Clay
ff922ac2ad
Import sanity test for main() in Ansible modules.
2018-02-16 11:17:36 -08:00
John R Barker
365630df65
Update ignore to deal with renamed files ( #36323 )
2018-02-16 19:07:36 +00:00
Matt Clay
80b55e3742
Add missing validate-modules ignore entries.
2018-02-16 01:40:45 -08:00
Matt Martz
831a9d67d7
Arg spec doc comparison fixes ( #36265 )
...
* Ensure we merge doc fragments early, for comparisons
* Perform boolean conversion from arg_spec data too
* Update valdiate-modules ignore.txt due to recent changes
2018-02-15 22:49:11 +00:00
Matt Martz
50adc5409b
Add several new doc<->arg_spec checks ( #36247 )
...
* Add several new doc<->arg_spec checks. See #18183
* Update ignore.txt for validate-modules
2018-02-15 20:34:40 +00:00
John R Barker
7dfa11cd8a
Notice in 2.6 remove in Ansible 2.10 ( #36191 )
...
Update the list of allowed removed_in for modules
2018-02-14 09:24:18 -08:00
John R Barker
3e22efa0ba
Ensure docs are valid before checking deprecation ( #36160 )
2018-02-14 14:47:31 +00:00
John R Barker
17c0d3eae0
Fix more docs vs argspec ( #36048 )
2018-02-12 17:42:25 +00:00
Jordan Borean
a0178b79f1
win_uri: fixes ( #35487 )
...
* win_uri: moved away from Invoke-WebRequest and fixed multiple issues
* fixes from review
2018-02-07 20:58:47 +11:00
Pilou
54882d4715
dimensiondata: fix broken import ( #35634 )
...
* Fix broken import
* Remove never reached statements
exit_json and fail_json methods call sys.exit, subsequent statements
can not be executed.
2018-02-07 00:44:42 +01:00
Toshio Kuratomi
86242e6871
Enable wildcard import pylint ( #35786 )
...
* Wildcard imports should be taken care of. Enable the pylint check for them
* Remove wildcard import code-smell test as we're now checking via pylint
* Add unused-wildcard-import as ignored in our compat code.
These three files use wildcard imports so that they can export
symbols in a compatible location. The real code lives elsewhere.
So disable the pylint tests for the relevant sections of code.
2018-02-06 15:17:49 -08:00
Toshio Kuratomi
a5b80464df
Fix packaging/os modules for wildcard imports and get_exception
2018-02-06 08:44:49 -08:00
Abhijeet Kasurde
1119709b56
Remove get_exception from modules
...
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-02-06 07:49:24 -08:00
Pierre-Louis Bonicoli
2646ea9b86
yum_repository: Python 3.7 error have been fixed
...
See 232dc7110c
2018-02-02 09:43:58 -08:00
Toshio Kuratomi
4a48fdba1d
Update code smell blacklists ( #35621 )
...
Update blacklist for get_exception, boilerplate, and no-wildcard.
f5, lenovo, and junos have updated their code.
2018-02-01 12:24:07 -08:00
Matt Clay
b9c5147be2
Move import sanity test files into own directory. ( #35593 )
2018-02-01 09:52:31 -08:00
Matt Clay
2d565d14ed
Add pslint sanity test settings.
...
Globally ignore rule: PSUseShouldProcessForStateChangingFunctions
2018-01-31 06:31:05 -08:00
Jordan Borean
62b87bc925
change .encode to to_bytes ( #35522 )
...
ignore backup dir in test integration targets folder
2018-01-31 08:58:03 +10:00
Matt Martz
c282e4e00f
Replace LooseVersion comparison with int/float comparison. Fixes #35435 ( #35519 )
2018-01-30 15:27:22 -06:00
Matt Martz
f659cc5963
Guard against assignments that are not ast.Name in docs parsing ( #35513 )
2018-01-30 12:56:16 -06:00
John R Barker
a23c95023b
Module deprecation: docs, scheme and tests ( #34100 )
...
Enforce module deprecation.
After module has reached the end of it's deprecation cycle we will replace it with a docs stub.
* Replace deprecated modules with docs-only sub
* Use of deprecated past deprecation cycle gives meaningful message (see examples below)
* Enforce documentation.deprecation dict via `schema.py`
* Update `ansible-doc` and web docs to display documentation.deprecation
* Document that structure in `dev_guide`
* Ensure that all modules starting with `_` have a `deprecation:` block
* Ensure `deprecation:` block is only used on modules that start with `_`
* `removed_in` A string which represents when this module needs **deleting**
* CHANGELOG.md and porting_guide_2.5.rst list removed modules as well as alternatives
* CHANGELOG.md links to porting guide index
To ensure that meaningful messages are given to the user if they try to use a module at the end of it's deprecation cycle we enforce the module to contain:
```python
if __name__ == '__main__':
removed_module()
```
2018-01-30 12:23:52 +00:00
Jordan Borean
4da19f2d6b
Added code-smell check to verify filenames are allowed with Windows ( #35436 )
2018-01-29 13:46:02 -08:00
Matt Clay
7abdab6c9e
Convert ansible-test compile into a sanity test.
2018-01-25 09:45:36 -08:00
Pilou
0ce8d389a4
azure_rm_dnsrecordset: fix broken import and minor updates ( #34983 )
...
* fix broken import
Error was:
lib/ansible/modules/cloud/azure/azure_rm_dnsrecordset.py:223:0: NameError: name 'ARecord' is not defined
* doc: use formatting functions
* remove unused dict
2018-01-25 09:39:49 -08:00