Will Thames
daac0e3a3e
Improved error handling
...
More tests, particular for failure testing
2016-12-08 11:22:30 -05:00
Patrik Lundin
25c3c03a11
Tweak error checking for "enabled" code.
...
Based on input from @jarmani:
* A return value of 2 now means a service does not exist. Instead of
trying to handle the different meanings of rc after running "status",
just look at stderr to know if something failed.
* Skip looking at stdout to make the code cleaner. Any errors should
turn up on stderr.
2016-12-08 11:22:30 -05:00
Patrik Lundin
32cb025b85
Fail if "rcctl status" writes to stderr.
2016-12-08 11:22:30 -05:00
Patrik Lundin
03d4b76b14
Check rc and print error message if any.
...
It is probably good to use stdout before printing a generic error
message as well.
2016-12-08 11:22:29 -05:00
Patrik Lundin
38d8db473f
Make "enabled" code aware of --check mode.
2016-12-08 11:22:29 -05:00
Jonathan Armani
d1433eca14
Add enable / disable of services for OpenBSD if rcctl is present
2016-12-08 11:22:29 -05:00
Will Thames
22a3b3f811
RDS rewrite to use boto.rds and boto.rds2
...
Using rds2 allows tags and the control over whether or not DBs are
publicly accessible.
Move RDS towards a pair of interfaces implementing the details of rds
and rds2
Added tests to ensure that all operations work correctly as well as
requirements files that allow virtualenvs to test either boto.rds or
boto.rds2
2016-12-08 11:22:29 -05:00
Antti Salminen
75e15e2ae9
Find the actual commit annotated tags refer to instead of the tag object.
2016-12-08 11:22:29 -05:00
willthames
ef88ff6dd8
Added the ability to remove snapshots
...
Added state option, and accompanying snapshot_id option for
when state=absent.
2016-12-08 11:22:29 -05:00
Michael DeHaan
f875cc5197
Remove potentially out of date or specific product references.
2016-12-08 11:22:29 -05:00
Michael DeHaan
76efaa6cfb
More EC2 doc tweaks
2016-12-08 11:22:29 -05:00
Michael DeHaan
590d20db24
Misc EC2 doc tweaks.
2016-12-08 11:22:29 -05:00
Toshio Kuratomi
ddc81c7b93
Escape % in db+table names before adding to a format string being passed into db.execute()
...
Fixes #416
2016-12-08 11:22:29 -05:00
Dan
fe787f1bc9
Adds a login_unix_socket option to the postgresql_privs module.
2016-12-08 11:22:29 -05:00
Dan
ee65c55fb0
Adds a unix_socket/login_unix_socket option to the postgresql_user module.
2016-12-08 11:22:29 -05:00
Dan
789ee410f1
Adds a login_unix_socket option to the postgresql_db module.
2016-12-08 11:22:29 -05:00
René Moser
ceeeea84cd
yum: add update_cache option
...
Yum does not always update to latest package version unless metadata cache has expired. By runing yum makecache, we ensure the metadata cache has been updated.
Signed-off-by: René Moser <mail@renemoser.net>
2016-12-08 11:22:29 -05:00
Toshio Kuratomi
5734838cd1
Fix module traceback instead of returning an error
2016-12-08 11:22:29 -05:00
Eric
11bd0fed9d
Fix lineinfile documentation typo
2016-12-08 11:22:28 -05:00
Achilleas Pipinellis
872f6aa559
Clarify supported init systems.
2016-12-08 11:22:28 -05:00
follower
4889701874
Fix typo of "rules_egress"
...
Or is "rules_egree" supposed to be a plural? The sentence is difficult to parse.
Maybe the correct fix is to "Purge existing rules on security group that are not found in rules_egress"?
2016-12-08 11:22:28 -05:00
Pascal Borreli
187b07e6c0
Fixed typo
2016-12-08 11:22:28 -05:00
Fabrice Bernhard
3d437b068e
Typo in comments
...
Credit goes to @kbsali
@pborreli : you did not see that one? :-)
2016-12-08 11:22:28 -05:00
Toshio Kuratomi
e8081baca9
Fix for single role_attr
2016-12-08 11:22:28 -05:00
Toshio Kuratomi
47b009b001
Add a bare grant to the list of allowed privileges
2016-12-08 11:22:28 -05:00
Toshio Kuratomi
b00e6464e9
Fix cornercase tracebaxk when detecting whether submodules changed
2016-12-08 11:22:28 -05:00
Devin Christensen
b2829cf6b9
Fix user_alter in postgresql_user
2016-12-08 11:22:28 -05:00
Devin Christensen
ff7a9eb625
Fix user_add in postgresql_user
2016-12-08 11:22:28 -05:00
Toshio Kuratomi
bed60553ca
Escape mysql identifiers
2016-12-08 11:22:28 -05:00
Toshio Kuratomi
87b2afc272
Correct new function name
2016-12-08 11:22:28 -05:00
Toshio Kuratomi
3e9771f544
Normalize privs and flags to uppercase so comparisons against allowed names will work
2016-12-08 11:22:28 -05:00
Toshio Kuratomi
e0ac340f59
Make sure we quote or confirm good all user provided identifiers
2016-12-08 11:22:28 -05:00
Toshio Kuratomi
d3787840a4
Audit escaping of identifiers in the postgresql_user module
2016-12-08 11:22:28 -05:00
Toshio Kuratomi
32aaa07325
More robust quoting of database identifiers
...
Note: These aren't database values, those are already using the
appropriate Pyhton DB API method for quoting.
2016-12-08 11:22:27 -05:00
Toshio Kuratomi
f7fafa8c16
Cannot readlink() on a hard link
2016-12-08 11:22:27 -05:00
Toshio Kuratomi
3e09de7aef
Fix git module checking out correct version after initial clone
...
Fixes #313
2016-12-08 11:22:27 -05:00
Toshio Kuratomi
1af6a85492
Correct variable name
2016-12-08 11:22:27 -05:00
Brian Coca
78fb3217d6
service now detects systemd is actually running, not just installed
2016-12-08 11:22:27 -05:00
Jonathan Mainguy
a71ce0615a
fixes user module for rhel5 by using -n instead of -N, all other distros will still use -N
2016-12-08 11:22:27 -05:00
Henry Finucane
2363074dd8
If force=true, ignore python-apt's advice
...
This lets you downgrade packages, for instance.
2016-12-08 11:22:27 -05:00
IndyMichaelB
07d4ddfeff
docfix for vsphere_guest.py
...
Corrected parameter name from user to username in documentation
2016-12-08 11:22:27 -05:00
Sam Kottler
bb9c7acc2f
Remove trailing whitespace in digital_ocean_domain
2016-12-08 11:22:27 -05:00
Nejc Zupan
442c8a5457
digital ocean: Remove unsupported states
2016-12-08 11:22:27 -05:00
Toshio Kuratomi
81978cbacb
Fix retrieval of package version in apt module
2016-12-08 11:22:27 -05:00
Toshio Kuratomi
83e43415da
Documentation update for apt version wildcards from bryanlarsen
2016-12-08 11:22:27 -05:00
Toshio Kuratomi
9472a27345
Clean up the docker module just a little so that we can unittest the get_split_image_tag function
2016-12-08 11:22:27 -05:00
Toshio Kuratomi
f45e70fdbc
Moving unittests to the main ansible repo for now
2016-12-08 11:22:27 -05:00
Toshio Kuratomi
615b954cd8
Update package_status and install to account for wildcarded versions.
2016-12-08 11:22:27 -05:00
Toshio Kuratomi
1ca1b80fe8
Decide to allow pkgname and version wildcards so that things like libxml2*=2.9* would work
2016-12-08 11:22:27 -05:00
Toshio Kuratomi
37fa22eb93
Cache pkg name list so we don't recreate the list for every package
2016-12-08 11:22:26 -05:00