Commit graph

48293 commits

Author SHA1 Message Date
Sloane Hertel
c1f1b2029c
Support vars plugins in collections (#61078)
* Move var plugins handling to a separate file

* Allow var plugins to require whitelisting

* Add global configuration ('demand', 'start') for users to control when they execute

* Add 'stage' configuration ('all', 'task', 'inventory') for users to control on a per-plugin basis when they execute

* Update ansible-inventory and InventoryManager to the global and stage configuration

* Update host_group_vars to use stage configuration and whitelisting

* Add documentation for using new options and to the developer's guide

* Add integration tests to exercise whitelisting and the new configuration options, using vars plugins in collections, and maintain backward compatibility

* Changelog

Co-Authored-By: Brian Coca <brian.coca+git@gmail.com>
Co-Authored-By: Sandra McCann <samccann@redhat.com>
2019-11-04 11:41:14 -05:00
Mads Jensen
39bf09517a wait_for - remove an obsolete fallback for Python 2.6 (#63988) 2019-11-04 11:39:19 -05:00
Mark Chappell
8c8077b5be Amazon related Sanity test fixups (remaining batch 1) (#64368)
* Remove Sanity test ignore.txt entries

* Fixup boilerplate

* Remove use of blacklisted _ variable name

* cloudformation: Add an explicit removal version for template_format

This option's been ignored since ansible 2.3

* General docs cleanup to clear sanity errors

* elasticache_parameter_group: Add list of choices

- matches documented choices
- other values wouldn't have worked

* data_pipeline: Deprecate 'version' - always ignored

* Add deprecation documentation
2019-11-04 15:13:27 +00:00
Mads Jensen
3126c38f8a Replace import of pycompat24.literal_eval with ast.literal_eval. (#64088) 2019-11-04 09:55:08 -05:00
Sam Doran
c67c23234a
clean_facts - use correct variable when evaluating the string (#64284)
A regexp object has no .startswith() method, which caused an unnecessary
try/except block to be added to handle this.
2019-11-04 09:44:10 -05:00
Martin Nečas
816e194e37 ovirt_vm: update cpu_threads docs (#64380) 2019-11-04 07:19:07 -05:00
Xu Yuandong
9e3b1f3b32 Doc notes 2 (#64347)
* addd

* all  update

* add/fix notes about modules work with connection

* duplication of key "notes"

* Update ce_evpn_bgp_rr.py

* Update ce_evpn_bgp.py
2019-11-03 21:56:57 -05:00
Xu Yuandong
1d40d429a0 Doc notes 5 (#64350)
* addd

* all  update

* add/update notes.

* add/updates notes.
2019-11-03 21:46:18 -05:00
Xu Yuandong
25e03b1e75 Doc notes 6 (#64351)
* addd

* all  update

* update/add notes.
2019-11-03 21:46:07 -05:00
Xu Yuandong
ad0769c095 Doc notes 3 (#64348)
* addd

* all  update

* update/add notes.
2019-11-03 21:35:12 -05:00
Xu Yuandong
703f7a149a Doc notes 4 (#64349)
* addd

* all  update

* add/update notes.
2019-11-03 21:35:03 -05:00
Xu Yuandong
705c014ec3 Doc notes 1 (#64346)
* addd

* all  update

* add notes to set modules works with C(connection)
2019-11-03 21:25:24 -05:00
Ganesh Nalawade
c27e47327f
Refactor CLI prompt mode check for network plugins (#63945)
* Refactor CLI prompt mode check for network plugins

*  Move the CLI prompt mode check logic from action plugin
   to the controller side with the cliconf plugins.

*  This refactor also allows the network modules
   to initialise the persistent connection with remote device
   only when it is required.

* Fix review comments
2019-11-03 04:10:30 +05:30
Andrey Klychkov
73526b9d65 mysql_variables: add mode parameter (#63547)
* mysql_variables: add mode parameter

* mysql_variables: add mode parameter, add changelog fragment

* mysql_variables: add mode parameter, fix

* mysql_variables: add mode parameter, fix

* mysql_variables: add mode parameter, fix

* mysql_variables: add mode parameter, fix sanity

* mysql_variables: add mode parameter, remove warns

* mysql_variables: add mode parameter, refactoring

* mysql_variables: add mode parameter, fix logic
2019-11-02 10:16:28 +01:00
Chris Smart
42b290b781 cloud/openstack: fix os_server_action errors when wait is False (#64330)
Using os_server_action to perform start, stop and pause actions on a
server in OpenStack results in an error when 'wait' is False.

The command is successfully sent to OpenStack, however Ansible fails the
task:

  fatal: [127.0.0.1]: FAILED! => {
    "changed": false,
    "msg": "New-style module did not handle its own exit"
  }

This patch ensures that those actions always exit, whether running with
'wait' set to True or False.

As we are not waiting to confirm the result, this assumes that the
actions were successful.

Fixes #62958

Signed-off-by: Chris Smart <chris.smart@humanservices.gov.au>
2019-11-02 04:42:34 -04:00
Matt Clay
78e476eb20 Increase unit test timeout in CI. 2019-11-01 17:16:07 -07:00
Chris Budzilowicz
135c853588 reduce docs/docsite/README to essential info (#64287) 2019-11-01 15:35:40 -05:00
willtome
bbbaf0dfe7 VMware Inventory Enhancements (#63938)
* Fixes #63937

* Add the environment variables VMWARE_HOST, VMWARE_USER, and VMWARE_VALIDATE_CERTS for consistency

* Follow the general pattern for config file naming requirements and update the documentation
2019-11-01 16:16:56 -04:00
Alicia Cozine
6e07d4c1d9 add general facts-to-info paragraph (#64293) 2019-11-01 16:09:03 -04:00
Sloane Hertel
371d7aae31
Use templating in HostVarsVars __repr__ (#64282)
* Fix HostVarsVars templating

* Add some tests for HostVars and HostVarsVars templating

* changelog
2019-11-01 15:51:34 -04:00
The Magician
5dff5603af New Module: gcp_compute_reservation (#64133) 2019-11-01 13:46:42 -04:00
The Magician
6e63210620 New Module: gcp_compute_target_instance_info (#64136) 2019-11-01 13:46:34 -04:00
The Magician
d865b7da71 Bug fixes for GCP modules (#64193) 2019-11-01 13:46:13 -04:00
Pierre Prinetti
2444fae208 Add a named parameter to the filter to_uuid (#64057)
Let the caller choose a namespace for `to_uuid` and document the
behaviour of both the default case, and the new explicit case.

This PR does not change the existing behaviour of the `to_uuid` UUIDv5
filter.
2019-11-01 13:11:34 -04:00
Geoffrey Blake
7b7f15cb3a Fix ec2_instance module where if placement_group and tenancy are (#63340)
both set in params, the placement_group setting is ignored.
2019-11-01 10:10:07 -07:00
Matt Clay
d2562cde1c Temporarily increase CI timeout. 2019-11-01 10:10:02 -07:00
Toshio Kuratomi
87de146038 Exclude the ansible-test script from the main rpm package (#64277)
We want the script to live in the ansible-test rpm subpackage alongside
of its libraries

Fixes #64275
2019-11-01 12:14:36 -04:00
Patrick O'Brien
c76e074e4c Callback: removing args from task_fields from Sumologic and Splunk plugin(#63527)
CVE-2019-14864 Ansible: Splunk and Sumologic callback plugins leak sensitive data in logs

Fixes #63522

Signed-off-by: Patrick O’Brien <patrick.obrien@thetradedesk.com>
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-11-01 19:51:11 +05:30
Sandra McCann
56d5fd34e3 [Docs-Release-2.9] clean up porting guide links and network text (#64124)
* clean up porting guide links and network text
* fix shippable error
2019-11-01 08:56:41 -05:00
Ganesh Nalawade
60276d3d8d
Fix network plugin config option load from collection (#64046)
* Fix network plugin config option load from collection

Fixes #63975

* Update the complete sub-plugin name within network
  connection plugins to handle sub-plugin in collection
  scenario.

* Fix review comments
2019-11-01 11:25:28 +05:30
Sandra McCann
3f808d9ed6 [Doc-Release-2.9] update release and maintenance page for 2.9 (#64166)
* update release and maintenance page for 2.9
* only 2.4 and earlier used the old changelog system
2019-10-31 20:20:34 -05:00
Sandra McCann
f264e9cfca update backport instructions to use stable-2.9 (#64168) 2019-10-31 19:49:17 -05:00
Sandra McCann
4d087ba6bd reorder porting guides (#64122) 2019-10-31 19:48:05 -05:00
Sandra McCann
0812516208 [Doc-Release-2.9] Add Roadmap 2.10 (#64162)
* add 2.10 roadmap shell and remove very old roadmaps
2019-10-31 19:46:33 -05:00
Sandra McCann
c63ef6d911 update too old version to 2.4 (#64167) 2019-10-31 19:44:53 -05:00
Sandra McCann
409545825f docs: update to latest 3 versions (#64109) 2019-10-31 19:32:05 -05:00
Bill Dodd
4349ab5777 Add option to specify ID of System/Manager/Chassis to modify (#62921)
* add option to specify ID of System/Manager/Chassis to modify

* added version to deprecate() call

* fix merge TODOs to use new self.systems_uri variable
2019-10-31 22:09:48 +00:00
Mads Jensen
c3838b5d73 Replaces deprecated usage of functions in ansible.module_utils.basic (#63990) 2019-10-31 16:22:44 -04:00
Sergey
1ad3879430 Add podman_volume_info module (#63380)
Add module podman_volume_info that collects data about podman
volumes on the host. Acts as docker_volume_info module.

Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2019-10-31 16:17:33 -04:00
Sam Doran
d5fbe6573b
paramiko_ssh - Improve authentication error message (#64157)
The error is not always an invalid username/password. It could be a connection timeout or refusal.
2019-10-31 15:39:53 -04:00
Danilo Bargen
35c415de98 get_url integration test: Fix missing conditional (#64100) 2019-10-31 15:17:38 -04:00
brasswood
090dca7569 Note for virtual environment users (#64040) 2019-10-31 11:47:09 -04:00
Alejandro Lazaro
63ce7d57b1 Remove extra dot at the end of the sentence (#64149)
Dot is already set in display.deprecated.
2019-10-31 11:07:23 -04:00
Bill Dodd
b4cd9086dc allow setting multiple BIOS attributes at a time (#62764)
* allow setting multiple BIOS attributes at a time

* fix documentation string errors
2019-10-31 14:47:05 +00:00
Chris Van Heuveln
ec1c5585af nxos_vrf: N6K regression test failures (#63277)
* nxos_vrf: N6K regression test needs 'nv overlay evpn'

* Add delay for vrf creation

* Revert "Add delay for vrf creation"

This reverts commit 8afa5281ff4b3c5a1775fbd40c5acb7ab5ecdf68.

* Add vrf_error_check w/delay to module

* whitespace

* httpapi fixes

* /input/input_data/ - 'input' is a built-in

* shippable retry
2019-10-31 18:17:39 +05:30
Sumit Jaiswal
be1bcc7450
fix bug 63761 (#63901) 2019-10-31 18:09:03 +05:30
Pavan Bidkar
548fa65ac6 VMware: Allow dash in Windows server dnsname (#64052)
Fixes: #62810
2019-10-31 14:02:52 +05:30
panyy3
8316fa66e8 add GetManagerServices and SetManagerServices (#62815)
* add GetManagerServices in redfish_info module, and add SetManagerServices in redfish_config module

* fix incorrect-version-added, fix incorrect Comparison to None, fix continuation line under-indented for visual indent, fix line too long, fix blank line at end of file

* update parameter format to allow multi-services update and additional parameter update

* fix bad-whitespace and trailing-whitespace detected by ansible-test

* change command name from GetManagerServices/SetManagerServices to GetNetworkProtocols/SetNetworkProtocols, and update parameter name to network_protocols with dict type, and enhance set_network_protocols() to follow suggestions

* donot need to import ast any more

* fix problems caused by code merge
2019-10-31 07:57:20 +00:00
Mark Chappell
4e8bb334a9 Sanity test fixups: AWS VPC related modules (#64089)
* Add missing boilerplate

* Avoid blocklisted variable name '_'

* doc fixups

* Remove defaults for required parameters

* Remove explicit definition of 'region' from argument spec
it's automatically added by ec2_argument_spec and redefining removes the aliases

* remove sanity ignore entries for AWS VPC related modules

* Suggested Review changes
2019-10-30 14:28:14 -07:00
John R Barker
56db433d63 BOTMETA: Enable automerge (#64114)
We are in the process of enacting our migration strategy of content out of the Ansible repo, and auto-merge privileges being revoked at this point in time was an accidental byproduct of that migration strategy.

TL;DR I jumped the gun, sorry, Bot will catch up and merge open PRs shortly.
2019-10-30 16:37:45 -04:00