Commit graph

2772 commits

Author SHA1 Message Date
Michael DeHaan
6e6884d6e0 Merge pull request #4789 from mohangk/devel
Fix for connect method parameter order
2013-11-03 08:49:00 -08:00
Mohan Krishnan
56bd9a14d5 Fix for connect method parameter order 2013-11-03 14:48:35 +07:00
Steve Tjoa
626d41c1d1 Changed parameter from 'user' to 'name' in the examples to coincide with the specs. 2013-11-02 22:42:44 -07:00
Mohan Krishnan
0ae9128c7b ec2_eip connect method references module var that is not passed in 2013-11-03 05:18:27 +07:00
Pedro Romano
78c616f271 Obsolete attempts at determining the full path to the desired
'easy_install' executable were still left behind and need to be removed
for the customizable 'executable' task argument to correctly work:
'_get_easy_install' should take care of all the functionality related to
determining the correct 'easy_install' executable to use.
2013-11-02 19:25:51 +00:00
Michael DeHaan
334dcfa2fa Update module documentation. 2013-11-02 09:34:44 -04:00
Michael Scherer
1ef9bed752 Try/finally is a python 2.5 construct, so not working
on EL5. Fix #4763
2013-11-02 11:24:29 +01:00
James Laska
2a5874b94f Honor wait on ec2 instance termination 2013-11-01 18:57:20 -04:00
Yegor Minin
df5fd0e0d0 apt: allow specifying dpkg options
This will allow specifying dpkg options as a string passed over to apt
command. dpkg_options expects a comma-separated string of options to be
passed as dpkg options which will be further expanded. For example
dpkg_options='force-confdef,force-confold' will end up as
-o \"Dpkg::Options::=--force-confold\" when passed to apt
Example usage would be:
-m apt -u ubuntu -s \
 -a "upgrade=dist update_cache=yes dpkg_options='force-confold'"
or
apt: upgrade=dist update_cache=yes dpkg_options='force-confold'
2013-11-01 20:11:40 +02:00
Michael DeHaan
e725eea4be Merge pull request #4770 from dragon3/devel
ec2_vol: return volume_id/device even when volume mapping already exists
2013-11-01 09:32:54 -07:00
James Tanner
afa5988391 Fixes #4540 Use shared module snippet to evaluate ec2 credentials 2013-11-01 11:59:24 -04:00
dragon3
19b5008c0a return volume_id/device even when volume mapping already exists 2013-11-01 23:59:42 +09:00
Alan Fairless
0824f004d9 Revised patch for more password entropy 2013-11-01 09:51:35 -05:00
Hiroaki Nakamura
abed2c47fa Fix for RHEL6. 2013-11-01 23:32:14 +09:00
James Tanner
f4b59fe285 Fixes #4516 file module: check prev_state earlier and use that if state is not specified 2013-11-01 09:31:32 -04:00
Michael DeHaan
337b6ce642 Fix documentation formatting. 2013-10-31 20:00:11 -04:00
Brian Cavagnolo
869f32123b make cloudformation module accept template_parameters from command line
Passing cloudformation template_parameters on the command line
like so was failing:

    ansible localhost -m cloudformation -a "...template_parameters=foo=5,bar=4..."
2013-10-31 17:00:03 -07:00
Michael DeHaan
7f125567cb Some simplification of include_vars and renamed include_files to include_vars. 2013-10-31 19:24:35 -04:00
Michael DeHaan
b69ab89eb1 Merge branch 'include_files' of git://github.com/bennojoy/ansible into devel 2013-10-31 19:14:27 -04:00
Michael DeHaan
187ebf2f56 Leverage 4318b27 and no longer treat instance tags as JSON, but as dictionary types which could be key=value or dicts or JSON or references. 2013-10-31 18:46:13 -04:00
Michael DeHaan
b520902852 Merge pull request #4756 from mscherer/fix_4739
Fix accelerate module on centos 5 by removing
2013-10-31 15:21:51 -07:00
Michael DeHaan
6d16f85b30 Suggest keyscan for github/other SCM hanging. 2013-10-31 18:00:24 -04:00
Michael DeHaan
aae3a0ea8d Merge pull request #4740 from retr0h/return-server-object-not-list
Need to compare on server object not list
2013-10-31 14:51:08 -07:00
Michael DeHaan
3a0d67024c Merge pull request #4736 from dmkoch/assemble-temp-file-cleanup
Clean up temp file left behind by assemble module
2013-10-31 14:50:28 -07:00
Michael DeHaan
3705f41992 Merge pull request #4754 from mscherer/fix_4648
Fix 4648, cron module is not working on solaris
2013-10-31 14:49:25 -07:00
Michael DeHaan
d34a26e307 Undo an inadvertant revert from template changes so we still allow pythonic imports in module land. 2013-10-31 16:53:05 -04:00
Michael Scherer
8efe53eebb Fix accelerate module on centos 5 by removing
unsupported string prefix in 2.4

http://docs.python.org/release/2.4/ref/strings.html
This is also ignored on later version of python 2
and is present only for python 3 conversion, as seen
on http://docs.python.org/2/reference/lexical_analysis.html#string-literals

Also see http://stackoverflow.com/questions/6269765/what-does-the-b-character-do-in-front-of-a-string-literal

Fix https://github.com/ansible/ansible/issues/4739
2013-10-31 21:04:34 +01:00
Michael Scherer
9e7b02aaee make cron module work on solaris
Cron on solaris do not take the same
set of option than vixie cron on linux, and
among the biggest difference, root cannot set
the crontab of a user directly from a file. Thus the
use of su to run the crontab command. Fix issue #4648
2013-10-31 19:58:26 +01:00
Michael Scherer
506ce6a809 remove unused function 2013-10-31 19:58:26 +01:00
Scott Dunlop
dbc1e20462 add "zle" as a supported ZFS compression type
ZFS supports "zle" compression, which compresses runs of null bytes efficiently.
2013-10-31 10:48:41 -07:00
Sheldon Hearn
6a02c75b7c Fix description of nova_compute:name option
It's the name of the instance, not of an image.
2013-10-31 12:34:04 +02:00
John Dewey
f1fa16b65f Need to compare on server object not list
TASK: [create test controller 0] **********************************************
    failed: [127.0.0.1] => {"failed": true, "parsed": false}
    invalid output was: Traceback (most recent call last):
      File "/Users/jdewey/.ansible/tmp/ansible-1383197329.62-262790004573235/nova_compute", line 1203, in <module>
        main()
      File "/Users/jdewey/.ansible/tmp/ansible-1383197329.62-262790004573235/nova_compute", line 261, in main
        _get_server_state(module, nova)
      File "/Users/jdewey/.ansible/tmp/ansible-1383197329.62-262790004573235/nova_compute", line 197, in _get_server_state
        if server.status != 'ACTIVE':
    AttributeError: 'list' object has no attribute 'status'
2013-10-30 22:41:02 -07:00
chrisalbright
44c2fae805 pip module: fix unexpected behavior when creating virtualenvs
This module supports `virtualenv_site_packages` as an option to control whether or not to include system packages when installing pip packages into a virtual environment. 

The default is no, and when you say yes it explicitly it includes a flag to include site packages, otherwise it doesn't provide a flag. 

Some versions of virtualenv by default include site packages and other versions by default do not. 

This patch just makes both branches explicit, so `virtualenv_site_packages=no` really means no.
2013-10-30 17:27:02 -07:00
Daniel Koch
dcdce838cf Clean up temp file left behind by assemble module 2013-10-30 20:24:03 -04:00
Michael DeHaan
e35c54b5aa Merge pull request #4727 from leth/apt-key-leading-zeros
Only remove leading '0x' from apt key ids, not all 0s
2013-10-30 17:16:20 -07:00
James Tanner
d154bf8781 Revert templating enhancements from 73dbab70 e6c28658 d409352c 9858b1f2 4587528b 9b1fe455 214b0b05 8d3db803 7f9504d1 5031104c 35cb9dc2 2bd8cb57 1e85c754 2013-10-30 10:50:16 -04:00
Marcus Cobden
414a5b4eab Only remove leading '0x' from key ids, not all 0s 2013-10-30 11:50:34 +00:00
James Tanner
d3c8832414 Fixes #4720 Use mysql command to restore database instead of mysqldump 2013-10-29 10:33:46 -04:00
jctanner
536b5b196f Merge pull request #4712 from mhite/bigip_node
New BIG-IP module for managing node objects
2013-10-29 06:07:45 -07:00
jctanner
a1fcaf5c61 Merge pull request #4715 from mscherer/fix_4702
Fix #4702, make setup work on windows
2013-10-29 06:03:49 -07:00
Michael Scherer
3f0b3a71ca Fix #4702, make setup work on windows 2013-10-28 23:41:18 +01:00
Thomas Omans
c12e2b53e3 Pip module: fixing issue with python 2.4 support
Python 2.4.3 returns:
TypeError: expected character buffer object

startswith is expecting only a string instead of a tuple like newer versions allow.
2013-10-28 15:15:04 -07:00
Matt Hite
25f7391d1a Fixed version_added and removed reference to traceback module 2013-10-28 14:51:51 -07:00
James Cammarata
0e9184eefd Fixing authorized_keys module to make the key part detection better
Fixes #4677
Fixes #4657
Fixes #4599
2013-10-28 13:52:45 -05:00
kiri
c1c32c75ac add NoneType check. 2013-10-28 21:35:57 +09:00
bennojoy
b53e7353f9 include files 2013-10-28 17:40:09 +05:30
Michael DeHaan
3722bebb1d Merge pull request #4509 from mremond/gem_executable
Add executable parameter to find gem binary in gem module
2013-10-27 08:59:19 -07:00
Michael DeHaan
3badedc983 Merge pull request #4424 from localvoid/firewalld-rich_rules
Add support for Rich Rules in firewalld module
2013-10-27 08:55:22 -07:00
Michael DeHaan
99d6726114 Revert "fix conversion from file to hardlink when force=yes"
This reverts commit 4d4518ed52.
2013-10-27 11:51:43 -04:00
Michael DeHaan
3778b39115 Merge pull request #4380 from joshkehn/lineinfile_validate
Added validate option to lineinfile
2013-10-27 08:46:47 -07:00
Michael DeHaan
41ed5635dc Merge pull request #4632 from simonsd/devel
refusing to convert between file and hard when force=yes
2013-10-27 08:32:34 -07:00
Michael DeHaan
d0904ded84 Merge pull request #4600 from earchibald/devel
Added ['date_time']['tz_offset'] using %z to get the time offset rather ...
2013-10-27 08:30:28 -07:00
Michael DeHaan
aac4c01786 Merge pull request #4597 from vegitron/devel
Allow generic django_management commands
2013-10-27 08:20:48 -07:00
Michael DeHaan
b725361bce Merge pull request #4560 from tronner/issue4461
Fix illegal set operation in FreeBSD section of user module.
2013-10-26 11:31:20 -07:00
Michael DeHaan
2b785ec7e5 Merge pull request #4610 from bennojoy/gcs_fix3
fix for overwrite in put operation
2013-10-26 11:29:11 -07:00
Michael DeHaan
da82906da5 Merge pull request #4680 from berendt/fix_permissions_of_ovirt
fixed permissions of module library/cloud/ovirt
2013-10-26 09:04:42 -07:00
Michael DeHaan
9858b1f2f3 Enable imports to work on a snippet based system, allowing for instance a library of common EC2 functions
to be reused between modules.  See library/system/service and library/system/ping for initial examples.  Can
work the old way to just import 'basic', or can import the new way to import multiple pieces of code from
module_utils/.
2013-10-26 11:09:30 -04:00
Christian Berendt
42d877146c fixed permissions of module library/cloud/ovirt 2013-10-26 09:05:21 +02:00
jctanner
43f48a2e02 Merge pull request #4167 from tima/rsync3
synchronization module take 3
2013-10-25 14:43:08 -07:00
James Tanner
40574c1938 Fixes #4448 reloaded services should be started if not running 2013-10-25 15:30:02 -04:00
James Cammarata
aa0577c211 Merge branch 'fix_autorized_keys' of https://github.com/mscherer/ansible into mscherer-fix_autorized_keys 2013-10-24 20:13:38 -05:00
James Cammarata
b58b287fce Fixing up authorized_keys to accept comments with spaces 2013-10-24 20:12:56 -05:00
Michael Scherer
951a91723d make sure that options are quoted, as people can add a shell
script there with a comma that would produce invalid configuration
upon being wrote again
2013-10-24 23:51:55 +02:00
Michael Scherer
7672e9fef8 sort the option_key to have a constant predictable line 2013-10-24 23:47:34 +02:00
Michael Scherer
264945a1f7 adding a single comma at the end of the options list confuse the module
it start to duplicate line, because this create
a empty option in the list, and so the module add a new line along the previous
one. See

>>> ' a,b, '.strip().split(',')
['a', 'b', '']
2013-10-24 23:46:49 +02:00
jctanner
f61a4c1eb3 Merge pull request #4631 from mmoya/mysql_variables-fix3
Fail if requested variable is not available
2013-10-24 10:37:37 -07:00
jctanner
509271f740 Merge pull request #4624 from SirScott/freebsd_service_module_uwsgi
Fix broken FreeBsdService class
2013-10-24 10:36:05 -07:00
James Tanner
8157d5e52a Set version_added for ec2_eip's in_vpc parameter 2013-10-24 12:19:43 -04:00
jctanner
0b4f84d780 Merge pull request #4593 from pas256/eip-vpc
Add VPC support for EIP module
2013-10-24 10:22:43 -07:00
James Tanner
6f523111d3 Set bigip_pool_member version added to 1.4 2013-10-24 11:41:34 -04:00
James Tanner
b803aac6ec Fixes #4500 change ec2 module params to type=bool
Revert 4833c2fdf0
2013-10-24 09:19:25 -04:00
Cove Schneider
94574f7296 update with current fixes from docker-ansible 2013-10-23 22:56:02 -07:00
Jon Kolb
ba7d05222a Fixes #3847: lineinfile without regex 2013-10-23 21:04:18 -04:00
jctanner
e34cde6bef Merge pull request #4112 from jsdalton/add_az_support_to_ec2_elb
Add enable_availability_zone parameter to ec2 module.
2013-10-22 14:01:24 -07:00
jctanner
de1e3f0cbc Merge pull request #4054 from mhite/bigip_pool_member
New bigip_pool_member module
2013-10-22 13:55:41 -07:00
Dave Simons
4d4518ed52 fix conversion from file to hardlink when force=yes
Signed-off-by: Dave Simons <dave@inuits.eu>
2013-10-22 10:46:45 +02:00
Maykel Moya
3db7ec8356 Fail if requested variable is not available 2013-10-22 09:30:19 +02:00
bennojoy
0c275424c6 fix to work like copy module 2013-10-22 09:03:52 +05:30
Scott Sturdivant
4d24e2e29f If the output of rcvar isn't a key=value pair, ignore it. 2013-10-21 14:20:54 -06:00
bennojoy
788e783b6d fix for overwrite in put operation 2013-10-21 09:46:21 +05:30
Eugene Archibald
30eb5c7342 Fixed (broken) tab to (correct) spaces for indentation 2013-10-19 17:04:37 -07:00
Michael DeHaan
21d4400c96 Misc pep8 fixes 2013-10-19 13:03:15 -04:00
Michael DeHaan
aa93ce2dc2 Fix deprecation warnings in the Google modules. 2013-10-19 13:03:14 -04:00
Michael DeHaan
75e0a1c6de Merge pull request #4592 from mscherer/fix_4586
setup module, replace ':' by '_' in interface name, fix #4586
2013-10-19 09:07:56 -07:00
Jimmy Tang
0568abeb14 check for ubuntu distribution first 2013-10-19 14:41:00 +01:00
Eugene Archibald
145c0b8be1 Added ['date_time']['tz_offset'] using %z to get the time offset rather than time zone. 2013-10-18 20:32:35 -07:00
Patrick Michaud
c1e241577c Allow generic django_management commands
This commit removes the restriction on django management commands.  If a command is unknown to the django installation, there will be a concise error produced.

for example:

  tasks:
    - name: invalid command
      django_manage: virtualenv="/valid/virtualenv" app_path="/valid/app_path" command="nowaydude"

Results in:

failed: [hostname] => {"cmd": "python manage.py nowaydude", "failed": true}
msg: stdout: Unknown command: 'nowaydude'
Type 'manage.py help' for usage.

:stderr: Unknown django command: nowaydude
2013-10-18 17:26:10 -07:00
Michael DeHaan
232eb9f8e6 Merge pull request #4595 from mscherer/fix_4563
fix logic in module host to add aliases even if none exist already, fix #4563
2013-10-18 17:09:23 -07:00
Michael DeHaan
b5c34308dd Merge pull request #4594 from mscherer/fix_4587
fix distribution detection in apt_repository module, so it also work on mint as it work on Debian, partially fix #4587
2013-10-18 17:08:35 -07:00
Michael Scherer
d5c290b513 fix logic in module host to add aliases even if none exist already, fix #4563
self._has_aliases is used to know if a alias already exist, but
the test we want is to know if we need to add a new alias, which
is stored in self.aliases
2013-10-19 01:51:42 +02:00
Michael Scherer
19bb44288e fix distribution detection in apt_repository module, so it also work
on Mint as it work on Debian, fix #4587.

PPAs are not supported however, since that's a Ubuntu specific feature
and mint is detected as a generic distribution and use a different
codename than the Ubuntu release it is based on, which mean that apt_repository
cannot add detect and add the proper url without a better heuristic.
2013-10-19 00:57:08 +02:00
Michael Scherer
fc211ac1a0 setup module, replace ':' by '_' in interface name, fix #4586 2013-10-19 00:24:07 +02:00
Peter Sankauskas
b793248df4 Now this disassociates EIPs from instances inside a VPC correctly. Time
for a PR.
2013-10-18 15:12:49 -07:00
James Tanner
3c4dd618e4 Fixes #4454 Make a temporary clean cnf file if unable to parse existing 2013-10-18 17:42:40 -04:00
Peter Sankauskas
0e459f65f0 First round of changes to the EIP module to get it to be able to work well inside a VPC, and to be able to delete EIPs as well 2013-10-18 14:38:58 -07:00
jctanner
92edf99c80 Merge pull request #4562 from nimbis/devel
Adding aws_access_key and aws_secret_key aliases to ec2_group arguments
2013-10-18 06:17:50 -07:00
Brian Schott
bdc8ea828e added aws_access_key and aws_secret_key aliases to ec2_group arguments 2013-10-17 15:23:24 -04:00
jctanner
12eaefb7e6 Merge pull request #4539 from sayap/git-sha1
git: Always return the before/after revisions, even in check mode.
2013-10-17 11:36:03 -07:00
Michael DeHaan
8666f8ea24 Merge pull request #4568 from mmoya/features
Improve change detection in mysql_variables
2013-10-17 10:51:36 -07:00
James Tanner
4f674ec522 Fixes #4554 Enumerate user homedir if not passed as an argument 2013-10-17 13:15:32 -04:00