Commit graph

7522 commits

Author SHA1 Message Date
Michael DeHaan
8666f8ea24 Merge pull request #4568 from mmoya/features
Improve change detection in mysql_variables
2013-10-17 10:51:36 -07:00
James Tanner
4f674ec522 Fixes #4554 Enumerate user homedir if not passed as an argument 2013-10-17 13:15:32 -04:00
Maykel Moya
b90a250165 Improve change detection in mysql_variables
mysql_variables bindly executes a SET var = value query even when
the variable already has the requested value.

With this patch the query is executed only if the current value is
different to the requested one.
2013-10-17 19:13:58 +02:00
Thomas Ronner
aee68511e6 Fix illegal set operation in FreeBSD section of user module. 2013-10-17 15:02:23 +00:00
Michael DeHaan
8a516d1479 Various standardization to the proposed gce_storage module to bring things in line with updates to the S3 module.
Some typo fixes.

Further testing required.
2013-10-17 10:49:51 -04:00
Michael DeHaan
4bdf3da25a Merge pull request #4333 from bennojoy/gcs
support for google cloud storage module
2013-10-17 07:35:53 -07:00
Michael DeHaan
baa13a5cc7 Merge pull request #4395 from erjohnso/devel
adding Google Compute Engine modules and inventory plugin
2013-10-17 07:30:55 -07:00
Michael DeHaan
ffaabc54bb Merge pull request #4559 from greenalto/fix_typo
Fix typo
2013-10-17 07:26:33 -07:00
Greg Karékinian
86f4e03bb5 Fix typo 2013-10-17 16:00:58 +02:00
Michael DeHaan
4484ba8a49 Merge pull request #4553 from mmoya/features
Do key validation only when key is provided
2013-10-17 05:18:17 -07:00
Maykel Moya
2592b2c3f9 Do key validation only when key is provided
key_id is optional, the previous code didn't handle the case of key_id
not specified
2013-10-17 12:04:04 +02:00
jctanner
6480945184 Merge pull request #4541 from Kami/improve_template_render_error_messages
Make errors which get thrown during template rendering more user-friendly
2013-10-16 17:52:07 -07:00
jctanner
7e8e186b3b Merge pull request #4517 from adfinis-sygroup/devel
Remove keys regardless of the options
2013-10-16 17:40:43 -07:00
jctanner
c737f222d5 Merge pull request #4480 from joemaller/absent_path_fix
ignore src when file module state=absent
2013-10-16 17:29:21 -07:00
jctanner
51a1a54bfb Merge pull request #4428 from robparrott/devel
Properly handle DEFAULT section with ConfigParser in ini_file modules
2013-10-16 17:18:17 -07:00
James Tanner
23cbdba65e Fixes #4350 Create homedirectory if create=yes and directory is missing 2013-10-16 20:08:41 -04:00
Michael DeHaan
8a3f222d41 Merge pull request #4548 from stoned/ansible-doc-fix
Fix 'ansible-doc -l' runtime error following commit 4430d0f
2013-10-16 15:59:41 -07:00
Stoned Elipot
c7217a8f1b Fix 'ansible-doc -l' runtime error following commit 4430d0f
skip "module" not found as plugin, id est directory
2013-10-16 21:58:54 +02:00
Michael DeHaan
f9ac88c9da Merge pull request #4547 from stoned/find_plugin-fix
when searching for a plugin only look for a regular file
2013-10-16 12:35:02 -07:00
Michael DeHaan
db7e4510f2 Merge pull request #4544 from mmoya/features
apt_key: Validate key_id and accept a leading '0x'
2013-10-16 12:32:28 -07:00
Stoned Elipot
4430d0f5a6 when searching for a plugin only look for a regular file 2013-10-16 21:23:37 +02:00
Michael DeHaan
1317ece644 Merge pull request #4543 from lorin/s3-walrus
s3: better check for walrus
2013-10-16 12:18:48 -07:00
Maykel Moya
1a79d9ae58 apt_key: Validate key_id and accept a leading '0x' 2013-10-16 20:52:18 +02:00
Lorin Hochstein
1c5bdba977 s3: better check for walrus
Check for Walrus endpoint by looking to see if the endpoint is not AWS.

This fixes a bug where the user specifies an AWS endpoint via S3_URL,
but the code interprets it as Walrus and then fails.
2013-10-16 13:22:41 -04:00
Tomaz Muraus
922f61899e Throw a more user-friendly exception during template rendering process. 2013-10-16 16:48:17 +02:00
James Tanner
807e602228 mysql_db: if connection is a socket, do not specify hostname 2013-10-16 09:59:31 -04:00
James Tanner
84a692bcf7 Fixes #4301 Use module_common functions for mysqldump and return better errors 2013-10-16 09:51:08 -04:00
Michael DeHaan
efe2a9fb1d Merge pull request #4538 from mulby/gabe/arguments-sudo
Ensure non-root users can read arguments file when using sudo_user and non-standard modules
2013-10-16 06:07:55 -07:00
Yap Sok Ann
8519d586ba git: Don't add --branch while cloning if the version is a SHA-1 hash. 2013-10-16 20:37:07 +08:00
Yap Sok Ann
9f8cdac0aa git: Handle network problem when running git ls-remote. 2013-10-16 20:37:07 +08:00
Yap Sok Ann
a53e7045a6 git: Always return the before/after revisions, even in check mode.
The return values from check mode and non-check mode should match in all cases,
except when a SHA-1 hash is used as version, as there is no way to check if it
is a valid hash using `git ls-remote`.

Also, to accomodate this change, the force flag for the reset function has been
removed so that we can do the checking in main.
2013-10-16 20:37:07 +08:00
Yap Sok Ann
b9558828e8 git: Make function get_remote_head usable when cloning.
This allows the module to return the before/after revisions in all cases.
2013-10-16 20:37:07 +08:00
Yap Sok Ann
2ad4d77c9a git: Remove unnecessary return code checking.
The functions either return rc=0 or call fail_json themselves.
2013-10-16 20:37:06 +08:00
Yap Sok Ann
9af05f4d2f git: Full length SHA-1 in, full length SHA-1 out.
This removes ambiguity at the expense of slight backward incompatibility.
2013-10-16 20:37:06 +08:00
Gabe Mulley
84a57b7545 ensure non-root users can read arguments file when using sudo_user
Non-standard modules must read in the arguments file in order to access their arguments, however, when this file is transfered to the remote host it may only have the permissions 600.  This means that using sudo and sudo_user will result in permission denied errors when attempting to read the arguments file.

This patch fixes #4438 by explicitly forcing the arguments file to be world readable before executing the module.
2013-10-16 08:18:11 -04:00
Michael DeHaan
afa781d628 Merge pull request #4530 from geerds/feature/use-bash-executable-in-subprocess-call
Fix TestInventory class by explicitly using /bin/bash
2013-10-15 17:38:19 -07:00
James Tanner
00f3ec645d Fixes #4532 Send easy_install to get_bin_path instead of None 2013-10-15 18:15:08 -04:00
Jascha Geerds
76ed19d279 Fix TestInventory class by explicitly using /bin/bash 2013-10-15 21:34:36 +02:00
jctanner
33faaaa9a0 Merge pull request #4529 from bcoca/warns_no_conflict
fixed name colision between warnings dict and module
2013-10-15 12:12:33 -07:00
Brian Coca
bd9acedb57 fixed name colision between warnings dict and module
Signed-off-by: Brian Coca <briancoca+ansible@gmail.com>
2013-10-15 14:58:15 -04:00
James Tanner
7061c99049 fix indentation in easy_install module docstring 2013-10-15 12:49:43 -04:00
Hiroaki Nakamura
54243dc8f5 Add support for Fedora, OpenSUSE and ArchLinux.
Tested under Fedora 19 and OpenSUSE 12.3. Not tested on ArchLinux.
2013-10-16 01:15:47 +09:00
Michael DeHaan
ebbf845e09 Merge pull request #4520 from jaugustin/patch-1
[doc] duplicate group in usa:children group
2013-10-15 08:23:52 -07:00
Michael DeHaan
cb87a94515 Merge pull request #4519 from mmoya/fixes
Fix building of docsite
2013-10-15 08:23:32 -07:00
Jérémie Augustin
ddf1d71b7d [doc] duplicate group in usa:children group 2013-10-15 17:18:07 +02:00
Hiroaki Nakamura
8c5eb96de4 Do not use shortcut conditional operator which is not supported in Python 2.4. 2013-10-15 23:41:49 +09:00
Maykel Moya
cd051c4a0d Fix building of docsite
* Fix paths in docsite/Makefile having an additional '..'.
* Ignore generated docsite/rst/modules/*.rst
2013-10-15 16:21:19 +02:00
James Cammarata
35284818a9 Handle ssh key files that may only have a type/key specified
If a specified key did not have a comment, it would be ignored as
an invalid key.

Fixes #4513
2013-10-15 09:05:50 -05:00
James Tanner
6b60267898 Document per task remote_user, based on #3932 2013-10-15 09:40:37 -04:00
jctanner
69fa5954fd Merge pull request #3932 from jocelynj/devel
Add option remote_user to task level, to specify the ssh login user
2013-10-15 06:34:57 -07:00