Commit graph

19610 commits

Author SHA1 Message Date
Tim Rupp
0e4e7de000
Various F5 related fixes for traceback raising (#34820)
The main purpose of this patch is to do the refactor that
supports replacing tracebacks with fail_json. Additionally, the
following was done.

* Removed re-def of cleanup_tokens.
* Changed parameter args to be keywords.
* Changed imports to include new module_util locations.
* Imports also include developing (sideband) module_util locations.
* Changed to using F5Client and plain AnsibleModule to prevent tracebacks caused by missing libraries.
* Removed init and update methods from most Parameter classes (optimization) as its now included in module_utils.
* Changed module and module param references to take into account the new self.module arg.
* Minor bug fixes made during this refactor.
2018-01-12 14:43:35 -08:00
René Moser
7bdbe9ab87
vultr: new module vr_startup_script (#34374)
* vultr: new module vr_startup_script

* add integration tests
2018-01-12 22:39:06 +01:00
Tim Rupp
eace686044
Various fixes and changes for F5 (#34817)
Primarily, this patch contains refactors to remove tracebacks that
are generated when libraries are missing. There is also,

* Removed re-def of cleanup_tokens.
* Changed parameter args to be keywords.
* Changed imports to include new module_util locations.
* Imports also include developing (sideband) module_util locations.
* Changed to using F5Client and plain AnsibleModule to prevent tracebacks caused by missing libraries.
* Removed init and update methods from most Parameter classes (optimization) as its now included in module_utils.
* Changed module and module param references to take into account the new self.module arg. Minor bug fixes made during this refactor.
2018-01-12 13:23:19 -08:00
dpassante
085a250575 Add new Cloudstack module cs_vpc_offering (#34797)
* Add new Cloudstack module cs_vpc_offering

* fix documentation

* fix returns list

* state=absent example minimalization
2018-01-12 21:40:35 +01:00
Tim Rupp
44a5b3abb4
Various fixes (#34815)
This patch was primarily an effort to reduce traceback errors for
work that sivel was doing. Part of (and in some cases in addition to)
that, the following was done.

* Removed re-def of cleanup_tokens.
* Changed parameter args to be keywords.
* Changed imports to include new module_util locations.
* Imports also include developing (sideband) module_util locations.
* Changed to using F5Client and plain AnsibleModule to prevent tracebacks caused by missing libraries.
* Removed init and update methods from most Parameter classes (optimization) as its now included in module_utils.
* Changed module and module param references to take into account the new self.module arg.
* Minor bug fixes made during this refactor.
2018-01-12 12:08:49 -08:00
Tim Rupp
18d33eeb89
Adds the AFM address list module (#34814)
This module can be used to manage address lists on a BIG-IP running
AFM.
2018-01-12 10:25:33 -08:00
Tim Rupp
9314607c38
Adds selective assignment of kwargs (#34813)
For the f5 module utils, the parameters base class needs to selectively
get args from kwargs
2018-01-12 09:50:53 -08:00
Abhijeet Kasurde
82a0253059
VMware: Add new module: vmware_host_service_facts (#34731)
This adds module to gather facts about VMware host service facts.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-01-12 22:32:10 +05:30
Abhijeet Kasurde
eabd7eafad VMware: Refactor vmware_host module (#33916)
This fix refactor vmware_host module to use PyVmomi.
Also, handle SSLVerifyFault exception to get hostsystem's certificate
thumbprint.

Fixes: #20819

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-01-12 11:30:28 -05:00
Matt Martz
2b66d9966c
Add a config toggle for agnostic become prompts, defaulting to False for the 2.5 release. Fixes #33999 (#34761) 2018-01-12 10:28:46 -06:00
Dag Wieers
7957ba7aad
Fix small typo 2018-01-12 15:06:05 +01:00
Bruno
545650c3b1 aci_switch_leaf_selector module (#34041)
* added aci_switch_leaf_policy_profile module WIP

* fixed pep8 errors for PR

* fixed unwanted modifications and fixed pep8 errors

* fixed suggested errors for PR

* adding WIP aci_switch_leaf_selector module

* fixed for pull request

* fixing pep8 errors, bad indents

* improved initial description

* fixed pep8 doc errors

* updated module to include infra:NodeBlk and infra:RsAccNodePGrp instead of having seperate modules for the latter

* fixing pep8

* adding 'name' alias to leaf_selector

* updating example

* updating aliases, forgot 'name' again

* added examples

* Fix pylint errors

* Fix trailing whitespace issue

* Fix one more pylint issue
2018-01-12 12:23:29 +01:00
Bruno
61d50a12e5 aci_access_port_to_interface_policy_leaf_profile module (#34398)
* added aci_switch_leaf_policy_profile module WIP

* fixed pep8 errors for PR

* fixed unwanted modifications and fixed pep8 errors

* fixed suggested errors for PR

* adding WIP aci_switch_leaf_selector module

* fixed for pull request

* fixing pep8 errors, bad indents

* improved initial description

* fixed pep8 doc errors

* updated module to include infra:NodeBlk and infra:RsAccNodePGrp instead of having seperate modules for the latter

* fixing pep8

* adding 'name' alias to leaf_selector

* updating example

* updating aliases, forgot 'name' again

* adding aci_interface_policy_leaf_profile module

* removing unwanted module.. man I always make this mistake

* add aci_access_port_to_interface_policy_leaf_profile module

* added example and integration tests

* Fix pylint errors
2018-01-12 12:20:52 +01:00
Dag Wieers
d23d290be8
aci_aep: Add infrastructure_vlan support (infra:ProvAcc) (#33996)
This is a needed enhancement.
2018-01-12 12:20:20 +01:00
Bruno
393c5bea67 aci_switch_leaf_policy_profile module (#33955)
* added aci_switch_leaf_policy_profile module WIP

* fixed pep8 errors for PR

* fixed unwanted modifications and fixed pep8 errors

* fixed suggested errors for PR

* fixing PR errors

* removing unwanted module from this branch for PR

* removing unwanted module again, rookie git mistakes

* correcting wrong module name

* added examples

* Fix pylint errors

* Fix trailing whitespace
2018-01-12 12:15:13 +01:00
Bruno
837a05fca4 aci_interface_selector_to_switch_policy_leaf_profile module (#34098)
* added aci_switch_leaf_policy_profile module WIP

* fixed pep8 errors for PR

* fixed unwanted modifications and fixed pep8 errors

* fixed suggested errors for PR

* adding WIP aci_switch_leaf_selector module

* fixed for pull request

* added new module aci_switch_leaf_selector_node_block for PR

* fixed pep8 issues

* fixed from and to parameter setup in arg spec

* fixed pep8 doc errors

* fixed pep8 indentation error

* adding new aci_interface_selector_to_switch_policy_leaf_profile module for  PR

* removed unwanted module

* added examples

* Fix pylint errors

* Remove whitespace introduced by Github editor
2018-01-12 12:14:14 +01:00
Bruno
007c19095d aci_interface_policy_leaf_profile module (#34364)
* added aci_switch_leaf_policy_profile module WIP

* fixed pep8 errors for PR

* fixed unwanted modifications and fixed pep8 errors

* fixed suggested errors for PR

* adding WIP aci_switch_leaf_selector module

* fixed for pull request

* fixing pep8 errors, bad indents

* improved initial description

* fixed pep8 doc errors

* updated module to include infra:NodeBlk and infra:RsAccNodePGrp instead of having seperate modules for the latter

* fixing pep8

* adding 'name' alias to leaf_selector

* updating example

* updating aliases, forgot 'name' again

* adding aci_interface_policy_leaf_profile module

* removing unwanted module.. man I always make this mistake

* added examples

* Fix pylint errors
2018-01-12 11:57:44 +01:00
Dag Wieers
d7d13b48e5
aci_aep_to_domain: New module to bind AEP to domain (#33942)
* aci_aep_to_domain: New module to bind AEP to domain

* Changes to bring in line with aci_domain

* Rename aep_domain to domain_dn, add types

* Fix pylint errors
2018-01-12 11:50:41 +01:00
Dag Wieers
628eca85c3
ACI: Fixing new pylint issue (#34775) 2018-01-12 08:07:59 +01:00
René Moser
e3b5be0887
vr_server: fix assumption returned id is an int (#34765) 2018-01-12 07:30:37 +01:00
Adam Miller
d860e13ae1 Add validate_certs to jira module (#34756)
The jira module uses ansible.module_utils.urls.fetch_url which will
attempt to get that value of the validate_certs parameter from the
module; if present it will honor it's value, otherwise it defaults
to True.

This patch adds that parameter to jira so that it can be specified
by the user and honored by ansible.module_utils.urls.fetch_url

Signed-off-by: Adam Miller <admiller@redhat.com>
2018-01-11 23:39:07 -05:00
Dag Wieers
83b7ec69fc
Fix pylint issue (#34773) 2018-01-12 02:26:14 +01:00
Dag Wieers
03dd3214b4
Fix new pylint issue (#34772)
Is it all worth it ?
2018-01-12 02:25:03 +01:00
Pilou
00332a49d5 ec2_win_password: fix broken import and minor updates (#34479)
* fix broken import

* ansible.module_utils.ec2.HAS_BOTO is already used

* wait_timeout parameter: use 'int' type

* wait is always True there

* doc: use formatting function
2018-01-12 11:24:46 +10:00
Matt Martz
dcc05093db Validate modules arg spec fixes (#34477)
* Update validate-modules arg_spec introspection to be faster, by only mocking the imports we explicitly list
* The use of types.MethodType in redhat_subscription wasn't py3 compatible, use partial instead
* Remove argument_spec import hacks, make them errors, we can ignore them with ansible-test
* Enable the --arg-spec flag for validate-modules
2018-01-11 15:41:53 -08:00
Matt Martz
42a0d71413
Catch exception comparing role versions, and provide a user friendly error message. Fixes #32301 (#34427) 2018-01-11 17:41:23 -06:00
Dag Wieers
c3909460d4
aci_domain_to_vlan_pool: Add domain to VLAN pool (#34402)
* aci_domain_to_vlan_pool: Add domain to VLAN pool

A new ACI module to bind a domain to a VLAN pool.

This module still needs integration tests once it is formally review and
accepted.

* Add examples to documentation
2018-01-11 23:32:12 +01:00
Dag Wieers
f3193f272c
aci_domain_to_encap_pool: Add domain to encap pool (#34123)
* aci_domain_to_encap_pool: Add domain to encap pool

A new ACI module to bind a domain to an encap pool.

This module still needs integration tests once it is formally review and
accepted.

* Fix domain RN and attributes
2018-01-11 23:31:48 +01:00
Dag Wieers
3127be0e3d
aci_domain: Manage phys, vmm, l2ext, l3ext and FC domain profiles (#34011)
* aci_domain: Manage phys, vmm, l2ext, l3ext and FC domain profiles

A new ACI module from the high priority list.

* Add RHEV VMM provider as Redhat

* PEP compliancy

* Make variables specific to domain

* Add examples
2018-01-11 23:31:23 +01:00
Dag Wieers
0d84e27d0c
aci_firmware_source: Manage firmware image sources on ACI (#34670) 2018-01-11 23:30:58 +01:00
Dag Wieers
e0214ece57
aci_vlan_pool_encap_block: New module to manage VLAN encap blocks (#34653)
* aci_vlan_pool_encap_block: New module to manage VLAN encap blocks

This module is a simplified version of the aci_encap_pool_range module.

* PEP8 fixes (closer to the original)

* Add integration tests
2018-01-11 23:22:43 +01:00
Samer Deeb
f8884f12bc Mellanox OS name change: MLNXOS changed to ONYX (#34753)
* Mellanox OS name change: MLNXOS changed to ONYX

Signed-off-by: Samer Deeb <samerd@mellanox.com>

* Fix alphabetical order of modules metadata

Signed-off-by: Samer Deeb <samerd@mellanox.com>
2018-01-11 22:21:17 +00:00
David Vilar Benet
57ff84251e Implemented Trigger Repetition (#32938)
* Implemented Trigger Repetition

* Refactorings and integration tests for Trigger Repetition

* Suggestions of first review

* Changes of second review
2018-01-12 08:08:50 +10:00
Nathaniel Case
bd989b3088
Report invalid connection types for network modules (#34755)
* Emit error on wrong connection type
2018-01-11 16:47:48 -05:00
chriskarel
bb9dcb0d2b Adding "-SyncWindow 0" flag to Compare-Object call (#34656)
Adding "-SyncWindow 0" flag to the Compare-Object call used to determine if the existing and proposed IP address lists are the same.  This makes the array comparison mark changes in order as a difference.

Fix for bug #34651
2018-01-12 07:43:02 +10:00
René Moser
476030a49c
vr_server: implement startup_script (#34565)
* simplify

* vr_server: implement startup_script
2018-01-11 22:26:39 +01:00
Dag Wieers
fbffcb36bf
aci_vlan_pool: Module to manage VLAN pools (#34650)
* aci_vlan_pool: Module to manage VLAN pools

This is a simplified version of the aci_encap_pool module.

* Add integration tests, based on aci_encap_pool
2018-01-11 22:17:10 +01:00
René Moser
be06799b20
vultr: new module vr_dns_domain (#34377)
* vultr: new module vr_dns_domain

* minor doc fix
2018-01-11 19:04:58 +01:00
René Moser
adbb2f7016
vultr: new module vr_user (#34521)
* vultr: new module vr_user

* add missing doc of arg force

* make password less required

* optimize error msg

* update docs
2018-01-11 18:58:02 +01:00
Samer Deeb
cb206abea3 Support advertised networks in bgp protocol (#34728)
Signed-off-by: Samer Deeb <samerd@mellanox.com>
2018-01-11 17:40:39 +00:00
Samer Deeb
fcf6da0a9d Add ospf protocol support for Mellanox MLNXOS network devices (#34717)
* Add new module for managing ospf protocol on mlnxos devices

Signed-off-by: Samer Deeb <samerd@mellanox.com>

* Fix test name, and documentation.

Signed-off-by: Samer Deeb <samerd@mellanox.com>
2018-01-11 17:40:04 +00:00
Andreas Olsson
7ac061139b Sort out parameter requirements for cloudflare_dns (#31800)
This module is mostly written to make room for the option of not
setting the `value` parameter while `state=absent`. That choice being
a feature, since it allows both for the removal of individual records
as well as the removal of full record sets.

The opposite goes for the `record` parameter, which needs to be defined
at least by its default value for the module to be able to produce any
meaningful result. Hence making it explicit as part of required_if.

The MX record type is already plenty covered. In addition to the
priority parameter having a default value, the `ensure_dns_record`
method does its own parameter checking.

SRV records on the other hand do need additional parameter
checking. Primarily with the `delete_dns_records` method in mind.

Fixes #23957
2018-01-11 12:03:54 -05:00
Abhijeet Kasurde
3f4dfb2574 WinRM: fix format_exc call (#34233)
This fix adds correct call for format_exc in winrm plugin.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-01-11 08:43:22 -08:00
Pilou
e9e316c76b Filesystem: refactor, improvements, add tests (#25519)
* filesystem: list used tools

* filesystem: btrfs and reiserfs don't support resizing

* filesystem: list supported filesystems

use formatting functions and 'filesystem' instead of 'file system'

* filesystem: PEP8

* filesystem: remove useless calls to module.boolean

* filesystem: fail when the requested action isn't implemented

* filesystem: resizefs: list supported FS rather than unsupported

* filesystem: refactor

* filesystem: add integration tests

* filesystem: allow to use image file with 'dev' param

* filesystem: test resizefs (ext2/3/4 filesystems only)

* filesystem: Btrfs, handle older version than v0.20-rc1

* filesystem: use loop keyword (integration tests)

* filesystem: new test, check when another filesystem already exists

* filesystem: add myself as a maintainer

* filesystem: fix tests as filters
2018-01-11 11:10:14 -05:00
Trishna Guha
303894dd17
fix nxos_banner (#34695)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-01-11 21:13:00 +05:30
Trishna Guha
df8b01aaf7
Handle platform os version for sandbox nxos_nxapi (#34490)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-01-11 21:12:00 +05:30
Matt Martz
bfb5264138
Support datetime serialization in json encoder. Fixes #34312 (#34516) 2018-01-11 09:10:14 -06:00
Christopher Brown
cf86c6aaf6 Add ManageIQ Azure provider (#34708)
This commit adds support for creating Azure providers on ManageIQ.
2018-01-11 09:06:33 -05:00
Ricardo Carrillo Cruz
32e7c9bc9c
Refactor EOS code to use cliconf (#34426)
* WIP Refactor EOS code to use cliconf

* Fix connection.get where sendonly is True

* Fix pylint issue

* Remove return from send_config and various exec_commands

Also, removed a few try/except, which are anyways handled in
Connection.
2018-01-11 13:33:33 +01:00
Ricardo Carrillo Cruz
477cd3f775
Refactor IOS libs to use cliconf (#34136)
* Refactor IOS libs to use cliconf

* Fix pep8

* Remove bytstrings from edit_config and additional end on load_config

* Fix pep8
2018-01-11 11:50:01 +01:00