Toshio Kuratomi
10ebcccedb
Escape mysql identifiers
2014-11-25 01:46:09 -08:00
Toshio Kuratomi
06ac459fc5
Correct new function name
2014-11-25 01:42:33 -08:00
Toshio Kuratomi
c84ae54294
Normalize privs and flags to uppercase so comparisons against allowed names will work
2014-11-25 00:44:18 -08:00
Toshio Kuratomi
fbc4ed7a88
Make sure we quote or confirm good all user provided identifiers
2014-11-24 22:56:51 -08:00
Toshio Kuratomi
51910a1a33
Audit escaping of identifiers in the postgresql_user module
2014-11-24 22:30:10 -08:00
Toshio Kuratomi
1b0afb137c
More robust quoting of database identifiers
...
Note: These aren't database values, those are already using the
appropriate Pyhton DB API method for quoting.
2014-11-24 20:51:27 -08:00
Michael DeHaan
3ed1378067
Some more module categorization.
2014-11-04 17:23:22 -05:00
Michael DeHaan
385a037cd6
package files
2014-09-26 11:05:47 -04:00
Michael DeHaan
c8e1a2077e
file extensions!
2014-09-26 10:37:56 -04:00
Michael DeHaan
417309a626
Restructuring.
2014-09-26 10:13:26 -04:00
Michael DeHaan
73123b69fa
Move modules into subdirectory.
2014-09-26 09:23:50 -04:00
James Martin
49a5619cc0
Prevents module from failing with "_mysql_exceptions.Warning: Sending passwords in plain text without SSL/TLS is extremely insecure." When not using SSL/TLS.
2014-09-09 19:44:40 -04:00
Michael DeHaan
677709803c
Merge pull request #8419 from georgeOsdDev/escape_underscore_in_database_name
...
mysql_db module: Escape "_" in database name for "SHOW DATABASES" statement
2014-08-08 14:38:51 -04:00
Michael DeHaan
185d5a6221
Merge branch 'spelling' of git://github.com/cgar/ansible into devel
...
Conflicts:
docsite/rst/guide_rax.rst
plugins/callbacks/mail.py
2014-08-08 13:28:45 -04:00
Takeharu Oshida
b42ff30505
Escape "_" in database name for "SHOW DATABASES" statement
2014-08-04 20:15:58 +09:00
Wayne Rosario
7cfef577a1
Adding the following Test Coverage:
...
Use mysql_user module to create, delete users.
Update user password and ensure new password was updated for the correct user.
Assert user has access to multiple databases
Assert user creation, deleting using different user privilege and ensure privilege work correctly.
2014-07-29 11:49:53 -04:00
Wayne Rosario
45d7e53da9
updating doc to include revoke example for mysql_user docs
2014-07-24 10:32:28 -04:00
Jonathan Mainguy
3da1e5ce62
This fixes 8173, if target was not defined it would break, now it wont
2014-07-18 09:52:37 -04:00
James Cammarata
93d862f3f5
Expand target for mysql_db
...
Fixes #8128
2014-07-16 13:39:47 -05:00
Jonathan Mainguy
2b84ec6b4a
Errors out with stderr 1049, unknown database: when importing a database that does not exist
2014-07-11 14:57:45 -04:00
James Cammarata
a8368e4dc4
Merge pull request #8092 from ghjm/mysql-exceptions
...
Added exception handling to database creation and deletion. Fixes #8075 .
2014-07-11 11:59:12 -05:00
Graham Mainwaring
8e6e9a12e7
Switched primary and alias names of the name/db parameter, to match documentation. Fixes #8065 .
2014-07-10 22:37:46 -04:00
Graham Mainwaring
6e237bed7a
Added exception handling to database creation and deletion. Fixes #8075 .
2014-07-10 22:28:56 -04:00
Jonathan Mainguy
f4690464b4
Makes ansible fail if login_port is defined and login_host is either not defined, or defined as localhost. This is because if login_host is localhost then MySQLdb will use the socket instead of TCP. This leads to confusion for ansible users as, when a port is defined it gets ignored if login_host is localhost. This is to fix the bug reported by wrosario #8070 . Info on MysqlDb can be read here http://mysql-python.sourceforge.net/MySQLdb.html
2014-07-09 14:38:27 -04:00
James Cammarata
ae37758257
Merge pull request #6766 from Jmainguy/mysql_db_bug
...
mysql_db module now correctly fails on import if bz2 or gz fails.
2014-06-23 12:42:42 -05:00
Scott Brown
34d960ef20
BUGFIX 1178: Adding better existence check in one place. db_import now fails fast if target does not exist b/c no point going further without the target.
2014-06-17 14:37:14 -07:00
Scott Brown
1853a3f565
BUGFIX 7811: Adding file existence check when performing mysql import on a .gz or .bz2 file, otherwise Ansible will not notice that the underlying *nix command silently died.
2014-06-17 13:08:53 -07:00
James Cammarata
8d0d2831e6
Fixing mysql master replication boolean
...
Fixes #7528
2014-06-09 08:58:55 -05:00
Josef Špak
1dbc069bcb
Fix typo in CHANGE MASTER TO syntax
2014-06-02 13:42:55 +02:00
Mathieu Martin
9589ee2a41
Add example 'Specify grants composed of more than one word' to the mysql_user module.
2014-05-20 14:41:18 -04:00
Scott Sturdivant
40a6a6f911
Clarify that the encrypted param must also be set.
...
While the encrypted parameter's documentation clearly states that it needs to
be set, if you are focused on the password parameter's documentation, there's
nothing to draw your attention to the fact that encrypted may also need to be
set.
2014-05-14 07:49:11 -06:00
Adam Chainz
29b10ac698
Fix sync_binlog name in mysql_variables example
...
The previous sync_binary_log is not a real MySQL variable.
2014-05-06 12:25:11 +01:00
Carlos E. Garcia
4dcaa9d9fb
multiple spelling error changes
2014-04-29 10:41:05 -04:00
Cove Schneider
ae0721d3da
re-add idempotency check
2014-04-05 16:31:33 -07:00
Cove Schneider
428dead8cd
add replicaset support to mongodb_user module
2014-04-05 15:33:22 -07:00
Michael DeHaan
acd89f7a1f
Merge pull request #6796 from mistaka0s/mysqldump_fix
...
Remove extra quote from the mysqldump password argument
2014-04-02 17:24:35 -04:00
Matt Martz
a4078a4bf8
Use /usr/bin/python instead of /usr/bin/env python
2014-04-01 13:54:37 -05:00
Chao Luan
749e749c11
Remove extra quote from the mysqldump password argument
...
The mysqldb Ansible module will fail if the state specified is import or dump with a '1045: Access Denied' mysql error for complex passwords.
This is caused by the extra quote around the '--password' argument to mysqldump, as pipes.quotes already quotes the password string.
>>> "--password='%s'" % pipes.quote('simple')
"--password='simple'"
>>> "--password='%s'" % pipes.quote('c0mplexp@ssword!')
"--password=''c0mplexp@ssword!''"
>>> "--password='%s'" % pipes.quote('password with space')
"--password=''password with space''"
2014-04-01 23:52:08 +11:00
Jonathan Mainguy
17fa8e3c84
Added mpdehaan suggestion to use os.path.splitext. Wise suggestion, does look clearner
2014-03-31 11:09:00 -04:00
Jonathan Mainguy
f0b2616bd8
mysql_db module now correctly fails on import if bz2 or gz fails.
2014-03-30 13:39:00 -04:00
Michael DeHaan
ff5560f00c
Update comments about redis config.
2014-03-19 18:15:52 -04:00
Michael DeHaan
fbb15ad52f
Merge branch 'devel' of git://github.com/mleventi/ansible into devel
2014-03-19 18:15:06 -04:00
Michael DeHaan
d10b3f9257
Merge pull request #5597 from laggyluke/mongodb_user_idempotence
...
Fix idempotence in mongodb_user module
2014-03-16 15:50:43 -05:00
Cristian Ciupitu
7f681c33a2
Micro-optimization: replace s.find(x)!=-1 with x in s
...
timeit shows a speedup of ~3x on Python 2.7.5 x86_64.
It also makes the code a bit shorter.
2014-03-16 13:10:28 -04:00
Richard Isaacson
35b4cf001c
Merge pull request #6461 from risaacson/modules_make_run_command_safer
...
Modules make run command safer
2014-03-12 23:28:06 -05:00
Richard C Isaacson
122917019c
mysql_db module: typo fix
...
Tests clean.
2014-03-12 23:25:22 -05:00
Richard C Isaacson
d9da5cf084
Shell updates.
2014-03-12 22:15:56 -05:00
James Martin
0a74cb484c
Fixes various typos introduced in a9017af2bb
.
...
Fixes odd encoding problem with wait_for_service.
2014-03-12 21:26:16 -04:00
Michael DeHaan
980653f20b
More shell fixes
2014-03-12 17:43:31 -04:00
James Cammarata
72217c297d
Adding validate_certs to all modules that use fetch_url
2014-03-12 10:19:54 -05:00