cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity
23932 commits 47 branches 390 tags 440 MiB
Commit graph

10547 commits

Author SHA1 Message Date
Brian Coca
19b3d43aa5 added missing version_Added 2016-12-08 11:24:01 -05:00
Toshio Kuratomi
457dfb3b4b Add an internal param instructing synchronize to replace localhost with the host that's being ssh'd from 2016-12-08 11:24:01 -05:00
Yair Fried
63a0b99b6a Fix glance_client module 
Wrong variable name.
 2016-12-08 11:24:01 -05:00
Graham Ullrich
61ac748bad Update django_manage documentation 
As of Ansible 2.x, invocation of Django's ```manage.py``` requires a valid "shebang". Additionally, ```manage.py``` must be executable.
The old invocation was hardcoded as ```python manage.py ...``` while the new invocation is ```./manage.py ...```. See [this PR](https://github.com/ansible/ansible-modules-core/pull/1165).
This change allows more flexibility for which Python interpreter is invoked, but breaks existing deployment when ```manage.py``` is not properly configured. This documentation update adds a note explaining the new requirements for ```manage.py```.
 2016-12-08 11:24:01 -05:00
Matt Martz
9e686c7294 Add note about precautions of using become with fetch. Addresses https://github.com/ansible/ansible/issues/14064 2016-12-08 11:24:01 -05:00
Toshio Kuratomi
b6ff36bed3 Fix documentation build in hostname 2016-12-08 11:24:01 -05:00
Toshio Kuratomi
5e4fe92676 Fix documentation build 2016-12-08 11:24:01 -05:00
Toshio Kuratomi
5f35d0d597 Document that synchronize in 2.0.0.x has broken sudo behaviour. 
Part of the changes for #13825
 2016-12-08 11:24:01 -05:00
Toshio Kuratomi
f4c9c4596f Fix for yum's use of rpm with non English locales 
Depends upon https://github.com/ansible/ansible/pull/14025

Fixes https://github.com/ansible/ansible/issues/13996
Fixes https://github.com/ansible/ansible/issues/13975
 2016-12-08 11:24:00 -05:00
techraf
896dcd9787 Fixed typo in example playbook 2016-12-08 11:24:00 -05:00
Brian Coca
a0204b80dc tabs are bad 2016-12-08 11:24:00 -05:00
Julia Kreger
060e12a2d3 Add wait support to os_ironic_node 
Add support for the os_ironic_node module to be capible of waiting
until the baremetal node activation or deactivation has completed.
 2016-12-08 11:24:00 -05:00
Tom Bamford
68f76c50d8 Remove explicit region parameter from ec2_ami_find 2016-12-08 11:24:00 -05:00
David Shrewsbury
f6d6895ce9 Add purge option to os_floating_ip module 
Add the ability to completely delete a floating IP from the pool
when disassociating it from a server. When state is absent and
purge is true, the IP will be completely deleted. The default
keeps the current behavior, which is to only disassociate the IP
from the server.
 2016-12-08 11:24:00 -05:00
Lee H
8e84ba71ae - fix check_mode test to avoid errors 
- correct test mode check to ensure it returns and doesnt apply changes
  (via jmainguy)
 2016-12-08 11:24:00 -05:00
David Shrewsbury
aed44e8886 Fix OpenStack module failure output 
The exception message, when shade fails, will contain much more
specific information about the failure if the exception is treated
as a string. The 'message' attribute alone is usually not helpful.
 2016-12-08 11:24:00 -05:00
Ben Visser
18ff22348a fixed grammatical issue in iam.py. exit -> exist. 2016-12-08 11:24:00 -05:00
Hiroaki Nakamura
f2246deaf9 Doc: Add NOTE about hostname modules does not modify /etc/hosts 2016-12-08 11:24:00 -05:00
Evgeny Vereshchagin
8f23e54a80 apt-key: convert ids to the 'short' format 
Fixes:
$ ansible all -m apt_key -a 'state=present id=7A82B743B9B8E46F12C733FA4759FA960E27C0A6 keyserver=hkp://keyserver.ubuntu.com:80' --sudo
127.0.0.1 | SUCCESS => {
    "changed": true
}

$ ansible all -m apt_key -a 'state=absent id=7A82B743B9B8E46F12C733FA4759FA960E27C0A6' --sudo
127.0.0.1 | SUCCESS => {
    "changed": false
}

$ apt-key export 7A82B743B9B8E46F12C733FA4759FA960E27C0A6
-----BEGIN PGP PUBLIC KEY BLOCK-----
Version: GnuPG v1
...

See https://bugs.launchpad.net/ubuntu/+source/apt/+bug/1481871
 2016-12-08 11:24:00 -05:00
techraf
7d09792758 Added 'backup' parameter to get_url module 2016-12-08 11:24:00 -05:00
Yoichi Imai
b9b08666f5 Fix iam_policy pdoc variable 2016-12-08 11:24:00 -05:00
Thomas Quinot
ef3308159f Allow cron_file to be an absolute path 
Support specifying an absolute path (typically /etc/crontab) rather than
a path relative to /etc/cron.d, to allow modifying the main system crontab.
Particularly useful for target systems that have /etc/crontab but no
/etc/cron.d.
 2016-12-08 11:24:00 -05:00
Michael Scherer
519e699b98 Split a shell snippet in 2 to avoid using use_unsafe_shell=True 
Since use_unsafe_shell is suspicious from a security point
of view (or it wouldn't be unsafe), the less we have, the less
code we have to toroughly inspect for a security audit.

In this case, the '&&' can be replaced by doing 2 calls to run_command.
 2016-12-08 11:24:00 -05:00
Jason Paige
a2f4d46c9b updating choices for rds parameter engines 2016-12-08 11:24:00 -05:00
Aaron Kurtz
e3782689bc Remove 'cache_table' from required params 
Starting in Django 1.7, the createcachetable command looks for cache
table names in the CACHES settings dictionary, so cache_table is no
longer required, but is still allowed.
 2016-12-08 11:23:59 -05:00
Bermudez, Jaime
efbdea909e Simplify logic around "present" state and skip dupes. If the policy doesn't exist or the policy document doesn't match or if we're not skipping dupes, then we go ahead and update the respective user/group/role policy. 2016-12-08 11:23:59 -05:00
daniel-sc
f654bd45f8 Allowing specifying ip by address 2016-12-08 11:23:59 -05:00
daniel-sc
40565b7293 Allowing to specify specific external ip for gce instances 2016-12-08 11:23:59 -05:00
Albert Mikaelyan
a61095b0b1 Update yum.py 2016-12-08 11:23:59 -05:00
Vladimir Mihailenco
2bdfea4a43 rackspace: set headers when uploading files to CF. 
Otherwise CDN (Akamai) downloads file without the headers. The sequence
is following:
1. Ansible uploads file to CF.
2. Akamai downloads the file and caches it in CDN.
3. Ansible sets headers.

As a result Akamai serves file without headers.

This is backwards incompatible change, because headers keys are not
prefixed with `x-object-meta-`. Which allows user to set headers like
`Access-Control-Allow-Origin`.
 2016-12-08 11:23:59 -05:00
bobgroves
18d4a33891 Makes rax_dns_record override default to true 2016-12-08 11:23:59 -05:00
bobgroves
65697dea14 Adds overwrite option to rax_dns_record 2016-12-08 11:23:59 -05:00
Jordan Bach
b6213ffa80 git: set remote branch before switching versions when using depth argument 2016-12-08 11:23:59 -05:00
Luca Berruti
0673a4919f cron module: add enviroment variables management 2016-12-08 11:23:59 -05:00
Henrique Rodrigues
c2e62ed9a9 Fix misspelling of the word 'certificate' 2016-12-08 11:23:59 -05:00
Brian Coca
b25c2a4261 added note about awslogs version added 2016-12-08 11:23:59 -05:00
Brian Coca
6e73c61298 added version_added 2016-12-08 11:23:59 -05:00
Constantin07
f36c567022 Added delete_on_termination option for volume attachment 2016-12-08 11:23:59 -05:00
Matt Ferrante
2dd53a8d91 updated s3 module documentation 2016-12-08 11:23:59 -05:00
jefferson fermo
9d9daeb73c add awslog option in docker log driver. this option is available starting with ansible 2.1 2016-12-08 11:23:59 -05:00
Brian Coca
4c6515e299 reverse order of cron commands 
does not affect linux but fixes issue with busybox caring about order
fixes #2807
 2016-12-08 11:23:58 -05:00
nitzmahone
821fb6c0ab fix win_get_url var renames ala xpicio fix PR #2378 
reimplements #2378 sans formatting merge conflicts
 2016-12-08 11:23:58 -05:00
Jeroen Seegers
7be08b00b0 Update cron.py 
Minor update to documentation for the cron module to reflect the required "name" parameter when the value of "state" is "absent".
 2016-12-08 11:23:58 -05:00
Brian Coca
f50fbe9dd2 updated s3 docs to reflect mode choices 
fixes #2318
 2016-12-08 11:23:58 -05:00
autotune
90631aef1b 1113 fix ec2 subnet tags 2016-12-08 11:23:58 -05:00
nitzmahone
fef6e5102e fix version_added on win_msi wait arg 2016-12-08 11:23:58 -05:00
Brian Coca
a5e4969dc4 updated version_added 2016-12-08 11:23:58 -05:00
Joost Cassee
267dcc8eb6 Add wait_timeout option to route53 module 
This option is used to make sure the module does not block forever.
 2016-12-08 11:23:58 -05:00
Joost Cassee
e91bcba078 Add wait option to route53 module 
This option makes the module wait for the changes to replicate to all
Amazon DNS servers.
 2016-12-08 11:23:58 -05:00
Mark van Driel
a24cdbe15e Fixed "invalid privileges string: set expected at most 1 arguments, got 2" 2016-12-08 11:23:58 -05:00
Jonathan Mainguy
e9a752f769 add ansi support 2016-12-08 11:23:58 -05:00
Ben Visser
cfed7e11d8 two choices for cache engine. adding them. 
revert spacing

undoing quotes around default. will do another pull requests

Making documentation more explicit for elasticache engine choices.
 2016-12-08 11:23:58 -05:00
Matt Clay
d861329d5e Added filename option to apt_repository module. 2016-12-08 11:23:58 -05:00
Hillel Antonov
8d5cebd597 Adding gathering environment variables to gather facts on Windows making similar in functionality to gather facts on Linux 2016-12-08 11:23:58 -05:00
Hans-Joachim Kliemeck
1354ef0285 fix problem with file content and high cpu/out of memory errors 2016-12-08 11:23:58 -05:00
Timothy R. Chavez
2ef913a288 Pass network argument to add_ips_to_server 
The `network` argument needs to be passed through `add_ips_to_server`
so that the default value can be properly overridden from ansible.
 2016-12-08 11:23:58 -05:00
Marios Andreopoulos
1ae765d61f fix: do not set scopes account to service account used for instance creation 2016-12-08 11:23:58 -05:00
Hans-Joachim Kliemeck
41ab7f8aed do not move item, instead copy item because acl will be kept 2016-12-08 11:23:57 -05:00
Alexey Wasilyev
4d30ae313d Add cpu_shares option for docker module 2016-12-08 11:23:57 -05:00
krdlab
c680611fe4 Fix self.changed value in ElbManager (ec2_elb_lb) 2016-12-08 11:23:57 -05:00
Jordi Gutiérrez Hermoso
4682ea1c3c hg: discard changes without changing the current revision 
The command `hg up -C` by default moves to the latest revision on the
current branch. The `discard` function was trying to update to a
different branch, in case it was provided, by passing a `-r REVISION`
argument. Not only is this not the intended effect of the `discard`
function, but this also could update to a different branch that hasn't
been pulled yet, which is how we were experiencing trouble.

Instead, we unconditionally do `hg up -C -r .` to "update" to the
current revision (i.e. to "."), while `-C/--clean`ing the current
directory. This is similar to `hg revert --all`, except that it also
undoes the merge state of the working directory, in case there was
any.
 2016-12-08 11:23:57 -05:00
Will Rouesnel
b565da78b3 docker: Fix state=reloaded to detect default LoggingDriver for docker 
Previously the logging module hard coded the default logging driver. This means
if the docker daemon is started with a different logging driver, the ansible
module would continually restart it when run.

This fix adds a call to docker.Client.info(), which is inspected if a logging
driver is not supplied in the playbook, and the container only restarted if
the logging driver applied differs from the configured default.

In usage, this has solved issues with using alternative logging drivers.
 2016-12-08 11:23:57 -05:00
Corwin Brown
c075c000c8 Adding Facter 2016-12-08 11:23:57 -05:00
Brian Coca
351de21ee7 made port default depending on db engine 2016-12-08 11:23:57 -05:00
Mark van Driel
d67f2eb104 Fixes require ssl in combination with other privileges 
Fixes require ssl in combination with grant option

Refactoring: code cleanup to make it easier to understand

Code rewritten inspired by @willthames

Added WITH GRANT OPTION as exception; when only REQUIRESSL and/or GRANT are specified we have to add USAGE
 2016-12-08 11:23:57 -05:00
Phil
3781c5ccb0 uses get-attr and fixes file path issues by escaping quotes around path 2016-12-08 11:23:57 -05:00
schwartzmx
5ff4d219e0 updates win_msi to allow install to wait - adds additional wait param - updates to use Start-Process to allow -Wait - this will wait for install/uninstall to complete before continue 2016-12-08 11:23:57 -05:00
Jan Duzinkiewicz
9c6db69827 forcing git fetch if sha1 are equal between repos but branch exists only at remote 
Add an explanatory comment to the code
 2016-12-08 11:23:57 -05:00
Brian Coca
3afaa2fef4 really fixed the doc formatting 2016-12-08 11:23:57 -05:00
Brian Coca
1fe3387971 crrected version added 2016-12-08 11:23:57 -05:00
Brian Coca
e2062c44d9 made note about choice availability in ansible ver 2016-12-08 11:23:57 -05:00
Brian Coca
0ca9356675 added versions note in description for new choice 2016-12-08 11:23:56 -05:00
Brian Coca
f5ddbd5c49 fixed win_feature docs 
added version_added for source and fixed some yaml parsing
 2016-12-08 11:23:56 -05:00
Pavel Derendyaev
3129154a2a Add "timeout" option to Docker module 2016-12-08 11:23:56 -05:00
Trond Hindenes
abcae97422 update doc 2016-12-08 11:23:56 -05:00
Trond Hindenes
37a24cc1b1 bugfix win_feature.ps1 2016-12-08 11:23:56 -05:00
Trond Hindenes
21b79123a4 Add source as optional parameter 2016-12-08 11:23:56 -05:00
KIKUCHI Koichiro
2974358b2b Add check_mode support to mysql_user. 2016-12-08 11:23:56 -05:00
Arata Notsu
a9f23ac54f apt: export env vars before run dpkg 
Without this change, some trouble may occur when "deb" parameter
is used as env vars controlling dpkg are not set. For example,
installing a package that requires user input will never end since
DEBIAN_FRONTEND=noninteractive is not set.

So export env vars in APT_ENV_VARS before run dpkg, like in cases
using apt-get/aptitude.
 2016-12-08 11:23:56 -05:00
Jonathan Mainguy
47d0719cfe Fix bad merge 2016-12-08 11:23:56 -05:00
Brian Coca
288a5c9a77 adds diff info for file info 2016-12-08 11:23:56 -05:00
nitzmahone
60ca6e2f85 fix win_file to stop on errors 2016-12-08 11:23:56 -05:00
Jon Hadfield
d0e37fa542 return allocation id for vpc address. 2016-12-08 11:23:56 -05:00
Dmitry Labutin
b20066ff8e Fix issue #2721: os_object parameters and docs don't align (file/filename) 2016-12-08 11:23:56 -05:00
Dmitry Labutin
60b1273d55 Github uses both HTTP and HTTPS protocols 2016-12-08 11:23:56 -05:00
Ben Visser
a01fe88263 staging that num_nodes is required when state=present 2016-12-08 11:23:56 -05:00
Brian Coca
1367e73c94 be smarter when dealing with policy_json input 
Now module will assume that if the argument is a string it is already formated as json
and will only try to convert non strings into json string.
Also removed unused 'msg' var declarations and the ifs that set them
fixes #2009
 2016-12-08 11:23:56 -05:00
Vic Iglesias
353db36515 Update GCE PEM deprecation text and examples 2016-12-08 11:23:56 -05:00
Barnaby Court
73d47ec7a4 add no_log to the password parameter 2016-12-08 11:23:55 -05:00
Charles Paul
980691338a adding no_log to password 2016-12-08 11:23:55 -05:00
Michael Scherer
d321670b38 Add more precise documentation on the requirements parameter 
Fix #427
 2016-12-08 11:23:55 -05:00
Michael Scherer
83b45ae047 Fix doc inconsistency (#2630) 2016-12-08 11:23:55 -05:00
Vic Iglesias
612d9c3e92 Use credentials_file for GCE module auth config 2016-12-08 11:23:55 -05:00
tksarah
7ad225eedd Edit azure.py 2016-12-08 11:23:55 -05:00
Etherdaemon
eba78d08f9 Update to wait and wait_timeout with a maximum of 10 minutes timeout 2016-12-08 11:23:55 -05:00
luto
610de975e6 vsphere_guest: when creating a guest, gather facts about it *before* disconnect 2016-12-08 11:23:55 -05:00
Etherdaemon
cd3f306518 Proposing a wait_for function to ensure elb has been successfully removed 2016-12-08 11:23:55 -05:00
Josh Rendek
bddcf737c9 Fix quote on grants of more than one word 
Fixed a quote location on the grants composed of more than one word. Current docs will raise an error with a invalid privilege command.
 2016-12-08 11:23:55 -05:00
Mike Buzzetti
f20b09e2ec Add evaluate taget health for alias based records 2016-12-08 11:23:55 -05:00
sebi
76af56eaca added unless stopped option 2016-12-08 11:23:55 -05:00
Martin Matuska
4cce825ae9 rhn_register: add sslcacert and systemorgid options 2016-12-08 11:23:55 -05:00
Brian Coca
7d6c704404 fix bad linebreak 2016-12-08 11:23:55 -05:00
Michael Scherer
69036826a8 Fix #2629, replace choices=BOOLEANS by type='bool' 2016-12-08 11:23:55 -05:00
Alexander Gubin
b0d54092ee command: Add warnings for dnf and zypper 2016-12-08 11:23:55 -05:00
luto
d20c4368d2 vsphere_guest: add power status to facts 2016-12-08 11:23:55 -05:00
stephane
40e7ed9518 Add support for pip force-reinstall 
The pip command allows a user to force reinstallation,
but the module doesn't currently support it. Add
"force-reinstall" as a possible state.
 2016-12-08 11:23:54 -05:00
Manuel Tiago Pereira
057cbacf8a Add support for legacy registries to pull_image(). 
Since we now have several exceptions to the assumption that the
result of the pull would be on the last status line returned by
docker-py's pull(), I've changed the function so that it looks
through the status lines and returns what if finds on it.
Despite the repeated `break`s, the code seems simpler and a little
more coherent like this. From what I've checked using
`https://github.com/jlafon/ansible-profile`, the execution time is
mostly the same.
 2016-12-08 11:23:54 -05:00
Sam Thursfield
eba767902c os_server: Add some error checking for the 'nics' parameter 
If this parameter was not of the right type, the module would fail with a
traceback, with a "AttributeError: 'str' object has no attribute 'get'"
exception.

It now gives a proper error message on type errors.
 2016-12-08 11:23:54 -05:00
nitzmahone
317ea13759 win_get_url doc/strict-mode fixes 
plus cleaning up from bad merge
 2016-12-08 11:23:54 -05:00
nitzmahone
feb077261e minor win_get_url doc update 2016-12-08 11:23:54 -05:00
T.Kuramochi
dfda2e9f57 Add HTTP Proxy options 
Update a document file for win_get_url.ps1.

Update add a prefix proxy_ for this variables

Update a document file for win_get_url.ps1.

Update win_get_url.ps1 20150907
 2016-12-08 11:23:54 -05:00
Toshio Kuratomi
7a492764d0 Fix up documentation 2016-12-08 11:23:54 -05:00
Toshio Kuratomi
4fa9de5af3 entrypoint feature added in 2.1 2016-12-08 11:23:54 -05:00
Toshio Kuratomi
eb65f819f5 labels is actually not aded in 1.9.4 but in 2.1 2016-12-08 11:23:54 -05:00
Andrew Pashkin
c811a3f4bc Add 'entrypoint' parameter to Docker module 2016-12-08 11:23:54 -05:00
Andrew Pashkin
8342397427 Harden matching running containers by "command" in the Docker module 
Before this patch:

  - Command was matched if 'Command' field of docker-py
    representation of Docker container ends with 'command' passed
    to Ansible docker module by user.
  - That can give false positives and false negatives.
  - For example:
      a) If 'command' was set up with more than one spaces,
         like 'command=sleep  123', it would be never matched again
         with a container(s) launched by this task.
         Because after launching, command would be normalized and
         appear, in docker-py API call, just as 'sleep 123' - with one
         space. This is false negative case.
      b) If 'entrypoint + command = command', for example
         'sleep + 123 = sleep 123', module would give false positive
         match.

This patch fixes it, by making matching more explicit - against
'Config'->Cmd' field of 'docker inspect' output, provided by docker-py
API and with proper normalization of user input by splitting it to
tokens with 'shlex.split()'.
 2016-12-08 11:23:54 -05:00
Omar Khan
369fe78c60 Add stop_timeout option to docker module 2016-12-08 11:23:54 -05:00
Toshio Kuratomi
a708ad65c4 Add version_added to documentation 2016-12-08 11:23:54 -05:00
Joe Quadrino
b6e2b2dce1 add devices parameter for docker module 2016-12-08 11:23:54 -05:00
Yann Hamon
1faf8dd5c2 Docker module: restarted should update the container when necessary 2016-12-08 11:23:54 -05:00
Andy Nelson
444895f889 Update to ec2_vpc.py to: 1 allow interface ids and vpc peering connections as route targets 2 set state to "terminated" when VPC is removed 3 fix some comment typos 
updates per PR comments
 2016-12-08 11:23:54 -05:00
HAMSIK Adam
2af105bcbc Convert enabled value to boolean to actually work, make sure we can set expiration period to 0(None) to disable it 2016-12-08 11:23:53 -05:00
Pedro Romano
bcae9a2b5e GCE libcloud 0.15 support and code cleanup * Code formatting (indentation and white space) fixes for improved PEP8 conformity. * Remove redundant backslashes inside parentheses. * Test for object identity should be 'is not None'. * Test for membership should be 'not in'. * Fit docstring to the PEP8 79 character limit. * Use forward compatible Python 2.6+ 'except .. as' syntax for exception handling. * Support libcloud > 0.15 'metadata' argument format. 2016-12-08 11:23:53 -05:00
Toshio Kuratomi
65b9243056 mariadb isn't always the last elemen of the version string 2016-12-08 11:23:53 -05:00
Toshio Kuratomi
0a64899eba Fix mysqldump usage of config_file 2016-12-08 11:23:53 -05:00
Brian Coca
f8a36c4047 service goes back to failing when absent 
if no tools and no init script, this should always fail
 2016-12-08 11:23:53 -05:00
Alberto Gireud
58c39f47c1 Update root_volume variable 2016-12-08 11:23:53 -05:00
Toshio Kuratomi
dafb39da2e Account for mariadb versioning 2016-12-08 11:23:53 -05:00
luto
d48dffc298 vsphere_guest: support putting a guest into a nested folder 2016-12-08 11:23:53 -05:00
Jonathan Mainguy
0cdb2719e5 Unify all 3 mysql modules. 
Use same connection method, use config_file, and add ssl support
 2016-12-08 11:23:53 -05:00
Toshio Kuratomi
8d293651df Fix os_server docs build 2016-12-08 11:23:53 -05:00
Lee H
7feb64d31c - add version_added as requested to host_all 2016-12-08 11:23:53 -05:00
Lee H
5606197c28 - remove user_anonymous as the same thing can be accomplished by user='', but leave in the examples for removing anonymous users 2016-12-08 11:23:53 -05:00
Donovan Jones
8b9cd7f410 fix typo in os_server security_groups description 2016-12-08 11:23:53 -05:00
Brian Coca
9259b51c97 updated module docs, added choices to state 2016-12-08 11:23:53 -05:00
Tobias Smolka
cf5403afa3 Making cluster parameter optional 2016-12-08 11:23:53 -05:00
Brian Coca
63fd67f156 added mime option to stat module 
it uses file magic to now return mime_type and charset of a file as
per output of `file -i /path`
 2016-12-08 11:23:53 -05:00
Lee H
95895177d0 - add example showing removal of anonymous user accounts 2016-12-08 11:23:52 -05:00
Monty Taylor
a715c91d0b Add support for network, boot_from_volume and volumes 
nics is a great flexible parameter, but it's wordy. Shade now supports
a simple parameter too, which is just "network" and takes a name or id.
Add passthrough support.

In addition to supporting booting from a pre-existing volume, nova and
shade both support the concept of booting from volume based on an image.
Pass the parameters through.

Shade supports boot-time attachment of additional volumes for OpenStack
instances. Pass through the parameter so that ansible users can also
take advantage of this.
 2016-12-08 11:23:52 -05:00
Toshio Kuratomi
687257bd62 Use rpm instead of repoquery for is_installed() 
* This keeps us from hitting bugs in repoquery/yum plugins in certain
  instances (#2559).

* The previous is also a small performance boost

* Also in is_installed(), when using the yum API, return if we detect
  a package name has been installed.  We don't need to also check
  virtual provides in that case.  This is another small performance
  boost.

* Sort the list of packages returned by the list parameter.
 2016-12-08 11:23:52 -05:00
Brian Coca
3b934016c0 note that create globs only work on 2.0 
fixes #2666
 2016-12-08 11:23:52 -05:00
Brian Coca
b4f87ac7fe made note that Z/z are only 2.1 options 2016-12-08 11:23:52 -05:00
Jonathan Mainguy
b86224a7ec Add Jmainguy as author, fix hash check 2016-12-08 11:23:52 -05:00
Adam Fields
9c131ea619 added a reference to the template module for clarity 2016-12-08 11:23:52 -05:00
Timothy R. Chavez
37ac954123 Get new server object after adding floating IP 
We need a new server object once we add the floating ip, otherwise we
will be operating with the older server object pre-floating-ip
assignment.
 2016-12-08 11:23:52 -05:00
Michel Alexandre Salim
325a979876 Set the argument type for ec2_vol's encrypted parameter 
If this is not set, Ansible parses the parameter as a string.
This is fine if the parameter is not provided by the caller, but
if it is set to False or True explicitly, ec2_vol receives this as
the string 'False' or the string 'True', both of which are truthy.

Thus, without this fix, setting the parameter results in encryption
always enabled.
 2016-12-08 11:23:52 -05:00
Veaceslav Mindru
fa98f55c44 fix typo s/defaults/default 2016-12-08 11:23:52 -05:00
Steve Spencer
d4aca8eacc Sync up with allowable docker volume mounting modes 2016-12-08 11:23:52 -05:00
Steve Spencer
769d7db1d0 Add support for mounting host volumes with Z and z options 2016-12-08 11:23:52 -05:00
Lee Hardy
f2f0f83ee6 - fix user_exists statement with host_all to use only username parameter 2016-12-08 11:23:52 -05:00
Leonty
22648e88cd Corrected misspelling in the 'labels' docker parameter documentation. 2016-12-08 11:23:52 -05:00
Lee Hardy
1113975741 - mysql: add user_anonymous parameter, which interacts with anonymous users - mysql; add host_all parameter, which forces iteration over all 'user'@... matches 2016-12-08 11:23:51 -05:00
Brian Coca
f435f887fa better handling of checkmode for solaris fixes #2296 2016-12-08 11:23:51 -05:00
Aaron Boushley
876bdb62e1 Fix issue with comparing versions improperly. 
This allows old versions of docker api to function.
 2016-12-08 11:23:51 -05:00
Leonty
8638d9d26c Support 'labels' parameter for docker. 2016-12-08 11:23:51 -05:00
Jumpei Ogawa
ebb0d6301d Add explanation in case that ipv4_range is required 2016-12-08 11:23:51 -05:00
Jumpei Ogawa
256c840942 Add better error message when specified network doesn't exist and ipv4_range is not specified 2016-12-08 11:23:51 -05:00
tobbe
65f12bccb6 add text to the description, more user friendly 2016-12-08 11:23:51 -05:00
tobbe
455da45e62 Add suport for selinux user when adding a new user on selinux enabled systems 2016-12-08 11:23:51 -05:00
Daniele Varrazzo
a057431a78 Detect unchanged pip runs when using a vcs url in name 
Should fix bug #1645
 2016-12-08 11:23:51 -05:00
Daniele Varrazzo
53e1310a7f Use 'pip freeze' output to detect changes with requirement specified 
If the requirements contains a repos url it will always report 'Successfully
installed'; there is no difference in the output to tell apart if
anything new was pulled. Use freeze to detect if the environment changed
in any way.

Should fix ansible/ansible#1705
 2016-12-08 11:23:51 -05:00
Derek Smith
b9baed507b updated examples 
added mysql 5.7 user password modification support with backwards compatibility

resolved mysql server version check and differences in user authentication management

explicitly state support for mysql_native_password type and no others. fixed some failing logic and updated samples

updated comment to actually match logic.

simplified conditionals and a little refactor
 2016-12-08 11:23:51 -05:00
trevoro
b5a3dd4818 adding password_hash support to mysql_user module 
fixing user_add arguments error

fixing user_mod arguments error
 2016-12-08 11:23:51 -05:00
Michael Scherer
55f2345829 Remove a unneeded use of use_unsafe_shell 
Since use_unsafe_shell is suspicious from a security point
of view (or it wouldn't be unsafe), the less we have, the less
code we have to toroughly inspect for a security audit.
 2016-12-08 11:23:51 -05:00
Daniel Kimsey
a8f7fda210 Fix yum module failing to initalize yum plugins 2016-12-08 11:23:51 -05:00
nitzmahone
0d0b78dd1e fixed disappearing groups on OSX user module 
Ensure that we don't try to modify the groups collection if groups are not specified
 2016-12-08 11:23:51 -05:00
Dominique Barton
5c05016d1e bugfix for issue #2537 2016-12-08 11:23:51 -05:00
quoing
3ad67d93ea Fix: Default ACL parameters are not correctly handled 2016-12-08 11:23:51 -05:00
Brian Coca
f0a3914f7b simplified lowercasing 2016-12-08 11:23:50 -05:00
quoing
3a91853e7e Add "default" entry option back (removed in e95bcae), update will translate entry to standard parameters so compatibility with BDS is kept 2016-12-08 11:23:50 -05:00
Mark Theunissen
c3450d542f Remove Mark Theunissen as maintainer 2016-12-08 11:23:50 -05:00
Toshio Kuratomi
94d163f3ed When the password file does not exist and we're making sure the user isn't in the password file, change error into a warning 
Warning catches typos in the filename.  Since the playbook is saying
"make sure this user doesn't have an entry" it makes more sense to warn
than to error.

Fixes #2619
 2016-12-08 11:23:50 -05:00
Arthur Clement
7c8d3d9b20 Example of single instance with ssd gp2 root volume creation 2016-12-08 11:23:50 -05:00
Ales Nosek
df4109d946 Fix #2475 ini_file module: bracklets in key break idempotence 
Escape the regex special characters in the option name.
 2016-12-08 11:23:50 -05:00
Brian Coca
42d0ce8744 corrected version_added for new temp_dest feature 2016-12-08 11:23:50 -05:00
cspollar
7ac010977b Fixed typo in uri module example 2016-12-08 11:23:50 -05:00
krdlab
fe0aa01ce8 Fix 'stat' module document 2016-12-08 11:23:50 -05:00
Toshio Kuratomi
6cb1606005 Don't raise or catch StandardError in amazon modules 2016-12-08 11:23:50 -05:00
Dylan Martin
579e444243 improved error message when no handler found 2016-12-08 11:23:50 -05:00
Brian Coca
3025451b10 fixed typo EEXISTS is actually EEXIST 
fixes #2585
 2016-12-08 11:23:50 -05:00
Veaceslav Mindru
0f456d7e61 adding validate_certs for YUM. #2582 2016-12-08 11:23:50 -05:00
Sina Sadeghi
2ad9c6c9e5 Update hostname.py 
Added support for FreeBSD. (http://www.freebsd.org)
 2016-12-08 11:23:50 -05:00
Charles Ferguson
4c93b5dab6 Add documentation to 'file' AnsibleModule definition for internals. 
The parameters 'diff_peek' and 'validate' are not expected to be used
by users. They are internal. To make it clear, this change adds the
comments 'Internal use only' to each of those definitions to make
it clear that they are actually used, just not by end-users.
 2016-12-08 11:23:50 -05:00
Brian Coca
b3c14ee0c3 minor doc fixes and reformating updated validate_certs feature to be 2.1 2016-12-08 11:23:50 -05:00
Charles Ferguson
e86ba78685 Update documentation for 'file' module to include 'diff_peek'. 
The 'diff_peek' option isn't documented at all, and provides a
rudimentary check that the content isn't binary. Documentation is
added to explain the option.

The 'validate' option has a declaration, but isn't implemented.
Therefore it may as well be removed from the module.
 2016-12-08 11:23:49 -05:00
Veaceslav (Slava) Mindru
2eb6b566b2 Squashed commit of the following: 
commit 406214fad214359fcf13fe8c7cd3f8f8faac5386
commit 85d1c9b0a41dd075eb2683b1a7de595ca3119614
commit 4aa5049b5ae25dee71a248238201611a466a13c4
commit 65a96974c80aea1fef88d78e218ecb665d8113e1
commit 22ea5863d1dfd628735b46cc7de51c0fd33251de

Refactoring
 2016-12-08 11:23:49 -05:00
Markus Suonto
39d3c3dea6 fixed quantum_ modules to work with minimum access rights if greater access rights are not needed 2016-12-08 11:23:49 -05:00
jhawkesworth@users.noreply.github.com
5453d1e959 Fix for 13315 - minute now included in ansible_date_time on windows hosts 2016-12-08 11:23:49 -05:00
Jay Rogers
bef2b75857 Update in Amazon IAM Policy Documentation 
There were typos in the documentation that made the examples seem misleading of what was being demonstrated. This update fixes that.
 2016-12-08 11:23:49 -05:00
Brian Coca
b30438f2c8 updated docs to denote retirement of v1 api and clarify when and why auth fields have changed 2016-12-08 11:23:49 -05:00
Lippy Lee
2ce1f87bf8 Make digital_ocean_domain use API v2 2016-12-08 11:23:49 -05:00
Michel Alexandre Salim
fba26fda1c Fix ec2_snapshot documentation 
last_snapshot_min_age is added in 2.0, not 1.9
 2016-12-08 11:23:49 -05:00
Martin André
aaa82d1942 Fix typo in ping module short description 2016-12-08 11:23:49 -05:00
Brian Coca
1c1c8d0854 doc updates - added version_added to new api_token - updated notes to explain API issues, option switch and versions affected. 2016-12-08 11:23:49 -05:00
Max Rothman
086038cb4f Fix rds "promote" command never promoting 
Previously, the `promote` command in the `rds` module would always return OK and never actually promote an instance. This was because `promote_db_instance()` had its conditions backwards: if the instance had the `replication_source` attribute indicating that it **was** a replica, it would set `changed = False` and do nothing. If the instance **wasn't** a replica, it would attempt to run `boto.rds.promote_read_replica()`, which would always fail.
 2016-12-08 11:23:49 -05:00
joshuaeke
88f221fd9f Update ec2.py remove state tag 
'exact_count' and 'state' are mutually exclusive options they should not be in the following examples:
- # Enforce that 5 running instances named "database" with a "dbtype" of "postgres" example and
- # Enforce that 5 instances with a tag "foo" are running
 2016-12-08 11:23:49 -05:00
Charles Ferguson
ac1e4bf6e0 Update the documentation of the 'apt' action for the 'name'. 
The package name has two aliases, 'package' and 'pkg'. Add them to the
documentation.
 2016-12-08 11:23:49 -05:00
Toshio Kuratomi
a90de29ceb Minor simplification of code 2016-12-08 11:23:49 -05:00
Charles Ferguson
3969bba771 Update documentation of the 'pkg' and 'state' parameters in yum. 
The yum module allows the 'name' parameter to be given as 'pkg', in
a similar way to some of the other package managers. This change
documents this alias.

The module's 'state' parameter has two other aliases, in line with
the 'apt' action; the 'state' parameter can take 'installed' as an
alias for 'present', and 'removed' as an alias for 'absent'. These
aliases are documented.
 2016-12-08 11:23:49 -05:00
Brian Coca
2efb97e9d5 corrected version_added, removed empty alias 2016-12-08 11:23:49 -05:00
David Shrewsbury
5c5db04ff0 Bug fix for os_image and min_disk/min_ram 
The min_disk and min_ram parameters were not being passed to
the shade API. They also need to be integer values. Also
updated the description of these parameters for better
clarification.
 2016-12-08 11:23:49 -05:00
Charles Paul
52d499d268 create non-existent ini file 
fixing fail_json

more verbose fail msg
 2016-12-08 11:23:48 -05:00
Keith Hassen
f7dfcc153e Fail if any group name is not resolved to an ID. 2016-12-08 11:23:48 -05:00
Daniel Donckers
5c7f72233f Fixes #822 2016-12-08 11:23:48 -05:00
Chris Streeter
04b52efb64 Fix name of ssh_opts arg 2016-12-08 11:23:48 -05:00
Chris Church
fea4308c69 Remove note about only using win_copy for small files. 2016-12-08 11:23:48 -05:00
Mike Riddle
f0156dda0d Fixed error message: TypeError: fail_json() takes exactly 1 argument (2 given) 2016-12-08 11:23:48 -05:00
David Shrewsbury
ebd977e780 Fix os_user_group module 
This module had a couple of errors in it. Also added check mode
support.
 2016-12-08 11:23:48 -05:00
Brian Coca
0425d6be39 fixed break order 2016-12-08 11:23:48 -05:00
Tom Paine
0bf5fa1c23 Update ec2_elb_lb.py 2016-12-08 11:23:48 -05:00
Maarten Claes
e0b8b0d789 This fixes copy with the remote_src option 
It was broken in 6e37f1dcef when the remote_src was added. Need to
pass the absolute path to copy2 instead of a tuple.
 2016-12-08 11:23:48 -05:00
Brian Coca
e1d0f3ff59 clarified set_fact function 2016-12-08 11:23:48 -05:00
James Cammarata
801c1cab49 Version bump for new beta 2.0.0-0.5.beta3 2016-12-08 11:23:48 -05:00
Marcin Stolarek
d3029a6059 Save changes of special characters to rset, without that comparison rset.to_xml() == wanted_rset.to_xml() will fail if record contains * or @ characters. 2016-12-08 11:23:48 -05:00
Marcin Stolarek
3c7787c05c It may be string with int comparison, if ansible user specifies identifier as int 2016-12-08 11:23:48 -05:00
J Levitt
502717d387 Add rds restore example to list of examples 
There was no db restore example. I've provided one that shows how to do the restore, then add a security group (you cannot add the security group during the restore step -- it has to be done in a modify step afterward). Also, I show how to get the endpoint.
 2016-12-08 11:23:48 -05:00
Brian Coca
139201ad83 fixed remote_src support, now actually copies and does not move 2016-12-08 11:23:48 -05:00
Jordi De Groof
7aa57219f6 Update facts when hostname is changed 
ansible_hostname contains the unqualified hostname
 2016-12-08 11:23:48 -05:00
Monty Taylor
a848d06a04 Use add_ips_to_server API 
This module is still using an old pre-release API and needs to update
to use the current API.

Co-Authored-By: Marton Kiss <marton.kiss@gmail.com>
 2016-12-08 11:23:47 -05:00
Timothy Appnel
f2e83fa452 Added the checksum_algo alias to the stats module. 2016-12-08 11:23:47 -05:00
Toshio Kuratomi
6f214bccca Add zfil as an owner of the docker module 2016-12-08 11:23:47 -05:00
Toshio Kuratomi
edaa4c3f32 Add a new contributor as a maintainer of the docker module 2016-12-08 11:23:47 -05:00
Toshio Kuratomi
2b8a7e88e9 Fix escaping of newline carriage return characters in the documentation 2016-12-08 11:23:47 -05:00
nitzmahone
45fff5d939 fixed ansible_totalmem fact returning 0 
Win32_PhysicalMemory CIM object is busted on some virtual environments, switched
to Win32_ComputerSystem.TotalPhysicalMemory
 2016-12-08 11:23:47 -05:00
Rabenstein
8eb04fe0d3 Squash of 3 commits for bugfix. 
Absent unction was not working on user with login profile
also fixed the exception handling

fixed the delete user function
now works with or without loginprofile (password)

typo
 2016-12-08 11:23:47 -05:00
Rabenstein
4c08545974 Absent unction was not working on user with login profile also fixed the exception handling 2016-12-08 11:23:47 -05:00
Stewart Rutledge
b71740125d Added support for reconfiguring network (moving to another switch, for example) 2016-12-08 11:23:47 -05:00
Lars Larsson
542eb2e09c total_seconds not present on timedelta on python2.6 2016-12-08 11:23:47 -05:00
Brian Coca
7517e6366e use marker instead of is_truncated which does not seem to work 2016-12-08 11:23:47 -05:00
Ales Nosek
4e787f17cf Make the syntax work with Python 2.4 2016-12-08 11:23:47 -05:00
Brian Coca
90d084d82b loop to get all load balancers, boto limited to 400 at a time fixes #2115 2016-12-08 11:23:47 -05:00
Ales Nosek
bd03dd67ff ini_file should only change what was specified and nothing more #5860 
See also:
http://alesnosek.com/blog/2015/08/03/improving-ansibles-ini-file-module/
 2016-12-08 11:23:47 -05:00
Lars Kellogg-Stedman
35240830f6 os_server_facts returns facts about multiple servers 
have `os_server_facts` call `list_servers` rather than `get_server`, and
treat the `server` parameter as a wildcard pattern.  This permits one to
get facts on a single server:

    - os_server:
        server: webserver1

On mutiple servers:

    - os_server:
        server: webserver*

Or on all servers:

    - os_server:

Introduces a `detailed` parameter to request additional server details
at the cost of additional API calls.
 2016-12-08 11:23:47 -05:00
Jonathan Mainguy
caf6115f43 Update documentation to reflect need for mysql client 2016-12-08 11:23:46 -05:00
Kevin Falcone
35e6684163 Mark this as a string so it is rendered in the docs 
When this was treated as a boolean, sphinx was leaving the Default
column on http://docs.ansible.com/ansible/ec2_module.html blank,
implying it would use AWS's default.  In reality, it passes False, which
overrides the defaults at AWS (it's possible to boot an instance which
AWS claims will always have EBS optimization without it because of this
silently passed False).
 2016-12-08 11:23:46 -05:00
whiter
c0d135e44c Allow iam_policy to maintain idempotentce if the role referenced has been removed 2016-12-08 11:23:46 -05:00
Adrian Bridgett
6bc4c877fc remove unneeded aliases 2016-12-08 11:23:46 -05:00
Adrian Bridgett
f90bcfee1f add idle_timeout support 2016-12-08 11:23:46 -05:00
Kai Webber
4a8bd74f52 Added launch group support for ec2 module 2016-12-08 11:23:46 -05:00
Michael Fenn
89eec3e4cf Support cloning VMs into a specific VM folder 
The pysphere VIVirtualMachine.clone() method supports specifying a VM
folder to place the VM in after the clone has completed.  This exposes
that functionality to playbooks.

Also documents that creating VMs could always place VMs in a specific
folder.
 2016-12-08 11:23:46 -05:00
Mike
922cf9d96b update_disks(): added origins of the code. 2016-12-08 11:23:46 -05:00
Mike Christofilopoulos
0e1ff271c9 add new disks automatically when the 'vm_disk' section changes 2016-12-08 11:23:46 -05:00
Philippe Jandot
5b7d72e4ef fix regression introduced by f38186ce8b, and propose a fix for docker facts 2016-12-08 11:23:46 -05:00
Felix Engelmann
abca0327b9 re-implements #226 
in optional (editable) way
with backward compatibility
 2016-12-08 11:23:46 -05:00
Toshio Kuratomi
66a4cb5c13 Make cache_parameter_group the name of this new param to match with similar params (leave old name as an alias) 2016-12-08 11:23:46 -05:00
Toshio Kuratomi
a692b2e4af Revert "Expose cache_parameter_group_name in elasticache module" 
This PR #1950 implements duplicate functionality to #1353
This reverts commit b04efa22c4.

Conflicts:
	cloud/amazon/elasticache.py
 2016-12-08 11:23:46 -05:00
Brian Coca
4d74c1d508 added missing version added 2016-12-08 11:23:46 -05:00
Toshio Kuratomi
7ae4bdadfc Fixes for bcoca's review of #1916 2016-12-08 11:23:46 -05:00
wtanaka.com
c31a6fd23f Update target parameter documentation 
xz support was only added recently (2015-05-15), so referring to it
unqualified in the online documentation is confusing.
 2016-12-08 11:23:46 -05:00
Greg DeKoenigsberg
248ea2deea Remove @ralph-tice from maintainership per his request 2016-12-08 11:23:45 -05:00
Greg DeKoenigsberg
1c0b231e29 Clarity of owner, even though module is deprecated 2016-12-08 11:23:45 -05:00
Greg DeKoenigsberg
f08d60388c @bradobro stepping down as maintainer 2016-12-08 11:23:47 -05:00
Greg DeKoenigsberg
742b452dc1 @lorin stepping down as maintainer 2016-12-08 11:23:45 -05:00
Gilad Peleg
9cb4388f9e Add state=running on some ec2 examples 
`state=running` was missing in some of the ec2 module examples
 2016-12-08 11:23:45 -05:00
Sarah Haskins
3ad19e75cc Expose cache_parameter_group_name in elasticache module 
The cache_parameter_group_name was not previously exposed in
elasticachy.py, I have exposed it, as optional.
 2016-12-08 11:23:45 -05:00
Bill Nottingham
8fdf18cfa1 win_msi: document extra_args 
The extra_args parameter was not documented. It's needed for installing some MSIs.
 2016-12-08 11:23:45 -05:00
Harlan Lieberman-Berg
a32e5932e9 Give include_recommends a useless default to make the parser happy. 2016-12-08 11:23:45 -05:00
Harlan Lieberman-Berg
f9c435ebd5 Add missing brace. 2016-12-08 11:23:45 -05:00
Harlan Lieberman-Berg
1ff12b66fb Change install_recommended in apt to a trinary. 
Conditions are now "yes", "no", and "default", with the latter falling
back to the OS default.
 2016-12-08 11:23:45 -05:00
Harlan Lieberman-Berg
8ef4715cf6 Change behavior of apt.py around installing recommended packages. 
Closes #1189.

This will cause the settings in Ansible to override the system settings.
That will have no effect except on systems that have an out-of-Ansible
configuration that disables automatic installation of recommended
packages.  Previously, ansible would use the OS default whenever
install_recommends wasn't part of the playbook.  This change will cause
the Ansible default configuration setting of installing recommended
packages to override the configuration files set on the OS for things
installed through ansible, even when there is no install_recommends
specified in the playbook.  Because the OS default matches the Ansible
default, this shouldn't have wide impact.
 2016-12-08 11:23:45 -05:00
Toshio Kuratomi
2619ec5321 Fix issues version_added and chaged => changed typo 2016-12-08 11:23:45 -05:00
sysadmin75
12c2c2b436 Adds tmp_dest option to get_url module. Addresses the issue in ansible/ansible#9512 2016-12-08 11:23:45 -05:00
Michael Schuett
e61a4f2fb5 Fix message 
Previous fix did not actual work. This fix does however.
 2016-12-08 11:23:45 -05:00
Michael Schuett
0cefc2358b Handle connection error 
Try and help when mac hits a connection error.
 2016-12-08 11:23:45 -05:00
Michael Schuett
536bfb521a remove .geturl() 
Can't call geturl on a string.
 2016-12-08 11:23:45 -05:00
Michael Schuett
6ff693f975 Remove faulty logic 
Update logic after splitting the error into two separate messages.
 2016-12-08 11:23:45 -05:00
Michael Schuett
5a20bb473b Documentation Fix 
Updated documentation to match current module state.
 2016-12-08 11:23:44 -05:00
Michael Schuett
8d1f8dacba Improve Message 
Give user a course of action in the case where the suggestions do not
work. This will hopefully allow us to work through any further issues
much faster.
 2016-12-08 11:23:44 -05:00
Michael Schuett
53294dbaaa Improve Error Reporting 
This will hopefully help mac users be able to quickly resolve any issues
they may find when trying to use this module.
 2016-12-08 11:23:44 -05:00
Michael Schuett
75a61ae6e1 docker_image TLS 
Check commit enables using tls when using the docker_image module. It
also removes the default for docker_url which doesn't allow us to check
for DOCKER_HOST which is a more sane default. This allows you to use
docker_image on OSX but more documentation is needed.
 2016-12-08 11:23:44 -05:00
Brian Coca
c8a7c25468 code cleanup and reoorg, renamed vars and functions to actual purpose reneabled logging of steps 2016-12-08 11:23:44 -05:00
Brian Coca
3906fd426b document mysql collation can only be set during creation 2016-12-08 11:23:44 -05:00
Toshio Kuratomi
fda9eeaa89 Use select in wait_for so that we don't get stuck in cornercases: 
* reading from a socket that gave some data we weren't looking for and
  then closed.
* read from a socket that stays open and never sends data.
* reading from a socket that sends data but not the data we're looking
  for.

Fixes #2051
 2016-12-08 11:23:44 -05:00
Toshio Kuratomi
f6353a548c Document and return an error if httplib2 >= 0.7 is not present. We 
can't use httplib2 0.6.x and below because they do not verify TLS
certificates and thus are insecure.

Fixes #1875
 2016-12-08 11:23:44 -05:00
Brian Coca
f7f8df1773 since find doesn't make changes, support check mode and gather data for other tasks in check mode 2016-12-08 11:23:44 -05:00
Toshio Kuratomi
5425f3e757 Correct typo in yum module docs 2016-12-08 11:23:44 -05:00
Jonathan Mainguy
833676960d Update doc to reflect password is required if adding a new user 2016-12-08 11:23:44 -05:00
Jonathan Mainguy
346c9ab80e Update error message to be more explicit 2016-12-08 11:23:44 -05:00
Toshio Kuratomi
a179d06a91 Simplify logic to handle options set to empty string 
Fixes #2125
 2016-12-08 11:23:44 -05:00
Patrick Galbraith
223c689ec0 Fix to issue 12912. Supply 'force' to install of python-apt. 2016-12-08 11:23:44 -05:00
Toshio Kuratomi
5f87f9deda Note the difference between yum package groups and environment groups. 
Fixes https://github.com/ansible/ansible/issues/12873
 2016-12-08 11:23:44 -05:00
Brian Coca
d2cffb31c3 rearranged systemd check, removed redundant systemctl check fixed unused cmd and state var assignements 2016-12-08 11:23:44 -05:00
Simon Hafner
923e442409 added earlier paths to systemd 
2b583ce657
b925e72633
 2016-12-08 11:23:43 -05:00
Lars Kellogg-Stedman
51fae74e7c make os_router return a top level 'id' key 
make os_router return a top-level 'id' key, much like other
os_* resources.
 2016-12-08 11:23:43 -05:00
James Cammarata
4faff0a56a Version bump for new beta 2.0.0-0.4.beta2 2016-12-08 11:23:43 -05:00
Lars Kellogg-Stedman
45cc987fe0 allow os_port to accept a list of security groups 
with this commit, the `security_groups` attribute for `os_port` will
accept either a common-delimited string or ` YAML list.  That is, either
this:

    - os_port:
        [...]
        security_groups: group1,group2

Or this:

    - os_port:
        [...]
        security_groups:
          - group1
          - group2
 2016-12-08 11:23:43 -05:00
Lars Kellogg-Stedman
c96dd16d5a allow os_server to accept a list of security groups 
This commit allows the `security_groups` parameter of the `os_server`
module to be either a YAML list or a common-delimited string (much like
the `nics` attribute).  E.g., this:

    - os_nova_server:
        [...]
        security_groups:
          - default
          - webserver

Or this:

    - os_nova_server:
        [...]
        security_groups: default,webserver
 2016-12-08 11:23:43 -05:00
Simon Hafner
4af48e139c simpler way to check if systemd is the init system 
According to
http://www.freedesktop.org/software/systemd/man/sd_booted.html
check if the directory /run/systemd/system/ exists.
 2016-12-08 11:23:43 -05:00
Lars Kellogg-Stedman
45012ea723 allow empty description attribute for os_security_group 
The `os_security_group` module would fail if there was no `description:`
attribute:

    localhost | FAILED! => {
        "changed": false,
        "failed": true,
	"msg": "Error creating security group larstest: Invalid input for
	description. Reason: 'None' is not a valid string."
    }

This commit makes the default description `''` rather than `None`.
 2016-12-08 11:23:43 -05:00
Lars Kellogg-Stedman
ff090a1224 make os_keypair return a top level 'id' key 
make os_keypair return a top-level 'id' key, much like other os_*
resources.
 2016-12-08 11:23:43 -05:00
Lars Kellogg-Stedman
bdd73fdfd0 make os_flavor return a top-level 'id' key 
make os_flavor return a top-level 'id' key, much like other os_*
resources.
 2016-12-08 11:23:43 -05:00
Lars Kellogg-Stedman
c1e081fcf6 make os_network correctly report changed status 
The `os_network` module was incorrectly returning changed=False whether
or not the network was created.  This commit makes the changed return
value useful.
 2016-12-08 11:23:43 -05:00
Lars Kellogg-Stedman
70bd95b4f0 return information about created subnet 
make os_subnet behave like os_network in terms of returning information
about the created resource.  With this commit, os_subnet will return the
created subnet in `subnet` and the subnet id in `id`.
 2016-12-08 11:23:43 -05:00
Brian Coca
14455f4acc final form, use_regex now controls if patterns is glob or regex - fixed cases in which stat fails (dangling symlink) - now properly reports name of skipped paths 2016-12-08 11:23:43 -05:00
Brian Coca
3e5dc1fd74 changed so regexes and shell globs work transparently 2016-12-08 11:23:43 -05:00
Evan Carter
956fe4c709 add documentation stating that JSON files can be loaded with include_vars 2016-12-08 11:23:43 -05:00
Ryan Sydnor
8a1c035fac Add capability for stat module to use more hash algorithms 
Specifically, the stat module now has a checksum_algorithm parameter.
This lets the module utilize one of the hash algorithms available on the host
to return the checksum of the file.

This change is backwards compatible. The checksum_algorithm defaults to
sha1 and still returns its result to the stat.checksum property.
 2016-12-08 11:23:43 -05:00
David Shrewsbury
f086279a23 Fix for routers without external interfaces 2016-12-08 11:23:43 -05:00
Monty Taylor
c2b695390b Actually pass in is_public to create_image 
Fixes #2325
 2016-12-08 11:23:43 -05:00
Brian Coca
e0d4d397ff fixed mispelled description 2016-12-08 11:23:42 -05:00
Etherdaemon
63c8c40a37 Update try statement as pointed out by defionscode 2016-12-08 11:23:42 -05:00
Brian Coca
505467d2ff clarified ping module purpose 2016-12-08 11:23:42 -05:00
Toshio Kuratomi
a5d95b4047 Another fix for docs 2016-12-08 11:23:42 -05:00
Toshio Kuratomi
ac58ef1404 Correct docs build 2016-12-08 11:23:42 -05:00
Brian Coca
7c0dc323a2 corrected docs for stat's lnk_source fixes #12850 2016-12-08 11:23:42 -05:00
Toshio Kuratomi
80b3bbd55e Mark a few parameters as no_log 2016-12-08 11:23:42 -05:00
David Shrewsbury
024b8365c2 Clarify password requirement and add return docs. 2016-12-08 11:23:42 -05:00
David Shrewsbury
c66491c076 Add OpenStack Keystone User module 
This is a replacement for PR #1598 and fixes #283
 2016-12-08 11:23:42 -05:00
Constantin Bugneac
55afa7e944 Added documentation for returned structure 2016-12-08 11:23:42 -05:00
Etherdaemon
9fe689eaec fixes #12831 by updating the boto iam connection method to connect_to_region 2016-12-08 11:23:42 -05:00
Constantin Bugneac
aa887ce49f Included 'block_device_mapping' in the output of module and other missing attributes 2016-12-08 11:23:42 -05:00
Brian Coca
baeb6d8dc0 fixed bug in spec 2016-12-08 11:23:42 -05:00
Brian Coca
a964754484 added regex support to find, also added 'singular' aliasess to patterns and paths 2016-12-08 11:23:42 -05:00
Brian Coca
9f503540f1 added missing version_added to new accesslogs feature 2016-12-08 11:23:42 -05:00
David Shrewsbury
92e6e2f7ea Fix os_router to accept internal interfaces 
Allow the 'interfaces' attribute to represent internal router
interfaces, composed of subnet names, and the 'external_fixed_ips'
attribute to represent external interface subnet/IP.
 2016-12-08 11:23:41 -05:00
Toshio Kuratomi
d5f3ac2a1d Remove debugging 2016-12-08 11:23:41 -05:00
Toshio Kuratomi
931fa9b6b2 xmlcharrefreplace is only for encoding, not for decoding :-( 2016-12-08 11:23:41 -05:00
Brian Coca
721f587e43 made output match multiline, as per posted code from @n0trax fixes #2081 2016-12-08 11:23:41 -05:00
Brian Coca
0540769677 specified that uri must be uppercase 2016-12-08 11:23:41 -05:00
Lars Kellogg-Stedman
fc741057b2 add some unit tests for the os_server module 
This commit adds some unit tests for the `cloud.openstack.os_server`
module.  These tests exercise `_network_args` thoroughly and
`_create_server` lightly.

These tests will **fail** until #2275 lands.

To run the tests:

    pip install -r test-requirements.txt
    PYTHONPATH=$PWD py.test
 2016-12-08 11:23:41 -05:00
Lars Kellogg-Stedman
413a9d0c62 fix handling of nics argument 
The existing code was receiving a list of strings and erroneously
assuming it was being given a list of dictionaries, leading it to fail
with:

    AttributeError: 'str' object has no attribute 'get'

This commit corrects the list handling code to check the type of each
item and handle it appropriately.   Also, based on bcoca's comment
in #2253, thie code removes the special case for a string-only argument.

By transforming string arguments into dicts and then handling them like
any other dict argument, this also permits arguments of the form:

    nics: net-name=mynet

Or:

    nics: port-name=mynet

Previous versions of this code only supported `net-id` and `port-id` in
string specifications.
 2016-12-08 11:23:41 -05:00
Monty Taylor
db59af564e Make the auto ip parameter auto_ip 
There was a parameter in the docs called 'public_ip' that didn't
actually exist. Additionally, auto_floating_ip is not consistent with
the underlying parameter which is auto_ip - for no good reason.

Add auto_ip as the real parameter, and then make public_ip and
auto_floating_ip as aliases for it for backwards compatability.

Fixes #2301
 2016-12-08 11:23:41 -05:00
Brian Coca
28749a794a added note on when reboot command became available fixes #2050 2016-12-08 11:23:41 -05:00
Brian Coca
5ecbd6c63a fixed results docs 2016-12-08 11:23:41 -05:00
Toshio Kuratomi
9c5ce44477 Some docs fixes 2016-12-08 11:23:41 -05:00
Brian Coca
d6f474761d documented new remote_src option 2016-12-08 11:23:41 -05:00
Gilad Peleg
295a28e128 Docs: remove redundant quotes in ec2_elb docs 2016-12-08 11:23:41 -05:00
Gilad Peleg
c340587bb8 Docs: add state choices to ec2_elb_lb 
add state options (`present` and `absent`) to `ec2_elb-lb` doc
 2016-12-08 11:23:41 -05:00
Val Komarov
0b294d69c5 Remove duplicate logic 2016-12-08 11:23:41 -05:00
dagnello
11f66c0742 Adding string support to metadata argument 
This patch adds support to setting metadata key/value through a string
argument.  Variables can now be used for both the metadata key and
value.

example:
meta: "{{ var1 }}:SomeValue,key:{{ var2 }}"
 2016-12-08 11:23:41 -05:00
Tim Barnes
d98683e1c5 fixing issue with subversion module whereby the module was reporting local modifications being present when externals were being used 2016-12-08 11:23:41 -05:00
whiter
9ee13c4e55 Add region to doc and handle missing region parameter 2016-12-08 11:23:40 -05:00
Rob
11c0be06fb Update ec2_vol.py 
Changed=true now reported on new volume.
Only detach volume when instance is specified as 'None' or '' rather than whenever instance is not specified at all
Fix regression caused by 6b27cdc where by no volume is created if id or Name is not supplied
Remove unnecessary empty aliases
Corrected example to use acceptable parameter for ions
Added exception handling to get_all_instances call
Moved the attachment state validation code to attach_volume function rather than create_volume function
Refactored attach_volume and detach_volume so that changed state can be passed back to call
Created get_volume_info function so that state=present and state=list can return the same data.  Also added instance_id as a returned value in attachment_set dict
Updated aws connection method so that boto profile can be used
 2016-12-08 11:23:40 -05:00
Adam Williamson
83d941da27 fix #2043: strip empty dict from end of 'pull' stream 
When pulling an image using Docker 1.8, it seems the output
JSON stream has an empty dict at the very end. This causes
ansible to fail when pulling an image, as it's expecting a
status message in that dict which it uses to determine whether
it had to download the image or not. As a bit of an ugly hack
for that which remains backward compatible, try the last item
in the stream, and if it's an empty dict, take the last-but-one
item instead.

The strip() is needed as the exact value appears to be '{}/r/n';
we could just match that, but it seems like the kind of thing
where maybe it'd happen to just be '{}/n' or '{}' or something
in some cases, so let's just use strip() in case.
 2016-12-08 11:23:40 -05:00
Sam Yaple
a4a4b6f423 Catch the second occurance of ExposedPorts as well 2016-12-08 11:23:40 -05:00
Sam Yaple
463fb5a058 Don't assume ExposedPorts exists (bug #2257) 
A recent change [1] in docker between v1.8.2 and v1.8.3 changed what
is returned in the json when inspecting an image. Five variables which
could have been expected before will now be omited when empty. Only
one of those variables is being addressed in the docker, ExposedPorts.

Unfortunately there was also no API version change on this so this
can't be easily corrected with pinning the API to the older version.

This does a get() which will return None if the variable is not in the
dict formed from the json that was returned. Everything else works the
same way.

[1] 9098628b29
 2016-12-08 11:23:40 -05:00
jhawkesworth@users.noreply.github.com
183430628b Fix for ansible modules core 2147 2016-12-08 11:23:40 -05:00
Michael Perzel
1fc2c8c324 Added date, year and month attributes 2016-12-08 11:23:40 -05:00
Michael Perzel
7ee0fa3b4b Add ansible_date_time to windows facts 2016-12-08 11:23:40 -05:00
Constantin Bugneac
7dd5ec5373 Added deleteOnTermination in the output of list option 2016-12-08 11:23:40 -05:00
Abhijit Menon-Sen
e9071c62ba Add missing variable initializations 
Without this, «ec2: state=stopped instance_ids=…» would fail with a
traceback like this:

    if inst.get_attribute('sourceDestCheck')['sourceDestCheck'] != source_dest_check:
NameError: global name 'source_dest_check' is not defined
 2016-12-08 11:23:40 -05:00
Brian Coca
a1484a0e5b doc fixes 2016-12-08 11:23:40 -05:00
Frank van Tol
5872e0a493 Update ec2_asg.py 2016-12-08 11:23:40 -05:00
Toshio Kuratomi
2c378cc78a Fix for state=latest with wildcard or virtual provide package names 2016-12-08 11:23:40 -05:00
Achilleas Pipinellis
961082620c Add missing documentation: cron_file requires user to be set 2016-12-08 11:23:40 -05:00
Rob
ed3d248234 Move import statements for easier debugging (correct line numbers) 2016-12-08 11:23:40 -05:00
Brian Coca
205d607320 added version added to new rax_cdb choices 2016-12-08 11:23:40 -05:00
Brian Coca
2d7b1bd1c4 added comment explaining chdir defaults 2016-12-08 11:23:39 -05:00
Brian Coca
d34f89a6fe default chdir to tmpdir to avoid virtualenv issues 2016-12-08 11:23:39 -05:00
Brian Coca
68e7945767 make chdir a path so it resolves shell aliases also removed this_dir logic as it is not needed, chdir is None by default and run_command can handle that. 2016-12-08 11:23:39 -05:00
Rob
61af70c087 Set default of dimensions parameter to be empty dict 2016-12-08 11:23:39 -05:00
Andrew Widdersheim
7d174daa77 Fix detached head detection in is_not_a_branch() 
Detached head detection seems to have broken somewhere a long the way
because git decided to change how that situation looks when doing a 'git
branch -a' which is performed by get_branches().

This is how git 1.7.1 displays this situation (which works):

shell> git branch -a
* (no branch)
  master

This is the output from git 1.8.3.1 (which does not work):

shell> git branch -a
* (detached from e132711)
  master

It looks like this same wording is used in the most recent version of
git (2.6.1 as of writing this).
 2016-12-08 11:23:39 -05:00
gekmihesg
d003fcd662 Support sysctl on OpenBSD 
Fixes #1233
 2016-12-08 11:23:39 -05:00
fperks
11dbd985b6 Fix error on ec2 status change 
Both `source_dest_check` and `termination_protection` variables are not
available within the scope of the startstopec2 instance method. This just
pulls them from module.params.
 2016-12-08 11:23:39 -05:00
James Cammarata
3e6f39dd2b Adding version file for core modules on devel branch 2016-12-08 11:23:39 -05:00
Adrian Lopez
624e95d718 Fix yaml syntax 2016-12-08 11:23:39 -05:00
fxfitz
61cdc2ae90 Fixed spelling mistake: missing 2016-12-08 11:23:39 -05:00
Brian Coca
5b1a508d6a restored quotes to checksum description to avoid breaking docs 2016-12-08 11:23:39 -05:00
Gerard Lynch
27f93bef40 minor doc fix 2016-12-08 11:23:39 -05:00
muszynski@so1.net
2e3ad2b80a description for the get_url module describing checksum verification before file download 2016-12-08 11:23:39 -05:00
Colin Hutchinson
d70c33f932 make a text link into a actual hyperlink 
the text link doesn't fit on some screen resolutions. Making it into sphinx hyperlink will solve that
 2016-12-08 11:23:39 -05:00
Matias De Carli
f2bc0a6d85 keep backwards compatibility 2016-12-08 11:23:39 -05:00
Simon Li
607b7c14bd Fix incorrect variable in group.py: user -> group 2016-12-08 11:23:39 -05:00
Toshio Kuratomi
99659c8667 Fix docs build 2016-12-08 11:23:38 -05:00
David Shrewsbury
bf9c3e0092 Add author to os_router 2016-12-08 11:23:38 -05:00
David Shrewsbury
78ea0df607 Deprecate older router modules. 
The quantum_router_gateway.py and quantum_router_interface.py modules
are deprecated with this change.
 2016-12-08 11:23:38 -05:00
James Cammarata
395253c581 A few bug fixes and tweaks for the accelerate module 2016-12-08 11:23:38 -05:00
Brian Coca
45907f2ff3 removed typo 2016-12-08 11:23:38 -05:00
Brian Coca
d55ba3ab7c removed syslog in favor of common module logging functions 2016-12-08 11:23:38 -05:00
Brian Coca
682cb99d45 revert must_exist 2016-12-08 11:23:38 -05:00
Shayne Clausson
92f88a4cb4 Replaces 'old' get_ec2_creds connection method with get_aws_connection_info to support passing in security_token for temporary creds. 2016-12-08 11:23:38 -05:00
David Shrewsbury
f91cc1d3e5 Allow setting external attribute 
With shade > 0.13.0, networks can be created that are externally
accessible. This adds a parameter for that.

Also, add RETURN documentation and 'if __name__' check around call
to main().
 2016-12-08 11:23:38 -05:00
David Shrewsbury
14546fe33c Allow complete router configuration 
This change allows one to completely configure a router, including
gateway and interfaces, using the latest shade (>0.13.0).
 2016-12-08 11:23:38 -05:00
justnom
b724bf8f1c Adding additional Docker log drivers. 
Adding additional `log_driver` choices:
* journald
* gelf
* fluentd

Compatible with Docker version >= 1.8.0
 2016-12-08 11:23:38 -05:00
Alex Kessinger
4d227e508d Fix a argument mismatch in elasticache 
I think in this commit 720aeffca2

There was bug introduced where the ElastiCacheManager init method has
a number of positional arguments like so.

```py
    def __init__(self, module, name, engine, cache_engine_version, node_type,
                 num_nodes, cache_port, parameter_group, cache_subnet_group,
                 cache_security_groups, security_group_ids, zone, wait,
                 hard_modify, region, **aws_connect_kwargs):
```

But then later in the code the positional arguments are passed in
like this.

```py
    elasticache_manager = ElastiCacheManager(module, name, engine,
                                             cache_engine_version, node_type,
                                             num_nodes, cache_port,
                                             cache_subnet_group,
                                             cache_security_groups,
                                             security_group_ids, parameter_group, zone, wait,
                                             hard_modify, region, **aws_connect_kwargs)
```

If you count, you can see that cache_subnet_group, is being passed in
where the manager expects to see parameter_group.
 2016-12-08 11:23:38 -05:00
Matt Calhoun
52f9c3468c The variable $uppercase_cert_thumbprint cannot be retrieved because it has not been set. 2016-12-08 11:23:38 -05:00
Matt Calhoun
a9d954b087 The variable $winrm_cert_thumbprint cannot be retrieved because it has not been set. 2016-12-08 11:23:38 -05:00
Matt Calhoun
70f7f144e0 The variable $https_listener cannot be retrieved because it has not been set. 2016-12-08 11:23:38 -05:00
Matt Calhoun
72970ab7a8 The variable $winrm_https_listener_path cannot be retrieved because it has not been set 2016-12-08 11:23:38 -05:00
Jens Carl
00f9dfac34 Change type of parameter 'template' to 'path'. 2016-12-08 11:23:38 -05:00
Gerard Lynch
f85a8ac746 allow use of volume_type in volumes dict 2016-12-08 11:23:37 -05:00
Jens Carl
507111f090 Fix to handle user directory within parameter 'template'. 2016-12-08 11:23:37 -05:00
Toshio Kuratomi
e7a48cfb40 Use is_executable from its new location 2016-12-08 11:23:37 -05:00
Toshio Kuratomi
e7d9d86ec9 No longer check for tmp_path being sent as we don't use it here anyway 2016-12-08 11:23:37 -05:00
Tom Bamford
dbf882a600 Clarify available options for device_mapping parameter of ec2_ami module 2016-12-08 11:23:37 -05:00
varnav
a05df49998 Fixed confusion in the docs 
As 'path' is actually alias for 'dest', this could be confusing.
 2016-12-08 11:23:37 -05:00
Toshio Kuratomi
58573187f8 Change the example of rsync_opts to use a list instead of a string 
Fixes #9889
 2016-12-08 11:23:37 -05:00
Shawn Silva
2962dabeda Fix for modifying the size of an RDS instance. When attempting to modify the size of an RDS instance Ansible succeeds and returns a "changed" status. However, no changes are applied to the RDS instance. Boto is looking for a keyword parameter of "allocated_storage" to update the size, and this parameter wasn't being included. 2016-12-08 11:23:37 -05:00
Selivanov Pavel
63d2575f9f ec2_group.py: added ICMP rule example 2016-12-08 11:23:37 -05:00
Greg DeKoenigsberg
c2cc7f17a3 Change author field for os_redhat_subscription.py 2016-12-08 11:23:37 -05:00
Nathaniel Felsen
ec14a5c728 Adding support for access logs in ELB 2016-12-08 11:23:37 -05:00
dagnello
ec1c18e3d5 Adding new os_subnets_facts module 
There can be instances during an Ansible play where the list of subnets
currently available from OpenStack is required.  This update provides
subnet list functionality as a new os_subnets_facts module.
 2016-12-08 11:23:37 -05:00
Matias De Carli
d32809cadb updated dependencies to work with azure.py 1.0.1 2016-12-08 11:23:37 -05:00
dagnello
d46894cf91 Adding new image facts module 2016-12-08 11:23:37 -05:00
dagnello
d76f6cceed Adding os_port Module to openstack ansible modules 2016-12-08 11:23:36 -05:00
whiter
82c898be5a Remove 'str' type so that json is properly quoted 2016-12-08 11:23:36 -05:00
Chris Church
7eb7efb737 Fix win_lineinfile to pass integration tests when strict mode is enabled. 2016-12-08 11:23:36 -05:00
dagnello
a4148c50e9 Adding os_networks_facts module 
There can be instances during an Ansible play where the list of networks
currently available from OpenStack is required.  This update provides
network list functionality as a new os_networks_facts module.
 2016-12-08 11:23:36 -05:00
Abitha Palaniappan
5047561036 os_server: Adding support to accept 'n' nic args as a string containing list 2016-12-08 11:23:36 -05:00
Mike Boone
dd76088019 Updated link to the FAQ. 2016-12-08 11:23:36 -05:00
evanccnyc@users.noreply.github.com
ff81aa11c0 Fixing ec2_asg termination_policy 
If this isnt set, it wont launch the instances because it needs to default to "Default" despite what boto docs say.
 2016-12-08 11:23:36 -05:00
Chris Church
c56db7920a Revert "Improvements to win_feature" 2016-12-08 11:23:36 -05:00
James Cammarata
4a4674ca24 Fix syntax error in synchronize docstring 2016-12-08 11:23:36 -05:00
David Shrewsbury
b67fb2bd29 More os_router module cleanup and fixes. 
Added a RETURN section, corrected version_added value, removed use of
'result' in exit_json() calls.
 2016-12-08 11:23:36 -05:00
Frank van Tol
db6c6ec5c9 Update s3.py 
We are copying from S3,  the bucket is the source, not the target.
 2016-12-08 11:23:36 -05:00
Rob
08999ecfd1 Update iam_policy.py 
Fixed doc for policy_name - it is a required field
Removed empty aliases
 2016-12-08 11:23:36 -05:00
Chris Church
c35d7304c9 Revert "Rename powershell versions of setup and slurp so they don't shadow the python versions of these modules." 
This reverts commit d4e16b0c73.
 2016-12-08 11:23:36 -05:00
Gerard Lynch
3339749017 order params, add missing tag param. update examples 2016-12-08 11:23:36 -05:00
Toshio Kuratomi
29cfd80220 Fix improper indentation 2016-12-08 11:23:36 -05:00
skylerbunny
dabf94ab1f Explanation of privilege escalation in notes 
An attempt to make clear how privilege escalation works with respect to the src/source host and dest/destination host. One existing note was incorporated into three new ones, iterating each.
 2016-12-08 11:23:36 -05:00
Toshio Kuratomi
8ce7348d52 Rename powershell versions of setup and slurp so they don't shadow the python versions of these modules. 
This change goes along with https://github.com/ansible/ansible/02502c5727753d02819cb32b94dc2035b65d81a7
 2016-12-08 11:23:35 -05:00
Evan Carter
5cd3217fc8 fixing termination policies for ec2_asg 2016-12-08 11:23:35 -05:00
Evan Carter
e9c04cfdfd Fixing bug #2058 and adding some backwards compatibility 2016-12-08 11:23:35 -05:00
Brian Coca
99159b3cdd changed chmod to 2.4 compat 2016-12-08 11:23:35 -05:00
Rob
4f9bb86e58 Add exception handling to iam 2016-12-08 11:23:35 -05:00
wimnat
540061c9fc Remove unnecessary json.loads 2016-12-08 11:23:35 -05:00
Tom Fotherby
135e7c60de Fix #1984 - allow load_balancer_port as a variable 2016-12-08 11:23:35 -05:00
Abitha Palaniappan
d26bff8162 Add support for port-id,port-name to nics in os_server 2016-12-08 11:23:35 -05:00
Sam Mingo
75473c0fd0 Update get_url.py 
Fixed typo with header parameter to get_url in the documentation.
 2016-12-08 11:23:35 -05:00
Victor Costan
8d9768c049 Fix indentation in os_server documentation 2016-12-08 11:23:35 -05:00
Yanchek99
ebbd206e86 Fixed typo for instance_tags documentation 2016-12-08 11:23:35 -05:00
David Dyball
cdff62643b Updated PR based on comments 2016-12-08 11:23:35 -05:00
Taneli Lepp
fb317c72b6 Added option to set multiple ACLs for S3 objects. Also verifies the selected permissions against Boto's canned ACL strings list. 2016-12-08 11:23:35 -05:00
Bret Martin
b1c5b17155 Use general-purpose parameter mutual exclusion code for network_interfaces 2016-12-08 11:23:35 -05:00
Bret Martin
0afa813324 Add alias network_interface and accept a string for a single ENI 2016-12-08 11:23:35 -05:00
Bret Martin
df8b2d45bc Add network_interfaces example 2016-12-08 11:23:35 -05:00
Bret Martin
96d8401fb4 Remove aliases specification from documentation since there are none 2016-12-08 11:23:35 -05:00
Brian Coca
281a92bbdd corrected whitepace 2016-12-08 11:23:34 -05:00
Toshio Kuratomi
b952dff2c1 correct documentation formatting 2016-12-08 11:23:34 -05:00
Victor Costan
2f11d96d49 os_server: nice error when flavor not found 
When we can't find the VM flavor that the user requests, this change replaces the non-descript stack trace with a clear error message.
 2016-12-08 11:23:34 -05:00
Bret Martin
df713192b4 Add network_interfaces parameter to ec2 module to support launch-time ENIs 2016-12-08 11:23:34 -05:00
Toshio Kuratomi
b3262479e9 Fix read-only usage to depend on the docker-py and docker server version 2016-12-08 11:23:34 -05:00
Toshio Kuratomi
13ab511642 We had two separate methods trying to do the same thing but neither one was complete. This merges them so that all of the options get parsed and applied. 2016-12-08 11:23:34 -05:00
Toshio Kuratomi
33f5afa779 Make sure listener ports are ints. 
May fix #1984
 2016-12-08 11:23:34 -05:00
Brian Coca
917b7071d6 partially reverted previous change to deal with systemctl show status not returning errors on missing service Now it looks for not-found key instead of running status which does return error codes when service is present but in diff states. fixes #12216 2016-12-08 11:23:34 -05:00
James Martin
c90bf9df98 Adds sanity check to make sure nics is a list. 2016-12-08 11:23:34 -05:00
Charles Paul
6011381bf0 vm_floppy 2.0 support 2016-12-08 11:23:34 -05:00
Chrrrles Paul
1ae0427d4e Revert "Add 2.0 docs - Revert "add virtual floppy to VMware guest"" 2016-12-08 11:23:34 -05:00
Chrrrles Paul
e8aaed3bbb Revert "add virtual floppy to VMware guest" 2016-12-08 11:23:34 -05:00
Brian Coca
fd23120d42 check systemctl status before show as show will not return antyhing other than rc=0 even when it fails. 2016-12-08 11:23:34 -05:00
Colin Hutchinson
9d77cef5be Remove the sample SHA256 
putting a full sha256 made the width of the table in the generated docs not fit on some screens
 2016-12-08 11:23:34 -05:00
Tony Kinsley
79f98bffcf Adding start and stop actions to os_server_actions 
Also making the os_server module allow a server in the possible new
states from the os_server_actions changes
 2016-12-08 11:23:34 -05:00
Chris Church
9ed0a5a920 * Update core modules to fix strict mode errors. * Also fix creates parameter issue in win_msi as described in https://github.com/ansible/ansible-modules-core/issues/129, slightly different fix from https://github.com/ansible/ansible-modules-core/pull/1482 * Fix setup.ps1 module issue described in https://github.com/ansible/ansible-modules-core/issues/1927 2016-12-08 11:23:34 -05:00
Bruno Galindro da Costa
6f36629d13 Added termination_policies option 2016-12-08 11:23:33 -05:00
Jérémie Astori
6695cc5c21 Fix physical walk on acl module for Linux 
`-h` is for BSD [1] while `-P`/`--physical` is for Linux [2].
This commit fixes that option now that acl module is (temporarily)
only supported for Linux.
I will re-add `-h` when fixing BSD support.

[1]: http://www.freebsd.org/cgi/man.cgi?format=html&query=setfacl(1)
[2]: http://linuxcommand.org/man_pages/setfacl1.html
 2016-12-08 11:23:33 -05:00
Jérémie Astori
186cc7cb17 Make sure entry is not sent when acl state=query 2016-12-08 11:23:33 -05:00
Jérémie Astori
3568f1cd78 Make sure permission-less entries are accepted when state=absent 
Also, remove that try condition as, at that stage, no permissions with
other than 2 or 3 fields are sent to the function.
 2016-12-08 11:23:33 -05:00
Jérémie Astori
a93445c798 Remove support for d[efault]: in entry permissions 
It is not documented in [the Ansible doc page][1] nor
[the BSD setfacl man entry][2] (which means it might not be compatible
with BSD) so removing it does not break the API.

On the other hand, it does not conform with POSIX 1003.1e DRAFT
STANDARD 17 according to the [Linux setfacl man entry][3] so safer to
remove.

Finally, the most important reason: in non POSIX 1003.e mode, only ACL
entries without the permissions field are accepted, so having an
optional field here is very much error-prone.

[1]: http://docs.ansible.com/ansible/acl_module.html
[2]: http://www.freebsd.org/cgi/man.cgi?format=html&query=setfacl(1)
[3]: http://linuxcommand.org/man_pages/setfacl1.html
 2016-12-08 11:23:33 -05:00
Toshio Kuratomi
ffbd1efaa7 Remove non-ascii quote char 2016-12-08 11:23:33 -05:00
Rick Mendes
8048c4482a using single device_id and enabling release on disassociation 2016-12-08 11:23:33 -05:00
Marius Gedminas
b2fc74337a authorized_key: fix example in documentation 
'key=' cannot be pointing to a file name; it needs to be the key itself as a string (or a URL).
 2016-12-08 11:23:33 -05:00
Tim Rupp
223cac3f39 Add hostname support for Kali linux 2.0 
This patch allows the hostname module to detect and set the hostname for a
Kali Linux 2.0 installation. Without this patch, the hostname module raises
the following error

   hostname module cannot be used on platform Linux (Kali)

Kali is based off of Debian.
 2016-12-08 11:23:33 -05:00
Luke
aa9b8b8552 removed hyphens in module name in examples 2016-12-08 11:23:33 -05:00
Timothy Appnel
488749500e Clarified and cleaned up grammar of error messages. 2016-12-08 11:23:33 -05:00
Timothy Appnel
d811a51744 Fixed call to undefined attribute when RDS module timeouts waiting. 2016-12-08 11:23:33 -05:00
Marius Gedminas
f97d00fbad user: don't generate SSH keys in check mode 
Fixes https://github.com/ansible/ansible/issues/11768

Test plan:

- (in a Vagrant VM) created a user 'bob' with no ssh key
- ran the following playbook in check mode:

    ---
    - hosts: trusty
      tasks:
        - user: name=bob state=present generate_ssh_key=yes

- saw that ansible-playbook reported "changes=1"
- saw that /home/bob/.ssh was still absent
- ran the playbook for real
- saw that /home/bob/.ssh was created
- ran the playbook in check mode again
- saw that ansible-playbook reported no changes
- tried a variation with a different username for a user that didn't
  exist: ansible-playbook --check worked correctly (no errors, reported
  "changed")
 2016-12-08 11:23:33 -05:00
Marius Gedminas
270c2e8bbd apt: check for "0 upgraded" to be at the beginning of the line 
Fixes #1678.
 2016-12-08 11:23:33 -05:00
Till Backhaus
e005ef0c36 Delete dead and broken code 2016-12-08 11:23:33 -05:00
Omri Iluz
1c6acc3e8f No need for .keys on volumes list 
Since c3f92cca21 changed "volumes" to be a list instead of a dictionary, we don't need (and cannot) .keys when appending to set.
Reported as bug #1957
 2016-12-08 11:23:33 -05:00
Simon Li
28c44c554c Don't fail in check_mode if user exists 
PR #1651 fixed issue #1515 but the requirement for path to be defined is unecessarily strict. If the user has previously been created a path isn't necessary.
 2016-12-08 11:23:33 -05:00
James Cammarata
b9ca912ffe Fixing region requirement regarding euca clusters 
Fixes ansible/ansible#11023
 2016-12-08 11:23:32 -05:00
nitzmahone
51154a6991 added windows facts ansible_lastboot, ansible_uptime_seconds 
switched OS object to Get-CimInstance since we need a DateTime object for lastbootuptime
 2016-12-08 11:23:32 -05:00
Toshio Kuratomi
1102afed43 Fix for the case where plugins aren't loaded on old RHEL systems 2016-12-08 11:23:32 -05:00
Toshio Kuratomi
77457feda6 Return change results in a dictionary listing the package names. 
Fix a parsing problem when package names contain a dot.
 2016-12-08 11:23:32 -05:00
Brian Richards
c054a058c0 Preventing servers that are deleted and left in the deleted state from being included in the server list 2016-12-08 11:23:32 -05:00
Nithy Renganathan
eb3f28effc Handle the changed value 2016-12-08 11:23:32 -05:00
Jason Cowley
2c511a9470 Add support for S3 canned permissions. resolves #1939 2016-12-08 11:23:32 -05:00
Sam Yaple
f2c1eeb54c Actually remove the section we are replacing 2016-12-08 11:23:32 -05:00
Sam Yaple
52d364b74c Refix bug 1226 after revert 
This patch properly fixes bug 1226 without introducing a breaking
change to idempotency which was introduced in PR #1358

We can properly assign permissions to databases with a '.' in the name
of the database as well as assign priviliges to all databases as
specified with '*'
 2016-12-08 11:23:32 -05:00
Jérémie Astori
1b34f1a7ac Fix wrong expectation regarding entry format in acl module 2016-12-08 11:23:32 -05:00
Jérémie Astori
6c298e20c0 Fix wrong processing of lines returned by setfacl in test mode 2016-12-08 11:23:32 -05:00
Jérémie Astori
08e8f732c5 Fix minor whitespace issues 2016-12-08 11:23:32 -05:00
Brian Coca
9ad712018c deal with more failures when apt module fails to instantiate pkg fixes #1499 2016-12-08 11:23:32 -05:00
Mahesh Sawaiker
4b6471d5e7 support creating role only 2016-12-08 11:23:32 -05:00
Ilya Epifanov
cbbf284a74 fixed memory_limit for docker api version >= 1.19 2016-12-08 11:23:32 -05:00
David M. Lee
4cd2fcf917 ec2_vol: Added missing "needs 2.0" doc 
The ability to find-or-create a volume was added in 2.0. Added note to
the example.
 2016-12-08 11:23:32 -05:00
Evan Carter
c1526ff87b Adding the ability to associate eips with network interfaces 2016-12-08 11:23:31 -05:00
Shobhit Srivastava
316ccb0e65 checking remote_group_id while comparing os_security_group_rule 2016-12-08 11:23:31 -05:00
Sam Yaple
f8bcdffa36 Revert "escapeds changes" 
While this change doesn't break the creation, it does break
idempotency. This change will convert '*.*' to '`*`.*' which is
functionally the same, however when the user_mod() function looks up
the current privileges with privileges_get() it will read '*.*'

Since '*.*' != '`*`.*' it will go through the process of updating the
privleges always resulting in a 'changed' result.

This reverts commit db9ab9b262.
 2016-12-08 11:23:31 -05:00
Brian Lloyd
e6ffb60855 Windows implementation of lineinfile and related documentation 2016-12-08 11:23:31 -05:00
Jason DeTiberus
3619630972 python 2.4 syntax fix 2016-12-08 11:23:31 -05:00
Jason DeTiberus
8bc90c6a62 Add example for changing consumed subscriptions 2016-12-08 11:23:31 -05:00
Adam Ever-Hadani
8fb52e0a8b added support for 'collectstatic clear' in django_manage.py 2016-12-08 11:23:31 -05:00
brannon
8691d56f3c Support creating new VMs by cloning an existing VM. Support setting power state of cloned VMs. 2016-12-08 11:23:31 -05:00
Scot Spinner
0fff871819 one thing missed 2016-12-08 11:23:31 -05:00
Guto Andreollo
81a1579e20 Added the 'hw_interfaces' array, listing the names of all interfaces present on the VM as 'ansible_interfaces' lists the ones seen by the operating system 2016-12-08 11:23:31 -05:00
Andrew Briening
bd531f87bc Show the exception messages 2016-12-08 11:23:31 -05:00
Matthias Frey
2ed50d5e5b assemble: add file validation support. 2016-12-08 11:23:31 -05:00
Nikolay Ivanko
33f1da6452 add virtual floppy to VMware guest 2016-12-08 11:23:31 -05:00
Mehul Ved
832f251e90 renamed variables type to cdb_type and version to cdb_version. 2016-12-08 11:23:31 -05:00
HAMSIK Adam
217764ba3c Rebase start/stop instance pull code 2016-12-08 11:23:31 -05:00
Александр Костырев
ec8a94f748 Fix documentation of authorized_key.py 
man for sshd http://www.openbsd.org/cgi-bin/man.cgi/OpenBSD-current/man8/sshd.8?query=sshd
says there's no "host" option but "from".
 2016-12-08 11:23:31 -05:00
Brian Coca
a1992ad890 updated encoding comment and expanded authors field 2016-12-08 11:23:31 -05:00
Jérémie Astori
288a9d8500 Set version number in recursive option description 2016-12-08 11:23:30 -05:00
Jérémie Astori
17170992c3 Ensure Python 2.4 compatibility and Linux-restricted support 
- Make build_entry compatible with Python 2.4
- Re-add missing warning/comment that was forgotten while refactoring
- Replace `all()` with a good ol' for-loop Python 2.4 compatibility
- Make a condition check more explicit (when `state` is `query`)
- Make sure this module can only be run with on a Linux distribution
- Add a note about Linux-only support in the documentation
- Set the version in which recursive support was added, 2.0
 2016-12-08 11:23:30 -05:00
Brian Coca
c341df2231 updated docs for package 2016-12-08 11:23:30 -05:00
Marius Gedminas
9ab2e9c740 Fix obvious copy-paste error in module docs 2016-12-08 11:23:30 -05:00
Brian Coca
34f8eb0f4c made continue into a pass (there was no loop) 2016-12-08 11:23:30 -05:00
Brian Coca
686026919e avoid shlex exceptions in rc parsing (happens with multiline entries) fixes #1898 2016-12-08 11:23:30 -05:00
Michael J. Schultz
c7eb08b217 Return an iterable instead of None 
By default `.get()` will return `None` on a key that doesn't exist. This
causes a `TypeError` in the `for` loop a few lines down. This change simply
returns an iterable type to avoid the error.
 2016-12-08 11:23:30 -05:00
Evgeny Vereshchagin
fe840225fb Fix service.enable on: Debian 8, Ubuntu 15.04 
Workaround for https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=751638
See https://github.com/systemd/systemd/issues/937
 2016-12-08 11:23:30 -05:00
Austin Hyde
ca512b5def Always end rc.conf entries with a new line 2016-12-08 11:23:30 -05:00
Brian Coca
a8b24699be added gpg2 as fallback fixes #1796 2016-12-08 11:23:30 -05:00
Brian Coca
4856f78031 updated win_file version_added fixes #1893 2016-12-08 11:23:30 -05:00
Toshio Kuratomi
a765411284 Another way that the serialization of the boto results can fail 2016-12-08 11:23:30 -05:00
Toshio Kuratomi
1f9580f257 Quote checksum description to fix docs 2016-12-08 11:23:30 -05:00
Toshio Kuratomi
cae0c2741c Another launchconfig field needs to be explicitly converted for json serialization 
Fixes #1848
 2016-12-08 11:23:30 -05:00
sebi
ce1afd01e0 mem_limit client version check 2016-12-08 11:23:30 -05:00
Toshio Kuratomi
a10b0e6fff Modify the default for synchronize's dest_port again 2016-12-08 11:23:30 -05:00
Toshio Kuratomi
052320b452 Update docs to reflect precedence for synchronize's dest_port param 2016-12-08 11:23:29 -05:00
Toshio Kuratomi
9ba5a438a8 Allow mode as a synchronize parameter (handled in action plugin) 2016-12-08 11:23:29 -05:00
Toshio Kuratomi
98e600961f Set a default value for DEFAULT_DOCKER_API_VERSION so we can create the AnsibleModule without docker-py 2016-12-08 11:23:29 -05:00
Ted Timmons
7027de77b7 fix ugly documentation 
current version dumps a character per line in the docs: http://docs.ansible.com/ansible/cloudformation_module.html
 2016-12-08 11:23:29 -05:00
Chris Church
1b6edab87c Add check mode support for Windows modules that don't modify the remote system. 2016-12-08 11:23:29 -05:00
Mehul Ved
bb6762dffd Added support for instance types. 
Added type and version parameters to be passed to rax_cdb module
so users can create Percona and MariaDB instance types.
 2016-12-08 11:23:29 -05:00
Benjamin Baumer
d38cd4896d version_added for switch Parameter changed to 2.0 Add comment to explain check_rc Parameter in _exec Function Optimize code and clean up is_svn_repo Function 2016-12-08 11:23:29 -05:00
queridiculo
92615669c0 yum: improved check_mode handling and package update flow. 2016-12-08 11:23:29 -05:00
Austin Brown
9ffde6c048 Adding version detection 2016-12-08 11:23:29 -05:00
Benjamin Baumer
04add7409e Fix: Calling svn info to determine if dest is an svn Working Copy, to support updates in Subfolders with Subversion > 1.8 Fix: Ignoring svn:externals on local Modification Check. Add: Added Argument switch to alow skipping the svn switch call. 2016-12-08 11:23:29 -05:00
Kamil Madac
08a2f01a5f Fixed bug, when MX records pointed to ORIGIN(@) caused unintentional change of random A record. 2016-12-08 11:23:29 -05:00
Evan Kaufman
b3495e238c Add disabled option to cron module 2016-12-08 11:23:29 -05:00
Andrew Briening
a886690309 Adds basic authentication & skip certificate validation to win_get_url module 2016-12-08 11:23:29 -05:00
Trond Hindenes
1ee2ddcbf4 updated win_feature.ps1 with improvements 2016-12-08 11:23:29 -05:00
Markus Juenemann
47065c2a43 Removed check whether destination directory is writable from files/unarchive.py. This check will prevent extraction of an archive if the archive does not actually write to the destination directory but only writes to any writable sub-directories of it. The underlying tar command will report errors should it try to write to read-only directories. 2016-12-08 11:23:29 -05:00
Monty Taylor
f71446045f Add OpenStack Group content module 2016-12-08 11:23:29 -05:00
Scot Spinner
bcc57875ed adding parameter group option 2016-12-08 11:23:29 -05:00
Jamie Hannaford
0eef7cadfa Add wait and wait_timeout options for provisioning servers 2016-12-08 11:23:28 -05:00
Jason DeTiberus
c2bc5a20fa bugfixes for redhat_subscription 
- correctly return pool ids for newer versions of subscription-manager
- allow for managing subscriptions after initial registration.
 2016-12-08 11:23:28 -05:00
David Shrewsbury
94ae8bbc9b Update os_router to the latest version 
This version uses the latest shade for a cleaner interface,
support for check mode, and updating an existing router.
 2016-12-08 11:23:28 -05:00
Monty Taylor
5ca11fa255 Add OpenStack Router module 
Also deprecate old quantum_router module
 2016-12-08 11:23:28 -05:00
Vladimir Mihailenco
de8c453ac6 rackspace: pass full path to the isdir. 2016-12-08 11:23:28 -05:00
Sam Thursfield
cad0adc691 Fix permissions issue with 'cron' module 
I have a task like this in a playbook. The ansible_ssh_user is 'root'
for this host.

    - cron:
        hour: 00
        job: /home/backup/backup.sh
        name: baserock.org data backup
        user: backup

Running it gave me the following error:

    TASK: [backup cron job, runs every day at midnight] ***************************
    failed: [baserock-backup1] => {"failed": true}
    msg: crontab: can't open '/tmp/crontabvVjoZe': Permission denied
    crontab: user backup cannot read /tmp/crontabvVjoZe

The temporary file created by the 'cron' module is created with the
Python tempfile.mkstemp() function. This creates a file that is readable
only by 'root' (mode 600). The Busybox `crontab` program then checks if
the file is readable by the 'backup' user, and fails if it isn't. So we
need to make sure the file is world-readable before running `crontab`.
 2016-12-08 11:23:28 -05:00
Rowan Wookey
7d85477acb Fixes #542 error when ec2_asg arguments aren't specified 
If max_size/min_size/desired_capacity are omitted
when updating an autoscaling group use the existing values
 2016-12-08 11:23:28 -05:00
Robb Wagoner
aed7d903ee Include a CFN stack's resources in the result 2016-12-08 11:23:28 -05:00
Jan Inowolski
3d45384aed update git remote url before ls-remote 
related to #8177
 2016-12-08 11:23:28 -05:00
Matt Ferrante
74b4882415 ec2_ami can update an ami's launch_permissions 2016-12-08 11:23:28 -05:00
Hideki Saito
2cb83fb196 The nova_compute module create a list of un-use floating ip by value of fixed_ip. 
Fixes #249
 2016-12-08 11:23:28 -05:00
Jérémie Astori
edf531efd7 Add recursive support for ACL module (fix #5053, fix #5550, fix #7276) 2016-12-08 11:23:28 -05:00
muffl0n
6482d1344a Allow additional hashing algorithms. Directly use hashlib and check if used algorithm is supported. 2016-12-08 11:23:28 -05:00
Robert Jailall
6530e76880 Refactor ec2_snapshot to make it more testable 2016-12-08 11:23:28 -05:00
Hagai Kariti
83aff77c26 made wait default to True in ec2_snapshot 2016-12-08 11:23:28 -05:00
Hagai Kariti
fcd2b354b2 Add to the ec2_snapshot module the ability to create a snapshot only if one hasn't recently been created 
- Added snapshot_max_age parameter
- Updated docs
- Made the default value of wait to be false, as it used to be
 2016-12-08 11:23:28 -05:00
Toshio Kuratomi
49ee99fe73 result is now a dict and so needs different access syntax 
Fixes #1848
 2016-12-08 11:23:27 -05:00
Toshio Kuratomi
b91684b8ad Remove unneeded urllib2 import 2016-12-08 11:23:27 -05:00
Brian Coca
ae18b7633c returned version added 2016-12-08 11:23:27 -05:00
James Cammarata
99075976a8 Fix missing params to download_s3file in s3 2016-12-08 11:23:27 -05:00
James Cammarata
689f13548f Fixing s3 failures when bucket names contain dots 2016-12-08 11:23:27 -05:00
Brian Coca
9241955076 added missing version_Added to extra_hosts fixes #1843 2016-12-08 11:23:27 -05:00
Pierre-Louis Bonicoli
fd88e8af53 fix error occurring with Debian 
Error was: AttributeError: 'SourcesList' object has no attribute 'repos_urls'
 2016-12-08 11:23:27 -05:00
Abhijit Menon-Sen
9b496818cf Simplify distribution test 
If it's Ubuntu, use UbuntuSourcesList; if it's any other apt-friendly
distribution, use SourcesList; otherwise, fail.
 2016-12-08 11:23:27 -05:00
Abhijit Menon-Sen
ca50b5c5e0 Make SourcesList __init__ method also set self.module 
This was originally required to allow other methods in SourcesList to
fail, but subsequent changes rendered that unnecessary, and it's just
a cleanup now, and avoids passing in module separately to save().
 2016-12-08 11:23:27 -05:00
Abhijit Menon-Sen
46c015375d Clarify HAVE_PYTHON_APT/install_python_apt handling in apt_repository 
1. Don't test check_mode in both the caller and in the callee.
2. Don't test HAVE_PYTHON_APT inside an if that tests HAVE_PYTHON_APT
3. Don't be irritatingly vague about why the module fails ("You may be
   seeing this because…").

Note that if «apt-get -y install python-apt» succeeds with rc==0, but
for some reason python_apt is not usable afterwards, this will break
because the imports in install_python_apt aren't wrapped inside a
try/except.

In other words, we assume that install_python_apt either succeeds or
fails with a traceback. This commit doesn't affect that behaviour.
 2016-12-08 11:23:27 -05:00
Abhijit Menon-Sen
7643d3aecf Fix call to _expand_ppa 2016-12-08 11:23:27 -05:00
brannon
824503fc19 Fix windows feature example to actually install IIS 2016-12-08 11:23:27 -05:00
Brian Coca
7d660adb39 changed verbose override variable 2016-12-08 11:23:27 -05:00
Micheal Waltz
5f0d989973 Fix incorrect var name for api_version 2016-12-08 11:23:27 -05:00
Luke Rohde
05974273b3 Use msg kwarg to pass error message in ec2_snapshot 2016-12-08 11:23:27 -05:00
Brian Coca
cd072e3090 added version added to headers in s3 2016-12-08 11:23:26 -05:00
Jaime Gago
b203deee31 Fix example indentation bug 2016-12-08 11:23:26 -05:00
Brian Coca
92dfe33021 defined DEFAULT_DOCKER_API_VERSION to avoid it erroring out before we send the message that docker.py is missing 2016-12-08 11:23:26 -05:00
Toshio Kuratomi
a01a800b65 Fi the local_rsync_path parameter used by the action plugin 2016-12-08 11:23:26 -05:00
Brian Coca
3b94910d4e minor doc fixes to get_url 2016-12-08 11:23:26 -05:00
Toshio Kuratomi
103b150090 Convert object into dict so it will turn into json properly 2016-12-08 11:23:26 -05:00
James Cammarata
05c6732462 Prefer non-zero rc's over text analyis in service status checks 
Fixes ansible/ansible#10441
 2016-12-08 11:23:26 -05:00
Bill Nottingham
d4069a8a8a Warn on use of sudo, etc. in shell/command. 2016-12-08 11:23:26 -05:00
James Cammarata
ba9ba7d0f5 In copy, set the mode before running th validation 
Because some programs that do validation (like visudo) may require
the permissions to be more restricted.

Fixes ansible/ansible#11385
 2016-12-08 11:23:26 -05:00
saito-hideki
19cd35806f Add Solaris support in hostname module 
feature_pull_request: #1804
 2016-12-08 11:23:26 -05:00
Brian Coca
357d542bb3 clarified error messages to actually give back ansible module option instead of internal boto field name 2016-12-08 11:23:26 -05:00
Jesse Keating
a913370687 Handle non-updatable openstack subnet details 
Some things cannot be updated via the API, so check for those and fail
if the user is wanting to update them. Also don't try to update ipv6
stuff, as that doesn't work and will cause a traceback.
 2016-12-08 11:23:26 -05:00
Jens Carl
c0eedc6e87 Fix missing alias "groups". 2016-12-08 11:23:26 -05:00
Brian Coca
56354731ce fixed fragment docs 2016-12-08 11:23:26 -05:00
Brian Coca
e5fe763474 fixed version added 2016-12-08 11:23:26 -05:00
Feanil Patel
e4898a4348 If overwrite is set, download eagerly. 
If the we are going to overwrite the file anyway,
there is no need to do any checksums locally or
grab the remote etag.
 2016-12-08 11:23:26 -05:00
Micheal Waltz
950701ba3e Use a if/else instead to avoid loading possibly invalid values for Memory 2016-12-08 11:23:25 -05:00
Micheal Waltz
af5e402b87 Set the API version when checking differences in containers and use this to determine the location of the Memory value depending on the version used. 
In v1.18 and earlier it was ['Config']['Memory'], but in v1.19 it
changed to ['HostConfig']['Memory'].
 2016-12-08 11:23:25 -05:00
billwanjohi
167e940e78 iam: don't delete passwords by default 2016-12-08 11:23:25 -05:00
Igor Khomyakov
9a599e35c1 fixed 'present' 2016-12-08 11:23:25 -05:00
Micheal Waltz
f36666ae1d Use proper HostConfig element which contians the proper Memory value - fixes #1766 2016-12-08 11:23:25 -05:00
Lars Kellogg-Stedman
3d79d96a1b restore mem_limit 
mem_limit got lost in the #1744; this restores it.  Thanks to @dgromov
for the report.
 2016-12-08 11:23:25 -05:00
Lars Kellogg-Stedman
562341049e docker: fix parsing of docker __version__ string 
If `docker.__version__` contains non-digit characters, such as:

    >>> import docker
    >>> docker.__version__
    '1.4.0-dev'

Then `get_docker_py_versioninfo` will fail with:

    ValueError: invalid literal for int() with base 10: '0-de'

This patch corrects the parsing of the version string so that
`get_docker_py_versioninfo` in this example would return:

    (1, 4, 0, '-dev')
 2016-12-08 11:23:25 -05:00
Mike Putnam
9623cd570c Add missing GPLv3 License header 
Fixes #1643
 2016-12-08 11:23:25 -05:00
Ash Caire
682bf34a43 add headers param to s3 uploads 2016-12-08 11:23:25 -05:00
Dan
5b4e7c797f Added header support 
Added the ability to pass custom http headers to the fetch_url method.
 2016-12-08 11:23:25 -05:00
KIKUCHI Koichiro
dab7305d3b Fix service enabled check failure on FreeBSD 2016-12-08 11:23:25 -05:00
Sébastien Gross
0fd3ece053 Allow '*' as empty password. 
If `password` is defined as `*` `useradd` or `usermod` returns an error:

    msg: usermod: Invalid password: `*'

This works very well on Linux host to not define any password for a
user (mainly useful if your setup is only based on SSH keys for
auth). On OpenBSD this does not work, so we have to ignore the encrypted
password parameter if it defined as `*`.
 2016-12-08 11:23:25 -05:00
Andrey Trubachev
b93633d7c2 Fix python-2.4 compatibility 2016-12-08 11:23:25 -05:00
Andrey Trubachev
c55187ff42 Fix 'wait_for' doesn't work with ipv6only host 2016-12-08 11:23:25 -05:00
khassen
8b60dd349d Use the common/shared MD5 function. 2016-12-08 11:23:25 -05:00
Brian Coca
f15ce1433a added version_added to body_format in uri 2016-12-08 11:23:25 -05:00
fti7
581ce7dd32 mount: Support for Check-Mode 2016-12-08 11:23:24 -05:00
Greg DeKoenigsberg
ffb1cab213 Add new policy guidelines for Core 2016-12-08 11:23:24 -05:00
Johan Haals
6a9a4d905a ensures API compatibility for read_only containers 2016-12-08 11:23:24 -05:00
Guilherme Carlos
aaac05c96c Fix login_user on mysql_user 
`login_username` was provided but `login_user` is the correct option
 2016-12-08 11:23:24 -05:00
Toshio Kuratomi
55271467d4 Remove validate_certs as the url is not user settable so we always want to validate the certificate 2016-12-08 11:23:24 -05:00
Artur Cygan
d71b1444a9 Update route53.py 
Fix typos
 2016-12-08 11:23:24 -05:00
Chris Church
d8f5a34d85 Save user after creating before trying to read/set other properties. Fixes #1241 2016-12-08 11:23:24 -05:00
Johan Haals
c88feaff7e changed version_added for read_only param 
this feature will be released in 2.0
 2016-12-08 11:23:24 -05:00
Baraa Basata
63a619fbae Fix iam_policy example 2016-12-08 11:23:24 -05:00
Will Thames
e5d96dc934 Correct handling of empty role_attr_flags 
role_attr_flags is the empty string by default, not None.
 2016-12-08 11:23:24 -05:00
Yuhui Huang
621b396bd9 Checking pip uninstall output in both stdout and stderr 2016-12-08 11:23:24 -05:00
Johan Haals
6231a9d52f Added support for --read-only Docker containers 
Adds support for mounting the container's root filesystem as read only.
 2016-12-08 11:23:24 -05:00
Constantin
7a7b8b913a Added additional stat output values 
Included in the output as well:
 - file extension
 - file attributes
 - file owner
 - creation, last access and last write timestamps (in UNIX format)
 2016-12-08 11:23:24 -05:00
Jeff Widman
70b3290a3b Move validate command into doc fragment and fix a few typos 2016-12-08 11:23:24 -05:00
Chris AtLee
e7af5d2384 Add support for 'update' parameter to hg module 2016-12-08 11:23:24 -05:00
Jesse Sandberg
807feb3ac4 Validate variable, return only the found variable value instead of tuple 
Docs imply the mysql_variables is used to operate a single variable therefore
- fail before making any db connections if variable is not set
- validate chars for mysql variable name with re.match(^[a-z0-9_]+)
- use "SHOW VARIABLE WHERE Variable_name" instead of LIKE search
- getvariable() returns only the value or None if variable is not found
- the module returns only the found variable value instead of tuple for easier operation eg. as registere variable in tasks
 2016-12-08 11:23:24 -05:00
sysadmin75
9bd58bd224 Fix to revoke privileges for mysql user = '' Issue #9848 2016-12-08 11:23:24 -05:00
Christian Hammerl
426ec96ea5 docker: add support to add/drop capabilities 2016-12-08 11:23:23 -05:00
Brian Coca
9b38e47d70 added rickmendes as maintainer 2016-12-08 11:23:23 -05:00
Brian Coca
1976ed931a minor doc fixes to docker_user 2016-12-08 11:23:23 -05:00
Brian Coca
b62a6f01ab added version_Added for new signal option in docker module 2016-12-08 11:23:23 -05:00
Brian Coca
723a48ca73 added versionadded to new option in pip module 2016-12-08 11:23:23 -05:00
Brian Coca
07fedaa03a corrected v ersion added 2016-12-08 11:23:23 -05:00
ayush
f46daacf67 Updated doc strings so each character isn't considered a line 2016-12-08 11:23:23 -05:00
Toshio Kuratomi
8eba30b488 Deprecated _ec2_ami_search now verifies SSL certificates 2016-12-08 11:23:23 -05:00
Daniel Kerwin
277065a302 Too late for 1.8 2016-12-08 11:23:23 -05:00
Daniel Kerwin
3a68101fa3 Switch to _cap_ver_req and add cpu_set to create_containers 2016-12-08 11:23:23 -05:00
Alan Scherger
861d260b6c fix docs; only delete network if fwname is not provided 2016-12-08 11:23:23 -05:00
HelenaTian
1b614172f5 Update gce.py to correctly handle propagated metadata type from a mother template 
My project is using Ansible to automate cloud build process. Ansible has a core module gce.py for managing GCE instances.
  We've come across a use case that's not yet supported - when executing ansible-playbook, if a child template is included, then metadata which is defined in and propagated from the mother template is treated as string type and not parsed correctly(which instead is dictionary type), and triggers release flow failure.
   We currently put some fix by explicitly casting metadata to string type in our own branch, but would like to contribute the fix to Ansible so that everyone onboarding GCE and using Ansible for release management could benefit from it, or hear owner's opinion on fixing the issue if there's a better fix in owner's mind:)
 2016-12-08 11:23:23 -05:00
Petros Moisiadis
68ef885e71 make migrate command idempotent with django built-in migrations 
Django since version 1.7 has built-in migrations, so no need to have south installed with recent django versions. The 'migrate' command works with built-in migrations without any change, but the output is different than the output produced by south, which breaks idempotence. This commit fixes this.
 2016-12-08 11:23:23 -05:00
nemunaire
f37510ebaa Add optional signal parameter when killing docker container 2016-12-08 11:23:23 -05:00
Isaac Simmons
07ccd3c86b Handle ini file properties that contain interpolation errors in the initial values 2016-12-08 11:23:23 -05:00
Wouter Bolsterlee
3d7e3e3c3d Add a virtualenv_python argument to the pip module 
This allows specifying the Python version to use when creating the
virtualenv. See issue #586.
 2016-12-08 11:23:23 -05:00
Wouter Bolsterlee
5a0157a4f2 A few coding style cleanups 2016-12-08 11:23:22 -05:00
Wouter Bolsterlee
e8a0b8b8ae Fix typo in version_added field. 2016-12-08 11:23:22 -05:00
Daniel Kerwin
5b029bde98 Renamed to cpu_set 2016-12-08 11:23:22 -05:00
Daniel Kerwin
940baa92a6 Add support for cpusets. Requires docker-py >= 0.6.0 2016-12-08 11:23:22 -05:00
Brian Coca
87c8d016dc added version_Added to get_url's force_basic_auth 2016-12-08 11:23:22 -05:00
Patrik Lundin
88881415e9 synchronize: add flag for verifying target host. 
Add the possibility to verify the target host using a "verify_host"
flag. It is disabled by default to not change the module behaviour.
 2016-12-08 11:23:22 -05:00
Brian Coca
7a6c8251dd prevent usless assignment of home 2016-12-08 11:23:22 -05:00
bambou
ac41e7c669 Check if the gid is set 2016-12-08 11:23:22 -05:00
Brian Coca
fedd1bed1f minor doc fixes, version added for latest feature 2016-12-08 11:23:22 -05:00
Herby Gillot
c0676f93f5 rds: add the ability to reboot RDS instances 2016-12-08 11:23:22 -05:00
Eero Niemi
1f560f8dae Fixed parameter validation when creating a volume from a snapshot 2016-12-08 11:23:22 -05:00
whiter
2dc689894c Added 'resource_tags' alias 2016-12-08 11:23:22 -05:00
Brian Coca
a0b0c022b8 corrected version_added 2016-12-08 11:23:22 -05:00
Brian Coca
6980503357 updated to add missing 'use' option 2016-12-08 11:23:22 -05:00
David Shrewsbury
014459e5ef Add new os_nova_flavor module. 
The os_nova_flavor module allows a user with administrative privileges
to create and delete nova flavors.
 2016-12-08 11:23:22 -05:00
Brian Coca
ec6e75f1cc attempt to fix check mode when state='absent' 2016-12-08 11:23:21 -05:00
Mischa ter Smitten
10cae0acb3 The tilde expansion doesn't work with user.home 2016-12-08 11:23:21 -05:00
HAMSIK Adam
e04a4a4114 Use mutually_exclusive in AnsibleModule 2016-12-08 11:23:21 -05:00
otdw
8740b44205 removed required together for resource pools, clusters, and template deployments. fixes inability to deploy from template on vsphere clusters without resource pools. Also, resource pools and cluster should not be required together as they are independant in vsphere 2016-12-08 11:23:21 -05:00
Iiro Uusitalo
d6fc0ac5be uri.py is not using module_utils/urls.py from ansible core 2016-12-08 11:23:21 -05:00
HAMSIK Adam
3d3be5e91f Fix missing , 2016-12-08 11:23:21 -05:00
whiter
a5a9c92fcd Fixed dicts comparison for tags 2016-12-08 11:23:21 -05:00
Brian Coca
e4dd0d98d4 now captures any exceptions when trying to create directories 2016-12-08 11:23:21 -05:00
whiter
54b02ee0da ec2_vpc_net refactor 2016-12-08 11:23:21 -05:00
HAMSIK Adam
b7a13e263f Add version 2016-12-08 11:23:21 -05:00
HAMSIK Adam
05df069176 Add module parameter for security group name. This make ec2_elb_lb module consitent with others 2016-12-08 11:23:21 -05:00
Maksim Losev
482d8da2dc Use HostConfig object when creating container with Docker Remote API > 1.15 
This is mlosev's patch (from #1208), rebased against devel as of
2790af2.  It resolves #1707, which was caused by an API incompatibility
between the docker module and server API version 1.19.
 2016-12-08 11:23:21 -05:00
Lars Kellogg-Stedman
e031efd82c Do not erroneously mask exceptions 
There was a catch-all `except` statement in `create_containers`:

        try:
            containers = do_create(count, params)
        except:
            self.pull_image()
            containers = do_create(count, params)

This would mask a variety of errors that should be exposed, including
API compatability errors (as in #1707) and common Python exceptions (KeyError, ValueError, etc) that could result from errors in the code.

This change makes the `except` statement more specific, and only attempts to pull the image and start a container if the original create attempt failed due to a 404 error from the docker API.
 2016-12-08 11:23:21 -05:00
Lars Kellogg-Stedman
6116e4cdab docker: permit empty or false pid 
The `docker` Python module only accepts `None` or `'host'` as arguments.
This makes it difficult to conditionally set the `pid` attribute using
standard Ansible syntax.

This change converts any value that evaluates as boolean `False` to
`None`, which includes empty strings:

    pid:

As well as an explicit `false`:

    pid: false

This permits the following to work as intended:

    - hosts: localhost
      tasks:
      - name: starting container
        docker:
          docker_api_version: 1.18
          image: larsks/mini-httpd
          name: web
          pid: "{{ container_pid|default('') }}"

If `container_pid` is set to `host` somewhere, this will create a
Docker container with `pid=host`; otherwise, this will create a
container with normal isolated pid namespace.
 2016-12-08 11:23:21 -05:00
Brian Coca
9e54efd3fd fixed version added, reworded description a bit 2016-12-08 11:23:21 -05:00
Brian Coca
16a4ff3462 fixed minor doc issues 2016-12-08 11:23:21 -05:00
Brian Coca
0cab021168 Revert "Revert "ec2_lc - include all launch config properties in the return"" 2016-12-08 11:23:20 -05:00
Brian Coca
af8ded66cc Revert "ec2_lc - include all launch config properties in the return" 2016-12-08 11:23:20 -05:00
Toshio Kuratomi
a655241488 Minor touch ups of vsphere_guest code. 2016-12-08 11:23:20 -05:00
Brian Coca
60d160a2e9 Also document in example that unarchive download was added in 2.0 2016-12-08 11:23:20 -05:00
Mitchell Ludwig
b664603a4d Improved stat documentation 2016-12-08 11:23:20 -05:00
Frank van Tol
39e24e89f4 Remove default port value, it does not work in _requires_destroy_and_create logic 
When creating a Redis cluster, every run it gets destroyed and recreated because the port number of memcached is used as the default.
 2016-12-08 11:23:20 -05:00
Frank van Tol
6655cd89c4 Update elasticache.py 2016-12-08 11:23:20 -05:00
Frank van Tol
426f93a291 Remove default for engine_version 
Redis and memcached have different engine version numbering, there can not be a shared default value.
 2016-12-08 11:23:20 -05:00
Nicholas O'Connor
b95cb3f4e9 Created option snapshot_to_clone. When specified, snapshot_to_clone will create a linked clone copy of the VM. 2016-12-08 11:23:20 -05:00
Apoorva Kulkarni
1f35e578b4 s3 module: Add missing version tag to "encrypt" parameter 2016-12-08 11:23:20 -05:00
Chris Church
31a01305ba Set force=yes as the default, add force parameter to module docs. 2016-12-08 11:23:20 -05:00
James Cammarata
5efeeb156b Correctly default crypt_scheme in htpasswd 2016-12-08 11:23:20 -05:00
Chris Faulkner
18b157fbac Report change status on django_manage collectstatic. 2016-12-08 11:23:20 -05:00
Evan Carter
d3ef622627 Adding default cooldown to AWS ASG 2016-12-08 11:23:20 -05:00
vanga
ddd399fe7a Throw error if encryption is set while passing a snapshot id 2016-12-08 11:23:20 -05:00
Chris Meyers
0dbf41e740 ensure password or ssh cert specified 2016-12-08 11:23:20 -05:00
Tom Paine
e97124d609 Update vsphere_guest.py 2016-12-08 11:23:20 -05:00
acaveroc
dda41fd95a Add version_added and type of parameter 2016-12-08 11:23:19 -05:00
acaveroc
2c6f69c95e Assorted minor bug fixes 
- Modified data type for port definition from string to integer
- Modified login_host default value for compatibilize with port definition according with MySQL Documentation (https://dev.mysql.com/doc/refman/5.0/en/connecting.html)
 2016-12-08 11:23:19 -05:00
acaveroc
1283fdd118 Add port definition support for mysql_vars module 2016-12-08 11:23:19 -05:00
Joel Thompson
f1ab33ad7b Adding ability to filter AWS Route 53 private hosted zones by attached VPC 2016-12-08 11:23:19 -05:00
Hennadiy (Gena) Verkh
098126807d Update uri.py 
Added methods 'TRACE', 'CONNECT' from https://www.rfc-editor.org/rfc/rfc2616.txt, section 5.1.1
Added method 'REFRESH'
 2016-12-08 11:23:19 -05:00
Tal Auslander
8766641871 use ConvertTo-Bool for the force parameter 2016-12-08 11:23:19 -05:00
Tal Auslander
64f19fc4c6 stop reading from url on error 2016-12-08 11:23:19 -05:00
Tal Auslander
9c6d829991 add force parameter to win_get_url 2016-12-08 11:23:19 -05:00
Tal Auslander
26a54897a2 win_get_url re-download file only if modified 2016-12-08 11:23:19 -05:00
Hennadiy (Gena) Verkh
852c232b2d Removed method restriction in uri module 2016-12-08 11:23:19 -05:00
Ian Babrou
9219aeaaeb Pulling missing docker image before doing anything 2016-12-08 11:23:19 -05:00
Nic O'Connor
c68d1ffa60 Added the ability to Linked_clone from snapshot 2016-12-08 11:23:19 -05:00
Simon Olofsson
a3cb6d2f16 Add option docker_user for docker module. 
docker_user can be used to specify the user or UID to use within the
container.
 2016-12-08 11:23:19 -05:00
Iiro Uusitalo
b92dabb9fb Refactor force basic auth, now all modules which use fetch_url() can use force_basic_auth 2016-12-08 11:23:19 -05:00
Toshio Kuratomi
05be82183f Add notes about loop squashing and 1.9.2 change to install packages in one yum transaction 2016-12-08 11:23:19 -05:00
Monty Taylor
8e26a7ae17 Fix a small typo in parameter processing 2016-12-08 11:23:19 -05:00
Brian Coca
f8f4a7dcdf added ignore hidden to assemble 2016-12-08 11:23:18 -05:00
Jesse Keating
16381fb5c0 Plumb ipv6 modes into os_subnet 
Shade already supports these, we just need to plumb them into the module
code.
 2016-12-08 11:23:18 -05:00
Jesse Keating
72809ac329 Fix up docs 2016-12-08 11:23:18 -05:00
Sean Chittenden
4c8b573e2c Fix group mod and group add for FreeBSD 2016-12-08 11:23:18 -05:00
Juho-Mikko Pellinen
29620b78fa Change the default flag value to None to prevent AWS complaining: "Instance creation failed => InvalidBlockDeviceMapping: the encrypted flag cannot be specified since device /dev/sda1 has a snapshot specified." 2016-12-08 11:23:18 -05:00
Monty Taylor
530f12035b Update docstring to show port ranges as optional 2016-12-08 11:23:18 -05:00
David Shrewsbury
789c1fcbe7 Correct port matching logic 
Port matching logic did not take into account recent shade change
to equate (None, None) to (1, 65535) when Nova is the backend.

Also, this encapsulates the port matching logic into a single function
and heavily documents the logic.
 2016-12-08 11:23:18 -05:00
Flyte
2f46364921 Provide correct kwargs to rds2 connection when making a final snapshot 2016-12-08 11:23:18 -05:00
David Shrewsbury
387fe5b0e7 Change required parameters for rules module 
The ports and protocol are no longer required (and now depends on
a new version of shade).
 2016-12-08 11:23:18 -05:00
Davide Guerri
531b93490b Fix reuse argument documentation 2016-12-08 11:23:18 -05:00
Davide Guerri
95cfe3da96 Update os_floating_ip with new shade methods 2016-12-08 11:23:18 -05:00
Monty Taylor
4f2028439f Use int in the parameter list instead of casting 2016-12-08 11:23:18 -05:00
dagnello
2c3fc61357 Resolving issues in rule comparison algorithm 
Port range min/max values are at times represented as string and
compared to int equivalents.  This fix explicitly ensures all
port range values are ints for proper comparisons.
 2016-12-08 11:23:18 -05:00
David Shrewsbury
e7dd93c5c1 Compare ports as strings 
Ports as returned from shade are ints. They are strings as they come
in to the module.
 2016-12-08 11:23:18 -05:00
David Shrewsbury
14212c37e2 Fix syntax error 2016-12-08 11:23:18 -05:00
Monty Taylor
60102e36e2 Return rule object 2016-12-08 11:23:18 -05:00
David Shrewsbury
174254a423 Update secgroup rules module for latest shade 
This allows the rules module to work against either nova or neutron
for handling security groups. New parameters for 'direction' and
'ethertype' are added.

Check mode is supported with this version.
 2016-12-08 11:23:18 -05:00
David Shrewsbury
fcc1d643f6 Recongnize None and -1 port equivalency 
shade 0.7.0 represents disabled min/max ports as None (in the
neutron style) rather than -1. Recognize this as the same as -1.
 2016-12-08 11:23:17 -05:00
David Shrewsbury
b42a9d56e6 Fix id value reference 2016-12-08 11:23:17 -05:00
David Shrewsbury
f02ec15c17 Update rules mode for latest shade 
Shade 0.7.0 normalized the security group data that is returned,
when using nova, to look more like neutron security group data.
This adjusts for that change.
 2016-12-08 11:23:17 -05:00
dagnello
ecef2aadba Minor fixes for os_security_group_rule module 
Was not able to use this module as it was.  The changes submitted
resolved the issues I ran into in order to get it working.
 2016-12-08 11:23:17 -05:00
Davide Guerri
2d7dbc5d0c Fix invalid syntax in openstack_module_kwargs call 2016-12-08 11:23:17 -05:00
Monty Taylor
9acc891477 Fix example code syntax 2016-12-08 11:23:17 -05:00
0tmc
6e4c5e0a12 Use of proper fstab file on FreeBSD 2016-12-08 11:23:17 -05:00
Monty Taylor
a657e80bc8 Add OpenStack Floating IP Module 
Also deprecate the two old quantum floating ip modules.
 2016-12-08 11:23:17 -05:00
Monty Taylor
8d5e43c14f Add OpenStack Security Group Rule module 2016-12-08 11:23:17 -05:00
Juho-Mikko Pellinen
321244d881 Remove empty aliases 2016-12-08 11:23:17 -05:00
Juho-Mikko Pellinen
54af79692a Add version number 2016-12-08 11:23:17 -05:00
Juho-Mikko Pellinen
f016cb556b Fix hosted_zone_id after rebase. 2016-12-08 11:23:17 -05:00
Juho-Mikko Pellinen
3f2d1e6bfa Add support for specifying unique hosted zone identifier 2016-12-08 11:23:17 -05:00
Scott Miller
62b6cf85d3 Update cloudformation.py 
Fix for inaccurate phrasing
 2016-12-08 11:23:17 -05:00
Brian Coca
e7dc05df11 updated upgrade to a more sensible default as the previous was prone to confusion fixes #1667 2016-12-08 11:23:17 -05:00
Robb Wagoner
848e9de950 remove double dict & fix increment bug 2016-12-08 11:23:16 -05:00
Mike Putnam
0e6e3e097e Upstream docs show launch_config_name as required. 
http://docs.aws.amazon.com/AutoScaling/latest/APIReference/API_AutoScalingGroup.html

Fixes #11209

Ansible behavior is correct, this commit just updates the docs to
reflect that correctness.
 2016-12-08 11:23:16 -05:00
verm666
ac40d9f41a fix authorized_keys in check_mode 
This change is in response to issue #1515.
Original pull request #1580.

The original problem is: in authorized_key module you have no idea about users
which will be created by Ansible at first run. I can propose next two ways to
solve this problem:

  1. Combine modules system/user.py and system/authorized_key.py in one module
     (so you will know everything about users in that module)
  2. Use small workaround: add my commit and always provide 'path' parameter
     for authorized_key module during runs with --check option.
 2016-12-08 11:23:16 -05:00
Matthew Gilliard
17a40aa259 Handle race condition in directory creation. 
If we try to make a directory, but someone else creates the directory
at the same time as us, we don't need to raise that error to the user.
They asked for the directory to exist, and now it does. This fixes
the race condition which was causing that error to be raised, and
closes #1648.
 2016-12-08 11:23:16 -05:00
Matt Martz
f33a8b09a9 Remove unnecessary imports in a docs only file for win_copy 2016-12-08 11:23:16 -05:00
Matt Martz
d47de74ade Replaced tabbed indentation with spaces for group module 2016-12-08 11:23:16 -05:00
Matt Martz
30d5c1166c Replaced tabbed indentation with spaces for subversion module 2016-12-08 11:23:16 -05:00
Matt Martz
a0f5ae8726 Replaced tabbed indentation with spaces for apt module 2016-12-08 11:23:16 -05:00
Matt Martz
3d28efaf7e Replace tabbed indentation with spaces for mysql_db module 2016-12-08 11:23:16 -05:00
Toshio Kuratomi
cf595b3c52 Fix indentation levels in os_keypair 2016-12-08 11:23:16 -05:00
Toshio Kuratomi
4c863187ad Few minor things from review of the pull request 2016-12-08 11:23:16 -05:00
verm666
6acfa5fcee unarchive: fix @bcoca's remarks, issue #1575 2016-12-08 11:23:16 -05:00
Toshio Kuratomi
432764b703 Add version that the profilename param was added 2016-12-08 11:23:16 -05:00
Jesse Keating
2b5af82706 Document auto_floating_ip argument 2016-12-08 11:23:16 -05:00
David Shrewsbury
3cd81d2dd3 Use newest documentation style for return value. 2016-12-08 11:23:16 -05:00
Jonathan Davila
f1027ae6bc no_log to iam password 2016-12-08 11:23:16 -05:00
David Shrewsbury
c4bc6dea13 Add a note about the return value. 2016-12-08 11:23:15 -05:00
Scott Miller
b43db1d2ff update docs for cloudformation 2016-12-08 11:23:15 -05:00
James Meickle
8197d7e640 Change uri debug example 2016-12-08 11:23:15 -05:00
Monty Taylor
c0190b0443 Fix dict syntax typo 2016-12-08 11:23:15 -05:00
Andreas Reischuck
3cc14a0a65 fixed win_file state=touch 2016-12-08 11:23:15 -05:00
ToBeReplaced
5e259a8dd9 Make ALL_IN_SCHEMA for tables affect views 
ALL TABLES is considered to include views, so we must check for reltypes
'r' and 'v', not just 'r'. This bug was introduced due to using a
custom, backwards-compatible version of "ALL TABLES IN SCHEMA".
 2016-12-08 11:23:15 -05:00
Robb Wagoner
372a2286db return health of instances and counts 2016-12-08 11:23:15 -05:00
verm666
b898cb656b unarchive: fix work with 0 bytes archives 
This change is in response to issue #1575
 2016-12-08 11:23:15 -05:00
Vladimir Martsul
db646757c1 Add "force" description 
Add "force" option description
 2016-12-08 11:23:15 -05:00
Patrick Roby
e638913c97 iterate through all keys in a more pythonic manner 2016-12-08 11:23:15 -05:00
Patrick Roby
bc5d79fc30 update documentation, adding new params 2016-12-08 11:23:15 -05:00
David Shrewsbury
341efbf7ae Update os_keypair for latest shade 
Uses the latest version of shade for cleaner code. Also, always
return the key dict whether we create the key, or it already exists.
The example using public_key_file is corrected to use a full path
since ~ is not converted for us.
 2016-12-08 11:23:15 -05:00
Evan Carter
98756144cf Add ClassicLink settings to EC2_launchconfig 2016-12-08 11:23:15 -05:00
Andrea Mandolo
ae1080d922 Added some block_device_mapping (disks) informations to EC2 instance module ouput 2016-12-08 11:23:15 -05:00
Andrea Mandolo
a8da674cf4 Added "EC2 instance" termination_protection and source_dest_check changeability at run-time 2016-12-08 11:23:15 -05:00
Tom Paine
df8013182e Parse out space characters in route53 value list 
Fixes: https://github.com/ansible/ansible-modules-core/issues/992
 2016-12-08 11:23:15 -05:00
Michael Weinrich
543cb13f42 Fix connection creation to allow usage of profiles with boto 2016-12-08 11:23:15 -05:00
Toshio Kuratomi
f422782180 Use module.fail_json() instead of sys.exit() 2016-12-08 11:23:14 -05:00
Toshio Kuratomi
53c840e275 Add testing of docs to the core repo 2016-12-08 11:23:14 -05:00
Brian Coca
b261fd8d3e added doc to note that git the command line tool is required for this moduel to function fixes http://github.com/ansible/ansible/issues/11358 2016-12-08 11:23:14 -05:00
Brian Coca
e91818ef77 updated docs to clarify use of exclusive 2016-12-08 11:23:14 -05:00
Roetman, Victor
fa612a14b1 apache2_module documetation update 
requires a2enmod and a2dismod
 2016-12-08 11:23:14 -05:00
Ash Wilson
9f12fd0a26 Default net to 'bridge' in container diff 
This prevents an unnecessary reload when the `net` parameter is unspecified
(i.e. almost always).
 2016-12-08 11:23:14 -05:00
verm666
9b3aa0a9d4 This change is in response to issue #133. 
The original problem is: apt_repository.py connect to launchpad on
every playbook run. In this patch apt_repository.py checks if required
repository already exists or not. If no - paa will be added, if yes -
just skip actions.
 2016-12-08 11:23:14 -05:00
Michael Weinrich
a0466f1f8d Add the option to pass a string as policy 2016-12-08 11:23:14 -05:00
Monty Taylor
869da89b35 Move the order of argument processing 2016-12-08 11:23:14 -05:00
Monty Taylor
377311db56 Add filter ability 2016-12-08 11:23:14 -05:00
Ed Hein
f11c451bfa Fix computation of port bindings. Port bindings configuration can be a list if several host ports are bound to the same guest port. 2016-12-08 11:23:14 -05:00
Davide Guerri
c1d7678cc2 Avoind using lookup() in documentation 
lookup() is currently broken (current Ansible devel branch), so better to avoid
it in our examples.
 2016-12-08 11:23:14 -05:00
Konstantin Gribov
8d91c3a61a Escape spaces, backslashes and ampersands in fstab 
Fixes #530.

It's more generic than #578 which only fixes spaces escaping in name (target dir to mount).
Escaping is used in both `set_mount` (important for `src`, `name` and `opts`) and
`unset_mount` (for `name`).

It's shouldn't be used in `mount` and `umount` since `name` parameter is passed as array element
to `module.run_command`.

Signed-off-by: Konstantin Gribov <grossws@gmail.com>
 2016-12-08 11:23:14 -05:00
Arata Notsu
cc76a479e1 Not use "is" to compare strings 
As "is" tests whether if operands are the same object rather than
they have the same value, potentially causes a wrong result.
 2016-12-08 11:23:14 -05:00
Bryan Fleming
6f8d60a5ed fixes #1120 - privileges using columns 2016-12-08 11:23:13 -05:00
Lucas David Traverso
20aa4c0cea django_manage: Use shebang in manage.py instead of hardcode python 2016-12-08 11:23:13 -05:00
Andrew Davis
4d4d911d6e ansible_facts reflects 1.8 output 2016-12-08 11:23:13 -05:00
Monty Taylor
0c0359798b Add OpenStack Keypair module 
Also deprecate old nova_keypair module.
 2016-12-08 11:23:13 -05:00
Ash Wilson
ea83727fcf Wait for process exit on detached=no. 2016-12-08 11:23:13 -05:00
Ian Clegg
f9c294f1ad Added support for comma seperated feature names in the name parameter of the win_feature module 2016-12-08 11:23:13 -05:00
Tagir Bakirov
8bd367eac7 added 'absent' option to supervisorctl 2016-12-08 11:23:13 -05:00
Stefan Junker
4ee972190b docker: Use a list instead of a dict for volumes according to the docker-py docs. Do not add host-binds to volumes list. 2016-12-08 11:23:13 -05:00
gimoh
fd69c5687b Do not insert extra newline if line already contains it 
When using YAML multi-line strings, e.g.:

- lineinfile:
    dest: /tmp/foo
    line: >
      foo
      bar

the line already ends with a newline.  If an extra newline is appended unconditionally it will lead to inserting an extra newline on each run.
 2016-12-08 11:23:13 -05:00
Jens Carl
9ad15cdae9 - List the name servers of a zone. 2016-12-08 11:23:13 -05:00
Alexis Seigneurin
53e9caa1d0 - 'name' should not be required so as to allow uninstalling a cron_file 2016-12-08 11:23:13 -05:00
Annika Backstrom
6b2c89a422 Force redownload if sha256sum does not match 2016-12-08 11:23:13 -05:00
Igor Khomyakov
03483d2ea5 Check if a service exists 2016-12-08 11:23:13 -05:00
Federico G. Schwindt
b6258a1e4c Document globbing support 2016-12-08 11:23:13 -05:00
sysadmin75
f096359608 ansible-modules-core #530 fix - Mount module does not accept spaces in mount point path 2016-12-08 11:23:13 -05:00
Chris Church
3048626d6e Update docs, add example of using django_manage to run other commands. 2016-12-08 11:23:13 -05:00
Stefan Junker
50fe57fff3 Fix bind-volumes on docker >= 1.4.0 
If bind-volumes are submitted to docker >= 1.4.0 with the volumes set in addition to the binds, docker will create a regular volume and not bind-mount the specified path.
 2016-12-08 11:23:13 -05:00
Federico G. Schwindt
fa463fb1b7 Allow globbing in creates= and removes= directives 
Fixes 1904
 2016-12-08 11:23:12 -05:00
Robb Wagoner
e025effc99 include all launch config properties in the return 
make all properties available when registering the result
which is useful when wanting to launch a stand-alone instance based upon
an existing Launch Config.
 2016-12-08 11:23:12 -05:00
Toshio Kuratomi
870446dd6b Update version_added to 2.0 for the partial option 2016-12-08 11:23:12 -05:00
Jonathan Davila
82b809f0e2 new vpc module. does not contain subnet or route table functionality. 
changed name to ec2_vpc_net

refactored out IGW functionality
 2016-12-08 11:23:12 -05:00
Juan Picca
81ea358b09 synchronize module: add partial option 2016-12-08 11:23:12 -05:00
Toshio Kuratomi
5118d0e3b1 Add note about redirects proxies 
Fixes #1574
 2016-12-08 11:23:12 -05:00
Toshio Kuratomi
0a3150f7d7 Add version_added documentation to log_driver parameter 2016-12-08 11:23:12 -05:00
Toshio Kuratomi
9ecd06fb47 Fix apt_repository so that it does not modify the mode of existing repositories 2016-12-08 11:23:12 -05:00
Michael Weinrich
1f6c177da0 Use aws connect calls that allow boto profile use 2016-12-08 11:23:12 -05:00
Ryan Walls
01a28e7d80 Fix typo in Docker module. 2016-12-08 11:23:12 -05:00
Ryan Walls
9630972c2c Update docker module to avoid false positives when containers are first created. Also have the module check for api compatibility before trying to set a "--log-driver" option. 2016-12-08 11:23:12 -05:00
Ryan Walls
f5c1d8141b Set default "log_driver" option to None in docker module. 2016-12-08 11:23:12 -05:00
Ryan Walls
0df1b01cb2 Update docker module to look at log_driver variable when deciding if container configuration has changed. 2016-12-08 11:23:12 -05:00
Ryan Walls
3419a1e253 Add support for --log-driver option that docker released with Docker 1.6 2016-12-08 11:23:12 -05:00
Alex King
c8ae53b308 Extend hashes that can be specified by crypt_scheme beyond those understood by Apache/Nginx. 2016-12-08 11:23:12 -05:00
Sebastian Gerhards
a979417a4a rhn_register: add support for profilename 2016-12-08 11:23:12 -05:00
Jim Patterson
4185ffc43e Correct check mode for pip in virtualenv. 
Fix #412.  Check mode was always returning changed=True for pip
when the target was in a virtualenv.  The code now uses the normal
tests for determining if change status.
 2016-12-08 11:23:11 -05:00
Lorin Hochstein
abf314c258 django_manage: expand ~ in app_path parameter 
Allow users to specify app_path parameters that contain ~, for example:

app_path=~/myproject
 2016-12-08 11:23:11 -05:00
Pierre-Louis Bonicoli
c366e7acb2 apt_repository: fix file mode 
'set_mode_if_different' method should be called on dest filename and after
'atomic_move' method
 2016-12-08 11:23:11 -05:00
Patrick Roby
b318bc8b43 Add support for listing keys in a specific S3 bucket 
Includes support for specifying a prefix, marker, and/or max_keys. Returns a list of key names (as strings).
 2016-12-08 11:23:11 -05:00
James Cammarata
4239922d07 Updating version_added for new spot_type param in ec2 module 
Also made sure 'choices' were set on the module param, to catch errors
in user's playbooks, etc.
 2016-12-08 11:23:11 -05:00
Toshio Kuratomi
cb776e6190 Fix for when the password file did not exist previously 2016-12-08 11:23:11 -05:00
Jay Taylor
ed279d8175 Added support for spot request type specification (to support persistent spot requests). 2016-12-08 11:23:11 -05:00
Toshio Kuratomi
bd87c11c2a Read the url in in chunks so that we don't use as much memory for large packages 2016-12-08 11:23:11 -05:00
Toshio Kuratomi
2e7dcf3317 Small cleanups. * Import url(lib|parse|lib2) if needed by the module rather than relying on module_utils.urls to do so. * Remove stdlib modules from requirements * Use the if __name__ conditional for invoking main() 2016-12-08 11:23:11 -05:00
Toshio Kuratomi
5f27a073ba Bump amount of file to download in a chunk to 64k. 2016-12-08 11:23:11 -05:00
Jonathan Mainguy
dd0659c83d add download ability to unarchive module 2016-12-08 11:23:11 -05:00
zimbatm
99e2557b42 route53: add support for routing policies 
It is now possible to pass various routing policies if an identity is
provided.

This commit also introduces multiple optimisations:
* Only fetch records for the given domain
* Use UPSERT instead of DELETE+CREATE to update existing records
 2016-12-08 11:23:11 -05:00
billwanjohi
86e679fe3c iam: use modern helper to allow sts 
previous implementation ignored the session token when present
 2016-12-08 11:23:11 -05:00
James Cammarata
5cd3c6ebe6 Update choices and version_added for new gce.py param service_account_permissions 2016-12-08 11:23:11 -05:00
Michal Smereczynski
9d4b252f56 Added new Premium Storage instance sizes and case-related documentation clarification. 2016-12-08 11:23:11 -05:00
murdochr
aae140e6cd Change docs to reflect correct when syntax for matching variable strings as per MD's forum post as this fails with unhelpful error otherwise. 
https://groups.google.com/forum/#!topic/ansible-project/D2hQzZ_jNuM
 2016-12-08 11:23:11 -05:00
Monty Taylor
186fbd7645 Remove duplicate shade requirement 2016-12-08 11:23:10 -05:00
Monty Taylor
73cb529d2c Make sure we're always returning objects too 2016-12-08 11:23:10 -05:00
dagnello
072110c757 Resolving secgroup.id issue in this module 
secgroup['id'] was not being returned in all cases where the
specified security group exists.
 2016-12-08 11:23:10 -05:00
toninog
bea77c938e fixes to code to enable updates of user to groups and delete groups. Fixed example yaml to use groups 2016-12-08 11:23:10 -05:00
toninog
ab7678f199 Fixed more issues with the delete_group and paramater mismatch 2016-12-08 11:23:10 -05:00
Jonathan Mainguy
c9d1cc0ce3 remove blank lines from htpasswd file 
used standard mktemp()
 2016-12-08 11:23:10 -05:00
Vasyl Kaigorodov
758688a667 GCE module: added Service Account permissions sanity checks 2016-12-08 11:23:10 -05:00
Vasyl Kaigorodov
4400c5e163 GCE module: document Service Account permissions parameter usage 2016-12-08 11:23:10 -05:00
Vasyl Kaigorodov
97e880a27f GCE module: add posibility to specify Service Account permissions during instance creation 2016-12-08 11:23:10 -05:00
Jonathan Davila
6482ad964f iam certificate module 
boto import tweak

style patch
 2016-12-08 11:23:10 -05:00
Dan Abel
a51a8e1fd6 use aws connect calls that allow boto profile use 2016-12-08 11:23:10 -05:00
Hagai Kariti
b46a1ff3e1 Hostname module should update ansible_hostname 2016-12-08 11:23:10 -05:00
Vyronas Tsingaras
654d2d3f60 This enable one to find a datastore with no config_target supplied 
Signed-off-by: Vyronas Tsingaras <vtsingaras@it.auth.gr>
 2016-12-08 11:23:10 -05:00
Jon Hawkesworth
a00d86946d document file size limit for win_copy module 2016-12-08 11:23:10 -05:00
Vyronas Tsingaras
56957ca45e Remember power state when starting vm reconfigure 
This commit fixes #1391

Signed-off-by: Vyronas Tsingaras <vtsingaras@it.auth.gr>
 2016-12-08 11:23:10 -05:00
Matt Martz
158772ffc2 Fix some remaining rax asg idempotency checks 2016-12-08 11:23:10 -05:00
Benno Joy
17c185c8d1 enable azure to provision windows instances 2016-12-08 11:23:09 -05:00
Benno Joy
2314670952 enable the module to provision windows instances 2016-12-08 11:23:09 -05:00
Colin Hutchinson
97a2cd0bd9 Indentation fix for with and register in the ec2_vol example 2016-12-08 11:23:09 -05:00
Ritesh Khadgaray
9c3f9d23c8 Add the ability to grep for content 2016-12-08 11:23:09 -05:00
Vyronas Tsingaras
bdb33b5756 Properly check if vm_hardware contains keys 
This commit fixes #1475

Signed-off-by: Vyronas Tsingaras <vtsingaras@it.auth.gr>
 2016-12-08 11:23:09 -05:00
Vyronas Tsingaras
262e86b36b Use either esxi:dc,host OR cluster,resource_pool 
vsphere_guest now can deploy a template using a datacenter and hostname
as the target, instead of requiring a cluster and resource_pool.

This commit fixes #951.

Signed-off-by: Vyronas Tsingaras <vtsingaras@it.auth.gr>
 2016-12-08 11:23:09 -05:00
Robin Roth
abc89f0df5 add comment: ports need to be exposed. 
port mapping with this module only works for ports that are exposed either in the Dockerfile or via an additional arguments. This is different from the command line docker client, that is willing to also map ports that are not exposed.

This comments makes the behaviour more obvious.
 2016-12-08 11:23:09 -05:00
Monty Taylor
8ff71a3fa8 Actually use changed variable 2016-12-08 11:23:09 -05:00
Monty Taylor
4125b576e9 Return the secgroup for all present states 2016-12-08 11:23:09 -05:00
Monty Taylor
b955b2f5c8 Return resource objects from OpenStack modules 
It's not uncommon for people to want to do additional things after
creating a module. Also, add a note about it to the dev notes.
 2016-12-08 11:23:09 -05:00
Monty Taylor
89f95471f8 Return secgroup, not just id 2016-12-08 11:23:09 -05:00
Philip Kirkland
cc214afed6 adding 'encrypted' option into volume dict so ec2 module can easily include encrypted volumes 2016-12-08 11:23:09 -05:00
Toshio Kuratomi
88ae201b20 Fix bugs found by @kustodian 2016-12-08 11:23:09 -05:00
Toshio Kuratomi
f0f1dc985f Fix incorrect line breaking 2016-12-08 11:23:09 -05:00
Toshio Kuratomi
9f043d9ba8 Further optimizations pointed out by @kustodian in #1516 
* Only install yum-utils if needed (b/c we're going to use repoquery)
* Add a warning message explaining that why slower repoquery was used
  rather than yum API.
 2016-12-08 11:23:08 -05:00
Toshio Kuratomi
ba566501a8 Yum API is faster than calling out to repoquery. Looking through the commit logs it looks like we weren't previously doing that because of commit 14479e6adc 
The message there is that Yum API prints an error message if the
rhn-plugin is in use and no rhn-certificate is available.  So instead of
using repoquery in preference always here we use repoquery in preference
if the rhn-plugin is enabled.
 2016-12-08 11:23:08 -05:00
David Shrewsbury
9cbd7b2ece Remove os_security_group_rule module 
The rules module will have it's own branch.
 2016-12-08 11:23:08 -05:00
David Shrewsbury
6527f895a1 Remove 'result' value 
This value is pretty much useless, and a holdover from the old
module code. Let's remove it.
 2016-12-08 11:23:08 -05:00
Monty Taylor
eb2f3c8a44 Update version added 2016-12-08 11:23:08 -05:00
David Shrewsbury
7f0da6d851 Update the docstring for os_security_group 
Indicate that idempotence is on security group names, and give
an example for updating a security group description.
 2016-12-08 11:23:08 -05:00