Commit graph

568 commits

Author SHA1 Message Date
Brian Coca
161b868e0f properly convert inputs to handle bytes/unicode (#53072)
* properly convert inputs to handle bytes/unicode

  fixes #52186

* Update changelogs/fragments/nmap_bytes_fix.yml

Co-Authored-By: bcoca <bcoca@users.noreply.github.com>
(cherry picked from commit 55dc63be3a)
2019-02-28 11:52:07 -05:00
arsenicks
8fba0ab199 Backport into 2.7
Katello: Added product to the dict choices (#49776)

* Added product to the dict choices.

Following issue 48594 where product is not a recognised choice: https://github.com/ansible/ansible/issues/48594

* fixed doc

added - product to the doc

* split line 549

to correct ci test splitting line 549

* Create 49776-product_fix_katello_foreman_module.yaml

changelog fragment creation

(cherry picked from commit d3fcdae4ad)
2019-02-22 11:04:29 -08:00
Till Maas
6cef018b71 rhsm_repository: Properly handle no repos (#51938)
When no repos are defined, the `repo` variable is undefined. Therefore
append it only to the result if a repo was found. Otherwise Ansible will
fail with an UnboundLocalError.

(cherry picked from commit 0469134f16)
2019-02-22 10:45:17 -08:00
Aniket Khisti
2d4096daf0 Fix trackback on providing arguemnt --all to ansible-doc command (#52034)
* Remove redundant argument from the function caller
* Add unit test
* Add changelog
2019-02-22 10:44:19 -08:00
Albert Cervera i Areny
e7cf6b7513 Filter DNSimple request by record name. (#49981)
* Filter DNSimple request by record name.

The request was not filtered and DNSimple returns only the first 100
records so if the number of records is larger the check could fail.

This patch fixes the issue and also makes the check to perform better.

* Add changelog fragment.

(cherry picked from commit e0274adafe)
2019-02-22 10:43:12 -08:00
Jiri Tyr
b8e8e2baa0 Fixing state=present for jenkins_plugin module (#52051) (#52535)
* Fixing state=present for jenkins_plugin module (#52051)


(cherry picked from commit 5f4840aaa8)

* Adding changelog fragment for PR #52051 (#52687)


(cherry picked from commit ee14b123f3)
2019-02-21 19:27:10 -08:00
Jiri Tyr
573a1106cd Updating update_url for jenkins_plugin (#52086) (#52536)
* Updating update_url for jenkins_plugin (#52086)


(cherry picked from commit f49469f7bf)

* Adding changelog fragment for PR #52086 (#52689)


(cherry picked from commit 280e8911ce)
2019-02-21 19:26:39 -08:00
Alan Rominger
ac4447f2c4 Plugin errors backport (#52749)
* Fix missing tracebacks in ansible-inventory

(cherry picked from commit b62693299b)

* remove usless tb initiator

  always pass proper tb
2019-02-21 19:26:10 -08:00
Zim Kalinowski
f80e9070a5 Backport/2.7/52540 (#52545)
* fixed deallocated vm facts problem (#52540)

(cherry picked from commit d6600b0ab6)

* added changelog
2019-02-21 17:03:59 -08:00
Philippe Makowski
ec8c1cb34a fix bug #47154 (#49881)
(cherry picked from commit 61743ab39a)

backport bugfix for urpmi module

add changelog
2019-02-21 17:03:14 -08:00
René Moser
24318d51e5 [2.7]: dnsimple: fix KeyError: 'record_type' (#52646)
* v2 dnsimple api uses type vs record_type (#39301)

* v2 dnsimple api uses type vs record_type

https://developer.dnsimple.com/v2/zones/records/#listZoneRecords

* replace prio with priority

(cherry picked from commit bb6a82d2a9)

* add changelog
2019-02-21 17:02:18 -08:00
Jordan Borean
a998c267c2 win_chocolatey - fix beta version parsing (#52601)
(cherry picked from commit 1ec376abca)
2019-02-21 17:01:28 -08:00
plumbeo
bf7597efe1 backport/2.7/40092 (#51909)
* mysql_user: Match quotes, double quotes and backticks when checking current privileges

(cherry picked from commit 1ae0e21383)

* Add changelog fragment for PR #40092

(cherry picked from commit 8974ce3c78)

* mysql_user: fix malformed regex used to check current privileges
2019-02-21 16:41:26 -08:00
Toshio Kuratomi
cf6c765871 New release v2.7.8 2019-02-21 09:17:52 -08:00
Zim Kalinowski
cb844ae32b Backport/2.7/45269 (#52466)
* Fixing issues with azure_rm_virtualmachine crashing (#45269)

* vm fixes

(cherry picked from commit f04139bfa3)

* added changelog
2019-02-18 13:50:55 -08:00
Zim Kalinowski
211fe600a4 fixing force_update in azure_rm_mysqldatabase (#52389)
(cherry picked from commit fa73abcf5d)
2019-02-18 09:57:12 -08:00
Zim Kalinowski
474d76c0dd Fixing azure_rm_postgresqldatabase force_update parameter (#52388)
(cherry picked from commit 8422e23533)
2019-02-18 09:47:01 -08:00
Zim Kalinowski
40055b4507 Fixing managed disk facts (#51781)
(cherry picked from commit 0c8c72a0bf)
2019-02-18 09:24:26 -08:00
Zim Kalinowski
0e4f07b5ae resolved conflict 2019-02-18 08:48:29 -08:00
Zim Kalinowski
0fed03fa85 merge conflict 2019-02-18 08:48:08 -08:00
Zim Kalinowski
f85cd0b0c2 Backport/2.7/49704 (#52467)
* backport image crash fix

* adding changelog fragment
2019-02-18 08:47:35 -08:00
Zim Kalinowski
3929cfea85 merged change 2019-02-18 08:44:16 -08:00
Zim Kalinowski
e531356d07 Backport/2.7/50120 (#52444)
* fixed crash in facts (#50120)

(cherry picked from commit 756ad176cc)

* added changelog
2019-02-18 08:43:42 -08:00
Alan Rominger
b159fc38ce Send openstack inventory logs to stderr (#51827) 2019-02-18 08:42:11 -08:00
Martin Krizek
7fb1549152 Native Jinja2: raise undefined error immediately (#52237)
Fixes #52158

(cherry picked from commit 50d7483632)
2019-02-18 08:31:26 -08:00
T. Ichikawa
dc3b7aebd6 Backport/2.7/51548 - Properly handle unauthenticated yum proxy config (#52245)
* Properly handle unauthenticated yum proxy config (#51915)

Fixes #51548

Signed-off-by: Adam Miller <admiller@redhat.com>
(cherry picked from commit 2721ed260e)

* Fix: Yum module does not use proxy when username is not set #51548 (#51994)

* add test of yum with proxy

* Properly handle unauthenticated yum proxy config

Fixes #51548

* shell executable is bash

(cherry picked from commit c2a409a9e0)
2019-02-14 12:45:31 -08:00
Simon Westphahl
b97caade8a Backport: Raise AnsibleConnectionError on winrm connnection errors (#52227)
* Raise AnsibleConnectionError on winrm con errors

Currently all uncaught exceptions of the requests library that is used
in winrm will lead to an "Unexpected failure during module execution".

Instead of letting all exceptions bubble up we catch the connection
related errors (inkl. timeouts) and re-raise them as
AnsibleConnectionError so Ansible will mark the host as unreachable and
exit with the correct return code.

This is especially important for Zuul (https://zuul-ci.org) to
distinguish between failures and connection/host related errors.

* Update lib/ansible/plugins/connection/winrm.py

Co-Authored-By: westphahl <westphahl@gmail.com>

* Add changelog fragment
2019-02-14 12:43:24 -08:00
Wojciech Sciesinski
b7b4182bbd Install the NuGet package provider if needed (#52129)
* Install the NuGet package provider if needed

* Add the changelog fragment file
2019-02-14 12:41:16 -08:00
Matt Martz
396a2f7471 [stable-2.7] Disallow use of remote home directories containing .. in their path (CVE-2019-3828) (#52133) (#52173)
* Disallow use of remote home directories containing .. in their path

* Add CVE to changelog
(cherry picked from commit b34d141)

Co-authored-by: Matt Martz <matt@sivel.net>
2019-02-13 09:23:06 -08:00
Bill Dodd
7918323832 Backport/2.7/51764 (#52126)
* Update GetBiosBootOrder to use standard spec resources (#51764)

* update GetBiosBootOrder to use standard spec resources

* handle case where BootOrder is present but BootOptions is missing

(cherry picked from commit e0538610bf)

* add changelog fragment and fix merge issue
2019-02-13 08:23:13 -08:00
Felix Fontein
6438ab2c46 ufw: check values for direction depending on situation (#50402)
* Check values of 'direction'.

* Add changelog.

* Update lib/ansible/modules/system/ufw.py

Co-Authored-By: felixfontein <felix@fontein.de>

* Update lib/ansible/modules/system/ufw.py

(cherry picked from commit 4d3d8dd60f)
2019-02-13 08:12:07 -08:00
Jordan Borean
cc5088c9e1 win become - fix token elevation issues
This is an implementation of 8bffcf8e50
that was done in the PR https://github.com/ansible/ansible/pull/48082 to devel.
The changes have been manually brought across to the the stable-2.7 branch as it
cannot be cleanly cherry picked due to the substantial differences in become
between these versions.

Currently we impersonate the `SYSTEM` token in order to elevate our become
process with the highest privileges it has available but there are some edge
cases where the first `SYSTEM` token we come across doesn't have the
`SeTcbPrivilege` which is required for the above. This PR adds a further check
in the search for a `SYSTEM` token to make sure it has the `SeTcbPrivilege`
before continuing.
2019-02-11 18:21:23 -08:00
Bill Dodd
7f33c7def5 Backport/2.7/51028 (#52048)
* get standard properties for each firmware entry (#51028)


(cherry picked from commit 63f7536594)

* add changelog fragment
2019-02-11 15:06:12 -08:00
Felix Fontein
c3271befda Prevent bug in 'ufw --dry-run reset' to delete firewall rules. 2019-02-11 12:24:43 -08:00
Felix Fontein
0093b69935 openssl_csr: ignore empty strings in altnames (#51473)
* Ignore empty strings in altnames.

* Add changelog.

* Add idempotence check without SAN.

* Fix bug in cryptography backend.

(cherry picked from commit 9b1cbcf3a4)
2019-02-11 12:10:22 -08:00
Viktor Utkin
e7e47ca1fc [Backport 2.7] spot instance request stay opened when module exit with timeout
Fixes: #51534

* set valid_until equal to current time + spot_wait_timeout
* add setting ValidUntil to  value
* add changelog fragment
* fix shebang issue

(cherry picked from commit d40f0313e2)
2019-02-11 11:49:18 -08:00
Nathaniel Case
df359e036c [stable-2.7] ios retry config if section filter fails (#49485) (#51871)
* [stable-2.7] ios retry config if section filter fails (#49485)

* Attempt to work around devices that don't understand | section

* Fix case of no flags
(cherry picked from commit 6caed0c)

Co-authored-by: Nathaniel Case <this.is@nathanielca.se>

* Add changelog
2019-02-11 11:22:07 -08:00
fboux0
aa73f8ea3c Backport/2.7/46478 - haproxy - fixes naming collision (#51822)
* fix drain mode 'bool' (#30833) (#46478)


(cherry picked from commit 4376417743)

* Create 46478-haproxy-fix-drain-mode.yaml
2019-02-11 11:20:02 -08:00
Martin Krizek
1492f46d78 yum: disableexcludes is supported on centos6 (#51698)
(cherry picked from commit 33b07f322c)
2019-02-11 11:18:29 -08:00
Felix Fontein
a200cfb07f acme_challenge_cert_helper: fix bad module.fail_json() call (#51795)
* Fix bad module.fail_json() call.

* Add changelog.

(cherry picked from commit c9b08db979)
2019-02-11 11:17:04 -08:00
Jordan Borean
718e011168 psrp - do not display bootstrap wrapper for eachach task (#51779)
(cherry picked from commit 146a89b612)
2019-02-11 11:16:17 -08:00
Elijah DeLee
fe79534415 Backport aws ec2 missing region discovery (#51626)
* aws_ec2 Implement the missing 'region discovery' (#51333)

* aws_ec2 Implement the missing 'region discovery'

  fixes #45288

  tries to use api as documented (which seems to fail in latest boto3 versions)
  and fallback to boto3 'hardcoded' list of regions

* fixes and cleanup, add error for worst case scenario

* fix tests, remove more unused code

* add load_name

* acually load the plugin

* set plugin as required

* reverted test changes, removed options tests

* fixes as per feedback and cleanup

* Allow default regions list to use flexible credential types
2019-02-11 11:13:48 -08:00
Toshio Kuratomi
11a2bafa21 New release v2.7.7 2019-02-07 14:08:13 -08:00
Brian Coca
7589d496fc remove default from delegate_facts to inherit (#45492) (#51553)
* remove default from delegate_facts to inherit (#45492)

* remove default from delegate_facts to inherit

fixes #45456

* test delegate_facts

* added note about inheritance and defaults

* yamllint

(cherry picked from commit 8743e6ae2e)

* added changelog
2019-02-04 14:16:32 -08:00
Andrea Tartaglia
d064534df6 Added description to single net interface (#51602)
* Added description to single net interface

* ec2_instance single iface description changelog

(cherry picked from commit b8790abcbe)
2019-02-04 12:45:09 -08:00
Sumit Jaiswal
483aa64216 Fixes issue where uppercase named A_Record delete was getting skipped (#51592)
* Fixes issue where uppercase named A_Record delete was getting skipped (#51539)

* fixes 51193

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* fixes 51193

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* fixes 51193

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
(cherry picked from commit 15cef845ca)

* shippable fix

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
2019-02-04 12:44:30 -08:00
chronidev
22c4745b96 Add coherency between check and normal mode for copy plugin action see issue #24633 (#51582)
* Add coherency between check and normal mode see issue #24633

* Add changelog fragment for the PR

* Make change following PR comment

* Remove trailing whitespace

(cherry picked from commit 240d1a6afb)
2019-02-04 12:43:38 -08:00
Jordan Borean
9168e6844a win_power_plan: fix for Windows 10 and Server 2008 compatibility (#51471)
(cherry picked from commit f27078df52)
2019-02-04 12:35:53 -08:00
Fabian von Feilitzsch
ce033c6762 [k8s] Always check envvars when auth parameter is not provided (#51495)
* Always check envvars when auth parameter is not provided

This will make it so that all code using the get_api_client
method will make use of the environment variables, instead of
silently ignoring them if default values haven't been set. This
affects at least the k8s lookup plugin.

* Add changelog

(cherry picked from commit 0be66113d4)
2019-02-04 12:35:30 -08:00
Brian Coca
3bf030ddcc Handle complex quoting in extra args in pull cli (#50212)
* added proper testing

fixes #40729

(cherry picked from commit b6824669df)
(cherry picked from commit e010034151)
2019-02-04 12:27:00 -08:00