cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity
7422 commits 47 branches 390 tags 440 MiB
Commit graph

205 commits

Author SHA1 Message Date
Stanislav Antic
c4986bf78d Fixes #155 2015-01-05 14:59:01 +01:00
Jonathan Mainguy
d611f86e5b Addes login_port feature, similiar to how mysql_db.py works 2014-12-12 16:10:14 -05:00
Balazs Pocze
0957768755 gtid_replication parameter added to keep this module working in 
environments which are using GTID replication
 2014-12-01 15:16:40 +01:00
Toshio Kuratomi
317654dba5 Use the python db api to quote mysql values 2014-11-25 01:34:25 -08:00
Michael DeHaan
ad181b7aa9 Categorize some modules. 2014-11-05 16:11:23 -05:00
Jens Depuydt
11e3b8e887 added postgresql_lang.py 2014-10-17 16:23:25 +02:00
Michael DeHaan
8a4f07eecd Merge pull request #2 from atlashealth/mongodb_ssl 
Ability to enable SSL when creating MongoDB users
 2014-10-01 14:23:51 -04:00
Philip Misiowiec
6df1aa6059 Added version 2014-09-29 17:45:55 -05:00
kustodian
9a5bd8587b mysql_replication should not connect to the 'mysql' database 
All the actions by the mysql_replication plugin can be done by connecting to the NULL database. There is no need to connect to the 'mysql' db, since there are permissions problems when connecting to remote hosts, e.g. when you want to query "SHOW MASTER STATUS" on a remote host.
 2014-09-30 00:22:02 +02:00
Philip Misiowiec
1c0965c631 Ability to enable SSL when creating MongoDB users 2014-09-26 23:23:39 -07:00
Michael DeHaan
110250d344 package files 2014-09-26 11:04:10 -04:00
Michael DeHaan
b1e789968b File extensions! 2014-09-26 10:40:16 -04:00
Michael DeHaan
50f105578a Restructuring. 2014-09-26 10:14:28 -04:00
Michael DeHaan
73123b69fa Move modules into subdirectory. 2014-09-26 09:23:50 -04:00
James Martin
49a5619cc0 Prevents module from failing with "_mysql_exceptions.Warning: Sending passwords in plain text without SSL/TLS is extremely insecure." When not using SSL/TLS. 2014-09-09 19:44:40 -04:00
Michael DeHaan
677709803c Merge pull request #8419 from georgeOsdDev/escape_underscore_in_database_name 
mysql_db module: Escape "_" in database name for "SHOW DATABASES" statement
 2014-08-08 14:38:51 -04:00
Michael DeHaan
185d5a6221 Merge branch 'spelling' of git://github.com/cgar/ansible into devel 
Conflicts:
	docsite/rst/guide_rax.rst
	plugins/callbacks/mail.py
 2014-08-08 13:28:45 -04:00
Takeharu Oshida
b42ff30505 Escape "_" in database name for "SHOW DATABASES" statement 2014-08-04 20:15:58 +09:00
Wayne Rosario
7cfef577a1 Adding the following Test Coverage: 
Use mysql_user module to create, delete users.
Update user password and ensure new password was updated for the correct user.
Assert user has access to multiple databases
Assert user creation, deleting using different user privilege and ensure privilege work correctly.
 2014-07-29 11:49:53 -04:00
Wayne Rosario
45d7e53da9 updating doc to include revoke example for mysql_user docs 2014-07-24 10:32:28 -04:00
Jonathan Mainguy
3da1e5ce62 This fixes 8173, if target was not defined it would break, now it wont 2014-07-18 09:52:37 -04:00
James Cammarata
93d862f3f5 Expand target for mysql_db 
Fixes #8128
 2014-07-16 13:39:47 -05:00
Jonathan Mainguy
2b84ec6b4a Errors out with stderr 1049, unknown database: when importing a database that does not exist 2014-07-11 14:57:45 -04:00
James Cammarata
a8368e4dc4 Merge pull request #8092 from ghjm/mysql-exceptions 
Added exception handling to database creation and deletion. Fixes #8075.
 2014-07-11 11:59:12 -05:00
Graham Mainwaring
8e6e9a12e7 Switched primary and alias names of the name/db parameter, to match documentation. Fixes #8065. 2014-07-10 22:37:46 -04:00
Graham Mainwaring
6e237bed7a Added exception handling to database creation and deletion. Fixes #8075. 2014-07-10 22:28:56 -04:00
Jonathan Mainguy
f4690464b4 Makes ansible fail if login_port is defined and login_host is either not defined, or defined as localhost. This is because if login_host is localhost then MySQLdb will use the socket instead of TCP. This leads to confusion for ansible users as, when a port is defined it gets ignored if login_host is localhost. This is to fix the bug reported by wrosario #8070. Info on MysqlDb can be read here http://mysql-python.sourceforge.net/MySQLdb.html 2014-07-09 14:38:27 -04:00
James Cammarata
ae37758257 Merge pull request #6766 from Jmainguy/mysql_db_bug 
mysql_db module now correctly fails on import if bz2 or gz fails.
 2014-06-23 12:42:42 -05:00
Scott Brown
34d960ef20 BUGFIX 1178: Adding better existence check in one place. db_import now fails fast if target does not exist b/c no point going further without the target. 2014-06-17 14:37:14 -07:00
Scott Brown
1853a3f565 BUGFIX 7811: Adding file existence check when performing mysql import on a .gz or .bz2 file, otherwise Ansible will not notice that the underlying *nix command silently died. 2014-06-17 13:08:53 -07:00
James Cammarata
8d0d2831e6 Fixing mysql master replication boolean 
Fixes #7528
 2014-06-09 08:58:55 -05:00
Josef Špak
1dbc069bcb Fix typo in CHANGE MASTER TO syntax 2014-06-02 13:42:55 +02:00
Mathieu Martin
9589ee2a41 Add example 'Specify grants composed of more than one word' to the mysql_user module. 2014-05-20 14:41:18 -04:00
Scott Sturdivant
40a6a6f911 Clarify that the encrypted param must also be set. 
While the encrypted parameter's documentation clearly states that it needs to
be set, if you are focused on the password parameter's documentation, there's
nothing to draw your attention to the fact that encrypted may also need to be
set.
 2014-05-14 07:49:11 -06:00
Adam Chainz
29b10ac698 Fix sync_binlog name in mysql_variables example 
The previous sync_binary_log is not a real MySQL variable.
 2014-05-06 12:25:11 +01:00
Carlos E. Garcia
4dcaa9d9fb multiple spelling error changes 2014-04-29 10:41:05 -04:00
Cove Schneider
ae0721d3da re-add idempotency check 2014-04-05 16:31:33 -07:00
Cove Schneider
428dead8cd add replicaset support to mongodb_user module 2014-04-05 15:33:22 -07:00
Michael DeHaan
acd89f7a1f Merge pull request #6796 from mistaka0s/mysqldump_fix 
Remove extra quote from the mysqldump password argument
 2014-04-02 17:24:35 -04:00
Matt Martz
a4078a4bf8 Use /usr/bin/python instead of /usr/bin/env python 2014-04-01 13:54:37 -05:00
Chao Luan
749e749c11 Remove extra quote from the mysqldump password argument 
The mysqldb Ansible module will fail if the state specified is import or dump with a '1045: Access Denied' mysql error for complex passwords.

This is caused by the extra quote around the '--password' argument to mysqldump, as pipes.quotes already quotes the password string.

>>> "--password='%s'" % pipes.quote('simple')
"--password='simple'"

>>> "--password='%s'" % pipes.quote('c0mplexp@ssword!')
"--password=''c0mplexp@ssword!''"

>>> "--password='%s'" % pipes.quote('password with space')
"--password=''password with space''"
 2014-04-01 23:52:08 +11:00
Jonathan Mainguy
17fa8e3c84 Added mpdehaan suggestion to use os.path.splitext. Wise suggestion, does look clearner 2014-03-31 11:09:00 -04:00
Jonathan Mainguy
f0b2616bd8 mysql_db module now correctly fails on import if bz2 or gz fails. 2014-03-30 13:39:00 -04:00
Michael DeHaan
ff5560f00c Update comments about redis config. 2014-03-19 18:15:52 -04:00
Michael DeHaan
fbb15ad52f Merge branch 'devel' of git://github.com/mleventi/ansible into devel 2014-03-19 18:15:06 -04:00
Michael DeHaan
d10b3f9257 Merge pull request #5597 from laggyluke/mongodb_user_idempotence 
Fix idempotence in mongodb_user module
 2014-03-16 15:50:43 -05:00
Cristian Ciupitu
7f681c33a2 Micro-optimization: replace s.find(x)!=-1 with x in s 
timeit shows a speedup of ~3x on Python 2.7.5 x86_64.
It also makes the code a bit shorter.
 2014-03-16 13:10:28 -04:00
Richard Isaacson
35b4cf001c Merge pull request #6461 from risaacson/modules_make_run_command_safer 
Modules make run command safer
 2014-03-12 23:28:06 -05:00
Richard C Isaacson
122917019c mysql_db module: typo fix 
Tests clean.
 2014-03-12 23:25:22 -05:00
Richard C Isaacson
d9da5cf084 Shell updates. 2014-03-12 22:15:56 -05:00
James Martin
0a74cb484c Fixes various typos introduced in a9017af2bb. 
Fixes odd encoding problem with wait_for_service.
 2014-03-12 21:26:16 -04:00
Michael DeHaan
980653f20b More shell fixes 2014-03-12 17:43:31 -04:00
James Cammarata
72217c297d Adding validate_certs to all modules that use fetch_url 2014-03-12 10:19:54 -05:00
Richard C Isaacson
525e811d9b Bulk update of choices=BOOLEANS to type='bool' 2014-03-11 22:56:51 -05:00
James Cammarata
b77ea4ed91 Merge pull request #4630 from mmoya/mysql_variables-fix2 
Add support for string values
 2014-03-11 15:20:46 -05:00
James Cammarata
a1b1182662 Validate SSL certs accessed through urllib* 
* Adds another module utility file which generalizes the
  access of urls via the urllib* libraries.
* Adds a new spec generator for common arguments.
* Makes the user-agent string configurable.

Fixes #6211
 2014-03-10 16:06:52 -05:00
Michael DeHaan
8e9f058214 Merge pull request #6305 from amree/fix-mysql-replication-port 
Fixed SQL syntax error when running mysql_replication module
 2014-03-06 11:08:12 -06:00
Jimena Cabrera-Notari
86e7555554 Don't use keyword error in encode 
This is not supported in Python 2.6. Just use positional arguments.
 2014-03-06 13:33:53 +00:00
amree
59f954b349 MASTER_PORT variable for CHANGE MASTER TO command can only accept integer value 2014-03-06 12:19:54 +08:00
Guido Kollerie
314e621671 Emphasize target is on remote host. List supported file types. 
From the documentation it is not immediately clear that the 'target'
option refers to a location on the remote host. This change emphasizes that.
In addition to .sql files, .bz2 and .gz files are supported for dumps and
restores. This is now documented.
 2014-02-26 12:56:24 +01:00
Kyle Kelley
70d8be5cc2 Fix expires 2014-02-24 15:54:55 -06:00
James Martin
e312b0e5bf Properly fetching the riak version, and properly setting the python interpreter. 2014-02-19 12:12:02 -05:00
James Cammarata
c85b7d868b Merge branch 'fix-postgres_user_to_understand_pg_namespaces' of https://github.com/alanfairless/ansible into alanfairless-fix-postgres_user_to_understand_pg_namespaces 2014-02-17 10:04:12 -06:00
James Cammarata
a570280b81 Merge branch 'postgres_alter_role' of https://github.com/jinnko/ansible into jinnko-postgres_alter_role 
Conflicts:
	library/database/postgresql_user
 2014-02-17 09:57:31 -06:00
Maykel Moya
5da6fcae4d Add support for string values 
The SET GLOBAL statement requires properly quoting of values. For example, the
following correct queries will fail if quotes are toggled:

mysql> SET GLOBAL innodb_lru_scan_depth = 2000;
mysql> SET GLOBAL master_info_repository = "TABLE";

`mysql_variable` module doesn't quote the value argument, therefore
string values will fail.

  # this task will pass, 2000 is passed without quotes
  - name: set a numeric value
    mysql_variable: variable=innodb_lru_scan_depth value=2000

  # this task will fail, TABLE is passed without quotes
  - name: set a string value
    mysql_variable: variable=master_info_repository value=TABLE

With this patch prepared statements are used. Proper quoting will be
done automatically based on the type of the variables thus an attempt
to convert to int, then to float is done in first place.

Booleans values, ie: ON, OFF, are not specially handled because they
can be quoted. For example, the following queries are correct and
equivalent, they all set _innodb_file_per_table_ to logical _True_:

mysql> SET GLOBAL innodb_file_per_table = "ON";
mysql> SET GLOBAL innodb_file_per_table = ON;
mysql> SET GLOBAL innodb_file_per_table = 1;

Tested in mysql 5.5 and 5.6.
 2014-02-12 12:44:28 +01:00
Arturs Vonda
df853fa92e Added port documentation to postgresql_db and postgresql_user 2014-02-07 18:27:55 +02:00
George Miroshnykov
58e34edce3 Add idempotency to mongodb_user module 2014-02-04 13:56:35 +02:00
Matthew Jones
3ddfc8d471 Allow strings containing single and double quotes to be used as passwords for postgres_user 2014-02-03 17:07:17 -05:00
Timur Batyrshin
9ad52632c5 reword "except Error as e:" into "except Error, e:" to be compatible with Python 2.5 (#5852) 2014-02-03 13:00:40 -06:00
Matthew Leventi
1637438298 adding the ability to change redis configuration 2014-01-25 22:20:39 -08:00
jctanner
7bab8656a3 Merge pull request #5435 from jkleckner/fix-mysql-dump-import 
mysql_db module: make dump and import to use port argument
 2014-01-14 13:06:33 -08:00
David Busby
ab8d5c5924 Documentation update to yield example of "WITH GRANT OPTION" which is undocumented previous 2014-01-14 12:04:32 +00:00
Alan Fairless
927a30c404 Fix postgresql_user to understand PG namespaces 
Previously postgresql_user quoted user supplied identifers to create
grant statements that look like this:

    GRANT SELECT on "tablename" to "user";

Which only works if the tablename is not in a namespace.  If you supply
a namespaced tabelname like "report.revenue" then it creates this
incorrect statement:

    GRANT SELECT on "report.revenue" to "user";

Which will not find the "revenue" table in the "report" namespace, but
will rather look for a table named "report.revenue" in the current
(default public) namespace.  The correct form is:

    GRANT SELECT on "report"."revenue" to "user";

This approach could have the unfortunate effect that code that
previously relied on the other behavior to grant privileges on tables
with periods in their names may now break.  PostgreSQL users
typically shouldn't name tables as such, and users can still access the
old behavior and use tablenames with periods in the if they must by
supplying their own quoting.
 2014-01-04 15:37:08 -06:00
Jim Kleckner
8ba9019797 Add quotes to password argument for dump/import 
The password is passed on a command line for dump and import and needs
quoting.

Ideally, this would not be passed on a command line at all - any ideas?
Or at least have a stronger form of quoting so that embedded single
quotes will be escaped.
 2014-01-02 12:04:03 -08:00
Jinn Koriech
57dc4fbea2 postgresql_user module: Gracefully handle ALTER ROLE on read-only postgres servers. 2013-12-31 18:23:45 +00:00
Jim Kleckner
59396d38e2 Fix mysql_db dump and import to use port argument 
The code for mysql_db did not pass the port argument when state=dump or
state=import.
 2013-12-26 16:21:16 -08:00
jctanner
8b925e93e6 Merge pull request #5099 from tartansandal/postgresql_db_check_mode 
postgres_db CHECKMODE changed status
 2013-12-16 11:39:16 -08:00
Jinn Koriech
fbb1018abe Fix postgresql_user documentation render 2013-12-05 16:57:56 +00:00
Jinn Koriech
e1aa94896f Add documentation for usage of encrypted postgresql passwords. 2013-12-05 10:35:35 +00:00
James Tanner
4f9aadcc07 Addresses #5023 Fix import comments 2013-12-02 15:13:49 -05:00
James Tanner
38edad70ac Fixes #5023 Convert all modules to use new snippet import pattern 2013-12-02 15:11:23 -05:00
Kahlil (Kal) Hodgson
147783528c postgres_db CHECKMODE changed status 
Make the changed status for postgres_db under CHECKMODE match the
status that would be returned normally.
 2013-11-29 11:29:03 +11:00
Michael DeHaan
4c35b7f380 There's a cleaner way to do this, commit to module formatter pending. 
Revert "No longer need to reference 'version_added' in docs for these, as this was quite a while ago."

This reverts commit ff0a41d446.
 2013-11-27 21:23:03 -05:00
Michael DeHaan
9e4d71203d No longer need to reference 'version_added' in docs for these, as this was quite a while ago. 2013-11-27 21:19:32 -05:00
Michael DeHaan
08996d78d6 Add version_added to all modules missing version_added information, the docs formatter will now 
raise errors when omitted, updated changelog with new modules.
 2013-11-18 18:55:49 -05:00
James Tanner
eccbd21a0d Fix typo in postgresql_user module docstrings 2013-11-14 11:57:01 -05:00
jctanner
6336129f59 Merge pull request #4686 from bcoca/postgresql_user_pwds 
postgresql_user now supports users w/o a password, encrypted passwords and expiration
 2013-11-14 08:55:11 -08:00
James Tanner
f7db64d69b Merge pull request #4307 from damianmoore/mysql_gzip_bzip2_support 
Add support for compressing mysql dumps and extracting during import.
 2013-11-07 15:07:59 -05:00
Steve Tjoa
de4b105e09 Changed parameter from 'user' to 'name' in the examples to coincide with the specs. 2013-11-02 22:42:44 -07:00
James Tanner
3370aee870 Fixes #4720 Use mysql command to restore database instead of mysqldump 2013-10-29 10:33:46 -04:00
Brian Coca
9b8b79f1fd updated to make note that password is required before v1.4 
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
 2013-10-26 12:47:22 -04:00
Brian Coca
0d9a6b63ea updated docs 
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
 2013-10-26 11:37:45 -04:00
Brian Coca
cdec70eeff now supports users w/o a password, encrypted passwords and expiration 
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
 2013-10-26 11:32:16 -04:00
Maykel Moya
6155bf2c55 Fail if requested variable is not available 2013-10-22 09:30:19 +02:00
James Tanner
251b52bef8 Fixes #4454 Make a temporary clean cnf file if unable to parse existing 2013-10-18 17:42:40 -04:00
Maykel Moya
2d33cf898c Improve change detection in mysql_variables 
mysql_variables bindly executes a SET var = value query even when
the variable already has the requested value.

With this patch the query is executed only if the current value is
different to the requested one.
 2013-10-17 19:13:58 +02:00
James Tanner
f233e29386 mysql_db: if connection is a socket, do not specify hostname 2013-10-16 09:59:31 -04:00
James Tanner
9128862b3b Fixes #4301 Use module_common functions for mysqldump and return better errors 2013-10-16 09:51:08 -04:00
Michael DeHaan
c586ed5168 Merge pull request #4342 from pileofrogs/devel 
mysql_replication switch to DictCursor for compatibility with more mysql server versions
 2013-10-11 06:21:22 -07:00
Michael DeHaan
daa005085d Add missing version_added doc to mysql login port parameter. 2013-10-11 09:14:14 -04:00