Commit graph

9376 commits

Author SHA1 Message Date
Felix Fontein
16d4d2dba9
acme_certificate: add select_chain option (#60710)
* Add select_alternate_chain option.

* Fix docs.

* Allow to match via subject key identifier and authority key identifier.

* Simplify test.

* Add comments.

* Add tests.

* Fix bugs.

* Also consider main chain when searching for alternatives.

* Bump version_added.

* Rename select_alternate_chain -> select_chain.
2019-10-29 08:09:15 +01:00
Felix Fontein
35a412fab7
openssl_csr: fix tests (#63994)
* Make sure tests are validated with correct backend in mind.

* Fix tests.
2019-10-29 07:07:17 +01:00
Gonéri Le Bouder
039c770a95 vmware_host_firewall_manager: fix #61332
Since https://github.com/ansible/ansible/pull/56733, we were not able to apply
firewall rules with no `allowed_hosts` key.

closes: #61332

In addition, this patch ensures the `allowed_hosts` key accepts a dict,
instead of a dict in a single entry list.

```yaml
vmware_host_firewall_manager:
  esxi_hostname: "{{ esxi1 }}"
  rules:
    - name: NFC
      enabled: True
      allowed_hosts:
        - all_ip: False
          ip_address:
            - "1.2.3.4"
```

Should be written:

```yaml
vmware_host_firewall_manager:
  esxi_hostname: "{{ esxi1 }}"
  rules:
    - name: NFC
      enabled: True
      allowed_hosts:
        all_ip: False
        ip_address:
          - "1.2.3.4"
```
2019-10-28 13:01:02 -04:00
Andrey Klychkov
defccd1d44 postgresql_db: allow to pass users names with dots (#64007)
* postgresql_db: allow to pass users names with dots

* postgresql_db: allow to pass users names with dots, add changelog fragment

* postgresql_db: allow to pass users names with dots, fix ci
2019-10-28 13:23:09 +00:00
John R Barker
1e8765f0d9
BOTMETA support migrated_to (#63952)
* BOTMETA support migrated_to

Allow BOTMETA to define if this part of the codebase has moved
into a Collection on Galaxy.
See also https://github.com/ansible/ansible/pull/63935

* Enforce migrated_to URL format

* pep8
2019-10-28 11:02:31 +00:00
Mark Chappell
ef7d060a3f AWS module_utils: Clear out Sanity Test issues (#63991) 2019-10-28 09:21:40 +00:00
Mark Chappell
cd7bfc09a1 AWS ELB: Sanity Test fixups (#64008) 2019-10-28 09:19:26 +00:00
Mark Chappell
8d7580a59f AWS S3 : Fixup sanity test issues and deprecate 2 unused options (#63989)
* S3 module Sanity check fixes.

* s3_lifecycle: deprecate unused 'requester_pays' option

* s3_sync: deprecate unused retries option

* Add changelog fragment
2019-10-28 09:18:08 +00:00
Mark Chappell
fd54c54b51 AWS IAM Sanity test cleanup and deprecate unused 'fail_on_delete' option (#63961)
* AWS IAM Sanity test cleanup

* Changelog and porting guide updates

* Review recommendations
2019-10-28 09:18:58 +01:00
kalimsshar
01a92f0191 Make banner detection non-greedy in ios_banner (#63092)
* Make banner detection non-greedy in ios_banner

* Added ios_banner unit test to detect bug #63091

* Corrected PEP8 errors

* Added integration test

* Corrected typo in integration test
2019-10-25 14:20:00 -04:00
Andrey Klychkov
88af9f6470 mysql_replication - accept empty string to the module's parameters (#63546) 2019-10-25 11:56:40 -04:00
Andrey Klychkov
3aaebba235 postgresql_privs: allow to pass roles with names containing dots (#63942) 2019-10-25 14:39:49 +01:00
Xu Yuandong
5c5a315a44 a new module to manage static route and bfd. (#58004)
* add a new module

* update for shippable

* update

* update for shippable

* update for shippable

* update for shippable

* update

* add unittest.

* update

* update integration

* update unittest

* update

* update unittest.

* update for syntax error

* update for reviewing.
2019-10-25 06:40:30 -04:00
Dusan Matejka
57c36e0378 Zabbix integration tests (#63744)
* adjusted setup_zabbix integration tests role to work on distributions from Debian family

* bumped zabbix_host integration tests role to be run against bionic
2019-10-25 06:28:20 -04:00
Will Thames
07ed860c2b Add more kubernetes Service tests (#62581)
* Add more kubernetes Service tests

Services can often go wrong, and one of the main motivations for
apply was being able to correctly modify them, so more tests are good

* Remove a port from a service for k8s testing

* Add a Service check mode to k8s tests
2019-10-25 11:21:13 +01:00
Xu Yuandong
68c997e4dd add a new module ce_lldp_interface. (#58252)
* add a new module ce_lldp_interface.

* update for shipabble

* update

* ad unittest

* update

* update

* update

* update

* update

* upate

* update

* update for shipable.

* update & add intergration tests.

* update for shippable.

* update

* import future.

* update.

* update.

* update docs.

* missing whitespace after ','

* update docs.

* update docs.

* update docs.

* Update ce_lldp_interface.py

* Update ce_lldp_interface.py

* update for reviewing
2019-10-25 10:45:53 +01:00
The Magician
9fe524248c New Module: gcp_runtimeconfig_config (#63883) 2019-10-24 17:16:24 -04:00
The Magician
50f85c9bdd New Module: gcp_runtimeconfig_variable (#63885) 2019-10-24 17:15:57 -04:00
Nathaniel Case
7f5d1ab2b7
Removed in 29 (#63680)
* Eh, 2.10 is close enough

* drop top-level authorize

* Remove from documentation

* Remove load_params

* Centralize this junos thing

* Fixup user modules

* I'm 95% sure this did not do what it was supposed to

* nxos_hsrp: I don't think this is an actual module parameter

* Try to fix junos_package tests

* Move local params to provider

* Promote 'timeout' to a real parameter for eos_eapi

* Don't assume provider exists?

* move another timeout

* Provider now always has auth_pass

* Fix junos tests to avoid NameErrors
2019-10-24 15:01:05 -04:00
Andrey Klychkov
40437d434e postgresql_membership: add CI tests for roles with dots (#63896) 2019-10-24 11:09:42 +01:00
Kyle Umstatter
fb38c9cea9 Support PostgreSQL Custom Format (#63806)
* Support PGC Restores

* Fix whitespace

* support pgc both dump and restore
2019-10-24 11:09:11 +01:00
Adam Miller
ed86907587 DNF Handle Empty AppStream stream definition (#63819)
* DNF Handle Empty AppStream stream definition

Fixes #63683

Signed-off-by: Adam Miller <admiller@redhat.com>

* Switch Fedora dnf test target modularity to stratis

In Fedora 29, the metadata was not properly set for a default stream
for ripgrep even though there is a profile called "default", however
that's an arbitrary string and the module maintainer must set the
default stream (which it never was for the ripgrep module, thus
failing the "empty stream" install test)

Signed-off-by: Adam Miller <admiller@redhat.com>
2019-10-24 00:57:31 -04:00
Mark Chappell
bd6d4b5b3a New module: iam_policy_info (#62955)
* iam_policy: (integration tests) migrate to module_defaults

* iam_policy: (integration tests) Rework iam_policy integration tests

* iam_policy_info: Add new module and add iam_policy_info tests to iam_policy integration tests
2019-10-23 13:04:25 -07:00
Martin Krizek
18b9ce8b82
Integration tests: prevent loop squashing (#63847)
1. the feature will be deprecated in 2.11
2. these modules support passing lists
3. loop squashing does not work with collections
2019-10-23 21:02:25 +02:00
Sam Doran
3e4ae42256
Cleanup after MySQL integration tests (#63641)
Add handlers to setup_mysql_db and setup_mysql8 to remove installed packages.
2019-10-23 11:11:02 -04:00
GomathiselviS
68de182555 eos_eapi: Added fix for bug # 51144 (#63632)
* Added fix for bug # 51144

* Corrected Lint errors

* Added fix for bug 51144

* Corrected errors

* Added unit testcase
2019-10-23 19:46:43 +05:30
Andrey Klychkov
b1e8a6c1cb mariadb_replication: improve CI tests (#63848) 2019-10-23 15:50:31 +02:00
Mark Chappell
4d72b69035 rds_subnet_group : Sanity Check fixes (docs) and Integration tests (#63214)
* rds_subnet_group: Fixup sanity test issues

* rds_subnet_group: Add integration tests

* rds_subnet_group: Add testing policy
2019-10-23 08:27:07 -04:00
Matt Clay
92ccdeac31 Fix various import sanity test issues.
- Relative imports are now properly recognized.
- Correct script invocation of Ansible modules is used.
- Warnings are now consistently reported as errors.
- Errors are now consistently reported with the file tested.

Resolves https://github.com/ansible/ansible/issues/62723
Resolves https://github.com/ansible/ansible/issues/61884
2019-10-22 23:00:35 -07:00
Prasad Katti
56f52a0169 ec2_vpc_route_table_info integration tests (#63413)
* ec2_vpc_route_table_info integration tests

Make sure ec2_vpc_route_table_info return value has the right attributes.

* ec2_vpc_route_table_info integration tests for tags
2019-10-22 14:46:40 -04:00
Bojan Vitnik
7afba9420a XenServer: Update docs with recent changes in XenAPI python lib and branding (#63728)
- xenserver module_util: XenAPI lib import error message handling is now
   ported to missing_required_lib(). Updated unit tests.
 - xenserver_guest, xenserver_guest_info, xenserver_guest_powerstate modules:
   docs are updated to reflect recent changes in availability of XenAPI lib
   on PyPI.
 - xenserver_guest, xenserver_guest_info, xenserver_guest_powerstate modules:
   docs are updated to reflect recent Citrix rebranding of XenServer. Broken
   URLs to external resources are fixed.
 - xenserver_guest, xenserver_guest_info, xenserver_guest_powerstate modules:
   more tested platforms are mentioned in docs.
2019-10-22 21:04:16 +05:30
Sorin Sbarnea
a6e610a9ed Prevent generating roles that do not pass linting (#63709)
Fixes bug where newly created role fails linting due to extra space
at end of line: [201] Trailing whitespace
2019-10-22 11:26:07 -04:00
Stefan Horning
7aac7a56da Added missing param to lambda module to pass it through to boto3 (#58822)
* Added missing param to lambda module to pass it through to boto3

* Allow updating of runtime, because there is no reason why not

* Updated version_added to 2.10 to make tests green again

* Updated RETURN docs of Lambda module

* Added tests to aws_lambda test-suite.
2019-10-22 17:17:01 +02:00
Sam Doran
92cd13a2cf
lineinfile - use correct index value when inserting at the end (#63696) 2019-10-22 10:39:58 -04:00
Sam Doran
29d4d318a5
lineinfile - properly insert line when line exists and backrefs are enabled (#63763)
Use a separate variable for the boolean test rather than having the same variable sometimes be a boolean and sometimes be a regular expression match object

Add integration tests to cover this scenario
2019-10-22 10:01:11 -04:00
Jill R
aa68f728fd s3_bucket: Allow empty encryption_key_id with aws:kms (#62031)
* s3_bucket: Allow empty encryption_key_id with aws:kms to use KMS master key

* Add idempotency check and cleanup example, dont require encryption_key_id
2019-10-21 19:45:41 -04:00
Ujwal Komarla
dc5770dfa2 EXOS/VOSS/SLXOS - Single action file and 'gather_facts' (#61914)
* EXOS Single action file

* Single action file for all Extreme Network OSes
2019-10-21 13:31:26 -04:00
Mark Chappell
145b79ef0e ec2_instance test cleanup (#63708)
* ec2_instance/ec2_instance_info : Fixup sanity test errors

* Move ec2_instance integration tests to use aws_defaults

* Search for the AMI instead of hardcoding an AMI

* Make our VPC CIDR variable

* Remove AZ assumptions - no guarantees about specific AZs being available

* Make sure we terminate instances when we're done with them.

* Add a 10 second pause for IAM roles to become available before using them

* Wait on instance changes by default

* Switch out t2 instances for t3 they're cheaper and have more CPU available

* Pull t3.nano instance info a little earlier

* rework vpc_name and vpc_cidr a little

* Mark ec2_instance tests unsupported for now, they take too long
2019-10-21 14:55:44 +02:00
Toshio Kuratomi
cc1ff57c5b
AH servers include automation-hub as part of the server configuration. (#63700)
* AH servers include automation-hub as part of the server configuration.

So we don't need to add it here.

Fixes #63699

* Update unittests for the fix to galaxy wait_import_task
2019-10-19 12:40:45 -07:00
Andrea Scarpino
8f843bbaa5 iptables: support wait parameter (#47877)
Version 1.4.20 doesn't support 'wait' at all
Version 1.6.0 requires an argument for it
2019-10-19 22:27:45 +05:30
Andrey Klychkov
b6e997aa5f Cleanup after MariaDB integration tests (#63657) 2019-10-19 13:10:35 +02:00
zhongjun2
64989bea6a hwc: Add eip module (#60182) 2019-10-19 12:58:29 +02:00
Lukas Kämmerling
86e4dcbaed hcloud: Add protection support to hcloud_server and hcloud_server_info (#63669) 2019-10-19 12:57:00 +02:00
zhongjun2
c904336db0 hwc: Add security group rule module (#60186) 2019-10-19 12:53:02 +02:00
zhongjun2
420de44a57 hwc: Add port module (#60188) 2019-10-19 11:32:10 +02:00
zhongjun2
652de1a7fd hwc: Add new module to peering (#60190)
* Add peering module

* Update hwc_vpc_peering_connect.py
2019-10-19 11:27:53 +02:00
zhongjun2
e0b4fafb22 hwc: Add disk module (#59919) 2019-10-19 10:09:40 +02:00
zhongjun2
39201d1ba3 hwc: Add instance module (#60180) 2019-10-19 09:50:03 +02:00
zhongjun2
7ed6a0037c hwc: Add security group module (#60187)
* Add security group module

* Update hwc_vpc_security_group.py
2019-10-19 09:43:50 +02:00
Tiziano Müller
034afd40a3 zypper: add additional flag --force-resolution (#61705) 2019-10-19 09:40:47 +02:00