cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity
6079 commits 47 branches 390 tags 440 MiB
Commit graph

680 commits

Author SHA1 Message Date
Toshio Kuratomi
effdba95de Merge pull request #639 from tgolly/devel 
distutils is not available on some non-Linux OS's
 2015-01-22 21:49:17 -08:00
Brian Coca
8c4b279552 Merge pull request #39 from kustodian/selinux_disable_fix 
Set selinux state to 'permissive' for state=disabled
 2015-01-22 14:52:26 -05:00
Brian Coca
d80e7438a6 Merge pull request #37 from mscherer/fix_old_7420 
Add hostname to generated user SSH key comment
 2015-01-21 18:16:05 -05:00
Brian Coca
6b784fb28a Merge pull request #675 from bcoca/sysctl_nonstrings 
now handles non string values for sysctl
 2015-01-21 10:49:47 -05:00
Ben Konrath
347234b937 Add support for SL7 to hostname module. 2015-01-20 21:50:15 +01:00
Brian Coca
f85b7ee13c now handles non string values for sysctl 2015-01-19 19:37:57 -05:00
Brian Coca
e957150f77 Merge pull request #189 from jarmani/openbsd_rcctl 
Openbsd rcctl
 2015-01-19 10:12:16 -05:00
Patrik Lundin
e8c328773a Update OpenBSD rcctl handling to use new syntax. 
See http://marc.info/?l=openbsd-cvs&m=142054488027109&w=2
 2015-01-17 12:04:41 +01:00
Tim G
8f43a0a4fe Load distutils on all platforms EXCEPT Solaris. 
Solaris doesn't ship distutils with with the default Python package.  This patch fixes "service" on Solaris since 30d6713.
 2015-01-16 10:06:36 +10:00
Brian Coca
9ac5ed2621 now allows for case in which someone removed the K* links and is trying 
to reenable a service
 2015-01-15 15:53:39 -05:00
Brian Coca
f4a709ad7c simplified update-rc.d enable/disable handling, removed forced defaults 
creation as that breaks local customizations
 2015-01-15 15:32:19 -05:00
Toshio Kuratomi
4c50fbedf4 Merge pull request #632 from mscherer/fix_uneeded_echo 
Do not use echo shell builtin for password
 2015-01-13 23:05:58 -08:00
Tim G
68b5b7be72 distutils is not available on some non-Linux OS's 2015-01-14 13:15:38 +10:00
Michael Scherer
826d313aad Do not use echo shell builtin for password 
Using \t in a password may result in a different password
being set :

    $ echo 'a\ta'
    a   a

Problem report originally found by Pilou-
( https://github.com/ansible/ansible-modules-extras/pull/198 )
 2015-01-12 19:30:07 +01:00
Brian Coca
8c8be0e48c Merge pull request #572 from jrobeson/rename-fedora-hostname-strategy 
[hostname] rename FedoraStratgy to SystemdStrategy
 2015-01-12 10:56:55 -05:00
Toshio Kuratomi
2973bac72f Clarify documented behaviour of user module's ssh_key_file parameter 
Fixes #9873
 2015-01-07 08:46:42 -08:00
Johnny Robeson
50011f13d6 [hostname] rename FedoraStratgy to SystemdStrategy 2014-12-26 00:02:36 -05:00
Jeff Gonzalez
54214f83b5 Added ability to use url as key source 2014-12-22 18:22:31 -06:00
Peter Oliver
18c429d016 Fix appending to a user's group on Solaris 
Without this change, you get:
    AttributeError: 'set' object has no attribute 'extend'

Tested on a Solaris 11.2 client with the included Python 2.6.8.
 2014-12-21 20:05:17 +00:00
Toshio Kuratomi
443951ce82 Merge pull request #524 from zitterbacke/patch-1 
re-enable AIX password setting
 2014-12-16 23:38:38 -08:00
Toshio Kuratomi
67aeab9576 Merge pull request #512 from mscherer/fix_438 
Revert commit cbc417c, as the code is broken, see #438
 2014-12-16 22:46:20 -08:00
Jonathan Mainguy
541070be4c Fixed hostname for rhel5 python 2.4.3 2014-12-16 09:49:13 -05:00
zitterbacke
2e88582165 re-enable AIX password setting 
the AIX class uses a unsafe shell for setting the user password (containing a pipe in the command). This patch adopts to the new behavior of module_utils/basic.py (since somewhere around 1.7).

besides it changes the qoutes for the echo command from double to single, because password-hashes contain $-signs and one would not have this variables expanded.
 2014-12-16 15:10:00 +01:00
Michael Scherer
39cd64ec17 Revert commit cbc417c, as the code is broken, see #438 
LooseVersion expect a string, so filtering to return a int
is incorrect. Thanks to Jeremy Brown for the analysis.
 2014-12-14 21:59:44 +01:00
Toshio Kuratomi
e1f90635af Don't traceback if a gid is specified instead of a group name 
Fixes https://github.com/ansible/ansible/issues/9796
 2014-12-12 12:08:03 -08:00
Patrik Lundin
2acfbf016d Handle string returned by 'default' correctly. 
We need to handle the string returned by 'default' in the same way we handle
the string returned by 'status' since the resulting flags are compared later.
 2014-12-11 23:01:23 +01:00
Brian Coca
ba139b145b fixed hostname for gentoo 2014-12-11 09:05:27 -05:00
Brian Coca
aba9e5e4f9 vastly simplified systemd detection, made enable/disable errors clearer 
both of which allows us to remove 'service name detection' as if systemd
is init we still use it to handle initscripts.
 2014-12-08 08:15:54 -05:00
Brian Coca
df6d58614e now actually adds usable name for systemd when service only has init 
script
 2014-12-05 12:45:01 -05:00
Toshio Kuratomi
5af4463823 Gixes to doc formatting 2014-12-03 08:17:15 -08:00
Toshio Kuratomi
799a75580a Update cron example for setting to run twice a day 
Fixes #415
 2014-12-02 14:38:32 -08:00
Brian Coca
943f8fe7c9 Merge pull request #346 from bcoca/service_cleanup 
service cleanup
 2014-12-02 11:03:03 -05:00
Jonathan Mainguy
a75bef5bc6 Fixes bind mounts 
Fixed tab's and spaces, or so I think I did

Fixed tabs and spaces for real this time
 2014-12-01 21:31:44 -05:00
Achilleas Pipinellis
a375ce33d3 Clarify supported init systems. 2014-12-01 16:15:24 +02:00
Pascal Borreli
32a00ec3a3 Fixed typo 2014-11-28 16:36:21 +01:00
Fabrice Bernhard
1ef8c26c0e Typo in comments 
Credit goes to @kbsali 
@pborreli : you did not see that one? :-)
 2014-11-27 12:36:34 +01:00
Brian Coca
29d211e7ab service cleanup 2014-11-17 22:32:16 -05:00
Brian Coca
f49120598f service now detects systemd is actually running, not just installed 2014-11-17 15:03:49 -05:00
Jonathan Mainguy
8b8008569f fixes user module for rhel5 by using -n instead of -N, all other distros will still use -N 2014-11-17 13:26:08 -05:00
Robert Estelle
4dd099fe7a Remove incorrect executable permissions. 2014-11-13 18:08:48 -05:00
Brian Coca
04680ce228 Merge pull request #286 from bcoca/hostname_24_compatible 
made hostname work with python 2.4
 2014-11-13 12:39:01 -05:00
Patrik Lundin
eea4d06848 Fix typo: Replace "N0" with "NO". 2014-11-13 12:39:29 +01:00
Brian Coca
83669d7eda switched to iterator as per comments 2014-11-11 09:39:03 -05:00
Martijn P. Rijkeboer
5257222f33 Fix whitespace around '=' in sysctl.conf. 2014-11-10 20:00:28 +01:00
Brian Coca
e4b6968901 made hostname work with python 2.4 2014-11-08 12:08:47 -05:00
David Fritzsche
c96a85fb70 Add working status detection for pf on FreeBSD 
The return code of "service pf onestatus" is usually zero on FreeBSD (tested with FreeBSD 10.0), even if pf is not running. So the service module always thinks that pf is running, even when it needs to be started.
 2014-10-31 11:41:51 +01:00
Toshio Kuratomi
7f611468a8 Fix for systemd service scripts with newlines 
Fixes #127
 2014-10-22 16:43:35 -04:00
Patrik Lundin
f9d9c1b6d7 Multiple fixes for OpenBSD rcctl handling. 
* Use the newly added 'default' argument to know if the default flags are set
  or not.
* Handle that 'status' may either return flags or YES/NO.
* Centralize flag handling logic.
* Set action variable after check if we need to keep going.

Big thanks to @ajacoutot for implementing the rcctl 'default' argument.
 2014-10-12 18:41:23 +02:00
Patrik Lundin
e463400412 Simplify self.arguments logic. 
Strange logic pointed out by @jarmani, thanks!
 2014-10-06 21:20:20 +02:00
Patrik Lundin
924cf20cf8 Depend more on rcctl if it is present. 
* Make the module support enable/disable of special services like pf via rcctl.
  Idea and method from @jarmani.
* Make the module handle when the user supplied 'arguments' variable does not
  match the current flags in rc.conf.local.
* Update description now that the code tries to use rcctl for everything if it
  is available.
 2014-10-06 21:20:20 +02:00
Patrik Lundin
5f37624eb4 Tweak error checking for "enabled" code. 
Based on input from @jarmani:
* A return value of 2 now means a service does not exist. Instead of
  trying to handle the different meanings of rc after running "status",
  just look at stderr to know if something failed.
* Skip looking at stdout to make the code cleaner. Any errors should
  turn up on stderr.
 2014-10-06 21:20:20 +02:00
Patrik Lundin
c6dd88c1d1 Fail if "rcctl status" writes to stderr. 2014-10-06 21:20:20 +02:00
Patrik Lundin
1a8cdb5e3e Check rc and print error message if any. 
It is probably good to use stdout before printing a generic error
message as well.
 2014-10-06 21:20:20 +02:00
Patrik Lundin
c46e030100 Make "enabled" code aware of --check mode. 2014-10-06 21:20:20 +02:00
Jonathan Armani
1b97390765 Add enable / disable of services for OpenBSD if rcctl is present 2014-10-06 21:20:20 +02:00
billwanjohi
ff36edbb11 user: add expired state 
ported from
https://github.com/ansible/ansible/pull/6303

It's very useful and routine to disable a *nix user.
I implemented expired instead of locked because this prevents any use of
the account, safer than just preventing password-based authentication.

I have tests [1], but since none of the suite came along with the core
modules, I'm unsure how to submit them.

[1] https://github.com/billwanjohi/ansible/blob/add_locked_state/test/integration/roles/test_user/tasks/main.yml
 2014-09-29 22:42:28 +00:00
kustodian
82af074382 Set selinux state to 'permissive' for state=disabled 2014-09-30 00:33:55 +02:00
Michael Scherer
37d9903169 Add hostname to generated user SSH key comment 
The default is not very useful to sort between different
keys and user. Adding the hostname in the comment permit to later
sort them if you start to reuse the key and set them in different
servers. See https://github.com/ansible/ansible/pull/7420
for the rational.
 2014-09-29 18:07:41 -04:00
Michael DeHaan
385a037cd6 package files 2014-09-26 11:05:47 -04:00
Michael DeHaan
c8e1a2077e file extensions! 2014-09-26 10:37:56 -04:00
Michael DeHaan
417309a626 Restructuring. 2014-09-26 10:13:26 -04:00
Michael DeHaan
73123b69fa Move modules into subdirectory. 2014-09-26 09:23:50 -04:00
Toshio Kuratomi
8b81062be0 The fix for gh-7284 causes problems for initscripts which have the 
standards compliant return codes but return a verbose error message via
stdout.  Limit the times when we invoke the heuristic to attempt to work
around this.
 2014-09-22 14:53:07 -04:00
Michael Scherer
c9a0a7ae4b Fix #9704, correctly set changed as false when nothing is done 2014-09-21 14:55:31 +02:00
Toshio Kuratomi
7b100dd389 Be more specific in checking if a job restarted successfully. 
Fixes: #9056
 2014-09-19 12:03:27 -07:00
Toshio Kuratomi
36083c3b90 Failure to enable a service now fails the task 
Fixes: 8855
 2014-09-18 12:39:54 -07:00
Toshio Kuratomi
a50258d26a remove debugging that was causing failure 2014-09-17 10:25:54 -07:00
Toshio Kuratomi
2e16bd3a44 Refactor the Linux service_enable() method 
* Fix check_mode for initctl systems

Fixes #9009
 2014-09-17 09:34:33 -07:00
Toshio Kuratomi
104401805b Revert "Refactor the Linux service_enable() method" needs some debugging 
This reverts commit e294e31fd3.
 2014-09-17 09:17:33 -07:00
Toshio Kuratomi
c362902f50 Refactor the Linux service_enable() method 
* Fix check_mode for initctl systems

Fixes #9009
 2014-09-17 08:44:32 -07:00
Toshio Kuratomi
a9928492f7 Make systemd vs rht detection more robust for centos 
Centos 6.x and below use an old RHT style of configuring hostname.
CentOS 7.x and better use systemd.  Instead of depending on the
distribution string which seems to have changed over the course of 6.x
we need to explicitly check the version.

Fixes #8997
 2014-09-16 09:53:13 -07:00
James Cammarata
7edcf21bdc Move initscript rc check to later in service status check 
Fixes #7284
 2014-09-11 12:11:06 -05:00
Michael DeHaan
5aa6ddef7f Tracebacks are now catchable with ignore_errors and have streamlined output. Also removes 'baby-JSON' for bash modules. 2014-09-11 12:27:21 -04:00
Patrik Lundin
0abf14ff19 service: use self.changed in service_enable_rcconf(). 
This sets the "changed" result of the module when a rc file is modified.
Previously only --check mode would show that it was going to change.
 2014-08-28 00:52:23 +02:00
James Cammarata
30d6713bf0 Add additional checks to detect upstart services 
Also adds checks for the upstart version, in order to test check
support for manual vs. start on manual
 2014-08-25 13:41:39 -05:00
Eri Bastos
6f8a29dc3d Proposed fix for issue #7757 2014-08-25 12:10:14 -05:00
James Cammarata
c8376e296f Tweaking change to documentation language for cron name param 2014-08-25 09:54:21 -05:00
James Cammarata
509761249c Merge branch 'devel' of https://github.com/mattparker/ansible into mattparker-devel 2014-08-25 09:51:17 -05:00
James Cammarata
07e77c5bed Merge pull request #8740 from mattparker/patch-1 
Name appears to be a required parameter for cron module
 2014-08-25 09:49:58 -05:00
James Cammarata
1f2727c607 Merge pull request #8729 from ercpe/openrc-hostname 
Hostname strategy implementation for OpenRC based systems (e.g. Gentoo)
 2014-08-25 09:28:29 -05:00
Matt Parker
6086c505fe Update cron documenation 
The "name" parameter seems to be rather important as the identifying feature of a cron job.  This is an update to the documentation to further emphasize this.
 2014-08-25 10:29:45 +01:00
Matt Parker
5accd15ba6 Name appears to be a required parameter 
As far as I can tell, `name` is a required parameter.  The guard test at (now) line 458 says you need name if `state == present` and at 464 if `state != present`, although that's not quite as clear.  Each of the code paths at 485 - 495 pass the name param through to `add_job`, `update_job` and `remove_job`, and the actual _update_job method earlier seems to require it too.  However I don't really know python so I may be wrong, but I can't see the circumstances when `name` is not required.
 2014-08-25 10:23:54 +01:00
Johann Schmitz
7ef67e3f8b Hostname strategy implementation for OpenRC based systems (e.g. Gentoo) 2014-08-23 09:00:28 +02:00
Ding Deng
85c6434262 debconf module: add the missing 'error' vtype and reorder vtypes as they appeared in debconf-devel(7). 2014-08-19 17:44:02 +08:00
Michael DeHaan
60ce2d3853 Fix documentation builds. 2014-08-08 15:12:10 -04:00
Michael DeHaan
f21d6c7980 Merge pull request #8002 from prune998/patch-2 
added missing force flag on mkfs commandline
 2014-08-08 13:55:19 -04:00
Michael DeHaan
185d5a6221 Merge branch 'spelling' of git://github.com/cgar/ansible into devel 
Conflicts:
	docsite/rst/guide_rax.rst
	plugins/callbacks/mail.py
 2014-08-08 13:28:45 -04:00
Michael DeHaan
66ec9089bd Update docs. 2014-08-08 11:51:27 -04:00
Michael DeHaan
f6f184b36d Updating docs. 2014-08-08 11:51:27 -04:00
Brian Coca
aeeefd046f bumped to 1.7 2014-08-08 11:51:27 -04:00
Brian Coca
5aa2ca762a added control to fail or not on missing key 
made split 'smarter' but still overridable
 2014-08-08 11:51:27 -04:00
Brian Coca
391f8ec600 added getent module to get system data as facts 2014-08-08 11:51:27 -04:00
Serge van Ginderachter
961d4b0d6c execute the mount after path validation 
This avoids a stale situation where name/path contains some impossible path,
but gets configured (faultly) in fstab, and the module only fails after that,
when creating that path.
 2014-08-06 10:52:08 +02:00
Jonathan Mainguy
650003dd5c Fixes issue #8339 where Scientific Linux incorrectly tries to use FedoraStrategy of hostnamectl 2014-08-02 15:38:52 -04:00
Michael DeHaan
e978dcf7eb Merge pull request #8283 from ps-jay/sys_mount_fstype_doc 
Add fstype arg to the mount examples
 2014-07-30 08:28:59 -04:00
Michael DeHaan
bc01f2571e Merge pull request #8311 from neersighted/wrap_distroversion 
Wrap get_distribution_version() in the hostname module
 2014-07-28 15:48:18 -04:00
Michael DeHaan
2212b64fd9 Cleaning up explanation of mount module states. 2014-07-28 12:18:45 -04:00
Bjorn Neergaard
cbc417ca1b Wrap get_distribution_version() in the hostname module 
We wrap get_distribution_version() with a new function,
_get_distribution_version(), that returns `0` when the result is a string or
`None`.

This accounts for the case when get_distribution_version() returns a string,
and we try to compare it to a float. We do this in the hostname module instead
of the module snippets because other modules may want the real string
version.module snippets because other modules may want the real string version.
 2014-07-28 11:16:30 -05:00
Michael DeHaan
99ad691950 Merge branch 'ufw' of git://github.com/Trozz/ansible into devel 2014-07-28 12:08:29 -04:00
Michael DeHaan
caba7ac6a6 Merge pull request #7954 from alimony/patch-3 
cron module: Use correct parameter name in error message.
 2014-07-28 11:29:05 -04:00