cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity
7246 commits 47 branches 390 tags 440 MiB
Commit graph

7246 commits

This branch
This branch
All branches
Author SHA1 Message Date
Matt Martz
32bdecef9a Merge pull request #1060 from sivel/open-iscsi-examples 
Fix open_iscsi EXAMPLES section
 2015-10-06 06:29:25 -05:00
Dreamcat4
dcaa794949 fix: update documentation with new module name "win_firewall_rule" 2015-10-06 10:47:27 +01:00
Dreamcat4
469d22df97 fix: The names of firewall profiles are different on win10 & win2008r2 
Hi again. This commit removes a small portion of your script's own internal error checking. In specific: for the value of the profile: key. This is essential to avoid errors on other verisons of the windows operating system which are not win2008r2 (your version).

For example: on win10 (and most likely win8x too), the names of the profiles don't include the values 'current' and 'all'. But instead the values are 'Public' 'Private' 'Domain' and 'Any. But in addition, there are also certain combinatorial values, such as profile=Public,Private etc. Which is too many to error check yourself.

Yet removing the error checking here should not cause any ill effects however: since the netsh advfirewall ... cmds themselves to add / remove / modify actually to their own error checking of the profile=value. So when the cmd is run, it will error out itself with an appropriate / informative error msg. No harm done.

Therefore please remove the highlighed portions from your own script. It is essential for interoperability with win10 and win8x. Many thanks.
 2015-10-05 21:53:11 +01:00
Dreamcat4
6c5a4a14ef fix: win10 - Add exception handling for 'Profiles:' textual output key name mismatch. 
In win10 (and pribably win8x also):

The output of 'show rule' key includes the line "Profiles:<TAB>Public,Private".
Yet your script expects the key name printed out to be "Profile:<TAB>value".

This commit added the necessary exception handling to avoid flagging 'different=true' under the false circumstance. The key name to SET a firewall rule is still "profile=" and not "profiles=".

There is coming up another commit to fix the value handling for win10/win8. Which is another (different) error with the profile: key.
 2015-10-05 21:36:24 +01:00
Dreamcat4
2654789af7 fix: fw rule names must always be quoted, to permit spaces ' ' and brackets '()' 
Without this fix, the 'netsh' command gets name=Firewall Rule Name instead of name="Firewall Rule Name". Thus causing all sorts of havoc. Basic shell quoting rules seems to apply to Windows Powershell too. This is very much needed as many of windows 10's default firewall rules contain spaces and brackets () characters.
 2015-10-05 21:10:59 +01:00
Matt Martz
9d015665b8 Fix open_iscsi EXAMPLES section 2015-10-05 13:34:42 -05:00
Matt Martz
e68d9315c1 sys.exit removal for system/capabilities.py 2015-10-05 13:24:25 -05:00
Matt Martz
eac4493421 sys.exit removal for notification/mail.py 2015-10-05 13:23:34 -05:00
Matt Martz
abf7ee579e sys.exit removal for cloud/google/gce_img.py and cloud/google/gce_tag.py 2015-10-05 13:23:00 -05:00
Matt Martz
55dab7cd1b sys.exit removal for cloud/misc/ovirt.py 2015-10-05 13:22:43 -05:00
Matt Martz
b82ebdde19 sys.exit removal for cloud/xenserver_facts.py 2015-10-05 13:22:32 -05:00
Matt Martz
d89ca8cc01 Merge pull request #1058 from sivel/xenserver-imports 
Switch from old style replacer code to new style for ansible.module_utils.basic
 2015-10-05 13:07:03 -05:00
Matt Martz
1b0f9d5fd9 Merge pull request #1057 from sivel/fix-vmware-interpreter 
Fix interpreter line in a few vmware modules
 2015-10-05 13:05:54 -05:00
Matt Martz
6732181a39 Switch from old style replacer code to new style for ansible.module_utils.basic 2015-10-05 12:58:47 -05:00
Matt Martz
1a76f4cc22 Fix interpreter line in a few vmware modules 2015-10-05 12:55:39 -05:00
Brian Coca
432ca0fa99 Merge pull request #1056 from rickmendes/add-gpl-to-winpass 
added missing license

Thanks!
 2015-10-05 13:32:07 -04:00
Rick Mendes
2cc18b8780 added missing license 2015-10-05 10:29:25 -07:00
Charles Paul
f4be5c6382 allow floating point input for size vale 2015-10-05 12:16:29 -05:00
Brian Coca
ebbd7748b1 doc formatting fixes 2015-10-05 11:57:38 -04:00
Toshio Kuratomi
da426da308 Change documented requirement from dnf to python-dnf as dnf could be taken to mean the command line tool. 
Fixes #1032
 2015-10-04 21:32:54 -07:00
Indrajit Raychaudhuri
02c17c023a homebrew: Also add 'formula' as alias for 'name' and reformat 2015-10-04 22:14:41 -05:00
Indrajit Raychaudhuri
791967485b homebrew: Improve 'argument_spec' handling 
- Remove choice list for boolean values in argument_spec and make it
  more consistent with core modules
- Add 'package' alias and support for list type for 'name' parameter
- Added self as maintainer
 2015-10-04 22:12:03 -05:00
Brian Coca
02b68be09d Merge pull request #854 from nitzmahone/win_updates_rewrite 
win_updates rewrite for 2.0
 2015-10-04 14:45:57 -04:00
Brian Coca
9f5420e459 Merge pull request #1047 from bcoca/use_common_logging 
switched to use module loggigng
 2015-10-02 01:38:03 -04:00
Brian Coca
5eff47c6f1 changed use_sudo to system_lib (kept alias) and expanded description to explain how it works 2015-10-01 19:59:51 -04:00
Brian Coca
e768a98bf3 Merge pull request #1017 from milad-soufastai/devel 
Adding the --sudo flag for CPANM use since the sudo: yes on the task …
 2015-10-01 19:52:54 -04:00
Brian Coca
baf32cedd1 Merge pull request #1049 from trondhindenes/#984 
win_package bugfix
 2015-10-01 15:04:38 -04:00
Trond Hindenes
7c48fe617d added module author 2015-10-01 19:12:21 +02:00
Matt Martz
70883852ed Merge pull request #1048 from sivel/znode-py26 
znode requires a minimum of python2.6
 2015-10-01 12:09:59 -05:00
Trond Hindenes
161b3cf1e1 fixes #984 2015-10-01 19:08:42 +02:00
Matt Martz
e6b6bac820 znode requires a minimum of python2.6 2015-10-01 12:07:43 -05:00
Matt Martz
5b8c2237a7 Merge pull request #1045 from mjschultz/sns-baby-json 
sns: remove BabyJSON
 2015-10-01 12:01:45 -05:00
Brian Coca
3564c48f3c switched to use module loggigng 2015-10-01 00:29:57 -04:00
Toshio Kuratomi
962afeed54 Make the znode module a valid ansible module 2015-09-30 19:57:29 -07:00
Toshio Kuratomi
255666a09d Fix doc build 2015-09-30 19:57:20 -07:00
Michael J. Schultz
c61d430191 sns: remove BabyJSON 2015-09-30 15:50:44 -05:00
Greg DeKoenigsberg
b69362647a Merge pull request #1011 from resmo/feature/args_specs 
cloudstack: implement common argument spec handling
 2015-09-30 16:47:19 -04:00
Greg DeKoenigsberg
beb362dd11 Merge pull request #633 from loia/feature/aws_sqs 
Add new Amazon SQS module
 2015-09-30 16:45:33 -04:00
Greg DeKoenigsberg
a4c2928712 Merge pull request #783 from wimnat/feature/ec2_vpc_subnet_facts 
New module - ec2_vpc_subnet_facts
 2015-09-30 16:43:54 -04:00
Greg DeKoenigsberg
8221a651d8 Merge pull request #1009 from ToBeReplaced/dnf-exit-json 
Fix fail_json call in _mark_package_install
 2015-09-30 16:39:53 -04:00
Greg DeKoenigsberg
750754f0d9 Merge pull request #976 from kovacsbalu/fix-push_type 
Use push_type and send link with push_link.
 2015-09-30 16:37:25 -04:00
Greg DeKoenigsberg
9447bf9c6f Merge pull request #1008 from privateip/vca_vapp 
cleaned up vca_vapp module to focus on managing vapps
 2015-09-30 16:34:48 -04:00
Greg DeKoenigsberg
2e588d8fc5 Merge pull request #1014 from resmo/for_ansible 
cloudstack: fix redundant security_group return
 2015-09-30 16:30:40 -04:00
Greg DeKoenigsberg
ed2708827d Merge pull request #963 from sgzijl/391-append-missing-dot 
issue #931 append dot to zone if not defined
 2015-09-30 16:29:05 -04:00
Greg DeKoenigsberg
22a3ec05e4 Merge pull request #1022 from trondhindenes/trondhindenes_win_chocolatey_improvements 
win_chocolatey bugfixes
 2015-09-30 16:26:45 -04:00
Greg DeKoenigsberg
d9b801a4c2 Merge pull request #965 from resmo/fix/composer 
composer: implemented smarter arguments per command handling
 2015-09-30 16:25:04 -04:00
Greg DeKoenigsberg
8e9299653a Merge pull request #1018 from indrajitr/pacman-checkmode-fixes 
Additional upgrade mode fixes for pacman module with check_mode safety
 2015-09-30 16:23:18 -04:00
Greg DeKoenigsberg
5931e60d99 Merge pull request #695 from georgefrank/win_nssm 
Adding win_nssm module
 2015-09-30 16:15:36 -04:00
Greg DeKoenigsberg
ff0a38ea65 Merge pull request #665 from perzizzle/scheduledTask 
Ability to add/remove scheduled task
 2015-09-30 16:11:45 -04:00
Shawn Siefkas
6186da08ef Check mode support for VPC route table creation 2015-09-30 11:00:36 -05:00