James Cassell
1bb94ec92f
service_mgr: detect systemd, even offline ( #66071 )
...
* service_mgr: detect systemd, even offline
* service_mgr=systemd iff /sbin/init is symlink
2020-02-04 17:32:36 -05:00
GomathiselviS
4ac89b8ac7
Added Fix - Allow nxos_l2_interfaces to append the allowed vlans list ( #66517 )
...
* Added Integration tests
* Corrected lint errors
* Added fix for bug # 54400
* Revert "Added fix for bug # 54400"
This reverts commit bf42db4269dafdd92d43129dc87682#66517
* Removed unnecessary commit
* fixing conflicts
* fixing conflicts
* addressed mikeweibe's comments
* Corrected lint errors
* Added idempotent tc for add vlans
* Added replaced and overridded tcs for trunk vlan add
2020-02-04 15:14:04 -05:00
James Cassell
fd954a9c5c
wait_for_connection: also retry interpreter discovery ( #67040 )
...
self._discovered_interpreter_key is None unless a previous iteration
has attempted discovery. In that case, force re-discovery, as the
previous attempt certainly failed.
2020-02-04 11:40:09 -08:00
tavery321
994a6b0c5a
fixes ANSIBLE_DUPLICATE_YAML_DICT_KEY=error crashes ( #66786 )
...
* Fix #65366
2020-02-04 13:53:13 -05:00
Erwin Oegema
3b32f95fb3
user - warn if "append" is set but not "groups" ( #65795 )
...
This fixes people unknowingly changing the primary group rather than adding a secondary group.
* Add integration test
2020-02-04 12:35:05 -05:00
Felix Fontein
fe454d27a1
Fix removed_in_version to support honor suboptions ( #66918 )
...
* Add unit tests.
* Fix reporting for removed_in_version.
* Add changelog.
2020-02-04 10:14:55 -05:00
Felix Fontein
28b2428d22
docker_container: fix port order in docs ( #67071 )
...
* Fix port order.
* Forgot to remove random.
2020-02-04 10:05:53 +01:00
Felix Wong
8b2ead5870
add jittered backoff for elb ( #66673 )
2020-02-04 08:57:26 +01:00
Brian Scholer
fc7980af9a
Fix UNC path support in the powershell shell plugin ( #66604 )
...
* Fix UNC path joining in the powershell shell plugin, add test
* Remove testy bits and a redundant line
* Fix style nits
* Update to use os.ntpath
* Add changelog for #66604
2020-02-04 16:34:11 +10:00
AirCombat
81378b3e74
Added -LogPath param from Install-ADDSForest to win_domain module ( #66956 )
...
* Added omitted logpath parameter to win_domain
The Install-ADDSForest -LogPath param seems to have been omitted in the win_domain module. We do not use this module organisation-wide as its non trivial to change the log patch once AD is set up. I will also update docs
* Removed trailing whitespace
* Added logpath option to win_domain module docs
2020-02-04 14:52:24 +10:00
Jordan Borean
6d792838e4
Move url option from util to individual modules ( #67068 )
2020-02-04 10:43:33 +10:00
Felix Fontein
23b2bb4f4d
docker_container: change behavior for one-port container ranges to be same as docker CLI ( #66382 )
...
* Adjust docker_container behavior for one-port container ranges to be similar to docker CLI.
* Add changelog.
* Add documented examples for ports:.
2020-02-03 23:27:40 +01:00
Andrew Klychkov
21ae66db2e
postgresql_user_obj_stat_info: new module ( #66892 )
...
* postgresql_user_obj_stat_info: new module
* fix sanity
* add schema parameter
* add CI tests
* add RETURN section
* add example with schema
* fix CI
* fix example comments
* skip aix
* fixes part 1
* fixes part 2
* fix CI
* fix CI
* fix doc formatting
2020-02-03 23:06:31 +01:00
Felix Fontein
5c1a3a3ac2
docker_container and docker_swarm_service: allow to actually disable healthcheck of image ( #66599 )
...
* Allow to actually disable healthcheck of image.
* Add changelog.
2020-02-03 13:13:17 -05:00
unixsysadmin
ea105dcb2f
Update template.py ( #67010 )
...
Update the example so that the task name matches the filename being updated
The first example shows how you might template a file to destination /etc/file.conf. The description of this task appears to have a typo as it refers to '/etc/files.conf' rather than '/etc/file.conf'
2020-02-03 12:28:55 -05:00
Gregor Riepl
f49408287a
Document difference between ec2 and ec2_instance modules ( #67009 )
...
Co-Authored-By: Mark Chappell <mchappel@redhat.com>
2020-02-03 12:12:13 -05:00
Martin Nečas
fad261b04f
ovirt_job: add when job is detected but in state finished ( #66810 )
...
* ovirt_job: add when job is detected but in state finished
* add docs
2020-02-03 09:21:10 -05:00
Nathaniel Case
53c7f8cbde
Allow httpapi for EOS resource modules ( #66871 )
...
* Redo tests to be transport agnostic
cli -> eos config
* Redirect connection for httpapi
* Fix tests
* Handle missing platform imports
2020-02-03 08:04:08 -05:00
Felix Fontein
a0e5e2e4c5
openssl_publickey: forgot to pass backend ( #67036 )
...
* Forgot to pass backend.
* Add changelog.
* Pass on backend from get_fingerprint.
* Handle cryptography backend in get_fingerprint.
2020-02-03 06:18:19 +01:00
Simon Dodsley
b1a8bded3f
Remove deprecated parameter for 2.10 in purefb_fs ( #67026 )
2020-02-02 15:30:01 +01:00
Felix Fontein
8f10db8552
Do fail instead of regenerate for password protected and invalid keys. ( #65638 )
2020-02-02 07:54:28 -05:00
Felix Fontein
d6fb9da8ed
openssl_* modules: allow direct input and output for some files ( #65400 )
...
* Allow to return generated object.
* Use slurp module instead of file lookup + b64encode.
* Rename return_xxx_content -> return_content.
2020-02-02 12:42:52 +01:00
Evert Mulder
4d345813ea
Group ids are strings now ( #66939 )
2020-02-02 04:57:23 -05:00
Klaus Frank
14b1febf64
Fix pacman: "IndexError: list index out of range" #63077 ( #65750 )
...
* Fix #63077
If the package is already installed the stdout is not as expected by this function. Either remove `--needed` or just noop if we detect pacman returning. We cannot match the stdout string, as that is most likely localized.
```
[root@archBook user]# /usr/bin/pacman --upgrade --noconfirm --noprogressbar --needed /srv/aur/src/i3cat-git/i3cat-git-r38.c6d29dd-1-x86_64.pkg.tar.xz
loading packages...
warning: i3cat-git-r38.c6d29dd-1 is up to date -- skipping
there is nothing to do
```
* Add comment
Add comment
* Add changelog fragment.
Co-authored-by: Felix Fontein <felix@fontein.de>
2020-02-01 14:37:27 +01:00
Andrew Klychkov
3baea92ec9
Bugfix of 54239: mysql_variables not supporting variables name with dot ( #66806 )
...
* Bugfix of 54239: mysql_variables not supporting variables name with dot
* add changelog
* add CI tests
2020-02-01 12:39:52 +05:30
Toshio Kuratomi
f5e194cbcd
Move random_mac into its own file ( #67000 )
...
* Move random_mac into its own file
This is likely to be the only filter which is not included in
ansible-base. So it needs to be in its own file.
2020-01-31 14:33:16 -08:00
Rotaru Sergey
ef1fd19c00
croc cloud - ec2 key patch ( #60929 )
...
This patch fixes "IndexError: list index out of range" error for https://console.cloud.croc.ru .
When key pair is new, croc return dict with an empty list for key KeyPairs that causes ansible to crush.
2020-01-31 17:20:58 -05:00
Mark Chappell
919a9e33e8
Minor AWS argument checks (required_if / mutually_exclusive) fixups ( #66966 )
...
* aws_netapp_cvs_snapshots - minor required_if fixup (state must be set if state=present)
* ec2 - fix typo in mutually_exclusive definition
* rds_instance: fix typo in mutually_exclusive restore_to_time should be restore_time - currently throws a boto error
2020-01-31 22:17:46 +01:00
Simon Dodsley
26175178ee
Fix user_agent string not getting set ( #66914 )
2020-01-31 15:50:53 -05:00
Sam Doran
9db0fb785d
Add collections path option to ansible-galaxy ( #66969 )
...
Some common code needed for 'collection list' and 'collection validate'
2020-01-31 14:27:54 -06:00
Andrew Klychkov
16ebeda86d
Bugfix of 66974: mysql_user doesnt support privileges with underscore ( #66995 )
...
* Bugfix of 66974: mysql_user doesnt support privileges with underscore
* add changelog
* add seealso
2020-01-31 20:44:03 +01:00
Stefan Horning
aad286b403
Make cloudfront_info work with Python3 … ( #66695 )
...
* Make cloudfront_info work with Python3 by using dict.update(dict) instead of dict += dict.
* Added changelog fragment for cloudfront_info fix
2020-01-31 14:37:36 -05:00
Nathaniel Case
3dbc03d58a
Try to load action plugin from the same collection as the module ( #66701 )
...
* Try to load network action plugin from the same collection as the module
* Alter tests to match
Just make sure the action plugin is as qualified as the module it is paired with
2020-01-31 12:49:37 -05:00
Petr Mikusek
725bb4d173
Fix typo in shell_windows.py ( #66964 )
2020-01-31 11:48:28 -05:00
Andrew Klychkov
54520c4685
mysql_user: priv parameter can also be a dictionary ( #66801 )
...
* mysql_user: add priv_dict parameter
* add changelog
* priv can be string or dictionary
* fix example
2020-01-31 16:32:31 +01:00
Mark Chappell
813091cf94
Migrate ec2_vol_info to AnsibleAWSModule ( #66979 )
...
* Migrate ec2_vol_info to AnsibleAWSModule
* Enable ec2_vol_info tests
* Add changelog
* Update lib/ansible/modules/cloud/amazon/ec2_vol_info.py
Co-Authored-By: Sloane Hertel <shertel@redhat.com>
2020-01-31 09:55:10 -05:00
Felix Fontein
f1a30164c5
Fix 'container_default_behavior: no_defaults'. ( #66601 )
2020-01-31 10:45:59 +01:00
Jordan Borean
2a9ec8975f
win_unzip - LiteralPath fix ( #66972 )
...
* win_unzip - LiteralPath fix
* Fix up Python sanity issues
2020-01-31 12:59:46 +10:00
Jordan Borean
811c54a7a4
validate-modules - support deprecated_aliases ( #66965 )
...
* validate-modules - support deprecated_aliases
* Removed changelog fragment
2020-01-31 07:35:16 +10:00
Sam Doran
5112feeace
Make get_bin_path() always raise an exception ( #56813 )
...
This makes it behave in a more idiomatic way
* Fix bug in Darwin facts for free memory
If the vm_stat command is not found, fact gathering would fail with an unhelpful
error message. Handle this gracefully and return a default value for free memory.
* Add unit tests
2020-01-30 12:54:25 -05:00
Andrew Klychkov
c9a34ae33e
mysql modules: fix the module's documentation ( #66848 )
2020-01-30 11:44:47 -05:00
Paul Belanger
adf73d47ec
Remove unused imports from paramiko_ssh connection ( #66948 )
...
These were caught by flake8 testing for ansible.netcommon collection.
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2020-01-30 11:01:34 -05:00
Nathaniel Case
bf65e7a3f6
nxos_facts: Don't fail if faninfo isn't reported ( #66866 )
2020-01-30 10:23:21 -05:00
sky-joker
72e1716f29
Fix to gather facts include macro and tag ( #66947 )
2020-01-30 10:07:40 -05:00
Dusan Matejka
e3190adcbb
zabbix_host - added support for usermacros and tags ( #66777 )
2020-01-30 08:32:47 -05:00
Felix Fontein
5fdc9a61f0
docker_container: pass volumes only for anonymous volumes ( #66600 )
...
* Simplify code.
* Only pass anonymous volumes.
* Add changelog and update porting guide.
* Add integration tests.
2020-01-30 14:08:25 +01:00
Dusan Matejka
57805b7def
zabbix_proxy interface option documentation and argspec fixes ( #66837 )
...
* zabbix_proxy interface option documentation and argspec fixes
* Update changelogs/fragments/66837-zabbix-proxy-interface.yml
Co-Authored-By: Felix Fontein <felix@fontein.de>
Co-authored-by: Felix Fontein <felix@fontein.de>
2020-01-30 14:06:44 +01:00
fraff
553997db25
Add new module cloud/ovh/ovh_monthly_billing.py ( #65730 )
...
remove useless 'state' parameter and update doc
remove useless module.params.get('state')
Update lib/ansible/modules/cloud/ovh/ovh_monthly_billing.py
Co-Authored-By: Abhijeet Kasurde <akasurde@redhat.com>
Update lib/ansible/modules/cloud/ovh/ovh_monthly_billing.py
Co-Authored-By: Abhijeet Kasurde <akasurde@redhat.com>
Update lib/ansible/modules/cloud/ovh/ovh_monthly_billing.py
Co-Authored-By: Abhijeet Kasurde <akasurde@redhat.com>
Update lib/ansible/modules/cloud/ovh/ovh_monthly_billing.py
Co-Authored-By: Abhijeet Kasurde <akasurde@redhat.com>
Update lib/ansible/modules/cloud/ovh/ovh_monthly_billing.py
Update lib/ansible/modules/cloud/ovh/ovh_monthly_billing.py
Update lib/ansible/modules/cloud/ovh/ovh_monthly_billing.py
Update lib/ansible/modules/cloud/ovh/ovh_monthly_billing.py
add application_key, application_secret and consumer_key optional parameters
Add some example concerning ovh auth.
2020-01-30 12:16:11 +01:00
rule88
6a1f82f174
url lookup - add options to match those in urls.py ( #64892 )
...
Add 'force_basic_auth' option
By default "force_basic_auth" option is set to False, with this adjustment it is up to the user if it wants to enforce basic authentication.
2020-01-29 16:45:25 -05:00
Jiri Hnidek
6f1bb37feb
When no pool quantity is set, then do not set quantity to 1 ( #66807 )
...
* Fixes #66478
* When no quantity is set, then candlepin server usually uses
default value 1. When more quantities are required, then
candlepin server can automatically choose correct minimal
value.
2020-01-29 12:10:47 -05:00
