Commit graph

4001 commits

Author SHA1 Message Date
Ruben-Bosch
5549788c8d win_updates: Add flag to only download updates without installing them (#58631)
* win_updates: Add flag to only download updates without installing them

* Fix test

* Fixes ansible-test (pep8)

* Fix integration test

* Fix actual fix.
2019-08-28 09:46:59 +10:00
Shachaf92
03bbba4a9f win modules - standarize regex and regxp as alias (#59037)
* win modules - standarize regex  and regxp as alias

* Changes to reflect desired state

* Update parameter names of funtions

* Update main.yml

* Update win_lineinfile.py

* Update win_wait_for.py
2019-08-28 09:38:23 +10:00
Jordan Borean
66f52b74b1 Change collection PS util import pattern (#61307)
* Change collection PS util import pattern

* Add changes for py2 compat

* fix up regex and doc errors

* fix up import analysis

* Sanity fix for 2.6 CI workers

* Get collection util path for coverage collection
2019-08-27 16:02:27 -07:00
Brian Scholer
eaa6848932 Allow password to be null in Scheduled Task for gMSA (#60990)
* Allow password to be null in Scheduled Task for gMSA

* Remove test for removed password validation, linting fixes
2019-08-28 08:44:45 +10:00
Yuwei Zhou
41778a8e12 Add azure resource lock module (#55700)
* add locks

* rename the module

* add test

* add test

* address comments

* add quote

* can list child scope lock

* minor docs tweaks

* Add files via upload (#62)

* change '\r\n' to '\n' (#63)

* Small changes, just to trigger CI verify.

* trigger CI verify

* remove 's'

* Update according by comments

* change small for trigger CI check
2019-08-28 05:35:12 +08:00
smile37773
31a1eadab2 Add the azure_rm_azurefirewall_info module (#58697)
* add the info module of azure firewall

* fix the format_item()

* add the test

* fix the indented line

* fix

* fix the test

* change the test file
2019-08-28 05:23:29 +08:00
Jordan Borean
faaa669764
PowerShell - Added coverage collector (#59009)
* Added coverage collection for PowerShell - ci_complete ci_coverage

* uncomment out coverage uploader call

* Generate XML for PowerShell coverage

* Use whitelist to exclude coverage run on non content plugins

* Remove uneeded ignore entry

* Try to reduce diff in cover.py

* Fix up coverage report package - ci_complete ci_coverage
2019-08-28 07:03:23 +10:00
smile37773
5438013191 Rename Azure modules: facts -> info (#60987) 2019-08-28 04:44:57 +08:00
Felix Fontein
e176023c6b Scaleway: rename _facts -> _info (#61095)
* Rename scaleway _facts -> _info

* Add changelog.

* Improve docs.
2019-08-27 16:39:24 -04:00
Sam Doran
32eeeab831
Revert "Disable Hetzner Cloud integration tests due to authentication issues (#61375)" (#61383)
This reverts commit 31b49334b9.
2019-08-27 15:30:28 -04:00
Nilashish Chakraborty
36f4af203c
Add iosxr_lag_interfaces resource module (#61303)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-08-27 23:01:05 +05:30
Strahinja Kustudic
a213b9160c Fix extended loop_control with includes (#61231)
* Fix extended loop_control with includes

* Use assert for testing extended loop_control

* fix typo
2019-08-27 12:09:56 -05:00
ygelfand
36b7baca4d getent - add service support(#60295) 2019-08-27 11:58:37 -04:00
Gonéri Le Bouder
d29aaffb16 vmware_guest_disk_info/test: ensure the test VM is running
`vmware_guest_disk_info` expects the VM to be running. Since
964783fbd2, `prepare_vmware_tests`
creates the test VM with the `powered-off` state. This to increase
the performance.

This commit ensures the test-suite actually run against a running VM,
as expected.
2019-08-27 11:31:14 -04:00
Gonéri Le Bouder
ef69f3a3b5 vmware/test: clean up dvswitch_0001 and dvswitch_0002
Ensure `dvswitch_0001` and `dvswitch_0002` won't remain after
`vmware_dvswitch` test execution.
2019-08-27 11:30:44 -04:00
Sam Doran
31b49334b9
Disable Hetzner Cloud integration tests due to authentication issues (#61375) 2019-08-27 10:47:08 -04:00
jasonjuenger
dfd1b29777 Add aci_vmm_credential.py (#60910)
* add module to create aci VMM credential objects
add initial remove and add integration tests for VMM credential objects

* update 'credential' var name to 'name'

* move vmware tests to domain type specific file

* move vmware tests to domain type specific file
add include task in main file to reference domain type specific tests

* update task names
add test to remove credential prior to first credential add
add tests for querying individual credentials
add tests for query all credentials
add additional tests for removing credentials

* update version added to 2.9
remove invalid module references from 'seealso' section

* fix list reference in query all assertions

* add reference to VM_PROVIDER_MAPPING keys for vm_provider arg
2019-08-27 14:08:24 +02:00
Sumit Jaiswal
b53bc94cc5
Resource module for iosxr_l2_interfaces (#59964)
* iosxr_l2 resource
2019-08-27 17:20:47 +05:30
Adharsh Srivats R
ee05d6bde2 Added nxos_lldp_global resource module (#60072)
* Added nxos_lldp_global module

Tests

Correction

remove q

* Added tests

* Corrections

Changes

Last few changes please

Final

Finall

Finalll

* Key error and punctuation changes

* .gitignore edit

* Facts file edit

* Changed facts collection and 'replaced' state

Changed facts collection and replaced state

Changed facts collection and replaced state

* Spacing and module error correction

* return facts as empty dict not list

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2019-08-27 14:52:24 +05:30
Ganesh Nalawade
2a13ad7adf
Fix junos resource modules group based config and minor updates (#61224)
* Fix junos resource modules group based config and minor updates

Fixes https://github.com/ansible/ansible/issues/61183

*  Add support to get inherited configuration for resource
   modules to handle group based configuration
*  Add task input check for merged, replaced and overridden
   states in junos resource modules
*  Integration test for group based configuration

* Fix CI test failures

* Fix test failures
2019-08-27 11:06:06 +05:30
Yuwei Zhou
b4732dd2e6 Support Azure IoT hub and related module (#55121)
* Support iothub creation

* raise errordetailexception rather than clouderror

* add facts

* change requirement

* compare endpoint

* add documentation

* add documentation

* add iot device facts

* modify line ending

* add auth method

* add iot module

* add consumer group

* add the test

* enhencement of  doc

* add list consumer groups

* fix lint

* fix lint

* fix doc

* fix doc

* Update auzre_rm_iothub related document

* changed paramter's type

* update type

* rename facts -> info

* fixed sanity

* missed during merge
2019-08-27 13:18:28 +08:00
Yuwei Zhou
1c06b302bc Support automation account managment (#56429)
* add automation account

* add test

* update sdk version

* fix doc

* Update azure_rm_automationaccount.py

* Update azure_rm_automationaccount_facts.py

* Update main.yml

* add type define (#64)

* add new (#67)

* change 'example' to 'sample'

* changed 'path' to 'ID'
2019-08-27 07:38:47 +08:00
Bruno Meneguello
954416932a route53: optimize zone_id lookup when hosted_zone_id is provided (#60437) 2019-08-26 16:21:17 -07:00
Yunge Zhu
749662d776 add azure monitor log profile module (#54702)
* add azure monitor log profile module

* fix version

* fix lint

* mark test as unsupported

* fix lint

* fix lint

* Fix the error prompted in the comments
2019-08-27 05:00:28 +08:00
The Magician
1631554c1b Bug fixes for GCP modules (#61251) 2019-08-26 15:04:24 -04:00
pratikgadiya12
8ee7d9f598 VMWare - Rename _facts to _info (#57474)
Deprecate vmware's _facts modules and add new modules.

Fixes: #57278
2019-08-26 14:45:34 -04:00
Sumit Jaiswal
30714682c9
Fixes iosxr interfaces zuul failure (#61313)
* fixes 61311

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* fix loopback

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
2019-08-26 22:25:43 +05:30
Felix Fontein
e536d0e128
openssl_*: deprecate PyOpenSSL backends (#59907)
* Deprecate PyOpenSSL backends.

* Add changelog.

* Add porting guide entry.

* Improve tests to ignore deprecations when comparing results.

* Deprecating pyopenssl backend for get_certificate and openssl_publickey.

* Fix typo.
2019-08-26 18:26:10 +02:00
Felix Fontein
039123ec6b
acme_account_info: retrieve orders (#59697)
* Add retrieve_orders option.

* Run acme_certificate tests also for acme_account_info; use acme_account_info to get list of orders.

* Doing some quoting.

* Improve returned description.
2019-08-26 18:16:43 +02:00
Felix Fontein
14974f5fc2
openssl_certificate_info: add ocsp_uri return value (#60393)
* Add ocsp_uri return value.

* Add changelog.

* Add integration test.

* Fix rebase error.
2019-08-26 17:42:52 +02:00
Nathaniel Case
a567a3fae0
New module eos_lldp_global (#60975)
* New module eos_lldp_global

* Implement facts

* Implement config, add tests

* Assorted fixes
2019-08-26 11:34:41 -04:00
Mario Lenz
0ac57941c1 VMware: Add missing HA admission control policies in vmware_cluster_ha (#60233)
* Add missing HA admission control policies
* Add new parameter host_isolation_response
* Bugfix: 'das_vm_config' referenced before assignment
* Implement test cases
2019-08-26 09:40:38 -04:00
Trishna Guha
5a04b4feb6
Add nxos_l2_interfaces resource module (#61120)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2019-08-26 16:46:05 +05:30
Michał Szczepańczyk
8ed3a0b360 fix bug - k8s was crashing when yaml ended with 3 dashes (#61182)
* fix bug - k8s was crashing when yaml ended with 3 dashes

* #61182 - add changelog
2019-08-26 17:28:01 +10:00
PRASOON KARUNAN V
48eed0b6c8 adding group parameter for win_firewall_rule (#55109)
* adding group parameter for win_firewall_rule

* integration test fix

* changing the version add to 2.9

* setting group optional

* fix:setting required to optional
2019-08-25 19:10:31 -04:00
Mark Chappell
4e6298b847 AWS dynamic inventory: fixup RDS integration tests (#61259)
* ec2 inventory/rds: (integration tests) migrate to module_defaults and cope with missing security_token

* ec2 inventory/rds: (integration tests) Avoid hard coding the parameter group name

Generated it based on the information returned when creating the RDS instance.

* ec2 inventory/rds: (integration tests) rename templates to .j2 rather than .yml
- avoids throwing yamllint errors
- makes it clear they're templates not the final yaml files.
2019-08-25 10:32:18 -04:00
Felix Fontein
c3b1a0a7e8 Vultr: rename _facts -> _info (#61239) 2019-08-24 17:54:17 +02:00
Mark Chappell
5434bf74c6 Fix issues with aws_kms when working cross-account and with IDs (#60805)
* aws_kms: (integration tests) Test updating a key by ID rather than just my alias

* aws_kms: (integration tests) Test deletion of non-existent and keys that are already marked for deletion

* aws_kms: Ensure we can perform actions on a specific key_id rather than just aliases

In the process switch over to using get_key_details rather than listing all keys.

* aws_kms: When updating keys use the ARN rather than just the ID.

This is important when working with cross-account trusts.
2019-08-23 16:56:45 -07:00
Felix Fontein
4551965af1 ACME modules: bump test container version (#61192)
* Fix root cert path.

* Bump testing container version.

* Improve check (needed due to letsencrypt/pebble#257).
2019-08-23 15:30:28 -07:00
Mark Chappell
1f733e2d55 ec2_asg: fix the integration tests (#61212) 2019-08-23 14:53:47 -04:00
The Magician
d3b493020d New Module: gcp_kms_crypto_key (#61096) 2019-08-23 13:27:46 -04:00
The Magician
ba026939bb New Module: gcp_kms_key_ring (#61098) 2019-08-23 13:27:28 -04:00
Sumit Jaiswal
c9f0b0fb42
Resource module for ios_l3_interfaces (#60405)
* ios_l3_interfaces

* fix shippable

* fix tests

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* fix ignore txt file

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* fix doc

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* fix shippable n tests

* fix replace test

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* fix zuul failures

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* fix shippable n zuul

* fix zuul

* fix zuul

* fix zuul test

* fix zuul

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* code zuul fix

* fix merge

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* fix merge

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
2019-08-23 22:09:20 +05:30
Felix Fontein
fa70690e5c
openssl_certificate/csr(_info): add support for SubjectKeyIdentifier and AuthorityKeyIdentifier (#60741)
* Add support for SubjectKeyIdentifier and AuthorityKeyIdentifier to _info modules.

* Adding SubjectKeyIdentifier and AuthorityKeyIdentifier support to openssl_certificate and openssl_csr.

* Fix type of authority_cert_issuer.

* Add basic tests.

* Add changelog.

* Added proper tests for _info modules.

* Fix docs bug.

* Make sure new features are only used when cryptography backend for openssl_csr is available.

* Work around jinja2 being too old on some CI hosts.

* Add tests for openssl_csr.

* Add openssl_certificate tests.

* Fix idempotence test.

* Move one level up.

* Add ownca_create_authority_key_identifier option.

* Add ownca_create_authority_key_identifier option.

* Add idempotency check.

* Apparently the function call expected different args for cryptography < 2.7.

* Fix copy'n'paste errors and typos.

* string -> general name.

* Add disclaimer.

* Implement always_create / create_if_not_provided / never_create for openssl_certificate.

* Update changelog and porting guide.

* Add comments for defaults.
2019-08-23 14:01:42 +02:00
Mark Chappell
77e4371460 aws_kms: Update policy on existing keys (when passed) (#60059)
* aws_kms: (integration tests) Use module_defaults to reduce the copy and paste

* aws_kms: (integration tests) make sure policy option functions.

* aws_kms: (integration tests) Move iam_role creation to start of playbook.

iam_roles aren't fully created when iam_role completes, there's a delay on the Amazon side before they're fully recognised.

* aws_kms: Update policy on existing keys (when passed)
2019-08-23 20:38:38 +10:00
Chris Van Heuveln
f1054f575d bfd_global: minor test-only fix (#60965) 2019-08-23 15:12:59 +05:30
Trishna Guha
f0ef624cff
Add nxos_l3_interfaces resource module (#61021)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2019-08-23 15:06:26 +05:30
Andrey Klychkov
e3cf76533c postgresql_user: add groups parameter (#60638)
* postgresql_user: add groups parameter

* postgresql_user: add groups parameter, fail_on_role default True

* postgresql_user: add groups parameter, add changelog fragment
2019-08-23 08:17:23 +02:00
Sumit Jaiswal
47243b0b2d
Resource module for iosxr_interfaces (#59853)
* iosxr interfaces resource

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
2019-08-22 21:27:41 +05:30
Mark Chappell
70777020c4 Fix iam_password_policy integration tests (#60930)
* iam_password_policy: (integration tests) Use module defaults for AWS connection details

* iam_password_policy: (integration tests) Ensure the policy is removed when tests fail

* iam_password_policy: (integration tests) Add regression test for #59102

* iam_password_policy: Only return changed when the policy changes.

* iam_password_policy: PasswordReusePrevention must be omitted to remove/set to 0

* #60930 add changelog

* Update hacking AWS security policy to allow testing of Password Policy Management
2019-08-22 23:25:25 +10:00
Nathaniel Case
8c5936671e
Add new module eos_l3_interfaces (#59820)
* Update base files for resource modules

* Add modules

* Add module_utils

* Add tests

* Deprecate eos_l3_interface

* Update facts
2019-08-22 09:06:38 -04:00
Markus Bergholz
2fff40d409 add max_allocated_storage parameter to rds_instance (#61008)
* #60921 add max_allocated_storage parameter add apply that parameter also to the integration test

* version_added 2.9

* test value of  max allocated storage
2019-08-22 22:20:50 +10:00
Andrey Klychkov
191068a286 Issue 59955: add array handling to postgresql_query module (#60559)
* Issue 59955: add array handling to postgresql_query module

* Issue 59955: add array handling to postgresql_query module, improvements

* Issue 59955: add array handling to postgresql_query module, fix example comment
2019-08-22 08:53:29 +02:00
Sumit Jaiswal
a5a1f01d1e
Resource module for ios_lldp_interfaces (#61012)
* ios_lldp_interfaces resource

* fix shippable n reviews

* fix shippable

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* add enable lldp tc
2019-08-22 10:02:25 +05:30
The Magician
76cc8e9fc3 New Module: gcp_filestore_instance (#60996) 2019-08-21 15:31:38 -04:00
Sumit Jaiswal
35d457a14f
Resource module for ios_lldp_global (#60506)
* ios_lldp_global model

* final fix for lldp_global

* fix shippable n reviews

* fix reviews
2019-08-21 23:02:25 +05:30
Christopher Schmitt
4e7cd76c56 Add hcloud network info (#60932)
* Add hcloud network facts

* Add tests

* Rename fact to info, adjust tests

* Fix style

* Fix test

* Fix typo

* Adjust test

* Adjust test

* Rename subnets to subnetworks

* Adjustments

* Apply suggestions from code review

Co-Authored-By: Lukas Kämmerling <4281581+LKaemmerling@users.noreply.github.com>
2019-08-21 15:47:02 +02:00
Lukas Kämmerling
96199be96b Rename hcloud_*_facts to hcloud_*_info (#60926)
* Rename hcloud_datacenter_facts to hcloud_datacenter_info

* Rename hcloud_location_facts to hcloud_location_info

* Rename hcloud_image_facts to hcloud_image_info

* Rename hcloud_floating_ip_facts to hcloud_floating_ip_info

* Rename hcloud_server_type_facts to hcloud_server_type_info

* Rename hcloud_server_facts to hcloud_server_info

* Rename hcloud_ssh_key_facts to hcloud_ssh_key_info

* Rename hcloud_volume_facts to hcloud_volume_info

* Fix typo in hcloud_image_info

* Add to porting guide and add changelog fragment

* Reword porting guide
2019-08-21 14:55:37 +02:00
Matt Davis
bfa004930a
add subdir support to collection loading (#60682)
* add subdir support to collection loading

* collections may now load plugins from subdirs under a plugin type or roles dir, eg `ns.coll.subdir1.subdir2.myrole`->ns.coll's roles/subdir1/subdir2/myrole, `ns.coll.subdir1.mymodule`->ns.coll's plugins/modules/subdir1/mymodule.py
* centralize parsing/validation in AnsibleCollectionRef class
* fix issues loading Jinja2 plugins from multiple sources 
* resolves #59462, #59890,

* sanity test fixes

* string fixes

* add changelog entry
2019-08-21 10:45:04 +01:00
Rohit
8b3ff933af
Vyos lldp interfaces (#60931)
* module_utils checkin

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* vyos lldp_interfaces merging

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* shippable fix

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* merge changes

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* failure added in ignore list

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* comments incorporated

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* comments incorporated

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* test cases updated

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* remove global commands

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
2019-08-21 12:30:13 +05:30
Pavan Bidkar
b75fc87a86 VMware: New module for deploy VM from content library template (#60203)
* Fixed format issues reported by pre-check tests

* Changes as per review comments. using single api_client between util class and module

* re-running the task to check the idempotency of module object
2019-08-21 11:17:29 +05:30
Nathaniel Case
764a81fce7
New module eos_lacp (#60698)
* Initial builder import

* Add tests

* Implement facts & config
2019-08-20 16:11:31 -04:00
Matt Clay
92380d7050
Update ansible-test --windows inventory creation. (#60911)
Host specific settings are created as part of the generated inventory instead of using a host_vars directory.

Also update connection tests to work properly with the generated inventory changes.
2019-08-20 07:17:32 -07:00
Will Thames
362c45517d aws_kms: fix failing tests (#60206)
Preserve tag key case by only calling camel_dict_to_snake_dict once,
before the tags are added.

Don't call assert_policy_shape as it seems to fail

Use aws_caller_info in the test suite now that it exists rather
than running `aws sts get_caller_identity`

Ensure that calls using `grant_types` can also use key aliases
2019-08-20 07:15:40 -04:00
Trishna Guha
41dc8e84e4
fix nxos test failure (#60928)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2019-08-20 16:14:00 +05:30
Sumit Jaiswal
8a8798c373
Resource module for ios_lacp_interfaces (#59516)
* ios lacp interfaces

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
2019-08-20 13:37:31 +05:30
Sumit Jaiswal
642e54f958
Resource module for ios_lacp (#60884)
* ios lacp resource

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
2019-08-20 12:05:14 +05:30
Nathaniel Case
efa163a2e8
New module eos_lag_interfaces (#60610)
* Copy module files

* Deprecate eos_linkagg

* Add tests
2019-08-19 15:34:20 -04:00
Nathaniel Case
d9ffc61539
Add new module eos_l2_interfaces (#59794)
* Add module files for l2_interfaces

* Add module_utils

* Add tests

* Deprecate eos_l2_interface

* Clean up tests so eos_vlan will still pass
2019-08-19 11:24:36 -04:00
Sumit Jaiswal
04ef376ab2
Resource module for ios_lag_interfaces (#60672)
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
2019-08-19 20:41:00 +05:30
Ganesh Nalawade
49736b6b27
Add support to configure network_cli terminal related options (#60086)
* Add support for configurable terminal plugin options

Fixes #59404

*  Add terminal options to support platform specific login menu
*  Add terminal options to support configurable options for stdout
   and stderr regex list

* Fix CI failures

* Fix CI issues

* Fix review comments and add integration test

* Fix sanity test failures

* Fix review comments

* Fix integration test case

* Fix integration test failure

* Add support to configure terminal related options

Fixes https://github.com/ansible/ansible/issues/59404

*  Add network_cli configurable options to support platform specific login menu
*  Add network_cli configurable options to support configurable options for stdout
   and stderr regex list

* Fix review comment

* Fix review comment
2019-08-19 18:56:20 +05:30
Nathaniel Case
446dcb7c96
New module eos_vlans (#60652)
* Initial commit of module files

* Add tests, implement facts

* Implement config, fix issues

* Handle vlan ranges from the device

* Deprecate eos_vlan
2019-08-19 09:02:38 -04:00
Rohit
d8f9904f43
vyos_lldp_global (#59627)
* vyos_lldp_global

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* sanity checks

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* deprecated changes

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* comments incorporated

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* test cases updated

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* comments incorporated

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* branch conflict resolved

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* sanity check passes

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
2019-08-19 17:31:09 +05:30
Sumit Jaiswal
b55a54469c
Resource module for ios_vlans (#59640)
* ios_vlans resource module

* fix shippable error

* fix shippable

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* fix vlans resource

* fix facts doc

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* fix shippable n review

* fix test

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* fix indentation

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* fix review

* fix shebang

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
2019-08-19 16:03:29 +05:30
Trishna Guha
f1cf838797
fix nxos CI failures (#60752)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2019-08-19 14:24:39 +05:30
Ryan Butler
555b8413a1 VMware: Add uptime and maintenance mode in vmware_host_facts (#60688)
* adding host facts
* adding to test
2019-08-19 10:57:01 +05:30
Felix Fontein
0d88ec241f
openssl_certificate: fix idempotency (#60745)
* Fix openssl_certificate idempotency.

* Add changelog.

* Add integration test.
2019-08-18 20:48:34 +02:00
Hannes Ljungberg
13364fc530 docker_swarm_service: Allow passing dicts in networks (#58961)
* Add support for passing networks as dicts

* Add function to compare a list of different objects

* Handle comparing falsy values to missing values

* Pass docker versions to Service

* Move can_update_networks to Service class

* Pass Networks in TaskTemplate when supported

* Remove weird __str__

* Add networks integration tests

* Add unit tests

* Add example

* Add changelog fragment

* Make sure that network options are clean

Co-Authored-By: Felix Fontein <felix@fontein.de>

* Set networks elements as raw in arg spec

Co-Authored-By: Felix Fontein <felix@fontein.de>

* Fix wrong variable naming

* Check for network options that are not valid

* Only check for None options

* Validate that aliases is a list
2019-08-18 08:55:54 +02:00
Felix Fontein
26b9c81a8e
crypto modules: fix sanity errors (#60046)
* Remove sanity warnings.

* Linting.

* More linting.

* Forgot one place.

* no_bytes -> num_bytes
2019-08-18 05:37:57 +02:00
Sumit Jaiswal
ab07c206aa
Resource module for ios_l2_interfaces (#60344)
* ios_l2_interface checkin

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
2019-08-17 23:02:36 +05:30
Felix Fontein
6a786d0d93
openssl_publickey: add cryptography backend (#60387)
* Add cryptography backend.

* Add changelog.

* Make sure requirements are satisfied.

* Use more compatible elliptic curve.

* Decrease required version numbers.

* PyOpenSSL >= 16.0.0 is really needed.

* Update lib/ansible/modules/crypto/openssl_publickey.py

Co-Authored-By: MarkusTeufelberger <mteufelberger@mgit.at>
2019-08-17 18:52:14 +02:00
Paul Belanger
13996aaff6
Fix missing variable with nxos_install_os tests (#60351)
Today we are getting an Ansible templating exception because this
variable isn't defined. But we also don't want testing to run, as we
don't have ability to run this test in DCI.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-08-17 10:04:50 -04:00
Felix Fontein
601a4b8f47
get_certificate: add cryptography backend (#60599)
* Add cryptography backend for get_certificate.

* Add changelog.

* Use short names (if possible).

* Adjust version (to behave as pyOpenSSL).

* Work around bugs (needed for cryptography 1.2.3).

* Don't run cryptography backend tests for CentOS 6.

* Bump cryptography requirement to 1.6 or newer.

Otherwise, signature_algorithm_oid isn't there, either.

* Simplify requirement text.

* CentOS 6 has cryptography 1.9, so we still need to block.

* Add auto-detect test.

* Improve YAML.
2019-08-17 16:02:14 +02:00
Felix Fontein
cf69b73c04
openssl_certificate/csr_info: add ordered issuer/subject return value (#60708)
* Add ordered issuer/subject return value.

* Add changelog.
2019-08-17 15:49:54 +02:00
Lukas Kämmerling
100b56439e hcloud_server: Allow users to enable/disable the rescue mode (#60070) 2019-08-17 11:29:58 +02:00
The Magician
818d1b2e45 New Module: gcp_cloudfunctions_cloud_function (#60668) 2019-08-16 15:23:39 -04:00
Mitsuru Nakakawaji
064cd63f3d fix: docker_swarm_service does not publish both tcp and udp ports (#60616)
* fix: docker_swarm_service does not publish both tcp and udp ports for same published port

* fix the linting problems and add the changelog fragment.

* add test

* modify test to ensure result rather than return value
2019-08-16 15:23:45 +02:00
Felix Fontein
48541910bf
docker_container: add mount endpoint collision detection (#60384)
* Add mount endpoint collision detection.

* Add changelog.

* Fix error.
2019-08-16 15:23:03 +02:00
Gonéri Le Bouder
218f4276d5 vmware_drs_group: creates test vm properly
Creates the test VMs with `prepare_vmware_test`. Before this commit,
only one VM was created and the next step was failing because this was
not matching the expected list of VMs.
2019-08-15 16:57:39 +02:00
Matt Clay
0c74ee4352
Clean up various integration tests. (#60613)
* Fix var_blending test temp dir usage.

* Fix filters integration test:

- Fix use of `output_dir`.
- Use `localhost` instead of `testhost` since we're only testing filters.
- Fix `fileglob` test to actually test a directory that exists.

* Fix lookups integration test:

- Fix use of `output_dir`.
- Use `localhost` instead of `testhost` since we're only testing lookups.

* Fix ansible-runner test temp dir usage.

* Fix template and template_jinja2_latest test.

Use the `OUTPUT_DIR` env var to get the output directory for the tests.

* Fix Python version compat in filters test.

* Skip filters test on Python 2.6.
2019-08-14 16:33:45 -07:00
René Moser
f02f5c4b5d
cloudscale_server: add tags support (#60396) 2019-08-14 22:55:31 +02:00
René Moser
5298d312a2
cloudscale_server_group: add tags support (#60397) 2019-08-14 22:54:25 +02:00
Lukas Kämmerling
4a09c7a920 hcloud: Add hcloud_rdns Module (#60123) 2019-08-14 22:51:05 +02:00
Gonéri Le Bouder
b8430a3221 vmware_guest_screenshot: fix the functional test
- VM are off my default since 964783fbd2
- `infra.vm_list[0]` → `virtual_machines_in_cluster[0].name`
- `datacenter` key is currently mandatory, see: https://github.com/ansible/ansible/issues/60565
2019-08-14 18:59:58 +02:00
Matt Clay
27ff8b1a80 Clean up unused config usage in integration tests. 2019-08-14 09:44:36 -07:00
Rohit
69bc24f607
lag interfaces resource module (#59175)
* lag interfaces resource module

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* sanity check imports

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* sanity fixes

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* dict_diff usage issue fix

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* new task

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* overridden updated

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* dict update

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* comments incorporated

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* facts merged

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* rebased and merged

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* new failures added

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* obsolete file removed

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* test cases updated

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* comments incorporated

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* dependency added

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
2019-08-14 17:31:49 +05:30
Trishna Guha
d5d88f9b11
Add nxos_interfaces resource module (#60421)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2019-08-14 13:38:22 +05:30
Matt Clay
b07f96c31d
Fix integration test temp dir usage. (#60555)
* Fix xfs_quota integration test temp dir usage.
* Fix lvg integration test temp dir usage.
* Fix filesystem integration test temp dir usage.
* Fix connection_windows_ssh test temp dir usage.
2019-08-14 00:12:05 -07:00
Matt Clay
60f8483603
Add missing boilerplate to collections test. (#60507)
* Add missing boilerplate to collections test.
* Remove redundant Python version check.
2019-08-13 12:20:14 -07:00
Iain Madder
1b1216d2d1 Update file.py's help doc, and narrow down diff logic, for recent pull 56353 (#59069)
* Limiting when path_content is generated

path_content will be empty and unnecessary in all scenarios except when changing the state of a folder to absent, so adding in a check to limit when this parameter is defined
2019-08-13 12:59:13 -04:00
Nathaniel Case
6b5c7f7c42
Add new module eos_interfaces (#59729)
* Move module_utils

* Add eos_interfaces and deprecate eos_interface

* Add boilerplate, update ignores.txt

* Try to reconcile eos provider documentation with argspec

* Try to work around unknown interfaces

* Move param_list_to_dict to utils
2019-08-13 10:09:52 -04:00
Nilashish Chakraborty
ef0f28097e
Remove lo from config (#60480)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-08-13 19:10:56 +05:30
Shaun M
fa783c027b Adding waiter to cluster remove process (#57324)
* Adding waiter to cluster remove process

* blank line contains whitespace

* update aws_eks integration test

* Refactor aws_eks test suite to use pip

* update version testing

* missing parens...

* add changelog fragment

* Add waiter to module_utils, fix exception handling.

* Correct EKS waiter checks
2019-08-13 23:11:21 +10:00
Felix Fontein
2d98734ad5 Amazon modules: rename _facts with ansible_facts result to _info (#60178)
* aws_s3_bucket_facts -> aws_s3_bucket_info

* cloudformation_facts -> cloudformation_info

* cloudfront_facts -> cloudfront_info

* ecs_service_facts -> ecs_service_info

* efs_facts -> efs_info

* Add changelog and porting guide entry.

* lambda_facts -> lambda_info

* Improve examples.

* Add subsection on renamed modules.

* Add sentence on registering variables.

* Fix ReST.

* Instead of renaming lambda_facts, deprecate it and replace with new module.

* Rename internal variable.

* Re-add sanity ignores for lambda_facts.
2019-08-13 08:01:37 -04:00
Nilashish Chakraborty
6110dcc789
Add iosxr_lldp_interfaces resource module (#60411)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-08-13 14:58:55 +05:30
Matt Davis
a40baf22fa
various mod_args fixes (#60290)
* various mod_args fixes

* filter task keywords when parsing actions from task_ds- prevents repeatedly banging on the pluginloader for things we know aren't modules/actions
* clean up module/action error messaging. Death to `no action in task!`- actually list the candidate modules/actions from the task if present.

* remove shadowed_module test

* previous discussion was that this behavior isn't worth the complexity or performance costs in mod_args

* fix/add test, remove module shadow logic

* address review feedback
2019-08-13 09:57:49 +01:00
Ganesh Nalawade
9efa00e762
Add [junos_lldp_global] model (#59712)
* Add [junos_lldp_global] model

*  Add new resource module junos_lldp_global
*  Targets model https://github.com/ansible/network/pull/30
*  Deprecate junos_lldp module

* Run lldp integration test only if protocol supported
2019-08-13 13:05:17 +05:30
Trishna Guha
0acf7be56a
Add nxos_lacp_interfaces resource module (#60313)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2019-08-13 12:13:35 +05:30
Matt Clay
d36919856f
Update integration tests. (#60447)
* Remove unnecessary ANSIBLE_CONFIG override.
* Fix pull integration test.
* Fix inventory_foreman integration test.
2019-08-12 16:23:47 -07:00
Sam Doran
c485a1b91e
Fix sanity tests based on newer version of shellcheck (#60423)
- change egrep to grep -E
- store exit codes and check them directly
- ignore SC1091
2019-08-12 16:24:28 -04:00
The Magician
6cb5b67b22 Bug fixes for GCP modules (#60115) 2019-08-12 14:34:20 -04:00
The Magician
be459c00bf Bug fixes for GCP modules (#60337) 2019-08-12 14:31:35 -04:00
The Magician
687da46a85 Bug fixes for GCP modules (#60338) 2019-08-12 13:41:41 -04:00
Marius Gedminas
c71622b31a user: createhome=no home=/no/such/dir (#60310)
Fixes #60307.

This bug was introduced in commit d2edf1d435
("User - Create parent directories if they do not exist in the specified
home path (#51043)") and did not make it into any releases.
2019-08-12 10:37:45 -04:00
Nilashish Chakraborty
09f712c7f3
Add iosxr_lldp_global resource module (#60074)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-08-12 18:03:23 +05:30
René Moser
602aded6ec
vultr: vultr_block_storage_facts to info (#60230) 2019-08-12 10:36:21 +02:00
Ganesh Nalawade
8cbfa75038
Add [junos_lacp] model (#59705)
* Add [junos_lacp] model

*  Add new resource module junos_lacp.
*  Targets model https://github.com/ansible-network/resource_module_models/pull/28

* Fix CI issues

* Fix CI failures
2019-08-12 13:54:44 +05:30
Nilashish Chakraborty
f4502a8f1c
Set eth0 to dhcp explicitly (#60305)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-08-12 11:36:54 +05:30
Ganesh Nalawade
fdf48ed0b4
Add [junos_lacp_interfaces] resource module (#59708)
* Add [junos_lacp_interfaces] resource module

*  Add new resource module junos_lacp_interfaces.
*  Targets model https://github.com/ansible-network/resource_module_models/pull/36

* Fix sanity test failure
2019-08-12 11:24:34 +05:30
Jordan Borean
35b87b8633
Move windows test to another group (#60391) 2019-08-12 10:00:09 +10:00
Maxim Babushkin
dda80c46e9 openssh_keypair - Add key `comment` to return output (#59268)
If the comment will be provided during the key creation, it will be
diplayed in the return values.
Same will be on the comment change.
2019-08-11 13:47:34 +02:00
Maxim Babushkin
27e414200f openssh_keypair - Add public key and key comment validation (#57993)
- Split the key validation to separate private and public.
- In case public key does not exist, recreate it.
- Validate comment of the key.
- In case comment changed, update the private and public keys.
2019-08-10 18:57:35 -04:00
The Magician
30ad73f1c1 Bug fixes for GCP modules (#60339) 2019-08-09 19:17:44 -04:00
Felix Fontein
8b68feb67e
acme_certificate: allow to download alternate certificate chains (#56334)
* Improve link handling.

* Also fetch alternate certificate chains.

* Add retrieve_all_alternates option.

* Simplify code.

* Forgot when condition.

* Add tests for retrieve_all_alternates.

* Fixes.

* Moved utility function for link parsing to module_utils.

* Fix grammar.
2019-08-09 23:54:48 +02:00
Alex Stephen
2e90efd4a7 Changing GCP Facts modules to Info Modules (#60172)
* file changes, porting guide, changelog fragment, renaming autoscaler, removing rst links
* Apply suggestions from code review

Co-Authored-By: Alicia Cozine <879121+acozine@users.noreply.github.com>
Co-Authored-By: Felix Fontein <felix@fontein.de>
2019-08-09 15:13:08 -05:00
Nathan Swartz
d61df0a9ba Lun mapping upstream dev (#57096)
* Fix hosts with same lun number conflict in netapp_e_lun_mapping.

This patch fixes an issue of when multiple hosts are created and then
subsequently volume(s) are mapped to them using the same specified number.

* Fix netapp_e_host module bug when lun=0

* Add thin-volumes to the netapp_e_lun_mapping update_mapping_info method.
2019-08-09 08:25:38 -04:00
Jordan Borean
dbd082efe4
Ansible.AccessToken - Added shared util for managing a Windows access token (#60302)
* Ansible.AccessToken - Added shared util for managing a Windows access token

* Fix tests when running in CI

* More fixes for older servers

* More fixes for Server 2008
2019-08-09 21:10:44 +10:00
Ganesh Nalawade
309a58eafd
Add [junos_l2_interfaces] resource module (#59693)
* Add [junos_l2_interfaces] resource module

*  Add new resource module junos_lag_interfaces.
*  Targets model https://github.com/ansible-network/resource_module_models/pull/12
*  Deprecate junos_l2_interface module

* Fix CI failures

* Fix CI issues
2019-08-09 13:09:19 +05:30
Matt Clay
3777c2e93d Fix plugin names when loading all plugins. (#59950)
* Fix plugin names when loading all plugins.

Add an integration test to verify plugin __package__ and __name__ are correct.

* Make sure filter and test names are unique.

* Remove __package__ test.

On Python 2.x __package__ is not set, but it is on Python 3.x.
2019-08-09 07:23:12 +01:00
Abhijeet Kasurde
d3624cf4a4
VMware: test - add missing datacenter parameter (#60273)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-08-09 11:17:44 +05:30
Matt Clay
07051473f8 Disable failing inventory_docker_machine test. 2019-08-08 20:39:04 -07:00
Ganesh Nalawade
6f0aae256d
Add [junos_lldp_interfaces] model (#59720)
* Add [junos_lldp_interfaces] model

*  Add new resource module junos_lldp_interface
*  Targets model https://github.com/ansible-network/resource_module_models/pull/40
*  Deprecate junos_lldp_interface module

* Fix CI issues
2019-08-08 18:23:54 +05:30
Trishna Guha
87a568da0b
Add nxos_lacp resource module (#59717)
* Add nxos_lacp resource module

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* Add commands in module doc

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2019-08-08 16:52:16 +05:30
Nilashish Chakraborty
a595c60d4c
Add eth0 in prepare_vyos_tests (#60212)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-08-08 16:45:01 +05:30
Jordan Borean
534a40c5cd
Move win target back a group (#60257) 2019-08-08 12:03:32 +10:00
Jordan Borean
81cb6f366a
Added group 7 to Windows groups - ci_complete (#60240) 2019-08-08 10:13:28 +10:00
ximon18
2cca9176a7 Added a Docker Machine dynamic inventory plugin (#54946)
* Added my Docker Machine dynamic inventory plugin (from https://github.com/ximon18/ansible-docker-machine-inventory-plugin) to begin the process of proposing it for inclusion in Ansible core. There are no integration tests yet. The docker_swarm inventory plugin has such tests but has some concerning note in its 'aliases' file about disabling docker due to test instability and also I wouldn't know at his point how to get Docker Machine installed on the integration test platform.
2019-08-07 18:14:14 -04:00
Nilashish Chakraborty
7b90e8aec4
Add iosxr_lacp_resource module (#59724)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-08-08 00:13:06 +05:30
Sam Doran
47796af64f
Change dummy package name in yum/dnf tests to not collide with an actual package (#60225)
When targeting 'foo*' in tests, it pulled in packages other than the dummy packages in our testing repo that have many dependencies, some of which were causing tests to fail.

Also change 'bar' package name to avoid the same issue in the future.
2019-08-07 14:26:55 -04:00
Nathan Swartz
e80f8048ee Fix netapp_e_volume wait-for-initialization to complete issue. (#58304)
* Fix netapp_e_volume wait-for-initialization to complete issue.

* Add unit tests for wait_for operations in netapp_e_volume module.
2019-08-07 11:28:39 -04:00
Marat Sharafutdinov
8751319820 Add wait_sleep parameter for the k8s module (#59714) (#59854) 2019-08-07 21:27:54 +10:00
Matt Clay
233efe0886 Add missing boilerplate. 2019-08-06 15:45:22 -07:00
Matt Clay
d651bda123
Relocate ansible-test code. (#60147)
* Initial move of `test/runner/` content.

`test/runner/lib/` -> `test/lib/ansible_test/_internal/`
`test/runner/`     -> `test/lib/ansible_test/_internal/data/`

* Initial move of `test/sanity/` content.

`test/sanity/` -> `test/lib/ansible_test/_internal/data/sanity/` (except `test/sanity/ignore.txt`)

* Initial move of `test/units/pytest/` content.

`test/units/pytest/` -> `test/lib/ansible_test/_internal/data/pytest/`

* Follow-up move of `test/runner/unit/` content.

`test/lib/ansible_test/_internal/data/unit/` -> `test/lib/ansible_test/tests/unit/`

* Initial move of `ansible.cfg` content.

`test/units/ansible.cfg` -> `test/lib/ansible_test/_internal/data/units/ansible.cfg`
`test/env/ansible.cfg` -> `test/lib/ansible_test/_internal/data/env/ansible.cfg`

* Follow-up move of `data` directory.

`test/lib/ansible_test/_internal/data/` -> `test/lib/ansible_test/_data/`

* Update import statements.

* Add missing __init__.py for unit tests.

* Fix path references and miscellaneous issues.
2019-08-06 14:43:29 -07:00
Matt Martz
923e21836b
Move plugin loader playbook dir additions back to Playbook instead of PlaybookCLI (#59557)
* Move plugin loader playbook dir additions back to Playbook instead of PlaybookCLI. Fixes #59548

* Restore cli additions
2019-08-06 15:58:15 -05:00
Nathan Swartz
acbffce079 Host dev upstream (#57086)
* Improve netapp_e_host module

Add host type strings for windows, windows cluster, linux and vmware to netapp_e_host module
Make host port information case-insensitive in netapp_e_host module
Fix port removal and default group.
Fix port reassignment in netapp_e_host module.
Fix port label or address change within existing host object in module netapp_e_host
Add unit and integration tests

* Created new unit test for netapp_e_host module
2019-08-06 15:01:22 -04:00
Nilashish Chakraborty
2c432f8bc7
Add vyos_l3_interfaces resource module (#59929)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-08-06 19:30:58 +05:30
Daniel Mellado Area
e3681c049c
Add junos vlans resource module (#59041) 2019-08-06 16:00:01 +02:00
The Magician
4317a97c42 New Module: gcp_compute_autoscaler (#60096) 2019-08-05 18:38:00 -04:00
The Magician
26a2d84dba New Module: gcp_compute_snapshot (#60098) 2019-08-05 18:37:51 -04:00
The Magician
820cfbbb77 Bug fixes for GCP modules (#60089) 2019-08-05 18:26:14 -04:00