Commit graph

48663 commits

Author SHA1 Message Date
Abhijeet Kasurde
eac7fa1860
gitlab_user: Remove optional parameters while state is absent (#64832)
While deleting gitlab user, several parameters such as email, name,
password are not required. This fix removes this requirement from the
module.

Fixes: #61921

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-11-14 17:21:14 +05:30
Jonathon Sheffield
9ee601288c Fix postgres_user not commiting changes when groups is set (#64807)
resolves #64806
2019-11-14 15:09:45 +05:30
Andre Lehmann
a75a79b84c hostname - Add Manjaro Linux distribution (#64810)
* Add Manjaro Linux distribution
2019-11-14 14:31:21 +05:30
Jiri Tyr
e0373a73a8 VMware: Simplifying get_vm() in module_utils.vmware (#62217) 2019-11-14 10:40:37 +05:30
Youhua Li
46a6c28bb0 use ~/.one/one_auth as default of ONE_AUTH file location (#64535)
* better excpetion handling when one_auth file is missing
* use Exception instead of BaseException
2019-11-14 09:37:35 +05:30
Daniel-Sanchez-Fabregas
04b8f75ffa win_domain_computer module: Fix idempotence when name != sam_account_name (#56967)
* win_domain_computer module: Minor documentation error

* Fix idempotence when name != samaccountname

* Added changelog

* Added unsupported alias for CI check
2019-11-14 12:59:05 +10:00
Shachaf92
f6ac4361e7 win_firewall_rule - support ICMP types and codes (#60361)
* win_firewall_rule - support ICMP types and codes

* Update main.yml

* Add more examples and change type to list
2019-11-14 11:32:01 +10:00
dlitster
91d0ad9a4c Update win_firewall_rule.py to include ICMP echo (ping) example (#55013)
* Update win_firewall_rule.py

<!--- Your description here -->
Added example of enabling ICMP protocol, as ping is commonly used for troubleshooting in automation scenarios.  Equivalent netsh command is: 
netsh advfirewall firewall add rule name='ICMP Allow incoming V4 echo request' protocol=icmpv4:8,any dir=in action=allow

+label: docsite_pr

* Remove yaml-breaking space

Removed extraneous space that caused validation to fail.

* Remove more extraneous whitespace
2019-11-14 10:17:45 +10:00
Tony Chia
23a751323b allow using --check on win_iis_webapppool module (#50528)
* allow using --check on win_iis_webapppool module

* Added changelog and slight logic tweak

* Fix typo in changelog fragment
2019-11-14 08:52:34 +10:00
Anusha Hegde
3a9650df98 Merging conflicts and updating PR
Signed-off-by: Anusha Hegde
2019-11-13 16:12:52 -05:00
Anusha Hegde
4e7c0b3e21 Fixed review comments
Signed-off-by: Anusha Hegde
2019-11-13 16:12:52 -05:00
Anusha Hegde
907c66c082 Resolved merge conflicts 2019-11-13 16:12:52 -05:00
Gonéri Le Bouder
80bf24b17c vmware_guest_disk/test: use less disk space
Reduce the amount of space that is used on the datastore during the
test. This allow use to use lighter storage environment during the test.
2019-11-13 16:00:20 -05:00
Mark Chappell
b5f484dcc3 ec2_eip Don't throw an exception when re-releasing an EIP (idempotency) (#62332)
* ec2_eip: (integration tests) move to using module_defaults

* ec2_eip: (integration tests) expand integration tests

Also clean up a little
- Delete EIPs when we finish testing them (reduce the chance of hitting limits)
- Rejig deletion so that it works when runs fail
- Add tests for ec2_eip_info

* ec2_eip: Minor doc tweaks

* ec2_eip: Don't throw an exception when we try to disassociate an already disassociated EIP

* ec2_eip: Add missing IAM policy (manage IGWs)

* ec2_eip: (integration tests) Use the VPC as a crude lock to avoid running parallel tests

We test that untagged EIPs come and go as we expect, if multiple tests are
running in parallel this confuses things

* Fix ec2_eip association
2019-11-13 13:27:35 -07:00
Jordan Borean
f8f7662850
Add the ability to ignore files and collection build (#64688) 2019-11-14 05:02:58 +10:00
Vincent Bernat
bf19060683 ipaddr: add an option to return peer of a point-to-point link (#59144)
* ipaddr: add an option to return peer of a point-to-point link

Signed-off-by: Vincent Bernat <vincent@bernat.ch>

* ipaddr: extend "peer" to also work with /30
2019-11-13 13:47:05 -05:00
John Mahowald
bb72b8f1d9 Syntax fix guide_gce.rst (#64779)
Fix syntax for create a GCP instance example playbook. Fix task indentation.
2019-11-13 11:39:20 -06:00
James Vornhagen
a2047cfa2d update documentation example (#64786)
missing k in workflow in an example for the tower_workflow_template module
2019-11-13 11:29:46 -06:00
Vera
844b5d4673 docs: fix gcs example to work with ansible 2+ (#64778)
switched directive sudo to become
2019-11-13 11:26:57 -06:00
James Cassell
a7f90df0e9 Document match/search tests (#64775)
* clarify `search` vs `match` tests

* string test docs: fix rst formatting
2019-11-13 11:14:10 -06:00
Gonéri Le Bouder
93d1a57d9a vmware_guest: fix the name of the test VMs
The test VM names must be deterministic, this way, the teardown playbook
can clean up the resources after the test execution.

See: https://docs.ansible.com/ansible/latest/dev_guide/platforms/vmware_guidelines.html#vm-names-should-be-predictable
2019-11-13 11:52:57 -05:00
Michael Shen
d3b7828118 [FIX] graceful is not an immutable attribute (#64397) 2019-11-13 11:22:34 -05:00
GomathiselviS
143bafec9a eos_lacp_interfaces : Fix to - lacp port-priority not set when… (#64530)
* Fix bug 64453
2019-11-13 09:31:21 -05:00
Richlv
83927c3437 Update openssl_certificate.py (#64772)
Changed 'generate' to 'generating'
2019-11-13 18:25:47 +05:30
Jie (Link) Zheng
743b6eb5b0 Fortinet's new module for fortios_vpn_ipsec_phase2_interface (#64767) 2019-11-13 16:27:20 +05:30
Klaus Frank
d0f8e8896f vmware_tools handle connection issues (#57661)
* Catch vmodl.fault.SystemError exception.

* Add exceptions for connection issues.

* Fix self._si not defined exception (L353), when trying to close a non existing connection.

* Fix vmware_tools connection reset

* Also catch InvalidGuestLogin exception, as it get's also thrown when trying to logging in too early on startup...
2019-11-13 18:27:15 +10:00
Artem Meshcheryakov
bd9a0b6700 Improve handling of "restarted" state for win_iis_website module (#63829)
* Improve handling of "restarted" state for win_iis_website module

* Added changelog fragment
2019-11-13 10:24:25 +10:00
P-Hessler
95d613f3ab win_acl no longer needs SeSecurityPrivilege (#57804)
* win_acl no longer needs SeSecurityPrivilege
Set-ACL raises missing SeSecurityPrivilege error when the inheritance
from the parent directory is disabled.

* fixes test sanity

* registry rights can only be modified with Set-ACL

* add changelog
2019-11-13 09:54:57 +10:00
sergioirium
e77426dad3 Corrected Get-adcomputer (#63093)
* Corrected Get-adcomputer

Corrected Get-adcomputer on "Remove-ConstructedState" and "Set-ConstructedState" functions.
resolved error: Unable to contact the server. This may be because this server does not exist, it is currently down, or it does not have the Active Directory Web Services running.

* Update lib/ansible/modules/windows/win_domain_computer.ps1

Co-Authored-By: Daniel-Sanchez-Fabregas <33929811+Daniel-Sanchez-Fabregas@users.noreply.github.com>

* Update win_domain_computer.ps1

changed
"-credential $credential" to "@extra_args" (Line 115 and 150)
corrected exception message (Line 122)

* Added changelog fragment, minor code tweak
2019-11-13 09:13:44 +10:00
Shachaf92
e74d397c01 setup.ps1 - parity with linux regarding missing local facts path (#58887)
* setup.ps1 - parity with linux regarding missing local facts path

* add warning

* Update setup.ps1-parity-with-linux-regarding-missing-local-facts-path.yml
2019-11-13 09:05:16 +10:00
Marius Rieder
d2e1aeeb67 win_domain_user: Make Identification of the user to work with more robust (#61594)
* Ensure we work on only one user.

After the initial get/create use the GUID of the found/created user to
ensure we will not start to work with  a different user. If we create a
user or modify it's attributes an he is not identified with the name
parameter afterwards this module fails in rather unpredictable ways.

This addressed #45298

* Use splatting create_args for creating user.

This prepars this for adding more optional create arguments without 
nesting of condictions.

* Set the UserPrincipalName and SamAccountName on create.

Set the UserPrincipalName and SamAccountName on the create operation if 
upn is given to ensure the User is created with a contollable 
SamAccountName.

* Rename $username to $name.

$username is missleading as its not the SamAccountName.

* Add a identity parameter to win_domain_user

This gives the user full controll over how the user is identified in the 
AD.

* Add version_added information for new parameter and fix yaml syntax.

* Added changelog fragment
2019-11-13 08:42:44 +10:00
Dusan Matejka
fadf7a426f re-enable zabbix_host integration tests and add cleanup handlers 2019-11-12 09:54:51 -08:00
Pilou
47bf5deb54 command, script & shell: mention 'cmd' parameter (#62778)
'cmd' parameter is supported since 2b3c5aa41e (v2.0.0-1)
2019-11-12 09:40:09 -06:00
Abhijeet Kasurde
68428efc39 Remove temp directory created by wait_for_connection (#64592)
wait_for_connection creates AnsiballZ_ping.py in temp directory,
which remains on remote machine even after playbook run.

Fixes: #62407

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-11-12 10:07:33 -05:00
Nathaniel Case
fed0496005
Fix eos_facts over local eapi (#64570)
* Fix eos_facts over local eapi

* Much better feedback when querying resources over local

* No need for that anymore

* Update comment

* Mkae sure facts are tested on local

resource modules might break this otherwise

* This test was not checking anything

* Pass over nxos_facts as well
2019-11-12 09:29:44 -05:00
Dusan Matejka
9dc94b32d2 added missing atexit logout for zabbix_host module (#63785) 2019-11-12 08:28:08 -05:00
Sandra McCann
94e98d5369 remove toshio as release manager (boohoo) (#64685) 2019-11-12 13:14:09 +00:00
Abhijeet Kasurde
47f9873eab
VMware: Handle slash in network name in vmware_guest module (#64494)
Encode slash in network name to work with vSphere API.

Fixes: #64399

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-11-12 17:13:57 +05:30
Abhijeet Kasurde
575116a584
doc: Handle exception in parsing parameter description (#60933)
Fixes: #60587

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-11-12 16:48:46 +05:30
PRASOON KARUNAN V
4bf79de8a6 Add output options for win_pester (#63583)
* add output options for win_pester

* fix typo

* correct variable name
2019-11-12 16:13:52 +10:00
Hidetoshi Hirokawa
c0331053db Add encoding and codepage params to win_command/win_shell (#54896) (#54966)
* Add output_encoding_override params to win_command/win_shell (#54896)

This enhancement enables Ansible to parse the output of
localized commands that ignore the prompt code page.

* Added changelog and minor nits
2019-11-12 15:58:57 +10:00
haiyuan_zhang
c11d73575b Fixes azure_rm_snapshot (#64542) (#64547)
* feature enhancement: make a snapshot from an existing managed disk.

* remove default creation option in argu_spec of azure_rm_snapshot

* fix pep8 related issue

* fixing broken integration test
2019-11-12 13:05:15 +08:00
philseeley
ca42cb2868 Make the DNS service optional when installing Active Directory (#63440)
* Added install_dns option to the win_domain module.

* Added install_dns option to the win_domain_controller module.

* Updated version_added to devel branch version 2.10.

* Updates for ansible-test errors.

* Minor nits to docs
2019-11-12 14:53:51 +10:00
PRASOON KARUNAN V
8b13836b1f change $partition variable name to $ansible_partition (#63968)
* change $partition variable name to $ansbile_partition

* Added changelog fragment
2019-11-12 14:44:18 +10:00
Jordan Borean
8c4f59ebd9
win_package - Set raw for argument type (#64690) 2019-11-12 14:39:48 +10:00
Cory Silva
9c5a1ebba5 Add Local Security Policy update example (#60897)
* Add Local Security Policy update example

##### SUMMARY
This real world example will be useful, but perhaps there is a better section?


##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr

* Move new example and add not to username
2019-11-12 14:33:56 +10:00
Matt Martz
b93d92ef9a
Set alter_sys=True instead of False to address backwards incompat (#64670)
* Set alter_sys=True instead of False to address backwards incompat

* ci_complete

* Add integration test

* ci_complete

* sanity

* ci_complete

* Changelog fragment

* Update import test and validate-modules to match
2019-11-11 16:47:35 -06:00
Brian Coca
c1493e5267 really clarify environment (#62531)
Co-Authored-By: John R Barker <john@johnrbarker.com>
2019-11-11 16:04:31 -05:00
chris-kiick-sp
8b83f9c14e archive module documentation is misleading (#62755) 2019-11-11 15:46:03 -05:00
Petr Ruzicka
a5dc11cdd1 Changed with_items -> loop (#62995) 2019-11-11 15:09:52 -05:00