Commit graph

4929 commits

Author SHA1 Message Date
James Cammarata
690904aae3 Merge pull request #8880 from kvar/fix_zypper_typo
fix typo in zypper module (requiered -> required)
2014-09-04 10:06:51 -05:00
James Cammarata
286ab6a079 Merge pull request #8868 from mike-d-d/fix-route_tables-default
Fix #8666 for real
2014-09-04 10:00:40 -05:00
tepwil
ae0f80c6e8 Fixing bug in cross-zone load balancing enablement
Fixes #8861
2014-09-04 09:53:41 -05:00
Alexander Gubin
7b98294903 Fix for #8886. Correct state=absent for statements without name/alias. 2014-09-04 14:35:39 +02:00
Kristofor Varhus
fc0675889e fix typo in zypper module (requiered -> required) 2014-09-03 13:03:59 -04:00
James Cammarata
758a0bbeb7 Adding ignore_scripts option to the argument_spec for npm 2014-09-03 10:24:09 -05:00
Mike Dixon
4510f2e5a1 Fix #8666 for real
Commit 311ec543af ("If not specified, do not modify subnet/route_tables for ec2 VPCs") mostly fixed the problem, except that it left defaults for subnets and route_tables so that not specifying them still deleted them.
2014-09-02 19:16:39 -07:00
James Cammarata
cb2520a73a Merge pull request #8843 from resmo/fix/boilerplate
zabbix_maintenance: move to new boilerplate
2014-09-02 13:44:24 -05:00
James Cammarata
b827f791e1 Merge pull request #8832 from sivel/rax-validate-regions
rax modules: Perform region validation early
2014-09-02 13:03:31 -05:00
James Cammarata
5b3c2097d8 Merge pull request #8831 from swindmill/devel
Add additional Azure Regions
2014-09-02 13:02:44 -05:00
James Cammarata
dcc8d73935 Fixing new ignore scripts option logic and name for the npm module 2014-09-02 12:13:15 -05:00
James Cammarata
2a43dc2ddf Merge branch 'npm-ignore-scripts' of https://github.com/tkellen/ansible into tkellen-npm-ignore-scripts 2014-09-02 12:09:31 -05:00
James Cammarata
3367c0ab8e Merge pull request #8803 from stygstra/quantum_subnet-docs
Fix description on quantum_subnet module
2014-09-02 11:08:35 -05:00
James Cammarata
bee1f8f420 Merge pull request #8788 from eest/service-service_enable_rcconf-changed
service: use self.changed in service_enable_rcconf().
2014-09-02 10:29:41 -05:00
James Cammarata
570425d306 Merge pull request #8775 from AdmiralNemo/portage-changed-use
portage: Add support for --changed-use
2014-09-02 10:15:27 -05:00
James Cammarata
21ed2baadf Merge pull request #8773 from mrevilme/ec2_fix_instances_list
Always return a list even if its empty.
2014-09-02 10:02:06 -05:00
Matt Martz
55ed4489e3 Perform region validation early to be more explicit about invalid region failures 2014-09-02 09:17:40 -05:00
Kristofor Varhus
acd37c87a9 zypper: handle lists of packages efficiently 2014-09-02 09:38:30 -04:00
Jon Hawkesworth
a57b6ccf46 This change selects the certificate from the winrm configuration and attempts to find the expiry date from that.
Trond Hindenes pointed out that simply picking the first certificate from local computer certs is not guaranteed to select the correct certificate.
2014-09-01 21:22:18 +01:00
Rene Moser
20a3772d85 zabbix_maintenance: move to new boilerplate 2014-09-01 20:13:34 +02:00
Jon Hawkesworth
e4b80dd43c Added null check in case http connection used and no cert found. 2014-08-31 16:20:50 +01:00
Sterling Windmill
0c8576bdd2 add additional Azure Regions 2014-08-31 09:15:46 -04:00
Tyler Kellen
4c954ec417 add support for --ignore-scripts when using npm 2014-08-29 16:06:10 -04:00
Chris Church
69e7999586 Merge pull request #8812 from trondhindenes/win_json_facts_setup_improvements
win_json_facts_setup_improvements; All changes referenced in PRs #8767 , #8768 , #8769
2014-08-29 15:53:42 -04:00
James Cammarata
4e3095877f Merge pull request #8791 from jrhe/aws_ec2_us-gov-west-1_region
Adds us-gov-west-1 aws ec2 region to cloud library
2014-08-29 09:34:09 -05:00
Trond Hindenes
72760f5999 All changes referenced in PRs #8767 , #8768 , #8769 :
This changes the get-attr function slightly, and lets the module specify whether a param is needed and auto-fails if it is not present. A module can now verify params like so::
 $params = Parse-Args $args;
 $result = New-Object psobject;
 Set-Attr $result "changed" $false;
 $path = Get-Attr -obj $params -name path -failifempty $true -resultobj $result

or

$params = Parse-Args $args;
 $result = New-Object psobject;
 Set-Attr $result "changed" $false;
 $path = Get-Attr -obj $params -name path -failifempty $true -emptyattributefailmessage "Oh man. You forgot the main part!" -resultobj $result

slight tweak in how the powershell module converts to json in order to support nested objects (allows for more complex facts, among others)

This script gathers some extended facts on windows hosts in a json array attribute called "ansible_interfaces". This info is needed for some network-related modules I'm working on. Required the update to powershell.ps1 to return deeply nested json objects.
2014-08-29 10:39:42 +02:00
James Cammarata
dbc980eaf4 Merge branch 'mischapeters-devel' into devel 2014-08-28 20:31:00 -05:00
James Cammarata
70ff6d35aa A10 module improvements
* moved common code to an module_util snippet
* rewrote logic to make each module idempotent
* added new capabilities like the write_config option
2014-08-28 20:23:48 -05:00
David Stygstra
9ae97a7754 Fix description on quantum_subnet module 2014-08-28 10:43:00 -04:00
Chris Church
0d1197a995 Replace Get-FileHash with MD5 code that works on PowerShell 3. 2014-08-28 01:42:22 -04:00
Jonathan Richard Henry Evans (JRHE)
62ef6d9a2b Adds us-gov-west-1 aws ec2 region to cloud library 2014-08-27 22:06:15 -04:00
Patrik Lundin
e65ca6876f service: use self.changed in service_enable_rcconf().
This sets the "changed" result of the module when a rc file is modified.
Previously only --check mode would show that it was going to change.
2014-08-28 00:52:23 +02:00
James Cammarata
90a42bb15a Merge branch 'devel' of https://github.com/mischapeters/ansible into mischapeters-devel 2014-08-27 13:03:37 -05:00
Dustin C. Hatch
a24ee0f31b portage: Add support for --changed-use
The `--changed-use` flag is an improvement over `--newuse` because it
does not trigger rebuilds for USE flag changes that would not affect the
installed package. Its use is generally recommended over `--newuse`.

Signed-off-by: Dustin C. Hatch <dustin@hatch.name>
2014-08-27 08:02:03 -05:00
Emil Palm
a373088d16 Always return a list even if its empty. 2014-08-27 11:07:19 +02:00
James Cammarata
64a6ab5fff Removing unused name param for wait_for tcp draining classes
Also updates the version_added and other references to the version
in which the connection draining functionality was added.
2014-08-26 20:36:11 -05:00
James Cammarata
4716f47d57 Merge branch 'devel' of https://github.com/gregswift/ansible into gregswift-devel 2014-08-26 20:06:43 -05:00
James Cammarata
36bd9efb70 Stop/remove existing docker container if the specified tag is different
Fixes #8278
2014-08-26 13:36:42 -05:00
James Cammarata
fa3676b848 Merge branch 'feature/makes-ec2-lc-boto-iso-functional' of https://github.com/botify-labs/ansible into botify-labs-feature/makes-ec2-lc-boto-iso-functional 2014-08-26 13:00:17 -05:00
James Cammarata
38eb5453b4 Add boto support checks for new ec2_elb_lb attribute fields
Also minor fixes like adjusting version_added fields, etc.
2014-08-26 10:58:25 -05:00
James Cammarata
adb00b9439 Merge branch 'elb-enhancements' of https://github.com/dataxu/ansible into dataxu-elb-enhancements 2014-08-26 10:05:34 -05:00
James Cammarata
d1d3394046 Docs updates to add examples for symbolic modes
Also fixes missing doc fragments missing in template and assemble
2014-08-26 09:09:08 -05:00
Peter Fry
35745aff22 Add support for volume encryption to ec2_vol
Fixes #7775
2014-08-25 16:21:28 -05:00
James Cammarata
d6a8d4671a Add additional checks to detect upstart services
Also adds checks for the upstart version, in order to test check
support for manual vs. start on manual
2014-08-25 13:41:39 -05:00
Eri Bastos
82ec224a93 Proposed fix for issue #7757 2014-08-25 12:10:14 -05:00
James Cammarata
795eaccecb Merge pull request #8725 from quiver/fix-get_url-content-disposition
[get_url module]parse content-disposition filename parameter even if it's not quoted
2014-08-25 10:43:06 -05:00
James Cammarata
0dda8a7996 Tweaking change to documentation language for cron name param 2014-08-25 09:54:21 -05:00
James Cammarata
a415993142 Merge branch 'devel' of https://github.com/mattparker/ansible into mattparker-devel 2014-08-25 09:51:17 -05:00
James Cammarata
2d683cbd30 Merge pull request #8740 from mattparker/patch-1
Name appears to be a required parameter for cron module
2014-08-25 09:49:58 -05:00
James Cammarata
69484fac7b Merge pull request #8736 from ericdwhite/issue-8735-Trim-docker-module-expose-items
module docker - expose will fail to port forward network connections if there are spaces in the CSV value
2014-08-25 09:46:22 -05:00
James Cammarata
0aec8244c8 Merge pull request #8738 from bcoca/acl_tilde_expansion
now acl expands tildes
2014-08-25 09:32:58 -05:00
James Cammarata
77ef324ab7 Merge pull request #8729 from ercpe/openrc-hostname
Hostname strategy implementation for OpenRC based systems (e.g. Gentoo)
2014-08-25 09:28:29 -05:00
Matt Parker
fd982cf8b7 Update cron documenation
The "name" parameter seems to be rather important as the identifying feature of a cron job.  This is an update to the documentation to further emphasize this.
2014-08-25 10:29:45 +01:00
Matt Parker
dc634bc644 Name appears to be a required parameter
As far as I can tell, `name` is a required parameter.  The guard test at (now) line 458 says you need name if `state == present` and at 464 if `state != present`, although that's not quite as clear.  Each of the code paths at 485 - 495 pass the name param through to `add_job`, `update_job` and `remove_job`, and the actual _update_job method earlier seems to require it too.  However I don't really know python so I may be wrong, but I can't see the circumstances when `name` is not required.
2014-08-25 10:23:54 +01:00
Brian Coca
f6e10b580e now acl expands tildes 2014-08-24 19:16:15 -04:00
Eric D. White
f44125ccb7 Issue 8735 - module docker - expose values should be striped to ensure port forwarding works. 2014-08-24 21:07:26 +01:00
Johann Schmitz
9945a732f7 Hostname strategy implementation for OpenRC based systems (e.g. Gentoo) 2014-08-23 09:00:28 +02:00
George Yoshida
b2385870af For content-disposition response header field, try to parse filename parameter even if it's not quoted. 2014-08-23 12:10:45 +09:00
Michael DeHaan
a419ffdf41 Make command warnings off by default to minimize surprises. 2014-08-22 16:12:48 -04:00
Michael DeHaan
7ffa9cecae Docs for command warnings feature. 2014-08-22 15:37:07 -04:00
Michael DeHaan
fcb610dec4 Slightly trim down the warnings list based on some things being pretty common
for local usage.
2014-08-22 15:37:07 -04:00
Will Thames
ab8490d003 Added warnings to command module
Generate warnings when users are shelling out to commands
rather than using modules

Can be turned off on a per-action line with the documented
warn=False flag. Can be turned off globally using
command_warnings = False in ansible config file.

Print out warnings using the standard playbook callbacks.

Created some additional tests in TestRunner.test_command
and also a demonstration playbook.
2014-08-22 15:37:07 -04:00
James Cammarata
6b3f7a82fb Fixing bug with image/tag pulling in docker module
Fixes #8670
2014-08-22 14:08:40 -05:00
Michael DeHaan
3871eebfbb Merge pull request #8441 from willthames/unarchive_dest_fix
Unarchive should work when parent directory is not writable
2014-08-22 15:05:42 -04:00
Michael DeHaan
b0e863b3f8 Merge pull request #8659 from willthames/rds_module_connection_fix
rds_module: Fix AWS connection
2014-08-22 14:45:27 -04:00
James Cammarata
311ec543af If not specified, do not modify subnet/route_tables for ec2 VPCs
Also fixes a bug whereby any changes to the route_tables were not
properly reflected by setting changed=True.

Fixes #8666
2014-08-22 11:03:41 -05:00
Greg Swift
5ecfe884b8 Extend wait_for module to support draining of active tcp connections 2014-08-21 16:15:59 -05:00
James Cammarata
b98348c2c1 Merge branch 'relative-path-fix' of https://github.com/major/ansible into major-relative-path-fix 2014-08-21 15:32:51 -05:00
Major Hayden
c9cdc9d6f9 File module cannot create relative paths
When trying to create a directory relative to the current working
directory, a directory is created at the root of the filesystem
instead.  This patch ensures that directories specified with relative
paths will be created in the current working directory.  Fully
qualified paths aren't affected

Signed-off-by: Major Hayden <major@mhtx.net>
2014-08-21 15:31:06 -05:00
James Cammarata
8956c636a5 Remove incorrect use of module.fail_json during import check for s3
Fixes #8698
2014-08-20 12:04:46 -05:00
Paul Armstrong
09979ac20d asg-properties Get all the properties from ASG's 2014-08-19 15:25:47 -07:00
Michael DeHaan
e6be619257 Merge pull request #8678 from 0x44/debconf-vtypes
debconf module: add the missing 'error' vtype and reorder vtypes as they...
2014-08-19 17:57:53 -04:00
James Cammarata
8648fa175c Removing skipped=True from result when using creates= and removes=
Fixes #8645
2014-08-19 09:09:13 -05:00
Michael DeHaan
47f4dec676 In order to allow easier updates from upstream hardware vendors, we're going to be hosting network hardware
config modules on Galaxy as announced during the last release cycle.   (This excludes load balancers, which remain in core).

Please refer to https://eos.arista.com/introducing-arista-eos-roles-for-ansible/ and https://galaxy.ansible.com/list#/roles/1359
and where this content now lives.

Thanks to Peter Sprygada for the roles content!
2014-08-19 08:31:49 -04:00
Ding Deng
13db184d7f debconf module: add the missing 'error' vtype and reorder vtypes as they appeared in debconf-devel(7). 2014-08-19 17:44:02 +08:00
James Cammarata
379e31883c Fix check mode issues with copy module
Fixes #8639
2014-08-18 16:02:45 -05:00
James Cammarata
e2b8f05b79 Add option to disable ControlPath to ssh options during rsync
Fixes #8473
2014-08-18 12:59:00 -05:00
James Cammarata
92f7aa79b0 Fix bad commit from #8095 and fix bad splitting on :'s in the image
Fixes #8095
Fixes #8658
2014-08-18 10:37:07 -05:00
Will Thames
0083212704 Fix RDS AWS connection
Use the common AWS connection improvements so that security_token,
boto_profile etc. are taken into account
2014-08-18 14:43:07 +10:00
Michael DeHaan
91560c00a9 Merge pull request #8627 from rghe/devel
fixes #8626 by reverting 0d8b81cd
2014-08-15 13:42:11 -04:00
James Cammarata
8dafacd4e9 Make env param a dict type instead of list
Also modifies param type checking code to remove whitespace from
around params before splitting them into k=v pairs.

Fixes #8199
2014-08-15 11:04:27 -05:00
rghe
9b6df6d9a8 fixes #8626 by reverting 0d8b81cd 2014-08-14 18:10:58 +02:00
Michael DeHaan
9e0090e21b Merge pull request #8612 from mjaschen-forks/devel
Homebrew module: Added `+` and `.` characters to the package name regex.
2014-08-14 10:52:25 -04:00
Marcus Jaschen
c6ac95d403 Homebrew module: Added + and . characters to the package name regex.
Solves installation failures for packages like `bonnie++` or
`virtualhost.sh` as described in #8413.
2014-08-13 22:31:03 +02:00
Eric Brown
8e6c219ee9 Update keystone_user doc for tenant_description
The description var should be tenant_description.

Closes-bug: #8299
2014-08-12 16:49:33 -07:00
Eric Brown
5ce366c6a2 Fix the docs for glance_image.endpoint_type
The endpoint_type option was added in version 1.7,
so the docs need to state this.  Also the the description
is too brief.
2014-08-12 16:40:01 -07:00
James Cammarata
a04efa2d84 Update docs for copy directory_mode param per #8572 2014-08-12 12:19:13 -05:00
Michael DeHaan
f186bcc936 Copy recursion works when source is a parameter, there is no parameter 'recurse' here. 2014-08-11 16:22:13 -04:00
Michael DeHaan
734548d8b4 Merge pull request #8525 from kamaln7/patch-1
Replace all occurrences of "Digital Ocean" with "DigitalOcean"
2014-08-11 16:04:04 -04:00
Matt Martz
315ac22437 Need to check e.errno instead of os.errno. Fixes #8548 2014-08-11 12:26:52 -05:00
James Cammarata
83fa9a8cde Make sure we only use unquote on quoted lines in lineinfile when needed 2014-08-11 11:23:52 -05:00
James Cammarata
b3371b8de8 Unquote lines that were quoted for safety during eval in lineinfile
Fixes #8535
2014-08-11 11:01:23 -05:00
Michael DeHaan
e66e4adedc Merge pull request #8532 from piffey/8502_acl
Issue 8502: Fixed bug where failed when permissions weren't specified.
2014-08-11 08:15:27 -04:00
Michael DeHaan
82564df61a Merge pull request #8544 from Tenzer/faster-apt_repository
apt_repository: Check if key already exists before adding it
2014-08-11 08:09:19 -04:00
Jeppe Toustrup
b811df38a7 apt_repository: Check if key already exists before trying to add it for a speed increase 2014-08-11 11:57:23 +02:00
Mischa Peters
5b9b42056e PEP8 Compliant except needed long lines and better exception handling 2014-08-10 11:25:19 +02:00
Piffey Parlance
cb0b06aa42 Issue 8502: Fixed bug where failed when permissions weren't specified. 2014-08-09 12:02:24 -05:00
Michael DeHaan
3d22e769d4 Merge pull request #8531 from sivel/rax-cdb-dedupe-docfrag
rax_cdb* modules: Dedupe code and switch to shared doc fragments
2014-08-08 20:59:11 -04:00
James Cammarata
535fb7345a Bumping version_added for use_ssl param in irc module 2014-08-08 19:43:20 -05:00
James Cammarata
a1ae05e9a0 Merge branch 'ah/add_ssl_for_irc' of https://github.com/ahamilton55/ansible into ahamilton55-ah/add_ssl_for_irc 2014-08-08 19:39:46 -05:00