Commit graph

25731 commits

Author SHA1 Message Date
Michael Eaton
2419806970 update author (#52583) 2019-02-22 10:24:16 +00:00
John R Barker
b3a3328ea6
Better document the return type of the fileglob filter (#52801)
https://github.com/ansible/ansible/pull/44986

Fixes #33465

Thanks to DaveB93 for the suggestion.
2019-02-22 10:23:15 +00:00
Sven Wegener
a966662e9a crypttab: Trim trailing newlines (#51594)
Having a comment or an empty line in /etc/crypttab results in an
additional empty line being added, because the newline that is part of
the line being read is getting re-injected in addition to the newline
used to concatenate the lines.

Signed-off-by: Sven Wegener <sven.wegener@inovex.de>
2019-02-22 09:25:23 +00:00
qw34ty
8724c0deda lxd_container fix to check for snap package install unix.socket #34924 (#51541)
* -added simple check to check snap unix.socket #34924

* fixed whitespacing around assignment

* documented snap_url variable

* documented snap_url variable

* documented snap_var

* updaed snap_var doc

* version_added: to documenation

* -updated check method to more reliable approach

* -fixed whitespace missing in replace
2019-02-22 09:24:07 +00:00
Lukas Kämmerling
861b7742fd Add Hetzner Cloud Inventory Plugin (#52553)
* Add hcloud Inventory Plugin

* Rename hcloudAPIException to APIException

* Apply changes from hcloud-python 1.0.0
Some source cleanup

* Add handling for server.image is None

* Fix some small things.

* Fix some small things.

* Remove some golang-ish code

* Apply review results

* Fix ci tests
2019-02-22 09:18:30 +00:00
Albert Cervera i Areny
e0274adafe Filter DNSimple request by record name. (#49981)
* Filter DNSimple request by record name.

The request was not filtered and DNSimple returns only the first 100
records so if the number of records is larger the check could fail.

This patch fixes the issue and also makes the check to perform better.

* Add changelog fragment.
2019-02-22 08:58:16 +00:00
Tuan Anh Hoang-Vu
b0fc2a2103 Fixed lvol ValueError with float size. (#36811)
* Fixed lvol ValueError with float size.

* Fixed lvol ValueError with float size.

* Initialized locale using system default.
Changed size validation from float() to locale.atof().

* Added changelog fragment.
2019-02-22 08:41:50 +00:00
Juan Antonio Osorio
28d2379e69 identity: Issue warning if GSSAPI parameters can't be used (#52721)
This issues a warning if the relevant parameters to use GSSAPI were
provided, but the needed library is not installed in the system.

This is meant for usability, since it'll tell folks what they're missing
in their systems in order to use GSSAPI for authentication with the
FreeIPA modules.

This also removes the "required" key from the password parameter; now
this is checked in runtime.
2019-02-22 08:39:42 +00:00
rockandska
540b07b884 Fix idempotence in rabbitmq_plugin (#52166)
* Fix idempotence in rabbitmq_plugin

* Add changelog fragment
2019-02-22 08:36:32 +00:00
arsenicks
d3fcdae4ad Katello: Added product to the dict choices (#49776)
* Added product to the dict choices.

Following issue 48594 where product is not a recognised choice: https://github.com/ansible/ansible/issues/48594

* fixed doc

added - product to the doc

* split line 549

to correct ci test splitting line 549

* Create 49776-product_fix_katello_foreman_module.yaml

changelog fragment creation
2019-02-22 08:27:34 +00:00
Yunge Zhu
28dadc9e18
add application security group facts (#52629) 2019-02-22 16:11:24 +08:00
Andrew Crosby
bc2bbff6bc Update galaxy cli metadata file templates (#51398)
* Remove github_branch from galaxy meta file templates

Signed-off-by: Andrew Crosby <acrosby@redhat.com>

* Update galaxy meta license examples to valid SPDX IDs

Signed-off-by: Andrew Crosby <acrosby@redhat.com>
2019-02-22 00:54:02 -05:00
Yunge Zhu
d2297c50d2
add cdnendpoint facts module (#52631) 2019-02-22 13:51:38 +08:00
Abhijeet Kasurde
e41b98ffb5
VMware: Refactor guest inventory plugin (#52642)
* VMware: Refactor guest inventory plugin
* Review comments

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-02-22 09:55:57 +05:30
Jordan Borean
aab1f30906
group - fix explicit git scenario (#52769)
* group - fix explicit git scenario

* Use str for simplicity and remove changelog

* dynamically get gid and remove Jinja2 check
2019-02-22 12:40:42 +10:00
plumbeo
e73e9ecbc3 mysql_user: fix malformed regex used to check current privileges (#52278)
* mysql_user: fix malformed regex used to check current privileges

* Add changelog fragment for PR #52278
2019-02-21 16:39:51 -08:00
Rafael Driutti
c68838fb13 AWS Redshift: port module to boto3 and fix parameters check (#37052)
* fix parameters check and port module to boto3

* begin with integration tests

* allow redshift iam policy

* Wait for cluster to be created before moving on to delete it

* Allow sts credentials so this can be run in CI

Don't log credentials

ensure cluster can be removed

* - Replace DIY waiters with boto3 waiters
- test multi node cluster

* catch specific boto3 error codes

* remove wait from test

* add missing alias for shippable

* - Rework modify function.
- Default unavailable parameters to none.
- Add cluster modify test

* Ensure resources are cleaned up if tests fail

* Ensure all botocore ClientError and BotoCoreError exceptions are handled
2019-02-21 17:04:42 -06:00
Chandler Wilkerson
8b8c4aa473 Exempt register vars from shell expansion (#52594) 2019-02-21 20:21:00 +00:00
getjack
151ea2e009 - Initial commit (#51739)
- Fix sanity checks
  - Fixed documentation trailing whitespaces
2019-02-21 20:13:41 +00:00
Hannes Ljungberg
dd4b4aa941 docker_swarm_service: Add stop_grace_period option (#52519)
* Add stop_grace_period option

* Add changelog fragment

* Move doc type to last

* Add version_added
2019-02-21 20:12:13 +00:00
Miguel Angel Muñoz González
1234df131e Fortinet's FortiOS report chart (#52328) 2019-02-21 20:11:25 +00:00
Miguel Angel Muñoz González
f083cb5ebe Fortinet's FortiOS report dataset (#52330) 2019-02-21 20:10:52 +00:00
Miguel Angel Muñoz González
4abdd37330 Fortinet's FortiOS router access list (#52340) 2019-02-21 20:10:32 +00:00
Miguel Angel Muñoz González
77698a3039 Fortinet's FortiOS system accprofile (#52344) 2019-02-21 20:10:20 +00:00
Miguel Angel Muñoz González
74f2c61c35 Fortinet's FortiOS system admin (#52345) 2019-02-21 20:09:54 +00:00
Miguel Angel Muñoz González
48aa9e87a4 Fortinet's FortiOS system api user (#52346) 2019-02-21 20:09:43 +00:00
Miguel Angel Muñoz González
1d51607426 Fortinet's FortiOS vpn ipsec concentrator (#52362) 2019-02-21 20:09:30 +00:00
Miguel Angel Muñoz González
17f0d45bc0 Fortinet's FortiOS vpn ipsec manualkey (#52361) 2019-02-21 20:09:08 +00:00
Miguel Angel Muñoz González
7276381f48 Fortinet's FortiOS system vdom (#52357) 2019-02-21 20:08:58 +00:00
Miguel Angel Muñoz González
2a65c72a6a Fortinet's FortiOS vpn ipsec phase2 interface (#52368) 2019-02-21 19:59:29 +00:00
Miguel Angel Muñoz González
5118e69ac8 Fortinet's FortiOS vpn ipsec phase2 (#52367) 2019-02-21 19:59:07 +00:00
Miguel Angel Muñoz González
c2b764aca2 Fortinet's FortiOS vpn ipsec phase1 interface (#52366) 2019-02-21 19:58:43 +00:00
Miguel Angel Muñoz González
7a8529ecbd Fortinet's FortiOS vpn ipsec manualkey interface (#52364) 2019-02-21 19:58:24 +00:00
Miguel Angel Muñoz González
e2c2910f25 Fortinet's FortiOS vpn ipsec phase1 (#52365) 2019-02-21 19:58:03 +00:00
Miguel Angel Muñoz González
18e8cc90d1 Fortinet's FortiOS vpn ipsec forticlient (#52363) 2019-02-21 19:55:13 +00:00
Miguel Angel Muñoz González
8d341145e1 Fortinet's FortiOS system dns (#52392) 2019-02-21 19:52:00 +00:00
Miguel Angel Muñoz González
0359048edd Fortinet's FortiOS router auth path (#52394) 2019-02-21 19:51:39 +00:00
Miguel Angel Muñoz González
61337f4134 Fortinet's FortiOS router bfd6 (#52395) 2019-02-21 19:51:30 +00:00
Miguel Angel Muñoz González
d7ba0503d1 Fortinet's FortiOS router bfd (#52396) 2019-02-21 19:51:13 +00:00
Miguel Angel Muñoz González
bce0f2152c Fortinet's FortiOS router bgp (#52397) 2019-02-21 19:47:06 +00:00
Miguel Angel Muñoz González
8cfeea04c4 Fortinet's FortiOS router multicast6 (#52398) 2019-02-21 19:46:52 +00:00
Miguel Angel Muñoz González
348a152841 Fortinet's FortiOS router multicast (#52399) 2019-02-21 19:44:16 +00:00
Miguel Angel Muñoz González
648d4ee5d7 Fortinet's FortiOS router multicast flow (#52400) 2019-02-21 19:43:43 +00:00
Miguel Angel Muñoz González
64aa986299 Fortinet's FortiOS router ospf6 (#52401) 2019-02-21 19:43:34 +00:00
Miguel Angel Muñoz González
0b5ce6b455 Fortinet's FortiOS router ospf (#52403) 2019-02-21 19:42:11 +00:00
Miguel Angel Muñoz González
c691e72968 Fortinet's FortiOS router policy6 (#52404) 2019-02-21 19:42:02 +00:00
Miguel Angel Muñoz González
c2c595d6b0 Fortinet's FortiOS router policy (#52405) 2019-02-21 19:41:42 +00:00
Miguel Angel Muñoz González
241857c11f Fortinet's FortiOS router setting (#52406) 2019-02-21 19:41:28 +00:00
Miguel Angel Muñoz González
e6cc44200c Fortinet's FortiOS router prefix list (#52677) 2019-02-21 19:18:32 +00:00
Miguel Angel Muñoz González
56b9913cd8 Fortinet's FortiOS router rip (#52678) 2019-02-21 19:18:19 +00:00
Miguel Angel Muñoz González
9fce539e5f Fortinet's FortiOS router static (#52679) 2019-02-21 19:18:09 +00:00
Chris Archibald
d32d03ce27 Add policy to na_ontap_snapmirror (#51497)
* changes to clusteR

* Revert "changes to clusteR"

This reverts commit 33ee1b71e4bc8435fb315762a871f8c4cb6c5f80.

* bug fixes for snapmirror

* mirror fixes

* updates
2019-02-21 19:05:17 +00:00
Chris Archibald
740d53011e Change na_ontap_igroup to NetAppModule module format (#52280)
* Revert "changes to clusteR"

This reverts commit 33ee1b71e4bc8435fb315762a871f8c4cb6c5f80.

* update to igroup

* fix author

* Revert "Revert "changes to clusteR""

This reverts commit 2c51779211.
2019-02-21 19:01:36 +00:00
Bas
ffd8f8d844 fixing some yamllint issues (#42775) 2019-02-21 11:58:42 -06:00
Matt Martz
269cdffcea
Format dict keys need to be bytes (#52728) 2019-02-21 11:43:45 -06:00
Matt Martz
f90610e48c
type should be a string, not callable bool (#52735) 2019-02-21 11:23:53 -06:00
Chris Archibald
fdc3f16bba New Module: Ontap Igroup initiator (#52281)
* Revert "changes to clusteR"

This reverts commit 33ee1b71e4bc8435fb315762a871f8c4cb6c5f80.

* Add igroup initiator

* fix author

* Revert "Revert "changes to clusteR""

This reverts commit 2c51779211.
2019-02-21 16:02:32 +00:00
Chris Archibald
fde2e2d195 New Module: Allow for copy of Luns (#52285)
* Revert "changes to clusteR"

This reverts commit 33ee1b71e4bc8435fb315762a871f8c4cb6c5f80.

* add lun copy

* Revert "Revert "changes to clusteR""

This reverts commit 8e56b999e6.
2019-02-21 16:02:05 +00:00
Chris Archibald
d63794741f New Module: Manage security keys (#52291)
* Revert "changes to clusteR"

This reverts commit 33ee1b71e4bc8435fb315762a871f8c4cb6c5f80.

* add key manager

* Revert "Revert "changes to clusteR""

This reverts commit 8e56b999e6.
2019-02-21 15:35:00 +00:00
Chris Archibald
cf491e8b5b Modify na_ontap_service_processor_network to use NetAppModule, add new option to wait for completion, and unit tests. (#52292)
* Revert "changes to clusteR"

This reverts commit 33ee1b71e4bc8435fb315762a871f8c4cb6c5f80.

* updates

* fix docs

* Revert "Revert "changes to clusteR""

This reverts commit 8e56b999e6.

* fix docs
2019-02-21 15:34:24 +00:00
Chris Archibald
42fe43a0c7 New options for na_ontap_aggregate (wait_for_online, and time_out) (#52353)
* Revert "changes to clusteR"

This reverts commit 33ee1b71e4bc8435fb315762a871f8c4cb6c5f80.

* updates

* fix author

* Revert "Revert "changes to clusteR""

This reverts commit 8e56b999e6.

* update copyright

* fix doc
2019-02-21 15:20:03 +00:00
Chris Archibald
a60740a37d New Module: na_ontap_vscan_on_demand_task (#51183)
* changes to clusteR

* Revert "changes to clusteR"

This reverts commit 33ee1b71e4bc8435fb315762a871f8c4cb6c5f80.

* Add vscan on demand task

* fix author line
2019-02-21 15:13:45 +00:00
Chris Archibald
bd8e75a67b Make na_ontap_user idempotent (#51509)
* changes to clusteR

* Revert "changes to clusteR"

This reverts commit 33ee1b71e4bc8435fb315762a871f8c4cb6c5f80.

* Fix Idempotent issue

* Fix author

* Fix author
2019-02-21 15:11:07 +00:00
Zim Kalinowski
053081a8a0 use the same C() everywhere for absent / present options (#52610)
* use the same C() everywhere for absent / present options

* Update lib/ansible/modules/cloud/azure/azure_rm_cdnendpoint.py

* Update lib/ansible/modules/cloud/azure/azure_rm_resourcegroup.py

* Update lib/ansible/modules/cloud/azure/azure_rm_cdnendpoint.py

* Update lib/ansible/modules/cloud/azure/azure_rm_cdnendpoint.py

Co-Authored-By: zikalino <zikalino@microsoft.com>
2019-02-21 09:07:10 -06:00
Chris Archibald
a722133640 Modify job schedule to allow list of date and times instead of a single datetime (#51510)
* changes to clusteR

* Revert "changes to clusteR"

This reverts commit 33ee1b71e4bc8435fb315762a871f8c4cb6c5f80.

* allow for more than 1 time to be set

* move file to correct directory

* Ansibot fixes
2019-02-21 15:04:55 +00:00
Ted Timmons
4876e9a48a specify basic minimum botocore version for this module (#52417)
Bump the version and give a warning. It took me 30+ mins to carefully look through botocore to find the minimum version. Grumble.
Fixes #52393, partially helps #39085.

* Update lib/ansible/modules/cloud/amazon/cloudformation.py

Co-Authored-By: tedder <ted@perljam.net>
2019-02-21 09:02:56 -06:00
Mahendra Yadav
62f5391da9 Add pyFG as requirement instead of note (#52667) 2019-02-21 08:52:57 -06:00
Abhijeet Kasurde
1b3cde353d osx_defaults: refactor (#52452)
* Code refactor
* Documentation update
* Add 'list' parameter
* Example update
* Testcase for osx_defaults

Fixes: #29329

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-02-21 14:37:16 +01:00
Miguel Angel Muñoz González
9b459646d6 Fortinet's FortiOS vpn ssl settings (#52680) 2019-02-21 13:24:03 +00:00
Miguel Angel Muñoz González
b0cd3957c0 Fortinet's FortiOS user radius (#52681)
* Fortinet's FortiOS user radius

* Change boolean value to uppercase

* Remove brackets from description

* Remove brackets and curly brackets
2019-02-21 13:23:49 +00:00
Miguel Angel Muñoz González
7732eb6b63 Fortinet's FortiOS vpn ssl web portal (#52682) 2019-02-21 13:23:34 +00:00
Hannes Ljungberg
da8574c567 docker_swarm_service: Allow passing period strings on relevant options (#52530)
* Allow duration to be passed as duration strings

* Remove whitespace

* Add changelog fragment

* Fix broken test

* Better error handling
2019-02-21 11:47:06 +00:00
Hannes Ljungberg
7276344f85 docker_swarm_service: Don’t remove service when networks change (#52634)
* Don’t remove service when networks change

* Add changelog fragment

* Some more network integration tests

* Add hannseman as author

* Remove return on self.client.fail
2019-02-21 11:46:50 +00:00
Shivam Singhal
19cf956453 Fixes typo digeset to digest (#52709) 2019-02-21 16:23:42 +05:30
Shivam Singhal
e931dd0e58 Fixes typo of formating to formatting (#52710) 2019-02-21 16:03:48 +05:30
Yunge Zhu
55e9acb043 support application security group in network interface (#52450) 2019-02-21 17:23:09 +08:00
Shivam Singhal
aa2cf46a09 Fixes typo of 'registed' to 'registered' (#52708) 2019-02-21 13:41:19 +05:30
Diane Wang
d6ef07ca45 modify doc description of disk.datastore (#52695) 2019-02-20 23:35:34 -05:00
Zim Kalinowski
4292c33649 adding tags to azure_rm_sqldatabase (#52615)
* adding tags to sql database

* can't add version_added, so have to ignore sanity test

* removed ignore
2019-02-20 16:17:45 -08:00
Zim Kalinowski
20a96bcc4e dev test labs artifacts and virtual machine modules (#51462)
* dev test labs vm and artifacts

* fix sanity

* fixing sanity

* disable artifact test for now

* + vn update

* fix sanity

* fixed test issue

* one more merge update

* fixed assert
2019-02-20 16:02:09 -08:00
Anil Kumar Muraleedharan
c9fea2b74b Lenovo cnos lldp (#52568)
* To add new module cnos_lldp.
2019-02-20 17:30:09 -05:00
Brian Coca
8a0347ac7a
warn when having issues with local facts (#52507)
* warn when having issues with local facts

fixes 41609
2019-02-20 17:25:55 -05:00
Zim Kalinowski
9d11cd311b adding vmss instance module (#51461)
* adding vmss instance

* fix indent

* fixing doc
2019-02-20 13:50:46 -08:00
The Magician
a6752f002b Bug fixes for GCP modules (#52616) 2019-02-20 16:27:05 -05:00
Sandra McCann
a94d16adef add agnostic doc fragment (#52673) 2019-02-20 15:18:12 -06:00
Nathaniel Case
1b9745722e
Fix issues with enable become plugin (#52657)
* Work around become_user not being set
2019-02-20 16:15:45 -05:00
Piotr Wojciechowski
67f14772b1 docker_node: labels operation fails when parameter 'labels' is None (#52662)
* docker_node: Fix for situation where labels parameter is None

* docker_node: Fix for situation where labels parameter is None and labels are not removed
2019-02-20 16:04:42 -05:00
Veaceslav Mindru
6f91bccf78 handle non strings in requirements version for ansible-galaxy (#52109) 2019-02-20 14:28:04 -05:00
The Magician
90a199a0ee Bug fixes for GCP modules (#52617) 2019-02-20 13:12:40 -05:00
The Magician
9291f48964 Bug fixes for GCP modules (#52618) 2019-02-20 13:12:12 -05:00
The Magician
0b16286254 Bug fixes for GCP modules (#52619) 2019-02-20 13:11:55 -05:00
The Magician
471b20bab3 New Module: gcp_cloudbuild_trigger (#52621) 2019-02-20 13:11:40 -05:00
The Magician
67eac8d7c0 New Module: gcp_cloudbuild_trigger_facts (#52622) 2019-02-20 13:11:28 -05:00
Sayed Anisul Hoque
1651d4f21a jira: Fixes json reading string object instead of byte (#52660) 2019-02-20 22:22:01 +05:30
Christian Kotte
bd0cad6ed7 Improve vmware_vmkernel module (#47270)
* update description and examples
* show updated settings
* add check mode support
* Remove unused option `vlan_id`
* add vDS support
* add TCP/IP stack support
2019-02-20 21:27:35 +05:30
David Passante
5abeb9659b cloudstack: streamline modules doc (#52509)
* cloudstack: streamline modules doc (first 5)

* Remove the "local_action" style from the examples
2019-02-20 10:53:31 -05:00
Anatoly Pugachev
924f5b5467 Add support of facts gathering WWNs on Solaris 10 and Solaris 11 OS (#52091)
* Add support of facts gathering WWNs on Solaris 10 and Solaris 11 OS

Extends PR #37043 / git commit c65909d "Add network fact to obtain FC
WWN initiator ports" for Solaris OS support.

$ fcinfo hba-port | grep 'Port WWN'
HBA Port WWN: 10000090fa1658de
HBA Port WWN: 10000090fa1658df
HBA Port WWN: 10000090fa165b5c
HBA Port WWN: 10000090fa165b5d

* use module.get_bin_path() instead of hardcoded cmd path
2019-02-20 10:46:54 -05:00
Alan Rominger
62feba3d15 support deterministic host ordering from group ancestors (#44067)
Fixes #44065
2019-02-20 10:41:25 -05:00
Zim Kalinowski
9b5514928a improving consistency of azure examples/documentation - 2 (#52572)
* normalizing azure example naming conventions - 2
2019-02-20 07:39:41 -06:00
Stanislas
220d0cb16b Fix typo in lxd_container module (#52644) 2019-02-20 07:37:11 -06:00