cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity
50911 commits 47 branches 390 tags 440 MiB
Commit graph

316 commits

Author SHA1 Message Date
Felix Fontein
18f7c3b850
Netapp: rename _facts -> _info (#60980) 
* Rename na_ontap_gather_facts -> na_ontap_info
Rename netapp_e_facts -> netapp_e_info

* Add changelog.

* Fix sanity.

* Forgot test.

* Forgot to remove 'gather'.

* Fix sanity ignore.

* Remove netapp_e_facts from PR.

* Remove superfluous version_added.
 2019-08-22 22:51:45 +02:00
Sumit Jaiswal
47243b0b2d
Resource module for iosxr_interfaces (#59853) 
* iosxr interfaces resource

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
 2019-08-22 21:27:41 +05:30
Nathaniel Case
8c5936671e
Add new module eos_l3_interfaces (#59820) 
* Update base files for resource modules

* Add modules

* Add module_utils

* Add tests

* Deprecate eos_l3_interface

* Update facts
 2019-08-22 09:06:38 -04:00
Miguel Angel Muñoz González
3ea55fc254 Fortinet's new module for fortios_system_settings (#60952) 
* Fortinet's new module for fortios_system_settings

* Avoid warnings on E336 a E336 for system settings
 2019-08-22 18:19:02 +05:30
Miguel Angel Muñoz González
628aa3a808 FortiOS modules for 2.9 - 5 (#61062) 
* FortiOS modules for 2.9 - 5

* Update fortios_firewall_vip.py

* Update fortios_firewall_vip6.py
 2019-08-22 17:44:17 +05:30
Fortinet Core CSE NA
df6d46fed3 Fortinet: fmgr_fwpol_ipv4 update/behavioral option fix (#58154) 
* PR Update to fmgr_fwpol_ipv4 -- now allows for failure or skip behavior option upon missing dependencies

* fmgr_fwpol_ipv4 minor docs fix

* Removed "system_package_print" line from test/sanity/ignore.txt as instructed by failed shippable test.

Actual PR module isn't affected.
 2019-08-22 15:54:46 +05:30
Pedro Magalhães
145a6a8756 maven_artifact.py - add support for version ranges by using spec (#54309) 2019-08-21 14:33:28 +01:00
Lukas Kämmerling
96199be96b Rename hcloud_*_facts to hcloud_*_info (#60926) 
* Rename hcloud_datacenter_facts to hcloud_datacenter_info

* Rename hcloud_location_facts to hcloud_location_info

* Rename hcloud_image_facts to hcloud_image_info

* Rename hcloud_floating_ip_facts to hcloud_floating_ip_info

* Rename hcloud_server_type_facts to hcloud_server_type_info

* Rename hcloud_server_facts to hcloud_server_info

* Rename hcloud_ssh_key_facts to hcloud_ssh_key_info

* Rename hcloud_volume_facts to hcloud_volume_info

* Fix typo in hcloud_image_info

* Add to porting guide and add changelog fragment

* Reword porting guide
 2019-08-21 14:55:37 +02:00
Felix Fontein
c1b2aa1d11
nginx_status_facts: deprecate/rename to nginx_status_info (#60979) 
* Rename nginx_status_facts -> nginx_status_info

* Add changelog.

* Remove warnings.

* Re-add ignore.txt entries.

* ...

* Raw strings for docs.

* Use U(...) for link.
 2019-08-21 09:09:22 +02:00
Rohit
8b3ff933af
Vyos lldp interfaces (#60931) 
* module_utils checkin

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* vyos lldp_interfaces merging

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* shippable fix

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* merge changes

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* failure added in ignore list

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* comments incorporated

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* comments incorporated

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* test cases updated

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* remove global commands

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
 2019-08-21 12:30:13 +05:30
chkp-orso
f1d568749f fix: Checkpoint check_mode, add suboptions, return the facts (#60264) 
* fix: check_mode, add suboptions, return the facts

* pip8, ansible_facts, get_payload

* add space to create PR

* remove space to create PR

* test tests of cp_network

* change for the test of network

* fixes to pass the tests

* fix tests

* Update ignore.txt
 2019-08-21 12:23:17 +05:30
Matt Clay
32b0a72547
Support windows-integration on collections. (#60984) 
* Support windows-integration on collections.

* Update configure-remoting-ps1 sanity test.

* Add copy of ConfigureRemotingForAnsible.ps1.

* Add ignore entry for copied file.
 2019-08-20 22:23:28 -07:00
Felix Fontein
e58919bccd
gluster_heal_facts: rename to gluster_heal_info (#60919) 
* Rename gluster_heal_facts -> gluster_heal_info

* Add changelog.
 2019-08-20 15:43:41 +02:00
Felix Fontein
c66163b118
hpilo_facts: rename to hpilo_info (#60917) 
* Rename hpilo_facts -> hpilo_info

* Fix porting guide.

* Add changelog.
 2019-08-20 15:14:18 +02:00
Miguel Angel Muñoz González
3cd70f53cc FortiOS modules for 2.9 - 4 (#60806) 
* FortiOS modules for 2.9 - 4

* Update ignore.txt

* Updates from maintainers to legacy modules

* Update fortios_firewall_ssl_setting.py

* Update fortios_firewall_ssl_server.py
 2019-08-20 16:11:11 +05:30
Nathaniel Case
efa163a2e8
New module eos_lag_interfaces (#60610) 
* Copy module files

* Deprecate eos_linkagg

* Add tests
 2019-08-19 15:34:20 -04:00
Nathaniel Case
d9ffc61539
Add new module eos_l2_interfaces (#59794) 
* Add module files for l2_interfaces

* Add module_utils

* Add tests

* Deprecate eos_l2_interface

* Clean up tests so eos_vlan will still pass
 2019-08-19 11:24:36 -04:00
Nathaniel Case
446dcb7c96
New module eos_vlans (#60652) 
* Initial commit of module files

* Add tests, implement facts

* Implement config, fix issues

* Handle vlan ranges from the device

* Deprecate eos_vlan
 2019-08-19 09:02:38 -04:00
Miguel Angel Muñoz González
decb016a2d FortiOS modules for 2.9 - 3 (#60678) 
* FortiOS modules for 2.9 - 3

* Remove default values in doc, as suggested from review

* Retriggering due to shippable failure

* Update fortios_firewall_ipv6_eh_filter.py

* Update fortios_firewall_ipmacbinding_setting.py

* Update fortios_firewall_ippool.py

* Update fortios_firewall_local_in_policy6.py

* Update fortios_firewall_local_in_policy.py
 2019-08-19 18:18:11 +05:30
Rohit
d8f9904f43
vyos_lldp_global (#59627) 
* vyos_lldp_global

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* sanity checks

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* deprecated changes

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* comments incorporated

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* test cases updated

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* comments incorporated

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* branch conflict resolved

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* sanity check passes

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
 2019-08-19 17:31:09 +05:30
Sumit Jaiswal
b55a54469c
Resource module for ios_vlans (#59640) 
* ios_vlans resource module

* fix shippable error

* fix shippable

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* fix vlans resource

* fix facts doc

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* fix shippable n review

* fix test

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* fix indentation

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* fix review

* fix shebang

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
 2019-08-19 16:03:29 +05:30
Felix Fontein
26b9c81a8e
crypto modules: fix sanity errors (#60046) 
* Remove sanity warnings.

* Linting.

* More linting.

* Forgot one place.

* no_bytes -> num_bytes
 2019-08-18 05:37:57 +02:00
Sumit Jaiswal
ab07c206aa
Resource module for ios_l2_interfaces (#60344) 
* ios_l2_interface checkin

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
 2019-08-17 23:02:36 +05:30
Miguel Angel Muñoz González
ca28ae3be5 FortiOS modules for 2.9 - 2 (#60598) 
* FortiOS modules for 2.9 - 2

* Fix long lines and ignore.txt
 2019-08-16 20:34:37 +05:30
Miguel Angel Muñoz González
4cae96109b FortiOS modules for 2.9 - 1 (#60469) 
* FortiOS modules for 2.9 - 1

* Fix empty choices and avoid E337,E338 warnings

* Ansible comments on version_added and ignore.txt only on this PR files

* Add version_added also for state attribute

* Avoid null choices on dlp_sensor

* Change required flag according to argspec
 2019-08-14 19:44:51 +05:30
Rohit
69bc24f607
lag interfaces resource module (#59175) 
* lag interfaces resource module

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* sanity check imports

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* sanity fixes

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* dict_diff usage issue fix

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* new task

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* overridden updated

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* dict update

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* comments incorporated

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* facts merged

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* rebased and merged

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* new failures added

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* obsolete file removed

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* test cases updated

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* comments incorporated

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* dependency added

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
 2019-08-14 17:31:49 +05:30
Trishna Guha
d5d88f9b11
Add nxos_interfaces resource module (#60421) 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2019-08-14 13:38:22 +05:30
Matt Clay
60f8483603
Add missing boilerplate to collections test. (#60507) 
* Add missing boilerplate to collections test.
* Remove redundant Python version check.
 2019-08-13 12:20:14 -07:00
Nathaniel Case
6b5c7f7c42
Add new module eos_interfaces (#59729) 
* Move module_utils

* Add eos_interfaces and deprecate eos_interface

* Add boilerplate, update ignores.txt

* Try to reconcile eos provider documentation with argspec

* Try to work around unknown interfaces

* Move param_list_to_dict to utils
 2019-08-13 10:09:52 -04:00
Felix Fontein
2d98734ad5 Amazon modules: rename _facts with ansible_facts result to _info (#60178) 
* aws_s3_bucket_facts -> aws_s3_bucket_info

* cloudformation_facts -> cloudformation_info

* cloudfront_facts -> cloudfront_info

* ecs_service_facts -> ecs_service_info

* efs_facts -> efs_info

* Add changelog and porting guide entry.

* lambda_facts -> lambda_info

* Improve examples.

* Add subsection on renamed modules.

* Add sentence on registering variables.

* Fix ReST.

* Instead of renaming lambda_facts, deprecate it and replace with new module.

* Rename internal variable.

* Re-add sanity ignores for lambda_facts.
 2019-08-13 08:01:37 -04:00
Ganesh Nalawade
9efa00e762
Add [junos_lldp_global] model (#59712) 
* Add [junos_lldp_global] model

*  Add new resource module junos_lldp_global
*  Targets model https://github.com/ansible/network/pull/30
*  Deprecate junos_lldp module

* Run lldp integration test only if protocol supported
 2019-08-13 13:05:17 +05:30
Matt Clay
473bd6bb0a Relax boilerplate sanity tests. 
This will avoid requiring boilerplate for documentation only python files.
 2019-08-09 18:49:57 -07:00
Felix Fontein
3290b8343c
docker: fix sanity errors (#60047) 
* Remove sanity check errors.

* More linting.

* Forgot to update places.

* Remove choices which aren't provided in argspec.
 2019-08-09 23:50:11 +02:00
Matt Clay
6c09b5c659
Unit test cleanup. (#60315) 
* Clean up option parsing unit tests.
* Remove unused unit test marker and import.
 2019-08-09 08:31:13 -07:00
Felix Fontein
49e16922b2 Remove no longer necessary check (since elements is procesed for path). (#59953) 2019-08-09 09:40:26 +02:00
Ganesh Nalawade
309a58eafd
Add [junos_l2_interfaces] resource module (#59693) 
* Add [junos_l2_interfaces] resource module

*  Add new resource module junos_lag_interfaces.
*  Targets model https://github.com/ansible-network/resource_module_models/pull/12
*  Deprecate junos_l2_interface module

* Fix CI failures

* Fix CI issues
 2019-08-09 13:09:19 +05:30
Nathan Swartz
10543c8a4c Facts dev upstream (#57082) 
* Improved netapp_e_facts module.

Added the following facts:
  - storage system segment size
  - cache block size capabilities
  - workload tags
  - storage array hosts
  - host groups
  - list of mapped volumes for each initiator

* Remove proxy specific facts from netapp_e_facts module

* Add unit tests for netapp_e_facts module.
 2019-08-08 11:36:23 -04:00
Ganesh Nalawade
6f0aae256d
Add [junos_lldp_interfaces] model (#59720) 
* Add [junos_lldp_interfaces] model

*  Add new resource module junos_lldp_interface
*  Targets model https://github.com/ansible-network/resource_module_models/pull/40
*  Deprecate junos_lldp_interface module

* Fix CI issues
 2019-08-08 18:23:54 +05:30
silverwizard
5d8302120b Removed breaking type check from nagios module (#49568) 
* Removed extraneous type check from nagios module, in order to allow python 3.x

* Removed now useless import types

* Added changelog fragment

* Update changelog.

* Rebased and removed check due to module adding earlier guardrails

* Updated changelog to mention earlier fix adding now completely removed guardrails

* Remove superfluous type checks. Fix docs type.

* Update ignore.txt.
 2019-08-07 22:43:14 +02:00
Nathan Swartz
e80f8048ee Fix netapp_e_volume wait-for-initialization to complete issue. (#58304) 
* Fix netapp_e_volume wait-for-initialization to complete issue.

* Add unit tests for wait_for operations in netapp_e_volume module.
 2019-08-07 11:28:39 -04:00
Matt Clay
d651bda123
Relocate ansible-test code. (#60147) 
* Initial move of `test/runner/` content.

`test/runner/lib/` -> `test/lib/ansible_test/_internal/`
`test/runner/`     -> `test/lib/ansible_test/_internal/data/`

* Initial move of `test/sanity/` content.

`test/sanity/` -> `test/lib/ansible_test/_internal/data/sanity/` (except `test/sanity/ignore.txt`)

* Initial move of `test/units/pytest/` content.

`test/units/pytest/` -> `test/lib/ansible_test/_internal/data/pytest/`

* Follow-up move of `test/runner/unit/` content.

`test/lib/ansible_test/_internal/data/unit/` -> `test/lib/ansible_test/tests/unit/`

* Initial move of `ansible.cfg` content.

`test/units/ansible.cfg` -> `test/lib/ansible_test/_internal/data/units/ansible.cfg`
`test/env/ansible.cfg` -> `test/lib/ansible_test/_internal/data/env/ansible.cfg`

* Follow-up move of `data` directory.

`test/lib/ansible_test/_internal/data/` -> `test/lib/ansible_test/_data/`

* Update import statements.

* Add missing __init__.py for unit tests.

* Fix path references and miscellaneous issues.
 2019-08-06 14:43:29 -07:00
Wojciech Wypior
2af67f0dce fixes issue with RD encoding in names (#59990) 
fixes issue with file download function on ASM file transfer endpoints
corrects doc fragments
removes not used parameters
corrects various sanity failures previously ignored across multiple modules
 2019-08-06 10:11:02 -07:00
Nathan Swartz
a9aeabb456 Improve netapp_e_storagepool and add units. (#57095) 
Refactored module to use eseries base class
Removed E322 and E326 for netapp_e_storage module from the ignore.txt file
Updated version_added quotes in netapp_e_storagepool
 2019-08-06 10:02:14 -04:00
Nilashish Chakraborty
2c432f8bc7
Add vyos_l3_interfaces resource module (#59929) 
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
 2019-08-06 19:30:58 +05:30
Daniel Mellado Area
e3681c049c
Add junos vlans resource module (#59041) 2019-08-06 16:00:01 +02:00
Matt Clay
fa2adf3b7b
More prep for ansible-test relocation. (#60114) 
* Update pytest plugins.
* Fix update-bundled sanity test.
* Remove old validate-modules comment.
* Fix ansible-test plugin loading
* Update code coverage comments.
* Fix Makefile ansible-test reference.
* Remove incorrect path from lint output.
* Update ansible-test unit tests.
* Make ansible-test's own unit tests singular.
 2019-08-05 16:38:21 -07:00
Alex Stephen
ac5228390c Removing validate-module exceptions on GCP modules (#60113) 
* facts modules with new types
* remove ignores on sanity tests
* removing new modules
 2019-08-05 16:17:06 -07:00
Felix Fontein
aecdfd397e ecs_taskdefinition_facts: rename to ecs_taskdefinition_info (#60023) 
* Rename ecs_taskdefinition_facts to ecs_taskdefinition_info.
 2019-08-05 12:47:35 -07:00
Matt Clay
d3da8e4a5b
Replace old shippable.py with new check_matrix.py. (#60022) 
This new script does not depend on ansible-test and provides much more robust job matrix testing.

It is also run on every job in the matrix now, to detect issues with jobs being re-run after matrix changes are made.
 2019-08-05 11:27:37 -07:00
Nathan Swartz
41235ac05a Improve netapp_e_hostgroup and add unit tests. (#57094) 
* Improve netapp_e_hostgroup and add unit and integration tests.

netapp_e_hostgroup was refactored for maintainability and improved
documentation clarity.

* Remove ignore sanity check E338 for netapp_e_hostgroup module

* Add __future__ import (absolute_import, division, print_function) to test_netapp_e_hostgroup unit test.
 2019-08-05 13:19:23 -04:00
Trishna Guha
021b1810c9
Add nxos_vlans resource module (#59294) 
* Add nxos_vlans resource module

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* address review comments

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* fix CI failure and udpate tests

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* Add commands in module doc

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2019-08-05 12:50:16 +05:30
Matt Davis
8d1f658ce4
move CLI entrypoints under ansible package (#60004) 
* needed so ansible-test can always find the right ones to copy to a target
* renamed the underlying scripts to be properly accessible as Python modules
 2019-08-02 11:27:02 -07:00
Felix Fontein
f3e20346cb
Google: gcpubsub_facts -> gcpubsub_info (#57668) 
* Rename gcpubsub_facts -> gcpubsub_info.

* Update porting guide and add changelog fragment.
 2019-08-02 17:27:28 +02:00
Sumit Jaiswal
b847327645
Resource module for ios_interfaces and Facts Update (#59716) 
* ios interfaces resource
 2019-08-02 14:34:05 +05:30
Felix Fontein
6d074d8a94
Move ome_* and idrac_* modules one level up (#59698) 
* Move ome_* and idrac_* modules one level up.

* Fix paths.

* Fix package name.

* Oranize in different directories.

* Update BOTMETA.

* Update new ignore entries.

* Revert "Update BOTMETA."
Revert "Oranize in different directories."
Adjust ignores.txt.
 2019-08-02 09:06:18 +02:00
Nilashish Chakraborty
730fa78ca4
Add vyos_interfaces resource module (#58589) 
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
 2019-07-31 23:06:53 +05:30
Daniel Mellado Area
58a53fe0eb
Add junos_l3_interfaces (#59026) 2019-07-31 16:29:32 +02:00
Matt Clay
32fa4b15d1
More sanity test updates for collections. (#59841) 
* Move action-plugin-docs ignores into ignore file.

* Update package-data sanity test.

The test now uses the file list provided by ansible-test.
 2019-07-30 22:36:03 -07:00
Matt Clay
e07c4f41d7 Standardize ansible-test sanity test filters. 2019-07-30 15:31:33 -07:00
Matt Clay
9f41a4273e Remove redundant sanity test ignores. 2019-07-30 10:45:19 -07:00
Ganesh Nalawade
127bd67f6e
Render elements in module doc and sanity test for sub-options (#59244) 
* Render elements in module doc and sanity test for suboptions

*  Add support to render module elements value in ansible-doc output
   module html
*  Add validate-module sanity test of sunoptions.

* Add current validate module failures to ignore list

* Fix CI failure

* fix rebase conflict

* Fix CI issues

* Fix review comments

* Add validate-modules failure in ignore list
 2019-07-30 12:07:21 +05:30
Matt Clay
5d7cc993dd
Clean up sanity test ignore handling. (#59749) 
* Allow sanity tests to easily ignore themselves.

Useful for simple regex based sanity tests that error on their own script due to the regex or error message generated.

* Simplify no-smart-quotes sanity test.

Pruning of unversioned directories is handled by ansible-test.

* Remove directory pruning from boilerplate tests.

Files not passing these tests should be ignored instead.

* Add missing sanity ignore entries.
 2019-07-29 14:37:44 -07:00
The Magician
4a7e11ba9a Bug fixes for GCP (as of 2019-07-09T06:06:53Z) (#59324) 2019-07-29 12:26:39 -07:00
Toshio Kuratomi
0e9f002073 Fix build-ansible.py release-announcement 
* When the release scripts were changed, this file to implement release
  announcements was left out

* Add announce.py to the compile skip lists as only the release engineers
  run this during package build.
 2019-07-26 16:39:56 -07:00
Matt Clay
f274cefa59
Consolidate sanity test ignore entries. (#59665) 
* Update empty-init test.
* Update future-import-boilerplate test.
* Update line-endings test.
* Update metaclass-boilerplate test.
* Update no-assert test.
* Update no-basestring test.
* Update no-dict-iteritems test.
* Update no-dict-iterkeys test.
* Update no-dict-itervalues test.
* Update no-get-exception test.
* Update no-main-display test.
* Update no-smart-quotes test.
* Update no-unicode-literals test.
* Update no-unwanted-files test.
* Update replace-urlopen test.
* Update required-and-default-attributes test.
* Update shebang test.
* Update test-constraints test.
* Update use-argspec-type-path test.
* Update use-compat-six test.
 2019-07-26 15:26:39 -07:00
Matt Clay
db7e9aa051
Use consolidated ignore.txt in ansible-test. (#59618) 2019-07-25 23:29:23 -07:00