Matt Martz
617048b717
It is not correct that you need at least 1 primary node
2016-12-08 11:22:38 -05:00
Tim G
b2e39265e1
Load distutils on all platforms EXCEPT Solaris.
...
Solaris doesn't ship distutils with with the default Python package. This patch fixes "service" on Solaris since 30d6713
.
2016-12-08 11:22:38 -05:00
Toshio Kuratomi
1728f9bba7
Add detection of uid,gid,mode changes when deciding whether an archive needs to be unarchived again.
2016-12-08 11:22:38 -05:00
Brian Coca
65d3b167e6
now captures cache fetch failures
2016-12-08 11:22:38 -05:00
Toshio Kuratomi
f9a6ec95b0
Implement user,group,mode,selinux settings for unarchive.
...
This is a partial fix for #234 . Still have to figure out how to
make change reporting work as we can no longer rely on tar's --compare
option
2016-12-08 11:22:38 -05:00
Toshio Kuratomi
44354e31e4
Better error messages if a2enmod/a2dismod are not found
2016-12-08 11:22:38 -05:00
Toshio Kuratomi
f3d41cdb06
Potential fix for 640
2016-12-08 11:22:38 -05:00
Tim G
ea77ac076b
distutils is not available on some non-Linux OS's
2016-12-08 11:22:37 -05:00
Alex Clifford
d4c4dd31d8
Fix slight typo in doco
2016-12-08 11:22:37 -05:00
Toshio Kuratomi
e11ea4b402
Also catch mysql errors so we can give the error message back through json rather than tracebacking
2016-12-08 11:22:37 -05:00
Michael Scherer
0a745de765
Do not use echo shell builtin for password
...
Using \t in a password may result in a different password
being set :
$ echo 'a\ta'
a a
Problem report originally found by Pilou-
( https://github.com/ansible/ansible-modules-extras/pull/198 )
2016-12-08 11:22:37 -05:00
Michael Scherer
b154bf967e
Remove unused code
...
There is no call to yum_base using 'cachedir' argument, so
while it work fine from a cursory look, that's useless code,
and so should be removed to clarify the code.
2016-12-08 11:22:37 -05:00
Michael Scherer
2dfc7122af
Use the rpm python module rather than execing rpm
...
Using the rpm module prevent a uneeded fork, and permit
to skip the signature checking which slow down a bit the
operation, and which would be done by yum on installation
anyway.
2016-12-08 11:22:37 -05:00
Bruce Pennypacker
605a5a5b53
requested changes
2016-12-08 11:22:37 -05:00
Bruce Pennypacker
9cbe3eb8ae
Added support for 'REQUIRE SSL' grant option
2016-12-08 11:22:37 -05:00
Brian Coca
a3de4db57d
fix for allowing permissions on hard links and soft links + follow=yes
2016-12-08 11:22:37 -05:00
Toshio Kuratomi
e75dc7e5a6
Clarify documented behaviour of user module's ssh_key_file parameter
...
Fixes #9873
2016-12-08 11:22:37 -05:00
Brian Coca
c5dfc66cb1
added version added for new template options
2016-12-08 11:22:37 -05:00
Vasyl Kaigorodov
d41ec7027f
gce_net - creating firewall rule, src_range value seems to get lost or set to empty string -- fixes #252
2016-12-08 11:22:37 -05:00
James Martin
07dbc333b2
vpc_zone_identifier must be a csv string when an asg is updated.
2016-12-08 11:22:37 -05:00
Brian Coca
9eb77bdb4f
fix for when state=directory, follow=yes and target is symlink to directory
2016-12-08 11:22:37 -05:00
Philip Misiowiec
f3abfa0f19
Adds tenancy state to returning json
2016-12-08 11:22:37 -05:00
Johnny Robeson
6fc04862a4
rename FedoraStratgy to SystemdStrategy
2016-12-08 11:22:37 -05:00
Michael J. Schultz
588d03db8d
Build the db connection on "postgres"
instead of "template1"
...
According to the postgresql docs[1], you should not have a connection with
`"template1"` when copying multiple databases.
[1]: http://www.postgresql.org/docs/9.1/static/manage-ag-templatedbs.html
2016-12-08 11:22:36 -05:00
Jeff Gonzalez
30822706dd
Added ability to use url as key source
2016-12-08 11:22:36 -05:00
Michael Scherer
d357f309b5
Fix #370 , by allowing to export over a existing repository
...
This requires to use force=True
2016-12-08 11:22:36 -05:00
Michael Scherer
e1194116b2
Make force parameter work for export operation
...
The default is changed from 'yes' to 'no' to follow
subversion behavior (ie, requiring explicit confirmation
to erase a existing repository). Since that was not working before
cf #370 and since the option was ignored before and unused, this
should be safe to change.
2016-12-08 11:22:36 -05:00
Patrik Lundin
9803938663
Handle string returned by 'default' correctly.
...
We need to handle the string returned by 'default' in the same way we handle
the string returned by 'status' since the resulting flags are compared later.
2016-12-08 11:22:36 -05:00
Jesse Buchanan
06a58dcad7
Files module: Allow touch on hardlinks
2016-12-08 11:22:36 -05:00
Patrik Lundin
d88080007a
Fix typo: Replace "N0" with "NO".
2016-12-08 11:22:36 -05:00
anatoly techtonik
59a700ad17
acl: Fix X support in ACL permissions
...
If you try to set rwX permissions, ACL fails to set them at all.
Expected:
$ sudo setfacl -m 'group::rwX' www
...
drwxrwxr-x 2 root root 4096 Nov 10 17:09 www
With Ansible:
acl: name=/var/www permissions=rwX etype=group state=present
...
drwxrw-r-x 2 root root 4096 Nov 10 17:30 www
x for group is erased. =/
2016-12-08 11:22:36 -05:00
Patrik Lundin
6594a1458d
Multiple fixes for OpenBSD rcctl handling.
...
* Use the newly added 'default' argument to know if the default flags are set
or not.
* Handle that 'status' may either return flags or YES/NO.
* Centralize flag handling logic.
* Set action variable after check if we need to keep going.
Big thanks to @ajacoutot for implementing the rcctl 'default' argument.
2016-12-08 11:22:36 -05:00
Ricky Cook
522c644bf1
Fix regex string format
2016-12-08 11:22:36 -05:00
Ricky Cook
a6a9e2c247
Get warn option same as other args
2016-12-08 11:22:36 -05:00
Ricky Cook
095400c45e
Add comment to command options dict
2016-12-08 11:22:36 -05:00
Ricky Cook
5e21c81ca4
Simplify command module option parsing
2016-12-08 11:22:36 -05:00
Luís Guilherme F. Pereira
b347875de0
Allow ec2_lc to create EC2-Classic Launch Configs
...
Removes default value from ec2_lc so it can create launch configurations valid on a EC2-Classic environment. AWS API will not accept a assign_public_ip when creating an ASG outside of VPC.
2016-12-08 11:22:36 -05:00
Nate Coraor
771fdfb1f8
Fix a few bugs and misbehavior in the hg module: 1. Don't pull when dest
is already at the desired changeset. 2. Don't change the working copy when cleaning or pulling and a revision was specified. 3. Change the default for the revision
param to match the behavior of hg.
2016-12-08 11:22:36 -05:00
Jonathan Mainguy
aef138107c
Fixes bind mounts
...
Fixed tab's and spaces, or so I think I did
Fixed tabs and spaces for real this time
2016-12-08 11:22:36 -05:00
Jonathan Mainguy
6be46cb2e3
Fixes --enable-repo for Oracle Linux
2016-12-08 11:22:35 -05:00
Jonathan Mainguy
13990e9479
adds error message if socket does not exist
2016-12-08 11:22:35 -05:00
Philip Misiowiec
c57c1ea419
added version
2016-12-08 11:22:35 -05:00
billwanjohi
b019076dd3
user: add expired state
...
ported from
https://github.com/ansible/ansible/pull/6303
It's very useful and routine to disable a *nix user.
I implemented expired instead of locked because this prevents any use of
the account, safer than just preventing password-based authentication.
I have tests [1], but since none of the suite came along with the core
modules, I'm unsure how to submit them.
[1] https://github.com/billwanjohi/ansible/blob/add_locked_state/test/integration/roles/test_user/tasks/main.yml
2016-12-08 11:22:35 -05:00
kustodian
447c625cb3
Set selinux state to 'permissive' for state=disabled
2016-12-08 11:22:35 -05:00
Michael Scherer
36c653f54a
Add hostname to generated user SSH key comment
...
The default is not very useful to sort between different
keys and user. Adding the hostname in the comment permit to later
sort them if you start to reuse the key and set them in different
servers. See https://github.com/ansible/ansible/pull/7420
for the rational.
2016-12-08 11:22:35 -05:00
Phillip Holmes
0d3b144eb2
Route53 fix - forcing zone_in, record_in to lower case
...
Fixed the .tolower to .lower() for correct syntax (copied change from older notes).
2016-12-08 11:22:35 -05:00
Philip Misiowiec
23668e41b0
Support for EC2 dedicated tenancy option
2016-12-08 11:22:35 -05:00
Philip Misiowiec
d30881a461
Ability to detach an EBS volume from an EC2 instance
2016-12-08 11:22:35 -05:00
fabios
3c53b3b268
mark as upgradable and let apt-get install deal with it
2016-12-08 11:22:35 -05:00
fabios
043242df2c
improve fail message and use itertools chain
2016-12-08 11:22:35 -05:00
fabios
21bfa80203
older python-apt compatibility
2016-12-08 11:22:35 -05:00
fabios
301c8b8e09
handle list of list for python-apt < 0.7.9 compatibility
2016-12-08 11:22:35 -05:00
Lorin Hochstein
88d5f15025
docker: fix volume[s]_from typo
...
Code makes reference to volume_from instead of volumes_from. If volumes_from is
passed as an argument, generates a KeyError.
2016-12-08 11:22:35 -05:00
Toshio Kuratomi
1dc2ae0aef
Cleanup the old apt compatibility changes
2016-12-08 11:22:35 -05:00
fabios
0ad355585a
use low-level apt_pkg.Package
2016-12-08 11:22:35 -05:00
Jan Weitz
8146b45203
Fixes invalid dictionary access.
2016-12-08 11:22:35 -05:00
FabioBatSilva
a748229f3a
fix compatibility issues with python-apt < 0.7.9
2016-12-08 11:22:34 -05:00
Mark Phillips
786aceb43b
vsphere_guest fix for KeyError: folder message
2016-12-08 11:22:34 -05:00
Jan Weitz
1b9d0c5987
Fixes version check for docker-py
2016-12-08 11:22:34 -05:00
Toshio Kuratomi
1be539d870
git fetch --tags overwrites normal fetching with git < 1.8.x so do a normal fetch followed by using the refspec format for fetching tags
2016-12-08 11:22:34 -05:00
Toshio Kuratomi
73b7d6ea7b
Fix typo in git refspec code. Change lists to tuples
2016-12-08 11:22:34 -05:00
Brian Coca
945909bf67
update to use connect_to_region to avoid errors with china
2016-12-08 11:22:34 -05:00
Brian Coca
abdb1afa0a
Revert "Merge pull request #384 from jhawkesworth/win_copy_file_template_ansible_modules_core_1" I missed some discussion in devel, these need more work before inclusion
...
This reverts commit 58bfebb047
, reversing
changes made to 27dee77ca0
.
2016-12-08 11:22:34 -05:00
Peter Oliver
432a6286db
Fix appending to a user's group on Solaris
...
Without this change, you get:
AttributeError: 'set' object has no attribute 'extend'
Tested on a Solaris 11.2 client with the included Python 2.6.8.
2016-12-08 11:22:34 -05:00
Toshio Kuratomi
5c090207ff
Make documentation clear about update=no vs clone=no
2016-12-08 11:22:34 -05:00
Chris Church
9d0830a181
Change version added in win_user docs to 1.9 for updates that didn't make it into 1.8.
2016-12-08 11:22:34 -05:00
Rohan McGovern
b607ffb7c6
git: add 'refspec' argument
...
This argument may be used to fetch additional refs beyond the default
refs/heads/* and refs/tags/*. Checking out GitHub pull requests or Gerrit
patch sets are two examples where this is useful.
Without this, specifying version=<sha1> with a SHA1 unreachable from any
tag or branch can't work.
2016-12-08 11:22:34 -05:00
Rohan McGovern
06ff34f364
git: clean up "fetch" method
...
De-duplicate repetitive code checking the exit code.
Include the stdout/stderr of the failed process in all cases.
Remove the returned values because no caller uses them.
Combine git commands where possible. There is no need to fetch branches
and tags as two separate operations.
2016-12-08 11:22:34 -05:00
Toshio Kuratomi
d28cd02ab7
Newstyle class
2016-12-08 11:22:34 -05:00
Toshio Kuratomi
4aaba45e29
Make insecure_registry feature version check against the client API
2016-12-08 11:22:34 -05:00
Maksim Losev
807d964a48
Add insecure_registry to docker-py pull method
...
Starting from docker-py>=0.5.0 it is impossible to work with private registries based on HTTP.
So we need additional parameter to allow pull from insecure registry
Related to ansible/ansible#9111
2016-12-08 11:22:34 -05:00
Toshio Kuratomi
7b74e451d9
Make docker ver checks issue failures rather than silently ignoring
...
Also:
* make client version checks robust for two digit version pieces and
alpha versions
* consolidate version checking code
2016-12-08 11:22:33 -05:00
Will Thames
834c8d2f59
Added better region handling and enabled eu-central-1
...
Make use of improved connect_to_aws that throws an exception
if a region can't be connected to (e.g. eu-central-1 requires
boto 2.34 onwards)
Add eu-central-1 to the two modules that hardcode their regions
Add us-gov-west-1 to ec2_ami_search to match documentation!
This pull request makes use of the changes in ansible/ansible#9419
2016-12-08 11:22:33 -05:00
Ingo Gottwald
f88107bc9b
Add support for new docker restart policies
2016-12-08 11:22:33 -05:00
Toshio Kuratomi
8af70de1fc
Probably would make clone a 1.9 feature rather than 1.8.3
2016-12-08 11:22:33 -05:00
Toshio Kuratomi
a7ff6c4cba
Make git's update parameter revert to its old behaviour and add new clone parameter to take its place.
...
Fixes #426
Fixes https://github.com/ansible/ansible/issues/8630
2016-12-08 11:22:33 -05:00
Kale Franz
7c8f0b99af
#531 correction
...
correct list comprehension for older versions of python (back to python 2.4)
2016-12-08 11:22:33 -05:00
Kale Franz
eac743dc39
fixes #529 ec2_group module bug
2016-12-08 11:22:33 -05:00
Toshio Kuratomi
104b2d684c
Add text/json as a mimetype to try deserializing
...
Fixes #503
2016-12-08 11:22:33 -05:00
Jonathan Mainguy
8c05023be3
Fixed hostname for rhel5 python 2.4.3
2016-12-08 11:22:33 -05:00
zitterbacke
1d4808780f
re-enable AIX password setting
...
the AIX class uses a unsafe shell for setting the user password (containing a pipe in the command). This patch adopts to the new behavior of module_utils/basic.py (since somewhere around 1.7).
besides it changes the qoutes for the echo command from double to single, because password-hashes contain $-signs and one would not have this variables expanded.
2016-12-08 11:22:33 -05:00
Toshio Kuratomi
123c99f879
Add error message from git to message returned from ansible
...
Fixes #81
2016-12-08 11:22:33 -05:00
Jeff Gonzalez
8eedd915cd
Fixed formatting in documentation
...
The example was using mixed shorthand and long form yaml (region: "us-east-1 disable_rollback=true"
I modified the entire example to be long form.
2016-12-08 11:22:33 -05:00
Jeff Bradberry
60ed80f99a
Fix breakage in lineinfile check mode when target file does not exist.
...
Similarly to https://github.com/ansible/ansible/issues/6182 , checking of the file attributes should be avoided in check mode when the file didn't originally exist.
Also, avoid creating parent directories in check mode.
Fixes https://github.com/ansible/ansible/issues/9546
2016-12-08 11:22:33 -05:00
Michael Scherer
104f91ed3b
Revert commit cbc417c
, as the code is broken, see #438
...
LooseVersion expect a string, so filtering to return a int
is incorrect. Thanks to Jeremy Brown for the analysis.
2016-12-08 11:22:33 -05:00
sysadmin75
7fbb422ae7
Fixes #9518 - "file state=directory" silently skips if it's currently a file
2016-12-08 11:22:33 -05:00
kustodian
8621f9a7cd
Fixed postgresql_db failing on Python 2.4 with --check
...
This reverts commit 81cbdb6c8c
and adds ignoring of the SystemExit exception because of Python 2.4.
2016-12-08 11:22:33 -05:00
Toshio Kuratomi
e359f7cfcf
Don't traceback if a gid is specified instead of a group name
...
Fixes https://github.com/ansible/ansible/issues/9796
2016-12-08 11:22:33 -05:00
Mike Putnam
d2d0ffd83a
Type fix on delete_snapshot docs.
2016-12-08 11:22:32 -05:00
Toshio Kuratomi
37f237ecfc
Fixup the directory name at a higher level so it can be used by both conditional branches
...
Fixes #500
2016-12-08 11:22:32 -05:00
Jon Hawkesworth
44cc1a75ba
Switched to SHA1 checksum instead of MD5
2016-12-08 11:22:32 -05:00
Harald Skoglund
1a8b9b8935
add support for stack policies in cloudformation
2016-12-08 11:22:32 -05:00
Jon Hawkesworth
67def35795
Adding first pass at win_copy, win_file and win_template modules (include new files).
2016-12-08 11:22:32 -05:00
Harri Hämäläinen
299d28f7e5
Fixed typo in comment
2016-12-08 11:22:32 -05:00
Brian Coca
6d56767454
fixed hostname for gentoo
2016-12-08 11:22:32 -05:00
Matt Martz
411e4cfae8
Make a few enhancements to the rax_scaling_group module
...
* Cast loadbalancer id and port to integers
* Do not attempt to base64 encode NoneType values
2016-12-08 11:22:32 -05:00
Petros Moisiadis
63b18ae618
mysql_user: Added missing privileges
...
Added missing privileges 'CREATE TABLESPACE' and 'PROXY' (see: http://dev.mysql.com/doc/refman/5.5/en/privileges-provided.html ).
2016-12-08 11:22:32 -05:00
PikachuEXE
fbba80d72e
~ Add missing documentation for option email
2016-12-08 11:22:32 -05:00
Andrew Shults
2390184084
Strip white space to support multiline permissions in YAML
2016-12-08 11:22:32 -05:00
Toshio Kuratomi
88ccfc219a
Change git update param documentation to match reality
2016-12-08 11:22:32 -05:00