Ricardo Carrillo Cruz
ba7ba7adc3
Check for proper response key on eos_banner map_config_to_obj ( #23399 )
...
If we run the task with 'login' banner, the 'show banner' command
will return a dict containing key 'loginBanner'.
However for motd, it will just return 'motd'.
Yay naming consistency!
2017-04-07 15:32:10 +02:00
Ricardo Carrillo Cruz
ce9826d76e
Fix eos_banner basic-motd eapi asserts ( #23398 )
...
The commands in EAPI does not contain the plain command sent to the
device as a one liner, but it is split in cmd/input keys.
2017-04-07 14:18:40 +02:00
Ricardo Carrillo Cruz
2cc2b8fb4d
Add missing provider to eos_banner basic-motd eapi test ( #23396 )
...
Otherwise this stalls and timeouts, it doesn't have creds to run.
2017-04-07 13:39:33 +02:00
Matt Clay
48eeab8a53
Fix errors reported by pylint. ( #23282 )
...
* Fix pylint misplaced-bare-raise errors.
* Fix pylint return-in-init error.
* Fix pylint bad-format-character error.
* Fix pylint too-many-format-args errors.
* Fix pylint too-few-format-args errors.
* Fix pylint truncated-format-string error.
2017-04-06 16:58:16 -07:00
Matt Clay
9e1bf1c6f2
Update fedora24 Dockerfile to resolve dnf issue.
2017-04-06 16:03:29 -07:00
John R Barker
6633ae1afa
look_for_keys & allow_agent actually added in 2.4
...
https://github.com/ansible/ansible/pull/22429 was merged, though not cherry picked into stable-2.3, so update docs
2017-04-06 19:17:59 +01:00
Guillaume Coré
3c75808c5c
fix incorrect parsing of xfs_info
...
when device name ends with 'data' line matches in :
- if 'data ' in line:
closes #23352
2017-04-06 11:11:13 -07:00
Toshio Kuratomi
dcc63c8f93
Fix imports and pep8 problems so CI can pass again.
2017-04-06 10:41:18 -07:00
Ricardo Carrillo Cruz
3537b24742
Unhardcode the port and protocol on eos EAPI ( #23350 )
...
We were hard-coding the protocol, port and validate_certs on
eos EAPI via the action plugin.
Put defaults on the eos_argument_spec and pull those values from it.
2017-04-06 19:18:28 +02:00
Toshio Kuratomi
5f4673b5ae
Update metadata for openssl_csr
2017-04-06 10:16:50 -07:00
Ganesh Nalawade
0cd50f0706
Fix #22880 junos_config update issue ( #23333 )
...
For update parameter add 'override' as acceptable value.
'override' name is in sync with junos naming convention.
2017-04-06 12:59:33 -04:00
Chris Alfonso
394cb3477b
Fixes loginBanner plucking over eapi transport when loginBanner isn't set. ( #23363 )
2017-04-06 10:58:04 -06:00
Ganesh Nalawade
990ba90380
Fix #23360 junos_config set format issue ( #23365 )
2017-04-06 10:45:15 -06:00
Nathaniel Case
98c23a3342
Attempt to clear up nxos_mtu tests and documentation ( #23361 )
...
nxos_system wasn't added until 2.3, so nxos_mtu should have been deprecated
then.
2017-04-06 12:26:17 -04:00
nerzhul
637e9942ff
Nsupdate idempotency fix
2017-04-06 09:20:01 -07:00
Yanis Guenane
2705e7a8aa
crypto: Add new module openssl_csr ( #21004 )
...
This new module allows one to automate the generation of OpenSSL
Certificate Signing Request. It supports SAN extension.
2017-04-06 18:09:07 +02:00
Matt Clay
40e88dadbe
Disable zypper tests for CI due to timeouts.
2017-04-06 08:48:31 -07:00
Peter Sprygada
f0008248d4
fix iosxr commands to encode json ( #23346 )
...
the command dict in the iosxr module_utils wasn't encoding the request
to json. this patch will fix that problem
2017-04-06 15:44:21 +01:00
John R Barker
13dc02d49d
More network_debug_troubleshooting.html ( #23335 )
...
More "unable to open shell" -> network_debug_troubleshooting.html
2017-04-06 12:39:59 +01:00
Takuya Sato
dff35bc205
ecs_taskdefinition module : Convert environment variables to string ( #23297 )
...
Before modification, it fails unless it is a string type
2017-04-06 10:46:40 +01:00
John R Barker
529df8640b
'unable to open shell' -> direct to web help ( #23267 )
...
* 'unable to open shell' -> direct to web help
The "unable to open shell" error is returned for a number of different,
direct people to online docs (we we can update out of band of releases)
to guide them though the various solutions.
* fix pep8 errors
2017-04-06 10:11:28 +01:00
Varadharajan
4540853a50
Pass CSRF token along with Jenkins POST requests ( #23250 )
2017-04-06 10:03:57 +01:00
Matt Davis
b71b157fb3
Cleanse CLIXML from win_shell stderr ( #23329 )
...
prunes all but Error stream values
2017-04-06 01:39:20 -07:00
Matt Davis
8d291f91ee
improve become_method: runas error handling ( #23328 )
...
Prescriptive errors for username/password issues and NTLM/Kerb auth failures, cleans up exception noise.
2017-04-06 01:34:30 -07:00
Dag Wieers
e66c98281e
Small consistency fixes ( #23294 )
2017-04-05 22:03:29 +01:00
Ricardo Carrillo Cruz
b9b4e68206
Check text key exists on eos_banner absent case ( #23319 )
...
This can fail if we don't check the key exists.
2017-04-05 21:07:18 +02:00
Ricardo Carrillo Cruz
4571ff0b52
Fix eapi basic-login asserts ( #23318 )
...
The asserts where not checking the commands sent to the device
2017-04-05 20:37:58 +02:00
Ricardo Carrillo Cruz
cf30f0f27d
Fix asserts on ios_banner tests ( #23315 )
...
The contain assert was broken.
2017-04-05 20:00:10 +02:00
Chris Alfonso
3a78861cb5
Fixes #23308 ios_banner: KeyError: 'text' on state: absen ( #23313 )
2017-04-05 11:30:40 -06:00
Ricardo Carrillo Cruz
d268471739
Fix basic-login eapi tests for eos_banner ( #23304 )
...
We should be passing the provider dict, not the transport.
2017-04-05 19:11:12 +02:00
John R Barker
f22702eee2
enable ios_facts tests again ( #23310 )
2017-04-05 17:50:32 +01:00
Adrian Likins
a936ea1333
update the flake8 config in tox.ini
2017-04-05 09:43:37 -07:00
Nathaniel Case
d890167575
Fix nxos_facts for nxapi transport ( #23302 )
...
* Partial revert of 2e476e64cd
This broke handling of nxos_facts over nxapi
* Fix nxos_facts tests not run in isolation
2017-04-05 11:47:37 -04:00
John R Barker
485affeb12
eapi & nxapi: Document validate_certs ( #23305 )
...
* Document validate_certs for eapu & nxapi
* formatting
2017-04-05 16:37:40 +01:00
Tim Rupp
780b2f2c84
Fixes pylint errors ( #23279 )
...
Reported by gundalow, this fixes pylint errors in F5 modules
2017-04-05 14:24:42 +01:00
Will Thames
b3a15e9ac3
[cloud] New AWS ec2_vpc_endpoint module for creating/deleting VPC endpoints ( #20212 )
...
* New AWS VPC Endpoint module for creating and deleting VPC endpoints
* Fix for python3, update version_added, fix flake8 issues
Change exception syntax for python 3
Update version_added to 2.3
Fix some minor flake8 issues
* ec2_vpc_endpoint: improve standards compliance
* Better documentation
* Return results in camel case format
* Improved exception handling
* Added `policy_file` argument
* Add ANSIBLE_METADATA
* Fix version_added
* Update ansible metadata to have metadata_version field
2017-04-05 08:28:52 -04:00
Benjamin Jolivot
f74a9abbda
fortios_ipv4_policy.py state=absent Fix 23239 ( #23242 )
...
* Resolve #23239 :
- path is missing when state=absent
- update doc for unclear policy ID
- required params based on state
* Fix pep8 + doc
* Fix doc
* Another doc problem...
* doc
* Update doc fot policy ID
* Fix doc string
* fix required in doc
* fix required in doc Required when I(state=present).
2017-04-05 13:27:34 +01:00
Ricardo Carrillo Cruz
2571d2f64b
Refactor openvswitch_db module ( #23288 )
...
The openvswitch_db module uses the ovs-vsctl binary to
address changes.
On other network modules we follow the pattern of returning 'commands'
as part of the result, containing the commands run on the target device.
Follow that for code consistency and maintenance.
Also, adding state param, which allows to add/remove keys on columns.
2017-04-05 13:27:52 +02:00
Nathaniel Case
e8538213fa
Fix various junos errors ( #23278 )
2017-04-05 16:42:13 +05:30
Ganesh Nalawade
0b8ca98c48
Fix junos rollback id validate issue ( #23283 )
2017-04-05 16:41:11 +05:30
Matt Clay
1daa69d685
Initial pylint support for ansible-test sanity.
2017-04-04 16:16:21 -07:00
Toshio Kuratomi
572e9a8959
Update the metadata of the proxysql modules to 1.0 final format
2017-04-04 14:20:17 -07:00
James Cammarata
a567c5de65
Only insert notified host if it's not already notified for certain cases
...
Fixes #18178
2017-04-04 16:03:29 -05:00
bmildren
21ab4343e3
Adding support for ProxySQL ( #19872 )
...
* Adding support for ProxySQL
2017-04-04 13:47:19 -07:00
Brian Coca
00231c29ba
Revert "keep ansible_local as top level var, always present"
...
This reverts commit 97cb2016d8
.
It was causing issues downstream as facts seem to be merged back for
subsequent tasks. Will restore if I ever figure out how to avoid that.
2017-04-04 16:30:57 -04:00
Matt Clay
a6ca849643
Fix PEP 8 issues.
2017-04-04 12:22:47 -07:00
JP Mens
5a0b2fe3be
dig lookup-plugin: add support for specifying rdclass ( #10493 )
...
* add support for specifying rdclass
* fix exception
2017-04-04 15:00:56 -04:00
Nathaniel Case
597bca3129
junos_config: Remove reliance on ability to output configuration in set
format ( #23225 )
...
* Remove reliance on ability to output configuration in `set` format
* Support multiple warnings per rpc-reply
2017-04-04 15:00:00 -04:00
John R Barker
01e27b1083
Typo
2017-04-04 19:40:41 +01:00
Toshio Kuratomi
57a7d7704f
Make scripts into symlinks
...
pip can't handle zip files with symlinks. Attempt to workaround that by
transforming the bin scripts into symlinks after the zip file has been
unarchived into the build tree.
2017-04-04 11:19:27 -07:00