Commit graph

26 commits

Author SHA1 Message Date
Shaun Brady
890bba6a0e Make group_name resolution VPC aware
EC2 Security Group names are unique given a VPC.  When a group_name
value is specified in a rule, if the group_name does not exist in the
provided vpc_id it should create the group as per the documentation.

The groups dictionary uses group_names as keys, so it is possible to
find a group in another VPC with the name that is desired.  This causes
an error as the security group being acted on, and the security group
referenced in the rule are in two different VPCs.

To prevent this issue, we check to see if vpc_id is defined and if so
check that VPCs match, else we treat the group as new.
2016-07-27 14:11:59 -04:00
Michael Pappas
d26bb2eb41 Prevent ec2group from deleting sgs during check_mode runs 2016-06-03 10:58:56 -04:00
codemeup @ Work
7314cc3867 Fixing error exception handling for python3. Does not need to be compa… (#3840)
* Fixing error exception handling for python. Does not need to be compatible with Python2.4 b/c boto is Python 2.6 and above.

* Fixing error exception handling for python. Does not need to be compatible with Python2.4 b/c boto is Python 2.6 and above.

* Fixing compile time errors IRT error exception handling for Python 3.5.
This does not need to be compatible with Python2.4 b/c Boto is Python 2.6 and above.
2016-06-02 12:56:48 -07:00
Neil Saunders
6aa0cd4457 Fix for issue #3109: Executing ec2_group with rules fails with "Invalid rule parameter '['" 2016-02-25 14:18:02 +00:00
Brian Coca
c4f64d822c changed modules to use common ec2 docs for region 2015-10-07 16:16:24 -04:00
Selivanov Pavel
ec24a86f69 ec2_group.py: added ICMP rule example 2015-09-22 16:56:13 +03:00
Toshio Kuratomi
42d3d02855 Merge pull request #51 from cewood/ec2-group/cidr-ip-list
Support specifying cidr_ip as a list
2015-08-01 07:45:38 -07:00
Cameron Wood (@cewood)
4241d940b7 Support specifying cidr_ip as a list
Update/fix to Support specifying cidr_ip as a list

Unicode isn't compatible with python2, so we needed some other
solution to this problem. The simplest approach is if the ip item
isn't already a list, simply convert it to one, and we're done.
Thanks to @mspiegle for this suggestion.
2015-07-29 19:11:43 +10:00
Mike Putnam
6c0e264806 Add missing GPLv3 License header
Fixes #1643
2015-07-03 22:57:53 -05:00
Greg DeKoenigsberg
28a869a030 Updating cloud modules with proper github author information 2015-06-15 14:41:22 -04:00
Robert Estelle
9b7de40922 EC2 Security Group - Validate parameters. 2015-06-14 15:35:41 -04:00
Brian Coca
32102f7e69 Merge pull request #1472 from bennojoy/fix_11177
fix for 11177 where module readds rule even if the rules exists
2015-06-05 19:09:18 -04:00
Brian Coca
f5ff5ba348 reverting pep changes that were breaking documentation 2015-06-05 12:01:10 -04:00
Benno Joy
6b9e9fe05d fix for 11177 where module readds rule even if the rules exists 2015-06-05 12:31:59 +05:30
marko
5f5be7bc2a Added support for foreign security groups (Fixes: #373) 2015-05-22 12:34:41 +02:00
zimbatm
34378b6c6a ec2_group: prioritise current VPC group names over others 2015-04-28 10:19:20 +01:00
zimbatm
8a4d5856ce ec2_group: select own group if the name matches
This fixes an issue where multiple VPC have the same group name and
the one from the other VPC is selected.
2015-04-27 19:26:13 +01:00
steenzout
d960dc1584 issue #994: use HAS_BOTO to determine if import was successful:
- removed import of sys module.
- HAS_BOTO constant to check if import was successful.
- trigger a failure when import fails.
- removed unnecessary imports.
2015-04-01 17:31:10 -06:00
Brian Coca
adfcfa4b58 Merge pull request #318 from preo/ec2-group-empty-rules
Allow empty EC2 Security Group rules.
2015-03-29 10:26:33 -04:00
Joel Thompson
01c4ff922f Fixes issue 697 -- only purge the grants that need to be purged 2015-01-24 00:52:37 -05:00
Kale Franz
73172fae47 #531 correction
correct list comprehension for older versions of python (back to python 2.4)
2014-12-17 09:01:50 -08:00
Kale Franz
e174c9b474 fixes #529 ec2_group module bug 2014-12-17 03:34:47 -08:00
Michael DeHaan
e7c92a6bc6 More EC2 doc tweaks 2014-12-01 15:14:57 -05:00
Robert Estelle
5e694c490c ec2_group allow empty rules. 2014-12-01 13:04:15 -05:00
follower
a6e0d9d613 Fix typo of "rules_egress"
Or is "rules_egree" supposed to be a plural? The sentence is difficult to parse.

Maybe the correct fix is to "Purge existing rules on security group that are not found in rules_egress"?
2014-11-29 18:05:22 +13:00
Brian Coca
0c4adcb2c6 made subcategories for cloud modules for better organization 2014-11-04 11:18:09 -05:00
Renamed from cloud/ec2_group.py (Browse further)