Commit graph

9133 commits

Author SHA1 Message Date
Monty Taylor
186fbd7645 Remove duplicate shade requirement 2016-12-08 11:23:10 -05:00
Monty Taylor
73cb529d2c Make sure we're always returning objects too 2016-12-08 11:23:10 -05:00
dagnello
072110c757 Resolving secgroup.id issue in this module
secgroup['id'] was not being returned in all cases where the
specified security group exists.
2016-12-08 11:23:10 -05:00
toninog
bea77c938e fixes to code to enable updates of user to groups and delete groups. Fixed example yaml to use groups 2016-12-08 11:23:10 -05:00
toninog
ab7678f199 Fixed more issues with the delete_group and paramater mismatch 2016-12-08 11:23:10 -05:00
Jonathan Mainguy
c9d1cc0ce3 remove blank lines from htpasswd file
used standard mktemp()
2016-12-08 11:23:10 -05:00
Vasyl Kaigorodov
758688a667 GCE module: added Service Account permissions sanity checks 2016-12-08 11:23:10 -05:00
Vasyl Kaigorodov
4400c5e163 GCE module: document Service Account permissions parameter usage 2016-12-08 11:23:10 -05:00
Vasyl Kaigorodov
97e880a27f GCE module: add posibility to specify Service Account permissions during instance creation 2016-12-08 11:23:10 -05:00
Jonathan Davila
6482ad964f iam certificate module
boto import tweak

style patch
2016-12-08 11:23:10 -05:00
Dan Abel
a51a8e1fd6 use aws connect calls that allow boto profile use 2016-12-08 11:23:10 -05:00
Hagai Kariti
b46a1ff3e1 Hostname module should update ansible_hostname 2016-12-08 11:23:10 -05:00
Vyronas Tsingaras
654d2d3f60 This enable one to find a datastore with no config_target supplied
Signed-off-by: Vyronas Tsingaras <vtsingaras@it.auth.gr>
2016-12-08 11:23:10 -05:00
Jon Hawkesworth
a00d86946d document file size limit for win_copy module 2016-12-08 11:23:10 -05:00
Vyronas Tsingaras
56957ca45e Remember power state when starting vm reconfigure
This commit fixes #1391

Signed-off-by: Vyronas Tsingaras <vtsingaras@it.auth.gr>
2016-12-08 11:23:10 -05:00
Matt Martz
158772ffc2 Fix some remaining rax asg idempotency checks 2016-12-08 11:23:10 -05:00
Benno Joy
17c185c8d1 enable azure to provision windows instances 2016-12-08 11:23:09 -05:00
Benno Joy
2314670952 enable the module to provision windows instances 2016-12-08 11:23:09 -05:00
Colin Hutchinson
97a2cd0bd9 Indentation fix for with and register in the ec2_vol example 2016-12-08 11:23:09 -05:00
Ritesh Khadgaray
9c3f9d23c8 Add the ability to grep for content 2016-12-08 11:23:09 -05:00
Vyronas Tsingaras
bdb33b5756 Properly check if vm_hardware contains keys
This commit fixes #1475

Signed-off-by: Vyronas Tsingaras <vtsingaras@it.auth.gr>
2016-12-08 11:23:09 -05:00
Vyronas Tsingaras
262e86b36b Use either esxi:dc,host OR cluster,resource_pool
vsphere_guest now can deploy a template using a datacenter and hostname
as the target, instead of requiring a cluster and resource_pool.

This commit fixes #951.

Signed-off-by: Vyronas Tsingaras <vtsingaras@it.auth.gr>
2016-12-08 11:23:09 -05:00
Robin Roth
abc89f0df5 add comment: ports need to be exposed.
port mapping with this module only works for ports that are exposed either in the Dockerfile or via an additional arguments. This is different from the command line docker client, that is willing to also map ports that are not exposed.

This comments makes the behaviour more obvious.
2016-12-08 11:23:09 -05:00
Monty Taylor
8ff71a3fa8 Actually use changed variable 2016-12-08 11:23:09 -05:00
Monty Taylor
4125b576e9 Return the secgroup for all present states 2016-12-08 11:23:09 -05:00
Monty Taylor
b955b2f5c8 Return resource objects from OpenStack modules
It's not uncommon for people to want to do additional things after
creating a module. Also, add a note about it to the dev notes.
2016-12-08 11:23:09 -05:00
Monty Taylor
89f95471f8 Return secgroup, not just id 2016-12-08 11:23:09 -05:00
Philip Kirkland
cc214afed6 adding 'encrypted' option into volume dict so ec2 module can easily include encrypted volumes 2016-12-08 11:23:09 -05:00
Toshio Kuratomi
88ae201b20 Fix bugs found by @kustodian 2016-12-08 11:23:09 -05:00
Toshio Kuratomi
f0f1dc985f Fix incorrect line breaking 2016-12-08 11:23:09 -05:00
Toshio Kuratomi
9f043d9ba8 Further optimizations pointed out by @kustodian in #1516
* Only install yum-utils if needed (b/c we're going to use repoquery)
* Add a warning message explaining that why slower repoquery was used
  rather than yum API.
2016-12-08 11:23:08 -05:00
Toshio Kuratomi
ba566501a8 Yum API is faster than calling out to repoquery. Looking through the commit logs it looks like we weren't previously doing that because of commit 14479e6adc
The message there is that Yum API prints an error message if the
rhn-plugin is in use and no rhn-certificate is available.  So instead of
using repoquery in preference always here we use repoquery in preference
if the rhn-plugin is enabled.
2016-12-08 11:23:08 -05:00
David Shrewsbury
9cbd7b2ece Remove os_security_group_rule module
The rules module will have it's own branch.
2016-12-08 11:23:08 -05:00
David Shrewsbury
6527f895a1 Remove 'result' value
This value is pretty much useless, and a holdover from the old
module code. Let's remove it.
2016-12-08 11:23:08 -05:00
Monty Taylor
eb2f3c8a44 Update version added 2016-12-08 11:23:08 -05:00
David Shrewsbury
7f0da6d851 Update the docstring for os_security_group
Indicate that idempotence is on security group names, and give
an example for updating a security group description.
2016-12-08 11:23:08 -05:00
David Shrewsbury
640dbee643 Update for latest shade API
Shade version 0.7.0 introduces new API methods for creating,
deleting, and updating security groups. Let's use those and
clean up the module.
2016-12-08 11:23:08 -05:00
az7arul
5ffb677b00 add include_doc option 2016-12-08 11:23:08 -05:00
Jamie Hannaford
f969bc0549 Fix get_launch_config var name 2016-12-08 11:23:08 -05:00
Jamie Hannaford
6b9310ecfb Fix attribute name for Auto Scale servers 2016-12-08 11:23:08 -05:00
Julia Kreger
d67ba5e25b Updating os_ironic_node module
Updating the os_ironic_node module to the most recent version
including support for power and maintenance states.
2016-12-08 11:23:08 -05:00
Julia Kreger
51149b9643 Updating os_ironic module
Updating os_ironic module to the most recent version accounting for
changes in Ansible devel branch and the shade library since the
original creation of the module.
2016-12-08 11:23:08 -05:00
nitzmahone
548ab163f5 Added choice validation for state arg
fixes traceback on invalid state arg
2016-12-08 11:23:08 -05:00
Toshio Kuratomi
ada424078b Restore setting cachedir when non-root but don't take a useless cachedir parameter to the function
* Revert "Remove unused code"
  This reverts commit bcfba0c050.
* Re-add the changes to remove cachedir as a parameter
2016-12-08 11:23:08 -05:00
Greg DeKoenigsberg
4cdd58064d Updated author data for modules 2016-12-08 11:23:08 -05:00
Sergei Antipov
e62f870859 mysql_user | Hide password 2016-12-08 11:23:08 -05:00
Greg DeKoenigsberg
eb881d7d5d Proper author info for all remaining modules 2016-12-08 11:23:07 -05:00
Greg DeKoenigsberg
18ca7aee07 Updating cloud modules with proper github author information 2016-12-08 11:23:07 -05:00
Robert Estelle
8b2327fe3a Fix missing instance_id param in ec2_eip. 2016-12-08 11:23:07 -05:00
Kamil Madac
1ae799f361 Better error handling in supervisorctl module.
If execution of supervisorctl was not successful (exit code > 0),
module silently supress this error and returns changed = false,
which turns to OK task state.
This is very confusing, when supervisorctl needs authentication,
and credentials are not specified in module or are incorrect,
services are not restarted/started/stopped without raising an error.
2016-12-08 11:23:07 -05:00
Monty Taylor
574bcac277 Add developer docs for the OpenStack modules 2016-12-08 11:23:07 -05:00
Hagai Kariti
b154ad4cbb ec2_vol: fix race conditions because we handle errors before actually deleting
Just try to delete the volume and handle the error amazon sends
2016-12-08 11:23:07 -05:00
Tyler Cross
9babe9b07d Get specific object version with S3 module.
- allow specifying version for mode=get and mode=getstr
- when version specified doesn't exist give an error message that indicates so
2016-12-08 11:23:07 -05:00
Pepe Barbe
5dc322b911 Add OS architecture and OS name to the Windows setup module 2016-12-08 11:23:07 -05:00
Monty Taylor
51ce05bfb9 Add Ironic Node module 2016-12-08 11:23:07 -05:00
Monty Taylor
e534753092 Add Ironic module 2016-12-08 11:23:07 -05:00
Monty Taylor
0447a88c80 Add OpenStack Object module 2016-12-08 11:23:07 -05:00
Monty Taylor
234a6c93c7 Add OpenStack Security Group support
Two modules - one for security groups and one to manage rules in a
security group.
2016-12-08 11:23:07 -05:00
Robert Estelle
ecae3403af Remove unnecessary wait_timeout parameter. 2016-12-08 11:23:07 -05:00
Robert Estelle
3798c8c0ce Refactoring of ec2_eip module. 2016-12-08 11:23:07 -05:00
Robert Estelle
41f7e4ed5e ec2_eip - PEP8 and minor style cleanups. 2016-12-08 11:23:07 -05:00
Robert Estelle
a41994974c EC2 Security Group - Validate parameters. 2016-12-08 11:23:07 -05:00
Edward Torbett
3a4d8f22a6 Renamed previous pkgs variable to installed_pkgs as spotted by @strahinja 2016-12-08 11:23:06 -05:00
Edward Torbett
dad26d70fa Corrected pkg to pkgs as noted by @abadger 2016-12-08 11:23:06 -05:00
Edward Torbett
9707a5a95e Added multi package operation to remove as suggested by @abadger. Adding to latest is a little more complex due to '*' support. 2016-12-08 11:23:06 -05:00
Edward Torbett
32180c3c0e Comments by @abadger 2016-12-08 11:23:06 -05:00
Edward Torbett
4b3fff108d Rather than executing yum once per package, execute yum once for all supplied packages. This is necessary when performing a yum upgrade involving multiple dependent packages installed from RPM, for example when upgrading from PostgreSQL 9.0.11 to 9.0.21 on a Red Hat server. 2016-12-08 11:23:06 -05:00
Ching Yi, Chan
be9cddbddf Refactoring for easier to read 2016-12-08 11:23:06 -05:00
Ching Yi, Chan
7cafbb5f05 Prevent memory-error from a large file 2016-12-08 11:23:06 -05:00
Soenke Ruempler
b57bcac72f Add support for SNS notification ARNs in CloudFormation 2016-12-08 11:23:06 -05:00
Andrea Mandolo
adb53cc3c5 Add "block_device_mapping" parameter on EC2_AMI Amazon module (DOCUMENTATION) - upgraded 2016-12-08 11:23:06 -05:00
Jon Hawkesworth
c86ed93f67 remove include of files options only relevant to unix from win_file.py documentation 2016-12-08 11:23:06 -05:00
Brian Coca
f66ed3a85e minor doc fixes on win_template 2016-12-08 11:23:06 -05:00
Bruce Pennypacker
4cb7df2631 Added delobj command to delete an object within a bucket 2016-12-08 11:23:06 -05:00
Jon Hawkesworth
a9b77e8480 corrected version added which I got wrong while rebasing 2016-12-08 11:23:06 -05:00
Jon Hawkesworth
5b6195e613 Fix win_copy problems described here: https://github.com/ansible/ansible-modules-core/issues/1404 and update documentation. 2016-12-08 11:23:06 -05:00
Brian Coca
b2dadaadf8 Revert "added innitial daemon-reloaded support to service module"
This reverts commit 438d87d269.
2016-12-08 11:23:06 -05:00
Brian Coca
3d42d8897e fixed doc issue with git 2016-12-08 11:23:06 -05:00
Brian Coca
523b4d638e updated version added 2016-12-08 11:23:05 -05:00
Louis-Michel Couture
03240cfcb6 Update example to remove outdated information 2016-12-08 11:23:05 -05:00
Brian Coca
61054921cf updated package examples 2016-12-08 11:23:05 -05:00
Brian Coca
d4d362b475 corrected copyright ... does a copied the copyrightnotice require copyright? 2016-12-08 11:23:05 -05:00
Brian Coca
0f30122750 may root help us all 2016-12-08 11:23:05 -05:00
Brian Coca
55d04f4ddf added innitial daemon-reloaded support to service module 2016-12-08 11:23:05 -05:00
Dionysis Grigoropoulos
59f7db899d git: Add option to verify GPG signature of commit 2016-12-08 11:23:05 -05:00
Alex Gandy
75fa5811db Added volumes dict to ec2_lc example 2016-12-08 11:23:05 -05:00
toninog
15b65fa115 Fixed bug in example where updating a user to a group Fixed bug in create_group and update_group whereby paramaters were not being set correctly. 2016-12-08 11:23:05 -05:00
Monty Taylor
97ce6a500d Update doc params and version_added 2016-12-08 11:23:05 -05:00
Benno Joy
f6f2359400 fix for 11177 where module readds rule even if the rules exists 2016-12-08 11:23:05 -05:00
Monty Taylor
29115f0602 AnsibleModule takes a dict as a param 2016-12-08 11:23:05 -05:00
Monty Taylor
dbf821ff67 Return a list of OpenStack clouds
The main use of this is to feed jinja templating, so structure the
data returned slightly better for that purpose.
2016-12-08 11:23:05 -05:00
Monty Taylor
b87c9002ae Add OpenStack Client Config module
All of the ansible OpenStack modules are driven by a clouds.yaml config
file which is processed by os-client-config. Expose the data returned by
that library to enable playbooks to iterate over available clouds.
2016-12-08 11:23:05 -05:00
Monty Taylor
58942eba2e Use the delete method from shade
Sigh. Turns out glance v1 and glance v2 delete images differently too.
2016-12-08 11:23:05 -05:00
Monty Taylor
8958deeb02 Don't update image properties if we're deleting 2016-12-08 11:23:05 -05:00
Monty Taylor
a4e4dbd863 Add OpenStack Image module
Also deprecate old glance_image module
2016-12-08 11:23:05 -05:00
Brian Coca
5ae6f5b767 reverting pep changes that were breaking documentation 2016-12-08 11:23:04 -05:00
Brian Coca
336c22bfd9 made non exec 2016-12-08 11:23:04 -05:00
Tim Mahoney
fb3c457122 Elasticache Subnet Group 2016-12-08 11:23:04 -05:00
Monty Taylor
0bc85d461b Add missing state parameter 2016-12-08 11:23:04 -05:00
Sankalp Khare
f7055c88de Fixed a typo in ec2_vpc module documentation 2016-12-08 11:23:04 -05:00
billwanjohi
ff7dfefbd6 cloudformation: accept local templates in yaml format
Since the YAML data format is a subset of JSON, it is trivial to convert
the former to the latter. This means that we can use YAML templates to
build cloudformation stacks, as long as we translate them before passing
them to the AWS API. I figure this could potentially be quite popular in
the Ansible world, since we already use so much YAML for our playbooks.
2016-12-08 11:23:04 -05:00
James Martin
38d0f31cac Streamlined rolling udpate algorithm. Still need to account for partials, and not waiting for instances if we're mass terminating them. 2016-12-08 11:23:04 -05:00
Demian Gemperli
1c5cb83ff3 Allow to add build flags for gem installation 2016-12-08 11:23:04 -05:00
whiter
fc53c2431d Added changed=True flag when new subnet groups created. Added conditional so that modify_db_subnet_group is only called when necessary and changed=True flag will be set. 2016-12-08 11:23:04 -05:00
Jonathan Davila
77fa67a240 author fix 2016-12-08 11:23:04 -05:00
Jonathan Davila
d4aff86349 iam_policy 2016-12-08 11:23:04 -05:00
Trevor Pounds
9de952cb3f Instance deregistration should try all associated ELBs. Fixes #869 2016-12-08 11:23:04 -05:00
Trevor Pounds
eff6307ac3 Use auto scaling group managed ELBs if present. 2016-12-08 11:23:04 -05:00
Jonathan Davila
a329dc05c0 iam module with fixes
iam module. fix policy issue.

bugfix

allow for modifying path without declaring new_path
2016-12-08 11:23:04 -05:00
Gugli
a00c078912 Add support for repos with svn:externals files
When a SVN repository has some svn:externals properties, files will be
reported with the X attribute, and lines will be added at the end to
list externals statuses with a text looking like
"Performing status on external item at ....".
Such lines were counted as a local modification by the regex, and the
module returned a change, even though they were none.

To have a clean (and parsable) "svn status" output, it is recommended
to use the --quiet option. The externals will only appear if they have
been modified. With this option on, it seems even safer to consider
there are local modifications when "svn status" outputs anything.
2016-12-08 11:23:04 -05:00
Raghu Udiyar
e6e8f65e92 Creating ami should be idempotent
If the ami already exists, return details of the duplicate
ami instead of failing with an error.
2016-12-08 11:23:04 -05:00
tedder
dd6d5f0cb5 feature pull request: catch and retry recoverable errors
boto can throw SSLError when timeouts occur (among other SSL errors). Catch these so proper JSON can be returned, and also add the ability to retry the operation.

There's an open issue in boto for this: https://github.com/boto/boto/issues/2409

Here's a sample stacktrace that inspired me to work on this. I'm on 1.7, but there's no meaningful differences in the 1.8 release that would affect this. I've added line breaks to the trace for readability.

    failed to parse: Traceback (most recent call last):
      File "/home/ubuntu/.ansible/tmp/ansible-tmp-1419895753.17-160808281985012/s3", line 2031, in <module> main()
      File "/home/ubuntu/.ansible/tmp/ansible-tmp-1419895753.17-160808281985012/s3", line 353, in main download_s3file(module, s3, bucket, obj, dest)
      File "/home/ubuntu/.ansible/tmp/ansible-tmp-1419895753.17-160808281985012/s3", line 234, in download_s3file key.get_contents_to_filename(dest)
      File "/usr/local/lib/python2.7/dist-packages/boto/s3/key.py", line 1665, in get_contents_to_filename response_headers=response_headers)
      File "/usr/local/lib/python2.7/dist-packages/boto/s3/key.py", line 1603, in get_contents_to_file response_headers=response_headers)
      File "/usr/local/lib/python2.7/dist-packages/boto/s3/key.py", line 1435, in get_file query_args=None)
      File "/usr/local/lib/python2.7/dist-packages/boto/s3/key.py", line 1488, in _get_file_internal for bytes in self:
      File "/usr/local/lib/python2.7/dist-packages/boto/s3/key.py", line 368, in next data = self.resp.read(self.BufferSize)
      File "/usr/local/lib/python2.7/dist-packages/boto/connection.py", line 416, in read return httplib.HTTPResponse.read(self, amt)
      File "/usr/lib/python2.7/httplib.py", line 567, in read s = self.fp.read(amt)
      File "/usr/lib/python2.7/socket.py", line 380, in read data = self._sock.recv(left)
      File "/usr/lib/python2.7/ssl.py", line 341, in recv return self.read(buflen)
      File "/usr/lib/python2.7/ssl.py", line 260, in read return self._sslobj.read(len) ssl.SSLError: The read operation timed out
2016-12-08 11:23:04 -05:00
Toshio Kuratomi
fa60891f68 Fix a problem introduced with #1101 and optimize privilege handling
* If a db user belonged to a role which had a privilege, the user would
  not have the privilege added as the role gave the appearance that the
  user already had it.  Fixed to always check the privileges specific to
  the user.
* Make fewer db queries to determine if privileges need to be changed
  and change them (was four for each privilege.  Now two for each object
  that has a set of privileges changed).
2016-12-08 11:23:03 -05:00
Tristan Fisher
75ef963922 removes bool type from validate. 2016-12-08 11:23:03 -05:00
Tristan Fisher
0180be25c4 standardizes bools in argument_spec 2016-12-08 11:23:03 -05:00
jaypei
fbc8d4ca4a use the right way to unescape line string Reference https://github.com/ansible/ansible/issues/10864 2016-12-08 11:23:03 -05:00
Feanil Patel
36dfb78831 Output the Internet Gatewoy id directly instead of in a dict. 2016-12-08 11:23:03 -05:00
Benno Joy
70188fe02a Fixes issue 1197 for s3 module, where the file gets downloaded even if checksums match 2016-12-08 11:23:03 -05:00
Feanil Patel
bfb36f0f1f Tell me what the igw id is if we created an igw. 2016-12-08 11:23:03 -05:00
Toshio Kuratomi
5027fc0642 Expand tildes and vars in the config file path 2016-12-08 11:23:03 -05:00
Brian Coca
d7bd36a215 Revert "Add deprecated documentation for _quantum_subnet" cause it was already added
This reverts commit 3fa32c4984.
2016-12-08 11:23:03 -05:00
Toshio Kuratomi
8576d1f9d1 Add deprecated documentation for _quantum_subnet 2016-12-08 11:23:03 -05:00
Will Thames
34e0e17090 Perform privilege grants/revokes only when required
Use `has_table_privileges` and `has_database_privileges`
to test whether a user already has a privilege before
granting it, or whether a user doesn't have  a privilege
before revoking it.
2016-12-08 11:23:03 -05:00
David Shrewsbury
67d8ff197e Rename os_subnet to os_subnet.py 2016-12-08 11:23:03 -05:00
Monty Taylor
acdc90f31d Add OpenStack Subnet module
Also deprecated old quantum_subnet module
2016-12-08 11:23:03 -05:00
xiaclo
8715ce07ae Fix issue #1156
Fix as suggested in the issue.

https://github.com/ansible/ansible-modules-core/issues/1156
2016-12-08 11:23:03 -05:00
Toshio Kuratomi
4f42e752e6 Allow playbook specified login_user and login_password to override config file settings 2016-12-08 11:23:03 -05:00
James Cammarata
46b60a5b70 Fix missing expanduser on chdir value 2016-12-08 11:23:03 -05:00
James Cammarata
d07378ceac Command module changes for v2 compatibility 2016-12-08 11:23:03 -05:00
Toshio Kuratomi
0af631499a Use a list comprehension instead of map and lambda 2016-12-08 11:23:02 -05:00
Toshio Kuratomi
8976b46888 Import ansible module_utils at bottom of file to not mess with line numbers in tracebacks 2016-12-08 11:23:02 -05:00
Toshio Kuratomi
b6257f73b4 Properly flip default for verifying server cert. Add nice error messages when the cert is invalid 2016-12-08 11:23:02 -05:00
Toshio Kuratomi
a4497a7ddf Change uri module to validate ssl certs by default 2016-12-08 11:23:02 -05:00
whiter
8ee2102993 Doc update to highlight use of body_type parameter 2016-12-08 11:23:02 -05:00
Toshio Kuratomi
c291c2dfea Fix for the new import code when password is empty 2016-12-08 11:23:02 -05:00
Jonathan Mainguy
a3f30540ca add :// url support for EL 5 2016-12-08 11:23:02 -05:00
Dennis Rowe
5109628693 Strip spaces around perms 2016-12-08 11:23:02 -05:00
billwanjohi
a6fd78af37 s3 put: add support for server-side encryption
- added 'encrypt' boolean option
- reordered module options alphanumerically
2016-12-08 11:23:02 -05:00
Toshio Kuratomi
b6a312e489 Minor fixups found during review of #582 2016-12-08 11:23:02 -05:00
Patrik Lundin
899788f1a7 service: Fix comments in OpenBsdService class.
No functional change.
2016-12-08 11:23:02 -05:00
Johann Schmitz
8f8109f1e0 Improved output of mysql_db plugin
Show error number and error description on connect error to ease debugging.
2016-12-08 11:23:02 -05:00
Andrew Pashkin
a960caae96 Add 'docker_api_version' to docker_image
By default docker-py uses latest version of Docker API. This is not
always desireable, and this patch adds option to specify version, that
should be used.
2016-12-08 11:23:02 -05:00
Jonathan Mainguy
7ab2ddbe2a escapeds changes
fixed merge conflict

remove uneeded regexs

arrays
2016-12-08 11:23:02 -05:00
Brian Coca
322518d06c stat doc fix fixes #1371 2016-12-08 11:23:02 -05:00
Robin Miller
a2f685a134 Replaced lambda functions with list comprehensions. 2016-12-08 11:23:02 -05:00
whiter
d252e7c08f Fix for issue #1332 - when instance is has finished deleting and get_db_instance returns None, exit gracefully 2016-12-08 11:23:01 -05:00
Robin Miller
8859a7cf8e Only revoke actually granted permissions, not 'ALL'.
This prevents errors when the login_user does not have 'ALL'
permissions, and the 'priv' value contains fewer permissions than are
held by an existing user. This is particularly an issue when using an
Amazon Web Services RDS instance, as there is no (accessible) user with
'ALL' permissions on *.*.
2016-12-08 11:23:01 -05:00
Brian Coca
7ccc2143fd sleep when only doing a time delay to avoid cpu churn 2016-12-08 11:23:01 -05:00
fdupoux
e34c7f31dc Refactoring to avoid duplication of code which manages the decompression of database dumps in various formats 2016-12-08 11:23:01 -05:00
fdupoux
9b83311471 Simplify code which prepares the decompression command 2016-12-08 11:23:01 -05:00
Toshio Kuratomi
dd4838e4aa Refactor dump compression and use get_bin_path for finding the compressors 2016-12-08 11:23:01 -05:00
fdupoux
aa79810cc8 Decompress mysql dumps on the fly using python subprocess during an import to simplify operation 2016-12-08 11:23:01 -05:00
Wang Qiang
86b6f39cf0 Do instance update after add tags to instance. 2016-12-08 11:23:01 -05:00
Jonathan Mainguy
20301427f8 fixes check mode for Ubuntu 14.04 2016-12-08 11:23:01 -05:00
James Cammarata
3e72a0657d Re-reverting windows modules PR #384 2016-12-08 11:23:01 -05:00
Vladislav Lewin
36ce019beb add SLE12 support to hostname.py 2016-12-08 11:23:01 -05:00
marko
de813195c5 Added support for foreign security groups (Fixes: #373) 2016-12-08 11:23:01 -05:00
Jesse Keating
96b03ce138 Add an openstack servers actions module
This module supports a few of the server actions that are easy to
initially impiment. Other actions require input and provide return
values in the API calls that will be more difficult to impliment, and
thus are not part of this initial commit.
2016-12-08 11:23:01 -05:00
Vasyl Kaigorodov
70235a930b Fix "_is_package_installed() takes exactly 4 arguments, 3 provided" error 2016-12-08 11:23:01 -05:00
Schlueter
b3be960d24 Add 'version_added' to state documentation for easy_install resource 2016-12-08 11:23:01 -05:00
Schlueter
9e8ce34031 Correct reference to gem in easy_install resource 2016-12-08 11:23:01 -05:00
Schlueter
58863d3b48 Add Documentation 2016-12-08 11:23:01 -05:00
Schlueter
1fc687b19d Use standard if statement to check state in easy_install resource 2016-12-08 11:23:00 -05:00
Schlueter
1ddf4c2368 Correct pass by object reference issue 2016-12-08 11:23:00 -05:00
Jonathan Mainguy
b25bc20d3d changes hostname to lowercase 2016-12-08 11:23:00 -05:00
Jonathan Mainguy
ce4c9cccf5 fixes example documenation 2016-12-08 11:23:00 -05:00
Zoltan Kozma
1a6b273a4f - Fixed annoying bug that disablerepo was essentially broken if a package needed updating by state latest. - Replaced some unsafe practice with default parameters. However looking at the code this does not seem to matter much as the calling functions always seem to supply these parameters anyway. 2016-12-08 11:23:00 -05:00
Schlueter
e198884280 Add state to easy_install 2016-12-08 11:23:00 -05:00
Jonathan Mainguy
06cd532cc5 added nice error for systemd hosts where name > 64 chars 2016-12-08 11:23:00 -05:00
Semyon Deviatkin
732b26ab23 Fix issue #1230
When virtual package providing only one package, look up status of target package
2016-12-08 11:23:00 -05:00
Toshio Kuratomi
9eac68b417 Fix problem writing binary content to a temporary file in the uri module.
Fixes https://github.com/ansible/ansible/issues/10938
Fixes https://github.com/ansible/ansible/issues/7606
2016-12-08 11:23:00 -05:00
Monty Taylor
eeacb7486d Add OpenStack Network module
Also, deprecate the old quantum network module
2016-12-08 11:23:00 -05:00
Toshio Kuratomi
84110be91d Update the cron docs to specify that it takes a boolean value 2016-12-08 11:23:00 -05:00
Toshio Kuratomi
623f70ecd6 Fix documentation of the variable that backup file name is returned in 2016-12-08 11:23:00 -05:00
Greg Taylor
79dd0466b5 Adding directory creation example to file module. 2016-12-08 11:23:00 -05:00
Brian Coca
b4775234c9 minor docfix 2016-12-08 11:23:00 -05:00
Brian Coca
831af880f0 minor doc fix and made sure check_implicit_admin is true boolean 2016-12-08 11:23:00 -05:00
Toshio Kuratomi
5c96c5c9c2 Fix splitting of role_attrs 2016-12-08 11:23:00 -05:00
Toshio Kuratomi
7e5a4afb6b Update module "imports" to new style
Fixes #1351
2016-12-08 11:23:00 -05:00
Brian Coca
b13fd5ac9a value should be string as that is what it compares against 2016-12-08 11:22:59 -05:00
Pierre Baillet
eba0f12769 Support optional dockerfile name 2016-12-08 11:22:59 -05:00
Jonathan Mainguy
f4b07b105b added openbsd to hostname module 2016-12-08 11:22:59 -05:00
Toshio Kuratomi
20d7f929be Fix use of codecs.escape_decode() 2016-12-08 11:22:59 -05:00
Toshio Kuratomi
5204e94bda Slightly more future-proof version of the lineinfile fix 2016-12-08 11:22:59 -05:00
Toshio Kuratomi
1002fafedf Correct lineinfile documentation about double quoting... Hasn't been the case for years. 2016-12-08 11:22:59 -05:00
Semyon Deviatkin
e94140e52b Fix unused variable systemd_enabled
Removed declared but unused variable systemd_enabled
2016-12-08 11:22:59 -05:00
Benno Joy
d24fbf5c3e fixe issue #600, where ec2 module returns instance state as runing even after instance is terminated 2016-12-08 11:22:59 -05:00
fdupoux
6f2f07ef51 Add support for xz compression (for dump and import) in mysql_db module 2016-12-08 11:22:59 -05:00
Brian Coca
18e16a16b7 fixed try/except/finally to be 2.4 compatible 2016-12-08 11:22:59 -05:00
whiter
0eb17142b5 Added postgresql-license type 2016-12-08 11:22:59 -05:00
Jason Paige
329266975b update flat description
default behavior is to append the `hostname/path/to/file`, not prepend as currently stated by the flat arg docs
2016-12-08 11:22:59 -05:00
zimbatm
933256fc63 ec2_group: prioritise current VPC group names over others 2016-12-08 11:22:59 -05:00
zimbatm
c3e720a393 ec2_group: select own group if the name matches
This fixes an issue where multiple VPC have the same group name and
the one from the other VPC is selected.
2016-12-08 11:22:58 -05:00
Martin Froehlich
8bff781a0a Use get_aws_connection_info to get AWS creds.
Previously used get_ec2_creds did not consider security_token,
making MFA requests fail.
2016-12-08 11:22:58 -05:00
Brian Coca
831e1d8739 added updated cache time to apt, also started documenting return values 2016-12-08 11:22:58 -05:00
Jesse Keating
17aabee6df Add service option to avoid failure on missing service
This adds a must_exist option to the service module, which gives callers the
ability to be tolerant to services that do not exist. This allows for
opportunistic manipulation of a list of services if they happen to exist on the
host. While failed_when could be used, it's difficult to track all the
different error strings that might come from various service tools regarding a
missing service.
2016-12-08 11:22:58 -05:00
Jan Brauer
af689dece3 Handle the case where a stack rollback fails. 2016-12-08 11:22:58 -05:00
Matt Schurenko
ef140a084a adding stickiness support to ec2_elb_lb.py
removing policy if enabled is no

adding sanity checks

removing debuging

check if policy exists before deleting

updating version_added to 2.0

adding stickiness support to ec2_elb_lb.py (squashed commit)
2016-12-08 11:22:58 -05:00
Jell
2e007167b9 Find or Create volume by name 2016-12-08 11:22:58 -05:00
Toshio Kuratomi
5336217649 Several cleanups to many modules:
* Fix docs to specify when python2.6+ is required (due to a library
  dep).  This helps us know when it is okay to use python2.6+ syntax in
  the file.
* remove BabyJson returns.  See #1211  This commit fixes all but the
  openstack modules.
* Use if __name__ == '__main__' to only run the main part of the module
  if the module is run as a program.  This allows for the potential to
  unittest the code later.
2016-12-08 11:22:58 -05:00
Brian Coca
0567404c03 generic fix for Exceptions that heppen when trying to set permissions on extracted files fixes ansible/ansible#10934 which is really a corner case 2016-12-08 11:22:58 -05:00
Nathaniel
935550d20d Update set_fact.py
Context: I recently discovered that when setting a fact, key=value pairs and complex arguments differ in how the fact is stored. For example, when attempting to use complex arguments using key=values, the result can be stored as a unicode string as opposed to an object/list/etc.

I'm hoping the above example update will better demonstrate to and instruct people to use complex arguments instead of key=value pairs in certain situations.
2016-12-08 11:22:58 -05:00
Matt Martz
65508bb21a Python2.4 fixes
* Ignore accelerate.py
* Don't use a lambda or a ternary
2016-12-08 11:22:58 -05:00
macbeth76
fce97365a4 Update user.py
M in date format is minutes. m is for months.
2016-12-08 11:22:58 -05:00
Chris Lundquist
7b4107a169 fix ami_search doc copy pasta 2016-12-08 11:22:58 -05:00
Toshio Kuratomi
dd02483b26 Explain why the apt module does not do implicit regex matches on package name since this is different than the apt-get command line tool.
Fixes #1258
2016-12-08 11:22:58 -05:00
Dominic Hargreaves
535f0e9b11 apt_key documentation: add a note explaining the benefit of including 'id' 2016-12-08 11:22:58 -05:00
Benno Joy
fc1ad5e1f1 fixes issue 122, where the module recreates the route table in each run 2016-12-08 11:22:58 -05:00
Ratnadeep Debnath
a99d7da0c1 Fixed typo in cloud docker module. 2016-12-08 11:22:57 -05:00
Toshio Kuratomi
5844a04061 Fix documentation formatting 2016-12-08 11:22:57 -05:00
Bret Martin
b2453bf9a3 ec2_vpc module: add route table resource tagging 2016-12-08 11:22:57 -05:00
Jonathan Mainguy
f662a48de7 Adds the exclude= option to the yum module. Works the same way --exclude does when yum install or yum update 2016-12-08 11:22:57 -05:00
Herby Gillot
6a39dc891a Use existing ec2_eip address if already associated
If an EC2 instance is already associated with an EIP address, we use
that, rather than allocating a new EIP address and associating it with
that.

Fixes #35.
2016-12-08 11:22:57 -05:00
louis
9d20a3091e added skeleton support in user module 2016-12-08 11:22:57 -05:00
(@cewood)
17b5d851f2 Support specifying cidr_ip as a list
Update/fix to Support specifying cidr_ip as a list

Unicode isn't compatible with python2, so we needed some other
solution to this problem. The simplest approach is if the ip item
isn't already a list, simply convert it to one, and we're done.
Thanks to @mspiegle for this suggestion.
2016-12-08 11:22:57 -05:00
Jonathan Mainguy
1ba2e34ae1 Adds all_databases option which allows a user to dump or import all databases at once, identical to mysqldump --all-databases
fix line 132

Update to name=all

cleaned up all_database per abadger's suggestions
2016-12-08 11:22:57 -05:00
Sam Doiron
a3ec0a1562 Fix Issue #1216 (ValueError with Amazon RDS)
Fix typo where wrong variable was used, causing ValueError.
2016-12-08 11:22:57 -05:00
Alex Feinberg
1ac9c20b6e Fix a typo in create_instances
Fix a typo in create_instances: use 'placement_group' instead of placement_group
when calling boto_siupports_param_in_spot_request().
2016-12-08 11:22:57 -05:00
Brian Coca
fb527955c9 added deprecated doc entry 2016-12-08 11:22:57 -05:00
James Cammarata
d7ce6b0d4b Fix bug in service where upstart services incorrectly use init scripts
Fixes #1170
2016-12-08 11:22:57 -05:00
Toshio Kuratomi
c2bf2c7c54 Fix error when container has no names.
Rename loop variable from "i" to more informative "container"

Fixes #1188
2016-12-08 11:22:57 -05:00
David Shrewsbury
dd6b153700 Update os_server for shade flavor API changes
Latest shade fixes the flavor API so that raw objects are not
returned.
2016-12-08 11:22:57 -05:00
Chris Meyers
cec3c8c209 better timeout logic when deleting vm disks. Python 2.4 safe excepts 2016-12-08 11:22:57 -05:00
Chris Meyers
cdcaa2d6a0 correctly delete disks associated with vms 2016-12-08 11:22:57 -05:00
Will Thames
9aff204f63 Usage is not a valid database or table privilege
Remove `USAGE` from the `VALID_PRIVS` dict for both database and
table because it is not a valid privilege for either (and
breaks the implementation of `has_table_privilege` and
`has_database_privilege`

See http://www.postgresql.org/docs/9.0/static/sql-grant.html
2016-12-08 11:22:57 -05:00
Will Thames
43bad27948 Update postgresql users only when necessary
For read-only databases, users should not change when no changes
are required.

Don't issue ALTER ROLE when role attribute flags, users password
or expiry time is not changing.

In certain cases (hashed passwords in the DB, but the password
argument is not hashed) passlib.hash is required to avoid
running ALTER ROLE.
2016-12-08 11:22:56 -05:00
Monty Taylor
78daf52994 Add OpenStack Server module
Also deprecated old nova_compute module
2016-12-08 11:22:56 -05:00
Ryan Hartkopf
118382ca70 synchronize: don't add ssh_args to ssh_opts when false or null 2016-12-08 11:22:56 -05:00
Brian Coca
2e9462aa21 minor doc fixes, set version added for new tags: parameter should Fix #10894 2016-12-08 11:22:56 -05:00
Toshio Kuratomi
8bc34613bc Second try at fixing #1227 -- set e default value earlier 2016-12-08 11:22:56 -05:00
Toshio Kuratomi
030858df67 Return empty list if an image has no repo_tags 2016-12-08 11:22:56 -05:00
Julia Kreger
6f7cd5c307 Set default for mysql_user config_file
The default value set by the module was a value of None for the
config_file parameter, which propogates into the connect method
call overriding the stated default in the method.

Instead, the default should be set with-in the parameter
specification so the file check is not requested to check None.
2016-12-08 11:22:56 -05:00
Toshio Kuratomi
0d468a3aa0 Get docker's default api version definition from both 1.2 location and pre-1.2 location
Fixes #1227
2016-12-08 11:22:56 -05:00
Brian Coca
018b0118dc removed deprecated docs, not true anymore 2016-12-08 11:22:56 -05:00
Toshio Kuratomi
4592b795d9 Only split on the first colon.
Fixes #1214
2016-12-08 11:22:56 -05:00
Brian Coca
b5b34f6931 removed unused and undefined aws_regions 2016-12-08 11:22:56 -05:00
Evgenii Terechkov
37d6c10133 Add ALT Linux support to hostname module 2016-12-08 11:22:56 -05:00
Brian Coca
953ed0aecc avoid exception when boto is not available 2016-12-08 11:22:56 -05:00
Brian Coca
5e892b894b removed redundant region def 2016-12-08 11:22:56 -05:00
David Shrewsbury
c29ae705f0 Update os_server_volume for latest shade
The shade volume API was updated to return a dict rather than the
object as returned by cinder.
2016-12-08 11:22:56 -05:00
David Shrewsbury
4ea6bded61 Update os_volume for latest shade
The shade volume API was updated to return a dict rather than the
object as returned by cinder.
2016-12-08 11:22:56 -05:00
Sven Schliesing
90d434d66d use default value for parameter config_file in connect() 2016-12-08 11:22:55 -05:00
mcameron
dcb8fa0cb9 Net_id already present, remove unnecessary lookup. 2016-12-08 11:22:55 -05:00
mcameron
1cc057ca97 Valodate fip is on the correct network 2016-12-08 11:22:55 -05:00
mcameron
9f30125876 Adding openstack multiregion support 2016-12-08 11:22:55 -05:00
David Shrewsbury
4699e5b905 Recognize when volume attach/detach is not necessary
Do not attempt to attach an already attached volume.
Likewise, do not attempt to detach a volume that is not
attached.

This version adds support for check mode.
2016-12-08 11:22:55 -05:00
Heikki Partanen
ec566d86b3 Add support for extra_hosts to docker module
extra_hosts parameter (maps to --add-host in 'docker run' syntax) is used
to add host-to-ip mappings to the container.
2016-12-08 11:22:55 -05:00
Matt Martz
1ceaa78dc0 Add version_added for the use_ssh_args option 2016-12-08 11:22:55 -05:00
Matt Martz
4faf0d59da Add ability to specify using ssh_args in synchronize 2016-12-08 11:22:55 -05:00
Monty Taylor
63a0c0999a Add OpenStack Volume module 2016-12-08 11:22:55 -05:00