cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity
7833 commits 47 branches 390 tags 440 MiB
Commit graph

789 commits

Author SHA1 Message Date
Brian Coca
83669d7eda switched to iterator as per comments 2014-11-11 09:39:03 -05:00
Martijn P. Rijkeboer
5257222f33 Fix whitespace around '=' in sysctl.conf. 2014-11-10 20:00:28 +01:00
Brian Coca
e4b6968901 made hostname work with python 2.4 2014-11-08 12:08:47 -05:00
David Fritzsche
c96a85fb70 Add working status detection for pf on FreeBSD 
The return code of "service pf onestatus" is usually zero on FreeBSD (tested with FreeBSD 10.0), even if pf is not running. So the service module always thinks that pf is running, even when it needs to be started.
 2014-10-31 11:41:51 +01:00
Toshio Kuratomi
7f611468a8 Fix for systemd service scripts with newlines 
Fixes #127
 2014-10-22 16:43:35 -04:00
Patrik Lundin
f9d9c1b6d7 Multiple fixes for OpenBSD rcctl handling. 
* Use the newly added 'default' argument to know if the default flags are set
  or not.
* Handle that 'status' may either return flags or YES/NO.
* Centralize flag handling logic.
* Set action variable after check if we need to keep going.

Big thanks to @ajacoutot for implementing the rcctl 'default' argument.
 2014-10-12 18:41:23 +02:00
Patrik Lundin
e463400412 Simplify self.arguments logic. 
Strange logic pointed out by @jarmani, thanks!
 2014-10-06 21:20:20 +02:00
Patrik Lundin
924cf20cf8 Depend more on rcctl if it is present. 
* Make the module support enable/disable of special services like pf via rcctl.
  Idea and method from @jarmani.
* Make the module handle when the user supplied 'arguments' variable does not
  match the current flags in rc.conf.local.
* Update description now that the code tries to use rcctl for everything if it
  is available.
 2014-10-06 21:20:20 +02:00
Patrik Lundin
5f37624eb4 Tweak error checking for "enabled" code. 
Based on input from @jarmani:
* A return value of 2 now means a service does not exist. Instead of
  trying to handle the different meanings of rc after running "status",
  just look at stderr to know if something failed.
* Skip looking at stdout to make the code cleaner. Any errors should
  turn up on stderr.
 2014-10-06 21:20:20 +02:00
Patrik Lundin
c6dd88c1d1 Fail if "rcctl status" writes to stderr. 2014-10-06 21:20:20 +02:00
Patrik Lundin
1a8cdb5e3e Check rc and print error message if any. 
It is probably good to use stdout before printing a generic error
message as well.
 2014-10-06 21:20:20 +02:00
Patrik Lundin
c46e030100 Make "enabled" code aware of --check mode. 2014-10-06 21:20:20 +02:00
Jonathan Armani
1b97390765 Add enable / disable of services for OpenBSD if rcctl is present 2014-10-06 21:20:20 +02:00
louis
45f41f4b05 added skeleton support in user module 2014-09-30 08:16:19 +02:00
billwanjohi
ff36edbb11 user: add expired state 
ported from
https://github.com/ansible/ansible/pull/6303

It's very useful and routine to disable a *nix user.
I implemented expired instead of locked because this prevents any use of
the account, safer than just preventing password-based authentication.

I have tests [1], but since none of the suite came along with the core
modules, I'm unsure how to submit them.

[1] https://github.com/billwanjohi/ansible/blob/add_locked_state/test/integration/roles/test_user/tasks/main.yml
 2014-09-29 22:42:28 +00:00
kustodian
82af074382 Set selinux state to 'permissive' for state=disabled 2014-09-30 00:33:55 +02:00
Michael Scherer
37d9903169 Add hostname to generated user SSH key comment 
The default is not very useful to sort between different
keys and user. Adding the hostname in the comment permit to later
sort them if you start to reuse the key and set them in different
servers. See https://github.com/ansible/ansible/pull/7420
for the rational.
 2014-09-29 18:07:41 -04:00
Michael DeHaan
385a037cd6 package files 2014-09-26 11:05:47 -04:00
Michael DeHaan
c8e1a2077e file extensions! 2014-09-26 10:37:56 -04:00
Michael DeHaan
417309a626 Restructuring. 2014-09-26 10:13:26 -04:00
Michael DeHaan
73123b69fa Move modules into subdirectory. 2014-09-26 09:23:50 -04:00
Toshio Kuratomi
8b81062be0 The fix for gh-7284 causes problems for initscripts which have the 
standards compliant return codes but return a verbose error message via
stdout.  Limit the times when we invoke the heuristic to attempt to work
around this.
 2014-09-22 14:53:07 -04:00
Michael Scherer
c9a0a7ae4b Fix #9704, correctly set changed as false when nothing is done 2014-09-21 14:55:31 +02:00
Toshio Kuratomi
7b100dd389 Be more specific in checking if a job restarted successfully. 
Fixes: #9056
 2014-09-19 12:03:27 -07:00
Toshio Kuratomi
36083c3b90 Failure to enable a service now fails the task 
Fixes: 8855
 2014-09-18 12:39:54 -07:00
Toshio Kuratomi
a50258d26a remove debugging that was causing failure 2014-09-17 10:25:54 -07:00
Toshio Kuratomi
2e16bd3a44 Refactor the Linux service_enable() method 
* Fix check_mode for initctl systems

Fixes #9009
 2014-09-17 09:34:33 -07:00
Toshio Kuratomi
104401805b Revert "Refactor the Linux service_enable() method" needs some debugging 
This reverts commit e294e31fd3.
 2014-09-17 09:17:33 -07:00
Toshio Kuratomi
c362902f50 Refactor the Linux service_enable() method 
* Fix check_mode for initctl systems

Fixes #9009
 2014-09-17 08:44:32 -07:00
Toshio Kuratomi
a9928492f7 Make systemd vs rht detection more robust for centos 
Centos 6.x and below use an old RHT style of configuring hostname.
CentOS 7.x and better use systemd.  Instead of depending on the
distribution string which seems to have changed over the course of 6.x
we need to explicitly check the version.

Fixes #8997
 2014-09-16 09:53:13 -07:00
James Cammarata
7edcf21bdc Move initscript rc check to later in service status check 
Fixes #7284
 2014-09-11 12:11:06 -05:00
Michael DeHaan
5aa6ddef7f Tracebacks are now catchable with ignore_errors and have streamlined output. Also removes 'baby-JSON' for bash modules. 2014-09-11 12:27:21 -04:00
Patrik Lundin
0abf14ff19 service: use self.changed in service_enable_rcconf(). 
This sets the "changed" result of the module when a rc file is modified.
Previously only --check mode would show that it was going to change.
 2014-08-28 00:52:23 +02:00
James Cammarata
30d6713bf0 Add additional checks to detect upstart services 
Also adds checks for the upstart version, in order to test check
support for manual vs. start on manual
 2014-08-25 13:41:39 -05:00
Eri Bastos
6f8a29dc3d Proposed fix for issue #7757 2014-08-25 12:10:14 -05:00
James Cammarata
c8376e296f Tweaking change to documentation language for cron name param 2014-08-25 09:54:21 -05:00
James Cammarata
509761249c Merge branch 'devel' of https://github.com/mattparker/ansible into mattparker-devel 2014-08-25 09:51:17 -05:00
James Cammarata
07e77c5bed Merge pull request #8740 from mattparker/patch-1 
Name appears to be a required parameter for cron module
 2014-08-25 09:49:58 -05:00
James Cammarata
1f2727c607 Merge pull request #8729 from ercpe/openrc-hostname 
Hostname strategy implementation for OpenRC based systems (e.g. Gentoo)
 2014-08-25 09:28:29 -05:00
Matt Parker
6086c505fe Update cron documenation 
The "name" parameter seems to be rather important as the identifying feature of a cron job.  This is an update to the documentation to further emphasize this.
 2014-08-25 10:29:45 +01:00
Matt Parker
5accd15ba6 Name appears to be a required parameter 
As far as I can tell, `name` is a required parameter.  The guard test at (now) line 458 says you need name if `state == present` and at 464 if `state != present`, although that's not quite as clear.  Each of the code paths at 485 - 495 pass the name param through to `add_job`, `update_job` and `remove_job`, and the actual _update_job method earlier seems to require it too.  However I don't really know python so I may be wrong, but I can't see the circumstances when `name` is not required.
 2014-08-25 10:23:54 +01:00
Johann Schmitz
7ef67e3f8b Hostname strategy implementation for OpenRC based systems (e.g. Gentoo) 2014-08-23 09:00:28 +02:00
Ding Deng
85c6434262 debconf module: add the missing 'error' vtype and reorder vtypes as they appeared in debconf-devel(7). 2014-08-19 17:44:02 +08:00
Michael DeHaan
60ce2d3853 Fix documentation builds. 2014-08-08 15:12:10 -04:00
Michael DeHaan
f21d6c7980 Merge pull request #8002 from prune998/patch-2 
added missing force flag on mkfs commandline
 2014-08-08 13:55:19 -04:00
Michael DeHaan
185d5a6221 Merge branch 'spelling' of git://github.com/cgar/ansible into devel 
Conflicts:
	docsite/rst/guide_rax.rst
	plugins/callbacks/mail.py
 2014-08-08 13:28:45 -04:00
Michael DeHaan
66ec9089bd Update docs. 2014-08-08 11:51:27 -04:00
Michael DeHaan
f6f184b36d Updating docs. 2014-08-08 11:51:27 -04:00
Brian Coca
aeeefd046f bumped to 1.7 2014-08-08 11:51:27 -04:00
Brian Coca
5aa2ca762a added control to fail or not on missing key 
made split 'smarter' but still overridable
 2014-08-08 11:51:27 -04:00
Brian Coca
391f8ec600 added getent module to get system data as facts 2014-08-08 11:51:27 -04:00
Serge van Ginderachter
961d4b0d6c execute the mount after path validation 
This avoids a stale situation where name/path contains some impossible path,
but gets configured (faultly) in fstab, and the module only fails after that,
when creating that path.
 2014-08-06 10:52:08 +02:00
Jonathan Mainguy
650003dd5c Fixes issue #8339 where Scientific Linux incorrectly tries to use FedoraStrategy of hostnamectl 2014-08-02 15:38:52 -04:00
Michael DeHaan
e978dcf7eb Merge pull request #8283 from ps-jay/sys_mount_fstype_doc 
Add fstype arg to the mount examples
 2014-07-30 08:28:59 -04:00
Michael DeHaan
bc01f2571e Merge pull request #8311 from neersighted/wrap_distroversion 
Wrap get_distribution_version() in the hostname module
 2014-07-28 15:48:18 -04:00
Michael DeHaan
2212b64fd9 Cleaning up explanation of mount module states. 2014-07-28 12:18:45 -04:00
Bjorn Neergaard
cbc417ca1b Wrap get_distribution_version() in the hostname module 
We wrap get_distribution_version() with a new function,
_get_distribution_version(), that returns `0` when the result is a string or
`None`.

This accounts for the case when get_distribution_version() returns a string,
and we try to compare it to a float. We do this in the hostname module instead
of the module snippets because other modules may want the real string
version.module snippets because other modules may want the real string version.
 2014-07-28 11:16:30 -05:00
Michael DeHaan
99ad691950 Merge branch 'ufw' of git://github.com/Trozz/ansible into devel 2014-07-28 12:08:29 -04:00
Michael DeHaan
caba7ac6a6 Merge pull request #7954 from alimony/patch-3 
cron module: Use correct parameter name in error message.
 2014-07-28 11:29:05 -04:00
James Cammarata
03f0d6bec8 Merge pull request #8308 from robinro/extend-hostname-distrolist 
Extended distributions list for hostname module
 2014-07-28 09:12:59 -05:00
Robin Roth
7920f4eaf5 Fix extra newline at end of hostname for Fedora 
This fixes a bug introduced by 138b45e3.
The hostname has an additional newline at the end which leads to the
state always being 'changed: true' even if the hostname is unchanged.
 2014-07-28 15:22:10 +02:00
Robin Roth
a26bc9c926 Extended distributions list for hostname module 
Implementations already present
 2014-07-28 15:19:41 +02:00
Tom Lazar
d89adce760 FreeBSD 10 compatibility fix 
On FreeBSD the whitespace around the ``=`` triggers a (cryptic) ``no such file or directory`` error. removing the whitespace like above fixes this.
 2014-07-25 14:33:24 +02:00
Philip Jay
bb7b290ed8 Add fstype arg to the mount examples 
Needed fstype in the examples, since fstype is a required argument for
mount.
 2014-07-25 09:58:54 +10:00
Berend de Boer
f46c4ee093 Default for fstab missing, causing KeyError: 'fstab' 2014-07-24 13:14:46 +12:00
James Cammarata
6879e4ff0a Merge pull request #8223 from renard/create-fstab-if-not-exists 
Create fstab if not exists
 2014-07-21 15:03:14 -05:00
Sébastien Gross
e0f7b3f39c [mount] make sure fstab exists 
This is mainly to prevent from failing with no such file or directory
during module execution.
 2014-07-21 18:32:02 +02:00
Sébastien Gross
806052a9e5 [mount] Add documentation for fstab option 2014-07-21 18:30:59 +02:00
Hector Acosta
60edb6b04b Add check_mode support to authorized_key. Fixes #7300 
Signed-off-by: Hector Acosta <hector.acosta@gmail.com>
 2014-07-19 17:55:58 -05:00
Yasser Nabi
8cc894bef2 Enable puppet facts 
Currently facter facts omit facts that a distributed via Puppet. This
commit adds the `--puppet` option.

In cases where puppet is not installed, the command sends a warning to
STDERR *but* completes successfully. So should not cause any issues.

The benefit is, filtering can be done based on facts set by Puppet.
 2014-07-17 17:53:12 +01:00
Michael DeHaan
96fe275946 Merge pull request #8139 from peterkh/devel 
Fix "TypeError: group id must be integer" if groupid passed in for group key
 2014-07-16 15:55:14 -04:00
Ruggero Marchei
ae95ebd075 fix LooseVersion exception with empty distribution_version 2014-07-16 07:55:20 +02:00
Peter Hall
ae67002c15 Fix "TypeError: group id must be integer" if groupid passed in for group 
key
 2014-07-15 11:16:47 +10:00
Ruggero Marchei
8d01986617 fix issue #8102 2014-07-15 01:26:44 +02:00
Cristian Ciupitu
72d6e6d805 Remove useless code 2014-07-09 23:11:15 +03:00
Michael Leer
39b34b008c add interfact documentation #7704 2014-07-01 18:49:07 +01:00
Prune
afb358af77 added missing force flag on mkfs commandline 
even if the option ```force=yes``` is used in the playbook, it is not reflected in the mkfs command line.
As force option is dependent of the fs type, a "if-then-else" case have been added. Also, some FS types does not have a force option.
 2014-07-01 15:09:39 +02:00
Markus Amalthea Magnuson
a58709ac1d Use correct parameter name in error message. 
The parameter is called `cron_file` but the error message uses `file` which is confusing.
 2014-06-27 14:53:54 +02:00
James Cammarata
936daf6f63 Updating the other classes in the group module to match #7249 2014-06-24 12:28:43 -05:00
James Cammarata
4ca9ebf084 Merge pull request #7249 from jfchevrette/implement-group-checking-if-state-present 
Allow group module to handle check_mode properly when group.state=present and group already exists
 2014-06-24 12:27:31 -05:00
James Cammarata
236a2989cc Merge branch 'lvg_dm_names' of https://github.com/ajsalminen/ansible into ajsalminen-lvg_dm_names 2014-06-20 13:24:07 -05:00
James Cammarata
ad4926e090 Update authors for modprobe module 2014-06-20 11:12:49 -05:00
James Cammarata
974693882e Merge branch 'add_name' of https://github.com/stygstra/ansible into stygstra-add_name 2014-06-20 11:12:24 -05:00
James Cammarata
6ad83bb5ce Merge branch 'devel' of https://github.com/tgolly/ansible into tgolly-devel 2014-06-19 22:41:58 -05:00
Michael DeHaan
4fbc2a83e0 Merge pull request #7861 from cchurch/devel 
Windows Remote Support
 2014-06-19 22:10:41 -05:00
David Stygstra
cae41d0931 Added author and copyright lines to modules I contributed 2014-06-19 20:02:02 -04:00
Michael DeHaan
8b262d775b Slight tweak to windows wording. 2014-06-19 14:24:15 -05:00
Matt Martz
cab68bc579 Mention that with windows target hosts, fact_path and filter are not currently supported 2014-06-19 14:24:14 -05:00
James Cammarata
2c22cf46cf Merge branch '7763' of https://github.com/rmarchei/ansible into rmarchei-7763 2014-06-18 12:16:01 -05:00
James Cammarata
34405ea905 Merge branch 'lvg_fix' of https://github.com/sergevanginderachter/ansible into sergevanginderachter-lvg_fix 2014-06-18 09:00:41 -05:00
Ilya Rusalowski
b1a31ebb84 Set default vg_options to empty string 2014-06-17 20:42:18 +04:00
Ruggero Marchei
f522425415 move get_distribution_version() to basic.py 2014-06-17 10:22:14 +02:00
Ruggero Marchei
bd69e9f265 use different strategy for RHEL >= 7. Fixes 7763 2014-06-14 19:29:04 +02:00
James Cammarata
d35d5ac9d1 Merge pull request #7741 from mgcrea/devel 
Add support for Linaro distribution in hostname module
 2014-06-12 08:58:56 -05:00
James Cammarata
3e04d8c70c Merge pull request #7737 from toddmowen/zfs-fix-7696 
zfs: fix incompatibility - share.nfs vs sharenfs (issue #7696)
 2014-06-12 08:53:21 -05:00
Olivier Louvignes
158d6276eb Add support for Linaro distribution in hostname module 2014-06-12 12:06:59 +02:00
Todd Owen
34517b0836 zfs: work around incompatibility by renaming share.nfs to sharenfs 
Fixes #7696
 2014-06-12 16:21:16 +08:00
rgbkrk
5591e8838d Error checking and reporting on interface ufw rule 2014-06-11 11:10:38 -05:00
Ron Gomes
73246a49dc Fix incorrect argument ordering in error message, which provokes a 
printf-related TypeError.
 2014-06-09 15:03:51 -04:00
Yann Coleu
f378ed643c Add primary group in the first user module doc example 2014-06-02 14:32:52 +02:00
Nicolas Brisac
ecda1455bf open_iscsi module: support RC 21 when listing logged-in target 2014-05-24 18:14:28 +02:00
Brian Coca
5c87e97a45 now module searches for update-alternatives vs hardcoding it 2014-05-20 22:51:27 -04:00
James Cammarata
3a8ebd4325 Pull the link out of the alternatives output when not specified 
Fixes #7414
 2014-05-16 14:44:31 -05:00
Adam Chainz
6b10cf756a Fix grammar and value errors in cron documentation 2014-05-09 15:19:42 +01:00
Luca Berruti
eca36953c8 Make alternatives module python 5 compatible 2014-05-08 14:46:49 +02:00
Jean-Francois Chevrette
8756612599 this should return 0 to indicate a non-failure when check_mode is True 2014-05-07 10:20:51 -04:00
Antti Salminen
a6b482c500 Switch to mapper device name if pvs returns the wrong one. 2014-05-03 10:36:22 +03:00
Carlos E. Garcia
4dcaa9d9fb multiple spelling error changes 2014-04-29 10:41:05 -04:00
Michael Scherer
4ed4bfff90 Do not fail if we try to generate a ssh key for a user without being root 
If we try to use the user module without being root, it fail on RHEL/Fedora
because usermod --help cannot be run. The root cause is lack of permission
due to EAL4+ certification, as seen in shadow-utils changelo.

So if we cannot run it, assume there is no append. It doesn't matter
much since we will not be able to run usermod at all with or without the
option.
 2014-04-28 12:29:57 +02:00
Chris Lamb
b123b648a0 Correct/update debconf examples - need to specify vtype. 
Signed-off-by: Chris Lamb <chris@chris-lamb.co.uk>
 2014-04-23 21:51:01 +01:00
Michael Scherer
cf3365b99e Add a better error message for service 
While migrating my playbook to a newer ansible version, I faced
the error message "unknown init system, cannot enable service". It turned
out to be caused by a wrong service name that was not expanded anymore.

So by giving the name of the service that cannot be enabled and a more precise
reason, i think people will be able to diagnose their issue more easily.
 2014-04-22 09:13:57 +02:00
Hernandes B. de Sousa
780b5e0bbf Add missing info for the append option 
Both 'default' and 'choices' options were missing at the documentation.
 2014-04-16 01:22:12 -03:00
James Cammarata
0c96e2f33b Check to make sure the firewalld client is connected before proceeding 
Fixes #6911
 2014-04-15 15:03:52 -05:00
Jonathan Davila
a90aa46ed2 Added example demonstrating other functionality 2014-04-11 11:14:40 -04:00
James Tanner
0025273fca Fixes syntax error in cron module caused by #6870 2014-04-08 12:53:56 -04:00
Eric Lake
58dccfbc29 Adding bold to service doc to call up state and enabled. 2014-04-07 09:37:15 -05:00
MorrisA
ac72d44219 Modified Cron to add AIX Crontab support, changed according to suggestions 
from mpdehaan and redone entirely.
 2014-04-05 18:10:45 -07:00
Serge van Ginderachter
867702b26a lvg module bugfix on vg_options patch 
When no vg_options are passed to the module, 'vg_options' still exists
in the module.params dict with a value of None, so the default empty string in
the get method is never used. None cannot be "splitted", which backtraced.
 2014-04-04 15:32:35 +02:00
Michael DeHaan
3d8997d219 Name is not required, update docs. 2014-04-03 18:03:13 -04:00
Michael DeHaan
7258c15ce1 Merge pull request #6831 from aresch/patch-1 
Fix _parse_value always returning 0 when not true, false or None.
 2014-04-02 20:09:41 -04:00
Andrew Resch
32e5383bef Fix _parse_value always returning 0 when not true, false or None. 2014-04-02 15:59:05 -07:00
Joshua Lund
74962a0e35 Update cron module documentation. The 'name' parameter is required. 2014-04-02 16:41:09 -06:00
Michael DeHaan
5826e1354a Slightly revise wording. 2014-04-02 17:43:40 -04:00
Michael DeHaan
ff2177442b Merge branch 'authorized_key-manage_dir' of git://github.com/tyll/ansible into devel 2014-04-02 17:42:24 -04:00
Michael DeHaan
4917f4a48f Merge pull request #6810 from bob-smith/debconf-text 
debconf detail requirements and fix typos
 2014-04-02 17:25:22 -04:00
James Cammarata
57adad7097 Fix issue with sysctl parameter parsing introduced by 0e8c7b1 
Fixes #6806
 2014-04-02 15:26:02 -05:00
Michael DeHaan
05551cfe51 Merge pull request #6826 from bob-smith/debconf-parsing 
debconf correctly quote strings
 2014-04-02 16:14:17 -04:00
James Cammarata
09c998f104 Fixing some parsing issues in authorized_key module 
Also adds an integration test for authorized_key for future validation.

Fixes #6700
 2014-04-02 15:02:54 -05:00
John Barker
ed4717a978 debconf correctly quote strings 2014-04-02 20:43:12 +01:00
John Barker
e4a779d4dd debconf detail requirements and fix typos 2014-04-01 21:51:12 +01:00
Tim G
32d48d75e9 Bugfix, fix crontab commands on HP-UX 2014-04-01 21:09:08 +10:00
Michael Scherer
ba9f910ec9 fix typo in the capabilities module description 2014-03-30 22:33:24 +02:00
Adam Nielsen
b35086c7a3 More descriptive error message if init system is unknown 2014-03-30 11:46:13 +10:00
Ahti Kitsik
74fa705e20 Bugfix for ufw to support "logging" properly: 
It's a separate parameter so updated docs and set it as mutually exclusive param.
Also due to an array construction typo it was not working in any situation (ufw LOGLEVEL was passed to cmd instead of ufw logging LOGLEVEL).

Also fixed doc and parameters parsing typo ("choises" should be "choices")
 2014-03-29 11:06:51 +02:00
Michael DeHaan
85320532d4 Rename vgoptions to vg_options. 2014-03-28 12:53:36 -04:00
Michael DeHaan
07423c1714 Merge branch 'devel' of git://github.com/chamill/ansible into devel 
Conflicts:
	library/system/lvg
 2014-03-28 12:53:00 -04:00
Michael DeHaan
9fa0ec57fb Scrub choices=BOOLEANS from remaining core module references. Correct form in argument_spec is type='dict'. 2014-03-28 11:41:35 -04:00
Michael DeHaan
073d34b40e Merge pull request #6524 from tyll/update_rc_d_disable 
service module: Properly disable Debian services
 2014-03-28 11:10:46 -04:00
Michael DeHaan
d3d1c8ce9a Merge pull request #6630 from bigl0af/devel 
Modified library/system/user so that password change date is set on Sola...
 2014-03-28 10:57:59 -04:00
Michael DeHaan
1e747e00e5 Merge pull request #6296 from jdauphant/devel 
Add linux module parameters for the modprobe module
 2014-03-27 17:12:21 -04:00
Cristian Ciupitu
7a4270184a Micro-optimization: replace s.find(x)==0 with s.startswith(x) 
timeit shows a speedup of ~1.4x on Python 2.7.5 x86_64.
It also makes the code a bit shorter.
 2014-03-27 20:35:20 +02:00
Ahti Kitsik
c757b6624f Fixed ufw module doc tags, it's reset everywhere, not reseted. 2014-03-27 17:22:39 +02:00
Seth Woodworth
21b7c358ee adds missing ' to debconf examples 2014-03-23 18:52:08 -04:00
Pierre-Louis Bonicoli
9a140881be Fix ValueError when selection contains a colon 2014-03-23 03:35:10 +01:00
David Fox
01acd73e30 Modified library/system/user so that password change date is set on Solaris when updating password 2014-03-22 15:12:56 -04:00
Till Maas
35f9e62422 service module: Properly disable Debian services 
Services on Debian need to be disabled with 'disable' instead of 'remove'
to avoid them being enabled again when 'update-rc.d $service defaults' is run,
e.g. as part of a postinst script.
 2014-03-20 09:19:42 +01:00
Till Maas
a063987d0e authorized_key: Be more specific about manage_dir 
- Explain which properties are managed when manage_dir is True.
 2014-03-20 09:15:59 +01:00
Michael DeHaan
7f36630dd5 Add capabilities module. 2014-03-19 17:48:17 -04:00
nate@bx.psu.edu
2daee9ed20 Bugfix for xattrless files and the capabilities module. 2014-03-19 17:48:17 -04:00
nate@bx.psu.edu
c19e4a7d0b Create a capabilities module for managing Linux kernel capabilities(7) with setcap(8). 2014-03-19 17:48:17 -04:00
James Cammarata
9f9c077878 Merge branch 'issues/6341' of https://github.com/threatgrid/ansible into threatgrid-issues/6341 2014-03-18 10:46:39 -05:00
James Tanner
4028f55c04 Fixes #6519 Properly handle state=absent in sysctl module 2014-03-18 09:30:21 -04:00
Michael DeHaan
ba99056948 Version bump for alternatives module, changelog. 2014-03-16 16:54:57 -04:00
Gabe Mulley
4c132c11f7 add a module for update-alternatives 2014-03-16 16:54:57 -04:00
Michael DeHaan
29a3a1d516 Move facts to 'module_utils' so they can be referenced by other modules. Note unlike other module_utils/ dirs this keeps the original 
license -- so usage of facts code in modules will be limited to GPLv3 modules.
 2014-03-16 16:12:02 -04:00
Michael DeHaan
c914e9e462 Update setup module signature from merge commit. 2014-03-16 14:11:43 -04:00
Michael DeHaan
cac81b1ad9 Merge pull request #6339 from threatgrid/systemd-template-svc-fix 
systemd template services must not discard template part
 2014-03-16 12:40:44 -05:00
Michael DeHaan
790a38e25d Merge conflict. 2014-03-16 13:36:52 -04:00
Michael DeHaan
201297cbfe Merge pull request #6175 from AdmiralNemo/fix-filesystem 
filesystem: Ignore blkid cache
 2014-03-16 12:31:53 -05:00
Michael DeHaan
d4de77fd45 Merge pull request #6097 from mattjeffery/bug/modprobe_normalise_name 
Normalise the module name when comparing against the module names in /proc/modules
 2014-03-16 12:31:17 -05:00
Michael DeHaan
bf33be20e1 Merge pull request #6005 from pgehres/chkconfig 
Adding better failure output for chkconfig failures
 2014-03-16 12:27:46 -05:00
Cristian Ciupitu
a416dba3d1 hostname module: don't filter hostnamectl with awk 
There's no need to filter hostnamectl's output with awk because its man
page says:

    hostnamectl [OPTIONS...] {COMMAND}

       --static, --transient, --pretty
	   If status is used (or no explicit command is given) and one
	   of those fields is given, hostnamectl will print out just
           this selected hostname.

E.g. hostnamectl --static status => ansible.example.org
 2014-03-16 13:10:28 -04:00
Cristian Ciupitu
7f681c33a2 Micro-optimization: replace s.find(x)!=-1 with x in s 
timeit shows a speedup of ~3x on Python 2.7.5 x86_64.
It also makes the code a bit shorter.
 2014-03-16 13:10:28 -04:00
James Tanner
59fb47ae9a Fixes #6482 Check sysctl file path and catch read exceptions 2014-03-14 11:16:45 -04:00
Michael DeHaan
29138b1872 More shell updates 2014-03-12 17:31:00 -04:00
Richard C Isaacson
9e9f43272a setup module: Mark unsafe commands as use_unsafe_shell=True. 2014-03-12 11:13:20 -05:00
Ryan
3494d67f30 add module param to Network & sub-classes 
add module param to Network and sub-classes of Network, so that ansible 1.5.1 changes to LinuxNetwork apply to all Network classes.
 2014-03-12 09:37:12 -04:00
Michael DeHaan
65c4e388eb Revert "Fix issue#6430 by instantiating Network() with expected arguments" 
This reverts commit 2a723e908e.
 2014-03-12 09:23:13 -04:00
James Laska
cb63352aff Fix issue#6430 by instantiating Network() with expected arguments 2014-03-12 09:04:42 -04:00
Richard C Isaacson
7d83f64bae Fix docstring issue. 2014-03-11 16:23:18 -05:00
Richard Isaacson
19d77ada25 Merge pull request #6406 from risaacson/at_module2 
This fixes what was merged in 1.5.0.
 2014-03-11 15:27:51 -05:00
James Tanner
e63e909d6f Fix name in locale_gen docstring 2014-03-11 16:13:55 -04:00
James Tanner
4fae7da5e8 Fix snippet imports and version_added in ufw module 2014-03-11 16:07:08 -04:00
James Cammarata
6a81debb0a Merge pull request #5518 from pyykkis/ufw 
UFW module (another take)
 2014-03-11 15:03:33 -05:00
James Tanner
820c328ca8 Set version_added for locale_gen 2014-03-11 15:56:30 -04:00
James Tanner
3763008d15 Rename locale module to locale_gen 2014-03-11 15:55:26 -04:00
James Cammarata
52d14d0fee Merge pull request #5411 from AugustusKling/locale 
locale module
 2014-03-11 14:54:36 -05:00
Michael DeHaan
e767de4978 Merge pull request #6372 from mriedelumab/devel 
Returning 'NA' when no virtualization found
 2014-03-11 10:17:22 -05:00
James Tanner
fc33860e5d Force command action to not be executed by the shell unless specifically enabled 2014-03-10 16:13:30 -05:00
Matthew Riedel
d21a8f6ddc Returning 'NA' when no virtualization found 2014-03-10 11:58:04 -04:00
Richard C Isaacson
3188429105 Some cleanup. 2014-03-10 10:31:08 -05:00
Charles Duffy
532cda524f #6341: use shared function for parsing systemd status; check rc code 2014-03-10 01:05:48 -05:00
Charles Duffy
fd5083fe71 #6341: check systemd service status with show subcommand 2014-03-10 00:09:29 -05:00
Jarno Keskikangas
19fb807824 Recognize rule changes even if ufw is in disabled state. 
See http://askubuntu.com/questions/30781/see-configured-rules-even-when-inactive
for the details.
 2014-03-09 12:56:52 +02:00
Jarno Keskikangas
9abdacc725 Insert rule to a specific num. 2014-03-09 12:56:51 +02:00
Jarno Keskikangas
76eb4969fb Fix typo: 'reseted' -> 'reset'. 2014-03-09 12:56:51 +02:00
Jarno Keskikangas
b8f37df8e7 Add protocol options 'esp' and 'ah'. 2014-03-09 12:56:51 +02:00
Jarno Keskikangas
767cfcb0bd Add functionality and reduce complexity. 
* Separate 'state', 'policy' and 'rule' commands
* Support for 'logging' command
* Support for 'direction' and 'interface' attributes
* Reliable change notifications based on 'ufw status verbose' diff
* Update documentation
* Cleanup
 2014-03-09 12:56:51 +02:00
Aleksey Ovcharenko
4754bf47be New module [ufw]: this module handles Ubuntu UFW operations 
* Updated documentation related to IPv6 usage.

BugFixes:
* Solved the default_policy and state mutual exclusive status.
* Fixed changed status for IPv6 addresses.

Added @otnateos patch.
 2014-03-09 12:56:51 +02:00
Richard C Isaacson
ce98edfc87 Cleaning up pep8 alerts. 2014-03-07 23:06:19 -06:00
Richard C Isaacson
bdfb2de7fc Documentation cleanup. 2014-03-07 23:04:56 -06:00
Richard C Isaacson
a94e1e5477 Refactored a few things to be more inline with the Ansible way. Passing testing. 2014-03-07 23:04:07 -06:00
Charles Duffy
32620cab4d systemd template services must not discard template part 2014-03-07 18:53:15 -06:00
jctanner
b105942654 Merge pull request #5872 from tomdymond/add-ignoreerror-to-sysctl 
Add option to enable the sysctl -e option
 2014-03-05 12:58:05 -05:00
Julien DAUPHANT
7ce4eba507 Add version_added 1.6 for the params modprobe option 2014-03-05 16:45:20 +01:00
Julien DAUPHANT
c95b358694 Add linux module parameters for the modprobe module 2014-03-05 16:42:52 +01:00
anatoly techtonik
63f0a644ac setup: Fix KeyError: 'ipv4_secondaries' (issue #6274) 2014-03-04 20:00:18 +02:00
James Tanner
87f17e7e94 Fix debconf docstring indentation 2014-03-03 13:48:44 -05:00
James Tanner
b07e5742b3 Merge branch 'debconf' of git://github.com/bcoca/ansible into bcoca-debconf 2014-03-03 13:46:11 -05:00
Brian Coca
a4f6a12181 didnt make 1.5 ... lets see 2014-03-01 22:28:51 -05:00
Brian Coca
a7444f5178 added better gentoo/funtoo support 2014-03-01 21:56:02 -05:00
Michael DeHaan
d71921492b Merge pull request #6223 from lvh/patch-2 
Support ssh-ed25519 keys
 2014-02-28 12:59:05 -05:00
Laurens Van Houtven
c50b772e61 Support ssh-ed25519 keys 
The newest version of OpenSSH supports a new, wonderful key type. authorized_key incorrectly discards pubkeys of this type as busted because it doesn't recognize type signature.
 2014-02-28 18:46:54 +01:00
James Cammarata
08fca488f3 Use the no-user-groups option (-N) for useradd in the user module 
If no group was specified, but a group by the same name as the user
exists, an error was raised in the situation where USERGROUPS_ENAB is
enabled in /etc/login.defs (which is the case for almost every major
linux distro). In this case, the user will be put in group 100 (which
is usually the "users" group on those same distros). This is currently
only done in the base class, as the issue may not exist on other
platforms like AIX or the BSDs.

Fixes #6210
 2014-02-28 11:46:27 -06:00
Dustin C. Hatch
d2dc260e98 filesystem: Ignore blkid cache 
Sometimes, `blkid` will incorrectly return no information about a block
device, even if it exists and has a valid filesystem. This causes the
*filesystem* module to fail if *force=no*. Instructing `blkid` to use
`/dev/null` as a cache file will force it to rescan the block device on
each run, making results more consistent.

Signed-off-by: Dustin C. Hatch <admiralnemo@gmail.com>
 2014-02-25 20:16:01 -06:00
Chris Church
09b076e39c Fix setup module to gather facts from PowerPC Macs. 2014-02-25 18:27:36 -05:00
James Cammarata
8aec47af89 Merge branch 'usermod_fix' of https://github.com/tknguyen79/ansible into tknguyen79-usermod_fix 
Conflicts:
	library/system/user
 2014-02-24 23:38:51 -06:00
Stefan J. Betz
b335eb2412 Require force for LVM shrink and remove operations in lvol. Fixes #5774 
Conflicts:
	library/system/lvol
 2014-02-24 18:52:35 -06:00
Richard C Isaacson
eb2762bc5b If you try to resize a lvol to the current size return a changed=False and don't fail. 
This addresses GH-5165 and adds the ability to check if a lvol exists.

The tests for this don't fit nicely into the current integration tests so they are below.

```
---

- name: remove any existing lv=one of vg=main
  lvol: lv=one vg=main state=absent

- name: remove any existing lv=two of vg=main
  lvol: lv=two vg=main state=absent

- name: check to see if lv=one of vg=main exists
  lvol: lv=one vg=main state=present
  ignore_errors: true
  register: lvol_result0

- name: Assert that we will get a "No size given."
  assert:
    that:
      - "'No size given.' in lvol_result0.msg"

- name: create lv=one of vg=main sized 30g
  lvol: lv=one size=30g vg=main state=present
  register: lvol_result1

- name: Assert that we made changes."
  assert:
    that:
      - "lvol_result1.changed == True"

- name: check to see if lv=one of vg=main exists
  lvol: lv=one vg=main state=present
  register: lvol_result2

- name: Assert that we did not make changes."
  assert:
    that:
      - "lvol_result2.changed == False"

- name: remove lv=one of vg=main
  lvol: lv=one vg=main state=absent

- name: create lv=two of vg=main sized 30G
  lvol: lv=two size=30G vg=main state=present
  register: lvol_result3

- name: Assert that we made changes."
  assert:
    that:
      - "lvol_result3.changed == True"

- name: reduce lv=two of vg=main to 15G
  lvol: lv=two size=15G vg=main state=present
  register: lvol_result4

- name: Assert that we made changes."
  assert:
    that:
      - "lvol_result4.changed == True"

- name: increase lv=two of vg=main to 30G
  lvol: lv=two size=30G vg=main state=present
  register: lvol_result5

- name: Assert that we made changes."
  assert:
    that:
      - "lvol_result5.changed == True"

- name: create lv=two of vg=main sized 30G when already exists at 30G
  lvol: lv=two size=30g vg=main state=present
  register: lvol_result6

- name: Assert that we did not make changes."
  assert:
    that:
      - "lvol_result6.changed == False"

- name: remove lv=two of vg=main
  lvol: lv=two vg=main state=absent
```
 2014-02-24 16:56:08 -06:00
Matt Jeffery
6cfa724472 Normalise the module name when comparing against the module names in /proc/modules. 2014-02-20 16:54:33 +00:00
C. Morgan Hamill
c29f2fb888 Add 'vgoptions' parameter to lvg module. 
Allows specifying extra flags to pass to `vgcreate`.
 2014-02-18 15:20:12 -05:00
Nils Pascal Illenseer
7f40790fc1 Fix zfs create command for properties with spaces 
If a property value contains one or more spaces, the zfs command will fail.
With value quoted this behavior is fixed.
 2014-02-18 11:30:17 +01:00
Richard C Isaacson
cb8c462880 Merge remote-tracking branch 'berendt/fixing_permissions' into pull_4703 2014-02-17 11:46:23 -06:00
Peter Gehres
a9bf607013 Adding better failure output for chkconfig failures rather than 
just saying that the service name is unknown
 2014-02-13 23:05:00 -08:00
Sean Chittenden
c892f51002 Fix broken behavior when removing all auxiliary groups from a user 
(e.g. 'groups=' in the user module).
 2014-02-10 13:08:53 -08:00
Brian Coca
01a1482f1a hopefully last batch of fixes 
- removed previous 'typification' of input as it needs it is typed by
  module as strings and needs to be output as strings, making it
  useless.
- now checks for vtype and value against None when question is specified
- simplified set_selections as vtype and value should have a string
  value going in.
- added example of querying questions for a package
- added module requirement of question,vtype and value being required
  together.
 2014-02-09 20:47:01 -05:00
Brian Coca
4b0c2d839e made changes as per feedback: 
- field names are more consistent with debconf
- values are now 'booleanized' or accepted as list/set objects when
  pertinent
- updated docs to reflect all of the above and debconf cli tools
  required
 2014-02-09 17:46:18 -05:00
Brian Coca
c11fbd54e1 fixed main() issue created in prev fix, now values are empty string if they were None 
Signed-off-by: Brian Coca <briancoca+ansible@gmail.com>
 2014-02-06 11:59:37 -05:00
Brian Coca
8a6a2aba75 changes names to name in example 2014-02-05 18:28:17 -05:00
Brian Coca
ddb191f208 fixes as per feedback 2014-02-05 18:08:01 -05:00
Tom Dymond
c9e7541e60 Reworked PR to avoid repeating the command 2014-02-05 15:35:24 +00:00
jctanner
4901af0ef6 Merge pull request #5554 from ttarabul/devel 
Use /etc/rc.conf.local for sevice configuration on FreeBSD
 2014-02-04 10:59:19 -08:00
Tom Dymond
16edbd3181 Add option to enable the sysctl -e option 2014-02-04 18:19:28 +00:00
kustodian
405dee2398 Updated authorized_key module documentation regarding manage_dir 
Added a warning in the documentation about manage_dir when selecting an alternate directory for authorized_keys
 2014-01-29 23:39:43 +01:00
Aaron Lindsay
931f8e4c5b Add move_home option to user module 2014-01-29 14:10:26 -05:00
Richard C Isaacson
cc20868bfb Tested implementation adding action option for (add, delete, unique). 2014-01-28 20:29:41 -05:00
Richard C Isaacson
855154226e Rough cut implementation based on @resmo's comments. 2014-01-28 20:29:41 -05:00
Richard C Isaacson
4e4ba1f695 Rough cut implementation based on @resmo's comments. 2014-01-28 20:29:41 -05:00
Richard C Isaacson
c677056dfe Change to dynamically pick up the command from the PATH. 2014-01-28 20:29:41 -05:00
Richard C Isaacson
9dc98d9b66 Formating and syntax fixes that were pointed out during code review. 2014-01-28 20:29:41 -05:00
Richard C Isaacson
eb9831cf62 Added user option. 2014-01-28 20:29:41 -05:00
Richard C Isaacson
7e1361d0e0 First commit of the at module being very basic. 2014-01-28 20:29:41 -05:00
Brian Coca
fee79e6501 be permissive with BSD with service enabled upper/lower/mixed cases 
Signed-off-by: Brian Coca <briancoca+ansible@gmail.com>
 2014-01-28 14:49:57 -05:00
Jakub Jirutka
1dc5ee00b6 sysctl: parse bool value as 0/1 and refactor a little bit 2014-01-27 20:26:11 +01:00
Thoai Nguyen
220b0f87d9 reorder usermod options 2014-01-22 15:27:00 -05:00
jctanner
f14f6ebd44 Merge pull request #5676 from simonz05/bugfix-sysctl-multivalue2 
Correctly compare values returned by 'sysctl -e -n'
 2014-01-20 06:11:29 -08:00
Augustus Kling
de19375d1b Fix error reporting in case locale-gen fails on non-Ubuntu systems. 2014-01-20 00:11:01 +01:00
Augustus Kling
eabc9cd775 Merge remote-tracking branch 'upstream/devel' into locale 2014-01-19 23:51:27 +01:00
Augustus Kling
00ee613446 Handle install/uninstall of locales for Ubuntu, too. 2014-01-19 23:35:10 +01:00
Simon Zimmermann
be69ca4ead correctly compare the values, better func name 2014-01-18 11:04:15 +01:00
Simon Zimmermann
45728d739c Correctly compare values as returned from 'sysctl -e -n' 2014-01-18 10:50:24 +01:00
Simon Zimmermann
624c563e43 fix str format error due to missing '%' in sysctl module 2014-01-17 22:31:12 +01:00
James Tanner
f3b86abc30 Fixes #5661 Handle null values for sysctl parameters 2014-01-17 11:30:07 -05:00
Michael DeHaan
49b0db9819 Merge pull request #5658 from rishid/devel 
Add support for Scientific Linux for hostname module
 2014-01-16 17:55:24 -08:00
jctanner
921ae2134b Merge pull request #5655 from scottgilbert/devel 
Allow keystring passed to authorized_key to contain blank lines and comments
 2014-01-16 14:22:57 -08:00
James Tanner
03aba39b59 Fixes #5656 quote values with multiple columns before calling 
the sysctl command. Calling sysctl should also not be true by default
 2014-01-16 16:30:13 -05:00
rishid
4ef5b60f3d Add support for Scientific Linux for hostname module 
hostname module was lacking support for Scientific Linux, this commit adds it.
 2014-01-16 16:08:51 -05:00
Scott Gilbert
df72690e6c Allow keystring passed to authorized_key to contain blank lines and comments 2014-01-16 12:14:37 -06:00
James Tanner
a9c5aa8f78 Remove unused variable from authorized_key 2014-01-16 11:46:06 -05:00
James Tanner
30f7b2d298 Fixes #5486 Keep authorized key options in tact and ordered 2014-01-15 17:10:10 -05:00