Artem Zinenko
2b63ae61f2
minor updates + tests to win_firewall_rule as per jborean93 review ( #29148 )
...
* Added warning for 'force' option
* Changed 'profiles' type to list
* Changed 'interfacetypes' type to list
* Added deprecation warning and fixed doc
* updated force parameter
2017-10-10 16:23:08 +10:00
Toshio Kuratomi
4cad720b22
Remove wildcard imports from cloudstack modules.
...
Also add boilerplate.
2017-10-09 21:41:02 -07:00
Toshio Kuratomi
2f8831c787
Fix get_exception and wildcard imports for nxos modules
2017-10-09 21:41:02 -07:00
Toshio Kuratomi
75eed6a51a
Port arg specs from type='str' to type='path'
2017-10-09 21:15:56 -07:00
Brian Coca
dc69af50dc
clarified inventory_dir changes for 2.4 ( #31484 )
...
* clarified inventory_dir changes for 2.4
added example on how to restore (mostly) old behaviour for add_hosts
fixes #30901
2017-10-09 20:56:32 -07:00
Brian Coca
74107ff7cc
better message for unsupported include/imports
...
adhoc cannot currently execute these actions
2017-10-09 20:49:11 -07:00
François Scala
aade5234a9
Fix urlparse import for Python3 ( #31240 )
...
* Fix urlparse import for Python3 in
* contrib/inventory/consul_io.py
* contrib/inventory/rudder.py
* contrib/inventory/windows_azure.py
* lib/ansible/module_utils/known_hosts.py
* lib/ansible/modules/cloud/centurylink/clc_firewall_policy.py
* lib/ansible/modules/cloud/docker/_docker.py
* lib/ansible/modules/cloud/ovirt/ovirt_disk.py
* lib/ansible/plugins/action/ce_template.py
2017-10-09 20:18:09 -07:00
Jordan Borean
82fa922491
win_become: Added support to become a service user ( #30407 )
...
* win_become: Added support to become a service user
* fixes for linting
* changes to get local and network service working
* fixed linting issues again
* pleasing pepe
2017-10-09 17:58:29 -07:00
Brian Coca
4e22677e7d
revert namespaced facts changes to package/service
...
fixes #31485
2017-10-09 16:31:58 -07:00
Prasad Katti
0c64bbcd6f
Document return values for aws_s3 ( #31158 )
...
* Document return values for aws_s3
2017-10-10 09:26:42 +10:00
Bill Wang
91a36faddb
New module: Add module for Amazon Systems Manager Parameter Store (cloud/amazon/ssm_parameter_store) ( #23460 )
...
- new module: ssm_parameter_store
- new lookup: ssm
* lookup module ssm - adjust error message
* Pacify pylint erroring on botocore not found
* adjust to version 2.5
2017-10-10 09:04:40 +10:00
Jordan Borean
f2bc89a880
win_copy: added decrypt option ( #31291 )
2017-10-10 08:21:25 +10:00
Rob
1353aae456
[cloud] Fix #31271 - cast all tag values as strings ( #31272 )
...
* Fix #31271 - cast all tag values as strings
* Replace `str` with `to_native`
2017-10-09 17:10:54 -04:00
Ryan Fitzpatrick
2ba5998c94
[cloud] Ensure absence of public_dns_name doesn't halt ec2 module ( #31476 )
2017-10-09 17:04:25 -04:00
Tim Rupp
75c5d0fedc
Adds the bigip_remote_syslog module
...
This patchs add a remote-syslog module that can be used by people
to manage their (basic, not HSL) syslog configuration
2017-10-09 13:21:16 -07:00
Vyronas Tsingaras
5bf9f271b3
win_copy: Add missing check_mode fix ( #31469 )
...
* Add missing check_mode fix
* Refactor conditional to use the one embedded in Remove-Item
2017-10-09 20:37:33 +02:00
Pilou
1c9bffe248
pip module: fix TypeError ( #31395 )
...
* pip: add test: an error occurs when pip not found
* pip: fix TypeError exception when pip executable isn't found
2017-10-09 10:01:21 -07:00
Toshio Kuratomi
5e9384300d
Add boilerplate and remove wildcard imports for openstack modules ( #31461 )
...
* Add boilerplate and remove wildcard imports for openstack modules
* Remove openstack files that are now pep8 compliant from the legacy list
2017-10-09 09:56:26 -07:00
James Cammarata
e609618274
Template role_name when statically including via include_role ( #31463 )
...
Also trims out code which was incorrectly setting is_static=True for
include_role.
Fixes #30700
2017-10-09 11:39:29 -05:00
Brian Coca
7d49b27218
added toggle to control vars plugin behviour
...
this should allow user to control how they want the playbook dirs inspected
for additional vars, default now reverts to 2.3 behaviour (top).
corrected paths order
minor doc reword
2017-10-09 12:31:15 -04:00
Brian Coca
adcd185273
version is string and should be 2.9
2017-10-09 12:15:56 -04:00
Sebastien Boyron
6b34dc788a
[feat] module apt: add warning on deprecated states
2017-10-09 12:14:36 -04:00
Ryan Brown
958ad7726a
Properly handle user selection of None
as vars_files ( #31313 )
...
* Properly handle user selection of `None` as vars_files
In a playbook, if a user has a playbook like:
```
- hosts: localhost
connection: local
vars_files:
tasks:
- ....
```
Then `vars_files` will be none, and cause a `TypeError` in vars-manager when it
tries to iterate over them. To avoid this, I changed the getter to either send
back the vars files from the user, or an empty list when the user passed
`None`.
* Only replace None with an empty list, not all falsey values
* Catch error when vars_files isn't iterable
* Move whole `for` loop into try/except and catch TypeError
* Line length
2017-10-09 11:27:50 -04:00
Sofiane Medjkoune
ef72eda172
Adding doc for the description argument of lxd_profile module
2017-10-09 11:11:58 -04:00
Toshio Kuratomi
9c81257ce3
Remove wildcard imports from amazon modules ( #31451 )
...
* Remove wildcard imports from amazon modules
* Remove files from legacy pep8 that now pass
2017-10-09 07:38:41 -07:00
Matthew Martin
63e59a9825
maven_artifact: Add classifier to default dest ( #24518 )
2017-10-09 07:56:33 -06:00
Pilou
870974e0be
ec2_vpc_route_table: fix broken import ( #31459 )
2017-10-09 20:20:31 +10:00
Martin Krizek
13631ececa
yum: check if env groups are installed ( #31182 )
2017-10-09 06:01:34 -04:00
Andreas Olsson
d025aca66f
Add optional port parameter to nsupdate module ( #31446 )
...
An example of when it's useful to be able to specify a custom port
number is when one is using an (ssh) tunnel to update a hidden master.
2017-10-09 05:51:17 -04:00
Pilou
0be8ac6797
ec2_vpc_igw: fix broken import ( #31458 )
2017-10-09 15:36:12 +10:00
Dag Wieers
ae5d8e5ebb
modprobe: PEP8 compliancy and doc fixes ( #31255 )
...
This PR includes:
- PEP8 compliancy fixes
- Documentation fixes
- Make module a bit more consistent with existing practices
2017-10-08 09:21:58 -04:00
Toshio Kuratomi
4804e99b44
Change ping docs to refer to win_ping ( #31444 )
2017-10-08 08:33:51 +01:00
Brian Coca
a9942353fe
revert ocalhost getting 'all' vars ( #31425 )
...
back to previous implicit localhost behaviour
fixes #31420
2017-10-06 19:11:00 -04:00
Brian Coca
e4c61ea9a1
fix 'return false' from parse
...
this was abandoned early on the manger side but seems like we left behind on plugin side.
more flexible extensions with yaml plugin
validate data correctly for yaml/constructed
fixed issue with only adding one child to keyed, the group only got the host that forced it's creation
fixes #31382
fixes #31365
2017-10-06 13:25:06 -04:00
Brian Coca
f2ade09dce
use configured ansible_shell_executable
...
refine args/shell/executable hanlding
2017-10-06 08:56:21 -04:00
rahushen
48f4643a66
nxos_snmp_* fixes : Fixes #30997 , #30999 ( #31000 )
...
* add codeblock to handle 5K platform for nxos_snmp_host
* fix get_snmp_traps for 5K platform
* Make shippable happy
2017-10-06 18:21:59 +05:30
rahushen
0218fdcd80
Fixes #30846 ( #30862 )
2017-10-06 17:10:03 +05:30
Eike Frost
9a1b495894
Fix idempotency if zabbix_host when visible_hostname is not set ( #31388 )
2017-10-06 03:28:17 -04:00
Jordan Borean
c4b51009f0
win_copy: allow src to have invalid windows chars ( #31392 )
...
* win_copy: allow src to have invalid windows chars
* create file with colon instead of avoid checkout errors
2017-10-06 15:23:37 +10:00
Prasad Katti
14b9a6b350
Add example showing how to add host to multiple groups ( #31152 )
...
* Add example of how to add host to multiple groups
* use 'name' task keyword for comments
2017-10-06 01:02:53 -04:00
Kaz Cheng
044dd699c2
Addition of TCP protocol to ELB target group ( #31228 )
...
* Addition of TCP protocol to ELB target group as target groups support HTTP/S and TCP now
* Fixup stickiness type so that it checks if the current_tg has the stickiness_type key in the dict, as TCP ones do not
2017-10-06 00:27:30 -04:00
Jean-Frédéric
d332367018
Allow an Elastic IP to be re-associated in ec2_eip ( #27389 )
...
Trying to associate an already-associated ElasticIP was failing.
This is however supported by the `boto` method that is used
under the hood, `associate_address`:
To quote `boto` documentation:
```
This option to allow an Elastic IP address that is already
associated with another networkinterface or instance to be
re-associated with the specified instance or interface.
```
This defaults to False, both per backwards-compatibility
and to mirror the boto default value.
Fixes #27385
2017-10-06 09:51:36 +10:00
Brian Coca
a6e27a903a
better chown errors
2017-10-05 18:40:41 -04:00
Strahinja Kustudic
7417282d37
Do not run systemctl daemon-reload in check mode
2017-10-05 18:40:02 -04:00
Michael Vermaes
fad3a4dc83
Fix typo in vault decrypt error message ( #31335 )
2017-10-05 18:09:22 -04:00
Dusan Matejka
336723d293
Allow zabbix_host to change proxy to no proxy, fixes #24735 ( #29123 )
2017-10-05 17:51:37 -04:00
Matt Davis
13e89b17cc
remove explicit provider reg from azure_rm ( #31369 )
...
* now that it's handled automatically as of msrest > 0.4.9
2017-10-05 12:48:13 -07:00
Sloane Hertel
efe3c94b1b
[cloud] ec2.py: warn that removing a public ipv4 address is not permitted - fixes #30679 ( #30952 )
...
* Add a warning to ec2.py if assign_public_ip is different from the matching instance(s) since it isn't a modifiable attribute.
* remove comments
2017-10-05 15:32:52 -04:00
Bradford Dabbs
f219d6b96d
[cloud] EC2_ASG Set desired capacity to min_size if no instances exist ( #30987 )
...
* Set desired capacity to min_size if no instances exist
* Improve readability of if/then clause
* Only update null desired_capacity to min_size on initial create
Any future updates to the ASG will be able to reference the existing
capacity.
2017-10-05 14:56:46 -04:00
John R Barker
e859d0da9c
data should be redacted in docker_secret ( #31366 )
2017-10-05 14:07:23 -04:00