Commit graph

411 commits

Author SHA1 Message Date
Dimos Alevizos
8c73aa13e4 Minor changes to simplify code 2013-12-08 09:02:50 +02:00
David Hummel
cc3678730c Fix issue #5214: hostname persistence on RedHat/CentOS 2013-12-07 21:10:42 -05:00
Dimos Alevizos
de4e4c54b9 Add get_dmi_facts in setup for FreeBSD systems using dmidecode 2013-12-07 17:16:20 +02:00
jeromew
1916e8ec90 user module: force= and remove= should not be mutually exclusive 2013-12-05 17:07:24 -05:00
jctanner
5e336d7caf Merge pull request #5075 from gservat/patch-1
Added support for parsing in the SLES patch level correctly
2013-12-05 13:34:57 -08:00
gservat
db2f41bdcb This change is meant to replace distribution_release, not version! 2013-12-06 07:53:39 +11:00
gservat
83f35a63dd Oops... fixed an error 2013-12-06 07:49:03 +11:00
Alfons Zitterbacke
5390ee9763 added AIX network facts 2013-12-05 10:13:55 +01:00
Alfons Zitterbacke
cc783b3e1b added AIX network facts 2013-12-05 10:06:44 +01:00
James Tanner
cbfeb0a2ea Fixes #5169 Evaluate check_mode in the user module SunOS class 2013-12-05 00:44:55 -05:00
Jasper N. Brouwer
0e11e4c86f Fixed false positive on initctl as enable_cmd
Also on update-rc.d
In service module
2013-12-04 21:49:00 +01:00
jctanner
2670529671 Merge pull request #5090 from dragon3/hostname_support_amazon_linux
hostname module: add support for Amazon Linux
2013-12-03 12:34:55 -08:00
jctanner
872a1ee39b Merge pull request #5107 from maetthu/devel
authorized_key module: rewrite options to dict parser, fixes #5032
2013-12-02 14:02:43 -08:00
jctanner
ef92b2cb12 Merge pull request #5063 from samh/devel
Fixed hostname module for RHEL6 Workstation
2013-12-02 13:38:32 -08:00
James Tanner
ad837709bd Addresses #5023 Fix import comments 2013-12-02 15:13:49 -05:00
James Tanner
6000d636b3 Fixes #5023 Convert all modules to use new snippet import pattern 2013-12-02 15:11:23 -05:00
James Tanner
c050872458 Fixes #4796 handle unicodedecode errors from dmidecode output 2013-12-02 11:56:38 -05:00
Michael DeHaan
5efcf265d1 Merge pull request #5046 from JensRantil/improve-mount-doc
mention that the mount module will remove mount directories
2013-12-01 14:27:40 -08:00
Matthias Blaser
9d442243ab rewrite options to dict parser, fixes #5032 2013-11-30 09:03:35 +01:00
Michael DeHaan
36effd237c There's a cleaner way to do this, commit to module formatter pending.
Revert "No longer need to reference 'version_added' in docs for these, as this was quite a while ago."

This reverts commit ff0a41d446.
2013-11-27 21:23:03 -05:00
Michael DeHaan
ff0a41d446 No longer need to reference 'version_added' in docs for these, as this was quite a while ago. 2013-11-27 21:19:32 -05:00
dragon3
d39e6fda92 hostname module: add support for Amazon Linux 2013-11-28 09:31:25 +09:00
gservat
13da2c3ac9 Added support for parsing in the SLES patch level correctly
On SLES, the setup module was returning the architecture as the distribution version (i.e. platform.dist() didn't quite return the right thing). This change checks for /etc/SuSE-release and grabs the second column in the third line as distribution_version.
2013-11-27 23:44:34 +11:00
Sam Hartsfield
ae7735b45d Fixed hostname module for RHEL6 Workstation 2013-11-26 11:36:10 -05:00
James Tanner
7be13faae8 Fix comment yaml escaping in authorized_key module 2013-11-26 08:54:19 -05:00
James Tanner
4ba51eef6f Save comment hashes in sshkeys 2013-11-25 23:46:48 -05:00
James Tanner
16b22d0d64 Cleanup debug statements 2013-11-25 22:16:04 -05:00
James Tanner
b938554311 Fixes #5032 escape and safely split key options in authorized_keys module 2013-11-25 22:13:42 -05:00
James Tanner
d187066339 Fixes #5010 Add user to all defined supplementary groups 2013-11-25 14:56:46 -05:00
Jens Rantil
883f37e404 Improved documentation of mount module
Mentioning the fact that mount point directories are created and
removed.
2013-11-25 13:58:00 +01:00
James Tanner
32986c4d64 Fixes #5021 safely split hostkeys with quotes 2013-11-22 16:36:31 -05:00
James Tanner
1d24bcc916 Fix pep8 error in hostname module 2013-11-19 16:39:48 -05:00
Michael DeHaan
5e0c6e0af3 Merge pull request #4868 from hnakamur/rhel5_hostname_fix
hostname module fix for RHEL5
2013-11-19 11:38:29 -08:00
Michael DeHaan
b29669dccd Remove the 'host' module for now because the alias handling involves a bit too much automagic. Proposal is to come up with a spec
of how it should work and accept to spec, using the existing patch (cherry-picked) as a baseline.
2013-11-19 14:12:45 -05:00
Michael DeHaan
f7c3975f21 Add version_added to all modules missing version_added information, the docs formatter will now
raise errors when omitted, updated changelog with new modules.
2013-11-18 18:55:49 -05:00
Michael DeHaan
2726b13245 Changelog updates and a few module renames. vpc -> ec2_vpc, githooks -> github_hooks, blacklist -> kernel_blacklist. These are all new in 1.4 so safe to change. 2013-11-18 18:28:21 -05:00
Sergey Sudakovich
4d0f374dbf compatible with python 2.4 2013-11-18 11:33:04 -08:00
jctanner
dc5b952854 Merge pull request #4910 from matze/add-system-blacklist-module
Add system module to blacklist kernel modules
2013-11-15 11:06:05 -08:00
Rene Moser
0c70e898cc host: fix bug, alias was not removed 2013-11-15 14:04:41 +01:00
Rene Moser
6da2d55007 host: removed unused self_has_aliases 2013-11-15 14:04:40 +01:00
Rene Moser
a61f46f4f0 host: skip lines beginning with new line 2013-11-15 14:04:40 +01:00
Rene Moser
ca5e5cfebc host: fix changed is not available on fail 2013-11-15 14:04:40 +01:00
Matthias Vogelgesang
e5ef5e29ec Add system module to blacklist kernel module 2013-11-15 10:34:55 +01:00
nextus
17cbbcdd30 Don't allow cron module to delete cron_file without name parameter assignment 2013-11-14 13:24:14 +04:00
nextus
a43aaaecd0 Fix: absent state removing whole cron.d file instead of specific job 2013-11-13 23:58:37 +04:00
James Tanner
7eadf78009 Merge pull request #4282 from cristobalrosa/ansible
Add a fact for checking if interface is in promiscuous mode.
2013-11-13 10:33:57 -05:00
Sergey Sudakovich
24ea5949bb fix when the system does not have lsb_release script, but has /etc/lsb_release file 2013-11-12 15:25:39 -08:00
James Tanner
6008ea40ee Add more error detail to the service module for FreeBSD 2013-11-12 00:02:30 -05:00
jctanner
ec55268738 Merge pull request #4304 from ferringb/fixes/cron-permissions
Enforce umask for cron module, so cron_file generated files are 0644.
2013-11-11 14:23:39 -08:00
Hiroaki Nakamura
63a552b2d3 Apply the same change as https://github.com/hnakamur/ansible-playbooks/pull/2 2013-11-10 08:28:33 +09:00
James Tanner
fa62ee46bf Set the correct version added for the hostname module 2013-11-07 22:01:02 -05:00
jctanner
01a054d2be Merge pull request #3940 from hnakamur/hostname_module
Add a hostname module, which sets system's hostname.
2013-11-07 15:11:06 -08:00
James Tanner
ce29c158a9 Address #4573 Check interface keys and return gracefully on solaris zones 2013-11-06 18:11:22 -05:00
Jim Richardson
bbfe11fc1e return True/False from remove_job_file()
revised fix for https://github.com/ansible/ansible/issues/4795
2013-11-04 14:14:53 -08:00
Jim Richardson
bcc08564e7 fix for https://github.com/ansible/ansible/issues/4795
Incorrect changed result in cron module.
Report changed=False if no cron is removed:wq
2013-11-03 17:43:51 -08:00
Hiroaki Nakamura
abed2c47fa Fix for RHEL6. 2013-11-01 23:32:14 +09:00
Michael DeHaan
3705f41992 Merge pull request #4754 from mscherer/fix_4648
Fix 4648, cron module is not working on solaris
2013-10-31 14:49:25 -07:00
Michael DeHaan
d34a26e307 Undo an inadvertant revert from template changes so we still allow pythonic imports in module land. 2013-10-31 16:53:05 -04:00
Michael Scherer
9e7b02aaee make cron module work on solaris
Cron on solaris do not take the same
set of option than vixie cron on linux, and
among the biggest difference, root cannot set
the crontab of a user directly from a file. Thus the
use of su to run the crontab command. Fix issue #4648
2013-10-31 19:58:26 +01:00
Michael Scherer
506ce6a809 remove unused function 2013-10-31 19:58:26 +01:00
Scott Dunlop
dbc1e20462 add "zle" as a supported ZFS compression type
ZFS supports "zle" compression, which compresses runs of null bytes efficiently.
2013-10-31 10:48:41 -07:00
James Tanner
d154bf8781 Revert templating enhancements from 73dbab70 e6c28658 d409352c 9858b1f2 4587528b 9b1fe455 214b0b05 8d3db803 7f9504d1 5031104c 35cb9dc2 2bd8cb57 1e85c754 2013-10-30 10:50:16 -04:00
jctanner
a1fcaf5c61 Merge pull request #4715 from mscherer/fix_4702
Fix #4702, make setup work on windows
2013-10-29 06:03:49 -07:00
Michael Scherer
3f0b3a71ca Fix #4702, make setup work on windows 2013-10-28 23:41:18 +01:00
James Cammarata
0e9184eefd Fixing authorized_keys module to make the key part detection better
Fixes #4677
Fixes #4657
Fixes #4599
2013-10-28 13:52:45 -05:00
Christian Berendt
2848cf34fc changing permissions of modules to 0644 2013-10-28 14:50:35 +01:00
Michael DeHaan
3badedc983 Merge pull request #4424 from localvoid/firewalld-rich_rules
Add support for Rich Rules in firewalld module
2013-10-27 08:55:22 -07:00
Michael DeHaan
d0904ded84 Merge pull request #4600 from earchibald/devel
Added ['date_time']['tz_offset'] using %z to get the time offset rather ...
2013-10-27 08:30:28 -07:00
Michael DeHaan
b725361bce Merge pull request #4560 from tronner/issue4461
Fix illegal set operation in FreeBSD section of user module.
2013-10-26 11:31:20 -07:00
Michael DeHaan
9858b1f2f3 Enable imports to work on a snippet based system, allowing for instance a library of common EC2 functions
to be reused between modules.  See library/system/service and library/system/ping for initial examples.  Can
work the old way to just import 'basic', or can import the new way to import multiple pieces of code from
module_utils/.
2013-10-26 11:09:30 -04:00
James Tanner
40574c1938 Fixes #4448 reloaded services should be started if not running 2013-10-25 15:30:02 -04:00
James Cammarata
aa0577c211 Merge branch 'fix_autorized_keys' of https://github.com/mscherer/ansible into mscherer-fix_autorized_keys 2013-10-24 20:13:38 -05:00
James Cammarata
b58b287fce Fixing up authorized_keys to accept comments with spaces 2013-10-24 20:12:56 -05:00
Michael Scherer
951a91723d make sure that options are quoted, as people can add a shell
script there with a comma that would produce invalid configuration
upon being wrote again
2013-10-24 23:51:55 +02:00
Michael Scherer
7672e9fef8 sort the option_key to have a constant predictable line 2013-10-24 23:47:34 +02:00
Michael Scherer
264945a1f7 adding a single comma at the end of the options list confuse the module
it start to duplicate line, because this create
a empty option in the list, and so the module add a new line along the previous
one. See

>>> ' a,b, '.strip().split(',')
['a', 'b', '']
2013-10-24 23:46:49 +02:00
Scott Sturdivant
4d24e2e29f If the output of rcvar isn't a key=value pair, ignore it. 2013-10-21 14:20:54 -06:00
Eugene Archibald
30eb5c7342 Fixed (broken) tab to (correct) spaces for indentation 2013-10-19 17:04:37 -07:00
Michael DeHaan
21d4400c96 Misc pep8 fixes 2013-10-19 13:03:15 -04:00
Michael DeHaan
75e0a1c6de Merge pull request #4592 from mscherer/fix_4586
setup module, replace ':' by '_' in interface name, fix #4586
2013-10-19 09:07:56 -07:00
Eugene Archibald
145c0b8be1 Added ['date_time']['tz_offset'] using %z to get the time offset rather than time zone. 2013-10-18 20:32:35 -07:00
Michael Scherer
d5c290b513 fix logic in module host to add aliases even if none exist already, fix #4563
self._has_aliases is used to know if a alias already exist, but
the test we want is to know if we need to add a new alias, which
is stored in self.aliases
2013-10-19 01:51:42 +02:00
Michael Scherer
fc211ac1a0 setup module, replace ':' by '_' in interface name, fix #4586 2013-10-19 00:24:07 +02:00
James Tanner
4f674ec522 Fixes #4554 Enumerate user homedir if not passed as an argument 2013-10-17 13:15:32 -04:00
Thomas Ronner
aee68511e6 Fix illegal set operation in FreeBSD section of user module. 2013-10-17 15:02:23 +00:00
jctanner
7e8e186b3b Merge pull request #4517 from adfinis-sygroup/devel
Remove keys regardless of the options
2013-10-16 17:40:43 -07:00
James Tanner
23cbdba65e Fixes #4350 Create homedirectory if create=yes and directory is missing 2013-10-16 20:08:41 -04:00
Hiroaki Nakamura
54243dc8f5 Add support for Fedora, OpenSUSE and ArchLinux.
Tested under Fedora 19 and OpenSUSE 12.3. Not tested on ArchLinux.
2013-10-16 01:15:47 +09:00
Hiroaki Nakamura
8c5eb96de4 Do not use shortcut conditional operator which is not supported in Python 2.4. 2013-10-15 23:41:49 +09:00
James Cammarata
35284818a9 Handle ssh key files that may only have a type/key specified
If a specified key did not have a comment, it would be ignored as
an invalid key.

Fixes #4513
2013-10-15 09:05:50 -05:00
Stefan Heinemann
af704562a9 Set the options of an authorized key comma separated
According to the sshd man page, no spaces are permitted between the
options of an authorized ssh key
2013-10-15 15:29:52 +02:00
Stefan Heinemann
346d46a94c Don't mind the options of a key when removing it
This allows to remove a key without knowing the options in the
authorized_key file
2013-10-15 15:29:47 +02:00
Michael DeHaan
6ff4806b90 Merge branch 'devel' of git://github.com/shirou/ansible into devel 2013-10-14 11:50:25 -04:00
Keith Buck
36a8312de6 Improve the formatting and content for the sysctl module's description. 2013-10-14 07:16:47 +00:00
James Cammarata
49130c688d Adding 'unique' option to authorized_key module and cleanup
A small refactoring of the authorized_key module to accomodate these
changes, plus fixing some things like not rewriting the file on every
new key. These changes bring the original feature for ssh options in-
line with the comments in #3798

Fixes #3785
2013-10-11 16:22:37 -05:00
David Minor
ed7d3f92a0 Add ssh key options parameter to authorized_key module 2013-10-11 16:22:37 -05:00
James Tanner
e3849f1be7 Fixes #4312 for older versions of usermod which do not have --append 2013-10-11 09:10:46 -04:00
Michael DeHaan
119b6d73dd Remove examples of module antipattern of setting the choices array for boolean types. 2013-10-11 08:45:13 -04:00
Boris Kaul
5a34e572f5 Add support for Rich Rules in firewalld module 2013-10-10 20:09:52 +07:00
Boris Kaul
194a7dab9f Fix timeout bug in firewalld module 2013-10-10 13:41:42 +07:00
James Tanner
b7f229d390 Second attempt at preventing ipv6 route enumeration on EL4 machines 2013-10-08 18:40:15 -04:00
James Tanner
4b1600aae5 Revert "Do not enumerate ipv6 routes in CentOS 4"
This reverts commit 5186c408f7.
2013-10-08 15:51:12 -04:00
James Tanner
5186c408f7 Do not enumerate ipv6 routes in CentOS 4 2013-10-08 15:12:38 -04:00
Michael DeHaan
135f79f337 Add documentation about how passwords are generated. 2013-10-08 08:36:48 -04:00
James Cammarata
a2ac5d6df2 Better detection/categorization of ipv4 secondaries/virtual IPs
Fixes #3916
Fixes #3478
2013-10-07 15:18:33 -05:00
Michael DeHaan
c5672cf16e Merge pull request #4389 from MattTheRat/devel
addresses #4371 - adds -m to usermod commands
2013-10-07 12:15:20 -07:00
Matt Warren
74c412e249 addresses https://github.com/ansible/ansible/issues/4371 - adding -m to home directory modification 2013-10-07 10:47:12 -04:00
Michael DeHaan
f6c3dce497 Merge pull request #4336 from orkaa/devel
Fixes service update-rc.d functionality on debian
2013-10-07 05:56:43 -07:00
Martijn Lina
4cd3b9d637 replace dashes in rc.conf keys (which are based on freebsd rc.d filenames) to underscores 2013-10-04 16:30:39 +02:00
Skylar Saveland
b47add0f32 fixes 4365 - Mac with cisco vpn client, GenericBsdIfconfigNetwork get_default_interfaces fails with index out of range 2013-10-03 18:58:11 -07:00
Adam Miller
323e8d4a8c fixed firewalld get_service_enabled 2013-10-02 18:52:53 -05:00
Nace Oroz
672a0c04e4 Fixes service update-rc.d functionality on debian 2013-10-02 14:27:38 +02:00
cdigiovanni
7ff2b3befd Added support to disable and enable upstart jobs 2013-09-30 14:50:47 -05:00
Brian Harring
f88fed2060 Enforce umask for cron module, so cron_file generated files are 0644.
Certain cron implementations get cranky if files in cron.* are group
writable.
2013-09-30 13:21:07 -04:00
Nils Pascal Illenseer
4ee6c6d5df Add option 'lz4' for compression 2013-09-30 14:20:21 +02:00
Cristobal Rosa
617f7bb0a0 Added an space between code and comments in order to follow the coding standars 2013-09-28 00:02:43 +02:00
Cristobal Rosa
be279295b6 Added a new check to check whether an network interface is in promiscuous mode 2013-09-28 00:02:06 +02:00
James Cammarata
9dd2d1eb13 Merge pull request #4222 from lessmian/devel
Module lvol fails when decimal point is a colon
2013-09-25 14:54:58 -07:00
James Cammarata
301a00ccf5 Merge branch 'obsd-fix-release' of https://github.com/johanwiren/ansible into johanwiren-obsd-fix-release 2013-09-25 14:49:57 -05:00
James Cammarata
23417368df Fixing up some open_iscsi docs and CHANGELOG update 2013-09-25 14:37:56 -05:00
James Cammarata
c98ed252fe Merge branch 'open_iscsi_bis' of https://github.com/sergevanginderachter/ansible into sergevanginderachter-open_iscsi_bis 2013-09-25 14:35:01 -05:00
Tomasz Lesniewski
385ffcdfb1 Module lvol fails when decimal point is a colon 2013-09-24 16:19:07 +02:00
Rene Moser
ff84812047 host: minor doc style improvements 2013-09-24 15:47:39 +02:00
Tomasz Lesniewski
e2815a56dc Module lvol fails when decimal point is a colon 2013-09-24 15:06:18 +02:00
Michael DeHaan
314e1aafc1 Merge pull request #4220 from dagwieers/setup-dmidecode-fix
Fix for commented dmidecode output
2013-09-24 05:04:33 -07:00
Dag Wieers
5bd7664fac Fix for commented dmidecode output
This patch fixes the problem that on some system dmidecode prints out warning information as commented text. For example:

    [user@system ~]# dmidecode -s system-manufacturer
    # SMBIOS implementations newer than version 2.6 are not
    # fully supported by this version of dmidecode.
    HP

So we remove all commented lines from the output.
2013-09-24 12:46:48 +02:00
Rene Moser
803b2b91a6 host: added another example 2013-09-24 09:15:16 +02:00
James Cammarata
a6d62ef59b Minor pep8 cleanup 2013-09-23 16:37:42 -05:00
James Cammarata
4420379f59 Fixing some bugs found during testing in the host module 2013-09-23 16:05:43 -05:00
James Cammarata
da0d50c383 Merge branch 'feature/host' of https://github.com/resmo/ansible into resmo-feature/host 2013-09-23 15:42:30 -05:00
James Cammarata
a8fac7906d Merge branch 'devel' of https://github.com/drybjed/ansible into drybjed-devel 2013-09-23 15:10:40 -05:00
James Cammarata
c31ece58fa Added version_added string to new modprobe module and CHANGELOG update 2013-09-23 15:02:02 -05:00
James Cammarata
4d7b5da25d Merge branch 'modprobe-module' of https://github.com/stygstra/ansible into stygstra-modprobe-module 2013-09-23 15:00:50 -05:00
James Cammarata
d1f713938e Modified env fact gathering to use the native python method
Also updated CHANGELOG for this feature
2013-09-23 14:17:40 -05:00
James Cammarata
19343288df Merge branch 'env_facts' of https://github.com/bcoca/ansible into bcoca-env_facts 2013-09-23 13:46:11 -05:00
Maciej Delmanowski
551b93c547 Made re.search string shorter 2013-09-23 12:27:14 +02:00
Maciej Delmanowski
40b0471e95 Add Linux Container identification 2013-09-23 12:15:33 +02:00
Johan Wirén
e9554e5da2 Fixed setup module to no longer break on OpenBSD release versions. 2013-09-22 14:05:22 +02:00
James Cammarata
4efdf0d49f More housekeeping
* Modified version_added strings in recent modules
* Added firewalld inclusion to the CHANGELOG
2013-09-21 01:06:34 -05:00
James Cammarata
8721ad2909 Moving firewalld module from net_infra to system 2013-09-21 01:02:19 -05:00
René Moser
0ba7acd205 host: code cleanup 2013-09-20 22:50:03 +02:00
James Cammarata
c2e02fbd6b Minor tweak to service changed logic from the previous commit 2013-09-19 15:00:25 -05:00
James Cammarata
f62093da56 Merge branch 'service-enable-fix' of https://github.com/gottwald/ansible into gottwald-service-enable-fix 2013-09-19 14:59:53 -05:00
Petr Svoboda
8d290e3394 Fix traceback in service module when svc_cmd is None (2nd fix)
When service module is used on unsupported Linux system where init
script is used directly, LinuxService.svc_cmd is None so .endswith()
fails.

This extends fix from e2f20db534 also
for state=restarted.

Fixes issue #3533
2013-09-19 14:36:02 -05:00
René Moser
bcaab4236b host: updated version_added 2013-09-19 20:09:38 +02:00
Rene Moser
7f96dd832f added module host
Add or remove entries in /etc/hosts using tasks:
- host: ip=127.0.0.1 hostname=localhost aliases=foobar.com,localhost.foobar.com
- host: ip=127.0.0.1 hostname=localhost state=present
- host: ip=192.168.1.1 state=absent
- host: hostname=localhost state=absent
- host: ip=::1 hostname=localhost aliases=ip6-localhost,ip6-loopback
2013-09-19 20:09:38 +02:00
David Stygstra
58620ca477 Add Python 2.4 support to modprobe module 2013-09-19 00:04:20 -04:00
David Stygstra
27a08dc647 Module to manage kernel modules 2013-09-19 00:02:44 -04:00
James Cammarata
f4c5f37ca6 Merge branch 'issue_3417_systemd_stuff' into devel 2013-09-16 09:30:39 -05:00
James Cammarata
02033f9ec8 Merge branch 'archlinux-fact' of https://github.com/Schnouki/ansible into Schnouki-archlinux-fact 2013-09-16 07:45:38 -05:00