Commit graph

4879 commits

Author SHA1 Message Date
Roberto Migli
ca5f1fcf03 Fixed error in docs 2014-06-18 18:29:06 +02:00
Roberto Migli
7a3c826f0c Fixed typo in docs 2014-06-18 18:22:50 +02:00
James Cammarata
55724f876d Merge branch 'lvg_fix' of https://github.com/sergevanginderachter/ansible into sergevanginderachter-lvg_fix 2014-06-18 09:00:41 -05:00
James Cammarata
7dae6b024c Merge pull request #7814 from scottbrown/bugfix-7811-mysql_import_does_not_perform_dump_existence_check
BUGFIX for Issue 7811: Adding file existence check when performing mysql import on...
2014-06-17 16:51:14 -05:00
James Cammarata
b5ea0246b3 Merge pull request #7810 from rivik/lvg_options_fix
Set default vg_options to empty string
2014-06-17 16:47:02 -05:00
James Cammarata
8e0c610200 Merge pull request #7808 from joelcrocker/patch-1
Updates django_manage so it populates VIRTUAL_ENV
2014-06-17 16:45:51 -05:00
Scott Brown
28c9104ed5 BUGFIX 1178: Adding better existence check in one place. db_import now fails fast if target does not exist b/c no point going further without the target. 2014-06-17 14:37:14 -07:00
Scott Brown
b09a144724 BUGFIX 7811: Adding file existence check when performing mysql import on a .gz or .bz2 file, otherwise Ansible will not notice that the underlying *nix command silently died. 2014-06-17 13:08:53 -07:00
Ilya Rusalowski
9c5ff8c498 Set default vg_options to empty string 2014-06-17 20:42:18 +04:00
James Cammarata
57a2104c40 Merge pull request #7801 from koenpunt/npm-rbenv-exec
Allow gem executable to contain spaces
2014-06-17 11:16:42 -05:00
Joel Crocker
3f7934cc04 Updates django_manage so it populates VIRTUAL_ENV
Virtualenv's activate script sets the VIRTUAL_ENV environment variable to the path of the virtualenv. Checking this variable is a reasonably common way to verify that execution is happening in a virtualenv. It would be convenient if this module's virtualenv handling set this environment variable.
2014-06-17 12:01:14 -04:00
Koen Punt
d9f9234084 Allow gem executable to contain spaces
rbenv has a special exec function which loads the correct ruby version before executing a command.
The syntax for this is `/usr/local/rbenv/bin/rbenv exec gem ...` for example.
But previously when specifying executable='/usr/local/rbenv/bin/rbenv exec gem' this would not work because the string was treated as one executable. This PR fixes that by splitting the executable on spaces.
2014-06-17 11:58:10 +02:00
Ruggero Marchei
e3f5af377f move get_distribution_version() to basic.py 2014-06-17 10:22:14 +02:00
Koen Punt
2748095a8e Allow executable to contain spaces
NVM has a special script which loads the correct node version before executing a command.
The syntax for this is `/usr/local/nvm/nvm-exec ...`, so `nvm-exec npm list --json` for example.
But previously when specifying `executable='/usr/local/nvm/nvm-exec nvm'` this would not work because the string was treated as one executable.
2014-06-17 01:31:24 +02:00
James Cammarata
cb13b30362 Use file documentation fragement for the copy module 2014-06-16 15:36:15 -05:00
James Cammarata
b7a5ce37a4 Merge pull request #7755 from sivel/rax-asg-normalize-nic
module rax_scaling_group: safe normalization of nics
2014-06-16 11:42:44 -05:00
James Cammarata
ddb946beb1 Minor cleanup of openbsd_pkg example comment 2014-06-16 11:35:57 -05:00
James Cammarata
df15990e0c Merge pull request #7774 from mwpher/devel
[openbsd-pkg] Add note regarding package flavors
2014-06-16 11:33:53 -05:00
James Cammarata
d1c9c943cb Merge pull request #7776 from toddmowen/pkgutil-quote-fix
Fix in pkgutil: don't call pipes.quote() on None
2014-06-16 10:06:09 -05:00
James Cammarata
3baed58eed Merge pull request #7778 from toddmowen/unarchive-detect-error
unarchive: improve failure detection and reporting
2014-06-16 10:04:03 -05:00
Todd Owen
43c9edad8a unarchive: do not assume tar supports -C
Fixes #7777
(But don't rewrite the tar invocation in is_unarchived(), since a
tar that supports "--diff" certainly supports "-C" as well).
2014-06-15 22:38:41 +08:00
Todd Owen
a4fe91050b unarchive: improve failure detection and reporting
Related to #7777
2014-06-15 13:13:18 +08:00
Todd Owen
247f70cf5c Fix in pkgutil: don't call pipes.quote() on None.
In this function, 'site' may be None, which will cause an exception
if it is passed to pipes.quote().
2014-06-15 10:20:35 +08:00
Matthew Pherigo
127201559f [openbsd-pkg] Add note regarding package flavors
This adds a note to the openbsd-pkg module which explains how to specify
package flavors as well as how to avoid ambiguity errors on a package
with multiple flavors.

Technically, this is not Ansible-specific, but it's pretty likely the
user will encounter this problem.
2014-06-14 19:42:09 -05:00
Ruggero Marchei
c53c6a507a use different strategy for RHEL >= 7. Fixes 7763 2014-06-14 19:29:04 +02:00
Brice Leroy
50d8047c6e Fix task description 2014-06-13 15:15:29 -07:00
Matt Martz
b2d24aba61 Perform safe normalization of nics to use uuid 2014-06-13 12:17:42 -05:00
James Cammarata
1173a8d6af Catch error in azure related to a failed deployment when creating a vm 2014-06-12 10:25:31 -05:00
James Cammarata
0b8c8b0581 Merge branch 'devel' of https://github.com/matlockx/ansible into matlockx-devel 2014-06-12 09:32:03 -05:00
James Cammarata
d90f0bdfad Merge branch 'fix-lineinfile-eof-newline' of https://github.com/ahtik/ansible into ahtik-fix-lineinfile-eof-newline 2014-06-12 09:13:49 -05:00
James Cammarata
db4a5c6046 Merge pull request #7741 from mgcrea/devel
Add support for Linaro distribution in hostname module
2014-06-12 08:58:56 -05:00
James Cammarata
c548d0fb3b Merge pull request #7737 from toddmowen/zfs-fix-7696
zfs: fix incompatibility - share.nfs vs sharenfs (issue #7696)
2014-06-12 08:53:21 -05:00
James Cammarata
ccf47577c4 Merge branch 'sivel-rax-autoscale' into devel 2014-06-12 08:14:39 -05:00
Olivier Louvignes
8051e12490 Add support for Linaro distribution in hostname module 2014-06-12 12:06:59 +02:00
Peter Kolloch
7a6354f753 Hack to fix #7738: Allow tag in image parameter of docker module
It also defaults to the "latest" tag for pulling the image
instead of pulling all versions.
2014-06-12 11:48:57 +02:00
Todd Owen
4230a9a462 zfs: work around incompatibility by renaming share.nfs to sharenfs
Fixes #7696
2014-06-12 16:21:16 +08:00
rgbkrk
da107d3f0c Error checking and reporting on interface ufw rule 2014-06-11 11:10:38 -05:00
Aleksey Khudyakov
6865ffe93c Escape backslash in assemble module docs 2014-06-11 04:38:57 +11:00
James Cammarata
917ad8da72 Merge pull request #7687 from ryanpetrello/devel
Fix neutron floating IP allocation for networks w/ multiple subnets
2014-06-10 09:42:34 -05:00
James Cammarata
07e10fb9ff Merge branch 'rax-autoscale' of https://github.com/sivel/ansible into sivel-rax-autoscale 2014-06-10 09:16:02 -05:00
Paul Myjavec
074a6f3e3e Docker links and required alias
If no alias is passed one will now be created for you with the same name
as the target link container, as per the documentation
2014-06-10 22:53:55 +10:00
James Cammarata
8e3b512293 Merge pull request #7377 from mikhailguru/devel
Fixed handling of paths containing whitespaces in the synchronize module
2014-06-10 06:50:07 -05:00
Brad Pitcher
73a92d3621 use the full list of available campfire sounds
From the list found [here](http://www.emoji-cheat-sheet.com/)
2014-06-09 21:59:20 -07:00
James Cammarata
0073b34653 Merge pull request #7259 from darKoram/nova_keypair_check_keys
nova_keypair should fail if 'name' of key exists in keystore, but ssh hash value != public_key offered
2014-06-09 23:53:22 -05:00
James Cammarata
150a2346c1 Merge pull request #7238 from willthames/ec2_snapshot_argument_spec
Improve the ec2_snapshot argument spec and docs
2014-06-09 23:51:42 -05:00
Ron Gomes
bcf3e29e14 Fix incorrect argument ordering in error message, which provokes a
printf-related TypeError.
2014-06-09 15:03:51 -04:00
Matt Ferrante
3e875c7867 ec2_asg module enhancements
- Added a more verbose response
  - includes its settable attributes and a list of its instances.
  - allows setting of tags, changes upon which mark the task changed
  - allow getting of information from asg module, not just setting
  - doesn't mark changed if the parameter wasn't specified
  - Availability Zones are pulled from the region
2014-06-09 13:34:57 -04:00
Ahti Kitsik
1caf9be109 Bugfix to lineinfile to properly handle files with no newline at EOF when using insertafter=EOF.
Looks like #6881 is also affected by this bug.

Currently when using lineinfile insertafter=EOF for a file that has no newline then the added line is not prefixed with a newline.
As a concrete example, ubuntu distro default /etc/ssh/sshd_config has no newline so lineinfile module cannot be used to add a new line to the end of the file.
2014-06-09 19:58:45 +03:00
James Cammarata
61325f5817 Cleaning up svr4pkg commit fix for #7645 2014-06-09 10:48:06 -05:00
James Cammarata
19d6f4d177 Merge branch '7645' of https://github.com/kcghost/ansible into kcghost-7645 2014-06-09 10:45:29 -05:00
James Cammarata
989e4770d0 Merge pull request #7684 from JeanFred/patch-2
Fix documentation of deb option in apt module
2014-06-09 10:03:36 -05:00
James Cammarata
7ff3282e39 Merge pull request #7682 from sergevanginderachter/bigip_monitor_http_checkmode_fix
bigip_monitor bugfix for check mode
2014-06-09 09:39:33 -05:00
James Cammarata
4c30b3d68a Fixing mysql master replication boolean
Fixes #7528
2014-06-09 08:58:55 -05:00
Casey Fitzpatrick
fdbb77da51 fix for svr4pkg module failure reporting, issue #7645 2014-06-08 19:59:44 -04:00
Martin Joehren
98ff559fa0 azure - fixed missing return statement 2014-06-08 21:39:31 +02:00
Martin Joehren
188a13efc0 azure - fix for: temporary redirect, not deleted vhds, missing locations and role types, async api calls 2014-06-08 00:36:55 +02:00
James Cammarata
5637426f51 Merge branch 'devel' of https://github.com/ansible/ansible into devel 2014-06-06 21:56:32 -05:00
Ryan Petrello
bb0ca4c1aa Fix neutron floating IP allocation for networks with a v4 *and* v6 subnet.
For networks that have both a v4 and a v6 subnet, the floating IP plugin
currently has two problems:

* When determining the subnet for the provided `internal_network_name`, it
assumes that the first item in the list of subnets is the one you want.
Instead, it should pick the first v4 subnet.

* When multiple fixed IP's exist for a given port (as is the case in a network
a v4 and a v6 subnet), neutron needs a hint as to which fixed IP to associate
to the floating IP address (the v4 one).
2014-06-06 17:03:26 -04:00
James Cammarata
5bd8cd6e00 Cleaning up azure module
* Fixed error messages to be more descriptive
* Removed direct use of subprocess module and replaced it with calls
  to module.run_command
* Changed AZURE_MANAGEMENT_CERT_PATH to be just AZURE_CERT_PATH, which
  matches what is expected by the inventory script
2014-06-06 15:58:28 -05:00
Matt Martz
ad5cf5d55d Add Rackspace Autoscale modules
- rax_scaling_group
- rax_scaling_policy
2014-06-06 11:30:07 -05:00
James Cammarata
e083168773 Merge branch 'devel' of https://github.com/jwhitbeck/ansible into jwhitbeck-devel 2014-06-06 11:19:43 -05:00
Jean-Frédéric
c42f8907fd Fix documentation of deb option in apt module
The apt module may install a .deb package on the remote machine, not on the local.
Fix the misleading documentation.
2014-06-06 18:18:44 +02:00
James Cammarata
bd5cf57e76 Merge pull request #7653 from evanccopengeo/devel
ec2_group: Fix for 500 error when creating new security groups
2014-06-06 10:34:42 -05:00
Serge van Ginderachter
ceb1ba1687 bigip_monitor bugfix for check mode
Fixes case where properties are retrieved for a non existent monitor
which happens in check mode.
2014-06-06 16:48:36 +02:00
James Cammarata
9cb05a0845 Catch failed connection due to a bad region in ec2_scaling_policy
Fixes #7505
2014-06-05 19:40:21 -05:00
James Cammarata
a760299170 Catch failed connection due to a bad region in ec2_scaling_policy
Fixes #7506
2014-06-05 16:44:55 -05:00
Kevin Bell
e0a4c389f3 Fixed asg instance count polling 2014-06-05 16:18:31 -05:00
Kevin Bell
426a827b46 Fix default availability zone list 2014-06-05 16:18:31 -05:00
James Cammarata
26aaa7bcdd Fix typo in nova_keypair import of exceptions from novaclient
Fixes #7640
2014-06-05 15:42:38 -05:00
James Cammarata
43f96a636b Fix issue with symlink path detection
Fixes #7627
Fixes #7664
2014-06-04 23:31:59 -05:00
James Cammarata
7483acde5d Fix linking issue to directories in file module
The os.path.isdir() returns True for symlinks that point to directories,
so we also need to check to make sure it's not a symlink too.

Fixes #7657
2014-06-04 22:48:08 -05:00
James Cammarata
b3bbca03d5 Add additional params to get_target_from_rule method in ec2_group
Fixes #7592
2014-06-04 13:52:44 -05:00
James Cammarata
9f0d496d67 Fixing version_added strings for new features in ec2_elb_lb
Fixes #7631
2014-06-04 13:37:04 -05:00
James Cammarata
609fd2e993 Merge branch 'rax-meta' of https://github.com/sivel/ansible into sivel-rax-meta 2014-06-04 11:02:35 -05:00
evanccopengeo
fac9a64d23 fixing problem where ansible would error out because Amazon was saying the group didnt exist yet (needed to wait a few more seconds for amazon to propagate correctly) 2014-06-03 14:25:48 -04:00
James Cammarata
1b5f2d47bb Merge pull request #7638 from yanc0/primary_group_doc_user_example
Add primary group in the first user module doc example
2014-06-03 10:10:55 -05:00
James Cammarata
f1afc107b2 Merge pull request #7635 from josef-spak/mysql-replication-typo
Fix typo in CHANGE MASTER TO syntax
2014-06-03 10:10:04 -05:00
Yann Coleu
b5ea9e0655 Add primary group in the first user module doc example 2014-06-02 14:32:52 +02:00
Matt Martz
04cd7c233b Allow search_regex to be used in wait_for with port 2014-06-02 07:17:01 -05:00
Josef Špak
2d402ab5ca Fix typo in CHANGE MASTER TO syntax 2014-06-02 13:42:55 +02:00
Christoph Dwertmann
5cab159bda Don't use deprecated BaseException.message in keystone_user
fixes error "failed to parse: <attribute 'message' of 'exceptions.BaseException' objects>
TypeError: <attribute 'message' of 'exceptions.BaseException' objects> is not JSON serializable"
2014-06-02 15:11:53 +10:00
Matt Martz
7dd5b731d2 Mention that user_data can be a file path or a string 2014-06-01 14:47:01 -05:00
Matt Martz
70881d5489 Switch functions over to kwargs to make it easier to manage in the future 2014-06-01 14:45:54 -05:00
Matt Martz
4ca7840861 Add user_data and config_drive support 2014-06-01 14:42:58 -05:00
Matt Martz
84b1f21617 Add rax_meta module
Also update rax to mirror meta value normalization from rax_meta
2014-06-01 14:31:26 -05:00
Michael DeHaan
6bc056e012 Merge pull request #6863 from sivel/rax-untouched
rax module: Return untouhced servers with exact_count
2014-06-01 15:27:45 -04:00
CorbanR
42f54238e4 updating example, to be more consistent with parameter names 2014-05-30 15:57:55 -06:00
Brian Coca
fedc3a4f85 corrected doc example, non existing fact to the 2 it had 'merged' 2014-05-29 22:44:33 -04:00
Sean Whitbeck
796d8db860 Add azure VM provisioning/termination module 2014-05-29 17:29:09 -07:00
Krzysztof Warzecha
8326b7672a vsphere_guest: Add support for setting hardware version (should fix #7206) 2014-05-30 00:01:39 +02:00
Johannes 'fish' Ziemke
352daa0138 Add networking mode parameter (net) to docker
Since 0.11 Docker supports different networking modes (see docker run
--net). This commit add support for that to the ansible docker module.

This depends on
2d58351164
2014-05-29 18:59:03 +02:00
Mischa Peters
a0ae43b311 Adding support for A10 Networks slb server, slb service-group, slb virtual-server 2014-05-29 12:16:04 +02:00
Brian Coca
202ac68995 Correctly examine path for relative links in file module
Fixes #7515
Fixes #7537
2014-05-28 11:47:44 -05:00
Stephen Paul Suarez
2c8564e787 fix spacing 2014-05-28 06:14:54 +08:00
James Cammarata
ba641de69e Merge pull request #7536 from fly/linode-warn-ssl
warn if remote SSL cert is not checked in linode
2014-05-27 16:38:33 -05:00
James Cammarata
8e111fe82e Cleanup subversion module documentation in regards to export 2014-05-27 16:20:10 -05:00
James Cammarata
e8aebcb751 Merge pull request #7567 from kitwestneat/devel
Fixed documentation for etype parameter on acl module.
2014-05-27 16:13:00 -05:00
James Cammarata
e85c7f848f Make sure export param for subversion module is checked as a boolean
Fixes #7548
2014-05-27 14:09:50 -05:00
James Cammarata
b1d76b37db Merge pull request #7542 from sivel/rax-cdb-notfound
rax_cbs module: Don't fail when the volume is not found
2014-05-27 13:47:32 -05:00
Jon Chen
be7ff82e2d require pycurl for linode module 2014-05-27 14:37:44 -04:00
James Cammarata
3dc7df39fc Merge pull request #7532 from oasiswork/devel
open_iscsi module: support RC 21 when listing logged-in target
2014-05-27 13:13:48 -05:00
Kit Westneat
fabe8521cb Fixed documentation for etype parameter on acl module.
The etype parameter just had a copy of the default parameter documentation.
Changed it to reflect what it really is for.
2014-05-27 13:34:01 -04:00
Stephen Paul Suarez
1edcee5ae8 fix typo 2014-05-27 19:19:49 +08:00
Stephen Paul Suarez
d1da454da6 support rw bind mode in docker module 2014-05-27 16:18:23 +08:00
Matt Martz
27ac5b1856 Don't fail in rax_cbs when the volume is not found 2014-05-25 19:39:43 -05:00
Nicolas Brisac
592a5b6fb1 open_iscsi module: support RC 21 when listing logged-in target 2014-05-24 18:14:28 +02:00
Brian Coca
c24956032d unified calls to fs function vs duplicate functions for file and
directory
2014-05-24 09:28:45 -04:00
Andrew Resch
3caea2e890 Fix typo in variable name 2014-05-24 09:26:44 -04:00
Andrew Resch
00389af1c2 Fix typo in variable name 2014-05-23 16:09:57 -07:00
Andrew Resch
fb1385bbd9 Replace CommandException with Exception 2014-05-23 12:44:01 -07:00
Jack Neely
7883261335 apache2_module: Handle dep resolution
The apache2_module module did not properly handle when a2enmod would
handle apache module dependancies.  It would always return a state of
changed.  I've updated the regular expression to properly parse that
output as well as the normal output.  A good example of this is the
mod_proxy_http module.
2014-05-23 12:47:57 -04:00
Jack Neely
3531d3cd28 apache2_module: whitespace cleanup
Remove trailing whitespace.
2014-05-23 12:47:49 -04:00
Evgenii Terechkov
7ad6f6e385 Relax suds module requirement 2014-05-23 10:40:10 -05:00
Daniel Jaouen
37fff3dc38 Add upgrade_all option to homebrew module. 2014-05-23 11:09:18 -04:00
Aleksey Khudyakov
a67c6f0663 Fix typo requird -> required 2014-05-24 00:10:46 +11:00
Matt Martz
576224e202 Add PTR record support to rax_dns_record 2014-05-22 18:12:56 -05:00
Michael DeHaan
ee82681d14 Merge pull request #7501 from sivel/rax-dns-serial-doc
Add notes to rax_dns and rax_dns_record to recommend using serial: 1
2014-05-22 14:10:43 -04:00
Matt Martz
413243186d Add notes to rax_dns and rax_dns_record to recommend using serial: 1 2014-05-22 11:58:28 -05:00
Michael Warkentin
c8eb47eefa Update command description
The docs were a little bit out of date with what commands are available to be run. They also didn't explain that you could pass custom commands - I almost went down the path of trying to run our custom management commands with the generic Ansible `command` module.
2014-05-21 14:00:12 -04:00
James Cammarata
062e82937f Fixing absolute path calculation for file module when linking
Fixes #7403
2014-05-21 12:49:42 -05:00
Matt Martz
73c67cea91 Allow public_key to be a path to a file 2014-05-21 12:28:18 -05:00
Ralf Geschke
c6f3f5b4d7 added missing description of composer command 2014-05-21 18:14:21 +02:00
Ralf Geschke
b04d42ecd9 added missing description... 2014-05-21 18:12:53 +02:00
Ralf Geschke
beceac1b35 implemented the missing "command" option, defaults to "install"... 2014-05-21 18:01:33 +02:00
Atlas Health
26c2491583 Stopped instances can also be terminated 2014-05-21 07:18:30 -07:00
James Cammarata
7ef94428bf Merge branch 'elb-internal' of https://github.com/asnare/ansible into asnare-elb-internal 2014-05-21 08:34:21 -05:00
James Cammarata
4faff30ee0 Merge branch 'multi-word-mysql-grant-example' of https://github.com/webmat/ansible into webmat-multi-word-mysql-grant-example 2014-05-21 07:48:24 -05:00
Brian Coca
24f5030257 now module searches for update-alternatives vs hardcoding it 2014-05-20 22:51:27 -04:00
Andrew Snare
0cc6c479bc Support internal-only ELBs in EC2. 2014-05-20 22:21:14 +02:00
Mathieu Martin
a8969b5d3c Add example 'Specify grants composed of more than one word' to the mysql_user module. 2014-05-20 14:41:18 -04:00
James Cammarata
d44ed533b3 Default use_proxy to True for fetch_url()
Also added some error handling to the fetch_url() call in the
apt_repository module, so that failures to look up the PPA info
are properly handled.

Fixes #7322
2014-05-19 23:04:13 -05:00
Abhijit Menon-Sen
0dea177e77 Allow '-t ' to be passed to apt: upgrade 2014-05-17 23:02:20 +05:30
James Cammarata
cbea442ec2 Pull the link out of the alternatives output when not specified
Fixes #7414
2014-05-16 14:44:31 -05:00
James Cammarata
923baa6772 Merge branch 'yum_module_typos' of https://github.com/mpeters/ansible into mpeters-yum_module_typos 2014-05-16 09:24:47 -05:00
James Cammarata
e3ee7787ed Remove erroneous set of status_code causing a traceback in module uri
Fixes #7416
2014-05-16 08:49:08 -05:00
Michael Peters
15b3b42525 slight language change based on feedback from jimi-c 2014-05-16 09:44:32 -04:00
Michael Peters
69923cc413 fixing some typos in the docs of the yum module 2014-05-16 09:22:12 -04:00
Alan Pearce
670068aaad Update composer example
Remove unsupported 'install' argument
2014-05-16 14:06:55 +01:00
Michael DeHaan
b80b92e778 Stackdriver module was in the wrong category, so moving. 2014-05-16 08:30:38 -04:00
Matt Bray
8363ab5a6f docker: fix targetting images by name 2014-05-15 15:04:30 +01:00
James Cammarata
32ce085689 Merge branch 'patch-1' of https://github.com/telsacolton/ansible into telsacolton-patch-1 2014-05-14 21:48:31 -05:00
willthames
551adfa26e Fix parameters check for ec2_vol
Split the error check into two error checks and delay the
checks so that listing existing volumes works more nicely.

The error check should check that:
* One and only one of volume_size id or name is set

This fix adds the 'only one' part of that check and provides
more useful error messages.
2014-05-15 12:31:13 +10:00
James Cammarata
df877f2e79 Check module_path permissions when creating ssh_wrapper for git
If the module directory is not writable/executable to the current user
(most likely because of a sudo to a non-root user), the ssh_wrapper
will be created in the default location for mkstemp() calls. To facilitate
the deletion of these new files, a new mechanism for cleaning up files
created by the module was also added.

Fixes #7375
2014-05-14 21:22:22 -05:00
telsacolton
06963c7826 Make file hardlink error message reasonble
When we hard-link a file, and the link path already exists, give the link path in the error message instead of the source
2014-05-14 16:54:26 -05:00
telsacolton
0d8104b8b7 Give reasonable error when symlink fails
When a symlink fails because the path already exists and force=no, we should output path in the error message instead of source.
2014-05-14 16:31:20 -05:00
James Cammarata
67d8df0e32 During vsphere config check attempt cast before marking values missing
Fixes #7385
2014-05-14 15:57:26 -05:00
James Cammarata
154ef942eb Merge pull request #7404 from jimi-c/issue_7363_docker_names
Make sure the docker data has a "Names" field before using it
2014-05-14 14:44:16 -05:00
James Cammarata
e623911df6 Merge branch 'bcoca-file_new_dirs_perms' into devel 2014-05-14 13:56:27 -05:00
James Cammarata
a9311a5dcb Merge branch 'file_new_dirs_perms' of https://github.com/bcoca/ansible into bcoca-file_new_dirs_perms 2014-05-14 13:53:08 -05:00
James Cammarata
bf405ef7a8 Merge pull request #7400 from etehtsea/patch-1
Fix env splitting in docker module
2014-05-14 11:00:32 -05:00
Konstantin Shabanov
ad9225895b Fix env splitting in docker module
ENV variable value could contain '=' (for example mysql://host/db?pool=10)
2014-05-14 18:11:43 +04:00
Scott Sturdivant
726dc1d2e8 Clarify that the encrypted param must also be set.
While the encrypted parameter's documentation clearly states that it needs to
be set, if you are focused on the password parameter's documentation, there's
nothing to draw your attention to the fact that encrypted may also need to be
set.
2014-05-14 07:49:11 -06:00
Atlas Health
342fef79a1 set type and default value 2014-05-13 22:00:22 -07:00
James Cammarata
19dbff916f Correctly cast the size_gb value for vpshere disks
Fixes #7385
2014-05-13 15:13:13 -05:00
Henry Finucane
6efc8008da Fail fast in the presence of permissions issues 2014-05-13 09:43:47 -07:00
Carson Gee
e6fbd2d8cb Fix missing variable initialization so an unspecified internal_network runs 2014-05-13 09:56:13 -04:00
Mikhail Emelchenkov
a2ca0441ae Fixed incorrect handling of paths contaiin whitespaces 2014-05-13 17:05:44 +04:00
Henry Finucane
278ecb9b55 Allow wait_for to wait on non-traditional files
Use os.path.exists to check for file existence, instead of "can we open
this file for reading".

Fixes #6710
2014-05-12 23:21:55 -07:00
Matt Martz
92b77048dc Handle ValueError during json.loads of json data from build 2014-05-12 14:16:07 -05:00
James Cammarata
bfc1201ecd Make sure the docker data has a "Names" field before using it
Fixes #7363
2014-05-12 12:27:07 -05:00
Yuichi TANIKAWA
2b644da4ca Add dots to valid path characters 2014-05-10 18:13:16 +09:00
James Cammarata
3bf890998b Merge pull request #7348 from adamchainz/patch-2
Fix grammar and value errors in cron documentation
2014-05-09 22:27:31 -05:00
James Cammarata
62c4a15c73 Merge pull request #7346 from tongpu/devel
Add documentation for required parameter name to quantum_subnet
2014-05-09 16:21:28 -05:00
Johannes 'fish' Ziemke
ea71c0c317 Fix: Remove check for Ghost state
This fixed the just committed change handling non existent Ghost state.
2014-05-09 20:13:25 +02:00
James Cammarata
c97dec9d75 Merge pull request #7338 from discordianfish/remove-ghost-state
Remove check for Ghost state
2014-05-09 13:06:16 -05:00
Johannes 'fish' Ziemke
b9d9ef511f Remove check for Ghost state
This doesn't exist anymore and causes ansible to throw a KeyError
2014-05-09 18:07:02 +02:00
Adam Chainz
3497582581 Fix grammar and value errors in cron documentation 2014-05-09 15:19:42 +01:00
James Cammarata
b78058022d Merge pull request #7342 from herbygillot/rds-params-fix
rds module: Fix undeclared reference to "params" when setting password in modify mode
2014-05-09 08:34:16 -05:00
Lukas Grossar
0aa4cb9a79 Add documentation for required parameter name to quantum_subnet 2014-05-09 15:17:04 +02:00
Michael DeHaan
54ac0fe92c Merge pull request #7343 from lberruti/alternatives_python5_2
Make alternatives module python 2.5 compatible
2014-05-09 09:08:34 -04:00
Herby Gillot
efbe4ca8d5 rds module: Fix undeclared reference to "params" when setting password in
modify mode.
2014-05-09 05:49:11 -04:00
James Cammarata
5c7109b8b9 Merge pull request #7110 from orgoj/docker-patch-version_comment
module docker - add docker version comment
2014-05-09 00:57:41 -05:00
James Cammarata
a18f4b6230 Merge branch 'devel' of https://github.com/jjshoe/ansible into jjshoe-devel 2014-05-09 00:31:39 -05:00
James Cammarata
0215134907 Fixing a doc mistake in the ec2 module from 4269bb6 2014-05-09 00:21:35 -05:00
James Cammarata
48e2a5e5a2 Merge branch 'ec2-start-stop' of https://github.com/sayap/ansible into sayap-ec2-start-stop 2014-05-09 00:04:34 -05:00
Yap Sok Ann
4269bb6a45 ec2: Fix bug with running/stopped state and wait=yes.
If `get_all_instances` returns multiple reservations, the old wait loop only
dealt with the first reservation. Thus, the wait loop may end before all
instances get to be running/stopped.

Also clean up the code a little.
2014-05-09 11:35:48 +08:00
James Cammarata
9d3583cab3 Merge pull request #7055 from bpennypacker/rds_modify
cloud/rds : renaming an rds instance always fails
2014-05-08 21:10:47 -05:00
James Cammarata
ebac5dfbce Updating docstring for docker_image based on new default for tag 2014-05-08 21:04:55 -05:00
James Cammarata
34e52c5884 Merge branch 'docker_image-patch-notag' of https://github.com/orgoj/ansible into orgoj-docker_image-patch-notag 2014-05-08 21:03:57 -05:00
James Cammarata
8dd91021f4 Merge branch 'git-submodule-when-recursive-true' of https://github.com/bibliotechy/ansible into bibliotechy-git-submodule-when-recursive-true 2014-05-08 20:47:10 -05:00
James Cammarata
39433949e0 Merge branch 'elb_subnets' of https://github.com/jimbydamonk/ansible into jimbydamonk-elb_subnets 2014-05-08 19:28:54 -05:00
James Cammarata
4358c846a0 Merge branch 'brian-brazil-devel' into devel 2014-05-08 16:47:21 -05:00
James Cammarata
b97f087f18 Fixing a typo in the monit module (status and not status()) 2014-05-08 16:46:32 -05:00
James Cammarata
a969941b85 Merge branch 'devel' of https://github.com/brian-brazil/ansible into brian-brazil-devel 2014-05-08 16:11:18 -05:00
James Cammarata
d9bb1a480a Merge pull request #7013 from orgoj/replace-patch-changed
module replace - report changed only if contents is changed
2014-05-08 15:14:19 -05:00
James Cammarata
3ac4943751 Some cleanup for the rds/vpc_security_groups fix 2014-05-08 15:08:43 -05:00
James Cammarata
768de238d4 Merge branch 'vpc_fix' of https://github.com/ebrevdo/ansible into ebrevdo-vpc_fix 2014-05-08 14:39:07 -05:00
James Cammarata
1a52fcce03 Merge pull request #7335 from napkindrawing/patch-1
Route53 module handling of domains with "*" is broken
2014-05-08 14:02:00 -05:00
napkindrawing
011ec5d9e6 Fix to unescape * was discarded by unescape of @
`decoded_name` was created twice, each from `rset.name`

So, the second call to `.replace(r'\100', '@')` overwrites decoded_name, discarding the result of the call to `.replace(r'\052', '*')`

I had a problem with wildcard domains that was fixed by this patch.
2014-05-08 14:20:32 -04:00
Chris Lamb
f510389298 Fail if monit reload failed; don't mask the error.
This is necessary for the scenario when you push a new, broken monit
config out, and then set a state=reloaded handler - the error was
previously swallowed so you could end up with successful play but missing
monitoring (!).

Signed-off-by: Chris Lamb <chris@chris-lamb.co.uk>
2014-05-08 18:18:28 +01:00
Paul Armstrong
7d28f30bda Add proper state output to ec2_asg, ec2_metric_alarm, ec2_scaling_policy 2014-05-08 15:51:07 +00:00
Luca Berruti
a3d1f06cb2 Make alternatives module python 5 compatible 2014-05-08 14:46:49 +02:00
James Cammarata
713657d684 Make sure the default ec2_group egress rule is not removed
Upon a second run, the default egress rule will be removed when a
vpc is specified but no other egress rules were set. This patch
corrects that behavior by removing the default egress rule from the
list of unmatched outbound rules.

Fixes #7309
2014-05-07 20:52:03 -05:00
James Cammarata
bd56cfdf18 Merge pull request #7313 from mmoya/doc-fixes
Minor typo fix
2014-05-07 10:12:26 -05:00
Jean-Francois Chevrette
83d79f6257 this should return 0 to indicate a non-failure when check_mode is True 2014-05-07 10:20:51 -04:00
James Cammarata
b71a451ed0 Close fds when running commands from the accelerate daemon
Fixes #7307
2014-05-07 08:47:38 -05:00
Maykel Moya
1d3ce41e83 Fix typo 2014-05-07 10:35:16 +02:00
Christian Berendt
2c39eff60e [get_url] check against lowered stripped sha256sum
The content of the sha256sum attribute should be lowered before comparing it with the calculated sha256sum.

In the following example the used sha256sum uses ABC.. and not abc.. and the check failed. This should not happen.

```
TASK: [get_url url=http://ftp.fau.de/apache/hadoop/common/hadoop-2.4.0/hadoop-2.4.0.tar.gz dest=/home/vagrant/hadoop-2.4.0.tar.gz mode=0644 sha256sum=024326AC68A1A68B5566B10F95609EAAFD9F70CFEB37FCA0E97CBB1674E57C3A] ***
failed: [instance000] => {"failed": true}
msg: The SHA-256 checksum for /home/vagrant/hadoop-2.4.0.tar.gz did not match 024326AC68A1A68B5566B10F95609EAAFD9F70CFEB37FCA0E97CBB1674E57C3A; it was 024326ac68a1a68b5566b10f95609eaafd9f70cfeb37fca0e97cbb1674e57c3a.

FATAL: all hosts have already failed -- aborting
```
2014-05-06 18:27:43 +02:00
James Cammarata
537494c2d6 Make sure distro variable is set if python-apt is installed
Fixes #7295
2014-05-06 09:42:50 -05:00
James Cammarata
941af22d5d Merge pull request #7294 from adamchainz/patch-1
Fix sync_binlog name in mysql_variables example
2014-05-06 08:18:05 -05:00
James Cammarata
7bf86ec1c0 Merge branch 'fixing_apache2_module' of https://github.com/berendt/ansible into berendt-fixing_apache2_module 2014-05-06 08:02:21 -05:00
Brian Coca
413a50f87b reworded copy option docs to be clearer 2014-05-06 08:31:26 -04:00
Adam Chainz
967de3cdf9 Fix sync_binlog name in mysql_variables example
The previous sync_binary_log is not a real MySQL variable.
2014-05-06 12:25:11 +01:00
James Cammarata
d6fc9f1dfc Fixing two bugs in the ec2_elb_lb module
* the current state of the ELB was not reflected properly when checking
  the status after a change was made.
* invalid zones caused a traceback when enabling/disabling zones
2014-05-05 12:48:45 -05:00
James Cammarata
faf733bc49 Removing zone choices that overly-limit available zones for gce
Fixes #7270
2014-05-05 11:58:39 -05:00
Antti Salminen
fa607f36b5 Switch to mapper device name if pvs returns the wrong one. 2014-05-03 10:36:22 +03:00
James Cammarata
b753625dbf Refuse to convert a non-empty directory into a link with the file module
Also adds an integration test for the above.

Fixes #7254
2014-05-02 14:46:38 -05:00
Kesten Broughton
aee1a97102 if key name already exists on tenant, check if public_key is offered that it matches the existing key 2014-05-02 11:09:54 -05:00
James Cammarata
ae7503d6fb Merge branch 'fix-copy-recursive-issue' of https://github.com/tksmd/ansible into tksmd-fix-copy-recursive-issue 2014-05-01 13:39:11 -05:00
James Cammarata
c0f92317ef Fixing a documentation error in the new stackdriver module 2014-05-01 11:44:31 -05:00
James Cammarata
2b898e7e8b Minor fix to imports in new stackdriver module 2014-05-01 11:39:46 -05:00
someda
50080b3774 fix #7244 recursive copy fails when setting directory attributes
- reverse the order of new_directory_list returned from split_pre_existing_dir in copy module
2014-05-02 01:38:16 +09:00
James Cammarata
6069d5d4cf Merge branch 'stackdriver' of https://github.com/bwhaley/ansible into bwhaley-stackdriver 2014-05-01 11:21:36 -05:00
willthames
44662a3d33 Improve the ec2_snapshot argument spec and docs
ec2_snapshot got missed when moving to a common argument spec.
It could already make use of the capabilities (as it uses
ec2_connect) and the documentation suggested it supported the
common argument spec (thanks to the documentation fragment work)
so it was just a matter of fixing the argument spec.

Removed unnecessary documentation for profile and security_token
that is covered by documentation fragment

Also removed spurious documentation flags (default: null, aliases: [])
which aren't needed.
2014-05-01 13:11:41 +10:00
James Cammarata
ce48e1f9ff Merge pull request #7230 from binarytemple/fix_for_issue_7228
fix issue #7228 ec2_vol crash
2014-04-30 08:30:27 -05:00
bryan hunt
88aaa70f0c fix issue #7228 ec2_vol crash 2014-04-30 10:43:05 +01:00
Atlas Health
49d0ad0644 added example 2014-04-29 17:13:25 -04:00
Atlas Health
4258eb6be7 updated docs to include snapshot_tags option
added version
2014-04-29 17:13:25 -04:00
James Cammarata
04793ff640 Merge branch 'patch-2' of https://github.com/budlight/ansible into budlight-patch-2 2014-04-29 15:58:05 -05:00
Michael DeHaan
6b26efdee0 Merge pull request #7119 from jjshoe/patch-4
Finish reverting a broken commit in #5679
2014-04-29 16:47:46 -04:00
James Cammarata
ac1948c04c Minor tweak to rsync_path construction in synchronize module
Fixes #7182
2014-04-29 15:47:16 -05:00
Michael DeHaan
d5e254d3c7 Merge pull request #6794 from follower/patch-4
Make `vpc_security_group` docs more accurate
2014-04-29 15:49:57 -04:00
Michael DeHaan
5c75ce1133 In apt module show 'name' vs pkg to standardize with the rest of the modules. 'pkg' is an alias for name. 2014-04-29 15:48:51 -04:00
James Cammarata
d2819e22e3 Merge pull request #7212 from jimi-c/issue_7027_ec2_group_egress_rules
Make sure a default allow out rule exists if no other egress rules do
2014-04-29 10:39:36 -05:00
Carlos E. Garcia
7f5dd5e85d multiple spelling error changes 2014-04-29 10:41:05 -04:00
James Cammarata
67092039d7 Merge pull request #7190 from jimi-c/issue_7180_vsphere_guest_hardware_variable_casts
Make sure values are integers for certain hardware items for vpshere_guest
2014-04-28 21:00:46 -05:00
James Cammarata
826198196b Merge branch 'elb' of https://github.com/bpennypacker/ansible into bpennypacker-elb 2014-04-28 20:39:10 -05:00
Christian Berendt
67a8ee24e1 made enabled/disabled checks of apache2_module workable 2014-04-28 19:46:34 +02:00
James Cammarata
50cd3a4a8f Make sure values are integers for certain hardware items for vpshere_guest
Fixes #7180
2014-04-28 11:40:00 -05:00
James Cammarata
a482e1583d Merge branch 'fix_user_non_root_on_rhel' of https://github.com/mscherer/ansible into mscherer-fix_user_non_root_on_rhel 2014-04-28 10:47:36 -05:00
Michael Scherer
28c373da0c Do not fail if we try to generate a ssh key for a user without being root
If we try to use the user module without being root, it fail on RHEL/Fedora
because usermod --help cannot be run. The root cause is lack of permission
due to EAL4+ certification, as seen in shadow-utils changelo.

So if we cannot run it, assume there is no append. It doesn't matter
much since we will not be able to run usermod at all with or without the
option.
2014-04-28 12:29:57 +02:00
Skyler Leigh Amador
a8d9470938 Remove --timeout option to rsync from synchronize defaults
The current 10-second default timeout for rsync seems to be behind issue #6809.

As a workaround for the underlying issue in rsync when different versions are
used on the source and destination sides, don't include the timeout option
unless the user specifies a timeout > 0.
2014-04-27 20:21:54 -07:00
Michael DeHaan
2ea386fe04 Merge pull request #7168 from jjshoe/fix_apache2_module_docs
Fix example
2014-04-27 16:28:31 -04:00
Joel Schuweiler
7916545979 Fix example 2014-04-27 12:16:51 -05:00
Joel Schuweiler
5bad971873 Finish reverting #b73cddc 2014-04-27 09:36:13 -05:00
jjshoe
a34478d6f3 Ensure the validation string has %s in it 2014-04-27 09:30:36 -05:00
Brian Brazil
d25f1dc2d0 Use empty string rather than None to avoid TypeError
Improve error messages.
2014-04-25 13:30:19 +01:00
mkosmach
fbf3b78ace add simplejson as alternative to json 2014-04-25 02:44:51 -07:00
Ben Holloway
e45d33954b documentation fix 2014-04-24 17:58:39 -06:00
Ben Holloway
4596521147 attempt to set availability_zones to all if neither availability_zones or vpc_identifier are set 2014-04-24 17:56:26 -06:00
Bruce Pennypacker
dc912ca201 removed unwanted 'if wait else None' 2014-04-24 20:41:51 +00:00
Ben
5a39672efa documentation fix availability_zones should be required for ec2_asg 2014-04-24 11:56:25 -06:00
Ben
30b634eae9 updated example to include instance_type 2014-04-24 11:50:49 -06:00
Ben
9770c7f47d Added instance_type to ec2_lc variable list 2014-04-24 11:47:41 -06:00
Michael DeHaan
31f7a0693e Add missing license headers to two modules and standardize formatting of another. 2014-04-24 10:32:54 -04:00
James Cammarata
89fa9b7305 Add parameters to get_url for the url username/password
Fixes #6928
2014-04-24 00:26:50 -05:00
James Cammarata
83f300ddd6 Merge branch 'apt_key_format' of https://github.com/andreasf/ansible into andreasf-apt_key_format 2014-04-24 00:02:10 -05:00
James Cammarata
3f1545f9db Fixing the version_added string in the vsphere_guest module 2014-04-23 22:46:14 -05:00
James Cammarata
833ceeca24 Merge branch 'vmware_core' of https://github.com/rhoop/ansible into rhoop-vmware_core 2014-04-23 21:12:40 -05:00
James Cammarata
2bc640c82f Merge pull request #7141 from lamby/devel
Correct/update debconf examples - need to specify vtype.
2014-04-23 21:09:52 -05:00
npeters
61bb40c0dd Remove invalid variable 2014-04-24 01:12:55 +02:00
Ben Whaley
1c996085ff Updated to use fetch_url 2014-04-23 15:26:13 -07:00
James Cammarata
16874464e9 Merge pull request #7047 from joshuaconner/docker_bugfix_exclude_entrypoint_from_command_check
docker: exclude 'entrypoint' from comparing 'command' param with containers
2014-04-23 16:14:48 -05:00
James Cammarata
46c0eb2f3e Merge pull request #7022 from jjshoe/patch-1
apt_key lists all keys in uppercase
2014-04-23 15:58:23 -05:00
Richard Hoop
578ba471b1 Author 2014-04-23 16:53:12 -04:00
Chris Lamb
446765ace0 Correct/update debconf examples - need to specify vtype.
Signed-off-by: Chris Lamb <chris@chris-lamb.co.uk>
2014-04-23 21:51:01 +01:00
James Cammarata
060e2193a1 Merge pull request #6991 from joshuaconner/bugfix_dont_send_wrong_params_to_dockerclient_start
Docker: don't send wrong parameters to client.start()
2014-04-23 15:48:04 -05:00
Richard Hoop
07ad8432ec Ready for pull request 2014-04-23 16:44:49 -04:00
Richard Hoop
5692ae95ab Core complete 2014-04-23 15:26:03 -04:00
James Cammarata
eb090ad4a2 Merge pull request #6599 from dmage/nova_region_name
use region_name in nova_compute
2014-04-23 10:15:57 -05:00
James Cammarata
24cfcd1f88 Merge pull request #6985 from jimi-c/issue_6763_ec2_vpc_params
Ensure params were set in ec2_vpc before accessing them
2014-04-23 10:08:50 -05:00
Brian Coca
f079d022a3 now when making multiple dirs in path to make dir, same permissions are assigned (but only for NEW dirs)
Signed-off-by: Brian Coca <briancoca+ansible@gmail.com>
2014-04-23 10:38:38 -04:00
James Cammarata
ed1c7a0f5d Merge pull request #7128 from stansonhealth/improve_tag_docu
update ec2_tags documentation to include missing option
2014-04-23 09:31:42 -05:00
Erika Heidi
036c7a7759 Possible docs error: 'path' instead of 'src'
I came to this example today (line 50), and when I tried it, I got an error:

`msg: src and dest are required for creating links`

So, I changed **path** to **src** and it worked fine. Looks like the example is wrong, since the docs say "dest" is already an alias for "path", in which case we would have 2 "path" definitions.
2014-04-23 16:00:22 +02:00
Richard Hoop
68d45a6484 Started reconfigured 2014-04-23 09:53:12 -04:00
Ted Timmons
b5895712b3 update documentation to include missing option
'list' was added more recently, it was omitted from the documentation.
2014-04-23 08:44:43 -05:00
Richard Hoop
630367ebfc Creation complete 2014-04-22 17:12:23 -04:00
Richard Hoop
3e75e504e0 More config checks and clean up for vm_config settings 2014-04-22 16:20:04 -04:00
Bruce Pennypacker
2be8feebce Changed behavior of deregister. If an instance is not found in the ELB then simply return 'changed=false'. Otherwise always remove the instance from the ELB no matter what state its currently in. 2014-04-22 18:44:41 +00:00
James Cammarata
d88ac5e24d Merge pull request #7076 from mscherer/better_message_service
Add a better error message for service
2014-04-22 08:44:14 -05:00
Mike Buzzetti
4cb41de987 Updated and corrected example section 2014-04-22 09:27:26 -04:00
Michael Heca
9ad6511be7 module docker - add docker version comment
Default docker version 0.9.1 from Ubuntu 14.04 LTS don't report APIVersion.
2014-04-22 12:21:51 +02:00
Michael Scherer
43d0fbd342 Add a better error message for service
While migrating my playbook to a newer ansible version, I faced
the error message "unknown init system, cannot enable service". It turned
out to be caused by a wrong service name that was not expanded anymore.

So by giving the name of the service that cannot be enabled and a more precise
reason, i think people will be able to diagnose their issue more easily.
2014-04-22 09:13:57 +02:00
Mike Buzzetti
b2c5106833 Adding support for purging subnets 2014-04-21 21:42:05 -04:00
Richard Hoop
06c64785fb Large cleanups. Reintegrating all modules together for a guest 2014-04-21 16:38:31 -04:00
James Cammarata
149339f620 Merge pull request #7089 from dagwieers/debug-docs
Add an example to show all hostvars using debug
2014-04-21 12:11:39 -05:00
James Cammarata
53754357f7 Merge pull request #7096 from CaptTofu/docker
Small bug - 'acts' should be 'facts'
2014-04-21 11:49:26 -05:00
James Cammarata
afee14173e Merge pull request #7095 from radeksimko/pokemon-exc-fix
Prevent catching unrelated exceptions
2014-04-21 11:49:04 -05:00
CaptTofu
2990db728a Small bug - 'acts' should be 'facts' 2014-04-21 08:06:00 -07:00
Radek Simko
1513d2bd64 Prevention for catching unrelated exceptions added 2014-04-21 15:35:49 +01:00
Radek Simko
8bdd96b273 Explicit check of return code for autoinstallation of python-apt added
This will allow easier debugging through more meaningful error message.
2014-04-21 14:10:09 +01:00
Dag Wieers
3c15d64655 Add an example to show all hostvars using debug
This is a useful example to help debug how facts and vars are being collated.
2014-04-21 11:40:53 +02:00
Bruce Pennypacker
b57887bafd Fix for https://github.com/ansible/ansible/issues/7054 - when renaming an instance and waiting for the change to occur, force result.id to the name of the new instance so the subsequent call to get_current_resource succeeds. 2014-04-18 17:56:11 +00:00
Michael Heca
4271613aa5 module docker_image - default tag latest
Fix constant rebuild of image if no tag specified.
2014-04-18 16:14:12 +02:00
Mike Buzzetti
5dada9403e Adds support for VPC subnets to ELB 2014-04-18 09:59:35 -04:00
Joshua Conner
4defd9a15a docker: exclude 'entrypoint' from comparing 'command' param with containers
The JSON the Docker API returns includes the container's ENTRYPOINT value (if it has one) with the 'Command' value. So instead of checking if `container['Command'] == module.params['command']`, we just check that `container['Command'].endswith(module.params['command'])` so the entrypoint won't affect a container being properly classified as matching the module params or not.

Also I refactored a super-long `if` statement into some temporary variables - I did it to help me figure out what was going wrong, and then it makes the code more readable so I kept it.
2014-04-17 16:10:53 -07:00
Joshua Conner
10171dc42b docker: send 1.10 params if docker-py is new enough version 2014-04-17 16:05:50 -07:00
James Cammarata
1ef0402f03 Make sure a default allow out rule exists if no other egress rules do
Fixes #7027
2014-04-17 15:24:18 -05:00
Chad Nelson
ef1a8e4cdd Only update submodules when recursive is true 2014-04-17 09:34:36 -04:00
Andreas Fleig
337a0059d9 apt_key: fix key lookup for 64 bit key ids
Fixes #7018 by extending `all_keys` to work with either short or long keys.

Also removes the ununsed method `key_present`.
2014-04-17 03:51:19 +02:00
Matt Bray
3948dc2d1d docker.client.APIError has moved to docker.errors.APIError
see 18d4db09ec
2014-04-16 23:42:56 +01:00
Andrew Newdigate
761e1c0daa Added additional error checking to avoid HTTP400 responses from ansible. 2014-04-16 23:00:01 +01:00
Andrew Newdigate
2ed83b9d70 Removing unused code 2014-04-16 22:44:34 +01:00
Andrew Newdigate
265d9adbb9 Merge branch 'devel' of github.com:ansible/ansible into devel
Conflicts:
	library/monitoring/pagerduty
2014-04-16 22:43:01 +01:00
James Cammarata
a37a84243b Check resource_tags value before using it in ec2_vpc
Fixes #7024
2014-04-16 12:21:32 -05:00
Brian Brazil
8ec400669f Fix race conditions where a process gets in state "Running"
between the restart/start command and the summary command.

Refactor to avoid repeating the status, and fail if a given call to monit fails.
2014-04-16 18:04:19 +01:00
James Cammarata
f9eb0ba4ad Merge branch 'devel' of https://github.com/evanccopengeo/ansible into evanccopengeo-devel 2014-04-16 10:24:39 -05:00
jjshoe
5258f75789 apt_key lists all keys in uppercase
allow for a little user error
2014-04-16 10:06:59 -05:00
Michael Heca
a1706e6411 module replace - report changed only if contents is changed 2014-04-16 09:25:56 +02:00
Hernandes B. de Sousa
202fc57253 Add missing info for the append option
Both 'default' and 'choices' options were missing at the documentation.
2014-04-16 01:22:12 -03:00
James Cammarata
e8b33636ae Get the bin path for commands in the unarchive module
Fixes #6927
2014-04-15 20:39:22 -05:00
evanccopengeo
ac64f3c8cf cleaning up the code a bit more 2014-04-15 18:16:34 -04:00
evanccopengeo
88b30a74d2 fixing bug where if both private_ip and assign_public_p are set ansible fails out 2014-04-15 17:55:26 -04:00
James Cammarata
f547733b1f Check to make sure the firewalld client is connected before proceeding
Fixes #6911
2014-04-15 15:03:52 -05:00
Cédric RICARD
3384021fe6 Fixed test on 'cached' parameter.
'cached' parameter is boolean, not string
2014-04-15 16:41:27 +02:00
Joshua Conner
0ef288dcc8 Docker: don't send wrong parameters to client.start()
As part of being updated for the 1.10 API, a couple of parameters were passed to the docker.client.start() command that it doesn't accept. This caused the module to error out if it tried to start any Docker containers. This removes those parameters so the module works again.
2014-04-14 15:05:42 -07:00
James Tanner
6ec0e25d1a Addresses #6908 Add a mode parameter to apt_repository 2014-04-14 16:42:23 -04:00
James Tanner
28cb4756c4 Remove debug line 2014-04-14 16:02:08 -04:00
James Tanner
db36c41c3b Addresses #6908 Strip usernames and passwords from apt_repository filenames 2014-04-14 13:18:21 -04:00
James Cammarata
46ea3155c6 Ensure params were set in ec2_vpc before accessing them
Fixes #6763
2014-04-14 10:58:07 -05:00
Chris Conway
b9af8ea1d0 Adds version_added property to new attributes in gce and gce_pd. 2014-04-14 08:33:45 -07:00
Michael DeHaan
537320774a Merge pull request #6952 from nousdefions/devel
Added example demonstrating other functionality
2014-04-14 11:32:44 -04:00
Michael DeHaan
bc2b4174a5 Merge pull request #6956 from mattjbray/docker-1-10-volumes-from-dns
docker: from API 1.10 dns and volumes_from should be passed to start()
2014-04-14 11:29:10 -04:00
Chris Conway
2257a69723 Adds support for attaching persistent disks to GCE instances 2014-04-13 18:38:31 -07:00
Chris Conway
d227330a55 Adds support for creating GCE persistent disks from snapshots 2014-04-13 18:38:31 -07:00
Chris Conway
0b45b1256d Adds support for creating GCE persistent disks from images 2014-04-13 18:38:31 -07:00
Ben Whaley
6c10297b2d Stackdriver code deploy and annotation module 2014-04-12 00:56:32 +00:00
Michael J. Schultz
db92301b00 cloud/elasticache: Ensure self.data is iterable
- self.data['SecurityGroups'] can return None causing traceback, if that
  is the case fallback to an empty list
2014-04-11 18:23:53 -05:00
Matt Bray
71b5a11735 docker: from API 1.10 dns and volumes_from should be passed to start() 2014-04-11 17:08:55 +01:00
James Tanner
b0556ab1fb Addresses #6702 Remove version_added from description string 2014-04-11 11:18:05 -04:00
Jonathan Davila
6a6ade830e Added example demonstrating other functionality 2014-04-11 11:14:40 -04:00
James Tanner
42fbbd0502 Addresses #6702 set version_added for rsync_opts 2014-04-11 11:04:05 -04:00
jctanner
bb3ce0c744 Merge pull request #6702 from jjshoe/devel
Allow you to pass in arbitrary rsync options
2014-04-11 10:43:14 -04:00
James Tanner
dfdc3b82a0 Fixes #6929 remote file module doc fragments from copy and template 2014-04-10 16:06:35 -04:00
Constantine Peresypkin
e834b23060 fix issue #6932
add `git remote set-url` before fetch to set the remote repo to the new url, if provided
2014-04-10 14:13:23 +03:00
Eugene Brevdo
8e32f54223 VPC security group membership fix for boto.
* facts now provides a list of existing vpc security group memberships
* adding a comma separated list of sg-* tags properly modifies membership
2014-04-09 13:32:47 -07:00
Will Thames
e7b275483c Use common code for ec2_elb and ec2_elb_lb
Uses the new get_aws_connection_info
and connect_to_aws common methods to reuse code

Now complains if region is not set in one of the
three possible methods

Also moved over to common documentation code so
this is actually based on #6913
2014-04-09 22:47:51 +10:00
willthames
509561f658 Moved AWS modules over to common module fragments
Created common module doc fragment, and applied to all
modules that use ec2_connect or connect_to_aws as
they definitely share the common doc fragments
2014-04-09 21:19:12 +10:00
James Tanner
68cd7258b6 Fixes #6894 create docs fragment for files 2014-04-08 13:20:15 -04:00
James Tanner
899ba4c9bb Fixes syntax error in cron module caused by #6870 2014-04-08 12:53:56 -04:00
James Cammarata
567f3819b1 Fixing newline escapes in lineinfile
Fixes #5679
2014-04-08 11:42:29 -05:00
James Cammarata
26ce8dac27 Fix incorrect version_added value in docstring for subversion export param 2014-04-08 10:26:12 -05:00
James Tanner
6d54eae96a Fix version_added for node in rabbitmq modules 2014-04-08 10:40:41 -04:00
James Tanner
7c9243eacf Fix version added for new parameters in quantum modules 2014-04-08 10:32:53 -04:00
James Tanner
c29cca6f86 Fix version added for annotation in pkgng 2014-04-08 10:28:01 -04:00
James Tanner
db90f308ca Fix version_added for login_tenant_name in keystone_user 2014-04-08 10:25:44 -04:00
James Tanner
5308c5dbdf Fix version_added for install_options in homebrew 2014-04-08 10:13:33 -04:00
James Tanner
03f99a57b7 Fix version_added for new params in gce_pd 2014-04-08 10:05:57 -04:00
James Tanner
d37f609e00 Fix version_added for new params in gce_net 2014-04-08 10:03:56 -04:00
James Tanner
387414fe29 Fix version_added for new params in gce_lb 2014-04-08 10:00:30 -04:00
James Tanner
34648426ba Set version_added for snapshot in ec2_vol 2014-04-07 23:10:24 -04:00
James Tanner
66747529a6 Fix version_added for a few parameters in django_manage 2014-04-07 22:57:49 -04:00
James Tanner
325bbf7dee Fix version_added for url in airbrake_deployment module 2014-04-07 22:30:53 -04:00
Michael DeHaan
dfa8aef408 Merge pull request #6850 from atlashealth/ec2_set_ebs_optimized
ec2: added ability to set EBS optimized instances
2014-04-07 15:57:34 -04:00
Michael DeHaan
cd1cd2060b Merge pull request #6869 from cove/mongodb_user
add replica_set attr to mongodb_user module
2014-04-07 13:57:28 -04:00
Michael DeHaan
3f89c3a3cc Merge pull request #6883 from ericlake/devel
Adding bold to service doc to call up state and enabled.
2014-04-07 13:39:28 -04:00
James Tanner
b2701d0d76 Fixes #6780 Update version_added for source_dest_check in ec2 module 2014-04-07 12:44:34 -04:00
James Cammarata
b73cddc485 Revert "Fix #5679 again after recent changes in core"
This reverts commit 2bfaacd170.

Fixes #6821
2014-04-07 09:55:59 -05:00
Eric Lake
e84291d717 Adding bold to service doc to call up state and enabled. 2014-04-07 09:37:15 -05:00
James Cammarata
085d9aee72 Merge branch 'rax-clb-nodes-nodeid' of https://github.com/sivel/ansible into sivel-rax-clb-nodes-nodeid 2014-04-07 07:40:05 -05:00
Matt Martz
8a98773089 Simplify node matching 2014-04-06 19:17:13 -05:00
Atlas Health
97a7df7644 moved ebs_optimized param out of main request hash 2014-04-06 15:35:22 -07:00
MorrisA
4dc46e9061 Modified Cron to add AIX Crontab support, changed according to suggestions
from mpdehaan and redone entirely.
2014-04-05 18:10:45 -07:00
Cove Schneider
6a321fe346 re-add idempotency check 2014-04-05 16:31:33 -07:00
Cove Schneider
6e81f41cd4 add replicaset support to mongodb_user module 2014-04-05 15:33:22 -07:00
Michael DeHaan
4d2b7d6341 Merge pull request #6864 from sivel/rax-add-shared-mod-docs
Shared module docs for remaining rax modules
2014-04-05 15:16:11 -04:00
James Tanner
036c8193b7 Fixes #6857 Make the url parameter required for get_url 2014-04-04 16:36:38 -04:00
Matt Martz
55a26fa9ed Shared module docs for remaining rax modules 2014-04-04 13:02:49 -05:00
Matt Martz
e821770505 Allow respecification of a node without requiring node_id 2014-04-04 12:41:57 -05:00
Matt Martz
5eace5f718 Return untouhced servers with exact_count 2014-04-04 12:15:35 -05:00
Michael DeHaan
466ab0a9d6 Merge pull request #6852 from tedder/patch-1
cloudformation's disable_rollback must be a bool
2014-04-04 12:14:03 -04:00
Ted Timmons
d544eb3e3b cloudformation's disable_rollback must be a bool
passing "yes" to boto causes severe problems.
2014-04-04 08:00:56 -07:00
Serge van Ginderachter
2dfee9d0a7 lvg module bugfix on vg_options patch
When no vg_options are passed to the module, 'vg_options' still exists
in the module.params dict with a value of None, so the default empty string in
the get method is never used. None cannot be "splitted", which backtraced.
2014-04-04 15:32:35 +02:00
Drew Blas
2e26549426 Update apt:deb with correct version
The docs site says this option is available in 1.5, but it is not.  

#5910 https://github.com/ansible/ansible/pull/5910 added the deb option.  The PR was generated two months ago (before 1.5) but was not included until after 1.5 was released.  This fixes the docs.
2014-04-04 05:59:57 -05:00
Michael DeHaan
621fcbb9de Name is not required, update docs. 2014-04-03 18:03:13 -04:00
Michael DeHaan
2518ec2b86 Merge pull request #6849 from atlashealth/ec2_snapshot_fixed_type_issue
ec2_snapshot: fix for "unknown type number requested for wait_timeout"
2014-04-03 18:01:22 -04:00
Michael DeHaan
b4c500634d Merge pull request #6793 from muffl0n/patch-4
apt_key: Output URL for debugging
2014-04-03 17:35:49 -04:00
Michael DeHaan
051d57caeb Clarify free_form isn't a real option :) 2014-04-03 17:34:33 -04:00
Richard C Isaacson
dc93b31d22 assemble module: fix insertion of newlines when not needed.
This builds on GH-6359 and changes the logic so that a newline is only inserted between fragments if the previous fragment does not end with a newline.
2014-04-03 16:32:35 -05:00
Peter Gehres
3ac731087c Fix for #6353 adding a newline between assembled files 2014-04-03 16:32:35 -05:00
Matt Martz
37f096a6bb rax modules improvements
* Catch issues with invalid regions
* Ensure we send string only data as meta values in the rax module
* Add public_key/lookup example for rax_keypair
* Clean up import statements
2014-04-03 17:16:24 -04:00
Michael DeHaan
1fa19e29e8 Use common file argument system previously implemented by @sivel for rax modules on the file modules as well (copy/file/template).
Application to other cloud providers would make very good sense.
2014-04-03 16:52:39 -04:00
Matt Martz
7b5f89ec7c Use PluginLoader for module docs fragments 2014-04-03 16:52:39 -04:00
Matt Martz
bb6f7a267a Add support for shared module documentation fragments 2014-04-03 16:52:39 -04:00
Atlas Health
2657bbcefa ec2: added ability to set EBS optimized instances
added version
2014-04-03 12:38:43 -07:00
James Tanner
1c9950678a Addresses #6750 Use --help instead of - 2014-04-03 15:26:48 -04:00
Atlas Health
7321e23b31 fixed error related to type being defined as a number 2014-04-03 12:24:05 -07:00
James Tanner
cca028187e Fixes #6750 Check git subcommand for --remote and expose errors 2014-04-03 15:21:54 -04:00
James Tanner
b660062801 Fixes #6454 verify ec2 key fingerprints 2014-04-03 13:53:43 -04:00
Gael Pasgrimaud
1fc4b89e64 Fix a typo in the subversion module documentation 2014-04-03 14:34:43 +02:00
Atlas Health
98edfa46c6 ec2: ability to list existing volumes 2014-04-03 02:39:07 -07:00
Michael DeHaan
2fd6d16f99 Merge pull request #6831 from aresch/patch-1
Fix _parse_value always returning 0 when not true, false or None.
2014-04-02 20:09:41 -04:00
Michael DeHaan
7db7e86db9 Merge pull request #6830 from angstwad/cf-fix
rax_files fix -- small idempotency fix
2014-04-02 19:18:42 -04:00
Paul Durivage
3763b32f86 Fix issue where a container is created but is not indicating that the state was changed 2014-04-02 18:05:36 -05:00
Andrew Resch
cd12d8a917 Fix _parse_value always returning 0 when not true, false or None. 2014-04-02 15:59:05 -07:00
Joshua Lund
79c245f31f Update cron module documentation. The 'name' parameter is required. 2014-04-02 16:41:09 -06:00
Michael DeHaan
90c137dea3 Slightly revise wording. 2014-04-02 17:43:40 -04:00
Michael DeHaan
dff5368e43 Merge branch 'authorized_key-manage_dir' of git://github.com/tyll/ansible into devel 2014-04-02 17:42:24 -04:00
Michael DeHaan
a4bce09ad1 Clarify docs message. 2014-04-02 17:37:10 -04:00
Michael DeHaan
19437aad0b Merge pull request #6798 from follower/patch-5
Clarify the port value always defaults to 3306
2014-04-02 17:34:33 -04:00
Michael DeHaan
18b713fd74 Example cleanup. 2014-04-02 17:32:44 -04:00
Michael DeHaan
5269216c41 Merge branch 'patch-3' of git://github.com/muffl0n/ansible into devel 2014-04-02 17:30:29 -04:00
Michael DeHaan
0981e405d6 Merge pull request #6810 from bob-smith/debconf-text
debconf detail requirements and fix typos
2014-04-02 17:25:22 -04:00
Michael DeHaan
0125f36c49 Merge pull request #6796 from mistaka0s/mysqldump_fix
Remove extra quote from the mysqldump password argument
2014-04-02 17:24:35 -04:00
Michael DeHaan
12022233f4 Merge pull request #6770 from lemonlatte/fix_default_uri_of_get_xml
Fix the default url of get_xml function.
2014-04-02 17:23:22 -04:00
Michael DeHaan
3ba01cac3c Note that keyserver was added in 1.6 2014-04-02 17:18:14 -04:00
James Cammarata
eb15d2f6fe Fix issue with sysctl parameter parsing introduced by 0e8c7b1
Fixes #6806
2014-04-02 15:26:02 -05:00
Michael DeHaan
71061479a0 Merge pull request #6826 from bob-smith/debconf-parsing
debconf correctly quote strings
2014-04-02 16:14:17 -04:00
James Cammarata
684d46b170 Fixing some parsing issues in authorized_key module
Also adds an integration test for authorized_key for future validation.

Fixes #6700
2014-04-02 15:02:54 -05:00
John Barker
b8efbb1cb3 debconf correctly quote strings 2014-04-02 20:43:12 +01:00
Michael DeHaan
f50a943064 Merge pull request #6803 from aresch/patch-1
redhat_subscription calls AnsibleModule() without argument_spec
2014-04-02 11:40:57 -04:00
Oleg A. Mamontov
933fb349f1 Fixed cwd for submodules update 2014-04-02 13:21:26 +04:00
James Cammarata
ba4838cde5 Adding wait/wait_timeout parameters to the ec2_key module
Fixes #6455
2014-04-01 22:14:35 -05:00
John Barker
f89262c74f debconf detail requirements and fix typos 2014-04-01 21:51:12 +01:00
jctanner
6a1dcca4be Merge pull request #6805 from sivel/env-interpreter-fix
Fix interpreter lines in a couple of modules
2014-04-01 15:03:20 -04:00
Matt Martz
b4de76373a Use /usr/bin/python instead of /usr/bin/env python 2014-04-01 13:54:37 -05:00
Andrew Resch
c92ec68fa3 redhat_subscription calls AnsibleModule() without argument_spec
The Rhsm object requires an AnsibleModule but it isn't created with an argument_spec and fails.  Since the rhn.module is set directly after, setting None for the required argument of Rhsm fixes the module.
2014-04-01 11:22:29 -07:00
follower
4be010b09b Clarify the port value always defaults to 3306
While the [boto docs](https://github.com/boto/boto/blob/develop/boto/rds/__init__.py#L253) make it seem like the default value of `port` is changed depending on the engine chosen, AFAICT from looking at the code the default value is never changed from 3306.

I think the docs are intended to be read as "the default value used by <engine> is <port> so you should change `port` to that value".

If you don't specify the port value and chose the database engine as PostgreSQL you'll end up with a PostgreSQL instance running on port 3306.
2014-04-02 02:25:14 +13:00
Chao Luan
134c449cf6 Remove extra quote from the mysqldump password argument
The mysqldb Ansible module will fail if the state specified is import or dump with a '1045: Access Denied' mysql error for complex passwords.

This is caused by the extra quote around the '--password' argument to mysqldump, as pipes.quotes already quotes the password string.

>>> "--password='%s'" % pipes.quote('simple')
"--password='simple'"

>>> "--password='%s'" % pipes.quote('c0mplexp@ssword!')
"--password=''c0mplexp@ssword!''"

>>> "--password='%s'" % pipes.quote('password with space')
"--password=''password with space''"
2014-04-01 23:52:08 +11:00
jjshoe
2387f044e4 module_retention isn't defined anywhere, including the help. 2014-04-01 07:49:51 -05:00
follower
618554ad63 Make vpc_security_group docs more accurate
Without the `subnet` parameter supplied there's an error `msg: Parameter vpc_security_groups invalid for create command`. (This might be a bug?)

If the VPC security group name rather than ID is supplied there's an error: `msg: Invalid security group , groupId= <some group name>, groupName=.` (Accepting a group name might be a feature enhancement.)

In my case I set the subnet as `default` and used `register` to get the result of the security group creation section and just referred to its `group_id` property.
2014-04-02 01:06:45 +13:00
Sven Schliesing
c8e80b2aa4 Output URL for debugging 2014-04-01 13:55:58 +02:00
Tim G
dbf412b77c Bugfix, fix crontab commands on HP-UX 2014-04-01 21:09:08 +10:00
James Tanner
c751168895 Fix merge conflicts 2014-03-31 13:15:21 -04:00
James Tanner
9fe2bcd076 Merge #5903 from rhaido/ansible
Update files documentation for usage of force=True and hardlinks
2014-03-31 12:53:03 -04:00
Jonathan Mainguy
8928a5ede1 Added mpdehaan suggestion to use os.path.splitext. Wise suggestion, does look clearner 2014-03-31 11:09:00 -04:00
Michael DeHaan
9ca9b9fe07 Merge pull request #6768 from mscherer/fix_typo_caps
fix typo in the capabilities module description
2014-03-31 09:34:25 -04:00
Sven Schliesing
fb10ca73dc Update uri 2014-03-31 14:32:56 +02:00
Sven Schliesing
d6943e46ef Example for queueing build in Jenkins 2014-03-31 14:32:07 +02:00
James Cammarata
225eca6311 Adding an options sections to the docstring in the lldp module 2014-03-30 23:08:53 -05:00
Jim Yeh
48dc27ea74 Fix the default url of get_xml function.
* This enable a user to configure uri in get_xml function
2014-03-31 11:05:31 +08:00
James Tanner
6792c76c50 Fix librato_annotation docstring 2014-03-30 22:28:31 -04:00
Michael Scherer
2dc3153330 fix typo in the capabilities module description 2014-03-30 22:33:24 +02:00
Matt Way
034ac93ca2 don't parse empty stream chunks 2014-03-30 15:27:29 -04:00
James Laska
f96618c967 Use proper YAML quotes to fix webdocs 2014-03-30 14:26:18 -04:00
Jonathan Mainguy
bb73819c43 mysql_db module now correctly fails on import if bz2 or gz fails. 2014-03-30 13:39:00 -04:00
Michael DeHaan
2f75662a47 Merge pull request #6758 from cgtx/devel
backreferences should be double escaped
2014-03-30 11:59:06 -04:00
James Cammarata
1b3f77fafd Merge pull request #6759 from Malvineous/devel
More descriptive error message if init system is unknown
2014-03-30 01:37:17 -05:00
James Cammarata
6e809c2be3 Removing wait loop around initial state check during registration
Also fixed a bug in which the state parameter was marked as a 'bool'
type, which was breaking execution of the module.

Fixes #6543
2014-03-29 23:47:11 -05:00
Adam Nielsen
1a9c5947ed More descriptive error message if init system is unknown 2014-03-30 11:46:13 +10:00
James Laska
6c8d8a746f Fix YAML docstring that broke webdocs 2014-03-29 19:15:42 -04:00
cgtx
f6abc17e8a backreferences should be double escaped 2014-03-29 18:14:56 -05:00
Ahti Kitsik
e0f3105ef9 Bugfix for ufw to support "logging" properly:
It's a separate parameter so updated docs and set it as mutually exclusive param.
Also due to an array construction typo it was not working in any situation (ufw LOGLEVEL was passed to cmd instead of ufw logging LOGLEVEL).

Also fixed doc and parameters parsing typo ("choises" should be "choices")
2014-03-29 11:06:51 +02:00
Daniel Jaouen
7f6d2a94af Miscellaneous fixes to homebrew module. 2014-03-28 19:37:05 -04:00
Daniel Jaouen
6412bdf003 Update homebrew module. 2014-03-28 19:20:51 -04:00
Michael DeHaan
4dc598049e Merge pull request #6746 from Jmainguy/svr4pkg
svr4pkg changes - Did my best to rebase. Now includes the latest changes made to devel, al...
2014-03-28 18:50:29 -04:00
Michael DeHaan
6c6523aa1b Merge pull request #6747 from ciupicri/cloud-bugfix
Bugfix for gc_storage and s3
2014-03-28 18:48:14 -04:00
Michael DeHaan
c308b98742 Merge branch 'intellectronica/non-recursive-git' of git://github.com/intellectronica/ansible into devel
Conflicts:
	library/source_control/git
2014-03-28 17:49:02 -04:00
Michael DeHaan
ae1b183855 Add LLDP module 2014-03-28 17:41:58 -04:00
Andy Hill
5b5f2e6d45 lldp: Added EXAMPLES 2014-03-28 17:41:58 -04:00
Andy Hill
8ca70ec487 lldp support in Ansible
This PR introduces support for a lldp module.

lldpd is similar to CDP and can return useful details about a server's network like ports, switches, and VLANs.
2014-03-28 17:41:58 -04:00
Michael DeHaan
c24d4acb2a Documentation fixes + add missing license header 2014-03-28 17:20:20 -04:00
Seth Edwards
cb97599a97 add librato annotation module 2014-03-28 17:20:20 -04:00
Michael DeHaan
2d116aca5e Add version_added info + changelog 2014-03-28 17:11:21 -04:00
Christian Berendt
9a1c1d3242 use module.get_bin_path() for a2enmod 2014-03-28 17:10:15 -04:00
Christian Berendt
b8a8e9fbec removed duplicated <<INCLUDE_ANSIBLE_MODULE_COMMON>> line 2014-03-28 17:10:15 -04:00
Christian Berendt
c958c301ae added module to enable/disable Apache2 modules
This module uses a2enmod or a2dismod to enable or disable
Apache2 modules.
2014-03-28 17:10:15 -04:00
Michael DeHaan
cc6d4bc3f0 changelog and version bump 2014-03-28 17:04:31 -04:00
Michael DeHaan
bba91c7f26 Merge branch 'add_rollbar_rollbar_deployment_module' of git://github.com/kavu/ansible into devel 2014-03-28 17:03:59 -04:00
Michael DeHaan
372c4e6d31 Changelog and version updates. 2014-03-28 17:01:15 -04:00
Michael DeHaan
9e07ff79d7 Merge branch 'layman' of git://github.com/jirutka/ansible into devel 2014-03-28 17:00:52 -04:00
Cristian Ciupitu
d89d2432fd Bugfix for gc_storage and s3
Make keysum return None if not key_check (this case wasn't covered).
2014-03-28 22:47:46 +02:00
Jonathan Mainguy
bef544dd0f Did my best to rebase. Now includes the latest changes made to devel, along with my change of adding category option to module 2014-03-28 15:35:52 -04:00
Michael DeHaan
e6ab2d83b8 Merge pull request #6081 from alexanderpopov1/ec2_vpc-subnet-tagging
Added support for tagging subnets in ec2_vpc module
2014-03-28 15:27:59 -04:00
Michael DeHaan
9190ddfcda Documentation updates / changelog. 2014-03-28 15:03:04 -04:00
Michael DeHaan
1f4e082c9d Merge branch 'added-logentries-module' of git://github.com/ivanvanderbyl/ansible into devel 2014-03-28 15:01:49 -04:00
Michael DeHaan
8baaf458c7 Repairs for documentation build. 2014-03-28 14:57:29 -04:00
Michael DeHaan
e02ae3476f Resolve merge. 2014-03-28 14:56:59 -04:00
Michael DeHaan
c1fbf80f70 Slight docs tweak, split lines according to code standards 2014-03-28 14:04:59 -04:00
Andrea.Mandolo
838b914a0d correct documentation comment and version_added in "synchronize" module 2014-03-28 14:04:59 -04:00
Andrea.Mandolo
c039dbe300 Add STDOUT lines in response of "synchronize" module 2014-03-28 14:04:59 -04:00
Andrea.Mandolo
f9ec53cdef Add "checksum" option support to 'synchronize' module 2014-03-28 14:04:59 -04:00
Michael DeHaan
5b5ab78183 Add version_added to docs. 2014-03-28 13:51:22 -04:00
Michael DeHaan
53ee1ea27c Merge branch 'aws-ec2-egress-rules' of git://github.com/mmoya/ansible into devel 2014-03-28 13:50:58 -04:00
Michael DeHaan
e05c86bb94 Merge pull request #6740 from mjschultz/add-sns-notification
Add Amazon SNS notification plugin
2014-03-28 13:37:09 -04:00
Michael DeHaan
dfbe35d4be Rename apt-rpm to apt_rpm. 2014-03-28 13:18:49 -04:00
Michael DeHaan
535b2ba64c Merge branch 'apt-rpm' of git://github.com/evgkrsk/ansible into devel 2014-03-28 13:17:37 -04:00
Michael DeHaan
e79171cbfb Merge branch 'devel' of git://github.com/leafnode/ansible into devel
Conflicts:
	library/packaging/apt_key
2014-03-28 13:15:06 -04:00
Alex Coomans
2de398b417 Allow setting env variables over .dnsimple file 2014-03-28 13:13:19 -04:00
Alex Coomans
a4372eafaa Add the dnsimple module 2014-03-28 13:13:19 -04:00
Michael DeHaan
5f14b6e637 Rename prerelease to pre_release. 2014-03-28 13:09:10 -04:00
Bob Zoller
e1a1ac1e76 gem module supports prerelease (--pre) 2014-03-28 13:09:10 -04:00
Michael DeHaan
78e5f6129f Documentation updates for supervisor module changes. 2014-03-28 13:07:13 -04:00
Michael DeHaan
b915390ec8 Merge branch 'supervisorctl-support-group' of git://github.com/inetfuture/ansible into devel 2014-03-28 13:04:21 -04:00
addshore
11895fa437 Add --remote to git submodule_update
This simply adds --remote to the git submodule update command.
This means that if a branch is defined in .gitmodules then we should track said branch when updating.
2014-03-28 13:01:39 -04:00
Michael DeHaan
7f7297f9ca Rename vgoptions to vg_options. 2014-03-28 12:53:36 -04:00
Michael DeHaan
b4bbdb2438 Merge branch 'devel' of git://github.com/chamill/ansible into devel
Conflicts:
	library/system/lvg
2014-03-28 12:53:00 -04:00
Michael DeHaan
8285ac5b31 Merge branch 'ec2_vpc-multiple-vpcs-support' of git://github.com/alexanderpopov1/ansible into devel
Conflicts:
	library/cloud/ec2_vpc
2014-03-28 12:51:40 -04:00
Michael DeHaan
53d03dc968 Merge branch 't-apt-list' of git://github.com/Elemecca/ansible into devel 2014-03-28 12:19:23 -04:00
Michael J. Schultz
c8a810df78 Add some failure handling for region and publish 2014-03-28 11:08:50 -05:00
Michael DeHaan
7db784687d Merge pull request #6486 from discordianfish/docker-module-add-running
Rename present to running, add new present state
2014-03-28 11:50:21 -04:00
Michael DeHaan
351aea4cb6 Merge pull request #6626 from brentley/devel
Allow custom hipchat urls
2014-03-28 11:49:37 -04:00
Michael DeHaan
8e27992335 Merge pull request #6649 from picsolvebryan/devel
Accept status code from a list of valid codes.
2014-03-28 11:49:04 -04:00
Michael DeHaan
09259cbd77 Merge pull request #6671 from dermute/svr4pkg-G
svr4pkg supports the -G switch for pkgadd
2014-03-28 11:42:46 -04:00
Michael DeHaan
0e8c7b1c03 Scrub choices=BOOLEANS from remaining core module references. Correct form in argument_spec is type='dict'. 2014-03-28 11:41:35 -04:00
Michael DeHaan
3312099e70 Merge branch 'ec2_snapshot' of git://github.com/hkariti/ansible into devel 2014-03-28 11:36:31 -04:00
Michael DeHaan
7519e33787 Merge pull request #6730 from sivel/rax-cbs-new
New modules: rax_cbs and rax_cbs_attachments
2014-03-28 11:28:46 -04:00
Michael DeHaan
344bbf3eea Merge pull request #6419 from willthames/aws-autoscaling-with-token-and-profile
Improvements to ec2 autoscaling modules
2014-03-28 11:26:53 -04:00
Michael DeHaan
e21f61d604 Merge pull request #6616 from willthames/ec2_vol_allow_delete
Allow state=absent for ec2_vol
2014-03-28 11:24:37 -04:00
Michael DeHaan
37efa1640f Merge branch 'update_docs_validate_cmd_not_passed_via_shell' of git://github.com/rwehner/ansible into devel
Conflicts:
	library/files/template
2014-03-28 11:21:41 -04:00
Joshua Conner
7a6c60b437 docker: use type instead of manually casting strings to lists 2014-03-28 11:19:48 -04:00
Joshua Conner
7bba229838 docker bugfixes: trim whitespace around list param elements, handle list params being coerced to int or long type 2014-03-28 11:19:13 -04:00
Michael DeHaan
2ddb251538 Merge pull request #6597 from tarka/handle-uncreated-symlink-tmpfile
Handle missing symlink tempfile
2014-03-28 11:11:32 -04:00
Michael DeHaan
0bec29a626 Merge pull request #6524 from tyll/update_rc_d_disable
service module: Properly disable Debian services
2014-03-28 11:10:46 -04:00
Michael DeHaan
2a656b2cf4 Merge branch 'devel' of https://github.com/drewblas/ansible into devel 2014-03-28 11:07:40 -04:00
Michael DeHaan
df3bb70797 Merge pull request #6630 from bigl0af/devel
Modified library/system/user so that password change date is set on Sola...
2014-03-28 10:57:59 -04:00
Michael J. Schultz
9fbef265bf Add Amazon SNS notification plugin
- Supports a default message or a special message for any of SNS's
protocols (email, sqs, sms, http, https)
  - http://docs.aws.amazon.com/sns/latest/dg/PublishTopic.html
2014-03-28 08:28:37 -05:00
Michael DeHaan
3b285d736c Merge pull request #6296 from jdauphant/devel
Add linux module parameters for the modprobe module
2014-03-27 17:12:21 -04:00
Cristian Ciupitu
96ff1444f0 Micro-optimization: replace s.find(x)==0 with s.startswith(x)
timeit shows a speedup of ~1.4x on Python 2.7.5 x86_64.
It also makes the code a bit shorter.
2014-03-27 20:35:20 +02:00
Cristian Ciupitu
1eaf85b89f Micro-optimization: replace s.find(x)!=-1 with x in s
timeit shows a speedup of ~3x on Python 2.7.5 x86_64.
It also makes the code a bit shorter.
2014-03-27 20:35:20 +02:00
Matt Martz
bb86443528 Implement recommendations from #4864 2014-03-27 12:59:08 -05:00
Ahti Kitsik
4d55f86f95 Fixed ufw module doc tags, it's reset everywhere, not reseted. 2014-03-27 17:22:39 +02:00
jjshoe
d57910b93a Allow you to pass in arbitrary rsync options. I also added help for it, and what version it was added in. 2014-03-27 08:00:20 -05:00
Michael DeHaan
cf434df6a4 Merge pull request #6707 from sivel/rax-extra-args
rax module: Support arbitrary extra args
2014-03-26 17:50:25 -04:00
Christopher H. Laco
972a27b14e Add Rackspace Cloud Block Storage modules
- Add rax_cbs to create/delete cloud block storage volumes
- Add rax_cbs_attachments to attach/detach volumes from servers
2014-03-26 14:42:22 -05:00
James Cammarata
e09313120c Make async jid's unique per host
The jid will now also contain the PID of the async_wrapper process,
and can each unique jid from each host is tracked rather than just
relying on one global jid per task.

Fixes #5582
2014-03-26 13:48:47 -05:00
Matt Martz
e093b216ff Support arbitrary extra args in rax module
Add extra_create_args and extra_client_args to rax module to support passing
advanced configuration options to client instantiation and server create calls.
2014-03-26 12:50:44 -05:00
Jeff Geerling
8960cba4a3 Fixed template validation docs and example. 2014-03-26 12:42:15 -05:00
Anton Lindström
71949fbc9f Make pip dry run work better for the common case
This change allows the pip module to figure out if something needs to be done during
a dry run using 'pip freeze'. This is implemented for the most basic case: name,
version and state=(present|absent). In other cases it will fall back to the old
behavior.
2014-03-26 15:48:21 +01:00
Hagai
436b59252c Added wait_timeout option 2014-03-26 16:18:25 +02:00
Hagai
c900254ed0 ec2_snapshot: Add wait' and snapshot_tags' parameters, return more
info on success
2014-03-26 16:18:25 +02:00
jjshoe
12c84dd6bd Show argument dependency
failed: [192.168.1.2] => {"cmd": "rsync --delay-updates -FF --compress --timeout=10 --delete-after --rsh 'ssh -i /home/jjshoe/.vagrant.d/insecure_private_key -o StrictHostKeyChecking=no' --rsync-path 'sudo rsync' --out-format='<<CHANGED>>%i %n%L' /tmp/app vagrant@192.168.1.2:/home/ubuntu/app", "failed": true, "item": "", "rc": 1}
msg: rsync: --delete does not work without --recursive (-r) or --dirs (-d).
rsync error: syntax or usage error (code 1) at main.c(1453) [client=3.0.9]
2014-03-26 08:32:55 -05:00
Alexander Winkler
69e09b048c version_added for the new parameters documentation 2014-03-26 10:25:42 +00:00
James Cammarata
19c92b3a42 Merge branch 'subversion_export' of https://github.com/maniaplanet/ansible into maniaplanet-subversion_export 2014-03-25 21:25:50 -05:00
James Cammarata
f2c06cadc3 Cleanup from merge of replace module and CHANGELOG update 2014-03-25 11:13:51 -05:00
James Cammarata
9775872f83 Merge branch 'devel' of https://github.com/EvanK/ansible into EvanK-devel 2014-03-25 10:38:59 -05:00
Alexander Winkler
03040a97c8 svr4pkg supports the -G switch for pkgadd 2014-03-25 09:03:48 +00:00
James Cammarata
d545b73ccb Merge branch 'file_fixes_agg' of https://github.com/bcoca/ansible into bcoca-file_fixes_agg 2014-03-24 16:38:35 -05:00
James Cammarata
a4af31e511 Revert "add yum module downgrade support"
This reverts commit cbd1da6457.
2014-03-24 12:27:32 -05:00
Robert Wehner
8a19d31391 Update 'validate=' parameter documentation to make clear that the command
passed via this paramter is not passed via shell and so all shell features
will not work.
2014-03-24 09:06:25 -06:00
bryan hunt
aa2d6e47f0 Accept status code from a list of valid codes.
(cast the list of acceptable codes to a list of int )
2014-03-24 14:23:18 +00:00
bryan hunt
9ff6c40ed0 Accept status code from a list of valid codes. 2014-03-24 14:17:36 +00:00
bryan hunt
5d51837921 Accept status code from a list of valid codes. 2014-03-24 13:51:44 +00:00
Seth Woodworth
c28d3545fb adds missing ' to debconf examples 2014-03-23 18:52:08 -04:00
Michael DeHaan
503327d53c Merge pull request #6640 from falloutdurham/ec2_count
ec2: Adding type int for count (in line with other cloud modules)
2014-03-23 16:24:11 -04:00
Michael DeHaan
ebc9ca9504 Merge pull request #6635 from pilou-/debconf
Fix ValueError when selection contains a colon
2014-03-23 16:19:54 -04:00
James Cammarata
3ea5d573aa Acclerate improvements
* Added capability to support multiple keys, so clients from different
  machines can connect to a single daemon instance
* Any activity on the daemon will cause the timeout to extend, so that the
  daemon must be idle for the full number of minutes before it will auto-
  shutdown
* Various other small fixes to remove some redundancy

Fixes #5171
2014-03-23 14:45:49 -05:00
Ian Pointer
bebb11afeb Adding type int for count (in line with other cloud modules) 2014-03-23 13:51:54 -04:00
Pierre-Louis Bonicoli
1bb5b0f6bd Fix ValueError when selection contains a colon 2014-03-23 03:35:10 +01:00
Max Riveiro
9114fd6d7a
Add rollbar_deployment module
Signed-off-by: Max Riveiro <kavu13@gmail.com>
2014-03-23 00:38:53 +04:00
David Fox
6b0ef5f10e Modified library/system/user so that password change date is set on Solaris when updating password 2014-03-22 15:12:56 -04:00
Brent Langston
ca14df4790 Make the default URI a constant 2014-03-22 13:56:49 -04:00
Brent Langston
712e114dff Allow custom hipchat urls 2014-03-21 23:22:05 -04:00
Colin Mattson
3e6bf9640c Clarify documentation for apt pkg, state, install_recommends 2014-03-21 13:52:36 -07:00
Michael DeHaan
50aa3f6a09 Fix documentation for twilio module. 2014-03-21 14:26:20 -04:00
willthames
c0ac615a07 Allow state=absent for ec2_vol
Add methods to the module to make it more readable and allow reuse
2014-03-21 22:10:55 +10:00
Maykel Moya
6a92d48b0f ec2_group: Document group_desc rule param 2014-03-21 08:35:25 +01:00
willthames
7272877df6 Allow npm to install to a directory that doesn't yet exist
If path is specified but does not exist, create it.
Fail if path is specified but is not a directory
2014-03-21 13:30:12 +10:00
James Tanner
ea5186ca63 Fixes #6590 add set_remote_user parameter to synchronize
This allows usage of custom ssh configs for remote hosts where
the inventory user does not match the configured user.
2014-03-20 13:56:07 -04:00
Michael DeHaan
c729bf209c Update documentation YAML syntax. 2014-03-20 13:22:19 -04:00
Maykel Moya
a429ff26dc ec2_group: Add documentation for rules_egress 2014-03-20 17:24:22 +01:00
Maykel Moya
b642e39e67 ec2_group: rules are not a required task argument 2014-03-20 17:24:22 +01:00
Maykel Moya
3156df9931 ec2_group: Request a fresh group object after creation
When a group is created, an egress_rule ALLOW ALL to 0.0.0.0/0 is added
automatically but it's not reflected in the object returned by the AWS API
call. After creation we re-read the group for getting an updated object.
2014-03-20 17:24:22 +01:00
Maykel Moya
649fcd3e1c ec2_group: Auto create missing groups referenced in rules
Suppose a pair of groups, A and B, depending on each other. One solution
for breaking the circular dependency at playbook level:

    - declare group A without dependencies
    - declare group B depending on A
    - declare group A depending on B

This patch breaks the dependency at module level. Whenever a depended-on
group is missing it's first created. This approach requires only two tasks:

    - declare group A depending on B (group B will be auto created)
    - declare group B depending on A

When creating a group EC2 requires you to pass the group description. In
order to fullfil this, rules now accept the `group_desc` param. Note
that group description can't be changed once the group is created so
it's nice to keep descriptions in sync.

Concrete example:

- ec2_group:
    name: mysql-client
    description: MySQL Client
    rules_egress:
      - proto: tcp
        from_port: 3306
        to_port: 3306
        group_name: mysql-server
        group_desc: MySQL Server

- ec2_group:
    name: mysql-server
    description: MySQL Server
    rules:
      - proto: tcp
        from_port: 3306
        to_port: 3306
        group_name: mysql-client
2014-03-20 17:24:17 +01:00
Maykel Moya
77d7165dde ec2_group: Deduplicate rule parsing/validation code 2014-03-20 16:19:35 +01:00
Maykel Moya
f97243d6ed ec2_group: Add support for handling egress rules 2014-03-20 15:50:08 +01:00
jjshoe
1f980b6880 assign_public_ip was actually added in 1.5
Checked 1.4.5 and this option doesn't exist. Will check/update/pull docs next.
2014-03-20 09:21:10 -05:00
Oleg Bulatov
3edd3862df Respect region_name in nova_compute
Signed-off-by: Oleg Bulatov <oleg@bulatov.me>
2014-03-20 17:07:49 +04:00
Steve Smith
e157355fd6 Only unlink the symlink tempfile on error if it was created in the
previous operation.
2014-03-20 13:14:24 +01:00
Michael DeHaan
2156e87e62 Update cpanm 2014-03-20 08:10:02 -04:00