Commit graph

37 commits

Author SHA1 Message Date
Carlos E. Garcia
4dcaa9d9fb multiple spelling error changes 2014-04-29 10:41:05 -04:00
Cristian Ciupitu
03eb65f25d Bugfix for gc_storage and s3
Make keysum return None if not key_check (this case wasn't covered).
2014-03-28 22:47:46 +02:00
Cristian Ciupitu
368e3c8310 Micro-optimization: replace s.find(x)!=-1 with x in s
timeit shows a speedup of ~3x on Python 2.7.5 x86_64.
It also makes the code a bit shorter.
2014-03-27 20:35:20 +02:00
Devon Crouse
c4004ae19b Fixed references to missing method in ec2 modules
Change-Id: I9b89d433b545269d111b3c290b6411aabf58dd24
2014-03-11 18:19:03 -06:00
James Cammarata
0b9b8abd6e Adding version_added field to metadata field in s3 module 2014-03-11 13:50:21 -05:00
Jake Kreider
72ea1de718 Updated S3 metadata examples 2014-03-11 13:50:21 -05:00
Jake Kreider
689c4fb0d6 Added metadata support to s3 module 2014-03-11 13:50:21 -05:00
James Cammarata
d45ee5a3d8 Fixing up some docstrings causing make webdocs to fail 2014-03-11 12:29:02 -05:00
jctanner
5d31c497f0 Merge pull request #5703 from ethercrow/fakes3
[s3] Compatibility with fakes3.
2014-03-11 11:48:21 -04:00
Scott Anderson
26e9c1ad61 Change standard AWS access and secret key parameter names to aws_access_key and aws_secret_key. Fixes an authentication problem with the rds module and standardizes the naming convention on something more encompassing than ec2_*_key. 2014-02-08 18:35:26 -05:00
Dmitry Ivanov
37dfa6b8d3 [s3] Compatibility with fakes3. 2014-01-21 17:31:22 +07:00
Justin Ludwig
bd9e6a74f7 Fix AWS credential params for s3 and other modules
The `ec2_ami`, `ec2_elb`, `ec2_tag`, `ec2_vpc`, `route53`, and `s3` modules
all canonicalize the AWS access and secret key params as
`aws_access_key` and `aws_secret_key`. However, following the fixes for #4540,
those modules now use `get_ec2_creds` from `lib/ansible/module_utils/ec2.py`,
which requires access/secret key params to be canonicalized as
`ec2_access_key` and `ec2_secret_key`. As a result, AWS credentials passed
to those six modules as parameters are ignored (they instead always use
the AWS credentials specified via environment variables, or nothing).

So this change fixes those six modules to canonicalize the
AWS access and secret key params as `ec2_access_key` and `ec2_secret_key`,
allowing them to again accept AWS credentials passed via module params.
2013-11-26 19:29:06 -08:00
James Tanner
d62812b8ee Change s3 module to use shared ec2 authorization module snippet 2013-11-12 14:13:05 -05:00
dragon3
15b6dad3e3 Remove duplicate "download_s3file" execution when the destination path doesn't exist 2013-11-05 22:03:40 +09:00
Lorin Hochstein
87055995b9 s3: better check for walrus
Check for Walrus endpoint by looking to see if the endpoint is not AWS.

This fixes a bug where the user specifies an AWS endpoint via S3_URL,
but the code interprets it as Walrus and then fails.
2013-10-16 13:22:41 -04:00
James Tanner
d03211cf6b Remove all sys.exit calls in the cloud/s3 module
Fixes #4458
2013-10-11 11:28:47 -04:00
Matthew Barrington
e16e77249f Fixed crash when s3 bucket did not exist for put operation 2013-10-11 16:01:54 +01:00
James Tanner
613b6a2473 #4408 s3: add force alias for overwrite and set True by default 2013-10-09 12:56:56 -04:00
James Tanner
7aa187b413 Remove debug comment from s3 module 2013-10-09 12:25:09 -04:00
James Tanner
4b4b9551d0 4006: return s3 url even if file exists 2013-10-09 12:12:24 -04:00
Michael DeHaan
50d72d89c2 Fix documentation of default value in s3 module. Fixes #4289 2013-10-08 08:42:03 -04:00
Benno Joy
325b65b8c6 change "Changed" to changed 2013-10-07 18:29:03 +05:30
bennojoy
78d1af3607 minor fixes 2013-10-02 13:27:54 +05:30
Jeremy Price
14f67a4bf7 dest in s3 module does not work with ~username notation for home directories. Wrapped dest definition in os.path.expanduser() which will return the expanded path in case of successful tilde expansion and otherwise the original value 2013-09-19 00:32:13 -04:00
Bruce Pennypacker
11470fea04 Rebase attempt
No idea if I'm rebasing properly or not.  This is my first attempt.
2013-08-20 15:14:16 -04:00
Michael DeHaan
35c58b5fc2 Merge pull request #3772 from lorin/s3-docpatch
Minor doc update to s3 & ec2 modules
2013-08-06 13:30:20 -07:00
Michael DeHaan
42eda799c8 Merge pull request #3709 from lwade/devel
S3folder
2013-08-06 13:01:43 -07:00
Lorin Hochstein
2281cb66a3 Minor doc update to s3 & ec2 modules
Adds some additional docs about the module parameters for s3
and ec2 modules.
2013-08-06 12:23:25 -04:00
Michael DeHaan
74679c1c87 Slight docs tweak and remove redundant sys.exit call 2013-08-03 14:25:27 -04:00
lwade
9128f9f313 Added ability to create virtual directories. 2013-07-31 11:51:57 +01:00
Peter Hall
0517a104e6 Adding getstr mode to download an object into a variable 2013-07-23 11:03:00 +10:00
lwade
99ac050a43 Rewritten s3 module to allow for additional modes of operation. 2013-07-04 15:55:06 +01:00
Jan-Piet Mens
3404a0fc16 DOCS: standardize on EXAMPLES (a.k.a. Docs-JumboPatch JetLag Edition)
Migrated all examples: in DOCUMENTATION=''' string to standalone EXAMPLES=''' string
  Added deprecation warning to moduledev.rst and remove deprecated example from it
  Fixed up a few typos and uppercased some acronyms.
  add consistency to how EXAMPLES are formatted
2013-06-15 20:54:25 +02:00
Michael DeHaan
901e73918a Doc standardization/style 2013-06-01 12:09:04 -04:00
Shahar Kedar
f1638c5eea Issue #3079: Initializing key_exists in case the S3 bucket does not exist 2013-05-31 16:37:37 +03:00
Ralph Tice
0866fa5405 amended s3 plugin to support 'dest' parameter to allow uploading to custom location 2013-05-02 14:27:12 -05:00
Michael DeHaan
cd97a4cb14 Allow modules to be categorized, and also sort them when generating the documentation. 2013-04-28 15:03:45 -04:00
Renamed from s3 (Browse further)