Commit graph

307 commits

Author SHA1 Message Date
Michael Scherer
2e7cd6e02a Port postgresql module to python3 (#4579)
Iteritems is no longer a dict method in Python3, replace it with
the six wrapper.
2016-08-31 08:08:12 -07:00
Michael Scherer
c091a3e9ac Fix mysql_user for python3 (#4576)
dict no longer have a iteritems method, it was replaced
by items. So we need to use six.

    Traceback (most recent call last):
      File \"/tmp/ansible_hjd7d65c/ansible_module_mysql_user.py\", line 587, in <module>
        main()
      File \"/tmp/ansible_hjd7d65c/ansible_module_mysql_user.py\", line 571, in main
        changed = user_add(cursor, user, host, host_all, password, encrypted, priv, module.check_mode)
      File \"/tmp/ansible_hjd7d65c/ansible_module_mysql_user.py\", line 239, in user_add
        for db_table, priv in new_priv.iteritems():
    AttributeError: 'dict' object has no attribute 'iteritems'
2016-08-31 08:07:32 -07:00
René Moser
a216ef210b mysql_db: use new exception handling, fixes build (#4373) 2016-08-10 12:35:01 +02:00
Saurabh Sharma
fcee7d08b3 error handling for importing non-existent db. Fixes ##2068 (#3617)
* error handling for importing non-existent db

* creating db on import state and suitable message on deleting db

* handling all possible cases when db exists/not-exists
2016-08-08 12:36:18 -07:00
Jiri Tyr
4cb16a0f66 Removing double definition in postgresql_user module (#3714)
This commit is removing double definition of variables in the
grant_privileges function of the postgresql_user module.
2016-05-24 14:47:50 +02:00
Michael Scherer
20342860ad Convert all databases modules to python3 and 2.4 syntax (#3688) 2016-05-18 07:07:21 -07:00
Rene Moser
051744f7b5 mysql_user: fix unresolved reference
L282, module is used but not passed into function. Replaced check_mode reference and used module instead since check_mode is also in module.
2016-05-02 18:42:31 +02:00
Rene Moser
9765a30179 mysql_variables: fix inconsistent params, fixes ubuntu 16.04 support
In the mysql_user module, login_host is defined as "localhost". Setting this to localhost also fixes Ubuntu 16.04 support.

To make it more consistent in the future, the params in all mysql modules should move to module utils. I'll take care.

Also fixed a few other things along.
2016-05-02 18:38:07 +02:00
Jeroen Geusebroek
766671f1e1 Allow an empty password when adding a new MySQL user. (#3445) 2016-04-19 10:44:52 +02:00
jjshoe
ea199ecac0 Give encoding examples (#3436) 2016-04-14 11:17:13 -04:00
hyperized
48fa3a5243 Set --quick to True by default and make it selectable (#3418)
As indicated by @jmainguy in eb1cb94380 (commitcomment-17077470), this will allow the user to set the option quick, which is True by default (as it was before).

This is in reference to: https://github.com/ansible/ansible-modules-core/pull/3402
2016-04-13 11:15:48 +02:00
hyperized
eb1cb94380 Add single_transaction and quick options to MySQL DB module (#3402) 2016-04-12 11:33:58 +02:00
Michael Scherer
738e62e449 Mark path as type='path', do not leak login_password by error (#3396) 2016-04-11 17:22:51 -04:00
Michael Scherer
a2c2a67170 Update the type of some arguments in mysql_db module (#3285)
login_password should not be logged, so mark it as 'no_log'
the others arguments are path to file, and so should be type='path',
which permit to remove the line handling '~' and shell variables.
2016-04-11 16:57:24 +02:00
Tom Paine
c790519048 Update mysql_db.py
* Update mysql_db.py

Resubmission of https://github.com/ansible/ansible-modules-core/pull/2961 in single commit.

* Update mysql_db.py
2016-04-11 07:46:39 +02:00
René Moser
b8d0f058f4 Merge pull request #2889 from towolf/add_check_mode_to_mysql_db
Add supports_check_mode=True to mysql_db module
2016-03-23 11:26:10 +01:00
Brian Coca
e26e3bc201 Merge pull request #3112 from Jmainguy/mysql_user_binlog
added sql_log_bin setting to disable binary logging as option
2016-03-21 11:23:51 -07:00
Matt Clay
518803c4d7 Add optional connect timeout to mysql* modules. 2016-03-10 13:06:39 -08:00
Kenny Gryp
d68c6c3de0 added sql_log_bin setting to disable binary logging as option 2016-03-02 14:38:00 -05:00
Matt Martz
c7845456a6 Various simple linting type cleanups on modules 2016-02-16 15:58:44 -06:00
Toshio Kuratomi
8d126bd877 password needs to be type str.
In 1.9 this was the default.  In 2.0.0 and 2.0.1 this doesn't get set.
2.1.0 will fix the default but we should fix this now.
2016-02-11 13:08:32 -08:00
Toshio Kuratomi
93d02189f6 Remove duplicate documentation fields 2016-01-28 09:24:20 -08:00
Tobias Wolf
3d606dd2b4 Add supports_check_mode=True to mysql_db module
The most important cases are state=present and state=absent.

Future work: import and dump could be simulated and hence checked.
2016-01-26 15:16:58 +01:00
Lee H
8e326e10ff - fix check_mode test to avoid errors
- correct test mode check to ensure it returns and doesnt apply changes
  (via jmainguy)
2016-01-14 12:08:25 -05:00
Brian Coca
0ef69d19eb Merge pull request #2764 from Jmainguy/mysql_user_ansi
add ansi support
2016-01-12 10:51:00 -05:00
Brian Coca
30559b71dd Merge pull request #2170 from mvdriel/fix-add-user-with-require-ssl
Fix add user with require ssl
2016-01-12 10:45:51 -05:00
Brian Coca
516aed0837 Merge pull request #2774 from koichirok/mysql_user-check_mode
Add check_mode support to mysql_user.
2016-01-11 18:50:38 -05:00
Brian Coca
dcb7169946 Merge pull request #2513 from joshrendek/patch-1
Fix quote on grants of more than one word
2016-01-11 18:13:10 -05:00
KIKUCHI Koichiro
76905bc345 Add check_mode support to mysql_user. 2016-01-07 15:23:13 +09:00
Mark van Driel
9da92bfba0 Fixed "invalid privileges string: set expected at most 1 arguments, got 2" 2016-01-06 11:53:06 +01:00
Jonathan Mainguy
aebbcd6955 add ansi support 2016-01-05 19:57:01 -05:00
Jonathan Mainguy
92ec54c9b3 Fix bad merge 2016-01-05 15:53:21 -05:00
Toshio Kuratomi
9366dfb63e mariadb isn't always the last elemen of the version string 2015-12-17 13:45:04 -08:00
Toshio Kuratomi
b4a3fdd493 Fix mysqldump usage of config_file 2015-12-17 11:35:44 -08:00
Toshio Kuratomi
16a3bdaa7d Account for mariadb versioning 2015-12-16 14:07:17 -08:00
Jonathan Mainguy
69d56c4d21 Unify all 3 mysql modules.
Use same connection method, use config_file, and add ssl support
2015-12-16 11:10:22 -05:00
Lee H
f3b2180e42 - add version_added as requested to host_all 2015-12-16 02:06:02 -05:00
Lee H
85a19c68bd - remove user_anonymous as the same thing can be accomplished by user='', but leave
in the examples for removing anonymous users
2015-12-16 02:03:30 -05:00
Lee H
9dd6cad224 - add example showing removal of anonymous user accounts 2015-12-14 11:46:32 -05:00
Lee H
b5d7becc29 Merge branch 'devel' into mysql_anon_user
Conflicts:
	database/mysql/mysql_user.py
2015-12-14 11:40:20 -05:00
Jonathan Mainguy
8e812164a4 Add Jmainguy as author, fix hash check 2015-12-11 21:48:15 -05:00
Derek Smith
aba519868f updated examples
added mysql 5.7 user password modification support with backwards compatibility

resolved mysql server version check and differences in user authentication management

explicitly state support for mysql_native_password type and no others. fixed some failing logic and updated samples

updated comment to actually match logic.

simplified conditionals and a little refactor
2015-12-11 21:48:12 -05:00
trevoro
c007cd7f9a adding password_hash support to mysql_user module
fixing user_add arguments error

fixing user_mod arguments error
2015-12-11 21:48:07 -05:00
Brian Coca
0b5555b62c Merge pull request #2365 from Jmainguy/mysql_docfix
Update documentation to reflect need for mysql client
2015-12-09 10:53:47 -05:00
Mark Theunissen
5599bfb07d Remove Mark Theunissen as maintainer 2015-12-08 19:09:50 +02:00
Mark van Driel
0890aab41b Fixes require ssl in combination with other privileges
Fixes require ssl in combination with grant option

Refactoring: code cleanup to make it easier to understand

Code rewritten inspired by @willthames

Added WITH GRANT OPTION as exception; when only REQUIRESSL and/or GRANT are specified we have to add USAGE
2015-11-26 16:09:03 +01:00
Josh Rendek
ccc06636d7 Fix quote on grants of more than one word
Fixed a quote location on the grants composed of more than one word. Current docs will raise an error with a invalid privilege command.
2015-11-22 23:09:15 -05:00
Lee Hardy
ee0412c8b4 Merge branch 'devel' into mysql_anon_user 2015-11-17 09:09:05 +00:00
Lee Hardy
2aeb188d81 - fix user_exists statement with host_all to use only username parameter 2015-11-04 16:37:18 +00:00
Brian Coca
d6c97bc880 Merge pull request #2381 from gregdek/devel
Module ownership changes
2015-11-02 19:00:21 -05:00