Nathaniel Case
53837c2ab0
Assorted nxos_bgp_* fixes ( #25080 )
...
* Simplify apply_key_map
* Fix nxapi
* Clean up get_value
* Fix missing non-values
* Add test for existing bgp_af case
* Fix small issues with bgp_neighbor_af
2017-05-30 14:11:15 -04:00
Pierre-Louis Bonicoli
69edd9e0bb
Avoid useless queries: use standard module hashlib
...
When an unchanged MD5-hashed password was used and passlib was
unavailable, an useless 'ALTER USER' query was executed.
Once this useless query avoided, the last 'SELECT' query becomes
useless too.
2017-05-30 10:55:49 -07:00
Pierre-Louis Bonicoli
f59f042bb0
postgresql_user: fix doc
...
See: https://www.postgresql.org/docs/current/static/sql-createrole.html
2017-05-30 10:55:49 -07:00
Dag Wieers
09ba70f7c4
stat: PEP8, imports, cosmetics ( #24653 )
...
- Make PEP8 compliant
- Ensure imports are specific
- Few cosmetic changes (sort lists, casing, punctuation)
2017-05-30 18:31:56 +01:00
Dag Wieers
8d962209f4
mod_utils/cloudengine: PEP8 compliancy ( #24659 )
...
- Make PEP8 compliant
2017-05-30 18:28:02 +01:00
Dag Wieers
b3b11fbce2
get_url: PEP8, imports, cosmetics ( #24676 )
...
- Make PEP8 compliant
- Ensure imports are specific
- Few cosmetic changes (sort lists, casing, punctuation)
2017-05-30 18:24:07 +01:00
Dag Wieers
630185cb20
ansible/executor: PEP8 compliancy ( #24695 )
...
- Make PEP8 compliant
2017-05-30 18:13:53 +01:00
Dag Wieers
51b595992b
ansible/utils/: PEP8 compliancy ( #24686 )
...
- Make PEP8 compliant
2017-05-30 18:09:44 +01:00
Ganesh Nalawade
d5ad3093d6
Add config_format note in junos_facts docs ( #25125 )
...
Fixes #24610
Add note to mention config_format value
dependency.
2017-05-30 22:39:09 +05:30
Ganesh Nalawade
44121352fe
Update requirements in junos module docs ( #25154 )
...
Fixes #24975
Update requirements section in junos
module docs
2017-05-30 22:37:48 +05:30
Trishna Guha
31c59ad5f9
nxos_portchannel fix and unit test ( #25019 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-05-30 21:22:24 +05:30
John R Barker
24fb567c40
MAX_FILE_SIZE_FOR_DIFF ( #25170 )
2017-05-30 16:18:13 +01:00
Brian Coca
5d572055b3
fixed script plugin
...
fixes #25130
2017-05-30 11:10:43 -04:00
Brian Coca
bc403934ef
properlly report plugin name
2017-05-30 11:10:43 -04:00
Sander Steffann
06f76a2741
Fix IndexError when junos_config contains multiple delete lines ( #25139 )
...
* Prevent IndexError when deleting multiple lines
The old code will raise `IndexError: list assignment index out of range` when deleting multiple lines because the indexes of the original and the copy get out of sync. Solved by deleting from the high indexes first so the lower ones remain stable.
* Don't load configuration if nothing to load
Instead of sending an empty candidate config (for example because the candidate only consisted of `delete` lines, and all of them were filtered out by `filter_delete_statements`) just return. JunOS seems to get confused by empty changes, and if the candidate config is empty then it's a no-op anyway.
2017-05-30 11:55:25 +05:30
Kei Nohguchi
6dd8a4cf78
openvswitch_bridge.py: Avoid runtime error with no external_ids ( #25128 )
...
This happens when there is external_ids configured on the existing
OvS bridge, though playbook doesn't.
2017-05-29 14:44:17 +02:00
Rene Moser
9cbae80c3b
cloudstack: fix pep8 cs_pod
2017-05-29 01:28:19 +02:00
Rene Moser
3ef37e88fe
cloudstack: fix pep8 cs_facts
2017-05-29 01:28:19 +02:00
Rene Moser
439f0beca5
cloudstack: fix pep8 cs_domain
2017-05-29 01:28:19 +02:00
Rene Moser
1778e23fad
cloudstack: fix pep8 cs_account
2017-05-29 01:28:19 +02:00
Rene Moser
e3f75227bc
cloudstack: fix pep8 cs_affinitygroup
2017-05-29 01:28:19 +02:00
Rene Moser
9fe3891d65
cloudstack: fix pep8 cs_cluster
2017-05-29 01:28:19 +02:00
Brian Coca
fd6302bcb8
only set ansible_host if i have data
2017-05-28 11:19:44 -04:00
Brian Coca
68936d0530
updated vbox docs
2017-05-28 11:14:03 -04:00
Brian Coca
21da284f5d
added ability to create vars from vbox properties
2017-05-28 10:55:50 -04:00
Brian Coca
5cd0074831
fixed virtualbox plugins, expanded docs
2017-05-28 10:37:18 -04:00
Brian Coca
46a3e6088b
fixed shared 'compose' method for inventory plugins
2017-05-28 10:37:06 -04:00
Brian Coca
e19109fb3d
made inventory plugins list to keep config order
2017-05-28 10:36:36 -04:00
Abhijeet Kasurde
757758cd1a
Remove redundant find_content_view method ( #24851 )
...
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2017-05-26 20:06:02 +01:00
Reilly Herrewig-Pope
723c8f06ab
Allow setting/unsetting BYPASSRLS Postgres role attribute ( #24625 )
...
* Allow setting/unsetting BYPASSRLS role attr
* Build valid role attrs against version
* Add integration tests
2017-05-26 12:56:42 -04:00
Esa Varemo
603366863f
Correct nmcli dns example and documentation. Fix example indent ( #20203 )
...
Fixes https://github.com/ansible/ansible-modules-extras/issues/1910
and https://github.com/ansible/ansible-modules-extras/issues/1843
2017-05-26 15:58:00 +01:00
Eric Workman
797259f757
Add monitor and failover support to DNSMadeEasy module ( #23434 )
...
* Add monitor and failover support to DNSMadeEasy module
* Fix pep8 and add version_added to new parameters
* Change versions and improve descriptions
2017-05-26 15:22:46 +01:00
John R Barker
3740ad2828
Minor fixes ( #25059 )
...
1) Examples: Remove double space between "option:" and "value"
2) Documentation: Fix rendering usses
3) Documentation: Remove `required: true` to match argspec
2017-05-26 15:17:08 +01:00
Evan Kaufman
ce584571e8
Fixed backup file behavior in check mode ( #24899 )
...
Fixes ansible/ansible#21523
2017-05-26 16:16:15 +02:00
Michael Eaton
8bfa19c4af
New module: Add module to manage Windows Firewall (windows/win_firewall) ( #23224 )
...
* added win_firewall module and updated to use list for profiles
* removed unnecessary cast and bug/typo in ForEach block
2017-05-26 09:26:48 -04:00
Damien
6dd1fc6f34
aos_login change default port and add version check ( #24752 )
...
* Change default port for aos_login and force type to Integer
* Add check to make sure aos-pyez is present and has the right version
* Update min version requirement in doc
* Change default port in documentation as well
2017-05-26 11:59:51 +01:00
tdtrask
8c50105a6c
New module: awall: add new module for alpine wall ( #24748 )
...
* awall: add new module for alpine wall
* awall: Fix is_policy_enabled bug when policy has description
2017-05-26 11:54:02 +01:00
Steven Bambling
330ad92425
New module: Add Sensu Silence module (monitoring/sensu_silence.py) ( #24332 )
...
* adding module to control management of sensu silence entries
* adding doc stanza
* fixing some issues
* more cleanup
* fixing defaults
* fixing more doc issues
* fixing examples
* more fixes
2017-05-26 11:49:52 +01:00
René Moser
d5b04aa1f1
cloudstack: add check mode tests ( #24908 )
...
* cloudstack: test: cs_network_acl: add check_mode tests
* cloudstack: test: cs_pod: add check_mode tests
* cloudstack: test: cs_user: add check_mode tests
* cloudstack: test: cs_sshkeypair: add check_mode tests
* cloudstack: test: cs_project: add check_mode tests
* cloudstack: test: cs_vpc: add check_mode tests
* cloudstack: test: cs_vpn_gateway: add check_mode tests
* cloudstack: test: cs_volume: add check_mode tests
* cloudstack: test: cs_vmsnapshot: add check_mode tests
* cloudstack: test: cs_account: add check_mode tests
* cloudstack: test: cs_affinitygroup: add check_mode tests
* cloudstack: test: cs_cluster: add check_mode tests
* cloudstack: test: cs_domain: add check_mode tests
* cloudstack: test: cs_instancegroup: add check_mode tests
* cloudstack: test: cs_iso: add check_mode tests
* cloudstack: test: cs_loadbalancer_rule: add check_mode tests
* cloudstack: test: cs_portforward: add check_mode tests
* cloudstack: test: cs_resourcelimit: add check_mode tests
* cloudstack: test: cs_securitygroup: add check_mode tests
* cloudstack: test: cs_securitygroup_rule: add check_mode tests
* cloudstack: test: cs_configuration: add check_mode tests
* cloudstack: test: cs_firewall: add check_mode tests
* cloudstack: test: cs_instance: add check_mode tests
* cloudstack: query current tags from API
Fixes unexpected tags returned in check mode.
2017-05-26 12:19:47 +02:00
Brendan Almonte
2af5556901
Added autoclean/autoremove for the apt module
...
- Removed alias autoclean from autoremove.
- Added independent execution of apt-get autoclean/autoremove
- Continued to support --auto-remove as a flag to install/remove
Fixes #22222 #24718
2017-05-25 14:18:20 -07:00
Robin Roth
8fca263560
Refactor zypper version parsing and handling ( #24056 )
...
Fixes #23516
2017-05-25 17:05:25 -04:00
Brian Coca
110fd917d6
adding caching to script plugin
2017-05-25 15:37:39 -04:00
Brian Coca
b8448fdb90
path cli options now resolve relative paths to cli
2017-05-25 14:29:27 -04:00
QijunPan
93ddfeb98a
Contributing lib/ansible/modules/network/cloudengine/ce_bgp_af.py module to manage HUAWEI data center CloudEngine ( #22031 )
...
* add cd_bgp_af module
add cd_bgp_af module
* fix review issues
2017-05-25 17:35:12 +01:00
QijunPan
e86279cee4
Contributing new /lib/ansible/plugins/action/ce.py module to manage HUAWEI data center CloudEngine switch ( #21645 )
...
* commit plugins action ce module
commit plugins action ce module
* update plugins/action/ce.py
update plugins/action/ce.py
* update action ce.py
update action ce.py
* fix CI issues
* update ce.py
* add ce action
2017-05-25 17:33:57 +01:00
QijunPan
e9f2c080f4
Contributing lib/ansible/modules/network/cloudengine/ce_mlag_config.py module to manage HUAWEI data center CloudEngine ( #22054 )
...
* add ce_mlag_config
add ce_mlag_config
* update ce_mlag_config
update ce_mlag_config
* fix CI issues
2017-05-25 17:31:53 +01:00
QijunPan
f89d12f26e
Contributing lib/ansible/modules/network/cloudengine/ce_link_status.py module to manage HUAWEI data center CloudEngine ( #22053 )
...
* add ce_link_status
add ce_link_status
* upgrade ce LinkStatus
* fix CI issues
2017-05-25 17:31:17 +01:00
QijunPan
1359d39f9a
Contributing lib/ansible/modules/network/cloudengine/ce_ip_interface.py module to manage HUAWEI data center CloudEngine ( #22052 )
...
* add ce_ip_interface
add ce_ip_interface
* fix CI issues
2017-05-25 17:30:42 +01:00
QijunPan
16bea773b8
Contributing lib/ansible/modules/network/cloudengine/ce_interface_ospf.py module to manage HUAWEI data center CloudEngine ( #22051 )
...
* add ce_interface_ospf
add ce_interface_ospf
* upgrade Interface OSPF
* fix CI issues
2017-05-25 17:30:10 +01:00
QijunPan
7c78a86338
Contributing lib/ansible/modules/network/cloudengine/ce_interface.py module to manage HUAWEI data center CloudEngine ( #22050 )
...
* add ce_interface
add ce_interface
* fix review issue
2017-05-25 17:28:54 +01:00
QijunPan
9aa58dd4ca
Contributing lib/ansible/modules/network/cloudengine/ce_info_center_log.py module to manage HUAWEI data center CloudEngine ( #22048 )
...
* add ce_info_center_log
add ce_info_center_log
* fix review issues
2017-05-25 17:28:05 +01:00
QijunPan
2e126edb91
Contributing lib/ansible/modules/network/cloudengine/ce_info_center_global.py module to manage HUAWEI data center CloudEngine ( #22047 )
...
* add ce_info_center_global
add ce_info_center_global
* fix review issue
2017-05-25 17:27:24 +01:00
QijunPan
2b9ac69692
Contributing lib/ansible/modules/network/cloudengine/ce_info_center_debug.py module to manage HUAWEI data center CloudEngine ( #22046 )
...
* add ce_info_center_debug
add ce_info_center_debug
* fix review issues
2017-05-25 17:26:52 +01:00
QijunPan
a137349522
Contributing lib/ansible/modules/network/cloudengine/ce_file_copy.py module to manage HUAWEI data center CloudEngine ( #22045 )
...
* add ce_file_copy
add ce_file_copy
* fix review issue
2017-05-25 17:26:11 +01:00
QijunPan
182d65d519
Contributing lib/ansible/modules/network/cloudengine/ce_evpn_bd_vni.py module to manage HUAWEI data center CloudEngine ( #22038 )
...
* add ce_evpn_bd_vni
add ce_evpn_bd_vni
* upgrade evpn bd vni
upgrade evpn bd vni
* fix review issue
2017-05-25 17:25:47 +01:00
Nathaniel Case
8985f7c930
nxos_static_route updates ( #24992 )
...
* Add static_route tests
* Add VRF tests
2017-05-25 12:19:04 -04:00
Abhijeet Kasurde
650b5fedb1
Handle None and Blank value for sysctl module ( #24871 )
...
Fix adds check for values provided by user for
name and value in sysctl module.
While providing name and value as in-line params,
check for blank values
Fixes #20176
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2017-05-25 11:49:20 -04:00
Brian Coca
7c325470e2
Pepe Ate
2017-05-25 11:38:53 -04:00
Brian Coca
f23920aa5e
optimize file finding
2017-05-25 11:38:53 -04:00
QijunPan
deeffc61d7
Contributing lib/ansible/modules/network/cloudengine/ce_dldp_interface.py module to manage HUAWEI data center CloudEngine ( #22036 )
...
* add ce_dldp_interface
add ce_dldp_interface
* fix review issues
2017-05-25 16:08:43 +01:00
QijunPan
645eb03eeb
Contributing lib/ansible/modules/network/cloudengine/ce_bgp_neighbor_af.py module to manage HUAWEI data center CloudEngine ( #22033 )
...
* add ce_bgp_neighbor_af
add ce_bgp_neighbor_af
* upgrade bgp neighbor af
upgrade bgp neighbor af
* fix review issues
2017-05-25 16:03:33 +01:00
QijunPan
d43fb67583
Contributing lib/ansible/modules/network/cloudengine/ce_bgp_neighbor.py module to manage HUAWEI data center CloudEngine ( #22032 )
...
* add ce_bgp_neighbor
add ce_bgp_neighbor
* fix review issues
2017-05-25 16:02:54 +01:00
Brian Coca
85c7a7b844
added new selinux fact to clarify python lib
...
the selinux fact is boolean false when the library is not installed,
a dictionary/hash otherwise, but this is ambigous
added new fact so we can eventually remove the type dichtomy and normalize it as a dict
2017-05-25 10:37:52 -04:00
Abhijeet Kasurde
211d0656f8
Misc Typo correction ( #25025 )
...
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2017-05-25 16:14:39 +02:00
Fabrizio Colonna
78fff751ab
Fixed issue idempotence issue on label an name. ( #23411 )
2017-05-25 16:12:25 +02:00
QijunPan
7df246cebb
Contributing lib/ansible/modules/network/cloudengine/ce_bgp.py module to manage HUAWEI data center CloudEngine ( #22030 )
...
* add ce_bgp module
add ce_bgp module
* upgrade ce bgp
upgrade ce bgp
* fix review issues
2017-05-25 14:51:26 +01:00
QijunPan
079590b589
Contributing lib/ansible/modules/network/cloudengine/ce_ospf_vrf.py module to manage HUAWEI data center CloudEngine ( #21881 )
...
* add ce_ospf_vrf module
add ce_ospf_vrf module
* update ce_ospf_vrf
update ce_ospf_vrf
* upgrade ospf vrf
* fix review issues
* fix CI issues
2017-05-25 14:49:29 +01:00
QijunPan
eaf23d2ec4
Contributing lib/ansible/modules/network/cloudengine/ce_mtu.py module to manage HUAWEI data center CloudEngine ( #21879 )
...
* add ce_mtu module
add ce_mtu module
* update ce_mtu
update ce_mtu
* fix review issues
2017-05-25 14:36:11 +01:00
QijunPan
a1578cc01a
Contributing lib/ansible/modules/network/cloudengine/ce_acl_advance.py module to manage HUAWEI data center CloudEngine ( #21877 )
...
* add ce_acl_advance module
add ce_acl_advance module
* update ce_acl_advance.py
* fix review issues
2017-05-25 14:33:59 +01:00
QijunPan
c0ef52cf40
Contributing lib/ansible/modules/network/cloudengine/ce_netstream_template.py module to manage HUAWEI data center CloudEngine ( #21818 )
...
* add ce_netstream_template
add ce_netstream_template
* update
* fix review issues
2017-05-25 14:29:19 +01:00
QijunPan
76b9c84cac
Contributing new lib/ansible/modules/network/cloudengine/ce_config.py module to manage HUAWEI data center CloudEngine switch ( #21667 )
...
* commit ce_config
commit ce_config
* update ce_config
update ce_config
* add module ce_config
add module ce_config
* update ce_config module
update ce_config module
* update ce_config
update ce_config
* fix CI issues
* fix review issues
* fix review issues
2017-05-25 14:01:50 +01:00
Trishna Guha
307fd1b3dc
nxos_vlan fix ( #24973 )
2017-05-25 09:45:43 +05:30
Will Thames
30fec68931
Expose variable_manager to PlayIterator
...
`variable_manager` is passed to the constructor of `PlayIterator`,
and then used to access the fact cache when fact gathering.
Make `_variable_manager` an attribute of the `PlayIterator` class
2017-05-24 21:59:13 -04:00
Benjamin Schwarze
5668c97850
enable su support for docker connection
2017-05-24 16:53:08 -07:00
louis
7363776174
fixes #19550 (docker_container with empty links list always restarts)
2017-05-24 16:14:10 -07:00
Konrad Klimaszewski
5f3c887c38
Docker does not output Status after pull anymore.
...
- Docker 1.12 on CemtoOS7 does not output status line anymore.
- Do not rely on Docker output to verify if the image was the latest.
2017-05-24 16:07:17 -07:00
Brendan Almonte
b820d024fc
Add alternative syntax for upgrading all installed packages via apt ( #25007 )
...
syntax: 'apt: name=* state=latest'
feature #24189
2017-05-24 16:04:38 -07:00
kkjang
5c43bd3bae
Cmp python3 compat ( #25008 )
...
* Use double-quotes for expect integration tests
* Cast user input to string for expect integration tests
* Remove usage of cmp() for python3 compatibility
- Add code smell test to look for cmp usage
- Fixes #24756
2017-05-24 15:59:59 -07:00
Konrad Klimaszewski
64f63a3cac
Properly handle Docker image comparison for published_ports defined as IP::PORT
...
- Published port defined as IP::PORT where parsed in expected.parameters
as 0.0.0.0::PORT leading to changed==True on every playbook run.
2017-05-24 15:55:30 -07:00
bengerman
5b39368108
use two-tuples rather than dicts to allow multiple aliases for the same target
2017-05-24 15:48:12 -07:00
Nikolay Murga
3610a2457f
Fixed #21464 - docker_network: TypeError with existing network ( #24266 )
...
Fixed #22530 - docker_network Failed but Overlay network created successfully on Docker swarm mode
2017-05-24 14:21:24 -07:00
bengerman
cb3026f769
rebuild docker containers if there are less ports exposed
2017-05-24 12:37:29 -07:00
Guillaume Coré
a5c70dc672
os_user: fix module undefined
...
module variable in the function is undefined. Pass it.
fix "NameError: name 'module' is not defined"
2017-05-24 12:26:53 -07:00
Brian Coca
a86878c425
fixes for insserv on SLES11
...
fixes #23700 , seems SLES11 has diff behaviour of insserv
these changes are compatible with debian/ubuntu.
2017-05-24 15:19:23 -04:00
bengerman
fab2dfd1c6
typo in security opts
2017-05-24 12:16:31 -07:00
Adrian Likins
ea3914f438
Show the ansible version if invoked with more than one -v ( #22091 )
...
* Show the ansible version if invoked with more than one -v
* use display.vv directly
2017-05-24 14:45:35 -04:00
Michael Sheinberg
272125023f
Add working_dir to docker_container ( #20044 ) ( #24977 )
...
* docker_container: add working_dir (fixes #20044 )
Added a working directory option that will get passed with the other
docker container parameters. This is optional and addresses feature
request #20044 .
2017-05-24 11:41:54 -07:00
Brian Coca
e558ec19cd
Solaris fact fix ( #24793 )
...
* ensure locale for solaris fact gathering
fixes issue with locale interfering with proper reading of decimals
fixes #24542
* fixed typoe
2017-05-24 14:31:38 -04:00
Brian Coca
1e1caaad06
docs update, use connection: local vs local_action
2017-05-24 14:09:25 -04:00
Tim Rupp
6ef022b034
Adds the bigip_snmp_trap module to Ansible ( #24848 )
...
This patch adds the bigip_snmp_trap module to Ansible to support managing
SNMP trap destinations on an F5 BIG-IP.
2017-05-24 12:57:30 -04:00
Brian Coca
40b222867f
ensure fullpaths on vars files ( #24990 )
...
fixes #24970
now correctly picks up group/host vars inside group/host named directories
2017-05-24 12:50:05 -04:00
tdtrask
0d761e4568
Add apk available and repository ( #24146 )
...
* apk: Allow update and upgrade in same task
* apk: Add repository option
* apk: Add available option
* apk: Add stdout and stderr output where possible
* apk: Add packages return with list of changed packages
2017-05-24 12:28:41 -04:00
Abhijeet Kasurde
625ee36e06
Make os_volume idempotent ( #24881 )
...
Fix adds idempotency while deleting volume in os_volume
module
Fixes #19619
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2017-05-24 18:16:23 +02:00
Damien
a611449cad
eos_user Add documentation and example to change password ( #24750 )
...
* Add doc for password
* Add example to change user password
* Add dot at the end of the doc for password
* Add disclaimer in documentation for password
* Correct provider option name in description
2017-05-24 21:27:50 +05:30
Brian Coca
0cde9489fb
removed unused import
2017-05-24 11:55:56 -04:00
Brian Coca
f2e4a90c93
clarified error messages
2017-05-24 11:55:56 -04:00
John R Barker
c158705c48
Fix pep8 issue
...
lib/ansible/plugins/vars/host_group_vars.py:74:41: E261 at least two spaces before inline comment
Caused by daef6f0911
2017-05-24 16:53:02 +01:00
Jiri Tyr
09e80a1306
Removing unecessary exception in jenkins_plugin ( #24968 )
2017-05-24 07:15:05 -07:00
Ganesh Nalawade
825d9df5ea
Add eos changes for Python3 ( #24600 )
...
* eos python3 changes
* changes to convert response from byte to text
* Add dellos6 python3 changes
Make `execute_command` arguments and its
return value complaint to PY3 changes
made in PR #24431
* Fix py3 prompt issue for invalid show command
* Fix review comments
* Add generic fix for error prompt in py3
* Fix CI issue
* Fix network_cli unit test failure
2017-05-24 19:40:38 +05:30
Brian Coca
daef6f0911
allow empty files in host/group_vars
...
also remove unused import
fixes #24963
2017-05-24 09:32:34 -04:00